GitLab

Also:
 * fixes drop-down buttons layout.
 * overlay for catching outside the menu clicks is implemented (mimics standard select control behavior).

BUG=chromium-os:18826
TEST=manual

Review URL: http://codereview.chromium.org/7550070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96147 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18897
TEST=Turn on accessibility on the OOBE screen by pressing Ctrl+Alt+z.  Continue to the update page.  Ensure that it's spoken.

Review URL: http://codereview.chromium.org/7606021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96146 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7605025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96145 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92267
TEST=Ran PhishingTermFeatureExtractor unittest under valgrind.

Review URL: http://codereview.chromium.org/7604022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96143 0039d316-1c4b-4281-b951-d872f2087c98

On Windows, when linking non-incrementally the functions that call the
CrOS-only code are dead-stripped so there's no error, but with incremental
linking the link fails.

BUG=92171
TEST=Links on all platforms


Review URL: http://codereview.chromium.org/7497040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96141 0039d316-1c4b-4281-b951-d872f2087c98

R=dmazzoni
BUG=chromium-os:14804
TEST=Press ctrl+alt+z on the OOBE screen to enable accessibility.  Continue to the Terms of service page.  Press tab to move focus to the DOM view.  Press shift + space + down to navigate the EULA.  Ensure that it's spoken.

Review URL: http://codereview.chromium.org/7609001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96136 0039d316-1c4b-4281-b951-d872f2087c98

Extracted
- ProfileImpl::spellcheck_host_ready
- ProfileImpl::spellcheck_host_
- ProfileImpl::spellcheck_host_metrics_
into newly created SpellCheckProfile.
This is a preparation for implementing SyncableService.

TEST=SpellCheckProfileTest.*
BUG=none


Review URL: http://codereview.chromium.org/7583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96135 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/7607012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96134 0039d316-1c4b-4281-b951-d872f2087c98

There are cases where Gaia authentication passed but login still fails, e.g. using a valid Google account that is not in whitelist. We want to reset Gaia UI with an error message when this happens.

BUG=chromium-os:18801
TEST=Verify fix for chromium-os:18801.


Review URL: http://codereview.chromium.org/7607019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96133 0039d316-1c4b-4281-b951-d872f2087c98

Manually unfreezes hosting window until WebUI OOBE/Login tab is rendered the first time to avoid the white screen when transitioning from boot splash.

This CL is based Oshima's r88345 and I have left a TODO to merge the logic.

BUG=chromium-os:18501
TEST=Verify fix for chromium-os:18501.


Review URL: http://codereview.chromium.org/7607011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96132 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92121
TEST=unit_tests --gtest_filter=FormStructureTest.*Autocompletetype*; browser_tests --gtest_filter=FormManagerTest.WebFormControlElementToFormFieldAutocompletetype


Review URL: http://codereview.chromium.org/7602006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96131 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppressions for leaks in ppapi::VarTracker.

BUG=92279
TEST=Valgrind bots go green.
TBR=brettw@chromium.org

Review URL: http://codereview.chromium.org/7606022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96130 0039d316-1c4b-4281-b951-d872f2087c98

Adds further suppressions for PhishingTermFeatureExtractorTest.

BUG=92267
TEST=Valgrind bots go green.
TBR=gcasto@chromium.org

Review URL: http://codereview.chromium.org/7604026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96129 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=rsleevi

Review URL: http://codereview.chromium.org/7590019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96128 0039d316-1c4b-4281-b951-d872f2087c98

views-desktop: Add the desktop-window as an observer for a widget when it gets added to the desktop.

This fixes sending keyboard events to the browser in views-desktop.

TBR=sky@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7604024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96126 0039d316-1c4b-4281-b951-d872f2087c98

A language from the accepted list was converted before being validated, but the unconverted version was returned.

BUG=90106

Review URL: http://codereview.chromium.org/7589002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96125 0039d316-1c4b-4281-b951-d872f2087c98

Check all injected mouse positions, not just the first one, to deal with
possibility that mouse-injection API might fail.

Also rename recent_remote_mouse_positions_ to injected_mouse_positions_ to
emphasize these are the events that were (attempted to be) injected into the
host.

BUG=None
TEST=Use buggy Mac client to send invalid mouse position to Linux host (move
mouse off-screen.


Review URL: http://codereview.chromium.org/7604007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96124 0039d316-1c4b-4281-b951-d872f2087c98

R=eroman@chromium.org
BUG=none
TEST=no compilation errors

Review URL: http://codereview.chromium.org/7497052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96123 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581


Review URL: http://codereview.chromium.org/7552026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96122 0039d316-1c4b-4281-b951-d872f2087c98

As of http://codereview.chromium.org/7471028, clang is used as
host compiler as well, so this check is no longer necessary. In
fact, it's harmful: In http://codereview.chromium.org/7550002 ,
a dependency on base is added on the host side, which doesn't
build with clang because e.g. -Wno-char-subscript isn't used,
which means base/third_party/dmg_fp/dtoa.cc doesn't build cleanly
in host compiler mode.

BUG=none
TEST=happy pkasting


Review URL: http://codereview.chromium.org/7606012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96121 0039d316-1c4b-4281-b951-d872f2087c98

LoadScriptContent outputs meaningful log when |path| is empty

BUG=None
TEST=compiles successfully

Review URL: http://codereview.chromium.org/7528021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96115 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92267
TEST=None

Review URL: http://codereview.chromium.org/7497053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96113 0039d316-1c4b-4281-b951-d872f2087c98

A fairly recent change introduced a history of page_ids for each RenderView, to validate that Navigation's go to legitimate pages.

In the prerender and instant cases, the history of page_id's was not accurate, because it was not offset to reflect the point in time when the page was swapped in. For example, if the history for the tab looks like

about:blank
http://www.launchprerender.com/
http://www.prerendered_page.com/first_page.html
http://www.prerendered_page.com/second_page.html

The history of page_id's in the prerender-page RenderView should look like

[-1, -1, 13, 14] - with the first two entries being -1 since they are not captured in this render view.

Before this fix, it would look like

[13, 14] - and when the back navigation was attempted, the length was not as long as expected.

BUG=89798
TEST=Go to prerender_test.appspot.com, do a prerender on dev.chromium.org, click on a link within dev.chromium.org, press back and see that it works instead of spinning forever. Also, browser_tests --gtest_filter=*BackToPrerenderedPage, which fails without the change.

Review URL: http://codereview.chromium.org/7491096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96109 0039d316-1c4b-4281-b951-d872f2087c98

GTTF: Use a fresh TestingBrowserProcess for each test, part #5

For a detailed description see part #1, http://codereview.chromium.org/6478005/

This CL fixes the bug fully on Windows. More platforms will follow.

BUG=61062
TEST=unit_tests, possibly more
Review URL: http://codereview.chromium.org/7601006

TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/7552029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96107 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Unittests.

Review URL: http://codereview.chromium.org/7508044

TBR=sergeyu@chromium.org
Review URL: http://codereview.chromium.org/7604021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/7604014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96105 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91371
TEST=none

Review URL: http://codereview.chromium.org/7605014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96104 0039d316-1c4b-4281-b951-d872f2087c98

A gyp file that generates a Visual studio solution for only certain targets and their transitive dependencies.

Review URL: http://codereview.chromium.org/7528011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96103 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
R=ncbray@google.com
Review URL: http://codereview.chromium.org/7552027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96101 0039d316-1c4b-4281-b951-d872f2087c98

standalone tarballs for V8.

This will be useful for Linux distributions packaging
shared library packages for V8.

BUG=none

Review URL: http://codereview.chromium.org/7600011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96099 0039d316-1c4b-4281-b951-d872f2087c98

For a detailed description see part #1, http://codereview.chromium.org/6478005/

This CL fixes the bug fully on Windows. More platforms will follow.

BUG=61062
TEST=unit_tests, possibly more
Review URL: http://codereview.chromium.org/7601006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96098 0039d316-1c4b-4281-b951-d872f2087c98

We've been seeing in the histograms that for some users, page feature
extraction is taking much longer than we would like, up to 200ms between
stops. This could possibly contribute to jankiness in the UI. These are some
timings from my desktop for how long it takes to extract features before and
after these changes. Obviously this is on much better hardware than the use case
we are worried about, but hopefully the increase is speed is proportional.

           Before  After
CNN        19       7.5    
ESPN       22       9.5
Google     12       4
Salon      40       12

BUG=
TEST=Ran associated unit tests.


Review URL: http://codereview.chromium.org/7549003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96097 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90214
TEST=PipelineImplTest.*

Review URL: http://codereview.chromium.org/7484054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96096 0039d316-1c4b-4281-b951-d872f2087c98

we don't need to rely on system SQLite being compiled
with specific flags.

BUG=22208

Review URL: http://codereview.chromium.org/7552022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96095 0039d316-1c4b-4281-b951-d872f2087c98

This replaces the var tracking in the proxy with the var tracking in the
shared_impl that's used by the implementation. It adds a new ProxyObjectVar
to be the proxied plugin analog of NPObjectVar in the impl. This new object
just keeps track of the host data.

The tricky part is to make the var tracker able to do all the crazy messaging.
This adds some virtual functions to the shared var tracker that we override
in the plugin in PluginVarTracker.

This removes the calls to the GetLiveObjectsForInstance in the var deprecated
test. It turns out this function really can't be implemented properly in the
proxy, and I don't know why it even worked before. A Release() call posts a
non-nestable task so the object isn't released until later. So to implement
the proxy for GetLiveObjectsForInstance we would also need to post a
non-nestable task. But when the test runs we're getting called from within
the plugin, so blocking on a non-nestable task deadlocks. So I just gave up
and deleted the parts of the test that uses it.

TEST=included
BUG=none
Review URL: http://codereview.chromium.org/7578001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96094 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/7529047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68657
TEST=ExtensionServiceTest.ClearExtensionData

Review URL: http://codereview.chromium.org/7550020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96092 0039d316-1c4b-4281-b951-d872f2087c98

Trimmed some #includes and cleaned up some comments as well, but avoided functional changes.

Review URL: http://codereview.chromium.org/7493030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96091 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/7584013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Unittests.

Review URL: http://codereview.chromium.org/7508044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96089 0039d316-1c4b-4281-b951-d872f2087c98