GitLab

BUG=646165

Review-Url: https://codereview.chromium.org/2341903002
Cr-Commit-Position: refs/heads/master@{#418742}

The "close all incognito tabs" notification can close tabs when chrome
is not in the foreground. This action bypasses the animation that
would ordinarily reset the normal button's opacity. In order to
correctly reset this opacity, setIsIncognito will be called even if
the button is not visible.

BUG=642682

Review-Url: https://codereview.chromium.org/2335403004
Cr-Commit-Position: refs/heads/master@{#418741}

BUG=584574

Review-Url: https://codereview.chromium.org/2333893002
Cr-Commit-Position: refs/heads/master@{#418740}

BUG=

Review-Url: https://codereview.chromium.org/2325623003
Cr-Commit-Position: refs/heads/master@{#418739}

BUG=chromium:646199

Review-Url: https://codereview.chromium.org/2340583004
Cr-Commit-Position: refs/heads/master@{#418738}

Will switch to gce bot if nothing regresses.

BUG=

Review-Url: https://codereview.chromium.org/2338353002
Cr-Commit-Position: refs/heads/master@{#418737}

The PropertyTreeState does not include scroll information and should
be renamed GeometryPropertyTreeState to reflect the real behavior.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2338373004
Cr-Commit-Position: refs/heads/master@{#418736}

mplement SharedModelTypeProcessor::GetAllNodes for USS, so
"Sync Node Browser" tab in chrome://sync-internals/ will show
USS data.
BTW, modelTypeWorker already ignore the root folder from
server.

BUG=645303

Review-Url: https://codereview.chromium.org/2319973003
Cr-Commit-Position: refs/heads/master@{#418735}

Minor cleanup after https://crrev.com/2217173002 to reduce code divergence.

BUG=488484

Review-Url: https://codereview.chromium.org/2344613002
Cr-Commit-Position: refs/heads/master@{#418734}

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove ChromeSyncExtensionFunctions from:
- launcher_search_provider
- hotword_private
- i18n
- identity
- omnibox

BUG=634140

Review-Url: https://codereview.chromium.org/2344653002
Cr-Commit-Position: refs/heads/master@{#418733}

This also removes the native hostname checking workarounds.

BUG=570909,588789,621684

Review-Url: https://codereview.chromium.org/2101303005
Cr-Commit-Position: refs/heads/master@{#418732}

Avoid Shell and PowerStatus access for display/power options.

BUG=646558,548429,644348
TEST=No crash accessing chrome://settings in chrome --mash.
R=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2341783005
Cr-Commit-Position: refs/heads/master@{#418731}

Adds new color for the launch button and changes star assets to match.
Also changes to the new Play logo.

BUG=646929

Review-Url: https://codereview.chromium.org/2335153003
Cr-Commit-Position: refs/heads/master@{#418730}

This CL changes the extensions build to have BUILD.gn's in (almost) all
leaf directories. This accomplishes several things,

a.) Makes it very clear of what files belong to which component/API. For
example, to see which files exist in the audio API, one needs to parse
the massive single //extensions/browsers/BUILD.gn to find the main API
source list, then look if any of the exception conditions (is_chromeos,
is_linux, etc) also contain any of the audio API files. This is now all
in one //extensions/browser/api/audio/BUILD.gn, making it easier to parse
and understand the build of each component.

b.) It makes dependencies clearer. Currently we have no idea which
dependency in the huge dependency list in //extensions/browser/BUILD.gn is
needed by which API. With individual build files, we can now specify
dependencies for just the component that needs them. This CL tries to
do this but some dependencies are used by enough components that we've just
included them for all (//content/browser/public, //skia). This is not ideal
but at worst, it is still much better than the current build.

Since we're now moving APIs over from //chrome/browser/extensions over to
//extensions/browser, this becomes even more important. All APIs that get
moved over now can use this new format for their build files.

jamescook@, rockot@, xiyuan@ - FYI

R=rdevlin.cronin@chromium.org
BUG=641155

Review-Url: https://codereview.chromium.org/2336843002
Cr-Commit-Position: refs/heads/master@{#418729}

Review-Url: https://codereview.chromium.org/2347433003
Cr-Commit-Position: refs/heads/master@{#418728}

TEST=Actually use the feature.
     Turn on "Don't keep activities", leave a CCT, click on
     it from recents.  See that your final page is visible.
BUG=606513

Review-Url: https://codereview.chromium.org/2336413002
Cr-Commit-Position: refs/heads/master@{#418727}

This class was supposed to delete when AddToHomescreenManager was introduced
(https://codereview.chromium.org/2292133003/), but wasn't. Delete it now.

Review-Url: https://codereview.chromium.org/2343433003
Cr-Commit-Position: refs/heads/master@{#418726}

InstallEvent interface was introduced only for ForeignFetch.
https://github.com/w3c/ServiceWorker/commit/98843d032cd668cda4c7e46f0e44245840cb5d4e
But according to the spec we should use InstallEvent interface for install event.
https://w3c.github.io/ServiceWorker/#execution-context-events

So we will use InstallEvent interface even if ForeignFetch feature is disabled.

BUG=

Review-Url: https://codereview.chromium.org/2339083002
Cr-Commit-Position: refs/heads/master@{#418725}

I haven't worked with audio in a while and am now missing enough context
that I shouldn't be on the owners files. Removing myself.

Need stevenjb's lgtm for removing me from //chromeos/dbus/OWNERS.

R=jennyz@chromium.org, stevenjb@chromium.org
BUG=None.

Review-Url: https://codereview.chromium.org/2338263003
Cr-Commit-Position: refs/heads/master@{#418724}

Move aura window properties to WmWindowAura.
(towards supporting [Shelf]WindowWatcher in mash)

Cleanup ShelfItem and ShelfItemDetails structs.
Remove unused ash support for UserManagerView

BUG=634150
TEST=Automated tests; no shelf functionality changes.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2332393003
Cr-Commit-Position: refs/heads/master@{#418723}

The document mode migration code was changed in
4804efe6
to skip document mode migration if a shared preference was not set.
On older versions of Chrome, that shared preference wasn't set
even though the user was in document mode. Migration was skipped and
all tabs were lost.

Revert to the old logic of using another shared preference to help
determine if the user is in document mode.

BUG=646146

Review-Url: https://codereview.chromium.org/2340743004
Cr-Commit-Position: refs/heads/master@{#418722}

This depends on https://chromium-review.googlesource.com/#/c/384594/

BUG=b:31254747
TEST=manually confirmed that the method is actually called

Review-Url: https://codereview.chromium.org/2332153002
Cr-Commit-Position: refs/heads/master@{#418721}

This CL fixes the bug in which the media router dialog would sometimes fail to show on OSX.

We make MediaRouterDialogDelegate::GetDialogSize() set the dialog size the first time it's called by WebDialogConstrainedWindowSheet::updateSheetPosition(), so that the custom window is not initialized with size 0.

BUG=633403

Review-Url: https://codereview.chromium.org/2275413002
Cr-Commit-Position: refs/heads/master@{#418720}

R=asvitkine@chromium.org, rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2342663003
Cr-Commit-Position: refs/heads/master@{#418719}

This CL also adds more logging in update_w3c_test_expectations.py, and changes deps_updater.py to run this script with the --verbose flag.

Purpose of this CL:
 1. Make it easier to diagnose issues with w3c-test-autoroller in the future.
 2. Start to make update-w3c-test-expectations better to use directly.

BUG=643761

Review-Url: https://codereview.chromium.org/2337183002
Cr-Commit-Position: refs/heads/master@{#418718}

Introduces a new content::AssociatedInterfaceRegistry and
content::AssociatedInterfaceProvider to serve as Channel-associated
interface counterparts to their shell namesakes.

RenderFrameHost and RenderFrame each have both of these things on them,
and they're routed to the other side using a new RouteProvider interface
buried in RenderProcessHostImpl / ChildThreadImpl on either end.

Also adds a WebContentsInterfaceRegistry to every WebContents,
and a helper WebContentsFrameBindingSet<T> to allow consumers to
very easily manage the lifetime of associated interface bindings
for each frame in a WebContents.

See the follow-up patch for example usage.

Part a series of CLs to enable and demonstrate WebContents associated
interfaces:

  1. https://codereview.chromium.org/2309513002
  2. https://codereview.chromium.org/2316963005
  3. This CL
  4. https://codereview.chromium.org/2310583002

BUG=612500
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2310563002
Cr-Commit-Position: refs/heads/master@{#418717}

Add initial unit tests for chromeos::PowerManagerClient's
suspend-delay-handling code. More coming soon.

BUG=646912

Review-Url: https://codereview.chromium.org/2345593002
Cr-Commit-Position: refs/heads/master@{#418716}

This is to get feedback from canary users.  It will be reverted on 2016-09-16.

BUG=624074

Review-Url: https://codereview.chromium.org/2335363003
Cr-Commit-Position: refs/heads/master@{#418715}

Revert of BackgroundGradientView: -drawBackground: → -drawRect: (patchset #2 id:40001 of https://codereview.chromium.org/2336453002/ )

Reason for revert:
AnimatableView inherits from BackgroundGradientView, so a number of
other views which *don't* want backgrounds end up inheriting from
BackgroundGradientView. This widened the scope of the change beyond what
I intended.

Original issue's description:
> BackgroundGradientView: -drawBackground: → -drawRect:
>
> BackgroundGradientView had a -drawBackground: method that its clients
> were expected to call. This change moves background drawing to
> -drawRect: so that the it happens by default.
>
> Subclasses that did custom drawing already override -drawRect:, but this
> removes a couple of overrides that just forwarded to -drawBackground:.
>
> BUG=589943
>
> Committed: https://crrev.com/6b1939a26d2839136aeeba2aa0e359fce0c20281
> Cr-Commit-Position: refs/heads/master@{#418358}

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=647018

Review-Url: https://codereview.chromium.org/2339143003
Cr-Commit-Position: refs/heads/master@{#418714}

Add a bool argument in FilterData() to signal that upstream's eof has been
reached.

R=rdsmith@chromium.org

BUG=474859

Review-Url: https://codereview.chromium.org/2331193005
Cr-Commit-Position: refs/heads/master@{#418713}

BUG=631262

Review-Url: https://codereview.chromium.org/2346623002
Cr-Commit-Position: refs/heads/master@{#418712}

BUG=626321

Review-Url: https://codereview.chromium.org/2301323003
Cr-Commit-Position: refs/heads/master@{#418711}

BUG=

Review-Url: https://codereview.chromium.org/2332393005
Cr-Commit-Position: refs/heads/master@{#418710}

BUG=642380

Review-Url: https://codereview.chromium.org/2337063003
Cr-Commit-Position: refs/heads/master@{#418709}

This is a step towards removing SidebarTreeElement, and moving
all tree outlines into shadow dom.

BUG=none

Review-Url: https://codereview.chromium.org/2335983002
Cr-Commit-Position: refs/heads/master@{#418708}

In 0.5 client, it's done in BlimpClientSession, which broadcasts
connection events, assignment result to the Java layer.

1. This CL port these functionalities to native code, in
core/session/connection_status. ConnectionStatus will cache engine info
and broadcast network events to other components in Blimp.

2. Also use delegate pattern to decouple the settings JNI bridge and
BlimpClientContextImpl.

3. Some utilities functions prepared for error messages handling in UI.

BUG=624451, 646655

Review-Url: https://codereview.chromium.org/2322843002
Cr-Commit-Position: refs/heads/master@{#418707}

and have it in arc::ArcIntentHelperBridge.

BUG=b:29079617, b:31406784
TEST=try, ARC still loads activity icons

Review-Url: https://codereview.chromium.org/2337193005
Cr-Commit-Position: refs/heads/master@{#418706}

Implement WebM subsample support according to the specification at http://wiki.webmproject.org/encryption/webm-subsample-encryption.

BUG=630344

Review-Url: https://codereview.chromium.org/2174533002
Cr-Commit-Position: refs/heads/master@{#418705}

The CSS Transitions specification recently added a section specifying how timing
functions should be serialized:
https://hg.csswg.org/drafts/rev/12d32649a91f
https://drafts.csswg.org/css-transitions/#serializing-a-timing-function

This patch changes how step timing functions are serialized in order to bring it
in line with the spec. The corresponding parsing function devtools/front_end is
also updated.

The removal of "step-middle" and "steps(x, middle)" as valid values is deferred
until frames() is implemented (see crbug.com/646265).

BUG=631875,600248

Review-Url: https://codereview.chromium.org/2330283004
Cr-Commit-Position: refs/heads/master@{#418704}

This will otherwise cause assertion failures on many pages.

We could also compute this in ng code during margin collapsing and just set it
on the old object, but I'm not sure that would be worth it.

This and https://codereview.chromium.org/2337763005/ fixes most (but not all)
of the assertion failures during legacy/ng interop.

R=ikilpatrick@chromium.org,eae@chromium.org,glebl@chromium.org
BUG=635619

Review-Url: https://codereview.chromium.org/2340113003
Cr-Commit-Position: refs/heads/master@{#418703}