- 13 May, 2019 40 commits
-
-
jonross authored
We have identified a slightly larger set of tests which we would like skia_renderer_content_browsertests to run. This increases the list from 4 tests to 20. With the runtime of the suite increasing from 6.6s to 9.6s TEST=skia_renderer_content_browsertests Bug: 956140 Change-Id: Iac40ecdc8104a8b8c03d50fba80c0641288e0c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605161Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#659245}
-
Alexei Filippov authored
This reverts commit 310bb105. Reason for revert: Broke build https://ci.chromium.org/p/chromium/builders/ci/Android%20Release%20%28Nexus%205X%29/19635 Original change's description: > Progress on the Revamped context menu > > This CL consists of: > - Improvements for URL formatting (i18n and emphasizing) > - Addition of grey background while loading > - Addition of favicons, monograms, and thumbnails > - Addition of checkered pattern behind the transparent PNGs > - Some visual polish and fixes > > Bug: 655359 > Change-Id: I6ebf13b6097780db22c05804f2b9cdf6d1ee8461 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595114 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Sinan Sahin <sinansahin@google.com> > Cr-Commit-Position: refs/heads/master@{#659233} TBR=twellington@chromium.org,sinansahin@google.com Change-Id: I8f9de27b1749a19e650dc3339b4de2fc2a996039 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 655359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611079Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#659244}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4894cb22..cbffd54f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iae123c0e8b47b31ff3a196c65a393f23580406c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609671Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659243}
-
John Budorick authored
Fails to compile. Bug: 962650,790202 Change-Id: Id515d645a8d701a3d495c41a170a5272a689c4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610259 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#659242}
-
Adam Langley authored
This change updates a couple of strings in the reset process to match suggestions from UX team. TBR=dbeam@chromium.org Bug: 960766 Change-Id: I6c908f31e5241725de936724480dbac864f3132c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610575 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#659241}
-
Frank Tang authored
Roll ICU to e3d32ff from 3a162e7 https://chromium.googlesource.com/chromium/deps/icu.git/+log/3a162e7..e3d32ff Testing code in https://chromium-review.googlesource.com/c/v8/v8/+/1601370 To test, in v8, after build debug, run tools/run-tests.py --outdir=out/x64.debug unittests/DateCache.AdoptDefaultMixed Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Test: v8 unittests - DateCache:AdoptDefault* Bug: chromium:950851 Change-Id: Ia540496882f4eca408706c86199904ebb0f74336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607506Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#659240}
-
Tim Song authored
This is a reland of 42b45514 Original change's description: > Notifications: Delay closing out of workarea bounds pop-ups. > > When the pop-up is expanded to show inline settings, the new height can overflow > the work area. Deleting the pop-up in this scenario triggers a crash as we're > still in the same call stack. > > BUG=957033 > > Change-Id: Ie8d4db393893b662b72f9c04317f9ca640a25607 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600155 > Commit-Queue: Tim Song <tengs@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658793} Bug: 957033 Change-Id: Id9209d2a648b234f933dbbf9de908a193b4b61df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609665Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#659239}
-
Raymond Toy authored
No functional changes. Bug: 960587 Change-Id: I2a6d00cde5bd1da04c126848733f6abb160367e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601326Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#659238}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8ef6d1fe29cc..628604eefdb9 git log 8ef6d1fe29cc..628604eefdb9 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 hliatis@google.com Implement vk_android_native_buffer (basic) Created with: gclient setdep -r src/third_party/swiftshader@628604eefdb9 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/122837237 TBR=swiftshader-team+autoroll@google.com Change-Id: I170b7a13d5fd9dd59b2dd70e40ed09f49ca7b35c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610342Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659237}
-
Alexei Filippov authored
This reverts commit 4f6f29a2. Reason for revert: Speculative revert for possibly breaking BookmarkBubbleViewTest.SyncPromoNotSignedIn https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/33302?blamelist=1 Original change's description: > Native Theme support for System Tray Focus Rings > -> Set Native Theme for UnifiedSystemTrayView > -> Remove hardcoded transparency for all focus rings > -> Add transparency to default focus border color in common theme > > Bug: 948959 > Change-Id: Ia4ee4315a894623ca9e5c20944972ce29714e2c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597114 > Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> > Reviewed-by: Tim Song <tengs@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658705} TBR=sky@chromium.org,tengs@chromium.org,beccahughes@chromium.org,amehfooz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 948959 Change-Id: I9c42c2c959cdaa63fcad61719e62a2036a905086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610860Reviewed-by:
-
shrekshao authored
Bug: 962555, 962636 Change-Id: I959445bef4bbc94f8e8b96c813205a49ab59419f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610606Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#659235}
-
Alexei Filippov authored
This reverts commit 7e9793c1. Reason for revert: Likely caused a test break on ASAN AccessibilityWinBrowserTest.TestPutAccValueInEditable https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8913554617299105712/+/steps/content_browsertests_on_Windows-10-15063/0/logs/Deterministic_failure:_AccessibilityWinBrowserTest.TestPutAccValueInEditable__status_CRASH_/0 Original change's description: > Refactor to handle ignored nodes that pass into the browser AX tree > > * Introduces the concept of "in the tree" vs "ignored" in Blink without > changing the actual behavior. No ignored nodes are sent to the browser > accessibility tree. > * Adds new function IsIgnoredPassThrough, for use when an object is > ignored, but should be passed through to the browser-side anyways. > This will be used to allow different types of ignored nodes to pass > through, instead of all at once. > * Refactors browser-side code to walk only the unignored tree. > > Bug:651614 > > Change-Id: Idbd85949a8505f8a03a08e3e002bb893619d6757 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535171 > Commit-Queue: Jacques Newman <janewman@microsoft.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#659089} TBR=dmazzoni@chromium.org,kinuko@chromium.org,dtseng@chromium.org,aboxhall@chromium.org,mrobinson@igalia.com,kbabbitt@microsoft.com,janewman@microsoft.com Change-Id: I1683253edf6af1498a805482eb9479a055d51af4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 651614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610026Reviewed-by:
-
Sinan Sahin authored
This CL consists of: - Improvements for URL formatting (i18n and emphasizing) - Addition of grey background while loading - Addition of favicons, monograms, and thumbnails - Addition of checkered pattern behind the transparent PNGs - Some visual polish and fixes Bug: 655359 Change-Id: I6ebf13b6097780db22c05804f2b9cdf6d1ee8461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595114Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#659233}
-
Peter Kasting authored
Bug: 957260 Change-Id: Ie4200dbd0916044bee1f9cd177eeb38812f5dba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594234 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#659232}
-
Mounir Lamouri authored
This is improving the mojo design to have a mojo interface on which the client can send request and observe. Bug: 919860 Change-Id: I26dccb64009c1544ecc091d2532b53ce57fd3e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547060 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#659231}
-
Wez authored
//skia/test_fonts' Fuchsia implementation makes use of the fuchsia.fonts io and sys libraries, so should depend on all of them. TBR=borenet Bug: 952652 Change-Id: I1bd2dff61a9029069e640390435b3c86d62efa54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610697 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Eric Boren <borenet@chromium.org> Cr-Commit-Position: refs/heads/master@{#659230}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7a3d1fb7569a..417f2332fcf4 git log 7a3d1fb7569a..417f2332fcf4 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/depot_tools@417f2332fcf4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Icda62c83e67de596f70a7912e8032f0fdb51bae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610341Reviewed-by:
-
Marcin Wiącek authored
* adding _MS to constants names * sorting constants names * removing constants names with value 0 * removing one unnecessary parameter in one of functions Change-Id: I86fbf202bb3c128bf8427478ba035f7543946016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607801Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#659228}
-
Alex Cooper authored
Change-Id: Ie519c2a70970a52b3f8b734c112eed7d2c346245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610576Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#659227}
-
Caitlin Fischer authored
Currently, profiles are passed once to Create() and once to GetLabels(). This is problematic because certain formatters, e.g. AddressContactFormLabelFormatters, are created specifically for the profiles passed to Create(), and the profiles could potentially change between the calls to Create() and GetLabels(). Now, LabelFormatters store a constant reference to a collection of profiles to ensure that the LabelFormatter and the labels it creates are guaranteed to be made for the same profiles. Bug: 958333 Change-Id: I242e3a24483afa614ea8256182d57b376abcdec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598492 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#659226}
-
Victor Costan authored
Our largest SQLite patch, 0001-Virtual-table-supporting-recovery-of-corrupted-datab.patch, contains the implementation of a virtual table extension that contains custom recovery logic. The automated tests for the extension use SQLite's infrastructure base on Tcl, and don't run on CQ. This CL rewrites the tests to use C++ and //sql, so they can be run on CQ. A follow-up CL will replace the recovery code with a rewritten version that lives in the Chromium tree. This CL also adds a test covering the edge cases of the recovery code's SQLite varint decoding logic, which has proven useful for debugging the rewritten recovery code. Bug: 945204 Change-Id: I50c6cbf6f94dc698915e6fb4925769051396cb4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603604Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#659225}
-
Marcin Wiącek authored
CL is deleting unused interpolators in Stack.java and moving more interpolators for sharing into CompositorAnimator.java Change-Id: I081039763d64d618809ad7066eb83c2021220e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594725Reviewed-by:
-
Robert Sesek authored
Previously the app_mode_loader was packaged into a .app bundle. But because the Info.plist is modified as part of creating app shim shortcuts, only the executable was code signed. This left the Info.plist as an un-sealed resource. Under stricter code signing verification rules required for macOS notarization, an .app bundle cannot have an un-sealed Info.plist. To work around this, place the un-bundled executable in the Framework's Helpers directory and store the Info.plist file under Resources. When building app shims at runtime, the .app bundle structure will be created manually (rather than copying the whole pre-built bundle). Created app shims will still not be validly signed .app bundles, but the components carried within Chrome will pass validation. Test: Browser menu > More tools > Create shortcut creates an app shortcut that launches. Bug: 960886, 850199 Change-Id: Ia4521ee436bc3288084004e247fd9765fb93816a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609886Reviewed-by:Nico Weber <thakis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#659223}
-
Alexei Filippov authored
This reverts commit 391dff3d. Reason for revert: Broke build https://ci.chromium.org/p/chrome/builders/ci/win-google-rel/3737 Original change's description: > Create source sets for tests in chrome/browser/conflicts > > This solves a filename collision that happens when moving all the files > in chrome/browser/conflicts to chrome/browser/win/conflicts because > module_info_win_unittest.cc becomes module_info_unittest.cc, and this > file already exists at > chrome/browser/install_verification/win/module_info_unittest.cc > > Change-Id: Id269f582259ac8e53a8a5aa64a61f4232ad732ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593894 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659186} TBR=sky@chromium.org,pmonette@chromium.org Change-Id: Iac5e9ba70ca8f15625b366374aeeaf24188d5d19 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609719Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d696f8e6bca3..2b8b06e79309 git log d696f8e6bca3..2b8b06e79309 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 mtklein@google.com rewrite docs to explicitly use python2 2019-05-13 brianosman@google.com Interpreter: Fix bool literals 2019-05-13 bsalomon@google.com Blacklikst AsyncReadPixels on MoltenVK Created with: gclient setdep -r src/third_party/skia@2b8b06e79309 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I6abb1087c55167819f0c77a943b5b5087f2f07cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610740Reviewed-by:
-
Matthew Jones authored
Bug: 958469 Change-Id: I88129f30f187636de500a34583fe002b44352b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592521 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Alexei Filippov authored
This reverts commit 192ccc29. Reason for revert: Needed to revert https://chromium-review.googlesource.com/c/chromium/src/+/1593894 that broke the build Original change's description: > Move chrome/browser/conflicts to chrome/browser/win/conflicts > > This allow us to remove all the _win suffixes to every files in the > directory. > > This CL contains no functional change. In addition to the directory > move, I only fixed file names (removing the _win suffix) and formatted > the resulting CL. > > Change-Id: I2158afd065fe81cb5350711653359983d9b790e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593724 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659208} TBR=sky@chromium.org,pmonette@chromium.org,wfh@chromium.org Change-Id: I5b74a56f2dc3e0601cd684a2a2abe6c157fea52c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610590Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a69e8c1681da..58d7304e63dc Created with: gclient setdep -r src-internal@58d7304e63dc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,battre@google.com Change-Id: I0ad3e167f8428e437edeba621a620f08bc35bb24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610837Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659218}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a40840a4e11c..ccf1a17964ab git log a40840a4e11c..ccf1a17964ab --date=short --no-merges --format='%ad %ae %s' 2019-05-13 saklein@chromium.org BuildPackages: Add USE flags to environment Created with: gclient setdep -r src/third_party/chromite@ccf1a17964ab The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ie4c07322ce13a646041d5823deb15f17dd143835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610840Reviewed-by:
-
Suman Nelson Kancherla authored
This can happen when a VRService couldn't be started on browser process, which calls an error handler callback that releases the service_ pointer. Fixed it by adding a nullptr check around the usage of service_. Also, checked if there are any other similar references. Bug: 961971 Change-Id: Icda57d91280e46df07b88db858a0539b7fac1526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610467 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
Bug: None Change-Id: Ibfce3c1740c07cbcf74705d459b54faefc3be217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609881 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#659215}
-
Becky Zhou authored
Bug: 948443 Change-Id: I2fe90e283fad46f5d2fecc71abd61392074c9af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601933 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#659214}
-
Alexander Timin authored
Add alexclarke@, altimin@ and skyostil@ to base/task/OWNERS as base/task now contains all base task scheduling infrastructure. Also update component tagging: - base/task: Internals>TaskScheduling - base/task/sequence_manager: Internals>SequenceManager R=gab@chromium.org,fdoray@chromium.org CC=alexclarke@chromium.org,skyostil@chromium.org Change-Id: I0a92c5d67630774d932ea109de896c5764c30301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605904Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659213}
-
Evan Stade authored
This relands 4bace02d without includes of stale header kiosk_app_info.mojom.h TBR=derat@chromium.org,tsepez@chromium.org Bug: 962631 Change-Id: I2c13a3453a12c6369431191dc53aed28b0595fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610843Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#659212}
-
Hongchan Choi authored
* This is branched off from: crrev.com/c/1524645 This CL implements a front-end for the WebAudio inspector agent. The UX design review is done by julialiang@ at the project design doc: https://docs.google.com/document/d/1TRgzZwp6M7sWL06UO3GYktqrv9TUv4G0QK6Io6VYVzc/edit#bookmark=id.id0mjwkct14i Bug: 837323 Change-Id: If0478ec96e74e93ce6615ab7322b33db704a6c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578947 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#659211}
-
Josh Karlin authored
CacheStorageCache dooms entries before closing them if their write operations fail. This prevents them from being used in the future. In the event that a ScopedEntry is held by a callback and the callback never gets to run, but does get deleted, a partially written entry would be closed and will be reusable. This is a hypothetical problem. We're not actually sure this can happen since the CacheStorageCache is kept alive by its manager during async operations. But for safety, I've made a new smart pointer for disk_cache::Entry*'s that will by default doom an entry before closing it unless WritingCompleted() has been called on its deleter. This new smart pointer is used anywhere that Entry* writing occurs in CacheStorage. Bug: 617683 Change-Id: Ia5b83bd87b4997fea08cba013fc4701441db6f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600267 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#659210}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3dfb68082e1a..5fc28b11a029 git log 3dfb68082e1a..5fc28b11a029 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 hta@webrtc.org Reland "Reland "Version 2 "Refactoring DataContentDescription class""" 2019-05-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7da20dc3..b06ee6f3 (658985:659110) Created with: gclient setdep -r src/third_party/webrtc@5fc28b11a029 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia8bcbaf7c4e22ffa3fd0b013cfc5fc499f5a6cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609674Reviewed-by:
-
Patrick Monette authored
This allow us to remove all the _win suffixes to every files in the directory. This CL contains no functional change. In addition to the directory move, I only fixed file names (removing the _win suffix) and formatted the resulting CL. Change-Id: I2158afd065fe81cb5350711653359983d9b790e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593724 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#659208}
-
Scott Violet authored
This functionality was added purely for mus and is no longer necessary. BUG=958241 TEST=purely dead code removal Change-Id: I856576f9adef9728d837d56e82f94a87aeea040b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610497 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e1de1ab33d7f..0a1eeb80641a git log e1de1ab33d7f..0a1eeb80641a --date=short --no-merges --format='%ad %ae %s' 2019-05-13 jmadill@chromium.org Call robust resource init before object sync. 2019-05-13 jmadill@chromium.org Roll dEQP (May 2019) 2019-05-13 syoussefi@chromium.org Vulkan: Rework layout block storage conversion 2019-05-13 syoussefi@chromium.org Add test to verify uniform matrix upload Created with: gclient setdep -r src/third_party/angle@0a1eeb80641a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: Ib7846401842c4bdcd8500528ecfeb782f7a4a39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610741Reviewed-by:
-
