- 06 Feb, 2020 40 commits
-
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/544031392417..63b8190db884 $ git log 544031392..63b8190db --date=short --no-merges --format='%ad %ae %s' 2020-02-06 ebrahim [test] minor 2020-02-06 ebrahim [glyf] Skip empty contours 2020-02-05 ebrahim [test] minor 2020-02-05 ckitagawa [cmap] remove dead code 2020-02-05 ebrahim [cbdt] minor, tweak spaces 2020-02-05 ebrahim [cbdt] Merge hb-ot-color-cbdt-table.cc into its header file 2020-02-05 59700018+ckitagawa-work [subset] Avoid incorrectly dropping cmap for NotoColorEmoji.ttf 2020-02-05 ebrahim [subset] minor on _subset 2020-02-05 ebrahim [subset] minor on tables iteration 2020-02-05 ebrahim [subset] minor on switch statements 2020-02-05 ebrahim [subset] Optimize _is_table_present 2020-02-05 ebrahim [cff] minor 2020-02-04 ckitagawa [subset] Keep head when no glyf table 2020-02-04 ebrahim [glyf] minor 2020-02-04 ebrahim [subset] Rename _subset2 to _subset 2020-02-02 ariza first rewrite of cff/cff2 _subset with _subset2 2020-02-04 ckitagawa Add guard to copy_glyph_at_idx 2020-02-01 ebrahim [name] Minor, use subtraction instead ternary operator 2020-01-28 qxliu [subset] Fix namerecord ordering This will fix inconsistency with fontTools. Also according to the spec, namerecords must be sorted first by platform ID, then by platform-specific ID, then by language ID, and then by name ID. 2020-01-21 ckitagawa parent 777ba47b50f6379b9f9abf1d72559316b7116b9e author ckitagawa <ckitagawa@chromium.org> 1579631743 -0500 committer ckitagawa <ckitagawa@chromium.org> 1580506176 -0500 2020-01-31 razrfalcon Minor hb_ot_layout documentation fixes. 2020-01-30 qxliu [subset] Fix simple glyph trim_padding in glyf table Detail: when numOfContours = 1 and flag = 0x31 xCoordinates and yCoordinates would be empty 2020-01-28 qxliu [subset] CMAP table subsetting fix Not all codepoints smaller than 0xFFFF go to cmap4 table. Only subset codepoints existing in each table. This will also make harfbuzz consistent with fontTools' behavior 2020-01-30 ebrahim [draw][docs] update to new terminology 2020-01-30 ebrahim [draw][docs] update to new terminlogy 2020-01-30 ebrahim [draw] minor 2020-01-29 ckitagawa [subset] COLR, simplify logic and use add_array 2020-01-29 ckitagawa Fix build 2020-01-29 ckitagawa Refactor to two iterators 2020-01-24 ckitagawa Use one-liner methods 2020-01-24 ckitagawa Try to fix Wrange-loop-analysis 2020-01-24 ckitagawa Minor style fixes 2020-01-24 ckitagawa Fix nullptr de-reference failure if both blobs in a subset test are 0 in size 2020-01-24 ckitagawa [subset] Add COLR support 2020-01-28 ebrahim [draw][glyf] Implement quadratic to cubic call translation 2020-01-28 ebrahim [draw] Rename conic_to to quadratic_to 2020-01-28 ebrahim Rename hb_outline_decompose to hb_font_draw_glyph and hb_outline_decompose_funcs_t to hb_draw_funcs_t 2020-01-27 ebrahim [outline] use hb_object_is_immutable instead comparing to Null 2020-01-25 ebrahim Rename hb_ot_glyph_* to hb_outline_* 2020-01-27 ebrahim [test][glyph] add subcomponent scale test 2020-01-27 ebrahim [test] test for not applying morx on horizontal runs if gsub exists 2020-01-26 razrfalcon Use correct return type in _unsafe_to_break_find_min_cluster. 2020-01-26 ebrahim [ot-glyph] Add fontkit non variables fonts tests 2020-01-26 ebrahim [ot-glyph][test] Avoid sprintf use 2020-01-26 ebrahim [ot-glyph] Add fontkits's variations toSVG tests 2020-01-26 ebrahim [ot-glyph] Add ttf-parser's outline_glyph tests Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Change-Id: Ic1e6e1014ddca36fea96a7dcb53dec51fc10b468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039614Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#738902}
-
Marc Grimme authored
ManagementUIHandlerTests has a lot of code that repeats itself and makes it hard to understand and extend with more tests. This CL addresses this and consolidates reused code into helper methods to be used by other tests. Bug: 1043658 Change-Id: I4d52fb163b3431be7b3ecc9f1996ef419926099d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010944 Commit-Queue: Marc Grimme <marcgrimme@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#738901}
-
Leon Han authored
Per the discussion at https://github.com/w3c/web-nfc/issues/523#issuecomment-581785547, such size limitation does not make much sense and does not bring much benefit to WebDevs. The spec issue: https://github.com/w3c/web-nfc/issues/523 BUG=520391,1048096 Change-Id: Id5fcc8c349ac220c460646f055b78b812da8aeba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037310Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#738900}
-
Roman Sorokin authored
depending on the fingerprint state Fixed: 936958 Change-Id: If920f13828140f78b765737c881c80eb5afa212c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035998 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738899}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b82ed734e767..656650f461c8 git log b82ed734e767..656650f461c8 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 johnkslang@users.noreply.github.com Merge pull request #2078 from amdrexu/bugfix Created with: gclient setdep -r src/third_party/glslang/src@656650f461c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: Ifb411d1b6031573742feede266099dc6a5b0c782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041035Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738898}
-
Vladislav Kuzkokov authored
Add HTTPS to a list of supported protocols. Bug: None Change-Id: Ibbfcd5e9058758de6bf7b4dca799a92d00bf5d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035994 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Auto-Submit: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#738897}
-
Harald Alvestrand authored
Bug: none Change-Id: Ibf43c6968f8fc3b38668fb636eeeb5094916453d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039671Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#738896}
-
Mikel Astiz authored
TBR=bsep@chromium.org Change-Id: I0729df379983a73f7a2a796d8dfec78f81a0202d Bug: 1049063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039513Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738895}
-
Gauthier Ambard authored
This reverts commit da62e3a8. Reason for revert: The disabled tests on EG1 are also failing on EG2. See https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/7943 Original change's description: > [iOS][coordinator] Modernize toolbar coordinators. > > This CL removes public properties for WebStateList, BrowserState and > dispatcher values and updates the coordinators implementation to get > them from self.browser. > The refactored coordinators: > - Adaptive Toolbar Coordinator > - Primary Toolbar Coordinator > - Secondary Toolbar Coordinator. > > Bug: 1029346, 1047873, 1048663, 1048674 > > Change-Id: I228ac98252cb315e84914bc5d5539168260b8faa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013280 > Commit-Queue: Nazerke Kalidolda <nazerke@google.com> > Reviewed-by: Mark Cogan <marq@chromium.org> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738584} TBR=marq@chromium.org,javierrobles@chromium.org,nazerke@google.com Change-Id: Iec23a5033b36bcdf0e0e3594b350b35505c8cc0d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029346, 1047873, 1048663, 1048674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041590Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#738894}
-
Yuki Shiino authored
Preserves sys.path[0] as is just in case. Bug: 839389, 1046970 Change-Id: I6904ff831783693720e6ee5e9597e7f40f7df683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041111Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#738893}
-
Maria Kazinova authored
Bug: 1047445 Change-Id: I6c90c4525186effe778af2c1b9bb33026774e246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033251 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#738892}
-
Hirokazu Honda authored
This is a reland of 7d82db05 Original change's description: > media/gpu/chromeos/MailboxVFConverter: Set visible size to SharedImage > > MailboxVideoFrameConverter sets coded size to SharedImage. It > causes that a green line is shown at the bottom and right edge > when playing a video. > > This fixes the issue by setting visible size to SharedImage so > that GPU doesn't access non visible area. > Note that MailboxVideoFrameConverter needs to recreate > SharedImage if the visible rectangle of the current video frame > is changed, which should be rare though. > > Bug: 1043582 > Test: Play a 1920x1080 video on soraka with --enable-features=ChromeosVideoDecoder > Change-Id: I76878a27fa92d755380d9b92b94d20e765056fac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011586 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734795} Bug: 1043582, 1045661 Change-Id: I0dc09d3936924086f4b433d204b57002fc75a1e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021562 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#738891}
-
Kuo Jen Wei authored
It's a workaround for not hitting crbug.com/1043790 by setting orientation to 1 before drawing JPEG with EXIF onto canvas. Bug: 998944 Bug: b:147272638 Test: tast run <DUT> 'camera.CCAUIResolutions' Change-Id: I274325e7ec4ce39fabcddb6e42e3fa1f55824514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040971Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#738890}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/cf10db2adddc..250ade1409dc git log cf10db2adddc..250ade1409dc --date=short --first-parent --format='%ad %ae %s' 2020-02-06 btolsch@chromium.org Add fuzzer for Cast message framer Created with: gclient setdep -r src/third_party/openscreen/src@250ade1409dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I31f92e3fdf1321c6ad20c6c0632c16cc836816ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041081Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738889}
-
Philipp Hancke authored
RTP over TCP allows for packets with a frame length of zero which is described in https://tools.ietf.org/html/rfc4571#section-2 Ignore those packets whіch, in the context of WebRTC, serve no purpose. BUG=1043805 Change-Id: Iad07ac4385c24062b3c48354772d88b010ab92f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016641 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#738888}
-
Yoshifumi Inoue authored
This patch changes |NGInlineCursor::PositionForPointInInlineBox()| to skip virtually "culled" inline boxes, used to be culled, to make mapping from hit test point to DOM position work correctly. This patch fixes following tests (at least): 1. editing/selection/android-longtap-not-select-empty.html 2. editing/selection/offset-from-point.html 3. editing/selection/shift-click.html Bug: 982194 Change-Id: I506ba863cc2ee760d78ff3fe1ef57a9dd2e577c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041150 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738887}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9e52bc0d0c1d..1f03ac10270a git log 9e52bc0d0c1d..1f03ac10270a --date=short --first-parent --format='%ad %ae %s' 2020-02-05 afdx@google.com spirv-fuzz: Fuzzer passes to add local and global variables (#3175) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@1f03ac10270a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: Ic77005fad1dbcad6f1cd87194d0e8c2e13a24b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041080Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738886}
-
Side Yilmaz authored
|getLastUsedRegularProfile|. |Profile#getLastUsedProfile| is depreciated and replaced with |Profile#getLastUsedRegularProfile|. This change replaces |Profile#getLastUsedProfile#getOriginalProfile| with |Profile#getLastUsedRegularProfile|. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I2947039aa9754f1490eeba860f768d87142337bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030404Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738885}
-
Richard Knoll authored
The experiment has been stopped so cleanup code that was used to collect metrics on it. Experiment results: go/click-to-call-regex-v2-experiment Bug: 1001033 Change-Id: Ib02a56068b2489f46a2d4c89a960cce68b3d997c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038771Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#738884}
-
Darwin Huang authored
WriteToClipboard expected a cfFormat, but inconsistently retrieved this from a hardcoded value or the ClipboardFormatType. Consistently pass in a ClipboardFormatType, and retrieve the cfFormat in WriteToClipboard. Refactoring change, so no functional changes intended. Bug: 1048945 Change-Id: I7f73d0904a8d1b3c02de220f471ebca9a71535c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036281 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738883}
-
Alan Cutter authored
The install promotability status was not being updated on app installation. This meant that pages would still show the install plus even after the user had installed the corresponding PWA. Bug: 1049405 Change-Id: I23d0f2226271ad46cadc4059d7a1846ef385f423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040638 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#738882}
-
Eric Seckler authored
We're refactoring startup tracing in Chrome, see design doc[1]. With the new startup tracing architecture, each process needs to allocate a shared memory buffer when enabling startup tracing. This is only supported after mojo was initialized for the process. On Android, we were previously enabling startup tracing right after the native library is loaded. At this point, mojo is not ready yet. To prepare for the startup tracing refactor, this patch moves startup tracing initialization on android to ContentMainRunnerImpl::Initialize, which is called after mojo was initialized by Main() in //services/service_manager/embedder/main.cc. We should only lose minimal tracing data due to this, since ContentMainRunnerImpl::Initialize is still very early during startup, and this doesn't affect recording of even earlier java events. [1] https://docs.google.com/document/d/1FygJQbD29vMkfVfT7m0Lb1u1zZZU1VgXAPi_R0uBoTw/edit?usp=sharing Bug: 1006753 Change-Id: I89aa292b3010bb501b42bd0bd735f8df75cea557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036188Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#738881}
-
David Tseng authored
This patch introduces AutomationPosition. It acts as a wrapper of an AXNodePosition and utilizes gin::Wrappable to ease the burden of surfacing positions in javascript. gin::Wrappable handles the details of object lifetime between the object within V8 and the native C++ object. This change has gone to great lengths to make it as easy as possible to define methods and properties on this wrapper object so that they are self-contained and trivial to add, remove, and edit. This will facilitate future changes in the underlying AXPosition class and make it straightforward for anyone changing the api. Bug: 1048367 Test: browser_tests Change-Id: I9c881002ffcb991e4f8a1db3c269e5be0e9144da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814650 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#738880}
-
Yoichi Osato authored
This CL applies move semantics of ResourceRequest rather than copy to that member in FetchParameters. We can apply move because most of ResourceRequest are stack allocated. Execptional ResourceFetcher::RevalidateStaleResource is left copy out of FetchParameters constructor. This is a preparation to introduce non-copiable PendingRemote into ResourceRequest for streaming body upload (design doc: http://bit.ly/2tSWsIH). Bug: 787704 Change-Id: I7b961d7f245f7955f2fd07bbedec4e41f4ad9b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026832Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#738879}
-
Dominic Farolino authored
Removing myself in favor of subscribing to navigation-cc R=fergal@chromium.org Bug: N/A Change-Id: Iaf59e21360423890c843d95b2aadac1879289978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041112 Auto-Submit: Dominic Farolino <dom@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#738878}
-
Steve Becker authored
Removes /third_party/blink/public/mojom/ #includes from /content/public/browser/content_browser_client.h. Instead, forward declares blink::mojom types. This fixes sporadic build breaks where unluckly builds fail to find generated headers like /third_party/blink/public/mojom/badging/badging.mojom-forward.h Bug: 1049216 Change-Id: I8df7bf9d12797917f4aa9b3b0193e76317965229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041033Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Steve Becker <stevebe@microsoft.com> Cr-Commit-Position: refs/heads/master@{#738877}
-
Dominic Mazzoni authored
When a live region changes, optionally provide a way to generate the text associated with that change. On some platforms we might expose that text directly so that AT doesn't need to try to compute it. The computation is somewhat subtle because it involves worrying about deleted nodes and handling aria-atomic, aria-relevant, and aria-busy. Bug: 1042893 Change-Id: Ia79f0c976bef73ea25a8821dbb9fc7f22fde0e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006131 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#738876}
-
Manuel Rego Casasnovas authored
Basically we can avoid marking all the ancestors in LayoutObject::MarkContainerChainForOverflowRecalcIfNeeded() if the overflow recalc flags are already set. BUG=941180 Change-Id: Ic8480a8d7a9fd7a2b7f35ff9ffb4ae10742098e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028228Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#738875}
-
Dana Fried authored
Nested layouts now allocate available space properly to their descendents. Also, we consistently use flex layout in the PWA titlebar. Removed a couple of invalid assumptions that were encoded as DCHECKs. There are still some inkdrop issues but they are purely cosmetic, see crbug.com/1006162 for more detail. Bug: 1048061 Change-Id: I403b71b5e2bbcb2d461e1ed6c543c76f91d4c652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036264 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#738874}
-
Yuki Shiino authored
Minimizes the path length (/a/../b/c => /b/c). Bug: 839389, 1046970 Change-Id: Ie5a1879fdb1cfcccc3224ecb2cc62c32346c20a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040798Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#738873}
-
Keishi Hattori authored
This reverts commit 4276111d. Reason for revert: Speculative revert for crbug.com/1049444 Original change's description: > [devtools] Don't continue execution after reload on breakpoint > > This CL fixes an issue where JavaScript execution would continue > after reloading on a breakpoint. See design doc: > https://docs.google.com/document/d/1aO9v0YhoKNqKleqfACGUpwrBUayLFGqktz9ltdgKHMk > > The CL depens on V8 change in crrev.com/c/1924366 and tests should fail until > that change is landed+rolled to chromium. > > Fixed: 1004038 > Fixed: 1014415 > Change-Id: I182393ebd4c68588163dda7c607be8bb09a3eda3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926502 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738522} TBR=dgozman@chromium.org,yangguo@chromium.org,sigurds@chromium.org Change-Id: Ia243a6f44d53789be935ecdc48d8db6c2340f6b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039854Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#738872}
-
Adrienne Walker authored
This was flaky in the past but has been rewritten. Time for another spin. Bug: 747589 Change-Id: Icf97dda7da24145e77dd7048e4c4db8cde163869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040054Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#738871}
-
Gyuyoung Kim authored
This CL migrates the legacy ResetPermissions IPC message to the new Mojo defined in WebTestClient interface. Bug: 1039247 Change-Id: I63e6ec066a4f4acb5e087dd3d764f56acfb45e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032757 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#738870}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/25b7b846db91..e5385ea920e0 git log 25b7b846db91..e5385ea920e0 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 syoussefi@chromium.org Vulkan: Compile shaders at link time 2020-02-06 jmadill@chromium.org Vulkan: Fix overlay with command graph disabled. Created with: gclient setdep -r src/third_party/angle@e5385ea920e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I36a37f3bff6ad4bf93582ddf0287768b640d3c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040928Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738869}
-
Daniel Cheng authored
Blink allows use of the //base histogram helpers, so there's no point in having two ways of doing the same thing. Just use //base, which has standardized definitions for recording "short" times (1ms - 10s), et cetera. Bug: 1047547 Change-Id: I8c573e4f29db102fe357ccf3d6eb95230c0abb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033927 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#738868}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/98b516151f71..cbf79b95c2d4 git log 98b516151f71..cbf79b95c2d4 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8e8e1d0dd729..dd48b7e2d06e (2 commits) 2020-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 58fc8b11cf3a..f1b2c4bed48a (13 commits) Created with: gclient setdep -r src/third_party/skia@cbf79b95c2d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I86bb72972ec4e636e43cbf05a2a1c60535af7881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040926Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738867}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5b6a7487a412..ca6faed1054e Created with: gclient setdep -r src-internal@ca6faed1054e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic5ef87f0fd526fa559022f419a4a1fab528b78de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040929Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738866}
-
Adam Rice authored
Move web_transport_close_proxy.h from send_stream.h to the .cc file. Remove the USING_GARBAGE_COLLECTED_MIXIN macro as SendStream has no mixins. BUG=1011392 Change-Id: I946781955ba068e396a82d37cb78b2248edbe699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032750Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#738865}
-
Xiaocheng Hu authored
This patch adds a new Chromium feature to control the Blink runtime enabled feature CSSReducedFontLoadingInvalidations. This allows us to study performance impacts of the feature via finch experiments. Bug: 441925 Change-Id: Icba6f1f1899af0bcecc12cf570786a07364f4fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040616Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#738864}
-
Peter Kasting authored
This reverts commit 26a7b762. Reason for revert: Likely caused http://crbug.com/1049486 Original change's description: > Add Windows high contrast support to the toolbar button icons > > This change adds different foreground icon colors to the toolbar buttons > for the hovered and pressed states when the high contrast ink drop > feature is enabled. This is to support the desired platform high contrast > colors. Future work will add foreground color support to other buttons. > > New theme properties were added to support the additional _HOVERED and > _PRESSED state high contrast colors. When not in high contrast, these > are the same as the normal icon color. In high contrast (+ flag) they > return the selected text HC color. These new colors are used to create > images in the toolbar buttons for the various button states. > > New helper functions we added to ToolbarButton to simplify setting the > images for the different button states, including one that just uses > the standard colors returned by |GetForegroundColor|. > > In the future, we might want to do work to allow icons to be separated > from colors to allow for easier recoloring. > > Bug: 776871 > Change-Id: Id72d8c60a23889f018044a5fcce7abd9359ad61a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029492 > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738660} TBR=pkasting@chromium.org,antrim@chromium.org,johnsm@microsoft.com,champnic@microsoft.com Change-Id: Ide6174254819728c271a3ed059cee7132cd2c124 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 776871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040029Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#738863}
-