- 04 Jan, 2018 40 commits
-
-
Andrew Grieve authored
Regressed in d875cacb Bug: 780593 Change-Id: Ifee7a93ada73f5b757a35ece75b0bef61ea767c2 Reviewed-on: https://chromium-review.googlesource.com/820531Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#527117}
-
Achuith Bhandarkar authored
This flag skips to the user login screen. BUG=753870 TEST=manual Change-Id: I3682b825d8177b8676718f421335f4af1d940937 Reviewed-on: https://chromium-review.googlesource.com/850582 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#527116}
-
Darin Fisher authored
Change-Id: I7f15880761ab173ecebac694d042b0048707acae Reviewed-on: https://chromium-review.googlesource.com/850836Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#527115}
-
Sidney San Martín authored
Bug: 787139 Change-Id: I141466b5e8d7b68a91f3a844e07053b6c3720153 Reviewed-on: https://chromium-review.googlesource.com/851193Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#527114}
-
Sidney San Martín authored
Safari plays a sound when a download fails. This does it for both success and failure. Bug: 787139 Change-Id: If3df9aaed218f8b66fcf124ae8f2529eba87c6f5 Reviewed-on: https://chromium-review.googlesource.com/850743Reviewed-by:
-
Francois Doray authored
This method is called when a nested loop is done running work. It will help simplify the TaskQueueManager code. Use case: The blink scheduler needs to adjust the time domain when there is a transition between a nested/non-nested scope. https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc?l=2302&rcl=614a67e2c14cf8bb9a06f4fe8da7625cbf1ea7d7 Currently, it checks base::RunLoop::IsNestedOnCurrentThread() every time a task completes to detect transitions between a nested/non-nested scope. Code would be simpler with an explicit notification. Bug: 783309 Change-Id: I9748c287ad8418831598d84f45a518e4138c5e1b Reviewed-on: https://chromium-review.googlesource.com/766388Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#527112}
-
David Trainor authored
For some reason duplicate onDismiss calls are sneaking through. This removes the crasher while a follow up patch will land to report more logging information only for dev and canary. BUG=791879 Change-Id: I62088ae7c966b6c75e667c7eff99fac7e6826bb5 Reviewed-on: https://chromium-review.googlesource.com/850575Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#527111}
-
Max Moroz authored
R=jbroman@chromium.org Bug: 754124 Change-Id: Ia7dd043982d404afa316be81fb030c9caed9e7c0 Reviewed-on: https://chromium-review.googlesource.com/849476Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#527110}
-
Steven Holte authored
Bug:785306,743089 Change-Id: I4e13b4d4c2bcd81ca54c7fa7c5133fe046a53043 Reviewed-on: https://chromium-review.googlesource.com/850842 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#527109}
-
Greg Kraynov authored
Change-Id: If4cb73bc28300b5ed01ce10f7068ff930c8ba6cb Reviewed-on: https://chromium-review.googlesource.com/847482 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
-
Ted Choc authored
BUG= Change-Id: I9297f99b73e8a91b208f3faa51644bd5574c4e0c Reviewed-on: https://chromium-review.googlesource.com/846248Reviewed-by:
-
Alexander Alekseev authored
SigninScreenHandler::HandleAuthenticateUser should ignore 'User not found' errors. Bug: 794487 Change-Id: I83c9a9bc2787514384e5bbee9253eaf383df94db Reviewed-on: https://chromium-review.googlesource.com/850998Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#527106}
-
Danyao Wang authored
The ui::PAGE_TRANSITION_FORWARD_BACK bit has always been set for different-document back/forward navigation. It's not clear why same-document back/forward navigation should be treated differently. Making this change matches the Blink behavior (so should be low risk) and removes a special case. Bug: 798832 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I39e7a28caa9069cbb12ebdc965918792b36b77b2 Reviewed-on: https://chromium-review.googlesource.com/847940 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#527105}
-
Eric Karl authored
This patch adds initial support for images in OOP raster, using the transfer cache. This has a few sub-components: - Update the ServiceImageTransferCacheEntry to handle > max texture size images. - Update the GPUImageDecodeCache to have a TRANSFER_CACHE upload mode. - Update GPUImageDecodeCache's unit tests to hit the TRANSFER_CACHE path. - Update RasterCHROMIUM to take an ImageProvider, and re-factor RasterCHROMIUM to reduce number of arguments. Bug: 777628 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I037391fa150529883f1fc534064e29802cf2d08f Reviewed-on: https://chromium-review.googlesource.com/822605 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#527104}
-
Pavol Marko authored
(Reland with WebviewProxyAuthLoginTest browsertext fix) This CL fixes sign-in behind an authenticated proxy. Two actual changes were necessary in this context: - SigninPartitionManager: copy auth data from the system request context into new StoragePartitions This makes SigninPartitionManager::StartSigninSession async, which made small changes necessary in GaiaScreenHandler and EnrollmentScreenHandler - SigninScreenHandler: Don't reload gaia immediately when auth details have been supplied. This was unnecessary (the URL Request will continue) and actually harmful, as now that we're using a new StoragePartition for each sign-in attempt, this discards auth data before we can copy them. To support the browsertest, testserver.py gets an argument to redirect CONNECT requests to localhost when proxying (in sign-in browsertests without proxy, we use RuleBasedHostResolverProc::AddRule to achieve this effect). unit_tests --gtest_filter=SigninPartitionManagerTest* Manual test: Setup: Setup an proxy server with Basic authentication Configure the device to use the proxy server. Make sure the user adding screen is shown. Test 1: Expect proxy auth dialog. Enter correct proxy auth data. Expect that sign-in screen is shown and sign-in works. Test 2: Expect proxy auth dialog. Enter incorrect proxy auth data. Expect that proxy-auth dialog is shown again. Test 3: Expect proxy auth dialog. Press Cancel. Expect that a network error dialog is shown. Press "try to sign in again". Expect proxy auth dialog. Enter correct proxy auth data. Expect that sign-in screen is shown and sign-in works. Bug: 793524 Test: browser_tests --gtest_filter=WebviewProxyAuthLoginTest.* && Change-Id: I56dafa240ad3bb5902517688a5cb17e309f2982d Reviewed-on: https://chromium-review.googlesource.com/850472Reviewed-by:Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Patrick Monette authored
- The omnibox icon size was changed - The strings used in the dialog were changed TBR=estade@chromium.org Bug: 797112 Change-Id: I05d70320f41940899663d871a6dc1948ee6fd0d2 Reviewed-on: https://chromium-review.googlesource.com/841245 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#527102}
-
Bruce Dawson authored
CR fixes after crrev.com/c/846422 Bug: 796644 Change-Id: I3395664131d44ecf2108582b28d1cac52ae26b91 Reviewed-on: https://chromium-review.googlesource.com/849708Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#527101}
-
Chris Mumford authored
file_data_pipe_producer.g should have been file_data_pipe_producer.h TBR=rockot@chromium.org Bug: None Change-Id: Ia25c80f2c62198fe6114d1a170542f710242e016 Reviewed-on: https://chromium-review.googlesource.com/836453 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Reviewed-by:
-
Jens Widell authored
The main improvement is that source files with unhandled extensions other than .h, for example .json and .idl, are not counted towards the merge limit, and thus can't lead to too many chunks being generated. By restructuring, the code also iterates the source file list once instead of twice, and calls get_path_info() once per source file instead of twice. Change-Id: I130c815c84fff08b6ad2d6f36434140efbeb2d29 Reviewed-on: https://chromium-review.googlesource.com/850397Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#527099}
-
Greg Levin authored
This reverts commit d7d410b6. Reason for revert: Test is crashing on linux-chromeos-dbg builder. See crbug.com/799229 for details. Original change's description: > Add test coverage for ChromeVox api > > Bug: > Change-Id: I8b4c002427f14426753e6a4ddc083e50a33cb985 > Reviewed-on: https://chromium-review.googlesource.com/847896 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#527035} TBR=dtseng@chromium.org,aleventhal@chromium.org,katie@chromium.org Change-Id: I73164ee8c477eff6878e59993f52168c552ed523 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/851075Reviewed-by:
Greg Levin <glevin@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/heads/master@{#527098}
-
Raymond Toy authored
R=robertma@chromium.org Bug: Change-Id: If362b229cde4d29397528ee361d8c11638beae1c Reviewed-on: https://chromium-review.googlesource.com/851154Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#527097}
-
Raymond Toy authored
Clean up and simplify audionodeoptions.js. We also now test all the possible channel count modes when the mode is fixed so that we verify we didn't miss a case. Bug: Test: constructor/*.html Change-Id: Ife8770e16097d243f2ce46dc98386109cdbe18e8 Reviewed-on: https://chromium-review.googlesource.com/832821Reviewed-by:
-
Charles Harrison authored
This change: 1. Adds NavigationSimulator::SetMethod to set the initial HTTP method. 2. Converts navigation intercept tests to use the nav simulator. Note well that this conversion *relaxes* the test constraints. We now simply check that the request fails to commit, rather than fails to start. This is to allow future optimizations to apply policy in an async way without blocking the majority of network requests. For POSTs, we still check that the nav is cancelled at start. 3. Converts flash download intercept test to use the nav simulator. Bug: 793053 Change-Id: Ic30bf123fa94abe978ca4f5b02802899bc9a423e Reviewed-on: https://chromium-review.googlesource.com/813417 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#527095}
-
Doug Arnett authored
This is a reland of 0346a3a1 Original change's description: > Adds predictable multimatch support in PreviewsOptimizationGuide > > Supports multiple hint matches with precendence given to the match > that occurs first in the configuration. Also, allows matches > without whitelisted optimization to be able to turn off whitelisting > for a host pattern (that otherwise would be whitelisted for another > matching pattern that occurs later in config). > > Bug: 783237 > Change-Id: I9239b74b170a1d5a19b13caccecc732f9715de90 > Reviewed-on: https://chromium-review.googlesource.com/847816 > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Doug Arnett <dougarnett@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526763} Bug: 783237 Change-Id: I75cf52fbe3b471f81b3f18ae451d7daa0844190e Reviewed-on: https://chromium-review.googlesource.com/849673 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#527094}
-
Yuri Wiitala authored
Due to a minor oversight, the FrameSinkVideoCapturer will occasionally drop refresh frame requests. This is because the VideoCaptureOracle can reject the request for a frame capture, based on its own sampling heuristics. This change adds a simple mechanism where a "retry timer" is started if this should occur. The "retry" is canceled if other frame captures are triggered in the meantime. Essentially, this guarantees that the consumer will eventually receive a new video frame after making a refresh request for one. Bug: 785072 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ic3dd0d5ca1f8cb48193123e714ed8cf89076f953 Reviewed-on: https://chromium-review.googlesource.com/838320Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#527093}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/c71862aa324c..91586494675e $ git log c71862aa3..915864946 --date=short --no-merges --format='%ad %ae %s' 2017-12-20 bryan.bernhart Allow MapResource to return context loss GL error 2018-01-04 jmadill Entry Points: Auto-generate extensions EPs. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Icf7c500acef93be0db40a218287790155abb2fbf Reviewed-on: https://chromium-review.googlesource.com/850441Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#527092}
-
Geoff Lang authored
Storing the bound textures in flat arrays significantly improves the performance of binding textures in the passthrough command decoder. BUG=angleproject:2188 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibb9dca361a2d598aece5b9ed7ed2e373ae9b7183 Reviewed-on: https://chromium-review.googlesource.com/811765 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/974a66a80812..a1b4d5ea3410 $ git log 974a66a80..a1b4d5ea3 --date=short --no-merges --format='%ad %ae %s' 2018-01-04 eakuefner [TBMv2] Switch to dynamically importing diagnostics in Python Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9ea4390a6bf34d270c59d1c68c8816ec41dae2b5 Reviewed-on: https://chromium-review.googlesource.com/850577 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#527090}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/d9dfb6cc16f6..cb6c8d4ec478 $ git log d9dfb6cc1..cb6c8d4ec --date=short --no-merges --format='%ad %ae %s' 2018-01-04 rharrison Make CXFA_List::GetLength return a size_t 2018-01-04 dsinclair Pass the FFDocView into CXFA_WidgetAcc::UpdateUIDisplay 2018-01-04 dsinclair Change CXFA_WidgetAcc::GetNextWidget to not require the FFDocView 2018-01-04 dsinclair Move ProcessValueChanged from CXFA_WidgetAcc to CXFA_FFDocView Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I66948db360c81255d47315e3b4d917ebf23c3c45 Reviewed-on: https://chromium-review.googlesource.com/850445 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#527089}
-
rbpotter authored
Bug: None Change-Id: Icd11e38860cf3eee024ebdf3fb847a528e8050c8 Reviewed-on: https://chromium-review.googlesource.com/843016Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#527088}
-
Charlie Andrews authored
NOTRY=true TBR=nednguyen@google.com, hayato@chromium.org Bug: 799184 Change-Id: Ic7ee070882bc1d2db502eccae6cadbb9b4807aa9 Reviewed-on: https://chromium-review.googlesource.com/851117Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#527087}
-
Xiaohan Wang authored
Verified by running the script to print all Media.EME histograms: ./print_histogram_names.py | grep "Media.EME" For print_histogram_names.py, see change 850545. BUG=776834 Change-Id: I6d95a03b52b66381f3507adc06594e682cbf69a6 Reviewed-on: https://chromium-review.googlesource.com/849705 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#527086}
-
Dave Schuyler authored
This CL adds a flag for enable/disable the GUI enhancements for rich entity suggestions in the omnibox. The default value is Disabled. As of this CL, the flag has no effect. Bug: 798630 Change-Id: I9e3ca0660965019dfbab16d2b98255d8cf7128c0 Reviewed-on: https://chromium-review.googlesource.com/848236 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/085bb64c8579..bb4bbfda1cf5 $ git log 085bb64c8..bb4bbfda1 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8563500f38e5be39143b98b7ac87cb52150a1649 Reviewed-on: https://chromium-review.googlesource.com/850846Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#527084}
-
Elad Alon authored
The tests were flaky because of a race with WebRtcEventLogManager::task_runner_. The problem is that SequencedTaskRunner's destructor does not block, allowing us to destroy a WebRtcEventLogManager objects while its |task_runner_| is still executing a task that operates on the WebRtcEventLogManager object. We solve this by making WebRtcEventLogManager work synchronously when it's used in WebRTCInternals' unit tests (but nowhere else). Bug: 796047 Change-Id: I76606b9394c1e5c02a3626fd8d3824bea587d1e4 Reviewed-on: https://chromium-review.googlesource.com/850697 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#527083}
-
Dave Schuyler authored
The README.md referred to pretty-print.py (which looks like a typo) and pretty_print.py. This CL changes them both to use underscores (e.g. pretty_print.py). (doc change) Bug: None Change-Id: If13ccf79bfd805cd8cfa3ea3111d318bbe45b545 Reviewed-on: https://chromium-review.googlesource.com/849699Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#527082}
-
Xida Chen authored
TBR=skyostil@chromium.org NOTRY=true Bug: 799127 Change-Id: Ic432554bdc50e3e2b438fc78115d939c96fa0e08 Reviewed-on: https://chromium-review.googlesource.com/851156Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#527081}
-
Eugene But authored
_documentURL is not needed for WK-based navigation manager so there is not much value in adding unit tests for this new code. Bug: 796777 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib4635f6d6d20934ea3fb07793d460ac3c1a786e0 Reviewed-on: https://chromium-review.googlesource.com/846020Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#527080}
-
Joe Downing authored
This change introduces a workaround and a TODO for the WebRTC DCHECK that we have been manually working around. We will continue to work on the proper solution and remove this workaround once it is ready. Note: I also updated the name of the method being commented out due to an error that occurs during CL validation prior to uploading. BUG=793486 Change-Id: Ibb77bf509f28698a4c3564c85386b6362a98daad Reviewed-on: https://chromium-review.googlesource.com/850442 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#527079}
-
Daniel Bratell authored
There are two HeaderFlattener classes that do similar things but not identical things. If they end up in the same translation unit (can happen in some extreme jumbo configurations) there will be a clash so this patch renames one of them to HeaderToString. Bug: 746953 Change-Id: I1fa37f86bcf13487fd8b18da766f440b3ad85545 Reviewed-on: https://chromium-review.googlesource.com/848915 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
