- 08 Mar, 2018 40 commits
-
-
Aleks Totic authored
This happens when ng cacheing is enabled. Following tests crash with Cache flag without the fix: compositing/geometry/composited-in-columns.html external/wpt/css/css-multicol/multicol-break-000.xht external/wpt/css/css-multicol/multicol-break-001.xht fast/block/float/floats-do-not-overhang-from-block-formatting-context.html fast/block/positioning/offsetLeft-offsetTop-multicolumn.html fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size.html fast/css-intrinsic-dimensions/multicol.html fast/forms/number/number-spinbutton-in-multi-column.html fast/forms/select/listbox-in-multi-column.html fast/multicol/auto-height-forced-break-complex-margin-collapsing.html fast/multicol/balance-break-inside-avoid.html fast/multicol/balance-floats.html fast/multicol/balance-short-trailing-empty-block.html fast/multicol/balance-trailing-border-after-break.html fast/multicol/balance-trailing-border.html fast/multicol/balance-unbreakable.html fast/multicol/break-after-always-bottom-margin.html fast/multicol/break-before-first-line-in-first-child.html fast/multicol/break-properties.html fast/multicol/client-rects-rtl.html fast/multicol/client-rects.html fast/multicol/composited-layer.html fast/multicol/cssom-view.html fast/multicol/first-line-in-block-below-next-column-top.html fast/multicol/first-line-in-block-with-padding-exact-fit.html fast/multicol/first-line-in-block-with-padding.html fast/multicol/first-line-in-float-below-next-column-top.html fast/multicol/first-line-in-float-with-margin.html fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html fast/multicol/fixedpos-in-transform-at-column-boundary.html fast/multicol/flipped-blocks-hit-test.html fast/multicol/float-beside-bfc.html fast/multicol/float-moved-by-child-line-and-unbreakable.html fast/multicol/float-with-margin-moved-by-child-block-and-unbreakable.html fast/multicol/float-with-margin-moved-by-child-block.html fast/multicol/float-with-margin-moved-by-child-line-and-unbreakable.html fast/multicol/float-with-margin-moved-by-child-line.html fast/multicol/float-with-margin-moved-unbreakable.html fast/multicol/forced-break-before-complex-margin-collapsing.html fast/multicol/forced-break-in-nested-columns.html fast/multicol/hit-test-above-or-below.html fast/multicol/hit-test-end-of-column-with-line-height.html fast/multicol/hit-test-end-of-column.html fast/multicol/hit-test-float.html fast/multicol/hit-test-translate-z.html fast/multicol/image-inside-nested-blocks-with-border.html fast/multicol/inline-getclientrects.html fast/multicol/inner-multicol-moved-into-continuation.html fast/multicol/insane-column-count-and-padding-nested-crash.html fast/multicol/margin-bottom-and-break-after.html fast/multicol/min-height-greater-than-content.html fast/multicol/min-height-greater-than-height.html fast/multicol/min-height-less-than-content.html fast/multicol/min-height-less-than-height.html fast/multicol/min-height-much-greater-than-content.html fast/multicol/nested-balancing-with-line-at-exact-top.html fast/multicol/nested-balancing-with-lines-and-space-left-in-previous-row.html fast/multicol/nested-inner-auto-height-outer-extra-space.html fast/multicol/nested-one-line-in-inner.html fast/multicol/nested-short-first-row-extra-tall-line.html fast/multicol/nested-short-first-row-unsplittable-block.html fast/multicol/nested-uneven-inner-column-height.html fast/multicol/nested-with-forced-breaks-in-eariler-rows.html fast/multicol/orphaned-line-at-exact-top-of-column.html fast/multicol/orphans-relayout.html fast/multicol/relayout-and-push-float.html fast/multicol/shadow-breaking.html fast/multicol/three-inner-rows.html fast/multicol/unforced-break-after-complex-margin-collapsing.html fast/multicol/widows-and-orphans.html fast/multicol/widows.html fast/multicol/widows2.html fast/multicol/dynamic/bottom-aligned-abspos-change-column-height.html fast/multicol/newmulticol/balance-images.html fast/multicol/newmulticol/balance-maxheight1.html fast/multicol/newmulticol/balance-maxheight2.html fast/multicol/newmulticol/balance1.html fast/multicol/newmulticol/balance10.html fast/multicol/newmulticol/balance2.html fast/multicol/newmulticol/balance3.html fast/multicol/newmulticol/balance4.html fast/multicol/newmulticol/balance5.html fast/multicol/newmulticol/balance6.html fast/multicol/newmulticol/balance7.html fast/multicol/newmulticol/balance8.html fast/multicol/newmulticol/balance9.html fast/multicol/newmulticol/orphans-and-widows-balance.html fast/multicol/span/autofill-after-spanner.html fast/multicol/vertical-lr/break-properties.html fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html fast/multicol/vertical-lr/balancing/balance-trailing-border-after-break.html fast/multicol/vertical-lr/balancing/balance-trailing-border.html fast/multicol/vertical-lr/balancing/balance-unbreakable.html fast/multicol/vertical-rl/break-properties.html fast/multicol/vertical-rl/balancing/balance-short-trailing-empty-block.html fast/multicol/vertical-rl/balancing/balance-trailing-border-after-break.html fast/multicol/vertical-rl/balancing/balance-trailing-border.html fast/multicol/vertical-rl/balancing/balance-unbreakable.html fast/pagination/multicol.html fragmentation/abspos-after-forced-break.html fragmentation/avoid-break-inside-first-child-nested.html fragmentation/avoid-break-inside-first-child.html fragmentation/block-with-float-and-1-orphaned-line.html fragmentation/break-after-last-child.html fragmentation/break-before-empty-child-block.html fragmentation/break-before-first-child.html fragmentation/break-in-caption-before-tbody.html fragmentation/break-in-first-table-row-only.html fragmentation/break-in-first-table-section.html fragmentation/break-in-second-table-section.html fragmentation/break-in-tbody-after-caption.html fragmentation/break-inside-avoid-with-forced-break.html fragmentation/cell-taller-than-col-straddles-columns.html fragmentation/class-c-break-after-clearance.html fragmentation/collapsing-class-a-breakpoints.html fragmentation/float-after-forced-break.html fragmentation/image-block-as-first-child.html fragmentation/multi-line-cells.html fragmentation/repeating-thead-exceeds-page-size.html fragmentation/repeating-thead-no-room-for-content-row-on-first-page.html fragmentation/single-cell-too-large-for-page.html fragmentation/single-cells-multiple-tables-no-repeating-thead.html fragmentation/single-line-cells-in-multiple-table-sections.html fragmentation/single-line-cells.html fragmentation/table-in-subpixel-fragmentainer.html fragmentation/table-overlapping-rowspan.html fragmentation/table-row-dimensions-break-freely.html fragmentation/table-row-dimensions-with-thead.html fragmentation/table-row-dimensions.html fragmentation/tbody-before-thead.html paint/invalidation/overflow/paged-with-overflowing-block-rl.html paint/pagination/pagination-change-clip-crash.html printing/multicol.html printing/pageProperty-with-multicol.html Bug: 819372 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5df07ebf451527a640d7a5f4125d10a3e7441bc8 Reviewed-on: https://chromium-review.googlesource.com/952262 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#541931}
-
Trent Apted authored
This avoid a conflict with class OmniboxState in an anonymous enum of omnibox_view_views Bug: 801583 Change-Id: Ifbf5ebd3f421e7ead9bd18e62d2c9786db3ae08b Reviewed-on: https://chromium-review.googlesource.com/954527Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#541930}
-
Luka Dojcilovic authored
Added aria-labels as one of the possible things to be used as a label for form control elements because they may contain useful information for username detection. Bug: 783185 Change-Id: I59a7f025c616f38d533c9c9a7327ec8ec9021c4c Reviewed-on: https://chromium-review.googlesource.com/951765Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#541929}
-
Yuly Novikov authored
Also rearrange other Android GPU.FYI bots hierarchy. BUG=808610 Change-Id: I8f959215b35e5759a759a5c96c0252cdd70c4d0a Reviewed-on: https://chromium-review.googlesource.com/955951Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#541928}
-
Stephen Chenney authored
The clip for iframes was missing when the iframe did not have its own composited layer. Fix the overly aggressive "NeedsClip" code to not return false for all LayoutEmbeddedContent in most paint modes. R=chrishtr@chromium.org BUG=814177 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iae77a367839f8dfccda817a31ab1cc988ecd0436 Reviewed-on: https://chromium-review.googlesource.com/956031Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#541927}
-
Jay Civelli authored
Fixes the ContentFaviconDriverTest browser tests with the network service by switching to using a URLLoaderInterceptor instead of the URLRequestDispatcherHost. Bug: 787614 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ifc04f6b8c85461f4974a8f6dd11b27e1beeef188 Reviewed-on: https://chromium-review.googlesource.com/955892Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#541926}
-
edchin authored
Bug: 804560 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8a7f1779aff808edddc525110c8900cbd9fd8b8a Reviewed-on: https://chromium-review.googlesource.com/955345Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541925}
-
kristipark authored
Modified the voice overlay to be a dialog element, and expanded the keydown event handler to handle keydown events on buttons/links as click events. As a side effect, switching to a dialog element also fixes the fade in animation for the voice overlay. Bug: 706908 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9dd79e21aa2b1f6c429e7f6d6957b18db2aa03a9 Reviewed-on: https://chromium-review.googlesource.com/945146 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#541924}
-
Christopher Cameron authored
Note from the comments in cc::Layer that the bounds of root cc::Layers are specified in pixels, in contrast with those of non-root cc::Layers, which are specified in DIPs. Add a compositor_viewport_pixel_size() accessor to RenderWidget to access this from the sub-class (naming is due the pending renaming of physical_backing_size to compositor_viewport_pixel_size). Bug: 814690 Change-Id: Ia8033961e04f18c374123b4f9f8da96be131edc7 Reviewed-on: https://chromium-review.googlesource.com/954359Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#541923}
-
Daniele Castagna authored
linux_dmabuf_v1 has been updated, clients have been updated to use "create_immed" that is available starting from v2, but we forgot to bump up the version we pass to wl_registry_bind. This patch updates the wayland test client code. Bug: None Test: wayland_rects_client --use-drm=rockchip on kevin now works. Change-Id: I83b16f48e797a275208df7f3d7cccfed8f0a5e40 Reviewed-on: https://chromium-review.googlesource.com/956563Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#541922}
-
Aga Wronska authored
This UI allows user to initiate desired demo mode setup flow. It is shown as a part of OOBE experience. It can be triggered by using keycombo on 'Sign in' screen. Some settings (locale, network) chosen during OOBE are relevant for the demo mode setup. UI will be updated when the final design and mocks are provided. Bug: 812460 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifccdb37a3cb8364fa1b247ef30caa552bb858491 Reviewed-on: https://chromium-review.googlesource.com/932914Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#541921}
-
Kent Tamura authored
Now public/ contains stuff not only for renderer process such as public/common. So we'll move public/ to third_party/blink/public, not third_party/blink/renderer/public. This directory structure is consistent with other modules in Chromium. Bug: 578345 Change-Id: I3baf7889b587c5acc1062cfc101cc9451750b542 Reviewed-on: https://chromium-review.googlesource.com/954890Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#541920}
-
Ryan Landay authored
It came up during review of https://chromium-review.googlesource.com/c/chromium/src/+/940188 that this class should be using @IntDefs instead of enums for efficiency reasons. This CL changes SwipeMode from an enum to an @IntDef. Bug: 817885 Change-Id: Iaded46027fd3409c936ef48208464e363df1cab1 Reviewed-on: https://chromium-review.googlesource.com/944546Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#541919}
-
Sunny Sachanandani authored
Windows expects back slash instead of forward slash in paths. Python subprocess.call does not convert slashes automatically. BUG=NONE R=zmo Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I76d8d4b973127102b42a4a02f59b09993383aabb Reviewed-on: https://chromium-review.googlesource.com/956548Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#541918}
-
Matt Falkenhagen authored
The "OmniboxCombinedSpeculativeServiceWorker" study has long expired and the "OmniboxSpeculativeServiceWorkerStartOnQueryInput" feature has been enabled by default in r541744. Bug: 732681 Change-Id: I08175813d67ed834eba31c080e5071248fb4a49e Reviewed-on: https://chromium-review.googlesource.com/954891Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#541917}
-
Justin Donnelly authored
After an option-enter navigation we should be displaying the URL. I'm a little nervous about changing this logic, but I've tried every kind of search and navigation I can think of and they all seem to still work correctly. Bug: 410707 Change-Id: I0d30ce7e23d6b98e4c99857e5b8226364398b758 Reviewed-on: https://chromium-review.googlesource.com/935672Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#541916}
-
Bartosz Fabianowski authored
App push-install log uploads are authenticated with the user's DMToken. It makes no sense to collect logs for any other users (e.g. kiosks, public sessions) as we would be unable to upload them anyway. Plus, trying to instantiate the logging framework in kiosk sessions leads to crashes as some singletons come up in an unexpected order. Bug: 811398 Test: Manual Change-Id: I827f3cd85accb423ac61bc5f6450753e9c6418cf Reviewed-on: https://chromium-review.googlesource.com/952904Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Bartosz Fabianowski <bartfab@chromium.org> Cr-Commit-Position: refs/heads/master@{#541915}
-
Katie D authored
The Chromevox instructions are a relative link. All the other links I added last were backwards. NOTRY=true Bug: none Change-Id: Iec684256f0d8ced7061aded6f3562ba0fde0be6f Reviewed-on: https://chromium-review.googlesource.com/956500Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#541914}
-
Troy Hildebrandt authored
Maybe third time's the charm. This patch is a minor refactoring of the URL bar margin logic in LocationBarLayout. It separates the calculation of the margin into a separate method to be overridden by the phone-specific LocationBarPhone. This way both the phone and tablet versions are happy, tests all pass, and everything looks as it should. The hope is that we can consolidate the layouts a little more in the near future. Bug: 816432,816376,819991 Change-Id: I4f8c18eae4f8d19c72e035a8aeae4ffb54b97400 Reviewed-on: https://chromium-review.googlesource.com/956013 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#541913}
-
Matthew Jones authored
This change removes two setters for the fullscreen manager and the tab model selector as they can be accessed in init from ChromeActivity. The height ratios of the sheet are now also referenced by their respective state. BUG=814528 Change-Id: I5a58a2ff367c7ad567d6b88b7bb8a3920632a57c Reviewed-on: https://chromium-review.googlesource.com/956342Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#541912}
-
Florin Malita authored
PrintToSkPicture currently uses a custom image serializer, but there is no corresponding custom deserializer in Skia -> we cannot deserialize these images. The historical reason for using a custom serializer is support for --skip-reencoding-on-skp-capture. This flag was added in https://crrev.com/1710553002, but is no longer used. The simplest fix for image serialization is to remove the custom proc and allow Skia to handle it instead. BUG=820142 Change-Id: Id19851811e23dd828b5fea7248874740cfda8dea Reviewed-on: https://chromium-review.googlesource.com/956025Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#541911}
-
Yixin Wang authored
Enable always-retransmittable-packet-on-wire behavior for QuicChromiumClientSessions with migrate_session_early(_v2) enabled. Change-Id: I007592fc9247dcbdee38cb964a0205576ec45de5 Reviewed-on: https://chromium-review.googlesource.com/953205 Commit-Queue: Yixin Wang <wangyix@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#541910}
-
Kurt Horimoto authored
This UIViewPropertyAnimator subclass records whether animations have been added and early returns before attempting to start an animator that has no animation blocks. This is necessary because the default implementations of |-startAnimation| and |-startAnimationAfterDelay:| throw exceptions if there are no animations. This CL also updates FullscreenAnimator to be optional, as there is no guarantee that FullscreenControllerObservers will add animation blocks to FullscreenAnimators. Bug: 819623 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1e73a7163f5bd9b82cf4ff693b290464ecec63cd Reviewed-on: https://chromium-review.googlesource.com/953793Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#541909}
-
Miguel Casas authored
Proposing dcastagna@ to join the //media/gpu OWNERS. The file is sorted alphabetically. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia96664905ec5cfbcd3879bcb7006b15db0ae6aeb Reviewed-on: https://chromium-review.googlesource.com/956287Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#541908}
-
Charles Harrison authored
This experiment ended a while ago, removing unused code and metrics Bug: 704117 Change-Id: I1149ef5efedf9e989fe957e4d7884a1296c64bc9 Reviewed-on: https://chromium-review.googlesource.com/955781Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#541907}
-
Yuqian Li authored
Bug: chromium:817110 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id2ccbca1f9ddc2f1073fd0532eb06fd335b98f0a Reviewed-on: https://chromium-review.googlesource.com/956034Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Yuqian Li <liyuqian@chromium.org> Cr-Commit-Position: refs/heads/master@{#541906}
-
Ken Rockot authored
Expose request body data to WebRequest listeners when Network Service is enabled. Bug: 721414 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I21d4a1baabd4f842a9af6a7442b070c4932b1b44 Reviewed-on: https://chromium-review.googlesource.com/954002 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#541905}
-
Finnur Thorarinsson authored
This allows the user to manually opt into using Windows native notifications instead of Chrome's version of the notifications. Note: This flag is ignored on versions of Windows old enough not to support native notifications. Bug: 734095, 516147 Change-Id: Ic5475e6fa13e29207a5d417efc996f16fdf997db Reviewed-on: https://chromium-review.googlesource.com/955244 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#541904}
-
Eugene But authored
The crash happens because contextForPendingNavigationWithURL returns null navigation context and receiving code expected a valid context object. Navigation context only exists for main frame navigations and will be null for iframes. This CL updates the code to avoid dereferencing context pointer for iframe navigations. Bug: 801161 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibd530f56ad1efc10a6f498118d63895c74b04b07 Reviewed-on: https://chromium-review.googlesource.com/953178Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#541903}
-
Hongchan Choi authored
Bug: 820110 Change-Id: I6402e7f40405a4c3a8cfa55a1aacedc3b7920912 Reviewed-on: https://chromium-review.googlesource.com/956095Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#541902}
-
Xi Cheng authored
Bug: 734095 Change-Id: Ib77b7a86351151cdb109fe86bbff291b1519f6c9 Reviewed-on: https://chromium-review.googlesource.com/953082 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#541901}
-
Donn Denman authored
This reverts commit 3364152a. Reason for revert: Broke the Android ARM64 builder (https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/28515) for some unknown reason. Original change's description: > [TTS] reland mojo-ify ShowUnhandleTapUIIfNeeded. > > Replaces the whole call chain for ShowUnhandledTapUIIfNeeded > between Blink and Chrome/WebView with Mojo messaging. > > Removes the Blink WebTappedInfo class in favor of a new UnhandledTapInfo > that sends a Mojo construct of the same name to the Browser which > has a service installed via a RenderHostFrame observer. > > All functionality should remain unchanged. > > NEW CODE: > The CSTabHelper now creates an UnhandledTapWebContentsObserver that > connects the Mojo service via UnhandledTapNotifierImpl. That Impl > calls back through Java to the CSTabHelper to the CSManager to notify > that a Tap has occurred. The CSTabHelper ignores these notifications > when CS is disabled. > > The mojo message is only sent to the browser if the tap is unhandled > and the other required conditions are met. > > UPDATED TESTS: > Test notification is now done through mojo messaging, so we now only > know if the tap was unhandled, not whether the page changed or other > details about why the tap was unhandled. > > Updated the test page by adding nodes that do not trigger, and removed > the mousemove handler since it's unrelated to tap handling. > > BUG=754862 > > TBR=dcheng@chromium, yfriedman@chromium.org, kinuko@chromium.org > > Original CL: > > Reviewed-on: https://chromium-review.googlesource.com/841544 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-on: https://chromium-review.googlesource.com/952679 > Commit-Queue: Donn Denman <donnd@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#541569} > Change-Id: I4da1704fe17fae6fe06d8a6167fbf9bc75a01303 > Reviewed-on: https://chromium-review.googlesource.com/956086 > Reviewed-by: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541879} TBR=dcheng@chromium.org,kinuko@chromium.org,yfriedman@chromium.org,donnd@chromium.org,yoichio@chromium.org,twellington@chromium.org,dcheng@chromium Change-Id: Ib49a16a10903e0b2ba52cf0e32e4f1883888b7b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 754862 Reviewed-on: https://chromium-review.googlesource.com/956356Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#541900}
-
Theresa authored
And fix up NTP tests. BUG=803095 Change-Id: I0b757c79ba6f0fe1b8a06cd7d4eaa700297b30ed Reviewed-on: https://chromium-review.googlesource.com/949090Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#541899}
-
Mustafa Emre Acer authored
This tool scans for any screenshots (png only) associated with grd files and uploads them to Google Cloud Storage using upload_to_google_storage.py. upload_to_google_storage.py is a tool that maintains content addressed files. It stores files with their sha1 hashes as filenames. The storage bucket name used in the tool is tentative. For details, see the design doc at http://go/chrome-translation-screenshots#heading=h.cyt0azox2105 Change-Id: Ide06aa679489a65887df9c58948c8adde12d3eba Bug: 814901 Reviewed-on: https://chromium-review.googlesource.com/922686 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#541898}
-
https://pdfium.googlesource.com/pdfium.git/+log/507fb4ed09d5..a724cb2df9f7 $ git log 507fb4ed0..a724cb2df --date=short --no-merges --format='%ad %ae %s' 2018-03-08 hnakashima Move GetPopupPos from CFWL_Widget to subclasses that call it. 2018-03-08 dsinclair Remove unused constructor 2018-03-08 dsinclair Cleanup CPDF_SimpleParser 2018-03-08 dsinclair CPDF_InterForm::ResetForm always returns true Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idc5571d6124b9bee5b698abfd1a82c9f7117daaf Reviewed-on: https://chromium-review.googlesource.com/955898 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541897}
-
erikchen authored
The concept of "working set" is specific to the Windows memory model. * Windows-only files were modified to directly invoke the Windows API. * os_metrics_linux.cc was modified to use RSS instead [which is what they really wanted]. * Two iOS files were incorrectly using GetWorkingSetSize() to return a task's "resident_size" as a rough measurement for total memory usage. This is inaccurate, since it includes reusable memory [used extensively by libMalloc for freeing objects]. This CL changes those two files to directly invoke the relevant mach APIs, and to subtract out reusable memory. * Remoting was using GetWorkingSetSize on all platforms, but the concept is only well defined on Windows. * MemoryCoordinator was calling GetWorkingSetSize from dead code. The dead code was removed. Bug: 819289 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I720e18ab483a9995982762cbd5ae1d045adfaa74 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/953723 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#541896}
-
Dave Tapuska authored
The bulk of this change is to revert commit 0b15dad9. It isn't a direct revert due to a number of things. - The ScopedComPtr interface that was widely used in the old patch no longer exists. - A number of interfaces change slightly (ImeTextSpans) - unsigned/signed compiler warnings This code was abandoned a few years ago and removed from the repository because it only worked in the Windows 8 Metro Mode of Chrome. Once that mode was removed the supporting IME code was removed as well. The code in its current form is functional but has issues which will be addressed in follow up patches. It is desirable to move to TSF since there are additional APIs that work via this API. Like text writing. Functionality common to both input methods are placed in InputMethodWinBase. InputMethodWin will be renamed to InputMethodWinImm32 in a followup patch. This feature is currently disabled but can be enabled via --enable-features=TSFImeSupport. No functionality changes are expected with the Imm32 implementation. Inputing text using Pinyin seems to work; as well as disabling DLL injection (crbug.com/557798) allows the IME to work correctly with TSF. There is some broken support with this change in that keydown/up messages, arrow keys in the omnibox are not delivered. I intend to fix these in followup changes being that this change is intended to make a previously reverted change available under a command line flag. BUG=657623 Change-Id: I89eb1a7ba6b9f95525df6fa83be5d923a03323b2 Reviewed-on: https://chromium-review.googlesource.com/916534 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#541895}
-
https://chromium.googlesource.com/angle/angle.git/+log/5242d5bf74d3..19fa1c6f8852 $ git log 5242d5bf7..19fa1c6f8 --date=short --no-merges --format='%ad %ae %s' 2018-03-08 jmadill Return an Error from Framebuffer::syncState. 2018-03-08 jmadill Vulkan: Use RenderTargetCache in FramebufferVk. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I00a6a1214c19650755b302ce9c307ccc8302a886 Reviewed-on: https://chromium-review.googlesource.com/955900 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541894}
-
Wenzhao Zang authored
Bug: 819135 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I239dab7a7ee1c9394f73e2dc51b411ed7c708305 Reviewed-on: https://chromium-review.googlesource.com/954331Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#541893}
-
Peter K. Lee authored
Final step 5 of cleaning up the provider API for MailtoHandlerProvider. Bug: 813821 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie454be3b22237a493f943869287b283e1bfe5227 Reviewed-on: https://chromium-review.googlesource.com/956237Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#541892}
-
