- 18 Aug, 2018 10 commits
-
-
Alex Moshchuk authored
The description now mentions that this metric is not reliable on Android. Bug: 875400 Change-Id: Ib0add3735f7d118504df5f23613339af56da542c Reviewed-on: https://chromium-review.googlesource.com/1180262Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#584255}
-
Lukasz Anforowicz authored
This CL flips the default value of features::kSitePerProcess on desktop to base::FEATURE_ENABLED_BY_DEFAULT. Bug: 874998 Change-Id: Ia1a999072e87cc32fbde1bb70f8bb39e9b3053a7 Reviewed-on: https://chromium-review.googlesource.com/1178622Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#584254}
-
Matt Mueller authored
The test depended on "host_resolver()->AddSimulatedFailure", which wasn't handled by the network service tests until https://chromium.googlesource.com/chromium/src/+/9690e08467150d094fd74f3db673c995cec2b78c Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id64f0eed2933a89d093a8f2328a1868009a57998 Reviewed-on: https://chromium-review.googlesource.com/1180472Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#584253}
-
rajendrant authored
Refactor the MaybeAllowImagePlaceholder() and MaybeAllowLazyLoadingImage() functions to checks and enable the placeholder request bit separately. This will help with lazyloading of CSS background images. Bug: 846170 Change-Id: I07dd50db59287c290ff0a7f0cc726dc23ed882e8 Reviewed-on: https://chromium-review.googlesource.com/1178637 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#584252}
-
Alexei Filippov authored
Change-Id: I1d2b25ee06997f3333e73e0380870d11d19843ee Reviewed-on: https://chromium-review.googlesource.com/1179474Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584251}
-
Lambros Lambrou authored
Mojo needs to be initialized, even in a single-process context, to fix a crash on startup. This CL removes the condition on remoting_multi_process for calling mojo::core::Init(). Bug: 875462 Change-Id: I021e5248aae850962c4ef53a506a2d06413aaf77 Reviewed-on: https://chromium-review.googlesource.com/1180499 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#584250}
-
Dominick Ng authored
This is an expanded and leak-fixed reland of crrev.com/c/1177641 and crrev.com/c/1176894, though it tackles the root of the problem rather than working around it. base::MessageLoopCurrent::SetTaskRunner() is deprecated since only owners of the MessageLoop instance should replace its TaskRunner. Odd things happen in tests when the message loop task runner is replaced and a profile is instantiated. This CL removes some more usage of the method in tests where there is interaction with a TestingProfile object. BUG=616447 Change-Id: Ic2ad6eb2a8699f103e432af74ad9c71c1dd43656 Reviewed-on: https://chromium-review.googlesource.com/1179111 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584249}
-
Xianzhu Wang authored
This reverts commit 8a53cc3a. Reason for revert: Performance regressions crbug.com/875321. BUG=875321 Original change's description: > [CI] Cleanup paint invalidation flags > > - Use separate flags HasDelayedFullPaintInvalidation and > SubtreeShouldDoFullPaintInvalidation in LayoutObject instead of using > paint invalidation reasons kSubtree and kDelayedFull to simplify logic > handling them. > > - Other cleanup and simplications > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I0946c042c80195dd6cf1d4a9e8c3554dbad1871d > Reviewed-on: https://chromium-review.googlesource.com/1123018 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583772} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I6f12dd7fe621f88e5a0fe1b96637b2ecc813e78e Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1180305 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584248}
-
Jennifer Apacible authored
Bug: 875170 TBR: altimin@chromium.org Change-Id: Ibf452c3fd02fba616e58d7fe9fb4377684126f67 Reviewed-on: https://chromium-review.googlesource.com/1180495Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#584247}
-
Nico Weber authored
Fixes fall-out from crrev.com/581138, which in turn fixed fall-out from crrev.com/579533 which fixed fall-out from crrev.com/579330. This makes stacks on the win/asan bots more readable again, and also fixes AddressSanitizerTests.TestAddressSanitizer, so that sbox_integration_tests can run on the win-asan bot. Bug: 875242 Change-Id: I660f3b8d2177fca97ab71bc8be43377ed4613f92 Reviewed-on: https://chromium-review.googlesource.com/1180284Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#584246}
-
- 17 Aug, 2018 30 commits
-
-
Tien-Ren Chen authored
Remove [ Timeout ] from external/wpt/cookies/http-state/domain-tests.html since it is already marked as slow. NOTRY=TRUE TBR=pdr@chromium.org BUG=875195 Change-Id: If55e788194015b93f32a98b8d93d8c3084037475 Reviewed-on: https://chromium-review.googlesource.com/1180504Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584245}
-
Jennifer Apacible authored
These are all now flaky. TBR=pkasting@chromium.org NOTRY=true (disabling tests) Bug: 875444 Change-Id: Ic756e6cb649c2cb54cd3f8371baf6afa94320035 Reviewed-on: https://chromium-review.googlesource.com/1180502Reviewed-by:
-
Lei Zhang authored
BUG=845250 Change-Id: Ifad55ab66e7c3bf99896a9be3dfc3c62a4e58832 Reviewed-on: https://chromium-review.googlesource.com/1178984Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584243}
-
Ben Pastene authored
Bug: 646404 Change-Id: Ie047903220a329f1d7731eec04c22c26fcf69b88 Reviewed-on: https://chromium-review.googlesource.com/1180419 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#584242}
-
Tien-Ren Chen authored
animations/interpolation/svg-stroke-dasharray-interpolation.html external/wpt/cookies/http-state/domain-tests.html TBR=pdr@chromium.org NOTRY=TRUE BUG=875170,875195 Change-Id: I0ecce2b5c62e673ab3dadd3b5724c6fb827309ad Reviewed-on: https://chromium-review.googlesource.com/1180468 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
-
Wenzhao Zang authored
1) Verified with --show-webui-login on multiple cases to make sure M69 is working. 2) Implementation of transitioning between OOBE and views login is WIP. It is a must-have before deprecating web-ui login code. Bug: 875128 Change-Id: I1e5cf08d9c978834830ca0d952f61b26b558a7b7 Reviewed-on: https://chromium-review.googlesource.com/1180475Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#584240}
-
Mrunal Kapade authored
This patch implements navigator.getWakeLock(WakeLockType) and other necessary interfaces such as WakeLock and WakeLockRequest to provide acesss to Screen wakelock for now. Latest WakeLock API spec can be seen here, https://www.w3.org/TR/wake-lock. Intent to Implement, https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/KMNZmMF1_H4 Bug: 257511 Change-Id: I7fa4d0f7f287d7497b48f583e18e0ca5ca39e662 Reviewed-on: https://chromium-review.googlesource.com/918062 Commit-Queue: Mrunal Kapade <mrunal.kapade@intel.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#584239}
-
Kevin Marshall authored
QEMU will soon be removed from the Fuchsia SDK tarball. This CL migrates our scripts to source QEMU from CIPD instead. Change-Id: I2347a5be598a1eecd2d7c9e6c431b55c3eab1189 Reviewed-on: https://chromium-review.googlesource.com/1178975 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584238}
-
Jennifer Apacible authored
TBR=pkasting@chromium.org NOTRY=true (disabling tests) Bug: 875195 Change-Id: I774947560cb501d60e24fc64b617ab6cc6653716 Reviewed-on: https://chromium-review.googlesource.com/1180486Reviewed-by:
-
Carlos IL authored
RecurrentSSLInterstitial is launching and has been enabled by default on trunk, this CL removes the experiment from fieldtrial_testing_config.json. Bug: 840575 Change-Id: I14f3c9862096807dcbc495e26d13e548b4c4168b Reviewed-on: https://chromium-review.googlesource.com/1180406Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#584236}
-
Azeem Arshad authored
This adds a StartServiceWorkerAndDispatchLongRunningMessage call in ConnectionEstablisherImpl to initiate background connection between Android Messages for Web service worker to and the Tachyon backend. Bug: 850823 Change-Id: I71b448b46f5802f741a1d7b6b4f09367defb0365 Reviewed-on: https://chromium-review.googlesource.com/1180417Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#584235}
-
Jared Saul authored
Bug: 848955 Change-Id: I4dbd64bd97a8483434fc247ca428dd4bacb4846d Reviewed-on: https://chromium-review.googlesource.com/1176428Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#584234}
-
Adenilson Cavalcanti authored
Optimizations can have different impact depending on the compression level used. It is quite handy to be able to change the compression level used for experiments while optimizing zlib. This patch adds an optional flag (-compression) to allow passing the desired compression level (0 to 9). To keep consistency, the user has to pass the target wrapper format (e.g. -wrapper gzip|zlib|raw). Finally, a help parameter is now supported (i.e. ./zlib_bench -h | --help) that will print the expected parameters while invoking the tool. Change-Id: I0b29fc2bd31bfccc39a7b7a10b510d9ca46d47e2 Reviewed-on: https://chromium-review.googlesource.com/1180341 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#584233}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3f621b000733..df1dcd998db4 git log 3f621b000733..df1dcd998db4 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 dgarrett@google.com chromeos_config: Stop building link-depthcharge-full-firmware. Created with: gclient setdep -r src/third_party/chromite@df1dcd998db4 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I17b0be199fc1ef5a4c9595fb629c9a7d639bba5f Reviewed-on: https://chromium-review.googlesource.com/1180142Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584232}
-
Alex Moshchuk authored
This reverts commit 71426a90. Reason for revert: Causing cookies and localStorage renderer kills involving the Drive app. I found a local repro where an app covers both http and https versions of a site, and a renderer-initiated navigation from http to https does not trigger a process transfer as it should. Original change's description: > Lock hosted apps to their underlying web origin. > > Previously, hosted apps were exempt from LockToOrigin() even in > --site-per-process mode. That meant that hosted apps were not subject > to enforcements such as not allowing access to cookies, passwords, or > local storage of other sites. Worse, it meant that hosted apps could > arbitrarily share a process (e.g., when over process limit), even if > they covered different web sites with --site-per-process. > > This CL starts locking hosted apps to their underlying web origin. If > a frame commits a navigation to URL http://foo.com, which is part of a > hosted app X's web extent, the process for that frame will be locked > to http://foo.com. Note that the SiteInstance for this frame will > still use a site URL based on the effective URL (i.e., > chrome-extension://<ext_id_for_X>/), but the origin lock will not be > based on effective URLs. This requires plumbing to compute the origin > lock as a site URL that does not use an effective URL, and to plumb it > into various places that make process model decisions, such as > RPHI::IsSuitableHost(). > > Bug: 811939, 794315, 791796 > Change-Id: Icc9b3c0a04253e581ea35953f3c566308305db59 > Reviewed-on: https://chromium-review.googlesource.com/959346 > Commit-Queue: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583895} TBR=creis@chromium.org,rdevlin.cronin@chromium.org,alexmos@chromium.org Change-Id: Ie459ef9b61eb78b6dad44e253768d8c4234e6abf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 811939, 794315, 791796 Reviewed-on: https://chromium-review.googlesource.com/1180308Reviewed-by:
-
Tien-Ren Chen authored
TBR=pfeldman@chromium.org BUG=875265 Change-Id: I672626fa22f47534745adcf61775ff7eef904420 Reviewed-on: https://chromium-review.googlesource.com/1180433Reviewed-by:
-
Etienne Pierre-doray authored
This CL adds trace event "SchedulerWorkerThread alive" to track lifespan of a SchedulerWorker. Change-Id: Id1a6be3a9235a0522c7618918c3453423db153e3 Reviewed-on: https://chromium-review.googlesource.com/1172925Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#584229}
-
Emircan Uysaler authored
This CL adds getDisplayMedia() calls going through MediaStreamCaptureIndicator into the existing |desktop_stream_count_|. Bug: 326740 Change-Id: I4c16e41c281d96bd9012b4bb66381d5c81d351ca Reviewed-on: https://chromium-review.googlesource.com/1180097Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Reviewed-by:
-
Penny MacNeil authored
Don't initialize third_party_dlls if the beacon says not to. Test: chrome_elf_unittests.exe Change-Id: I5334d82eb11ecfcc026ed1bfaf25a02070830e59 Reviewed-on: https://chromium-review.googlesource.com/1180267Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#584227}
-
Jun Choi authored
Once UI for showing users to authenticate using Touch Id authenticator is rendered, dispatch request to device/fido layer. Bug: 847985 Change-Id: I9531d412e5c3f6626a6a80bb3b1b6128712c132e Reviewed-on: https://chromium-review.googlesource.com/1177442 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#584226}
-
Jennifer Apacible authored
TBR=pkasting@chromium.org NOTRY=true (disabling tests) Bug: 875444 Change-Id: I03d723f877a4ef001e16487739d661142f36c37f Reviewed-on: https://chromium-review.googlesource.com/1180429Reviewed-by:
-
Tien-Ren Chen authored
TBR=dewittj@chromium.org,jianli@chromium.org BUG=875433 Change-Id: Ie19eea6bc5b131884f6f25d3ba0ad1fe4b9dc9ad Reviewed-on: https://chromium-review.googlesource.com/1180358Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/54ff302cdc5a..ff6a73cc08af git log 54ff302cdc5a..ff6a73cc08af --date=short --no-merges --format='%ad %ae %s' 2018-08-17 mtklein@google.com add rec2020 configs to DM 2018-08-17 robertphillips@google.com Pull non-substantive changes out of GrShape mask drawing CL 2018-08-17 reed@google.com try to help res-scaling in perspective 2018-08-17 robertphillips@google.com Reland "Make directFilterMaskGPU & directFilterRRectMaskGPU no longer require canFilterMaskGPU's permission" 2018-08-17 recipe-roller@chromium.org Roll recipe dependencies (nontrivial). 2018-08-17 kjlubick@google.com [PathKit] Add conic tests and re-create expectations. 2018-08-17 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 3394a73db973..43a2762db19a (1 commits) 2018-08-17 kjlubick@google.com [PathKit] Rework API to avoid extra copies unless explicitly called for. 2018-08-17 caryclark@skia.org update doc index Created with: gclient setdep -r src/third_party/skia@ff6a73cc08af The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Iadc4ac9d71bd79276fc8da58cfd5bdb58263ec39 Reviewed-on: https://chromium-review.googlesource.com/1180321Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584223}
-
Toni Barzic authored
Device getting enterprise enrolled, and then used should be a good signal that demo mode resources are no longer needed. An exception is made for demo mode implemented through public sessions (as it's the case today) - in that case retailer might attempt to swich to the revamped demo mode sessions, so might need the resources after all. BUG=827368 Change-Id: Ia5645b059050f9d7858ba34acd84201969b88b71 Reviewed-on: https://chromium-review.googlesource.com/1176652 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584222}
-
Devlin authored
This reverts commit f41f215c. Reason for revert: Checking to see if this was the cause of flakiness in a test. Original change's description: > [Extensions] Introduce common client initialization > > In order to extract apps-specific code from extensions, we'll need to > be able to add extra information to the extensions client from outside > extensions code. This will require having a centralized initialization > for the extensions client. > > Introduce a single method, EnsureExtensionsClientInitialized(), which > constructs and sets the ChromeExtensionsClient. Remove the old way of > constructing the client, ChromeExtensionsClient::GetInstance(). Update > all callers to construct the client via the new method. > > While we're at it, update the client to use base::NoDestructor instead > of LazyInstance. > > Bug: 873937 > Change-Id: I47147cd5f33ea44079c0a319626c57f3c5813af8 > Reviewed-on: https://chromium-review.googlesource.com/1175459 > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583217} TBR=thestig@chromium.org,rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 873937 Change-Id: I750a4cde4d76054fc82f91bac8e63413f9599b9e Reviewed-on: https://chromium-review.googlesource.com/1179347Reviewed-by:
-
Dan Sanders authored
When playing silence, many samples are small enough that squaring them results in a denormal float. On some AMD CPUs this results in significantly reduced performance. This patch configures the SSE floating point environment to flush denormals and to treat denormals as zero. Bug: 531026 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If3842a22f6dc9bef76d87b0a6db069c3f9234d19 Reviewed-on: https://chromium-review.googlesource.com/1179361 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584220}
-
Alex Newcomer authored
UX requests we disable context menus on the back button and overflow buttons in the shelf. Removed tests for these cases and added new ones for not showing the menus. Bug: 875334 Change-Id: I45c320a148e8f7ad39abd0e8181e59e3c4b663fe Reviewed-on: https://chromium-review.googlesource.com/1180073Reviewed-by:
-
Fredrik Söderquist authored
There's no real reason to give 'tabindex' preferential treatment (not anymore at least.) Just let it be handled by the common fall-through code-path and flatten the structure of the code a bit. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I96e6c265aeb384fe1acc0b61378078bb3d06051c Reviewed-on: https://chromium-review.googlesource.com/1179886 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584218}
-
Charles Zhao authored
(1) TabLifecycleObserver is added for TabActivityWatcher to track OnDiscardedStateChange event. (2) In DidReplace(replaced_tab), the ukm_source_id and is_discarded state is copied to new_tab so that we can track discarded state after reload or closing. (3) A browser test is added. Change-Id: I9777b515d28d215f3409525b0201dc5916d35941 Bug: 872139 Change-Id: I9777b515d28d215f3409525b0201dc5916d35941 Reviewed-on: https://chromium-review.googlesource.com/1166763Reviewed-by:Chris Hamilton <chrisha@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#584217}
-
Becca Hughes authored
Add a list of media sessions and their state to a new audio focus tab on media internals. BUG=870418 Change-Id: I654b9444c1abc3f5ae12c29d070627e137f5e137 Reviewed-on: https://chromium-review.googlesource.com/1161500 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#584216}
-
