GitLab

Change-Id: I34e8872d1011d143810a2f6b53a238e517785bf2
Reviewed-on: https://chromium-review.googlesource.com/1255045Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595844}

Focus ring around MessageView should be painted on top of all the
children.

TEST=manual
BUG=887366

Change-Id: I5667aff33196a5f3f8792b4e936e7da1cdda1057
Reviewed-on: https://chromium-review.googlesource.com/1255750Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595843}

I have confirmed with the test case in https://github.com/catapult-project/catapult/issues/4490
that the navigation id in document loader is the correct id.  Adding an id to the
document itself is not the same between navigation and fcp.

Bug: 850258,catapult:4490
Change-Id: I4028bcb13d90a5a1a765890fe02e346d496fab7a
Reviewed-on: https://chromium-review.googlesource.com/1249533
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595842}

TestingFactory is a base::Callback<> while TestingFactoryFunction
is a function pointer. Convert UserCloudPolicyManagerFactory to
the callback based type.

Bug: 809610
Change-Id: If041d74cf623b29672c90351460f23be9a5fb24d
Reviewed-on: https://chromium-review.googlesource.com/1245713
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595841}

../../third_party/blink/renderer/core/loader/image_loader.h:257:5: warning:
explicitly defaulted move constructor is implicitly deleted
[-Wdefaulted-function-deleted]
    DecodeRequest(DecodeRequest&&) = default;
    ^
../../third_party/blink/renderer/core/loader/image_loader.h:252:25: note: move
constructor of 'DecodeRequest' is implicitly deleted because base class
'GarbageCollected<blink::ImageLoader::DecodeRequest>' has a deleted move
constructor
  class DecodeRequest : public GarbageCollected<DecodeRequest> {
                        ^
../../third_party/blink/renderer/core/loader/image_loader.h:262:20: warning:
explicitly defaulted move assignment operator is implicitly deleted
[-Wdefaulted-function-deleted]
    DecodeRequest& operator=(DecodeRequest&&) = default;
                   ^
../../third_party/blink/renderer/core/loader/image_loader.h:252:25: note: move
assignment operator of 'DecodeRequest' is implicitly deleted because base class
'GarbageCollected<blink::ImageLoader::DecodeRequest>' has a deleted move
assignment operator
  class DecodeRequest : public GarbageCollected<DecodeRequest> {

../../third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory.h:36:27:
warning: explicitly defaulted move assignment operator is implicitly deleted
[-Wdefaulted-function-deleted]
  P2PQuicTransportConfig& operator=(P2PQuicTransportConfig&&) = default;
                          ^
../../third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_factory.h:41:33:
note: move assignment operator of 'P2PQuicTransportConfig' is implicitly
deleted because field 'packet_transport' is of const-qualified type
'blink::P2PQuicPacketTransport *const'
  P2PQuicPacketTransport* const packet_transport;
                                ^

Bug: 890307
Change-Id: I5bcb4e343ae96f26d20f1e772d1442d1edbdb105
Reviewed-on: https://chromium-review.googlesource.com/1256942
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595840}

Moving to a new dns_config.cc/h to separate the public struct from the
component-private DnsConfigService. Creates a better place for a new
DnsConfigOverrides struct that I'll be adding soon for the servicified
DNS config manipulation work.

TBR=mef@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: I5e02cc29b47851ea5295d2ec7d17b381b124d97a
Reviewed-on: https://chromium-review.googlesource.com/1255783
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595839}

input_predictor_unittest.cc is used purely as a header file so
it should have the .h suffix. Now it looks like some .cc files
are trying to include another .cc file.

The class was too large to have an implicit inline
constructor/destructor so those remain in a cc file. This presubmit
check didn't work before because the file was named *.cc.

Change-Id: I67740f4181ea60d02cd3149ce57b0d4e8c36aaf2
Reviewed-on: https://chromium-review.googlesource.com/1255638Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#595838}

Replace them with uses of TestingFactory which is based
on base::Callback<> instead of function pointers.

This converts uses in /chrome/browser/safe_browsing/incident_reporting.

This CL was uploaded by git cl split.

R=robertshield@chromium.org

Bug: 809610
Change-Id: Id58fcdc5a649e33a68effc8e774be09beb930ed0
Reviewed-on: https://chromium-review.googlesource.com/1246169
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595837}

https://skia.googlesource.com/skia.git/+log/16c9216905c1..9e92782016c4


git log 16c9216905c1..9e92782016c4 --date=short --no-merges --format='%ad %ae %s'
2018-10-02 caryclark@skia.org fix path addrrect example in docs


Created with:
  gclient setdep -r src/third_party/skia@9e92782016c4

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=mtklein@chromium.org

Change-Id: I6272354423f082e3a79bd64c4cbb386734ce04de
Reviewed-on: https://chromium-review.googlesource.com/1256240Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595836}

Eliminating email notifications and code reviews that are no longer
relevant.

Bug: N/A
Change-Id: Ida73132009087c43440fc3e324d8852f096bcf5d
Reviewed-on: https://chromium-review.googlesource.com/1255724Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Pam Greene (Please send IM for reviews) <pam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595835}

This reverts commit 46f49dac.

Reason for revert: reverting the original change breaks other bots, such as https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29 an it does not fix the problem on  WebKit Mac 10.13 Retina anyway.

Original change's description:
> Revert "remove SK_SUPPORT_LEGACY_SVG_ARC_TO"
> 
> This reverts commit 05ee0393.
> 
> Reason for revert: Sheriff reverting due to several paint-invalidation failing on the bot WebKit Mac 10.13 Retina.
> See https://crbug.com/891230
> 
> Original change's description:
> > remove SK_SUPPORT_LEGACY_SVG_ARC_TO
> > 
> > Change-Id: I330bdfe4dcbfed55a03385043e703af6fe070ffd
> > Reviewed-on: https://chromium-review.googlesource.com/1254341
> > Commit-Queue: Mike Reed <reed@chromium.org>
> > Reviewed-by: Florin Malita <fmalita@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#595627}
> 
> TBR=fmalita@chromium.org,reed@chromium.org
> 
> Change-Id: Ica1ccdd43953772d40c70d22f3fc399df7dd56b1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 891230
> Reviewed-on: https://chromium-review.googlesource.com/1256825
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Commit-Queue: Camille Lamy <clamy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595805}

TBR=fmalita@chromium.org,clamy@chromium.org,reed@chromium.org

Change-Id: If0cd979dc3772397f1631d01efc8e08911ecd98c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891230
Reviewed-on: https://chromium-review.googlesource.com/1256375Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595834}

https://chromium.googlesource.com/catapult.git/+log/59297c6f73a6..48348e91f2d7


git log 59297c6f73a6..48348e91f2d7 --date=short --no-merges --format='%ad %ae %s'
2018-10-02 achuith@chromium.org oobe: Catch the right WebSocketException.


Created with:
  gclient setdep -r src/third_party/catapult@48348e91f2d7

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:879353
TBR=sullivan@chromium.org

Change-Id: Ie2201501881dfd170f964cf9312fecef7f48e59e
Reviewed-on: https://chromium-review.googlesource.com/1256238Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595833}

Bug: 832676
Change-Id: Iaac83b8248816993554baeefc03740d21f870370
Reviewed-on: https://chromium-review.googlesource.com/1256145Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595832}

This reverts commit 3efff7c9.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 595787 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vM2VmZmY3YzlkOGMxZTUzYTg5NGE5YmY1MTY2MTVhNWM3ZjliMjU2Ygw

Sample Failed Build: https://ci.chromium.org/buildbot/tryserver.chromium.win/win10_chromium_x64_rel_ng/106570

Sample Failed Step: sync_integration_tests (with patch) on Windows-10-15063

Sample Flaky Test: USS/SingleClientWalletSyncTest.ClearOnStopSync/1

Original change's description:
> Consistently clear server credit cards with USS
> 
> AutofillWalletDataTypeController is used (pre-USS) for both AUTOFILL_WALLET_DATA
> and AUTOFILL_WALLET_METADATA. When Sync is stopped, it calls
> PersonalDataManager::ClearAllServerData. Since there are two instances of the
> controller, that happens twice (which is unnecessary but doesn't hurt). However,
> when AUTOFILL_WALLET_DATA is on USS, then the remaining ClearAllServerData call
> (for the metadata controller) still happens, which brings Sync into a bad state
> since the data is now gone, but the progress marker is still there (see bug 885211).
> 
> This CL changes AutofillWalletDataTypeController to only call ClearAllServerData
> for AUTOFILL_WALLET_DATA (i.e. it won't be called anymore if Wallet is on USS).
> Instead, AUTOFILL_WALLET_DATA gets special-cased in ModelAssociationManager to
> clear even in the STOP_SYNC case. This achieves the same "clear data on stopping
> sync, but *not* on browser shutdown", but without requiring a special side channel
> to the SyncService.
> 
> One consequence is that with AUTOFILL_WALLET_DATA on USS, the clearing now happens
> asynchronously (because it goes through the DB), which requires some test changes.
> 
> Bug: 889941
> Change-Id: I54c36050c81fa862acfc0052f355ff1645a8b292
> Reviewed-on: https://chromium-review.googlesource.com/1251041
> Commit-Queue: Marc Treib <treib@chromium.org>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Reviewed-by: Jan Krcal <jkrcal@chromium.org>
> Reviewed-by: Florian Uunk <feuunk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595787}

Change-Id: I429e5ef10c8d5b858f36ce69cc2b41b30e318fd4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 889941, 891254
Reviewed-on: https://chromium-review.googlesource.com/1255573
Cr-Commit-Position: refs/heads/master@{#595831}

BundledConnectionHelp is ready to launch, flipping flag to enabled and
cleaning up fieltrial_testing_config.json before submitting the
new variations config.

Bug: 803178
Change-Id: Iee7297e4d58b073126585a2143412b6dadf41510
Reviewed-on: https://chromium-review.googlesource.com/1255383Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595830}

Set mode to UPDATE for Mirror and log it. Needed for CL on logging which has a higher priority than the one where mode will actually be used. Use VLOG(1) to make variable and used somewhere.

Change-Id: I0eb3def674b510a5a5ca433f62540a027fa1cc25
Reviewed-on: https://chromium-review.googlesource.com/1255823
Commit-Queue: Valeriya Sinevich <valeriyas@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595829}

This re-implements functionality Ash would normally provide via
WorkspaceEventHandler (double click/tap on frame for maximize) and
WmToplevelWindowEventHandler (drag).

Dragging by gesture is a TODO, and may be more complicated. (It doesn't
work for tab-initiated drags either.)

Change-Id: Ie9eff39915dd6ea68dcc69ac9b46d6edda78f23f
Reviewed-on: https://chromium-review.googlesource.com/1246417Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595828}

Add disable_histogram_support gn argument. If set to "true", then GetHistogramDeltas()
support is disabled, and Cronet size is reduced by about 200 kilobytes.

Bug: 830005
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: I34806415bc08e700e8753e728572da896f1edf04
Reviewed-on: https://chromium-review.googlesource.com/1256122
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595827}

This is a reland of e195437f

The first version of this change was broken because ActionDelegate::StopCurrentScript() was not abstract (pure virtual).

This was fixed in this CL by adding "= 0"; at the function declaration in action_delegate.h.

Original change's description:
> [Autofill Assistant] Add StopCurrentScript() in ActionDelegate.
>
> Bug: 806868
> Change-Id: Ic3deb3353377e950fadc0d011c75f7ed91ca5366
> Reviewed-on: https://chromium-review.googlesource.com/1250923
> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595445}

Bug: 806868
Change-Id: Ic57f8607844267c98d0ab5ece8a253ae853ec325
Reviewed-on: https://chromium-review.googlesource.com/1256184Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595826}

Using wpt-import in Chromium fa730bd6.
With Chromium commits locally applied on WPT:
92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default."
a9d61b8e "Implement RTCIceTransport.onselectedcandidatepairchange"
3e89d0d3 "Revert "Implement RTCIceTransport.onselectedcandidatepairchange""
8c84af9b "Update beacon WPTs"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25750

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Iadde7e4f5b043b863122ad6c11c78e2f14bc8d7e
Reviewed-on: https://chromium-review.googlesource.com/1256237
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595825}

Every file has been moved to AppBarViewControllerPresenting. Safe to delete AppBarPresenting now.

Bug: 874471
Change-Id: I5c1edc13f1b9a8288c99fcb7b6e13f4ef7e70066
Reviewed-on: https://chromium-review.googlesource.com/1251762Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595824}

https://webrtc.googlesource.com/src.git/+log/895ce82cabc8..73d117f64ebb


git log 895ce82cabc8..73d117f64ebb --date=short --no-merges --format='%ad %ae %s'
2018-10-02 brandtr@webrtc.org Split WebRTC-UseShortVP8TL3Pattern field trial in two.
2018-10-02 philipp.hancke@googlemail.com getStats: add relayProtocol
2018-10-02 aleloi@webrtc.org Reduce digital adaptive AGC2 gain in some situations.


Created with:
  gclient setdep -r src/third_party/webrtc@73d117f64ebb

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ifd5ada35335256725d83210eb85a0032af7ff85f
Reviewed-on: https://chromium-review.googlesource.com/1256236Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595823}

New content to the offline page will mean it's currently possible to
scroll down the page and inadverently activate the offline dino game.

This change ensures the game canvas is mostly  in the viewport before
allow the game to start.

Bug: 873343
Change-Id: I04d874f71480b3aac20a24373466626e3372f246
Reviewed-on: https://chromium-review.googlesource.com/1240339Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Edward Jung <edwardjung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595822}

Previously custom element default style is passed to the constructor,
adding a CSSStyleSheet parameter to multiple parts of code. This change
removes that and instead sets the default style after the definition
has been built, in CustomElementRegistry::DefineInternal

Bug: 824684
Change-Id: Ic544561830cced77e946ae43491e6ee989511117
Reviewed-on: https://chromium-review.googlesource.com/1256263Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595821}

Both some Win32 headers and OpenSSL/BoringSSL defines some
constant macros like X509_NAME. To avoid that clash we have
a wrapper for <wincrypt.h>, crypto/wincrypt_shim.h Use that
one in chrome/chrome_cleaner/os/system_util.h too since
that header might be used close to OpenSSL code.

Change-Id: I678b5aa1658e8436eed4b431e6c2950ce7acfb3b
Reviewed-on: https://chromium-review.googlesource.com/1255825Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#595820}

If the device's size class has changed from RegularXRegular to another or
reversely, the find bar should switch between regular mode and compact mode
accordingly. Hide and then reshow the findbar in BVC.traitCollectionDidChange
if the size class changed.

Bug: 883672
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I38872c3fd0911e0e99ffae87f51f90c0cf9082fb
Reviewed-on: https://chromium-review.googlesource.com/1256690
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595819}

This reverts commit e186dbf7.

Reason for revert: Introduced flakyness in virtual/user-activation-v2/fast/events/middleClickAutoscroll-drag.html.

See https://crbug.com/891155

Original change's description:
> Convert middleClickAutoscroll.js to use gpu benchmarking
> 
> This cl converts middleClickAutoscroll.js and the middle click autoscroll
> layout tests that are using it to use gpu benchmarking.
> 
> Bug: 875945
> Change-Id: Ic5acb4367dd406de3e5897063bfe6b1b44e7daa6
> Reviewed-on: https://chromium-review.googlesource.com/1251901
> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> Commit-Queue: Sahel Sharify <sahel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595596}

TBR=nzolghadr@chromium.org,sahel@chromium.org

Change-Id: I108620182b4466997df7734f01718e102628fcf6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 875945
Reviewed-on: https://chromium-review.googlesource.com/1256923Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595818}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9c1070ec18e9..e928488baf66


Created with:
  gclient setdep -r src-internal@e928488baf66

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ic0e355a7049e874b7e2f90acdc8eb02ac1fbf76b
Reviewed-on: https://chromium-review.googlesource.com/1256235Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595817}

Reland of https://crrev.com/c/1245786 that was reverted by
https://crrev.com/c/1255456 due to a build failure.

This CL replaces Chrome-specific tinting view classes with their
AppCompat equivalents: TintedImageView -> AppCompatImageView and
TintedImageButton -> AppCompatImageButton.
1. Entries in XML layouts have fully qualified names because some
   layouts are inflated outside AppCompatActivity, so AppCompat magic
   doesn't work for them.
2. AppCompatImageView doesn't have setTint, so
   ImageViewCompat.setImageTintList is used instead.
3. AppCompatImageView uses 'tint' XML attribute instead of 'chrometint',
   so these are replaced, too.

TBR=tedchoc@chromium.org

Bug: 727723
Change-Id: Iedc6337e2f58c60de2d19cd3ac1787ec7ae7b16e
Reviewed-on: https://chromium-review.googlesource.com/1256783Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595816}

This change matches the behavior of Edge, Firefox and the spec:
https://html.spec.whatwg.org/multipage/rendering.html#flow-content-3

Bug: 612424
Change-Id: Ib085301f732b259f2789d50b92aff9e12dcf4ae7
Reviewed-on: https://chromium-review.googlesource.com/1254724Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595815}

Adds support for showing shortcuts in the popup view controller when no
suggestions are shown.

Since the actual shortcuts are not implemented yet, a placeholder is
displayed.

Bug: 886897
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ie9afb4933b42b846d5177c1024feebf9241afdee
Reviewed-on: https://chromium-review.googlesource.com/1233706
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595814}

../../components/zucchini/disassembler.h:100:3: warning: explicitly defaulted
default constructor is implicitly deleted [-Wdefaulted-function-deleted]
  ReferenceGroup() = default;
  ^
../../components/zucchini/disassembler.h:144:23: note: default constructor of
'ReferenceGroup' is implicitly deleted because field 'traits_' has no default
constructor
  ReferenceTypeTraits traits_;
                      ^

Bug: 890307
Change-Id: Ic7ec04e175f4fb3cc9a32e6a43115485f671b72f
Reviewed-on: https://chromium-review.googlesource.com/1256805Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595813}

Remove some redundant parameters of
FindBarControllerIOS::addFindBarViewToParentView:usingToolbarView:selectText:animated.

Bug: 879136
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I47dbefdfbadcd160f3466a39ea6b75d90c2e8c78
Reviewed-on: https://chromium-review.googlesource.com/1254722
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595812}

R=tangltom@chromium.org, msarda@chromium.org
BUG=890925

Change-Id: Ibbcd8c86e6398d2d5abbe55536297195f8b00afc
Reviewed-on: https://chromium-review.googlesource.com/1254148
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595811}

Bug: 860467
Change-Id: I47a07d4b3a518c1bf109483b80e8951b9fa93aa7
Reviewed-on: https://chromium-review.googlesource.com/1251626
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595810}

This reverts commit f990835b.

Reason for revert: Breaks H264 profile negotiation in some cases.

Original change's description:
> WebRTC: Migrate completely to new video codec factories API
> 
> This CL is a reland of
> https://chromium-review.googlesource.com/c/chromium/src/+/788410
> 
> This CL makes the Chromium HW video factories implement the new
> interfaces directly. It also adds SW codecs, simulcast, and SW fallback
> codecs manually, instead of relying on WebRTC to do this. This will
> give Chromium more flexibility in the future, and will allow us to
> simplify the WebRTC code, since it's only Chromium that uses some of
> these features.
> 
> Bug: webrtc:7925
> Change-Id: Ib66ec75827363dc9e0985c35a6de936ca8f3a523
> Reviewed-on: https://chromium-review.googlesource.com/1100463
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> Commit-Queue: Anders Carlsson <andersc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580144}

TBR=haraken@chromium.org,emircan@chromium.org,hiroh@chromium.org,andersc@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:7925
Change-Id: I4b9c7ef3c386d310156611898ecbd552df8c1520
Reviewed-on: https://chromium-review.googlesource.com/1255636
Commit-Queue: Anders Carlsson <andersc@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595809}

This reverts commit 1c700bea.

Reason for revert: Causes flakiness on the WebGL2 video tests on Mac. See crbug.com/891249

Original change's description:
> [media] Reland: Fix video to canvas GPU-CPU race.
> 
> VideoFrames marked with VideoFrameMetadata::READ_LOCK_FENCES_ENABLED
> must be retained until all reads have been completed. Such frames are
> produced when software frames are uploaded to GpuMemoryBuffers. The
> VideoResourceUpdater handles this, but PaintCanvasVideoRenderer
> implemented only sync tokens.
> 
> As a result, WebGL reads of software-decoded frames can tear when the
> storage is reused for later frames.
> 
> This CL adds a GL_COMMANDS_COMPLETED_CHROMIUM query after each potential
> VideoFrame read in PaintCanvasVideoRenderer, and retains a reference to
> the VideoFrame until it completes. This ensures that the memory is not
> reused until after the reads complete in the GPU process.
> 
> TBR=pfeldman@chromium.org
> 
> Bug: 819914
> Change-Id: Id181a476b78e2799bdbff149c9655427ae552743
> Reviewed-on: https://chromium-review.googlesource.com/1252962
> Commit-Queue: Dan Sanders <sandersd@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595676}

TBR=pfeldman@chromium.org,tedchoc@chromium.org,sandersd@chromium.org,sunnyps@chromium.org,piman@chromium.org

Change-Id: I5a1c66dc55ef5d4a5980704ef97dadea7ab41051
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 819914
Reviewed-on: https://chromium-review.googlesource.com/1256372Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595808}

V8 compile options related to producing code caches
(kProduceParserCache, kProduceCache, kProduceFullCodeCache)
are no longer supported and would be deprecated. This cl
fixes chrome to not use those options. V8 provides
an explicit API (CreateCodeCache) to generate code caches.


Change-Id: I8039c6e4ef84133af5b1e406f10fbd5b166acdb4
Reviewed-on: https://chromium-review.googlesource.com/1254147
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595807}

echo_control_mobile() and echo_cancellation() interfaces are replaced
with AudioProcessing::Config.

Some configuration is now hardcoded defaults in APM, and hence should
not (can not) be configured in these processors.

Statistics are now accessed through AudioProcessing::GetStatistics.

A UMA metric disappears.

Bug: webrtc:9535
Change-Id: Ia23d58cf1a1315605beef3ec72e080844bb94e5d
Reviewed-on: https://chromium-review.googlesource.com/1243123Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Sam Zackrisson <saza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595806}

This reverts commit 05ee0393.

Reason for revert: Sheriff reverting due to several paint-invalidation failing on the bot WebKit Mac 10.13 Retina.
See https://crbug.com/891230

Original change's description:
> remove SK_SUPPORT_LEGACY_SVG_ARC_TO
> 
> Change-Id: I330bdfe4dcbfed55a03385043e703af6fe070ffd
> Reviewed-on: https://chromium-review.googlesource.com/1254341
> Commit-Queue: Mike Reed <reed@chromium.org>
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595627}

TBR=fmalita@chromium.org,reed@chromium.org

Change-Id: Ica1ccdd43953772d40c70d22f3fc399df7dd56b1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891230
Reviewed-on: https://chromium-review.googlesource.com/1256825Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595805}