- 14 Oct, 2020 40 commits
-
-
Joe Mason authored
R=fdoray Bug: 1080672 Change-Id: Ia7d6d6139daac23a80d824734bde7bdc5c111ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459567 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#816911}
-
Muhammad Hasan Khan authored
In https://crrev.com/c/2459528 we added a test for container_client_adapter that uses fake session_manager_client therefore we need to ensure that fake works the same way as real. BUG=b:164816080 TEST=components_unittests --gtest_filter='ArcContainerClientAdapterTest*' TEST=revert the fix and ensure that the test fails Change-Id: I271d116d10387cb6b5967378bab3fdea508d6581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461603 Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816910}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/47cbd60f079b..a4b5132faf7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alancutter@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: alancutter@google.com Change-Id: Iac9dae3e51aec61234e8243133adad7b5918bf9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469708Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816909}
-
Noel Gordon authored
Add SpanToStringPiece helper and use it handle response messages from the devtools agent. This avoids the implicit memcpy under-the-hood of the span to temporary std::string (message) conversion. Minor: remove unused includes, and add base::span, base::string_piece includes. No change in behavior. Tbr: benreich Bug: 1113941 Change-Id: I9a9295230b0a807d3405d70af92cf32ac88cbdaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470280 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816908}
-
Muhammad Hasan Khan authored
This change is needed to ensure that fake behaves the same as real client and we can use it in the unit test to validate that arc instance stopped is not fired on unrelated instance. BUG=b:164816080 TEST=cq Change-Id: Ice5e588b81231ac87b78dafd25188d6629b38bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469231 Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#816907}
-
Noel Gordon authored
The helper URI encodes a url or any component of a url, so it is a URI string sequence, identical to the web method encodeURIComponent. Let's use |component| arg in its definition and adopt the name for clarity. No change in behavior, no new tests. Tbr: benreich Bug: 1113941 Change-Id: I4c46377656182bc97c04ea91997bbc3b36bfcc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469920Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816906}
-
Ramin Halavati authored
The criteria for disabling DeleteSoleProfile on Lacros are updated. Bug: 1130131 Change-Id: Ifbb3def8b809c990e12a873ddfc21d92abf4c8ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464931 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#816905}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6b8b2ea6be63..99446001182c 2020-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from d1bca09f4ab3 to cac0442277f7 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: If453399602c5f9d0015b22301d068afe79e55d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469482Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816904}
-
Manas Verma authored
Text now includes "Cashback linked" instead of including the percentage or dollar amount. Bug: 1093057 Change-Id: I53e046a6a495cc4b6cabbf35a8876e940f280b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466142 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#816903}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ad80b184a00d..9580f3b4c530 2020-10-14 jmadill@chromium.org Test Runner: Accept GTEST shard environment vars. 2020-10-14 ianelliott@google.com Vulkan: Remove Arm from perFrameWindowSizeQuery 2020-10-14 jmadill@chromium.org trigger.py: Remove GTest shard env when running one shard. 2020-10-13 jmadill@chromium.org Suppress multisample "max samples" tests on Win/NV/GL. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I45bf9adc253011aaa1b0d98bc23794ab9cb565f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469474Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816902}
-
David Tseng authored
R=akihiroota@chromium.org AX-Relnotes: fixes an issue where ChromeVox would speak changes in a popup button when its value changes even if it didn't have focus. Bug: none Change-Id: Id609af0fb7ee5e99bb9f0c4e0e822ab986db11e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468573Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#816901}
-
Minoru Chikamune authored
[Context] This is a part of an effort to achieve MBI. We want to avoid per-thread task runner as much as possible. [Previous code] AssociatedInterfaceProvider::GetInterface was using per-thread default task runner because task_runner was not specified. [What this CL does] Use the given task runner for AssociatedInterfaceProvider::GetInterface instead of per-thread task runner [Rlated stack trace] base::SequencedTaskRunnerHandle::Get() mojo::internal::GetTaskRunnerToUseFromUserProvidedTaskRunner() mojo::internal::AssociatedInterfacePtrStateBase::Bind() mojo::internal::AssociatedInterfacePtrState<>::Bind() mojo::AssociatedRemote<>::Bind() mojo::AssociatedRemote<>::BindNewEndpointAndPassReceiver() mojo::AssociatedRemote<>::BindNewEndpointAndPassReceiver() blink::AssociatedInterfaceProvider::GetInterface<>() content::RenderFrameImpl::GetFrameHost() content::(anonymous namespace)::ResourceLoadCompleted() content::NotifyResourceLoadCompleted() content::NavigationBodyLoader::NotifyCompletionIfAppropriate() content::NavigationBodyLoader::OnComplete() network::mojom::URLLoaderClientStubDispatch::Accept() network::mojom::URLLoaderClientStub<>::Accept() Bug: 1105403 Change-Id: I20d3e2a7e1ba638a94d30e33d964d8df5f8fd418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462857Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#816900}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602622713-d22858ceb9d9ad4a4a6268ac3709afaee3037eec.profdata to chrome-win64-master-1602633476-7a781163f6d564d4e8e8516c828c3e90624a360b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I49fb1178caf2cb562932d2a39316c1a502a2f756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469473Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816899}
-
Trent Apted authored
Fixes, ../../ui/file_manager/image_loader/piex_loader.js:357: ERROR - [JSC_UNKNOWN_EXPR_TYPE] could not determine the type of this expression thumbnail: this.createImageDataArray_(view, preview).buffer, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Bug: 1030935 Change-Id: I97a0f40f9c574e6af82aa5a46a91374db6c357f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470061 Commit-Queue: Trent Apted <tapted@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Trent Apted <tapted@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816898}
-
Hiroki Nakagawa authored
mojom::PrerenderProcessor::Abandon() is a mojo call from a renderer process to the browser process in order to abandon a running prerender, but this is never called. This CL removes the mojo function and relevant functions (e.g., pre-finalizer). > Why is this never called? Abandon() is supposed to be called when a page that has <link rel=prerender> navigates away, etc, and apparently blink::PrerenderHandle::Dispose() calls it. However, actually Dispose() never calls Abandon(). See the following code snippet. void PrerenderHandle::Dispose() { if (remote_processor_.is_bound() && !GetExecutionContext()->IsContextDestroyed()) remote_processor_->Abandon(); Detach(); } Dispose() is called by ContextLifecycleObserver during the context destruction. |remote_processor_| can be unbound at this point because the remote processor is retained with MojoHeapRemote that is supposed to be reset by ContextLifecycleObserver. There is an ordering issue here. Also, even if the remote processor is still bound, IsContextDestroyed() always returns true because Dispose() is called during the context destruction. In another case, Dispose() is called on the pre-finalizer, but this doesn't work as well because PrerenderHandle::Cancel() that resets |remote_processor_| or ContextDestroyed() that calls Dispose() are already called before the pre-finalizer. In summary, both Abandon() and the pre-finalizer are not necessary. This CL removes them. > Mojo connections are managed by MojoHeap variants. Does > PrerenderHandle have to explicitly reset them on the context > destruction? That's not necessary. MojoHeap variants automatically reset the connections on the context destruction. This CL removes ContextLifecycleObserver implementation used for resetting the connections from PrerenderHandle. > Is the browser-side abandon code also never used? No, it's used. Instead of waiting for Abandon() call from a renderer process, PrerenderLinkManager::LinkPrerender in the browser process monitors the connection of mojom::PrerenderProcessorClient and abandons the running prerender on connection destruction. Therefore, this CL doesn't remove the browser-side code. Bug: 1130360 Change-Id: I14555530f98d1fb191b04f387636f58a52484c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462987 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#816897}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/538433c72064..a58a676ab96a 2020-10-14 tsepez@chromium.org Split up xfa/fgas/BUILD.gn by crt/ and font/ directories 2020-10-13 tsepez@chromium.org Move xfa/fxgraphics to xfa/fgas/graphics. 2020-10-13 tsepez@chromium.org Observe CFX_Timer's timer handler objects. 2020-10-13 tsepez@chromium.org Make CJS_Object's ObjDefnID be one-based. 2020-10-13 thestig@chromium.org Use "= default" for constructors. 2020-10-13 tsepez@chromium.org Nest class CPLST_Select as CPWL_ListCtrl::SelectState. 2020-10-13 tsepez@chromium.org Rename fpdfsdk/pwl/cpwl_list_impl.{cpp,h} to cpwl_list_ctrl.{cpp,h} If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1137668 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ieaaf961c9793fadedd6c848a02344db4012b8da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470296Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816896}
-
Joe Mason authored
Also adds a GetProcessNodeForRenderProcessHostId accessor to PerformanceManager. R=fdoray Bug: 1080672 Change-Id: I3c2ceb14643833867d836c06c8d409889e24ba46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456667 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#816895}
-
Omid Tourzan authored
It fixes the issue of showing remaining time for not supported operation. Also fixes the issue when remaining time displayed if same (identical panel item id) error panel gets updated or reused because not dismissed yet. Bug: 1137229 Change-Id: Ic09e621e8811322ad4602e5d4ecc8fef8f42929c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463100Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#816894}
-
Jimmy Gong authored
- Responsible for managing the internal notifications set and sending inline replies for notifications. Bug: 1106937 Test: chromeos_components_unittests Change-Id: I659f3b16c06005d213beb9c2cbe21618f35404c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466980Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#816893}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ad59e7a16b5d..072e187b21bb 2020-10-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic05a08a549da7b50a274fe2902784daa58f424e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469475Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816892}
-
Alan Cutter authored
This reverts commit e1ec1546. Reason for revert: Test times out on Mac. Bug: 1138084 Original change's description: > Focus WebContents prior to sending focus to renderer for accessibility > > When focus moves from the main WebContents to a guest WebContents, there > currently isn't any mechanism to make sure focus moves to the guest > WebContents. Due to this, the focus call ends up being a no-op which > causes focus not to move along with AT navigation. > > Ensure the guest web contents is focused before performing the rest of > the accessibility focus action which allows it to have the desired > effect. This has to happen whether or not the RenderWidgeHostView > believes it is focused (which it does in a guest web contents that > itself does not have focus). > > The new test is disabled for ozone wayland - it's passing on all other > platforms (including ozone x11) so will probably need an independent > platform-specific fix (tracked by crbug.com/1137626). > > Bug: 1130710 > > Change-Id: Idd5b9709f255b4085a5268ee52dd6375e88e9412 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446789 > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Aaron Colwell <acolwell@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#816808} TBR=dmazzoni@chromium.org,acolwell@chromium.org,aleventhal@chromium.org,lfg@chromium.org,dlibby@microsoft.com,kschmi@microsoft.com Change-Id: I3fcf6285ff471e5f99038018c0d86a30ac397ec4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1130710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470059Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#816891}
-
Noel Gordon authored
CL:1483697 added a mock arc::FileSystemInstance (ie Mojo interfaces to interact with ARC container) for use with DocumentsProvider volumes in test. Entries can be added to the test DocumentsProvider volume (works fine) but the content of file entries is not shown in Quick View tests per issue 1131298. Fix this: arc::FileSystemInstance requires that the content of entries is provided to it using its AddFile() API. Do that and update the test added in CL:1483697 to verify the text file content is shown. Test: browser_tests --gtest_filter="*openQuickViewDocumentsProvider" Bug: 1131298, 1049966, 923991 Change-Id: I992dc69e3a9e7421e94a88e62edfed56b6d8e465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469336 Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816890}
-
Majid Valipour authored
The old name does not reflect the changes made to the feature name and specification. No change in functionality is expected. The following changes were made using grep & sed. - rename files - [^_]+sms_service->webotp_service - [^_]+sms_receiver->webotp_service - {SMS,Sms}Receiver->WebOTPService - SmsService->WebOTPService - SMS Service->WebOTP Service The only manual change were: - update some outdated documentation in webotp_service.mojom - SMSReceiver -> WebOTP for flags ## Aside Getting a pre-submit warning which seems incorrect as we have not changes the UMA histogram name and it exists :-? ``` ** Presubmit Warnings ** Some UMA_HISTOGRAM lines have been modified and the associated histogram name has no match in either tools/metrics/histograms/histograms.xml or the modifications of it: [components/browser_ui/sms/android/java/src/org/chromium/components/browser_ui/sms/WebOTPServiceUma.java:35] Blink.Sms.Receive.TimeCancelOnKeyboardDismissal ``` Bug:1117238 Change-Id: I369f8631450b0a539b3c2afbf8d4ed87ce853a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424707 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816889}
-
Zufeng Wang authored
If a searchable item provides subheadings, use those instead of the body. The subheadings should have less text than the body, so index update should happen in less time. If a search result has multiple subheadings, pick the one with the most positions. Also add js type check for the browsertests. The build rules are based on the ones used in media_app_ui/BUILD.gn Bug: b/170162418 Change-Id: Ic9682ac13b3d5e674c5d30e7042d199e98f42206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466011 Commit-Queue: Zufeng Wang <zufeng@google.com> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#816888}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/aba3f0d..84fb34e2d 84fb34e Revert "Set icu_disable_thin_archive on non-component chromeos builds" c18a117 Update IANA timezone db to 2020b 146cb61 Set icu_disable_thin_archive on non-component chromeos builds Update IANA timezone db to 2020b https://mm.icann.org/pipermail/tz-announce/2020-October/000059.html Revised predictions for Morocco's changes starting in 2023. Canada's Yukon changes to -07 on 2020-11-01, not 2020-03-08. Macquarie Island has stayed in sync with Tasmania since 2011. Casey, Antarctica is at +08 in winter and +11 in summer. zic no longer supports -y, nor the TYPE field of Rules. The tz-related files are updated by running update_tz.sh and ICU data files are rebuilt. Either in JS console in Chrome or v8 should work like these: // a) Canada's Yukon changes to -07 on 2020-11-01, not 2020-03-08. df1 = new Intl.DateTimeFormat("en", {timeZone: "America/Dawson", timeStyle: "long", dateStyle: "long"}) d1 = new Date("2020-03-09T00:00:00.000Z") df1.format(d1) Before change "March 8, 2020 at 5:00:00 PM MST" After change "March 8, 2020 at 5:00:00 PM PDT" Notice "This change affects only the time zone abbreviation (MST vs PDT) and daylight saving flag for the period between the two dates." // b) Casey Station, Antarctica using +08 in winter and +11 in summer since 2018. df2 = new Intl.DateTimeFormat("en", {timeZone: "Antarctica/Casey", timeStyle: "long", dateStyle: "long"}) d2 = new Date("2020-10-04T00:00:00.000Z") df2.format(d2) Before change "October 4, 2020 at 8:00:00 AM GMT+8" After change "October 4, 2020 at 11:00:00 AM GMT+11" // c) Macquarie Island in sync with Tasmania since 2011. df3 = new Intl.DateTimeFormat("en", {timeZone: "Antarctica/Macquarie", timeStyle: "long", dateStyle: "long"}) d3 = new Date("2020-04-05T00:00:00.000Z") df3.format(d3) Before change "April 5, 2020 at 11:00:00 AM GMT+11" After change "April 5, 2020 at 10:00:00 AM GMT+10" TBR=jshin@chromium.org Bug: chromium:1137864 Change-Id: Ic182e359d1bab7bf309a13286cbea4f58b6dda74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468382 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#816887}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cae3bad79262..47cbd60f079b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alancutter@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: alancutter@google.com Change-Id: Ib7971b656ae5a6a0c39801204350e84e4819245e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469580Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816886}
-
Ian Kilpatrick authored
Previously when building the constraint spaces we didn't set the fallback inline-size, this prevents the DCHECK: Check failed: orthogonal_fallback_inline_size_ != LayoutUnit(-1) ("-1" vs. "-1") Bug: 1045599 Change-Id: I57261e8390613ddec8ef8c8f85d3b378ff89b478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468707Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#816885}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/095444c21262..0150a791fcb7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1b5b6aa2a1e185123425a74f16c118cfd468bdbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469367Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816884}
-
Austin Tankiang authored
This text, contained in the .xf-panel-text element, can have two different widths depending on the Files Transfer Details flag, so make it flex to fill up the entire space in both cases. Bug: 1137316 Change-Id: Ibea7905e7c764e0e5d1a0caf096fdba427cbb911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467498Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#816883}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ice473442cf6dd2017012ef65d0ab6e2cfef51d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469480Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816882}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ibb217565c576fb9439e0e127e9da4d4302557cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469717Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816881}
-
Andrey Kosyakov authored
Bug: 1137291 Change-Id: Id9ae17cce017e977adac8d6fee3f2d265f6ad89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468945 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#816880}
-
Alexander Alekseev authored
Implemented permanent ScopedAnimationDuration object to persist animation duration changes. Bug: 1137643 Change-Id: Iacaad772114ff4bc262080f809ad37fb009f642a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466841 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#816879}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/aa45aa62c3c6..6e970e597b25 2020-10-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I84626fa149dadfc498ef91d0caf88b667f6e5a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469656Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816878}
-
bttk authored
LocationBarCoordinator (LBC) - the public API for location bar. This class implements LocationBar, but is not a View. Interfaces LocationBar.Phone and LocationBar.Tablet are now replaced by LBCPhone and LBCTablet. Interfaces were removed in an effort to reduce the method count. Views LBPhone and LBTablet no longer need to be visible outside of their package. LocationBarLayout can't be hidden, since SearchActivityLocationBarLayout depends on it. Bug: 1133482 Change-Id: I5f8bbc3b8cfd6c896aca41482d3c271be957f352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446826 Commit-Queue: who/bttk <bttk@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Auto-Submit: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#816877}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602590170-40f871c7cd5f95ac04c91a2fc42fd5651e0714b3.profdata to chrome-win64-master-1602622713-d22858ceb9d9ad4a4a6268ac3709afaee3037eec.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I803d47b08106b0d66d875130700ea49aa9238b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469698Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816876}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602611974-a7265b2715cbc4cd86dbab6cb07ce46a3b6949bc.profdata to chrome-mac-master-1602633476-0a6cb13b3824485740d2ed9816cdaa54debab52e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9f6fce1650a30e3db5f36d2682c9d16760cf470f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469668Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816875}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a08dc37d19e5..095444c21262 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie3028abd2dd13f30218899df25e41da11d8ae86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469778Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816874}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602611974-f7262751d1dc906200528d84bf62f89d4908c5e2.profdata to chrome-linux-master-1602633476-bff3708a6ce1ff631b23d1b618c56f8a3baedfe0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie5a36b737145e367bf5e678f08646da2518749ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470116Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816873}
-
Taylor Brandstetter authored
Bug: chromium:1025302 Change-Id: Iadbcb87f0f3f3a1845e925aed8f52685d78e740e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108066Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Taylor <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#816872}
-