- 15 Feb, 2019 40 commits
-
-
Manu Cornet authored
Currently some shelf buttons (launcher button, overflow button) do not have any outline when focused (only app buttons do). This change moves the single line creating a focusing painter up the class hierarchy so that all shelf buttons have at least a visual cue indicating focus. I might refine this in the future so that the focus ring is circular for circular buttons (currently it's a rounded corner square), but this at least fixes the core issue. Bug: 753409, 884799 Change-Id: I28bb2e77e5d35bc08a1374d75fea6dbf4ee816ca Reviewed-on: https://chromium-review.googlesource.com/c/1474885 Auto-Submit: Manu Cornet <manucornet@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#632664}
-
Robert Ogden authored
Bug: 932350 Change-Id: Idf2dbca27379389212277cfc20543b9b387440b9 Reviewed-on: https://chromium-review.googlesource.com/c/1475196Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#632663}
-
Tom Tan authored
Bug: 893460 Change-Id: I5618e7da43eb99e59839549c9669deeb61ee65f6 Reviewed-on: https://chromium-review.googlesource.com/c/1474438Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#632662}
-
Antonio Gomes authored
This is a precursor CL to the CL that will change GCMS::AddAccountToCookie to take a completion callback rather than calling the GCMS::Observer::OnAddAccountToCookieCompleted. With this CL GCMS::SignalComplete now is called solely in the context of a GCMS::AddAccountToCookie calls. Previously it could be called in the context of a GCMS::ListAccount call too (see stack below). #1 0x55d9e66a8018 AccountReconcilor::OnAddAccountToCookieCompleted() #2 0x55d9e5d0df79 identity::IdentityManager::OnAddAccountToCookieCompleted() #3 0x55d9e66c0ad8 GaiaCookieManagerService::SignalComplete() #4 0x55d9e66a77d9 AccountReconcilor::FinishReconcile() #5 0x55d9e66a6568 AccountReconcilor::OnAccountsInCookieUpdated() #6 0x55d9e5d0dd8d identity::IdentityManager::OnGaiaAccountsInCookieUpdated() #7 0x55d9e66c59de GaiaCookieManagerService::OnListAccountsSuccess() #8 0x55d9e5cf9316 GaiaAuthFetcher::OnListAccountsFetched() (...) #xx GaiaCookieManagerService::TriggerListAccounts #yy GaiaCookieManagerService::ListAccounts Additionally, the CL removes the only caller of GCMS::SignalComplette (AccountsCookieMutator::ForceTriggerOnAddAccountToCookieCompleted and its respective unittests). No behavior change is expected, since GCMS::SignalComplete calls out to AccountReconcilor::OnAddAccountToCookieCompleted BUG=932180 Change-Id: Ib64e96ae4761fa2976c6f07a457ad756084cf029 Reviewed-on: https://chromium-review.googlesource.com/c/1474111Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#632661}
-
Raymond Toy authored
|active_source_nodes_| tracked the active source nodes. But we really want to track the handlers for the nodes because that's what is really running. The nodes themselves may go away, but the handlers can still be alive. Thus, rename active_source_nodes_ to active_source_handlers_ and move it to the DeferredTaskHandler class. Bug: 752333 Change-Id: I1d7b39863f66782b6945fd5b7f02ab169c39584f Reviewed-on: https://chromium-review.googlesource.com/c/1459791Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#632660}
-
Xing Xu authored
This test makes a request to Litepages integration test site, and then checks whether an expected report has been sent to the reporting endpoint by looking at netlogs (the endpoint will only return 200 on receiving expected report). Design doc: https://docs.google.com/document/d/1sqfM65y0D31GGKB9vUCT8QqWFafQPGH-pYR1tzX7nos/edit#heading=h.8l9t303augmm add new test Bug: 929774 Change-Id: If894450e87bdf6b8baa7d9d767fe44e4f4345192 Reviewed-on: https://chromium-review.googlesource.com/c/1474381Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Xing Xu <xingx@chromium.org> Cr-Commit-Position: refs/heads/master@{#632659}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=danakj@chromium.org, rmcilroy@chromium.org Bug: 714018 Change-Id: I864f484c23ef23b0ced770ef1e0e768a013c3156 Reviewed-on: https://chromium-review.googlesource.com/c/1475649Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#632658}
-
Domenic Denicola authored
Follows https://github.com/WICG/kv-storage/pull/51. Bug: 931263 Change-Id: Ia3b1482093bfaca443b8809c6e284397fdb6fec1 Reviewed-on: https://chromium-review.googlesource.com/c/1466863Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#632657}
-
ssid authored
Change-Id: I014c9f549e8ef65782590056ad3dbe5722bb7d24 Reviewed-on: https://chromium-review.googlesource.com/c/1471954Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#632656}
-
Allan Sandfeld Jensen authored
You should not access a unique_ptr in the same expression you are moving it. This currently only crashes with MSVC 2017, but being undefined and could also crash in the future with clang. Bug: 887865 Change-Id: I9c242896e91d4c250e474667ed2132ba8587117c Reviewed-on: https://chromium-review.googlesource.com/c/1238217 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#632655}
-
Ehsan Chiniforooshan authored
BUG=878420 Change-Id: Ia4e558d8733d952c86706e4ede39fe0b5c69b774 Reviewed-on: https://chromium-review.googlesource.com/c/1475736Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#632654}
-
Robert Ogden authored
This was in the original UX spec and I missed it :( It caused the bug below since the VerboseStatusView does respect the security level, but this did not. On a side note, I've filed a bug for M74 to not allow previews on broken HTTPS pages in the first place. Bug: 929412 Change-Id: If9ad72584de62e6a51e4a6e676255d5e394ba9c3 Reviewed-on: https://chromium-review.googlesource.com/c/1474382Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#632653}
-
Ian Kilpatrick authored
The comment indicates that previously we were setting the current fragment based on LayoutNGMixin::SetCachedLayoutResult, which isn't true anymore. As a result this isn't necessary. \o/ Bug: 635619 Change-Id: I75a1b4101f5434106176797ab900b6fe2fef0604 Reviewed-on: https://chromium-review.googlesource.com/c/1473833 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#632652}
-
Vladimir Levin authored
This patch ensures that we notify local frames that have display locks when lifecycle advances. Otherwise, those frame never get the notifications and locks seem to "freeze" on acquire or commit. R=chrishtr@chromium.org Bug: 882663 Change-Id: I4269364ea5095e9f5eb0f4b2239105be74a3684b Reviewed-on: https://chromium-review.googlesource.com/c/1474683 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#632651}
-
Mario Sanchez Prada authored
TestIdentityManagerObserver::ErrorFromAddAccountToCookieCompletedCallback() is not the right call to make here, as it returns an unset error, from a callback never called before. Instead, it needs to return the error returned by the OnAccountsInCookieUpdated() callback, so let's add an additional getter for that in TestIdentityManagerObserver, and update the two tests. Bug: 930192 Change-Id: Ic252041f4d1ee27683f8edda3ad9664179ff1018 Reviewed-on: https://chromium-review.googlesource.com/c/1475179Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#632650}
-
Elly Fong-Jones authored
Bug: None Change-Id: Ibe69071fb7f40844686d67708f7bacdb2d016c16 Reviewed-on: https://chromium-review.googlesource.com/c/1474827 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#632649}
-
Albert J. Wong authored
This CL builds on the huge amounts of ground work by danakj@ removing templates and clarifying usage + relations for these classes. This coding pattern of having proxy with a base class of common "fake" functionality along with an extra "client" that could have specific override of the base functionality was originally created to support the Mandolin project. Mandolin would have added a second client to blink in parallel to content. The structure of having a full proxy that could select between multiple fake client implementations made sense in this context. However, at this point, this forest of classes is overkill. For example, in the case of the View/Widget cluster of these classes, each cluster was using 3 classes in a multiple-inheritance and bridge configuration with lots of shell methods for the purpose of faking the implementation for 5-6 virtual methods. This CL merges all the Web{View,Frame,Widget}TestProxy classes with their .*Base superclass. This removes 3 multi-inheritance hierarchies which helps with code clarity and sanity in the debugger (it was easy to accidentally cast a pointer incorrectly in gdb and crash the debugger). WebViewClient and WebWidgetClient were also merged into the Proxy as the Proxies consisted mostly of forwarding logic. This again removes another set of objects that can get mis-assigned in code or mis-inspected in the debugger. Lastly, WebViewTestProxy no longer inherits from WebWidgetTestProxy mirroring the recent inheritance break between RenderView and RenderWidget. This removes some duplicated code (ScheduleAnimation() was nearly cut/paste between WebViewTestProxy and WebWidgetTestProxy) and allows for a cleaner InstallCreateXXXHooks pattern. See...deforestation isn't always bad. Bug: 545684, 912193 Change-Id: I42a4ffc2d3bb55f7d73e3b758daaddf058128a04 Reviewed-on: https://chromium-review.googlesource.com/c/1437324 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:Nasko Oskov <nasko@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Auto-Submit: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#632648}
-
Monica Salama authored
Support code ordering should be enabled on devices running Android with arm or arm64 cpu. There exist other operating systems that use arm or arm64. Bug: 932524 Change-Id: Iab041c23d3fbab6de281b2d09da1394cd324809a Reviewed-on: https://chromium-review.googlesource.com/c/1475466Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Monica Salama <msalama@google.com> Cr-Commit-Position: refs/heads/master@{#632647}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d4d1be8dedf0..28bafb01c90c git log d4d1be8dedf0..28bafb01c90c --date=short --no-merges --format='%ad %ae %s' 2019-02-15 bsalomon@google.com Add option to force GLSL string caching rather than program binaries. 2019-02-15 robertphillips@google.com Switch GPU blur code over to using GrRecordingContext 2019-02-15 bsalomon@google.com Add SK_API to GrContextOptions and GrContextOptions::PersistentCache 2019-02-15 bsalomon@google.com Remove unused fields related to old multitexturing TextureOp. Created with: gclient setdep -r src/third_party/skia@28bafb01c90c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:924572 TBR=stephana@chromium.org Change-Id: I943bbc52a4e9bcbdf5965c218ef66e463743fb04 Reviewed-on: https://chromium-review.googlesource.com/c/1474788Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632646}
-
Ria Jiang authored
RenderPass has a cc::FilterOperations |filters| which might include information for ALPHA_THRESHOLD - a vector of alpha rects, e.g. from ChromeNativeAppWindowViews::UpdateShape. This CL accounts for that list when we create hit-test data and only submits hit-test data for the region that intersects with rects in that vector. Bug: 864508 Test: viz_unittests Change-Id: Iaae1b11ae45e443b8f7da07df072cafbee55269b Reviewed-on: https://chromium-review.googlesource.com/c/1426163 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#632645}
-
Elly Fong-Jones authored
This change removes: android-payment-apps enable-android-pay-integration-v1 enable-android-pay-integration-v2 enable-web-payments-method-section-order-v2 enable-web-payments-single-app-ui-skip just-in-time-service-worker-payment-app pay-with-google-v1 service-worker-payment-apps web-payments web-payments-modifiers and annotates their backing features to be cleaned up later by rouslan@ (who has already started this work in CL 1341970). TBR=avi@chromium.org Bug: 906632 Change-Id: I0eda9a8db8d1522250e35b15d9b1402f13eda6eb Reviewed-on: https://chromium-review.googlesource.com/c/1474825Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#632644}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8bcb8ed34b93..0613361e6c4f Created with: gclient setdep -r src-internal@0613361e6c4f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idfe4a1abaf6301d465a5de6e572fb8f341564618 Reviewed-on: https://chromium-review.googlesource.com/c/1474787Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632643}
-
Aditya Keerthi authored
This CL introduces a new MemoryPurgeManager class, to handle proactive memory purging in a renderer process. Currently, the class is responsible for performing a purge after a page if frozen. Eventually, the purging associated with the PurgeAndSuspend experiment (memory purging on renderer backgrounded) will also be moved to this class. As the implementation of proactive memory purging becomes more complex, we would like to avoid adding new code to RenderThreadImpl (the existing location for memory purging logic). This is necessary so that RenderThreadImpl does not have too many responsbilities. Furthermore, more code from //content/ is being moved to Blink, and the new class allows us to avoid adding new code to //content/. MemoryPurgeManager is owned by MainThreadSchedulerImpl, as we require exactly one instance per renderer process. The rest of the code was moved from RenderThreadImpl and RendererBlinkPlatformImpl, and will be modified in upcoming CLs. Bug: 926186 Change-Id: I072412c6ebfc2f71c3000ac931345d9c76dc4fb7 Reviewed-on: https://chromium-review.googlesource.com/c/1468081 Commit-Queue: Aditya Keerthi <adityakeerthi@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#632642}
-
Peter Collingbourne authored
Only a couple of the annotations added for ASan are also required for HWASan. It looks like most of the ASan annotations here are because Oilpan wants to poison memory before a GC sweep in order to detect bugs in the GC. It seems like it should be possible to implement memory poisoning and unpoisoning using the __hwasan_tag_memory function (poisoning would set tags to 0, unpoisoning would set them to ptr >> 56). But for now this CL lets the tests pass, and it also appears to be enough to let the browser start up and load web pages. Bug: 916828 Change-Id: I88599286a8fd90e42761e89d0c580ca3057981c8 Reviewed-on: https://chromium-review.googlesource.com/c/1474255Reviewed-by:
-
Daniel McArdle authored
Replace current behavior (prefixing the cache key with "pm/" or "nopm/") with two instances of the session cache. Also removes the vestigial session cache shard string. Bug: 458365 Change-Id: Iac1ac1671d82491795c5804b04eb46c66254c2d4 Reviewed-on: https://chromium-review.googlesource.com/c/1455021 Commit-Queue: Daniel McArdle <dmcardle@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Auto-Submit: Daniel McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#632640}
-
Eric Lawrence authored
On some platforms, a failed Find-in-page search results in a beep if no results were found; this matches platform conventions and helps a user recognize that further query input will not be helpful. Today, this beep also disruptively and unnecessarily plays during the teardown of a page as it is navigated away. This change ensures that after a Find-in-page search completes, no beep will sound for that query. Bug: 682299 Change-Id: I052d562cee657cb2b1aeb7353dcb8254c3fa0ac7 Reviewed-on: https://chromium-review.googlesource.com/c/1469408 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#632639}
-
Nate Fischer authored
This implements the getCookie() API for WebView in the NetworkService path. We introduce the AwCookieManagerWrapper class, which wraps a network::mojom::CookieManager. This class is designed to create its own CookieManager if instantiated before content layer starts up, and to use the NetworkContext's CookieManager after content layer starts; for now, we only implement the latter condition, and will follow-up later to fix the former. For now, AwCookieManagerWrapper only wraps the GetCookieList() API. cookie_manager.cc is modified to use the AwCookieManagerWrapper method when NetworkService is enabled. This edits the test filter: * This fixed CookieManagerTest#testAcceptCookie_trueWillSetCookies * This exposed more work for #testAcceptCookie_falseWontSetCookies (for a follow-up) * This fixed LoadDataWithBaseUrlTest#testSetCookieInIframe Design doc: http://go/wv-ns-cookie-apis Bug: 902641, 893576, 893580 Test: run_webview_instrumentation_test_apk -f LoadDataWithBaseUrlTest.testSetCookieInIframe Test: run_webview_instrumentation_test_apk -f CookieManagerTest.testAcceptCookie_trueWillSetCookies Change-Id: I071693768701f5e5ba7c68265f07135d9b7f9107 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1469426 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#632638}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d3b1539c. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." 6cf9dcc6 "Use testdriver Action API in WPT pointerevent touch tests" 5c3da78e "Revert "Use testdriver Action API in WPT pointerevent touch tests"" c3f69282 "New wpt tests for absolute position" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: If47b3b96f18ce6830694c8a6d7c80d23e09e566e Reviewed-on: https://chromium-review.googlesource.com/c/1475630Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632637}
-
Alexei Svitkine authored
Previously, it would be treated as matching all platforms. This makes it match none, which matches what server behavior is for serving configs given a platform request param. Bug: None Change-Id: I2241c664c5b8dd12c689a84aec8fd779c78b81c5 Reviewed-on: https://chromium-review.googlesource.com/c/1473614 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#632636}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=spang@chromium.org Bug: 714018 Change-Id: I4f7e913ba43e8d78331e4ce06d70b2ded165b81f Reviewed-on: https://chromium-review.googlesource.com/c/1475636Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#632635}
-
Anna Malova authored
Bug: 931577 Change-Id: I39b7ad3ec1df5c3dec58c430fdce43ea8dbb0346 Reviewed-on: https://chromium-review.googlesource.com/c/1475442Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#632634}
-
Liquan(Max) Gu authored
Currently FCP++ is hooking into pre-paint-tree-walk for node-checking. FCP++ is supposed to check the nodes to be painted immediately afterwards. However, pre-paint-tree-walk will expose more than the nodes FCP++ need to know. As an improvement, we are going to move node-checking to painter::paint. Specifically, text-paint-timing detector hooks up these painters: * EllipsisBoxPainter * FileUploadControllerPainter * InlineTextBoxPainter * NgTextPainter * SvgInlineTextBoxPainter We intentionally omits ListMarkerPainter because the list markers are anonymous nodes which FCP++ are not able to track yet. We've changed the visual rect of an object. Originally, we used object.FirstFragment().VisualRect(). Now we change to use object.FragmentsVisualRectBoundingBox(). This CL is the relanding of https://chromium-review.googlesource.com/c/chromium/src/+/1427794 after fixing the crash issue. The crash was caused by the fact that some of nodes in the painters are not LayoutText, such as the one in ListMarkerPainter. The mismatch causes crash when we execute ToLayoutText(). The crash has been fixed by guarding ToLayoutText. And I've also made the following change upon the last CL: * Added tests for texts in different painters * Remove hooks in ListMarkers, since the nodes are anonymous nodes which FCP++ are not able to track (as it requires a node id). * Add DCHECK(node_id != kInvalidDOMNodeId); Change-Id: I97539e8ec627b3b063800078a852cd0e8ec8ef42 Reviewed-on: https://chromium-review.googlesource.com/c/1470732 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#632633}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a5e94126..b23ca2a5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I171cf3b50a29abfd905c010745b21d82ce6d1dd9 Reviewed-on: https://chromium-review.googlesource.com/c/1475632Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632632}
-
Elly Fong-Jones authored
Bug: None Change-Id: I878329117f0f253cc195f99121230f4c28312974 Reviewed-on: https://chromium-review.googlesource.com/c/1474822 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#632631}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I313275a593c3eef2c9a55f82285281d3e4680233 Reviewed-on: https://chromium-review.googlesource.com/c/1474908Reviewed-by:
-
Olivier Li authored
It was previously necessary to |delegate_.reset();| in HistoryBackend::Closing() to prevent a reference cycle as HistoryService was ref-counted. HistoryService was recently refactored to be WeakPtr-based and as such there isn't a reference cycle anymore and this is unnecessary. Further cleanups are enabled by using explicit (make_unique) memory management and not having to deal with |delegate_| ever being null. HistoryService::Cleanup() is also simplified through move-only OnceClosure which guarantees that the last reference to HistoryBackend is released on |backend_task_runner_| without having to manually Reset() and ReleaseSoon(). Bug: 927804 Change-Id: Ic815ec4330610f1e84c2624347fcf08e8c782d8d Reviewed-on: https://chromium-review.googlesource.com/c/1448978Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#632629}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ee4db4b3e9e3..2f1b272e0818 git log ee4db4b3e9e3..2f1b272e0818 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 taylori@google.com perfetto-ui: Changes to work with latest package versions Created with: gclient setdep -r src/third_party/perfetto@2f1b272e0818 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I034ef437d3f425d2d52c83f96a381e38670e293f Reviewed-on: https://chromium-review.googlesource.com/c/1474909Reviewed-by:
-
Christopher Grant authored
This breaks the VR UI's direct dependency on Chrome's raw data, which is necessary before moving code into a DFM. BUG= Change-Id: Ifea2bced680cd4181c4d5516fbe8fbc62612c759 Reviewed-on: https://chromium-review.googlesource.com/c/1473818 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#632627}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/154acd7a1374..d4d1be8dedf0 git log 154acd7a1374..d4d1be8dedf0 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 559aaca5abd8..aead8edf8c46 (1 commits) 2019-02-15 brianosman@google.com New SkCurve type with multiple curve segments Created with: gclient setdep -r src/third_party/skia@d4d1be8dedf0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ib032e6c2b6c231c3dc44777d4901074a5b01bfd2 Reviewed-on: https://chromium-review.googlesource.com/c/1475690Reviewed-by:
-
Javier Ernesto Flores Robles authored
|accessibilityViewIsModal| is not required on iPad since the view is not above any keyboard view, and it is causing problems since the keyboard view is a sibbling of it. Bug: 932461 Change-Id: Ie1865460609da8b51705f10e7967ff47320d4ddf Reviewed-on: https://chromium-review.googlesource.com/c/1475455Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#632625}
-
