- 23 Sep, 2019 27 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11e2cbc5cca3..66e6e12e7e7a Created with: gclient setdep -r src-internal@66e6e12e7e7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I97676e08c2a27278a3c90c6478cf298ebd62fd1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819001Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698825}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4854b9f8047e..3c5f91b74871 git log 4854b9f8047e..3c5f91b74871 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e74d6b59..82de2e61 (698711:698813) 2019-09-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5cbf4ebd..e74d6b59 (698593:698711) Created with: gclient setdep -r src/third_party/webrtc@3c5f91b74871 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: Id8a59b70eca32bb37fbcecb8b72666e9bd2475b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819003Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698824}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b4d60b5eda31..5b4c0ee19b74 git log b4d60b5eda31..5b4c0ee19b74 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b6fa949c4539..1f89f58faeb8 (5 commits) Created with: gclient setdep -r src/third_party/skia@5b4c0ee19b74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: chromium:None Change-Id: I73c6ae54ec1c248059f721f1ccca7febb16732d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819000Reviewed-by:
-
Alan Cutter authored
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=media%2Fvideo-played-reset.html TBR=steimel@chromium.org Bug: 1006659 Change-Id: I23cba878f2ad2f993f946c6f11d8af49703580e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817869Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#698822}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If8ebf2941057e20541961a6b5099f07c93a484dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818999Reviewed-by:
-
Alan Cutter authored
Mark external/wpt/html/cross-origin-embedder-policy/require-corp.https.html as flaky on debug builds https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fhtml%2Fcross-origin-embedder-policy%2Frequire-corp.https.html TBR=pbos@chromium.org Bug: 626703 Change-Id: I48c678b89e40109b65967691143872e21b86bb7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816062Reviewed-by:
-
Wei Lee authored
This CL supports the data chunk mechanism so that we could record long-length video via camera intents. Bug: 980812, 967611, b/131809655, b/134635999 Test: am start -a android.media.action.VIDEO_CAPTURE Change-Id: Ieb18c614d942fb1f59743a37eb5cfa9cbab40128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722167 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#698819}
-
Darren Shen authored
We'll be doing some work on IMF so let's clean up the code a bit. I ran clang-tidy with: modernize-use-auto,modernize-use-equals-default,modernize-loop-convert, modernize-raw-string-literal,llvm-namespace-comment, modernize-use-emplace,modernize-use-using,modernize-raw-string-literal on //chrome/browser/chromeos/input_method/* //chrome/browser/extensions/api/input_ime/* Bug: 1005619 Change-Id: I1634591833f82e352d268bedb08516d0528b66c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815805 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#698818}
-
Peter Kasting authored
Testing to see if this route avoids breaking the Linux Deterministic bot. TBR=bbudge Bug: 82078 Change-Id: I1512141cc886dafa6683f5ff38c6a50f35be067a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818998Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#698817}
-
Raul Tambre authored
Conversion performed automatically using '2to3 -w -f has_key .'. This is backwards compatible with Python 2. Bug: 941669 Change-Id: I8e681b7ef8cc78b94c14b0c97101a3a0a32459bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816414 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#698816}
-
Alan Cutter authored
fast/canvas/OffscreenCanvas-copyImage.html and virtual/gpu/fast/canvas/OffscreenCanvas-copyImage.html are flaking on all debug bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=OffscreenCanvas-copyImage.html TBR=mstensho@chromium.org Bug: 974652 Change-Id: I841ef1902b831dbb5302efaec60d353ee1b5edb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817868Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4f789591c8f2..11e2cbc5cca3 Created with: gclient setdep -r src-internal@11e2cbc5cca3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ife871c6aece7e9c1565eb658e26eea5913bc9d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818640Reviewed-by:
-
Jinsuk Kim authored
This CL moves bookmark-related API's in Tab class out to chrome/browser/bookmarks (specifically BookmarkBridge) which seems to be a better fit for the task. Also moves the invalid bookmark ID definition to BookmarkId. The new methods find the bookmarkid of the passed Tab by getting the URL and the profile from its WebContents. Thought BookmarkBridge is always up-to-date to use the selected Tab's profile, so the methods could use the bridge's |profile_| but I guess I was wrong - many tests fail at DCHECK https://crrev.com/c/1809289/4/chrome/browser/android/bookmarks/bookmark_bridge.cc#1093 hence switched to static methods. Bug: 925242 Change-Id: Iff38f45159c64b0d0a2cba9d602809ab0e0f7b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809289Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#698813}
-
Glen Robertson authored
Fixes issue where CanBookmarkAppHandleUrl could correctly be false for a PWA but then its launch URL would be checked anyway as if it was a Shortcut App. Bug: 1006054 Change-Id: I5d5e58bd01f214f8cd42641f06afecb7fef2ab69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815803 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
Maggie Cai authored
The CL fetches the scope field for PWAs and convert it to App Service intent filter struct. BUG=853604 Change-Id: I44928b2d1ef771f7edc7ce2c1f14188249872693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816489 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#698811}
-
Darren Shen authored
Currently, sendKeyEvents needs to send keyData, which has a compulsory requestID field. However, this field is not used by IMF at all. We make two backwards-compatible changes to the public API: 1) Make KeyboardEvent.requestId optional. Then, |sendKeyEvents| can omit the requestId. All existing code will still work as IMF will still populate the requestId field for onKeyEvent. 2) Make onKeyEvent have a third parameter, which is the requestId. This is not strictly necessary, but makes a better API since |requestId| is not part of the KeyboardEvent, but rather the onKeyEvent event. Change-Id: I562ed7ecb27a660c862e12e2032a7066d2b15a39 Bug: 1005996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808666 Commit-Queue: Darren Shen <shend@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#698810}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: Idaa704425ae24b233e09189d4f8bb1a39bb628be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818820Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698809}
-
Jeonghee Ahn authored
broken links. - ... [Running Web Tests Using the Content Shell](web_tests_in_content_shell.md) - ... [docs/web_tests_linux.md](./web_tests_linux.md). Change-Id: I5dd681d21e2f6e340f0907581d67f1fbfcd647fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817863Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#698808}
-
Alan Cutter authored
This reverts commit bf29e54a. Reason for revert: Broke Deterministic Linux (dbg) bot. https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/11261 Output: Unexpected files with diffs: nacl_test_data/extension_vcache_test/glibc/extension_validation_cache_libs/lib64/libppapi_cpp_lib.so nacl_test_data/glibc/pm_exit_status_test_libs/lib64/libppapi_cpp_lib.so nacl_test_data/glibc/simple_libs/lib64/libppapi_cpp_lib.so nacl_test_data/glibc/sysconf_nprocessors_onln_test_libs/lib64/libppapi_cpp_lib.so ppapi_nacl_tests_libs/lib64/glibc_x64/libppapi_cpp_lib.so Bug: 1006638 Original change's description: > Remove using directives ("using namespace x") from ppapi/. > > Bug: 82078 > Change-Id: I5acb5fde43a747f319709222a6cdbb7a414df070 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816293 > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698766} TBR=pkasting@chromium.org,bbudge@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 82078 Change-Id: I6d28134d3fbabac5e243123201af795692b9d8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817865Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts ProxyResolverRequestClient and ProxyResolverFactoryRequestClient from ProxyResolverFactoryMojoTest to new Mojo types. Bug: 955171 Change-Id: If23e54b4c2bdbc0ab43d84de7c5abb4fe268be3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812937 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#698806}
-
Jinsuk Kim authored
This CL replaces NavigationPopup with NavigationSheet for the history popup menu impl triggered by long press on back button. This allows the gesture navigation sheet and navigation popup to have same UI. The only difference between them is that, on long press on back, the sheet fully expands to show all the items. Now NavigationPopup class is used by back/forward button on tablet only. Bug: 999377 Change-Id: Ib68de11f0e5ac5357723ffbd1401c7859393a4ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792687 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Trent Apted authored
E.g. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/6932 Test times out. Possibly related to recent change in r696987. TBR=yigu@chromium.org Bug: 1006635 Change-Id: I72f0a17f94932e7d197e4a90f99d81769e6299a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818878Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#698804}
-
Trent Apted authored
This reverts commit a42225db. Reason for revert: Test consistently fails on Linux Chromium OS ASan LSan Tests (1) e.g. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/35424 errors like [12262:12262:0922/152157.497151:FATAL:compositor_frame_sink_support.cc(336)] Check failed: result == SubmitResult::ACCEPTED (5 vs. 0) Details in BUG=1006633 Original change's description: > Portals: Add chrome/ browser test for activation > > Bug: 927056 > Change-Id: Ief5a22cf86cd6bdeeae4361e616f66487f589c9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809115 > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698129} TBR=avi@chromium.org,adithyas@chromium.org,lfg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 927056 Change-Id: Ib245b7d25b719d791ef6aeefa044200d90a64d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818877Reviewed-by:
-
Trent Apted authored
E.g. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/6929 [1756:1756:0922/124740.991289:ERROR:browser_context.cc(300)] Ignoring request for unknown per-browser-context service:multidevice_setup ../../chrome/browser/chromeos/login/session/chrome_session_manager_browsertest.cc:295: Failure Expected equality of these values: expected_brand Which is: "" google_brand::chromeos::GetBrand() Which is: "TEST" Stack trace: [1756:1756:0922/124741.053454:INFO:rlz_tracker.cc(306)] RLZ is disabled [ FAILED ] GuestSessionRlzTest/GuestSessionRlzTest.DeviceIsLocked/0, where GetParam() = false (664 ms) TBR=rogerta@chromium.org Bug: 997360 Change-Id: I020c643d74107e0ee811f829bfea3a8f75400d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817864Reviewed-by:
-
Trent Apted authored
Consistently failing since e.g. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/29406 Errors like [10182:10182:0919/233523.341151:ERROR:service.cc(373)] Failed to retrieve primary account info. ../../chrome/browser/ui/app_list/chrome_app_list_model_updater_browsertest.cc:82: Failure Value of: oem_app Actual: false Expected: true TBR=dominickn@chromium.org Bug: 1006522 Change-Id: I8c56ccdd0cdf82d671a9a3ef77c3b9641f178271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816255Reviewed-by:
-
Matt Giuca authored
(In addition to the existing same-origin check in the browser.) Bug: 1001404 Change-Id: Iac497980928da78458472cf3a6953e04b2ea8218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804707 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#698800}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9c9449e7331..4f789591c8f2 Created with: gclient setdep -r src-internal@4f789591c8f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7dc9c1e62d60381e012f420002db5f5430df6f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818120Reviewed-by:
-
- 22 Sep, 2019 13 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8e4e504bae2e..8ab15bbab0fa git log 8e4e504bae2e..8ab15bbab0fa --date=short --no-merges --format='%ad %ae %s' 2019-09-22 vapier@chromium.org lint: fix a few redefined-argument-from-local warnings Created with: gclient setdep -r src/third_party/chromite@8ab15bbab0fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: If65284bfe94fadf764a312c1672dd6c3058d0b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817693Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic6884b8ca7d1fca2815ef496d97eb469837ac754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817694Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dfab53cb6dbb..c9c9449e7331 Created with: gclient setdep -r src-internal@c9c9449e7331 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7b8b6cf966abb8787252de100e2f7fe4190e0a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817691Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8b9de727666c..b4d60b5eda31 git log 8b9de727666c..b4d60b5eda31 --date=short --no-merges --format='%ad %ae %s' 2019-09-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@b4d60b5eda31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: Icf85707ea41635e25855ac05548e2ee26a10a1b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817692Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/82ae4b4b7d53..7cb60e812f16 git log 82ae4b4b7d53..7cb60e812f16 --date=short --no-merges --format='%ad %ae %s' 2019-09-22 tandrii@chromium.org git-cache: fix bug in prior CL. Created with: gclient setdep -r src/third_party/depot_tools@7cb60e812f16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ide6a67fb8dafdb50bd388d0ab2e0f63ad426de70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817690Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83de0881aaaa..dfab53cb6dbb Created with: gclient setdep -r src-internal@dfab53cb6dbb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9786f0f8a3971fb159971d3410c1908a3b6a5992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818376Reviewed-by:
-
Elly Fong-Jones authored
In order to fully fix the linked bug, I need to change the color of this icon; doing that on a PNG is considerably painful. As such, this change first switches from using the PNG to using a vector icon. That allows cleaning up some bespoke image rendering code used with the old PNG icon. A followup CL will perform the actual color adjustment; this CL uses the exact colors the old PNG used to avoid unnecessary visual changes. The new Material icon does look slightly different from the old PNG, but that delta (the icon being different) has been approved by UX. TBR=oshima@chromium.org Bug: 957391 Change-Id: I3787b561dbe15bf00977ad54dd57ce183115bbec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815733 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#698792}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7b6b405503c1..8e4e504bae2e git log 7b6b405503c1..8e4e504bae2e --date=short --no-merges --format='%ad %ae %s' 2019-09-22 vapier@chromium.org cros_build_lib: replace PartialCmdMock.CmdResult with cros_build_lib.CommandResult Created with: gclient setdep -r src/third_party/chromite@8e4e504bae2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I9276795d51903d9f084b2c94cd87bbd99a1dd3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817347Reviewed-by:
-
David Grogan authored
It should only be definite if the element already had a definite main size or if the container has a definite main size. This is #2 from https://drafts.csswg.org/css-flexbox/#definite-sizes Bug: 845235 Change-Id: I0230080d22ada93ebc8bae09aeda629d87cf5b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797442Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#698790}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1848f3e9638d..8b9de727666c git log 1848f3e9638d..8b9de727666c --date=short --no-merges --format='%ad %ae %s' 2019-09-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@8b9de727666c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: I0eca82fdd5519f3bc6baa9edc3a2bb573facc1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818639Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2e00c9f853b8..1848f3e9638d git log 2e00c9f853b8..1848f3e9638d --date=short --no-merges --format='%ad %ae %s' 2019-09-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@1848f3e9638d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: I1d56dd2060d9627caf35b1538d04c23f75cd9861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818375Reviewed-by:
-
Raul Tambre authored
Initial conversion performed using '2to3 -f print .'. Imports added and duplicate parentheses removed manually. Manually converted files, comments and inline code that 2to3 missed. Afterwards ran "git cl format --python" and cherry-picked the formatting changes. Fixed a syntax error in check_grd_for_unused_strings.py due to a missing comma (caught by pylint). There are no intended behavioural changes. Bug: 941669 Change-Id: Ie0c67e5e416f386830e95aa2469b18a98b5425a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818477 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#698787}
-
Raul Tambre authored
Initial conversion performed using '2to3 -f print .'. Imports added and duplicate parentheses removed manually. Manually converted files, comments and inline code that 2to3 missed. Afterwards ran "git cl format --python" and cherry-picked the formatting changes. There are no intended behavioural changes. Bug: 941669 Change-Id: I9d8cb5d770a3f68231d0dea664a12a10fb81ce9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814923 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
