GitLab

As described in the bug, |ElementProviderFromPoint| was hanging when
performing hit-testing on the PDF toolbar buttons.  Stepping through the
code, it was apparent that the loop in that function was alternating
between two different elements, and never exiting... but only when the
monitor scale-factor was something other than 100%!

Stepping a little deeper, it became apparent that the problem was in
|BrowserAccessibilityManager::CachingAsyncHitTest|.  It is passing the
|scaled_point| when it recurses on the |root_manager|, meaning that the
point was getting scaled twice in that case.

The result was that |CachingAsyncHitTest| would return a different
element depending on whether you called it on the root manager or a
child manager... and these were the two elements that we were
alternating between in |ElementProviderFromPoint|.

The solution is to pass the original |screen_point| to the recursive
call.  (I also reordered the code to make the flow more obvious.)

Bug: 1032299
Change-Id: Ief01a2e961d14ad75eec3f1017a98c57f77613a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957129Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Ian Prest <iapres@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#724032}

See [1] for a description of a project to potentially dispatch
legacy DOM mutation events on CEReactions timing. For that
project, these use counters were added. The conclusion of
the project, at least for now, is that the usage is too high
to warrant changes. To clean up the old code and regain a bit
in node.h, I'm removing the use counters.

[1] https://docs.google.com/document/d/1vYBKZGjE-EEFHy-sidffEqKNxuBSENcym3ql-3jDYfk/edit

Bug: 859391
Change-Id: I82c6ed19e067d44ee320b3ab60ec465c1a48c137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962893
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724031}

This CL removes the GetInitiatorSchemeBypassingDocumentBlocking method
from ContentBrowserClient.

This method used to be called by implementation of Cross-Origin Read
Blocking (CORB) before NetworkService shipped.  This dependency is gone
now.

Before this CL, the only remaining caller of this method was
AppCacheSubresourceURLFactory::CreateLoaderAndStart.  The method was
called to exclude content script requests from request_initiator checks
(this exclusion was introduced in r624685).  Such exclusion is no longer
needed, after request_initiator=website (see r694827 and r710554).

Bug: 940068
Change-Id: I736f1414ffe890da9cd6477d377f4482168befae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926541Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724030}

Merge the OverlayCandidateValidatorOzone class's functionalities into
OverlayProcessorOzone which is a subclass of
OverlayProcessorStrategy.

This is CL 8/? of overlay processor refactor.

R=rjkroege
TBR=kylechar

Bug: 963597
Change-Id: I0033f59825898b16eefceb67357211dfb0fb578c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954538
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724029}

This is a step to move feature-specific logic out of
ChromePreferencesManager and delete it.

Bug: 1022102
Change-Id: I04bab089d99529fa6786a26f9518b36864051d3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954556Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724028}

Bug: b/145774037
Test: Manual
Change-Id: I81b3d2b7d20cb600db09a1d60bad7ce8c64d9b7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955028
Commit-Queue: Li Lin <llin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724027}

Allow CancelableTaskTracker to be configured not to cancel off-sequence
tasks, using a Feature.

This allows us to evaluate the impact on performance metrics of not
cancelling off-thread tasks (e.g. database operations). Tasks running on
the posting thread continue to be cancelled normally, since callers rely
on that guarantee.

This is a re-land of https://chromium-review.googlesource.com/1949777,
fixed to avoid implicit initialization of the global FeatureList if
the setting needs to be checked before the FeatureList has been
initialized.

Bug: 1030235, 1009795, 1031427
Change-Id: Iab9c2a6fdcf20c2c428df79b35417e4296ac89d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963191
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724026}

No change to production logic.

This adds integration tests for NetworkMetricsProvider and
AndroidMetricsProvider (both of which were already integrated). This
does not test the providers work as expected (glancing at the code, I
don't see why they would break in AW, so I think their unit tests are
sufficient), it only tests that they log some sort of value for their
proto fields or histograms.

Bug: 1011991
Test: run_webview_instrumentation_test_apk -f AwMetricsIntegrationTest#*
Change-Id: Ifa4a59b06ced2f089fc326bc4dd88f8c0fe49cc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961217Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724025}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8852b8bbb1c1..1159fec7d02e


Created with:
  gclient setdep -r src-internal@1159fec7d02e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:984162
Tbr: jbudorick@google.com
Change-Id: I52a3fc5e8097a71bb0ebf908ad2ecffe585260a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962543Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#724024}

Inline and remove the following deprecated methods in favor of their
contextless versions:
- ChromeBrowserInitializer#getInstance(Context)
- SyncController#get(Context)

This was a mechanical refactor done with Android Studio, followed by
some manual cleanup of unused variables and parameters.

Should be submitted after downstream change lands:
https://crrev.com/i/2295459

Change-Id: I4e875cedbcd49b294616fe7ee88a2bfd512b4749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960179Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724023}

This reverts commit dd747e31.

Reason for revert: Clang has segfault in go/chrome-ci-builder/linux-chromeos-chrome/75

Original change's description:
> Roll clang n332890-c2443155-1 : n333629-caa41209-1.
> 
> Ran `./tools/clang/scripts/upload_revision.py caa412090666c10f854322cdc701c1cbf8ed726e`.
> 
> Change-Id: I7cb80e1332fadd08e39e5e4d6cd224c270ee5f74
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959582
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Auto-Submit: Reid Kleckner <rnk@chromium.org>
> Reviewed-by: Bob Haarman <inglorion@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#724004}

TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org,inglorion@chromium.org,inglorion@google.com,akhuang@google.com

Change-Id: Iaef4152abe0631ffae48ffb973a49f13bd8c00c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962602Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Anushruth  <anushruth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724022}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: If051341242dd90e83feb5b2f9941201ccc63167a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962542Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#724021}

This is attempt #2. Attempt #1 (crrev.com/c/1898151) was rolled back
(crrev.com/c/1944286) due to performance and RAM usage regressions
(crbug.com/1023129, crbug.com/1023191).

During that time, there has been some optimization work done in the
upstream Skia project, especially around RAM usage, so we are trying
again.

Still, as crrev.com/c/1898151's commit message says, this change isn't
about performance per se, it is about tracking upstream Skia.
Nonetheless, here are some before-vs-after total times for Chromium's
"image_decode_bench -i 10" program for x86_64, on a selection of GIF
images that noel@chromium.org collects:

old_time  new_time  ratio file_name  file_size
0.000139  0.000325  0.43  bar.gif          265
0.000217  0.000315  0.69  radient.gif     1034
0.001144  0.001045  1.09  mondrian.gif    3792
0.002364  0.001987  1.19  rain.gif       10272
0.008795  0.005614  1.57  flag.gif       41738
0.020884  0.013044  1.60  warp.gif      106420
0.377886  0.286732  1.32  hex.gif      1072114

A ratio higher is better: more than 1.00 means that the new GIF decoder
is faster than the old one.

Bug: 1014044
Change-Id: Iba304db1ceea0661e0ca57308c2a68b2c48297a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958292Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724020}

Bug: none
Change-Id: I293d340188fc23ffe701f13260eb9e4915f4c3f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959713Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724019}

Add AttachControllerToTask to handle background tasks, which is
similar with the current implementation:
https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc?q=AttachControllerToTask&l=468&dr=CSs

Copy the current ARC item controller to AppService item controller to
record the task id:
https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc?q=ArcAppWindowLauncherItemController::AddTaskId&l=26&dr=CSs

When ARC apps are removed, OnTaskDestroyed is not called, so copy the
current OnAppRemoved implementation in ARC app window to the
AppServiceAppWindowArcTracker:
https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc?q=OnAppRemoved&l=290&dr=CSs

BUG=1011235

Change-Id: I1377190895c485f55bfc8aae5f7c54099c9d1da6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961826
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724018}

The local() function in the src attribute of @font-face allows
specifying system fonts to try using when using a particular
font-family.

The current FontMatchAttempts considers fonts loaded by @font-face to be
web fonts, even if they use local(). This CL augments that UKM metric to
add counts for @font-face src:local matching.

UKM privacy review doc (Google internal):
https://docs.google.com/document/d/1YtF7GvIhApgp1V7_9X8tSy4mZ-T9cssbMR3bVWw7AOE/edit?usp=sharing

Bug: 1025945
Change-Id: Id8842e21eaf9b984ade9c4aa4dbf192cc1429f12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931140Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724017}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a0ccfd73da86..98ea80082239

git log a0ccfd73da86..98ea80082239 --date=short --first-parent --format='%ad %ae %s'
2019-12-11 brgoddar@microsoft.com Revert "Fix background on rows with error network logview"

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@98ea80082239

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I353bbe1dc6ec9e1073829c286fb271bdc09ade5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962971Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#724016}

Get the cloud token data from Chrome Sync and store them locally in the
Chrome database. This will be stored in a separate table.

Add a entire new wallet sync flow for this data. This data will only
be modified via sync bridge. (No personal data manager
interactions, etc)

The usage of this data will be added in following CLs.

Change-Id: Ic0c802f031d4612589ed173d300395fcb4253b5a
Bug: 1020740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897317
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724015}

Updating the pixel_expectations for Android.
We've fixed some video related failures.
We have now also retriaged older failures, to find out their current
state. New bugs have been filed where appropriate.

TBR=ynovikov@chromium.org
TEST=pixel_tests

Change-Id: I82c23e4d70a43ab55159c90a925c1ef6e820ba81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961604Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724014}

This is fully launched in M79 and can be removed now.

Bug: 914577
Change-Id: Icce750059737f12f1d26edb143abc05165d25087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955102Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724013}

This change adds the ResolvePpdLicense() method to PpdProvider which
can be used to determine whether a given effective make and model name
of a printer is associated with any proprietary PPD license.

Change-Id: I3bdfa2aca501dbb6a9a756c86eaf7eaffb78301c
Bug: 1020586
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953694
Commit-Queue: David Valleau <valleau@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724012}

The shelf bounds being passed into WorkAreaInsets are already in screen
coordinates, so the current calculation is not correct for secondary
displays.

However, the shelf's ideal bounds are in window coordinates and need to
be converted to screen coordinates.

TEST=manual + unit tests
BUG=1019289

Change-Id: Ic0ad5604f7f52f6a41a66114b0c22c9f8f789f21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959576
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724011}

This CL modify the window pointer for Web apps, and use the top level
window pointer for Chrome only. For Web apps, still use the tab's
window pointer. This fix is used to fix All/HostedAppTest.* browser
tests, because that tests pull the Web apps to Chrome, which cause the
app id changed in AppService InstanceRegistry, so DCHECK crash:
https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/448712
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8894423355073665120/+/steps/non_viz_browser_tests__with_patch_/0/logs/Deterministic_failure:_All__x2f_HostedAppTest.CtrlClickLink__x2f_0__status_CRASH_/0

BUG=1011235

Change-Id: Id308f394c95196d507d164bb2fe5ac2fbeab406b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957749
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724010}

Bug: 1009881
Change-Id: Ic3c00b61b8d9984b77b0d8e38a5a10d8a9c6e4d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956241Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724009}

Use OnceCallback where possible because the callback is only used once
and RepeatingCallback and BindRepeating otherwise.

After this, content/ is without legacy Bind/Callbacks, so we remove it
from the PRESUBMIT allow list.

R=avi@chromium.org, dcheng@chromium.org
TBR=dcheng

Bug: 1007760
Change-Id: I15295047b9f07fcdecaa553a5f404a95fb6e2e8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963091Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724008}

Provide a command line argument to control the behavior of the
Autofill Server recommendations during test replay.

Switch `--autofill-server-type` is used to override the default
behavior of using the cached responses from the recording.

Valid options are:
  SavedCache       - Uses cached responses. This is the Default.
  ProductionServer - Connects to live Autofill Server for recommendations
  AlwaysNone       - Test with local heuristic recommnedations only

Bug: 1031655
Change-Id: I6b1e4c1384b9233df8e42ce7b16e21e691ff8d36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956247Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
Cr-Commit-Position: refs/heads/master@{#724007}

This reverts commit 2e7eb004.

Reason: In crrev.com/c/1925687, the functions within the Port class were modified to set
their output directory to the artifacts directory. Some scripts like run_webdriver_tests.py
will not create the artifacts directory, therefore whenever classes like WPTServe were
instantiated an exception would be raised because the artifacts sub-directory was not created.
This CL will make the server classes create the artifacts directory. It will also add an optional
parameter for the output directory to the server starter functions in the Port class.
The default value for these parameters will be the artifacts directory.

Original Description of commit reverted:

Revert "[web tests] Add layout-test-results/ prefix to all artifact relative paths in json results"

This reverts commit 9138bb30.

Reason for revert: Suspect to cause:
https://crbug.com/1032504

Original change's description:
> [web tests] Add layout-test-results/ prefix to all artifact relative paths in json results
>
> This will make the artifacts paths consistent with the isolate output directory paths. All
> test runners should follow this standard for outputting artifact paths in the JSON results.
>
> Bug: chromium:1026494
> Change-Id: I36dbbb2a9bec507182610e959edf55f1819d2ca7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925687
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Robert Ma <robertma@chromium.org>
> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
> Commit-Queue: Rakib Hasan <rmhasan@google.com>
> Cr-Commit-Position: refs/heads/master@{#723270}

Bug: chromium:1026494
Change-Id: I272242b00b9334c8bc6b6443638ead5aa17db54f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960716
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724006}

Validate that OpenGL query extensions are present before calling
glDeleteQueries. This was attempted in a previous change but one
entry point was missing, causing a null dereference.

Bug: 1026911
Bug: 1031524
Change-Id: I7a4980ea13f2160102de94b6426db18d49fa6dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961009Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#724005}

Ran `./tools/clang/scripts/upload_revision.py caa412090666c10f854322cdc701c1cbf8ed726e`.

Change-Id: I7cb80e1332fadd08e39e5e4d6cd224c270ee5f74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959582
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Bob Haarman <inglorion@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724004}

See John's suggestion here:
https://bugs.chromium.org/p/chromium/issues/detail?id=1028811#c19

Bug: 1028811
Change-Id: I2d904ac86cfe1924bb0c8af7c635ec0efdc479eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954534
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724003}

This CL early-aborts MIX-DL blocking on download types that aren't
appropriate for blocking. These include internal downloads (e.g. when
Chrome downloads something for its own UI), WebView, downloads initiated
from the omnibox, and more. We record these downloads in an existing
histogram.

Bug: 1028179
Change-Id: Ice2d840ffb4810f3f00824c59632440c4865a44d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962532
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724002}

Numbers like 0xC0000005 and 0x80000003 are easily recognizable in hex
(access violation and breakpoint respectively) but confusing and
unrecognizable in decimal. So, print these in hex.

Bug: 803617
Change-Id: Ie2ade13fcb1390daa734650ab3cdfe8e37155e87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962589
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724001}

This file isn't actually used as of https://crrev.com/c/1888736, but I
forgot actually delete it.  Delete it now to avoid confusion. It will
be re-added (with different contents) soonish.

Change-Id: I7f32d08c530cb55075e5fc05262372707af6d59f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962544Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724000}

Now that there is OverlayProcessorStrategy class always holding an
OverlayCandidateValidatorStrategy, move some data and shared functions
from validator class to the overlay processor class.

This is also part of merging overlay validator into processor.

This is CL 7/? of overlay processor refactor.

R=rjkroege

Bug: 963597
Change-Id: I55a961a818da60a0cb9d5a7c5b322d2c86d1945d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953754
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723999}

This came up in a mailing list discussion:
http://g/sampling-profiler-core/lzZlIlY5PLM/xLWKG5PEAQAJ

Once a DFM is installed by Play, it will be updated alongside Chrome. A
separate reinstall will not be necessary on every app update.

Bug: None
Change-Id: I7d839b2161e72cb81c77796336918ede1b0e7f75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963094
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723998}

Bug: 942279
Change-Id: I78d1f7724a4101369eadd464b3d2b47c9ef35dc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959530Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723997}

IndexedDB schedules all of it's operations on the transaction's
operation queue, and these operations can hold quite a lot of memory.
This is accounted for in any of the memory dump providers, so this adds
that accounting and reports it accordingly.

R=erikchen@chromium.org

Bug: 1028623
Change-Id: Ib42986346cedea510632165e7b1bb04ac246769a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956161
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723996}

TBR=govind@chromium.org

Change-Id: I19a2e25cb4794a234a75f510e98cf2ef2c594219
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962794Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723995}

This fixes a race where the FrameSinkId might arrive after the embedder
generated a frame, causing a flash during portal adoption.

Bug: 966119
Change-Id: Iad8948f1f0c596817fbf468a54bbd5ccf432cef5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960825Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723994}

Follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/1894293

Bug: 982018
Change-Id: I5d7a6f706071d1fda3688473fbe9acded464b067
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957128Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Mia Glaese <glamia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723993}