GitLab

Provide better overview.

Provide link to go/chrome-benchmarking-sheet.

R=wenbinzhang@google.com

Bug: 949246, 1054000
Change-Id: I5a36bd5d362b1e8fa28cd90ef7a973f503d62d45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092058
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747959}

https://skia.googlesource.com/skia.git/+log/24a8e9e170f7..1b0124fec65c

git log 24a8e9e170f7..1b0124fec65c --date=short --first-parent --format='%ad %ae %s'
2020-03-06 brianosman@google.com Move interpreter disassemble to out-of-line member of ByteCode
2020-03-06 mtklein@google.com Revert "Split building encoding from decoding"
2020-03-06 brianosman@google.com Handle runtime effect shader errors better

Created with:
  gclient setdep -r src/third_party/skia@1b0124fec65c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC herb@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: herb@google.com
Change-Id: Ib649767fae068f078644dc317402a829105a465a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092454Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747958}

Remove a stale TODO from declarativeNetRequest code. This was fixed in
https://chromium-review.googlesource.com/c/chromium/src/+/2016201.

BUG=974391
TBR=lazyboy@chromium.org

Change-Id: I374b08f428491cdd678c334238de8d5d3d23aba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092873Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747957}

TBR=arakeri@microsoft.com

No-Try: true
Bug: 1058244
Change-Id: Ib1e272813e477245a98901ce9d6fe611616a252e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092876Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747956}

Bug: 1059187
Change-Id: I6d42d40d5d6971ddba41c2fe62cb39e7b1e1b9f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092431Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747955}

This changes NativeFileSystemPermissionView to not only support asking
for write access, but to also support asking for read access (as well
as asking for read and write access at the same time).

Also changes the origin scoped permission model to go through this new
code path when asking for read access.

This does not hook anything up yet to ask for read and write access at
the same time (that will still DCHECK in the content layer), dealing
with that case will be handled in a follow-up CL.

Bug: 984769
Change-Id: I5fc276b11802e105379ae42e0f6abf84f2c7d81f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091920Reviewed-by: Olivier Yiptong <oyiptong@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747954}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4d2824af525d..57d4742bbb10

git log 4d2824af525d..57d4742bbb10 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 ehmaldonado@google.com git-cl: Tell users to set SKIP_GCE_AUTH_FOR_GIT=1 when running on cloudtop.
2020-03-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@57d4742bbb10

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1059141
Tbr: agable@chromium.org
Change-Id: Icb14cfc48478070475b4215e3740ce6dc38c4c1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092452Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747953}

The specification for the Switch Access menu (see bug for full details)
specifies that the menu should be translucent, with rounded corners.
To accomplish this, we need to make the underlying view transparent.

Previously, the menu showed with a white background filling the
bounding box.

Bug: 973719
Change-Id: I101bb6203fd8c972f7b235821e0f0a51cafa25e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085596Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#747952}

Support /* ignore */ annotations in Polymer modulizer, following the
same approach as the JS modulizer. This will be used to temporarily
migrate settings_idle_load and settings pages that depend on it, before
adding lazy loading to the Polymer 3 page.

Bug: 1026426
Change-Id: Iaf2b3d1e3ba69f97946039522d86ecf2739370cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092183Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747951}

Extend the expiration date for most fingerprint authentication UMA
metrics, except two:
1. Fingerprint.Unlock.MatchIgnoredDueToPowerButtonPress
     This was introduced to verify that the fix for the race condition
     between power button press and fingerprint match on Nocturne works.
     This metric shows that ratio of matches ignored due to power
     button press on Nocturne is stable and reasonable, so we can
     assume this worked and no need to further track it.
2. Fingerprint.Unlock.MigrationForPositiveMatchSecretResult
     This was introduced to verify the migration to positive match
     secret works. Since the migration worked and not many devices
     are expected to run old fingerprint firmware after M85, we can
     let it expire.

BUG=b:148979792
TEST=none

Change-Id: Idf78ebfb2a568414f989b2120b486a227b7d1ba9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090872Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Yicheng Li <yichengli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747950}

After inherit from TextBubble, the ProfileCardView is no longer a view, so it can't be the label of the layout file.

Change-Id: I79f0785eac13b33c3ab572d8cac0e78b2a26e6ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092216Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747949}

https://swiftshader.googlesource.com/SwiftShader.git/+log/8c13b2f02094..b44162fdbb25

git log 8c13b2f02094..b44162fdbb25 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 madesroches@google.com Support for the largePoints feature in Vulkan

Created with:
  gclient setdep -r src/third_party/swiftshader@b44162fdbb25

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I1f52ff1aeafd5045b8b0b042944070723497e1bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091672Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747948}

Also change the text to string16 as it will mostly used for rendering
UI.

Bug: b/150783279
Test: Unit tests
Change-Id: Ib940ebec905c22a75152a437d8e6c12f33ae4777
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092057
Commit-Queue: Li Lin <llin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747947}

This reverts commit 01102b89.

Reason for revert:
Caused 30 test failures in lollipop phone tester at https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/24514

Original change's description:
> [Android Refactor] Replace StatusBarColorProvider
> 
> This CL:
> - Makes StatusBarColorController use TopToolbarThemeColorProvider
> instead of StatusBarColorController.StatusBarColorProvider
> - Deletes CustomTabStatusBarColorProvider.java
> - Renames TabThemeColorProvider to TopToolbarThemeColorProvider and
> makes it return the correct value when there is no active tab.
> - Moves StatusBarColorController owners to RootUiCoordinator
> 
> BUG=1015627
> 
> Change-Id: I0aff744a8901c00c6198adfa1a086b7de6193a36
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063966
> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Reviewed-by: Peter Conn <peconn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747745}

TBR=twellington@chromium.org,mdjones@chromium.org,peconn@chromium.org,pkotwicz@chromium.org

Change-Id: I9a75cc5fd45133234f43988b495b2566836dbc50
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1015627
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092559Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#747946}

WebView permits apps to load their own Android assets and resources with
file:///android_asset/<name of asset> and file:///android_res/<name of
resource> respectively. Because these are meant to access the app's own
resources, we should treat them as internal to WebView and not search
for apps which expose intent filters matching this pattern.

This also avoids a crash. If another app targets N+ and exposes such an
intent filter, the embedding app will crash with
FileUriExposedException.

This does the same with chrome:// URLs, which was previously overlooked
because this can only happen if clicked from a frame loaded on the
chrome:// scheme (which can happen if the app uses loadDataWithBaseUrl).

This implements the fix for the default shouldOverrideUrlLoading()
implementation (in WebView) and WebView shell's
shouldOverrideUrlLoading() (which is meant as a best practice for apps
to follow).

Bug: 1059193
Test: Manual - built a test app to let me click these URLs, verified
Test: default shouldOverrideUrlLoading works as intended
Change-Id: I797c4b45cf15bf6c519bf55a848ed646456a6fd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092416
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747945}

These actions are helpful for Breadcrumbs feature that attaches steps to
reproduce to crash reports.

Bug: 1046231
Change-Id: Ib21bfa86fdcebcf692fd23f0a5273d61bea5152a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089978
Commit-Queue: Eugene But <eugenebut@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747944}

ChromeTestExtensionLoader is the most common mechanism used to load
extensions in tests, and is used in both unit and browser tests. It is
the underlying mechanism used in
ExtensionServiceTestWithInstall::InstallCRX() (and variations) and also
ExtensionBrowserTest::LoadExtension() (and variations).

Currently, the ChromeTestExtensionLoader loads the new extension, adds
it to the profile, and then waits for extension readiness by
a) waiting for extension content scripts to load, and
b) waiting for all active extension WebContents to finish loading.

Unfortunately, this can be insufficient if the extension WebContents
hasn't been created yet. Since we queue ExtensionHost creation, this
can be an asynchronous process, and can (depending on other factors)
happen sufficiently late that the ExtensionHost isn't created by the
time we check whether all WebContents are done loading.

This inconsistency leads many tests to exercise the following pattern
in their background page, to avoid flakiness:

chrome.<something>.addListener(() => { ... });
chrome.test.sendMessage('ready');

However, this should be unnecessary, because we should be able to wait
for the background page to finish its first "spin" before proceeding
(which would mean we only have to take the "listen for ready" approach
if an extension has to perform asynchronous set up).

Modify ChromeTestExtensionLoader to also wait for the background page's
ExtensionHost to be created and finish its first load before proceeding.
Apply this behavior only if there exist any renderer processes, as a
proxy for whether this is running in a unit or browser test (since
waiting on a background page in a unit test will wait forever). Allow
tests to override this behavior (which is necessary if they never expect
the page to load).

Add a regression browser test that exposes the previous potential
failures by incorporating a delay into ExtensionHostQueue.

Bug: 1038051

Change-Id: Ic736ae4990dcc9ec9bc50b79d65768c705b2748b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982770Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747943}

This reverts commit ac7a6b27.

Reason for revert: Suspicious chromeos official build browser_tests failures: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3777

Original change's description:
> Move ExecutionContext to LocalDOMWindow (attempt #2)
> 
> This actually changes the structure, so that LocalDOMWindow inherits
> ExecutionContext, rather than Document.
> 
> I left as much logic as I could on Document, and had LocalDOMWindow
> call in to it. A few things needed to move for consistency, and I moved
> anything where the Document override of a ExecutionContext function
> was only called through the ExecutionContext interface.
> 
> Added null-checks and updated code to final format where it was necessary
> to keep tests passing, otherwise left transitional code/helpers intact.
> 
> Updated many unit tests that needed an ExecutionContext to use
> DummyPageHolder instead of just a standalone Document.
> 
> Bug: 1029822
> Change-Id: I6a94442382b2eed6d682c4993821718daf7797ee
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090148
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Nate Chapin <japhet@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747853}

TBR=dcheng@chromium.org,japhet@chromium.org

Change-Id: I5a759e30c8625e085393668e85b238c663e8960f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1029822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092556Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747942}

This reverts commit 4d323a02.

Reason for revert: This caused cast_runner_integration_tests to fail. See https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20x64/50467

Original change's description:
> [fuchsia] Enable ANGLE in web_engine
> 
> This is not currently compatible with --enforce-vulkan-protected-memory.
> which forces all shared images to be protected, including canvas
> resources.
> 
> Bug: 766360
> 
> Change-Id: I172c873d239a7e2da2012cf308d74198e615355e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090455
> Commit-Queue: Michael Spang <spang@chromium.org>
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747857}

TBR=spang@chromium.org,sergeyu@chromium.org

Change-Id: I9b5ca3ab6182b0629885d5802e2c4031603df01e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 766360
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092555Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747941}

Follow-up CL to crrev.com/c/2083573 to remove vague bool
flips_vertically.

Bug: 1051970
Change-Id: I7442d72396ae435521b9d9006202a4722c2a87eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091922Reviewed-by: kylechar <kylechar@chromium.org>
Auto-Submit: Kramer Ge <fangzhoug@chromium.org>
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747940}

This is a repeating callback as documented in:
* https://cs.chromium.org/chromium/src/media/cast/cast_sender.h?rcl=d6afb93c52bcd0e1681d60f303310c991c66e590&l=79

An example of this callback being repeatedly called is in the following
2 locations of the same class:
* https://cs.chromium.org/chromium/src/media/cast/sender/h264_vt_encoder.cc?rcl=62e892ae5ae694ab792ab5312066bd64c45e8412&l=173
* https://cs.chromium.org/chromium/src/media/cast/sender/h264_vt_encoder.cc?rcl=62e892ae5ae694ab792ab5312066bd64c45e8412&l=212

Another example is the callback being run on the audio status change
event:
* https://cs.chromium.org/chromium/src/media/cast/cast_sender_impl.cc?rcl=d6afb93c52bcd0e1681d60f303310c991c66e590&l=177

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40

Bug: 714018
Change-Id: I6d34ba74959538139b7f1e7eb45a373f95ccd2a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078471
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Auto-Submit: Jose Lopes <jabolopes@google.com>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747939}

This is an optimization -- once reparenting has been found, we generally
keep checking for more, as it could affect the least common ancestor.
However, there is no need to check the descendants of an ancestor node
that has already affected the least common ancestor.

Bug: None
Change-Id: I60967d4fe22ee8835f706a59f3e5d5816dae453b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092176Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747938}

This CL simplifies and reduces the amount of indirection required for
injecting test fakes. This pattern has been inconsistently copied and
pasted across many different files, so things have gotten a bit messy.
Before this CL, there were two general strategies:

1. Hold a default Factory instance in a base::NoDestructor and delegate
   to it if no test factory override is set. This has the disadvantage
   of requiring an indirect call even when no injection is needed, as
   well as incurring overhead for storing, initializing, and accessing
   the base::NoDestructor.

2. Heap allocating a new default Factory instance if no test factory
   override is set. Like before, this has the disadvantage of always
   requiring an indirect call even when no injection is needed. It is
   also potentially leaky in tests.

Instead, these locations have been updated to follow the same pattern as
RenderFrameHostFactory and the naming conventions have been
standardized:

- Entry to the factory is via a static Factory::Create() method.
- Factory itself is now an interface class, with a pure virtual
  CreateInstance() method.
- The factory override is set via a static Factory::SetFactoryForTesting
  method().
- If a factory override is set, Factory::Create() delegates to the
  factory's CreateInstance() method.
- Otherwise, Factory::Create() simply performs uses the default
  construction path.

There is no real behavior change from before: previously, the static
factory method already had to have knowledge of the default factory, so
this simply lifts that logic into the static factory method itself and
eliminates an unneeded layer of indirection.

A few miscellaneous style fixes have been included as well:
- All default args have been removed from the virtual CreateInstance()
  methods. Default arguments on virtual methods are banned by the Google
  C++ style guide, due to their confusing semantics in that context.
- All the Factory interface classes now have a virtual destructor.

The net result is the removal of 60 unnecessary base::NoDestructor
globals, and the removal of another 18 bare new calls that could
potentially leak.

Bug: 960538
Tbr: avi@chromium.org
Tbr: khorimoto@chromium.org
Change-Id: I657af336ab1538bd762352062bdc97df451dabec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088358
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747937}

Concerning TabletModeController, the if statement at the beginning of
SetTabletModeEnabledInternal checks the same condition as the if
statement in UpdateUiTabletState. It does not need to be checked twice.

Bug: None
Change-Id: I2e69c1f34c476f819ed42aa5dd66f46f1022d8e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090206
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747936}

This CL adds new methods to blinkpy's TestExpectation class which
extracts and encapsulates logic for adding and removing expectation
lines and also updating expectations files after the lines were updated.
This removes duplicate logic from several of blinkpy's sub modules.

Bug: 986447
Change-Id: Ie8a49dfb98c6553fb224cbfd691238cee6869f66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055892
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747935}

Bug: 1024915
Change-Id: I681937537b65e12253dd122d521f49b193612654
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049209Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Sajjad Mirza <sajjadm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747934}

So that we can attribute new Advanced Protection users to the
newly added entrypoint.

Bug: 1032584
Change-Id: I8f8a9a6c17008fb25843c89133a08c9cc2362ef6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080483Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747933}

Bug: 1059102
Change-Id: Ic7773bb238c82dd863676992720c9c0294186b62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091946Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sajjad Mirza <sajjadm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747932}

This reverts commit cb8fbfbf.

Reason for revert: 3P file had fallen out of TSAN whitelist when it was renamed, it has since been added back.

See: https://chromium-review.googlesource.com/c/chromium/src/+/2076278

Original change's description:
> Revert "Create field trial for hover card images."
>
> This reverts commit 9ba868cd.
>
> Reason for revert: <INSERT REASONING HERE>
> interactive_ui_tests failed on
> Builder Linux TSan Tests
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests
>
> Original change's description:
> > Create field trial for hover card images.
> >
> > This is required to deploy a finch configuration.
> > See cr/296239960 for WIP Finch config.
> >
> > Bug: 1032640
> > Change-Id: Ifae3d2966d4ca908982cec37c5d88f786bf07367
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067558
> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> > Commit-Queue: Dana Fried <dfried@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#743826}
>
> TBR=rkaplow@chromium.org,dfried@chromium.org
>
> Change-Id: I27fbe4d67b42a42d63757e78427d86d31e045592
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1032640
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069275
> Reviewed-by: Lan Wei <lanwei@chromium.org>
> Commit-Queue: Lan Wei <lanwei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#743839}

TBR=rkaplow@chromium.org,lanwei@chromium.org,dfried@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1032640
Change-Id: I13c1920b2e3d0a721af5475df789b15cf0794904
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091933
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Lan Wei <lanwei@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747931}

This reverts commit dfe67264.

Reason for revert: This breaks on device runs for xcodebuild_runner.
This revert will land after the revert of crrev/c/2076765.

Original change's description:
> [iOS][code coverage]Move raw coverage data to isolated output in test runner scripts.
>
> - Added function of moving raw coverage data in a new utility file and
>   corresponding tests.
> - Added "use_clang_coverage" arg to run.py and all simulator test
>   runner classes.
> - Added check of the arg and call to the function in TestRunners after
>   running unit tests and EG tests.
>
> Bug: 943883
> Change-Id: I5f16c152a38f7a8a3d988aac9e73964d890219b8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048851
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#744470}

Bug: 943883,1058257
Change-Id: I4ae784f831c60bf621c8135af490bdeffa3c004e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089404
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747930}

Bug: 1007815
Change-Id: I2eef21c585df6441715e188fcc816735b125b828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091532
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747929}

Now that test_runner.set_permission() is available these Wake Lock API
tests can be upstreamed to Web Platform Tests.

Bug: 1015327
Change-Id: I7bb1c7cbc458c8b7b05c0c2361fbe5ea50444e8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089968Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747928}

Also added a log statement and a cleanup of a value in the unit test.

Bug: 1058506
Change-Id: I6e43df059f11d7fdba8c430458a1d1f298a56905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090916
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Auto-Submit: S. Ganesh <ganesh@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747927}

This change swaps the order of the back and overview pages on the
gesture navigation screen. The new order for the gesture navigation
screen is as follows:
(Intro Page) -> (Home Page) -> (Overview Page) -> (Back Page)

Bug: 976949
Change-Id: Ic621c8c5a69b3b8a5c1e2822605944a94c68d8d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090356Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747926}

Used by Breadcrumbs feature that attaches steps to reproduce to
crashlogs. These actions duplicate some histograms, but Breadcrumbs
can't observe histogram logs.

Bug: 1046223
Change-Id: I2043a9cceee6639f4404906e8ea11f7e26648695
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090978
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747925}

ConditionVariable by default emits a trace event from Wait().
Message pump like code needs to explicitly disable this to avoid
emitting trace events while sleeping that make the thread incorrectly
look busy.

R=pwnall@chromium.org

Bug: 899897
Change-Id: I5c7078db3e4889ae3e946e045a4e626fcd7ee8b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090505
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747924}

These includes will not be valid when idb moves to the storage service.
Additionally, the size is not used as in the web ui so it is safe to
save it as a double instead of a formatted string.  (base::Value does
not support int64_t.)  It could also be potentially removed in the
future.

Bug: 1015214
Change-Id: I943fe6f89672560097b99f6883f7999d2a811495
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091710
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747923}

BUG=1059201

Change-Id: Ia2a6f4dd477bc52ec607d7d989e03875140d058d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091944Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747922}

We are adopting Chrome Flag Ownership in iOS.
go/chrome-flags-ios

More about flag ownership here:
https://chromium.googlesource.com/chromium/src/+/master/docs/flag_ownership.md

This CL creates a util file of data structures and functions that
are shared by:
//chrome/browser/about_flags_unittest.cc and
//ios/chrome/browser/flags/about_flags_unittest.mm

This CL migrates 5 tests to iOS. However, the main test that ensures
that flags in iOS have a corresponding metadata entry is disabled. This
will be enabled when the metadata file is filled out with iOS flags.

Additional followup CLs will add entries to the metadata files,
enable tests, and modify documentation.

bug: 1058614
Change-Id: I8c94183a47d2065c2fc4441e4fc7d9682d17da55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088034
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747921}

Add a new left pointing arrow SVG asset for use as file path separator
in RTL layouts.

The left pointing arrow asset was produced by hand flipping the points
in the existing right pointing arrow asset.

Changes the p:before separator for the files-ng bread crumbs to use SVG
assets instead of a text character pulled out from the current font.

Bug: 1035691
Change-Id: I61549e16a85ba2c709016fbd4272a860d2d2054c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090553
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747920}