- 12 Sep, 2019 40 commits
-
-
Ted Meyer authored
The UMA stats were wrong :( Change-Id: I400bd19b8a9be49bb3b209bc6366539eeae0bd3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799462Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#695938}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b81d59e59e07..5a2ba9996b20 git log b81d59e59e07..5a2ba9996b20 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 benjaminwagner@google.com Omit path_text benches on Pixel3a Created with: gclient setdep -r src/third_party/skia@5a2ba9996b20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I4b178da6e2cdb525906817b5491a41241776dc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799281Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695937}
-
nancy authored
This is just the first step, moving the code from ChromeLauncherController::LaunchApp/LauncherControllerHelper::LaunchApp to AppService, and still reuse all those functions in launch_service. Also move ConvertLaunchSource to extension_apps, as next step will be remove launch_util, or see how we can better organize the launch process. So for this CL I just move code, to make it works the same as before. There will be several separate CLs to follow up for this CL: 1. Update ChromeLauncherController to use AppService launch. 2. Refactor internal apps launch process. 3. Refactor extension apps launch process. BUG=1002351 Change-Id: I87cf52c82043b45b0c2d750c62c4ffd586510098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795527 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#695936}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5a5ffe52a944..d94d6a3d1103 git log 5a5ffe52a944..d94d6a3d1103 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 capn@google.com Assert Reactor Float constants are finite 2019-09-12 capn@google.com Fix construction of SPIR-V constant float objects 2019-09-12 capn@google.com Fix passing sampler offset operands unchanged 2019-09-12 capn@google.com Fix storing of non-float SPIR-V constants 2019-09-12 capn@google.com Fix non-float constant creation for ASM Created with: gclient setdep -r src/third_party/swiftshader@d94d6a3d1103 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140302841,chromium:b/140302841,chromium:b/140302841,chromium:b/140302841,chromium:b/140302841 Change-Id: Iad5d7bf74b78924d1b5e8507ea091f2d138a7ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800002Reviewed-by:
-
Hiroshige Hayashizaki authored
As preparation for migrating wpt/upgrade-insecure-requests to the /common/security-features generator framework in https://chromium-review.googlesource.com/c/chromium/src/+/1788551, this CL introduces `downgrade` redirection type, which is to be used to test upgrading on redirects. Bug: 1001422 Change-Id: I590015cdb48c9814135dbd61a91aa318ddeba2fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787571Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#695934}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9805913bb537..e373bb6ea58b git log 9805913bb537..e373bb6ea58b --date=short --no-merges --format='%ad %ae %s' 2019-09-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fe8ed20c..0d1efbbb (695755:695897) Created with: gclient setdep -r src/third_party/webrtc@e373bb6ea58b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Icb691e054fadcd67945b93912cdcd3fd424b9240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799280Reviewed-by:
-
Maksim Moskvitin authored
|kSyncUSSNigori| should be checked last, since check itself has side effect (only clients, which have feature-flag checked participate in the study). Otherwise, we will have different amount of clients in control and experiment groups. Bug: 922900 Change-Id: I400b1c419c5c952d074486b644c14de8ee20227f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798672 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#695932}
-
Austin Tankiang authored
Remove the multi-profile browser tests as DriveFS is the default in production, so we do not need these tests. The drive migration tests required the legacy drive sync client which will be removed, so remove them too. Bug: 1002339 Change-Id: I64aa397e9981dd49fdb60a47066bb9e242f5e2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797843 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#695931}
-
Kenichi Ishibashi authored
Before this CL there was a case where ReadyToRunWorkerScript() was called twice (see the linked bug for detail). The method should be called only once. To make sure ReadyToRunWorkerScript() is called only once this CL introduces another flag that tracks if InitializeGlobalScope() is already called. ResumeEvaluation() calls ReadyToRunWorkerScript() only when the flag is set. Bug: 1001967 Change-Id: I9e068208be5a11e47accc4c71da0eda2640a85dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792477 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Nigel Tao authored
BUG=1000828 Change-Id: I16870dd006c56b02ec0e58b4752f2843da192236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787671Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#695929}
-
Takuto Ikuta authored
This reverts commit 0f435b65. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux/24718 Original change's description: > Update axe-core to v3.3.2 > > This change updates the version of axe-core to the latest released > version. As part of picking up the latest version, the following > additional changes were made: > > 1) axe-core removed the 'href-no-hash' rule, so that been removed > from the test list. > > 2) Several 'link-in-text-block' tests started failing with > axe-core v3.0.2 (and later). These tests do pass in v3.0.1, but > are disabled as part of this change. > - CrManagementA11yTest.SimpleTest_link_in_text_block > - CrManagementA11yTestWithExtension. > ExtensionSection_link_in_text_block > - CrostiniAccessibilityTest.CROSTINI_link_in_text_block > - CrExtensionsA11yTest.NoExtensions_link_in_text_block > - MultideviceA11yTest.MULTIDEVICE_link_in_text_block > - MultideviceFeaturesA11yTest. > MULTIDEVICE_FEATURES_ACCESSIBILITY_link_in_text_block > > 3) One 'heading-order' test started failing in v3.0.0 (and later). > This tests does pass in V2.4.2, but is disabled as part of this > change. > - CrExtensionsA11yTestWithMultipleExensions. > WithExtensions_heading_order > > I spent some time investigating the test failures, and it looks > like axe-core is highlighting legitimate product issues. > > Change-Id: I99c1f85087aea873e29b413dca967864fc93c786 > Bug: 984817 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790125 > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Mike Jackson <mjackson@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#695885} TBR=aboxhall@chromium.org,hcarmona@chromium.org,mjackson@microsoft.com Change-Id: Icd7234920d116eb88ccab6eacbb298a0c8eeab2f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 984817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798076Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#695928}
-
Julie Jeongeun Kim authored
This CL converts NetworkContextPtr from chromecast and ios to new Mojo types. NetworkContextOwner from IOS takes mojo::Remote<network::mojom::NetworkContext> instead of NetworkContextPtr. CastNetworkContexts keeps mojo::Remote<network::mojom::NetworkContext> instead of NetworkContextPtr. Bug: 955171 Change-Id: I7d12cbe2ba26529a8b7ed9b685ff309ef1edc28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797950Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#695927}
-
Jeremy Roman authored
This captures all of the dispatching (main) thread objects in a reply callback, reducing the risk of the background thread accessing it in an unsafe way. As it happens this is fine today, mostly because the main thread heap cannot be torn down, but it's actually shorter this way, too.) Change-Id: I33021cf19d82f704c61a8f08bc89d5f7595c2aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799278 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695926}
-
Hiroshige Hayashizaki authored
As preparation for migrating wpt/upgrade-insecure-requests to the /common/security-features generator framework in https://chromium-review.googlesource.com/c/chromium/src/+/1788551, this CL introduces `downgrade` origin type, which is to be used to test upgrading on initial requests. Bug: 1001422 Change-Id: Ia1f2dba1f7d894c0f2b5ba0b24835a9e86287d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787570Reviewed-by:
-
Abhijeet Kandalkar authored
This CL converts |interface PerfettoService| occurrences to uses new Mojo types. Bug: 955171, 978694 Change-Id: I48fe3dfa63192ad01b7ba105dfed06b5b314b09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798225Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
TBR=huangdarwin@chromium.org No-Try: true Bug: 1003224 Change-Id: Ic20a1049c30297fe251e0c1c0323af9c9fb8acc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799648Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695923}
-
Matt Falkenhagen authored
This fixes the tests on Android and enables it in testing, following up on r695883. Bug: 824858 TBR: bcwhite Change-Id: I04ea9c9d44f7b0eea933354c44b7c8116e9f9f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799645 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#695922}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7c47d41067d4..b81d59e59e07 git log 7c47d41067d4..b81d59e59e07 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@b81d59e59e07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: Ia1a54bc5f0996178f466cf8e71b328341d18889c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799274Reviewed-by:
-
Finnur Thorarinsson authored
Bug: 988275, 988276, 860467 Change-Id: I1831c2c8b0be8621f3ff0c97bd3e18ffe402ef2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793164Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#695920}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1fb182f7519..6115c7945f28 Created with: gclient setdep -r src-internal@6115c7945f28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I84607fe4725c2f0801ed4aaab2bf18ec203da095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799842Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695919}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8ac49e182aa0..f421e0e33e66 git log 8ac49e182aa0..f421e0e33e66 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 zmo@chromium.org Make angle_deqp_gles*_tests use discrete GPU for test expectations. 2019-09-11 timvp@google.com Vulkan: Support program interface queries for inputs 2019-09-11 bsalomon@google.com Add final to class TIntermPreprocessorDirective Created with: gclient setdep -r src/third_party/angle@f421e0e33e66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: chromium:1003030 Change-Id: I944863643b47e76a55112dfef34494e9d3033c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799277Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Bug: 987303, 1002164 Change-Id: I5bec8f742e3d5c93dacdea0f3c70b93eba171124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799751 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#695917}
-
v.paturi authored
With the blocks count fixed at 10, the images whose width or height is lesser than 10 cannot be classified as it leads to division with 0 scenarios while extracting the pixels from the bitmap. The blocks count is reduced when necessary depending on the width and height of |src_rect| so that the minimum size of the image doesn't have to be limited. Blocks count is maintained separately for horizontal and vertical directions as opposed to the current |kBlocksCount1D| that is used for both directions. A unit test is added to check the correctness and minor refactoring is done to the test file to avoid code repetition. Bug: 997569 Change-Id: Ib8776a033ca32f4d9b57c80d1bf7e6f0b31ecf5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772925 Commit-Queue: Varun Chowdhary Paturi <v.paturi@samsung.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#695916}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4189eaea..9f468ceb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibefd1ec1464a66b5850097d6f63e446802e92e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799863Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695915}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I549a4045f985954244740bdca92e1617304b5c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799804Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695914}
-
Alexander Dunaev authored
The base Clipboard interface supports different types of clipboards, such as primary selection on X11 or drag on OS X. Ozone didn't support this concept at all, which made it impossible to use more than one clipboard. This CL adds support of multiple clipboards at the Ozone level and implements the selection clipboard for Ozone/X11. R=dcheng@chromium.org, msisov@igalia.com, rjkroege@chromium.org Bug: 973295 Change-Id: I05ed4aa93517d80e1c789a2a09d249a2b923546d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781142Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#695913}
-
chrome://terminalJoel Hockey authored
Bug: 846546 Change-Id: I0d2065953cb2f5fb1ef5ddec86cb1de29ec6a60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799646 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#695912}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I74c4af988999a790524d242c0b134384999ca34a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799273Reviewed-by:
-
Kuo Jen Wei authored
Bug: 1000555 Test: Test entering/leaving view w/o tab navigation and chromevox. The focus is shown/not shown as expected. Change-Id: I672bf245d93b244b52ef7844d65371ac9e008ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797963 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#695910}
-
Justin Cohen authored
Currently SlimNav sets restored URL's to type redirect, since each page is in fact a redirect from the restore_session page. Instead, override this transition and set it to RELOAD. This is necessary, at least, for the request desktop feature (which walks back the redirect transition chain). Bug: 1003024 Change-Id: I743b5beaf1068eb8a80e15c5823a345e981c69ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796264 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#695909}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 43e5419e. With Chromium commits locally applied on WPT: cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I75aeeb1b1a6a5db2107e70ec0939b79749bc13eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799862Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695908}
-
Julie Jeongeun Kim authored
This CL converts ResourceUsageReporterPtr, ResourceUsageReporterRequest to new Mojo types. Bug: 955171 Change-Id: If0c5c388e76a866edd2ed7ef74375cfb700f7a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797949 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
dpapad authored
- Autogenerate Polymer 3 action_link_css style module - Add <a is="action-link"> instance in the demo page This is in preparation of migrating chrome://extensions to Polymer3. Bug: 965770 Change-Id: I32a51118ffd2f0cd9edad8ed3f01723002e1244f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799466 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#695906}
-
Wanming Lin authored
Rewrote /external/wpt/resources/chromium/generic_sensor_mocks.js to align with /http/tests/resources/sensor-helpers.js, but excluded those functions specific for device orientation. Merged tests from /sensor/resources/generic-sensor-tests.js to /external/wpt/generic-sensor/generic-sensor-tests.js Moved common utils into /external/wpt/generic-sensor/resources/generic-sensor-helpers.js Merged tests from /sensor/*.html to corresponding test folders under /external/wpt/, e.g. sensor/orientation-sensor.html -> external/wpt/orientation-sensor/OrientationSensor.https.html Updated all sensor tests under external/wpt/ to adapt to sensor mojom mocks Deleted folder web_tests/sensor/ Bug: 816462 Change-Id: I614ce82b7c90530b7a268d8f6a0f72cc96ea3d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770158 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695905}
-
Rakina Zata Amni authored
We shouldn't do style recalc for things under locked elements, including pseudo elements. Bug: 1000997 Change-Id: Ie183d8ccd67639fe49af8548f720982dc025f284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797947Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#695904}
-
Julie Jeongeun Kim authored
This CL converts WidgetPtr to new Mojo types. It updates CreateNewWidget() and CreateFullscreenWidget() from render_message_filter.mojom and methods and members which implement these interfaces. Bug: 955171 Change-Id: Ibc1a871b182716c216e90d4a9d041917cf35e278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792471 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#695903}
-
Rakina Zata Amni authored
Note there are some changes (contain-size* references) and some weird results in get-bounding-client-rect-block-layout.html Bug: 1000702 Change-Id: I028a00de6c9e6700c1ce1a2e3f05c6037958777b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792221Reviewed-by:
-
Alan Cutter authored
HostedApp* View classes are used by web app (PWA) windows. The name hosted app comes from the Extension app backend used to store them. Web apps are being migrated to their own web_app subsystem while hosted apps are being deprecated (and having their UI implemented on top of web apps instead of the other way around). This CL renames a number of UI classes to fit the current state of the world now that the web_app subsystem is more fleshed out than before when web apps were just bookmark apps (a subtype of hosted app). The following renames are done in this CL: IDs: IDC_HOSTED_APP_MENU_APP_INFO -> IDC_WEB_APP_MENU_APP_INFO IDS_HOSTED_APPMENU_TOOLTIP -> IDS_WEB_APP_MENU_BUTTON_TOOLTIP HOSTED_APP_MENU_BUTTON_SIZE -> WEB_APP_MENU_BUTTON_SIZE HOSTED_APP_PAGE_ACTION_ICON_SIZE -> WEB_APP_PAGE_ACTION_ICON_SIZE VIEW_ID_HOSTED_APP_BUTTON_CONTAINER -> VIEW_ID_WEB_APP_FRAME_TOOLBAR View classes: HostedAppButtonContainer -> WebAppFrameToolbarView HostedAppMenuButton -> WebAppMenuButton HostedAppOriginText -> WebAppOriginText HostedAppToolbarActionsBar -> WebAppToolbarActionsBar Methods: BrowserView::IsBrowserTypeHostedApp -> IsBrowserTypeWebApp BrowserNonClientFrameViewAsh::StartHostedAppAnimation -> StartWebAppAnimation BrowserNonClientFrameViewAsh::SetUpForHostedApp -> SetUpForWebApp Tests: HostedAppNonClientFrameViewAshTest -> WebAppNonClientFrameViewAshTest ImmersiveModeControllerAshHostedAppBrowserTest -> ImmersiveModeControllerAshWebAppBrowserTest HostedAppOpaqueBrowserFrameViewTest -> WebAppOpaqueBrowserFrameViewTest HostedAppAshInteractiveUITest -> WebAppAshInteractiveUITest HostedAppGlassBrowserFrameViewTest -> WebAppGlassBrowserFrameViewTest New directory: chrome/browser/ui/views/web_apps/ TBR=jcivelli@chromium.org Bug: 788051 Change-Id: I1a54693bab779a492ee1ebdc04e7ccba343fe9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792035Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#695901}
-
John Budorick authored
Bug: 1001171 Change-Id: I19912e1cfcb3e4a97dd485f5b751484b4334f690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786867Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#695900}
-
James Cook authored
UX wants the strings to be: "Used by Chrome browser and Chromebook Launcher" (capital L) "Add languages or reorder list. Learn more" (with period) Bug: 997481 Change-Id: I9e43205df301adb202d5eed6886777463fa8f0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799028 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#695899}
-
