- 18 Apr, 2019 40 commits
-
-
Chris Harrelson authored
An earlier refactor (*) accidentally removed the clearing of previous visual overflow before computing a new value. This has the effect of the visual overflow being too large after movement or animation, but also overflow of LayoutRect precision for elements far off-screen. (*) https://chromium-review.googlesource.com/c/chromium/src/+/1366767 Bug: 950963 Change-Id: Idb0609c814d0acf6058383202063ed34a8caf69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572924 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#652300}
-
Hesen Zhang authored
> Created UpdateNotificaionController listening to the UpdateStatusProvider, and will push notification when available. > Implemented Play Store update flow and inline-update flow after receiving the notification. Bug: 952354 Change-Id: I81fa80c7f1cb350fdfb0b33df86c3ef8fd078f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564584Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#652299}
-
Kristi Park authored
Implement toggleMostVisitedOrCustomLinks for the EmbbededSearchApi. This will allow users to toggle between Most Visited tiles and custom links. Bug: 953822 Change-Id: Ide2d1a62456649a5b6f9ff45d16548ac1212e0b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572233Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#652298}
-
Esmael El-Moslimany authored
The preference minimum font size has a default value of 0. The preference is exposed in the UI on the appearance fonts page in settings via a slider. The allowable values for the preference excluded the default value of 0. The settings slider code was changed to ensure the value of the preference was also an allowable value. When the font settings page loaded, the preference was then updated to the closest allowable value. If the preference is set to the default value, the closest allowable value is 6px. This change adds 0 as an allowable value which will allow a user to turn off the effects of a minimum font size. Bug: 944002 Change-Id: Ifc1c72e3673eef60e62f3edecd07ccba6b67928a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573238 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#652297}
-
Henrik Grunell authored
This function is used for controlling audio experiments. The only experiment available to control via this API was the AEC3 (new echo canceller). That has now been fully rolled out, and there are no plans to add other experiments to control this way. Thus removing the function completely. Bug: 696930 Change-Id: I398e783747865b8774637d712f33c4c4c07260ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570827Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Auto-Submit: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#652296}
-
Chris Lu authored
Bug: 919685 Change-Id: I306637940553044ed6fd57b13f00c0d12b6cd0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566612Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#652295}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/060c5300eae0..86dcbc73338c git log 060c5300eae0..86dcbc73338c --date=short --no-merges --format='%ad %ae %s' 2019-04-18 evanhernandez@chromium.org api: Nuke dead controller/protos. Created with: gclient setdep -r src/third_party/chromite@86dcbc73338c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I2d1212844179c8c12ce057ad07096be515e8ca2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574244Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652294}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d754b70592ca..7aad9653f9a3 git log d754b70592ca..7aad9653f9a3 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 zoddicus@users.noreply.github.com Remove legacy utility functions (#2530) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@7aad9653f9a3 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icb91fe0d002e3e2644f6ef6cfb78fff13a611672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574242Reviewed-by:
-
kyle Ju authored
Check in bits of code from the pending two-way sync CL. It allows me to monitor the flakiness of webdriver_test_suit on Linux Tests (dbg)(1) while the other CL is being reviewed. The changes are taken from https://chromium-review.googlesource.com/c/chromium/src/+/1484616/36 Sample JSON output: https://pastebin.com/CfuVTuP8 The is_unexpected fields for all of the three tests are false because their expectations exist in the WebDriverExpectations. Bug: 934919 Change-Id: If068f2318f2f2cbe6b866f96f14cb97f941a4df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574360Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/master@{#652292}
-
Yiming Zhou authored
In https://chromium.googlesource.com/catapult/+/734e7ea0cbf9e0965596350ea51e5b4c8fc623f0, I introduced a change to Web page Replay Go (WPR Go) to prefer previously unmatched responses. This change fixed a number of issues with capturing checkout workflows on captured sites. The change hides the fix behind a feature flag for compatibility reasons. This change enables the fix by turning on the feature flag in Captured Sites tests. Bug: 850756 Change-Id: I0331b3b5cfe8b0ddde84211bd0b320ef65faa8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574358 Auto-Submit: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#652291}
-
Kevin Marshall authored
"bootserver" fails to run because we are passing it an arg that is now deprecated, "--efi". EFI partition management is now managed by default by "bootserver". Bug: 954277 Change-Id: Id71932b9969a71ef27d21362c010c299659dd459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574224Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#652290}
-
rbpotter authored
Increase the width of the Print Preview sidebar by 25px, providing an extra 25px for titles. Bug: 925960, 941369 Change-Id: I59f216523709547312348d33104aa5e467a3f585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574225Reviewed-by:
-
Khushal authored
The android surface used by the display compositor when in VR mode is backed by SurfaceTexture, which is incompatible for use with SurfaceControl. Disable it when in VR mode. Fundamentally, SurfaceControl can only be used when the consumer end of the display's frame updates is SurfaceFlinger. With SurfaceTexture, the consumer end can be any arbitrary process which created the SurfaceTexture. TBR=tsepez@chromium.org R=piman@chromium.org Bug: 953953 Change-Id: Ie132d143aeffcf1bb022f6c691a0738515b19a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573164 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c8ee49fcfce8..fa3c64638fba Created with: gclient setdep -r src-internal@fa3c64638fba The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: I753bf73354a64acd7f4f20ae80831977aaa46ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574039Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652287}
-
Erik Chen authored
Change-Id: Ie4ef73b77d2ffc02c1cd39026dc24ccd940f4a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574220 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#652286}
-
Alexei Filippov authored
Change-Id: I2ffd5db7f3ea2ab30be495e496663b98ffa942fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573007Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#652285}
-
Jacob Dufault authored
Also eliminate AppLaunchSplashScreenView::Delegate Bug: 928555 Change-Id: I056c5fa6efb94bb59c45cbaf8e4344588dd97230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564935Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#652284}
-
Henrique Nakashima authored
These comments that say "BrowserContextKeyed_Base_Factory" are outdated and should refer to "BrowserContextKeyed_Service_Factory" instead. Bug: 937770 Change-Id: Ib851fcf251c064a59bdb79d5cf718712654a602c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574422Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#652283}
-
Mitsuru Oshima authored
* The test should observe the active window (that will be dragged) instead of all. * PresentationTimeRecorder used to discard the presentation feedback that can happen after it is deleted. This CL introduces the internal state that can outlive until the feedback is recorded. * I also removed the max latency as it's very noisy and normal latency should be enough. (SplitView test does the same) Bug: 953355 Change-Id: I3b3e329ca4e866004763f18c55f71816d5a5d535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572268 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652282}
-
Shakti Sahu authored
Bug: 951200 Change-Id: Idad969c53e72fa3bc657883d580f6ed93fc5d484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568041 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
Shakti Sahu authored
This CL tries to update the tab style used in download home to match with rest of chrome. Bug: 951819 Change-Id: Id9eab9209ae12e47fe5d5a4808a0f55c9c9cbaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573094 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
Bruce Dawson authored
Windows 10's implementation of Control Flow Guard costs about 300 ms per process-create call with unit_tests.exe and other huge executables. Since process creation is serialized this adds about 300 s to the test run time of unit_tests.exe (10,000 tests divided by ten tests per process times 0.3 s), which means it takes significantly longer to run than it would otherwise. There have been reports that this causes unit_tests.exe to take 4-5x as long to run as when CFG is disabled. CFG is not needed for these tests, so disabling it is fine. unit_tests.exe, for example, has about 180,000 CFG functions, which is a lot, but it's not clear why it costs so much to set a bit for each function in the ~1.5 MB CFG bitmap. That is a problem for Microsoft to figure out and this is being discussed with them. The underlying issue and this change do not affect chrome.exe. See http://www.alex-ionescu.com/?p=246 for more information on CFG. Bug: 950923 Change-Id: I660ef68ca33141e54cfe895efaa3e7c11bc7118a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570694Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#652279}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ac9b0f378677..7b2943927c04 git log ac9b0f378677..7b2943927c04 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 ellyjones@chromium.org depot_tools: bail out if $PATH contains tildes Created with: gclient setdep -r src/third_party/depot_tools@7b2943927c04 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:952865 TBR=agable@chromium.org Change-Id: I1fb86cbfeef30d43fc4c6104f20c5dba844aaeb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574243Reviewed-by:
-
Ben Pastene authored
These shouldn't be used on the device during tests (only the host). Bug: 866062 Change-Id: I1d8ecf6cc9b416c34cc90bb55377bb8185556fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572266 Auto-Submit: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#652277}
-
Becky Zhou authored
+ Add an incognito badge on location bar on phone + Update incognito location bar background to black Bug: 942776 Change-Id: I13d64ac21a082e77a8df7b640f68f87ff9798072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566754Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#652276}
-
Lily Chen authored
This CL adds a base::Feature that controls the effective SameSite behavior of cookies with SameSite() equal to CookieSameSite::UNSPECIFIED. The effective SameSite behavior is the same as for CookieSameSite::NO_RESTRICTION if the feature is disabled (which is the current default), or the same as for CookieSameSite::LAX_MODE if the feature is enabled (which currently is only in tests). Currently, the only way to get a cookie with SameSite set to UNSPECIFIED is to construct it directly, i.e. parsing a cookie line without SameSite specified still sets SameSite to NO_RESTRICTION under all circumstances. Right now, there should not be any cookies in the CookieStore that have SameSite set to UNSPECIFIED. This will change in the future. The net::CookieInclusionStatus enum (as well as the mojom equivalent) is also extended with some new values, to be used when cookie exclusion results from an unspecified SameSite attribute that is interpreted as Lax, and in two other circumstances which are not yet implemented. Bug: 953306 Change-Id: I1dea6c04e58b52804fe03fabe920331afb30e3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570748 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#652275}
-
Chan authored
TBR=fdoray@chromium.org Bug: 953994 Change-Id: Iec8853179e5d5e3ccd73c2f7a7beaf792f9b4b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574148 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#652274}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/422c94bdab7a..d18c048ab5a6 git log 422c94bdab7a..d18c048ab5a6 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 ynovikov@chromium.org Remove Nexus 5X Vulkan test suppressions. 2019-04-18 spang@chromium.org Vulkan: Implement glTexStorageMem2DEXT Created with: gclient setdep -r src/third_party/angle@d18c048ab5a6 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I007654cab9b59cc5d1b45a262fd5d6638a1129d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574241Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0c133bbe554e..342c6ea1a933 git log 0c133bbe554e..342c6ea1a933 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 enga@chromium.org Fix MultisampledRenderingWithDepthTest Created with: gclient setdep -r src/third_party/dawn@342c6ea1a933 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@chromium.org Change-Id: I28400bfb081eb9a06b825320b71d9358b5266275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574239Reviewed-by:
-
Caitlin Fischer authored
Bug: 953073 Change-Id: Ib0ffe69b177ddbbe2694fe701de791e5779dab60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566596 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#652271}
-
Xianzhu Wang authored
This is a part of geometry cleanup work preparing for fragment-based paint invalidation. Some temporary code was left in implementations of DebugRect() to keep backward compatibility and avoid massive rebaselines of layout tests that outputted layout trees. Now we no longer dump layout for most of the layout tests, so rebaselining them (only for some editing tests) is trivial, making it possible to clean up DebugRect() by removing the temporary code. Bug: 941228 Change-Id: I621638a291b1597cfb53f2fd21b8afedd381101d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572525Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652270}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ac07ed82c3b7..96fbe0810a3f git log ac07ed82c3b7..96fbe0810a3f --date=short --no-merges --format='%ad %ae %s' 2019-04-18 bclayton@google.com Dynamic dispatch for image samplers 2019-04-18 chrisforbes@google.com Factor out GetTexelOffset from EmitImageRead/EmitImageWrite 2019-04-18 chrisforbes@google.com Add support for OpImageRead 2019-04-18 chrisforbes@google.com Add support for OpImageWrite 2019-04-18 chrisforbes@google.com Implement OpImageQuerySize 2019-04-18 chrisforbes@google.com Specialize descriptor contents for storage images Created with: gclient setdep -r src/third_party/swiftshader@96fbe0810a3f The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/130746922,chromium:b/130768731,chromium:b/130768731,chromium:b/130768731,chromium:b/129523279,chromium:b/130768731 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I9d424509162f05c950c0a754fb9629184019fbaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574240Reviewed-by:
-
Azeem Arshad authored
This CL adds an additional check to make sure that the messages setup button is disabled when the feature is prohibited by policy. This fixes crashes when a user tries to click the button in this state. Bug: 953398 Change-Id: Ia27e16ca34ac07e952a9c873d9c3d1f16fac8c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573090 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#652268}
-
Sam Maier authored
Bug: 952640, 954179 Change-Id: I7af49dbf8b75eb97ad14c6d9b1f849ac52cf9f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574278Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#652267}
-
Justin Cohen authored
Offline pages can leave the WKBackForwardList current item as a placeholder with no saved content. In this case, trigger a retry on that navigation with an updated NavigationItem url and NavigationContext error. Bug: 875761 Change-Id: Iff5e2688b76da59755726097ac955efefded39d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573082 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#652266}
-
danakj authored
This will allow us to convert more Callbacks in the bluetooth component over to OnceCallbacks, which will let us convert Callbacks in content eventually. R=reillyg@chromium.org Bug: 953861 Change-Id: Ibdc6523432ff74ff265e3086c4a8580a88b3e52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572999 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#652265}
-
cjamcl@google.com authored
Only relevant when doing multiple runs (-t) of a command. If any fail, there is no need to continue running the command for a revision. Speeds up bisects that have flaky repros. Also, resurrect bisect_test.py. Change-Id: I6b5302dc2408d5779192d1f4808b9d51ddfbc1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540741Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Connor Clark <cjamcl@google.com> Cr-Commit-Position: refs/heads/master@{#652264}
-
Xianzhu Wang authored
It missed a leading space, causing check_network_annotations failure on linux-rel and win7-rel. TBR=rhalavati@chromium.org,nicolaso@chromium.org Bug: 949382 Change-Id: If662c470e97ba8375b276a1bf46f77b065e7a262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574599Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652263}
-
Evan Stade authored
Make label initialization more consistent and less verbose by pulling common init into a local lambda. This should have no behavioral effect except for giving the timestamp labels the same color as the other labels. Bug: none Change-Id: I1fea98a91e979d1dc5ebb6e3a3976e092f7673f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568085Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#652262}
-
Varun Khaneja authored
This change needs to be merged back to M74 too :( For M75, I'll send a follow-upCL that enables this feature behind a Finch flag that's disabled by default. The relevant GmsCore release should be out soon so it should be safe for M75 release. R=drubery Bug: 954255 Change-Id: Iebb0f78aa4fd6e5219ffa3645c98fcf1b5d32244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574143 Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#652261}
-
