- 17 Sep, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4b4c63ad..84da790b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie1500c7ebcd08156b72ec9c8f3318f9779bf02bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806843Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697165}
-
Alex Keng authored
This change enables MockTheme for color picker's pixel verification tests (except for color-picker-appearance.html and color-picker-appearance-disabled.html) so that when we change in-page UI ex border color we don't need to rebaselne hundreds of files (see https://chromium-review.googlesource.com/c/chromium/src/+/1792578/8 for example, where we need to change about 50 pngs for only one platform and there are total 7 platforms we need to consider). Change-Id: Ie452378dcfcd4170f9324e5ab046d5bf89e96d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808166 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#697164}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b19a360c1269..b4e53c4a9938 git log b19a360c1269..b4e53c4a9938 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 tmrts@chromium.org Enable snapshots and update Linux D8 to 7.7.299.11 to speed up TPMv2 Created with: gclient setdep -r src/third_party/catapult@b4e53c4a9938 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:1001953 Change-Id: I72cfe8185cf4304cd68bdab114577fe557c7ad9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808512Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697163}
-
Anastasiia Nikolaienko authored
Bug: 1001384 Change-Id: I403d8215a377b991f65e036dd93585fcf250cf42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803927 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#697162}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b895066e074a..cd3c3cc8eea4 git log b895066e074a..cd3c3cc8eea4 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 treehugger-gerrit@google.com Merge "Revert "[GPU TRACE] Add GPU scheduling trace events"" Created with: gclient setdep -r src/third_party/perfetto@cd3c3cc8eea4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I7dcadf75262ae0977ee686b47af00ba0a4880f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808511Reviewed-by:
-
Fergus Dall authored
BUG=none TEST=none Change-Id: Ic480d31aac9df461a52b63ec53c44d1140f6ceda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808296 Auto-Submit: Fergus Dall <sidereal@google.com> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#697160}
-
Dominic Battre authored
This CL moves the log_buffer.* implementation from browser/ to common/. This allows the LogBuffer to be used for structures that live in common and in the renderer. Bug: 928595 Change-Id: Ib249f88c997a3669008efad1a99240fe6d0d2cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804299Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#697159}
-
Victor-Gabriel Savu authored
Add two UMA histograms to check if and how install_attributes.pb validation fails on devices deployed in the field. More information about the monitored flow and the resulting data: https://docs.google.com/document/d/1vU4Lfy9EcBxb7TqrZ8FuLc_CWxU1AHG3x9yyLusZ3HU CL that added the metrics: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1800664 Bug: 1000305 Change-Id: I5271708bbe89e29888845a7d70fde29ab89b0fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800751 Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#697158}
-
Oleg Davydov authored
File policy_browsertest.cc contains integration tests for many unrelated policies, that makes this test file extremely large. It's better to split it into several parts according to testing section. This commit starts with splitting work by moving extension-related policy tests into separate file. Possible follow-up improvement could be: extract other sections into different files, leaving only generic policy tests in policy_browsertest.cc. Another possible follow-up: refactor PolicyTest base test class, eg., by moving its extension-related methods into new subclass in extension_policy_browsertest.cc. Bug: 1002483 Change-Id: I97f6286fd5ba0ba681fa95fc1f85107da4fe246c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763667 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#697157}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eba8215b6f4c..6e25bd5bbc4f Created with: gclient setdep -r src-internal@6e25bd5bbc4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I903614c81a1537f2bc9b0d9df86bdb955f59cdfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809019Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697156}
-
Gyuyoung Kim authored
This CL applies pending_remote to the first argument of AddCompositionModeWatcher in CompositingModeReport interface. Bug: 955171 Change-Id: I331573a1245d2ea1348aa4109bdfbc23cd402c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804698Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#697155}
-
Alexander Dunaev authored
Implementations of PlatformWindow::SetBounds() in WaylandWindow and X11Window are different: the latter calls delegate's OnBoundsChanged always, while the former returns early if the new bounds were the same as the existing ones. There is a comment in the X11 implementation that says that we need to call delegate always because the call might be a result of the device scale factor being changed. We had a TODO in the Wayland implementation saying that we need to investigate this and maybe call the delegate always as well. The simple experiment has shown that when the device scale factor is changed, the window gets new bounds that are not the same as the existing ones, so the delegate is called anyway. As a conclusion, no change is needed, and the TODO can be removed. R=msisov@igalia.com Bug: 958314 Change-Id: I95fcffb43d09702d3dbcc6c2083d2087e7c166f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807823Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#697154}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/01dfe4048205..41079d70e469 git log 01dfe4048205..41079d70e469 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src fe0b2bd694bb..be467db7bdaa (2 commits) Created with: gclient setdep -r src/third_party/angle@41079d70e469 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:None Change-Id: I722dc5686ac58c7495db8ef065b8a52253214931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808507Reviewed-by:
-
Marina Ciocea authored
Increase opacity to 50% to obtain contrast ratio 3:1; reduce the thickness of the border to make it overlap less with the content of the share tab. Bug: 1000970 Change-Id: Idfaa0ddb3e1bd2e8a783862037b15474fdbe438e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807117Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#697152}
-
Denis Solonkov authored
This change splits the LOAD segments so the [l, r) range is located in its separate segment to make removal of it in the later stages possible. This change also moves the logic of resizing the segments after adding new program header to AddPhdr method. Bug: 998082 Change-Id: Ibec04434caea993ffddb73bcd1771730f2bd1e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795448 Commit-Queue: Denis Solonkov <solonkovda@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697151}
-
Henrique Ferreiro authored
Convert the implementation and all users of the content::mojom::FieldTrialRecorder interface. Bug: 955171 Change-Id: Ic3d08fa61affb7e9c1c1f010ad3c2b6105b27cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796806 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#697150}
-
Maksim Sisov authored
Some platforms that use WmMoveResizeHandler for user-driven move/resize actions require last pointer location in pixels to be sent along with the request (like X11, for example). The WindowEventFilter used to be provided last pointer location in dip instead of in pixels, which caused some weird behaviour when a display, where a window was located on, had different than 1.0f device scale value set. Also, the filter has been renamed to WindowEventFilterLinux. Bug: 1001050, 1000620 Change-Id: I37a5e7229d3a1b7154b449be4f133e97ef222947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787503 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#697149}
-
Fredrik Söderquist authored
This changes the internal representation of SMILTime to use base::TimeDelta. This aligns better with handling of time in general, and should hopefully avoid issues that arise from having a floating point representation. The special values "indefinite" and "unresolved" are stored as TimeDelta::Max() and TimeDelta::Max() - 1us respectively to satisfy the requirements for ordering. Bug: 1003338 Change-Id: I26ef5d14b45f646dcfcfe672736aa7caf343a375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806753 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#697148}
-
Tanisha Mandre authored
- Test that the button directs the user to the 'Add Payment Methods' screen. Bug:1002183 Change-Id: Ibac78b433dba35c9b36fb5b5b96787edbc60d477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798667 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#697147}
-
Takuto Ikuta authored
This reverts commit be56a0b9. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux/24794 Original change's description: > Include *.mojom-forward.h instead of .mojom.h from logging_utils.h > > This CL replaces .mojom.h with .mojom-forward.h to reduce pre-processed > size of logging_utils.h > > This CL has no behavior changes. > > Bug: 1001360 > Change-Id: Idd305572c67e46a5f7a01937ec1d2e31fc62d8ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808619 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#697134} TBR=haraken@chromium.org,tkent@chromium.org,gyuyoung@igalia.com Change-Id: If68d5ebefcf6a923c519ca98685d28b4243fc42a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809197Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#697146}
-
arthursonzogni authored
The NavigationController was not invalidating the URL when a pending entry was removed. To fix this, be more systematic, more stupid. Always invalidate the URL when DiscardNonCommittedEntries() is called. Bug: 998284. Change-Id: I01f1d16bcb25fa827bf68a52db4de531429a8564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781434 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#697145}
-
Lowell Manners authored
This is case is covered on line 218. Bug: 1001528 Change-Id: I558dba59febe82673ec30dad82cc18eb5953d30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803441Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#697144}
-
Dale Curtis authored
4519c32f landed around May when we started seeing flakiness with many Linux audio tests. This splits out the addition such that only the input path should hang if it turns out to be the root cause. BUG=986021 R=ossu Change-Id: I103814bf4c244585fd4678d96ecf6f947727d3de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807558 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697143}
-
chrome://settings/passwordsMarc Treib authored
The settings page still doesn't actually do anything with this information (left for later CLs). Bug: 1002063 Change-Id: Ib29e1d18d3d47e15fd44384fa7ebd40af26947de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798352Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Adam Rice authored
It's possible for a WebSocket handshake to be cancelled while an SSL error callback is pending. Handle this case correctly. BUG=990894 Change-Id: Ibef81a40cdf43f4c042d05c54dd391cd48c9bb32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788770Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#697141}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/146563ad..4b4c63ad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I77aea73d244d310b9931db0270a5d655eacffdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806841Reviewed-by:
-
Yoshifumi Inoue authored
This patch makes |LayoutText::GetTextBoxInfo()| explicitly ignores generated text, e.g. ellipsis, instead of using fragment tree structure with |IsHiddenForPaint()|. Before this patch, text fragment for ellipsis is skipped by using tree structure: 1. fragment for original text marked hidden for paint 2. fragment for trunated text 3. fragment for ellipsis When |GetTextBoxInfo()| vistis fragment#2, it stops processing then it doesn't process a fragment for ellipsis. However, for ellipsis for one character ::after, tree is 1. fragment for ::after 2. fragment for ellipsis Then |GetTextBoxInfo()| handles ellipsis fragment and calls offset mapping with text offset 0 and 1 of ellipsis text in text fragment instead of text content of |NGInlineNodeData|. This causes |GetTextBoxInfo()| processes invalid mapping result then crashes. Bug: 1003413 Change-Id: I210738f609e78854d1d1887e1a5afa93aea40b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808628 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#697139}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c0326d5a977f..b895066e074a git log c0326d5a977f..b895066e074a --date=short --no-merges --format='%ad %ae %s' 2019-09-17 treehugger-gerrit@google.com Merge "Revert "[GPU TRACE] Add UI control to record GPU sched trace events"" Created with: gclient setdep -r src/third_party/perfetto@b895066e074a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I8e3999ba2372835d928290e26de7c22300ec99be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808506Reviewed-by:
-
Lei Zhang authored
- Replace PdfAccessibilityLinkInfo's copy ctor with a move ctor. This implicitly deletes the copy ctor. Without a copy ctor, all the usage of the struct have to use move semantics correctly and cannot copy anymore. - Mark the PdfAccessibilityLinkInfo ctor that takes a single PP_PrivateAccessibilityLinkInfo as explicit. - Change the PP_PrivateAccessibilityLinkInfo ctor to use an initializer list. - Reorder the ctors so the move ctor and dtor are at the end. Make pdf_accessibility_shared.cc match the header. Then do the same set of changes for PdfAccessibilityImageInfo. Bug: 981448 Change-Id: Ie3daca03b4226748daed7d39c31444da2a9de47c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794248 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#697137}
-
Roman Sorokin authored
* Remove "Caps Lock is on" message * Alter keyboard layout message Bug: 551167 Change-Id: Ie258138e74abccd45183b807ea57c8937e721518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808385 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#697136}
-
Christopher Gunadi authored
Dialogs that are non-modal should preferably inherit BubbleDialogDelegateView. Bug: 1004271 Test: browser_tests --gtest_filter="*Crostini*ViewBrowserTest*" Change-Id: I2abef29396e9d202bad28a0406b0f2c5e8e2fd02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806678Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Christopher Gunadi <chrisgunadi@google.com> Cr-Commit-Position: refs/heads/master@{#697135}
-
Gyuyoung Kim authored
This CL replaces .mojom.h with .mojom-forward.h to reduce pre-processed size of logging_utils.h This CL has no behavior changes. Bug: 1001360 Change-Id: Idd305572c67e46a5f7a01937ec1d2e31fc62d8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808619Reviewed-by:
-
arthursonzogni authored
There was a bug in RenderFrameHost::DeleteRenderFrameHost(). Bug: 992894 Change-Id: I0fb3171814113a57ac2267a4442cf252d47d4de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807234Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#697133}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the media.mojom.AudioOutputStream interface, and adapt unit tests. Bug: 955171 Change-Id: I2a5fb08b9ff0b156385551d9a936e68834215276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803146 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#697132}
-
Michael Liao (WPT) authored
Example of submenu: https://imgur.com/fBFrvao According to W3C, elements should be marked as 'aria-haspopup = true' if: - it indicates the availability and type of interactive popup element - the popup element appears as a block of content that is on top of other content Context menu submenu items meet the criteria since the arrow indicates another context menu, and the submenu context menu is the popup element. Here is a W3C example of a similar construct that they mark as 'aria-haspopup = true': https://www.w3.org/TR/wai-aria-practices/examples/menubar/menubar-1/menubar-1.html Bug: 963183 Change-Id: I7cf82fb266847698555c7a81ecbd7f5b3827f26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725163 Commit-Queue: Michael Liao <michael.liao@microsoft.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#697131}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the content.mojom.RendererAudioOutputStreamFactory interface, and adapt unit tests. Bug: 955171 Change-Id: I1732245f699c7c05e1d771d1210fed60076322fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801151Reviewed-by:
-
Jérôme Lebel authored
The Sign-in interaction coordinator needs to cancel when -[MainController stopChromeMain] is called. Bug: 1002834 Change-Id: Ideb74b457c983203508757863da6a7ce9afad075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807213Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#697129}
-
Mikel Astiz authored
This reverts commit 1dc90fac. Reason for revert: suspect for causing flakes in DomDistillerViewerSourceBrowserTest.PrefPersist BUG=1004663 Original change's description: > Populate the distilled content slightly earlier > > Before this CL, the distilled content is injected on DidFinishLoad(), > or when the distillation finishes if it's later than DidFinishLoad(). > When the DidFinishLoad() event propagates to TalkBack, the distilled > content is usually not there yet, so TalkBack would announce the > content of the place-holding page. > > This CL populates the distilled content in DocumentLoadedInFrame() > instead of DidFinishLoad(). DocumentLoadedInFrame() is late enough to > execute JavaScript, and is early enough so that it's more likely that > the title and content can be picked up by TalkBack instead of the > placeholder. > > If distillation is finished by DocumentLoadedInFrame(), onload() event > would also be delayed, so that the accessibility focus is more likely > to be on the web content. Otherwise, the focus is usually on the close > button of the CustomTab (CCT), or nowhere. > > Note that this CL doesn't guarantee the distilled title is announced > by TalkBack. If distillation finishes later than > DocumentLoadedInFrame(), or if for some reason the accessibility focus > is on the close button of the CCT, the title would go unannounced like > before. > > Bug: 811417, 803474 > Change-Id: Iaf2ff988b427ca9af582622597b505e7a8aca8e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791048 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697074} TBR=dmazzoni@chromium.org,mdjones@chromium.org,wychen@chromium.org Change-Id: I6af4de1fa2a872402f9abe13321f5d1af8e09d75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 811417, 803474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807495Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697128}
-
Wei Wang authored
This patch makes StartServiceWorker and StopServiceWorker the helper test utils which can be used by all tests. In this patch, we have already used the StartServiceWorker and StopServiceWorker in ServiceWorkerVersionTest, ServiceWorkerJobTest and ServiceWorkerRegistrationTest. In the next step, other tests will be changed as well. Bug: 931095 Change-Id: I91d70239b6d76498d01c2adba684fde3e7bff121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788251 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697127}
-
Miyoung Shin authored
This CL converts HidConnectionClientRequest in services and content to the new Mojo type. Bug: 955171 Change-Id: I993ee59359700e0cd87db38d777db3df1a288a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804708Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#697126}
-
