- 16 Apr, 2020 40 commits
-
-
Xiaocheng Hu authored
FontDescription has a mutable bit field subpixel_ascent_descent_ that can be modified via a const method. This patch removes the mutable keyword and changes the callers so that FontDescription no longer has mutable fields, and the code maintainability is improved. Change-Id: I53fab83b3a8c00e2827aa19b0ba640bb59765fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145072Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#759798}
-
Nathan Zabriskie authored
Clusterfuzz picked up a potential error if we can't retrieve shared memory when deserializing an SkColorSpace. Bug: 1071441 Change-Id: I9cefd0cf3cee92c2ad2556e914522203f88e282f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153344Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759797}
-
Xiaoqian Dai authored
Bug: 1071598 Change-Id: I950ebd930cc06de05c65426bfa14081dc1c58dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153689Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#759796}
-
Devlin Cronin authored
Extend the expiry date of still-useful metrics. Extended to 2021-04-01: - ExtensionOverrideBubble.SettingsApiUserSelectionHomePage - ExtensionOverrideBubble.SettingsApiUserSelectionSearchEngine - ExtensionOverrideBubble.SettingsApiUserSelectionStartupPage - ExtensionOverrideBubble.NtpOverriddenUserSelection - ExtensionBubble.DevModeUserSelection - ExtensionBubble.ExtensionsInDevModeCount Extended to 2020-12-01: - ExtensionToolbarModel.BrowserActionsVisible - ExtensionToolbarModel.BrowserActionsCount Bug: 1052982, 1052981, 1016423 Change-Id: Ie4b126f4a83571745c73e058cb17cd17f4e2ead1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148115Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759795}
-
Darwin Huang authored
Return early if utf_text.data() == nullptr. utf_text.data() can be nullptr if the Clipboard was empty. Previously, this would trigger a DCHECK in Blob::Create(). Tested manually using `pbcopy < /dev/null`, as per bug repro steps. Unfortunately, Chrome's test infra doesn't seem to have a way to simulate clearing the clipboard. Therefore, there isn't an automated test being added here to verify this behavior. Bug: 1071279 Change-Id: I95cdc6ed2df25394ca1ffa78d4cde96782d9a10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151132 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#759794}
-
Toni Barzic authored
The containers are currently ranked with 0, which seems to be a valid result rank. We should ensure that containers with results are always ranked before empty containers (code to manage search result selection depends on this assumption). Change-Id: Ie72ef9f93e2216a6a910c47f53028572d21cc465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106509 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#759793}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/efdff53176d6..6415dcad7a71 git log efdff53176d6..6415dcad7a71 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 mbonadei@webrtc.org Remove WebRTC-ExperimentalScreenshareSettings. 2020-04-16 danilchap@webrtc.org Delete generic frame descriptor v1 trait and enum value Created with: gclient setdep -r src/third_party/webrtc@6415dcad7a71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibc5956b6a9f20e0815ecc4ad57caa334d61bd305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153631Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759792}
-
Jon Mann authored
When configuring a local network from a synced proto, this change implements the required logic for applying manual proxy settings. Bug: 966270 Change-Id: I43bc884d9c7b64cc44266cc7587caf5682c0abcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151837 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#759791}
-
Sammie Quon authored
On reconnection, windows are moved to another display via a call to Window::SetBoundsInScreen, which will add to the correct container on the other display. Windows are currently added (if meets conditions) in the order of the MRU, which means they are added to the new container in that order. Stacking order of a window's children is in order of the indexes, so visually the windows are the opposite of the MRU order. Adding the windows in the reversed order would solve this. On disconnection, windows are squashed onto the primary display and stacked according to the MRU list. The formula is: Find window in MRU list, and after that, the next window with the same parent will be the window stacking on top target. If none is found, stack window at bottom. Attached a video for more context in the bug. Test: manual, PersistentWindowControllerTest.MRUOrderMatchesStacking Bug: 1071246 Change-Id: I10a145081603a505491b4885fd2091aa4ea1c55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151180Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#759790}
-
Dominic Mazzoni authored
In http://crrev.com/c/2017662, I attempted to fix an issue with the Android implicit root scrollers, but that patch ended up breaking pinch-zoom. To fix it properly, we need to keep track of which node is the root scroller - which may not be the root element. Then, on Android only, we ignore the scroll offsets from that node (actually we unapply them) and instead apply the scaling and offset from RenderCoordinates. Bug: 1066809, 1005121 Change-Id: I0d717a563a6b5d480b68c35916243e848fe53bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142101 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#759789}
-
Xinghui Lu authored
This feature is not launched. Remove the feature flag and other unused code. Add a default implementation in the SafeBrowsingApiHandler interface. The interface will be removed eventually, once the internal repository code is removed. The field in the csd proto will be deprecated in a future CL together with the same field on the server-side. Bug: 1070836 Change-Id: Ia18aff08c008006898ae7886b5a07203d6f9b7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150067Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#759788}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d8b32f96. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools panicker@chromium.org: external/wpt/longtask-timing panicker@chromium.org, tdresser@chromium.org: external/wpt/paint-timing NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I61ef1820f9f50b1d702ee3a53072223be094e94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153267Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759787}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/77750704ab85..c4fb400988c9 git log 77750704ab85..c4fb400988c9 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 tross@microsoft.com Add keyboard accessibility to Issues panel Created with: gclient setdep -r src/third_party/devtools-frontend/src@c4fb400988c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1067773 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5310c84bd45c19ebdcc635c530ab2e21bdc44d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153471Reviewed-by:
-
Ryan Daum authored
Have the ui_devtools server launch for all devices that are BUILD_ENG or is_debug=true. Bug: internal b/148931987 Test: manual Change-Id: I55b58c51e0a4a080aae269e7d985975b3ae75e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144616Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#759785}
-
aknobloch authored
Adds a new member variable to the `CastMetricsServiceClient`, rather than reinitializing the `CastSysInfo` object each time the `GetChannel()` method is called. Bug: 145136478 Change-Id: I04cdc10ecbb7ff6761a24cedd4ab88e8098913c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123508Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Aaron Knobloch <aknobloch@google.com> Cr-Commit-Position: refs/heads/master@{#759784}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/671aece845dd..2dd3f0f2c0f7 git log 671aece845dd..2dd3f0f2c0f7 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 thestig@chromium.org Add unit tests for comparison operators in CPDF_PSEngine. 2020-04-16 tdusnoki@inf.u-szeged.hu Remove CPDF_PSEngine.Truncate test case 2020-04-16 shwali@microsoft.com Add API for removing an inklist for an ink annotation. 2020-04-15 nigi@chromium.org [SkiaPaths] Embolden SkFont if substitute font is bold or extra-bold. 2020-04-15 asweintraub@google.com Add explicit casts in pdfium_test_event_helper.cc 2020-04-14 nigi@chromium.org Update the expected results in FPDF_RenderPageBitmapWithMatrix for Skia. 2020-04-14 nigi@chromium.org Update the expected results of FPDFTransformEmbedderTest for Skia. Created with: gclient setdep -r src/third_party/pdfium@2dd3f0f2c0f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: If7fe5cf796a2a80a47c00fe9b13c3e74fde5791f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153480Reviewed-by:
-
David Van Cleve authored
The prototype Trust Token API (https://github.com/wicg/trust-token-api) provides new JS functionality with which one can specify certain cryptographic operations to execute along outgoing requests. Executing some of these operations requires that the client possess trust token issuers' "key commitments," which are collections of public keys and associated metadata. For the initial prototype implementation, which will be available to participants in an origin trial, we're shipping these key commitments out of band through the component updater. This CL implements the client side of this key shipping, namely a component installer that will: - register itself whenever base::features::kTrustTokens is on; - expect an unversioned JSON-encoded collection of commitments from the update server; and - pass this collection of commitments to the network service via NetworkService::SetTrustTokenKeyCommitments, whence network-service side code will parse the collection and store the keys in memory. R=waffles registration when the feature is off; correctly pass obtained keys to a callback). We'll also add a manual test plan once the server-side configuration lands. Test: A couple unit tests verify some aspects of the functionality (no Bug: 1068651, b/152525332 Change-Id: I58c760fe3d5219a61a805923d63fe1d5714450a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144831 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#759782}
-
Tina Wang authored
A small fix cleaning up the password related imports and deps since we automate policy unittests and no longer need them for policy_unittest.mm. Change-Id: Ic6a57e571a121c486b1edddc7b6d73c8713ff469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152906Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759781}
-
Aran Gilman authored
Bug: 1069635 Change-Id: I53b8bad02b26ed86d7941e8c0229d932d539cfd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144620Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#759780}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2d65b73337ee..efebaa2a1152 git log 2d65b73337ee..efebaa2a1152 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 westont@google.com Run docker as current user and add option to copy directory structure to docker.run. 2020-04-16 egdaniel@google.com Remove use of GrVkCaps from SkSLProgram settings. 2020-04-16 bsalomon@google.com Remove redundant before/after child proc mangling calls. 2020-04-16 michaelludwig@google.com Add GM for blur + repeat bugs 2020-04-16 robertphillips@google.com Make all SkImages mipmapped w/in the DDL testing harness 2020-04-16 bsalomon@google.com GrLightingEffect uses GrTextureEffect Created with: gclient setdep -r src/third_party/skia@efebaa2a1152 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1056730 Tbr: kjlubick@google.com Change-Id: I2336bbe8424543b9b25c9c7d7d9c775fbfde02f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152869Reviewed-by:
-
Julie Jeongeun Kim authored
Migrate this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames to inline-flex-frameset-main-axis-crash.html. Bug: 1063749 Change-Id: I03ee1f9bc35abac50b9b08247def9e9a704fd008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152062 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759778}
-
Etienne Pierre-doray authored
This is a reland of 38e3a62a Reason for revert: Official build failure crbug/1071307 Fix: Compile NativeUnwinderAndroid + tests only on arm/arm64 Original change's description: > [Clank SSM]: Implement NativeUnwinderAndroid. > > This CL implements NativeUnwinderAndroid & tests for android > unwinding support. It also enables StackSamplingProfilerTest > on Android. > > A new target source_set is added, native_unwinder_android > that contains NativeUnwinderAndroid. > StackSamplingProfilerTest depends on it for android. > > Bug: 989102 > Change-Id: Ie38fd99ca5fb053e1881d0977924b70a6fbc1e9b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055743 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759283} Bug: 989102, 1071307 Change-Id: I03345dc46b205f3c1b211ffa9aeb6d51fdacaacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151727 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#759777}
-
Jesse McKenna authored
This change adds a field-trial testing config for the experiment SlowDCTimerInterruptsWin so that it can be enabled on 50% of the Beta channel. Background on the SlowDCTimerInterruptsWin experiment: Windows implements timers (e.g., sleep(50), wait(100)) by polling at some frequency for any waiting timers that may have finished. This is called the 'timer-interrupt frequency', and effectively limits the actual granularity of timers. Chrome frequently raises Windows' global timer-interrupt frequency to make timers more responsive. However, raising the timer-interrupt frequency increases system power consumption, so should be done sparingly. Chrome currently sets the following timer-interrupt frequency limits: Default, not raised: 64 Hz Raised, on wall power: 1000 Hz (MinTimerIntervalHighResMs = 1) Raised, on battery power: 250 Hz (MinTimerIntervalLowResMs = 4) This experiment halves the raised frequency on battery power: Raised, on battery power: 125 Hz (MinTimerIntervalLowResMs = 8) This level has been reported to result in a ~4% power savings and minimal negative impact on performance (per crbug.com/927165). Bug: 927165 Change-Id: I1db7cbacac2697f382d815dc2a48ece905d58871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145761Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#759776}
-
Daniel McArdle authored
Bug: 1071327 Change-Id: Icf4189905dc5c95854b5af4b3e5e25e0607dd39e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153325Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#759775}
-
Caroline Rising authored
Mac offers overlay scrollbars that become transparent when not in use. When transparent, the scrollbar still exists and takes click and hover events. This causes a visual bug for the ExtensionsToolbarMeunuView where a button sits partially under the overlay scrollbar. This change updates the scrollbar ability to process events with the subtree when the scrollbar is transparent. Bug: 1016578 Change-Id: I64c363943167a31f39308eacf7863977ab47d2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134648 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#759774}
-
Rafael Cintron authored
Freeing DComp resources such as visuals and surfaces causes the device to become 'dirty'. We must commit the changes to the device in order for the objects to actually be destroyed. Leaving the device in the dirty state for long periods of time means that if DWM.exe crashes, the Chromium window will become black until the next Commit. Bug: 1071288,1011655 Change-Id: I7d118e5bc5f1e4fc6959661b1902939ba7dc83f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152784Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759773}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cca5c49d45e0..b8265f103a9a git log cca5c49d45e0..b8265f103a9a --date=short --first-parent --format='%ad %ae %s' 2020-04-16 demorri@microsoft.com Add cpplint support for space before [[attributes]] Created with: gclient setdep -r src/third_party/depot_tools@b8265f103a9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I65a1c195b7385832e01c8d8c974cf0f3b30c6349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153476Reviewed-by:
-
Xiaoqian Dai authored
Bug: 1031766 Change-Id: Ie810de835b2abccaff53bed44ea007836e7fb667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151245Reviewed-by:
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/897e7631c5c8..9b3cba4056fc $ git log 897e7631c..9b3cba405 --date=short --no-merges --format='%ad %ae %s' 2020-04-16 nharper Check for nullptr before calling OnProofVerifyDetailsAvailable 2020-04-16 quiche-dev Fix implicit includes through string_piece.h 2020-04-15 nharper gfe-relnote: Refactor TLS QUIC tests. Test-only change. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I125192a3b820816c94e7b63599347e5f5de6ce72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153332Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759770}
-
David Schinazi authored
It looks like the older MOCK_METHODxx (where xx is the number of arguments) are being deprecated upstream. This CL exists to confirm that they now work well in Chromium (they didn't 6 months ago). Once this lands I'll make changes to allow using them in QUICHE. Change-Id: Ia39c234951679e865acc13bcb66d920052ba522d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152991 Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759769}
-
Bo Liu authored
Read default encoding from components_locale_settings, same as chrome. Bug: 1052496 Change-Id: I24e0205ab94e71a3412783d322563ababd64e42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147684 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#759768}
-
Kurt Horimoto authored
This is an AlertOverlayCoordinator subclass that aggregates all the mediator types used for the supported OverlayRequests for alerts shown in OverlayModality::kWebContentArea, allowing for the removal of the boilerplate coordinator code for these overlays. After this CL, new alerts shown over the web content area simply need a new mediator that is added to the coordinator's |supportedMediatorClasses| array. This CL also creates a new util function to instantiate an appropriate mediator for other OverlayRequestCoordinators that support multiple mediator types. InfobarBannerOverlayCoordinator was updated to use this function as well, since it also supports multiple banner mediator classes. Bug: none Change-Id: I360b0f94bb2eb76709074f826854a262fc82ce80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149687 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#759767}
-
Evan Stade authored
This struct should more or less mirror LoadURLParams, or at least as much of that struct as necessary. For now it only contains mShouldReplaceCurrentEntry. This makes replace() obsolete. Since this is designed to be merged back to 83, replace() was added in 82, and 82 did not make it to stable, replace() can be removed without the normal deprecation process. Bug: 1070851 Change-Id: I0845bab184a182e9a616b01b6115615275422fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150968Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#759766}
-
Elly Fong-Jones authored
This change removes the overrides of Accept and Cancel on this dialog. Cancel is straightforward; for Accept, a semantic change to the dialog is needed. Right now, this dialog stays open after Accept() is pressed, and normally gets closed as part of the browser teardown process when relaunch succeeds. This change has the dialog close on Accept(), as is best practice. The dialog currently says it stays open so that the user can retry the relaunch operation. That doesn't seem like a good idea - most dialogs don't behave that way. Bug: 1011446 Change-Id: I0725a3d357f7a71a8e27a569acd0cf1cc165ed38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153340 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#759765}
-
Tim Volodine authored
Add a kTypeForTesting to the safe_browsing_blocking_page and a check in the browser test to make sure the correct insterstitial is shown. Also remove unnecessary logging in the test. BUG=1015418,1034546,1071519 TEST=run_weblayer_browsertests --gtest_filter=SafeBrowsingBrowserTest* Change-Id: Ia184557ab08f811dcd0903ba06b185b3d6c2d896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142273 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#759764}
-
Robert Liao authored
Change-Id: Ib66426dadaaa68800c818d00457ebafe73d0e4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153572 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
SiteSettingsHelper is implemented in //chrome. This removes the dependency of PageInfoController on this class so it can be componentized. Bug: 1052375 Change-Id: I0a80f93d0314a2202e4f3c77a55731759516caf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152368 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#759762}
-
Ian Prest authored
Skia takes a precision value when generating strokes as an optimization. When rendering, we pass a value derived from the scale-factor in the CTM, but when hit-testing we were passing a hard-coded value. This worked reasonably well for solid strokes at moderate scales. However, at sufficiently high scales and especially for dashed strokes, the stroke generated for hit-testing was noticeably different from the rendered stroke. This change passes the CTM through to the hit-testing code, so that we can use the same high precision for hit testing as rendering. Bug: 964614 Change-Id: I8dfcb3ade86b9e7b63c7415baab5814ac2286ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112955Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759761}
-
Koji Ishii authored
This patch sipmlifies |IsFirstForNode| for |NGInlineItemResult| by using all information in it. This was originally addded in r754815 <crrev.com/c/2111158>. Bug: 1043787 Change-Id: I3acccd6fd7f53f7eeff955025397216680565850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152336 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#759760}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dff792591fb9..efdff53176d6 git log dff792591fb9..efdff53176d6 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 terelius@webrtc.org Limit BWE drops from probes to 85% of the throughput estimate. 2020-04-16 sprang@webrtc.org Limits size of payload padding packets to 2x target size. 2020-04-16 hta@webrtc.org Remove deprecated ssl_identity methods 2020-04-16 srte@webrtc.org Cleanup: Removes unused BBR congestion controller. 2020-04-16 eshr@google.com Unify AdaptationReason and AdaptReason enums. Created with: gclient setdep -r src/third_party/webrtc@efdff53176d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I245585f978fde779110c27f1a69d100c251c073b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152883Reviewed-by:
-
