- 20 Nov, 2017 40 commits
-
-
Sylvain Defresne authored
Convert TestRedirectObserver to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Also remove TestRedirectObserverUserDataWrapper by using WebStateUserData. Bug: 775684 Change-Id: I85e965e8c99dd5dd848082c305619aaff5b6a5ca Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/771690 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#517815}
-
Kush Sinha authored
Change-Id: Ibd3291ac69042141ad9809021abcb6d7a18b27cf Reviewed-on: https://chromium-review.googlesource.com/779186Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#517814}
-
Sergei Datsenko authored
Clean up render tests structure and require virtual time exhaustion as an indication of rendering completion. Change-Id: I62a7ed9389facaab223ab3ddebb80496ece5c203 Reviewed-on: https://chromium-review.googlesource.com/776517Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#517813}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f4f2b219..b0cb35c7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I36f4ac2649017d565dacb62b3b4b3afa5cf6cfd5 Reviewed-on: https://chromium-review.googlesource.com/778780Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#517812}
-
Sylvain Defresne authored
Convert BrowserListSessionServiceWebStateListObserver to observe the active WebState directly and remove dependency on deprecated methods of WebStateObserver. Bug: 775684 Change-Id: I5c6a4478515c657d077180b6de263ac531930d4d Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/771671 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Mounir Lamouri authored
Bug: 690364 Change-Id: I218ca3455dc9c838f798e96e89fdb5c3899e918e Reviewed-on: https://chromium-review.googlesource.com/768669 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#517810}
-
Egor Pasko authored
This is to later use clear_system_cache as a standalone tool for startup benchmarking on Android. Bug: 760498 Change-Id: Ifd15e65158742d0876a2209b87e4d30e485f84f6 Reviewed-on: https://chromium-review.googlesource.com/776883Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#517809}
-
Sylvain Defresne authored
Convert FaviconCallbackTest to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: Icafd83b54dfb598ec6cbe22ddb2f0c35d926b945 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768692 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Olga Sharonova authored
Introducing type-parametrized tests verifying that a given AudioSystem implementation is correct. This will allow to re-use tests for AudioSystem implementation on top of Mojo Audio service. Bug: 740943 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If69ee76bce05f0dcfab6abeb31af95959149ca9d Reviewed-on: https://chromium-review.googlesource.com/707142 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517807}
-
Gauthier Ambard authored
ContentSuggestions is enabled to 100%, those methods can be removed as they were only used in the old NTP. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7606b7635862168e9e019ad8bb8175b9d11484b1 Reviewed-on: https://chromium-review.googlesource.com/778860Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#517806}
-
Tommi authored
This is to be used only on bots where there's a conflict with necessary (for purposes of testing) 3rd party drivers/components that employ patching as part of their function. Currently WebRTC's "Win Builder" will need to set this flag. BUG=737090 Change-Id: If483b06aa9f0f8a797e41f429cc363979a5c01f3 Reviewed-on: https://chromium-review.googlesource.com/753591 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#517805}
-
cm.sanchi authored
From discussion on chromium-dev, it was decided to remove 'chrome' namespace. Bug: 289619 Change-Id: I4b06495e341b6f75cce89d06f92a18fc4826cac1 Reviewed-on: https://chromium-review.googlesource.com/766088Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Anthony Berent <aberent@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#517804}
-
Tim Volodine authored
Web Share API is currently not supported by Android WebView and hence should not be exposed. This patch makes sure this is the case, and will be verified automatically by the Android WebView bots on the waterfall. BUG=765923 NOTRY=true Change-Id: I1c8d2f078c6b8ebe136c64cd0763645008e44b4e Reviewed-on: https://chromium-review.googlesource.com/776716Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#517803}
-
Philip Jägenstedt authored
See https://github.com/w3c/web-platform-tests/issues/7503 The incorrect css/README.md was updated here: https://github.com/w3c/web-platform-tests/pull/8306 Bug: 766650 Change-Id: I28c3a0d683b18ec59cfa8d2f65f71296eb521b13 Reviewed-on: https://chromium-review.googlesource.com/778884Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#517802}
-
Louis Romero authored
Bug: 719940 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3f4ca925dd4e4378e5f7ae8fcb5276660a9cb5fc Reviewed-on: https://chromium-review.googlesource.com/776816 Commit-Queue: Louis Romero <lpromero@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517801}
-
Martin Sramek authored
The counters in Clear Browsing Data dialog have been part of the stable UI on Desktop and Android for a long time. The flag is now obsolete. Bug: 785186 Change-Id: I2524fabcc7fd7fd795d3381678e5e90aa0966511 Reviewed-on: https://chromium-review.googlesource.com/776697 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#517800}
-
Daniel Bratell authored
The X11 header wrapper prevents us from polluting the global namespace with risky macros such as None, True, False, Status. This is in particular necessary for jumbo builds since they are more vulnerable to headers doing unexpected things. Bug: 782184 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icd39a959c24a6b8f5a74e044e3fd1e6b959c6280 Reviewed-on: https://chromium-review.googlesource.com/771195Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#517799}
-
Jose Dapena Paz authored
Provide implementation of AtkComponent grab_focus method, that will send a focus AXAction through the AXNodePlatformDelegate. Bug: 784583 Change-Id: I1874240801d117fc299cd520ecdf2824a5165e24 Reviewed-on: https://chromium-review.googlesource.com/767429 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#517798}
-
Yoshifumi Inoue authored
This patch Introduces |NGPhysicalOffset::ToLayoutPoint()| to simplify pattern, |LayoutPoint(offset.left, offset.top)| to |offset.ToLayoutPoint()| for ease of writing LayoutNG adopting code in existing functions. This patch is a preparation of http://crrev.com/c/763188 Change-Id: I2311d98a66192e9e4f13c74ad75eb63b02d2b2e5 Reviewed-on: https://chromium-review.googlesource.com/776514Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517797}
-
Sylvain Defresne authored
Convert WebIntTest to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Also convert IntTestWebStateObserver from a member variable to a local variable since its lifetime is bound to the method call. Bug: 775684 Change-Id: I098d007c8ad3a4b211c9683aa63e90e343b5f53c Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/769011 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Jochen Eisinger authored
BUG=753691 R=mkwst@chromium.org Change-Id: I35261847b2cfa42f5bec2c05960bf331479c8945 Reviewed-on: https://chromium-review.googlesource.com/778322Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#517795}
-
Takashi Toyoshima authored
URLLoaderStatus is used in URLLoaderClient::OnComplete to notify the loader's completion status. In comparison with other types used in other callback arguments in URLLoaderClient, the name "URLLoaderStatus" is too generic, and does not explain what it actually represents. This patch renames it to URLLoaderCompletionStatus. Since the native struct was named as ResourceRequestCompletionStatus, it should sound reasonable. Bug: 736308 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic6aea2a31fab18f102d2f7f56183eaa016e07583 Reviewed-on: https://chromium-review.googlesource.com/776016 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#517794}
-
Sylvain Defresne authored
Convert WebViewTranslateClient to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Change-Id: Ifdf8f2ba5e113f67269d4329500d1693e772eeae Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768877 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
jdoerrie authored
This change removes the deprecated SetDictionaryWithoutPathExpansion in the //chromeos directory and replaces it with the new base::Value API. Bug: 646113 Change-Id: Ia3be13e49959224db93a1dd67408590af780a98e Reviewed-on: https://chromium-review.googlesource.com/776656 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#517792}
-
Sylvain Defresne authored
Convert SadTabTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Pass the WebState to SadTabTabHelperTestDelegate to fix the unit test (as WebStateObserver method web_state always return nullptr). Bug: 775684 Change-Id: I7908650e3612645eddf03eb7ea01f88dfba4d395 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/768724 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 790d985e. With Chromium commits locally applied on WPT: 23705631 "service worker: Upstream sandboxed iframe test to WPT." Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/5666 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=lukebjerring No-Export: true Change-Id: I85165dbd213aef03b0bd9f2fea81b60d564d6b62 Reviewed-on: https://chromium-review.googlesource.com/778779 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517790}
-
Shanmuga Pandi M authored
This patch measures how often getter returns anything other than non null. Bug: 695891 Change-Id: I62ea96d6ccf9c0dea0804dcab221e71b55ffca37 Reviewed-on: https://chromium-review.googlesource.com/773520 Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Reviewed-by:
-
Khushal authored
Add an option to override flags during serialization and use it do alpha folding for SaveLayer/Draw/Restore during serialization. The overridden flags will also be used to replace images in shaders. R=enne@chromium.org Bug: 758350 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iff0a9fd81bd9dee9b932dc95e194208e34dc4069 Reviewed-on: https://chromium-review.googlesource.com/777844 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517788}
-
jdoerrie authored
This change removes the deprecated SetDictionaryWithoutPathExpansion in the //chrome directory and replaces it with the new base::Value API. Bug: 646113 Change-Id: Ia951cab83174b7816f99500b50f03ad0980dbfd7 Reviewed-on: https://chromium-review.googlesource.com/775340 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#517787}
-
Jose Dapena Paz authored
Provide the hit test wrapper for AtkComponent interface, using an implementation that is compatible with the one in BrowserAccessibleAuraLinux. Bug: 784583 Change-Id: Ie1dcae846db9aabf06e636eaf3054c87d2e8bcc9 Reviewed-on: https://chromium-review.googlesource.com/767428 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
-
Yoichi Osato authored
This patch excludes editing adjustment part from ComputeVisibleSelection() to a function which returns SelectionTemplate<Strategy> for code health. We will have ComputeVisibleSelection(passed_selection) { const SelectionTemplate<Strategy>& xxx_adjusted_selection = AdjustSelectionXXX(passed_selection); const SelectionTemplate<Strategy>& yyy_adjusted_selection = AdjustSelectionYYY(xxx_selection); const SelectionTemplate<Strategy>& zzz_adjusted_selection = AdjustSelectionZZZ(yyy_selection); return zzz_adjusted_selection. } Bug: 775701 Change-Id: I0cb1e34156f3792a1ca67443370f862c2cf268ba Reviewed-on: https://chromium-review.googlesource.com/749567Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#517785}
-
Takeshi Yoshino authored
Updated the test file for Android WebView and ManualTests/ to address http://crbug.com/756965. This is a reland of 33c9d62c Original change's description: > Remove layoutTestController, an alias to testRunner > > Bug: > Change-Id: I5a3cc233bfc3daa96f8fa5258dc2cba0d1740fa1 > Reviewed-on: https://chromium-review.googlesource.com/618432 > Reviewed-by: Mike West <mkwst@chromium.org> > Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#495525} Change-Id: I71dd446fcf025cee113593f889e34d9566257728 Bug: Reviewed-on: https://chromium-review.googlesource.com/622171 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#517784}
-
Takeshi Yoshino authored
Bug: 782487 Change-Id: Ied52b6322d1e66f11ae589256680b48706a62b67 Tbr: jochen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/778601Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#517783}
-
Christopher Lam authored
This CL adds an extra string to the Desktop PWA window title that denotes which app the window belongs to and the domain of the start URL. The window title is painted such that the page title will elide first, followed by the app name then the domain. Further work is required to maintain this property for all languages. Bug: 762401 Change-Id: Ibcc697b02fa643df9c2618ca0ef0249c6f887b64 Reviewed-on: https://chromium-review.googlesource.com/768601 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#517782}
-
Gyuyoung Kim authored
According to latest specification, DOMString types were updated to either ByteString or USVString. So this CL changes DOMString with them based on the updated specification partially, because there are unexpected test results on getResponseHeader, setRequestHeader, and open functions when updating. Following CLs will solve them. Spec: https://xhr.spec.whatwg.org/#the-send()-method https://github.com/whatwg/xhr/commit/cea2b9e1187921453434bc245208660edefa4c58 https://github.com/whatwg/xhr/commit/cbbc56ab2dc5049eb59c69f760038d62b3439cca Bug: none Change-Id: I8ed56dcbd5fa0451d82539d50659819fd117b710 Reviewed-on: https://chromium-review.googlesource.com/776516 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by:
-
Takeshi Yoshino authored
Bug: 786626 Change-Id: I8a5a3d5673f7a1fc57bb87791fb93411ae16adf2 Tbr: qinmin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/778342Reviewed-by:
-
cm.sanchi authored
From discussion on chromium-dev, it was decided to remove 'chrome' namespace. Bug: 289619 Change-Id: Ibc473af04b1e28f59ebcec8a4e1cb5616d4eb8cb Reviewed-on: https://chromium-review.googlesource.com/771091Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#517779}
-
Xiaocheng Hu authored
LayoutText::CaretMaxOffset() requires clean layout, but currently can be called from DeleteSelectionCommand when layout is dirty. This patch adds layout update before the call sites to fix it. Bug: 781698 Change-Id: I17b7596e93f025d61836e39cca4bf736713d3422 Reviewed-on: https://chromium-review.googlesource.com/778050 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Takeshi Yoshino authored
Bug: 754679 Change-Id: Icabfdc8f753595cd9b586b721ac58c607e7b660d Tbr: qinmin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/778646Reviewed-by:
-
Takeshi Yoshino authored
This reverts commit 1e2e99ef. Reason for revert: Suspected to be the cause of fast/mediastream/MediaStreamTrack-gc-no-crash.html failure Original change's description: > Enable video capture service by default on platforms where it is rolling > out with M61. > > Bug: 721812 > Change-Id: I1de0f625a1fb106e2dea664675e94267e66fc2fd > Reviewed-on: https://chromium-review.googlesource.com/719416 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517761} TBR=emircan@chromium.org,chfremer@chromium.org Change-Id: Icdb2af1cf68e1774d57c1d8b3c529e86e0a2a48e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721812 Reviewed-on: https://chromium-review.googlesource.com/778603Reviewed-by:
-
