- 29 Jun, 2018 40 commits
-
-
Aga Wronska authored
This reverts commit 4c2ee1dc. Original change's description: > Revert "Implement content of progress and error dialogs according to mocks." > > This reverts commit 1f7e073e. > > Reason for revert: Revert 1 of 2 - FindIt flagged https://crrev.com/c/1100237 with 100% confidence of breaking "Linux ChromiumOS MSan Tests" bot (DemoSetupTest.ProceedThroughSetupFlowSetupError); revering this CL is needed to be able to revert that one. > > Original change's description: > > Implement content of progress and error dialogs according to mocks. > > > > Bug: 827376 > > Cq-Include-Trybots: luci.chromium.try:closure_compilation > > Change-Id: I16781ef2ad241f28da0eef3126d9b6a66840f828 > > Reviewed-on: https://chromium-review.googlesource.com/1105568 > > Commit-Queue: Aga Wronska <agawronska@chromium.org> > > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > > Reviewed-by: Jun Mukai <mukai@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#571202} > > TBR=mukai@chromium.org,alemate@chromium.org,michaelpg@chromium.org,agawronska@chromium.org > > Change-Id: I86eba9fb27bc78941b9caab8c69bf983f17b19f0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 827376, 858817 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Reviewed-on: https://chromium-review.googlesource.com/1119267 > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Commit-Queue: Carlos Knippschild <carlosk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571283} Change-Id: I80071a9c745712e4e9f5b58c730edfb1f3d716e7 Bug: 827376, 858817 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1119269 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#571664}
-
Alexander Semashko authored
This is a prerequisite for switching WindowedNotificationObserver to use base::RunLoop instead of deprecated MessageLoopRunner. This CL is split out from https://crrev.com/c/982612. This CL was uploaded by git cl split. R=alexmos@chromium.org Bug: 668707 Change-Id: Ic3c72233d13ee53965bc250602462da4b12aa4c8 Reviewed-on: https://chromium-review.googlesource.com/1120489Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#571663}
-
James Cook authored
AXTreeSourceAura and AXTreeSourceMus share code, so extract a common base class. Bug: 851578 Test: views_unittests, views_mus_unittests, unit_tests Change-Id: I64a245dc6cdb97aaba8e2e05c0a6c7d008a38ef5 Reviewed-on: https://chromium-review.googlesource.com/1117918Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#571662}
-
Alexander Semashko authored
This is a prerequisite for switching WindowedNotificationObserver to use base::RunLoop instead of deprecated MessageLoopRunner. This CL is split out from https://crrev.com/c/982612. This CL was uploaded by git cl split. R=alexmos@chromium.org Bug: 668707 Change-Id: I2d723e7938ac7e07c6334e58b26b60e7e493834e Reviewed-on: https://chromium-review.googlesource.com/1120487Reviewed-by:
-
Bo Liu authored
This is a speculative experiment (since it's a simple change) to see if it has any effect on the rate of sad tabs when site isolation is enabled. This should be reverted before M69 branch point, and definitely before site isolation actually ships to beta. Bug: 855037 Bug: 859208 Change-Id: I90c7cce4a03603d8bd9772ead804eeabb4114bad Reviewed-on: https://chromium-review.googlesource.com/1120864 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
-
Aga Wronska authored
This is a reland of c618b6e7 Original change's description: > Add skeleton of Demo Mode setup UI. > > Mocks: > https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCGxzIhEyEZFkDOfw1G1Tu4Z > > Bug: 827376 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I1206687fff441ec6be5a3bb9e6dddba7469f292b > Reviewed-on: https://chromium-review.googlesource.com/1100237 > Commit-Queue: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571137} Bug: 827376 Change-Id: I8f4d81e2e10437b23cd4c84eac95204600fb28ee Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1119268Reviewed-by:
-
Yi Gu authored
Currently removing/pausing/aborting keyframe models to cc::Animation requires the client to provide the keyframe model id. e.g. Animation::RemoveKeyframeModel(id). Actually in reality we never remove/abort individual keyframe model of an animation but do them all together. This patch removes the ids from the clients so that they don't need to track the keyframe models. This patch is to clear barriers of introducing Group Effects. The non trivial changes on ui animation: Current logic: LayerAnimationSequence owns n LayerAnimationElement which could be either threaded (opacity, transform) or non threaded. Each of the threaded LayerAnimationElements has a corresponding cc::KeyframeModel which is added / removed on the LayerAnimationElement level. e.g. element->AddKeyframeModel(), element->RemoveKeyframeModel(). New logic: Given that threaded keyframe models can only be removed all together, we move the removal logic to the LayerAnimationSequence level. e.g. sequence->RemoveKeyframeModels(). The *add* logic is still on the element level because adding individual keyframe model for each element is allowed. Note that a sequence can contain both threaded and non threaded elements simultaneously. e.g. [threaded, non threaded, threaded]. To make sure that we don't remove the keyframe model from the second threaded element upon finishing the first threaded element, we need to finish the whole sequence to proceed. Also note that the sequence may be repeated infinitely and every time a threaded element is started we create a cc::KeyframeModel for it. That being said, we need to make sure that the existing keyframe models are removed before the sequence gets repeated. Bug: 810003 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia7dd8dab07a374da82f1619d011a23c31421295b Reviewed-on: https://chromium-review.googlesource.com/1102831 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#571658}
-
Fernando Serboncini authored
Bug: 563816 Change-Id: I3939845a5c512f7a1975b2da7592595572cbc522 Reviewed-on: https://chromium-review.googlesource.com/1119156Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#571657}
-
Eric Karl authored
Currently, we initialize HostFrameSinkManager at CompositorImpl creation, rather than at first request, which leads to the manager not being available at first use in rare cases where a DelegatedFrameHostAndroid is created before a CompositorImpl. This change shuffles logic around so that a HostFrameSinkManager is always available and doesn't rely on CompositorImpl timing. Bug: 858857 Change-Id: Ia708eaf35d9d39cd65c51b73e4ec6202b59fbb43 Reviewed-on: https://chromium-review.googlesource.com/1120937Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#571656}
-
Evan Stade authored
hosted apps. The caption buttons are provided by Ash, but we need the menu button and content settings icons to be added by Chrome (there are lots of Chrome dependencies there). Thus most changes are in the browser side frame view, as opposed to //ash/frame/. Test app: https://airhorner.com/ (app menu > Install Airhorn) Bug: 854704 Change-Id: Ibf65e49b0e6f4698a727cfcd17e2d78bb4a719af Reviewed-on: https://chromium-review.googlesource.com/1116069Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#571655}
-
Esmael El-Moslimany authored
Bug: 850239 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7c4807237b88ea8461c8835d6b5bd8f9bdb796f8 Reviewed-on: https://chromium-review.googlesource.com/1119634Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#571654}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f76f0b44062c..d1692d4ac997 git log f76f0b44062c..d1692d4ac997 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 perezju@chromium.org [Telemetry] Test markers are found in trace during StartupTracingTest 2018-06-29 perezju@chromium.org [dashboard] Make returning bug comments optional Created with: gclient setdep -r src/third_party/catapult@d1692d4ac997 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:854212 TBR=sullivan@chromium.org Change-Id: I14cafb4de0ff9c4b82b5a6ba9ce25cd4574e7e19 Reviewed-on: https://chromium-review.googlesource.com/1121016Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571653}
-
Morten Stenshorne authored
Change-Id: I46e6c87cbb74cd94e219d16be7c39dbc2e2b4c30 Reviewed-on: https://chromium-review.googlesource.com/1118175 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#571652}
-
Brian White authored
Bug: 682680 Change-Id: I913cdcced074d92ad60452a02a3781e8fb1b00cf Reviewed-on: https://chromium-review.googlesource.com/1120693Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#571651}
-
Carlos Knippschild authored
TBR=battre@chromium.org Bug: 853118 Change-Id: I4bec34e74ef14fbe8fc7ff17c6d6db51d343e7e1 Reviewed-on: https://chromium-review.googlesource.com/1121114Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#571650}
-
Sebastien Marchand authored
Bug: 859049, 773382 Change-Id: Ifc45ce7b154f7a5abf74fed09f92c1e3eb8c4b8a Reviewed-on: https://chromium-review.googlesource.com/1120843 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#571649}
-
Yoichi Osato authored
This patch refactors the test using NextLayoutObjectOnDOMTreeIncludeShadow rather than layout tree order to confirm SelectionStatus exactly. This patch also introduces understandable error output for ease of debugging. Bug: 708452 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ibd09fa39cbd2f98b84951ba41e091b8f3ae68494 Reviewed-on: https://chromium-review.googlesource.com/1117737Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#571648}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ae82b696f236..2895880fa835 git log ae82b696f236..2895880fa835 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 thestig@chromium.org Better determine if ICC colorspaces can be used for blending. Created with: gclient setdep -r src/third_party/pdfium@2895880fa835 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:847346 TBR=dsinclair@chromium.org Change-Id: I449f49dbc325fb0f7ed9fed5dd977bbf4c96b3dc Reviewed-on: https://chromium-review.googlesource.com/1120879Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571647}
-
Mitsuru Oshima authored
Bug: Noe Test: None Change-Id: If4e64628cf242c77a6c79defd0735fa408caba3e Reviewed-on: https://chromium-review.googlesource.com/1121196 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#571646}
-
Sky Malice authored
Bug: 714018 Change-Id: I2085e52ccd2e6f9205a0dc7b10bd9dd7c519ae84 Reviewed-on: https://chromium-review.googlesource.com/1117468Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#571645}
-
Henrique Grandinetti authored
Bug: 823536 Change-Id: I60edacb5780c019ae82fbe2df924b240ee0693e8 Reviewed-on: https://chromium-review.googlesource.com/1112051Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Cr-Commit-Position: refs/heads/master@{#571644}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/deee55b3d522..cf5de1da0720 git log deee55b3d522..cf5de1da0720 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 buildbot@webrtc.org Roll chromium_revision a88423ac..a714568f (571410:571512) 2018-06-29 srte@webrtc.org Removes redundant AlrDetector. 2018-06-29 srte@webrtc.org Adds srte@webrtc.org as modules/pacing/ OWNER. 2018-06-29 devicentepena@webrtc.org AEC3: Misadjustment estimator of the linear filter. 2018-06-29 danilchap@webrtc.org Add Generic frame descritpor header extension Created with: gclient setdep -r src/third_party/webrtc@cf5de1da0720 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:857426 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8ce05b9ba63368a1a56098fa9be00dd0c4c7fc17 Reviewed-on: https://chromium-review.googlesource.com/1121048Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571643}
-
Koji Ishii authored
When NGLineBreaker tries to fit items into a line, rounding errors are hard to avoid. One case is to fit `monospace` font into a container whose `width` is set by `ch` unit. Blink computes `ch` units in float, then round to LayoutUnit. This rounding often prevents the specified number of characters to fit into the line. All 4 impls pass this test for `3ch` to `100ch`. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9fe68a8bb44820aa15c7eb8c564776688c8320ee Reviewed-on: https://chromium-review.googlesource.com/1116409 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Min Chen authored
This is an initial cl for app windows dragging in tablet mode. Mocks: No exactly mock currently. Should be similar to tab dragging in tablet mode, https://docs.google.com/presentation/d/1zCV2v5rXFUndWC5ECMKj06i5WNbRJ-uZWyZTFxU8dEE/edit#slide=id.g21b4c071a9_0_116 See doc for the context: https://docs.google.com/document/d/1wq5F2P-CVokPEJT1V5-QIbQM6wjh-E65E6wPb6tOV7s/edit?ts=5b0ee6ae Recorded video: https://drive.google.com/file/d/1ZlDFDyB4-TpE-AQaVWbG8Ed2XwtkEC2q/view?usp=sharing Changes in this cl: - Add a new feature flag --enable-features=DragAppsInTabletMode and also expose it to chrome flag --enable-drag-apps-in-tablet-mode. - Added TabletModeAppWindowDragController to help handle app windows dragging in tablet mode. Only maximized window can be dragged currently. It can be dragged into splitscreen or restore back to maximized mode. If the window cannot be snapped, it will always restore back to maximized mode after dragging. - Rename TabletModeWindowResizer to TabletModeBrowserWindowDragController. And added TabletModeWindowDragController as the base class of TabletModeBrowserWindowDragController and TabletModeAppWindowDragController. Bug: 847587 Change-Id: I3c1a0e023019114189524500290704f46f892d08 Reviewed-on: https://chromium-review.googlesource.com/1105127 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#571641}
-
Peter Collingbourne authored
The browser process is the only embedder process that needs a service manager thread. With this change we avoid spinning up an unnecessary I/O thread (and presumably, once issue 729596 is fixed, a service manager) in processes that are neither subprocesses nor the browser process, such as the cloud print service process. Bug: 855193 Change-Id: Iffae3405f6dd541ce898ac2033c9c10daefd0031 Reviewed-on: https://chromium-review.googlesource.com/1117473 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#571640}
-
Cole Winstanley authored
This is a reland of be44dc6b Original change's description: > [ChromeDriver] Making CloseWindow W3C Compliant > > Making CloseWindow W3C compliant by returning the result of > GetWindowHandles. Modified testCloseWindow in run_py_tests.py > to test this conformance. > > Bug: chromedriver:1990 > Change-Id: I2e90e9e9ca16559ea3678846a7d605b402b4d431 > Reviewed-on: https://chromium-review.googlesource.com/1115813 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Cole Winstanley <cwinstanley@google.com> > Cr-Commit-Position: refs/heads/master@{#571334} Bug: chromedriver:1990 Change-Id: Iac9b60f09aeb697151077410dbcb408dbba420c2 Reviewed-on: https://chromium-review.googlesource.com/1120696Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Cole Winstanley <cwinstanley@google.com> Cr-Commit-Position: refs/heads/master@{#571639}
-
Peter Collingbourne authored
TBR=calamity@chromium.org Change-Id: I4df745993ebc2d01da7b463b4cec3c92d9e7380d Reviewed-on: https://chromium-review.googlesource.com/1119493 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571638}
-
Chris Harrelson authored
An experiment was run on the beta channel. Health metrics were unchanged, and performance improved at 75th (slight improvement), 95th (~10%) and 99th (~3%) percentiles on both Android and Windows. Bug: 831762 Change-Id: Iee215f53317d9508f49061c08d961ca01366a4e0 Reviewed-on: https://chromium-review.googlesource.com/1120690Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571637}
-
David Grogan authored
A collapsed row would subtract border-spacing right away, then also subtract it later when passing heights to %-height children. Bug: 855917 Change-Id: I29f5e01035b7f9dc76af337fbd65cc332d50376c Reviewed-on: https://chromium-review.googlesource.com/1116249Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#571636}
-
Antonio Gomes authored
This CL makes the TestURLLoaderFactory::SimulateResponse API more flexible in the following ways: - it starts to actually use the |net_error| parameter (to build the URLLoaderCompletionatus instance) - it adds an extra (also optional) net::HttpStatusCode parameter, so that one can more easily mock failing responses. - one can see it in action in [1]. [1] https://crrev.com/c/1114998/components/autofill/core/browser/autofill_download_manager_unittest.cc#283 Bug: 773295 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iba4edf640b3ff82e035ffbe26c3066d404f18ce7 Reviewed-on: https://chromium-review.googlesource.com/1120916 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#571635}
-
Peter Collingbourne authored
Bug: 855193 Change-Id: Ic7ca91171215cc7054ca56af3ef6d496c2fcfb55 Reviewed-on: https://chromium-review.googlesource.com/1117862Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#571634}
-
Morten Stenshorne authored
Change-Id: I0220951586c580689caa4a5a1b9c0451e83c5069 Reviewed-on: https://chromium-review.googlesource.com/1118177 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
When parent and child inline elements have different font metrics, they may have different vertical locations and/or heights, in which case we should preserve the parent box fragment, since we can't reconstruct the parent rect as a simple union of its child rects. This patch fixes failures due to such incorrect reconstruction. Note: this is a sibling patch of crrev.com/c/1108509, where we preserved inline box fragment if there are atomic inline children. Note 2: legacy handles different font metrics case with ComputeItemTopHeight in layout_inline.cc, which looks hacky and reduces code readability. Hence, we don't replicate it to NG. Bug: 851075 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7d99e01afd0842b03163c16d0ab57bc0ef9fcc4c Reviewed-on: https://chromium-review.googlesource.com/1117716 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7ec4a3ef. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20357 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources TBR=kereliuk No-Export: true Change-Id: Ica3db82437f23f0a92da020e108d652b9e42b09e Reviewed-on: https://chromium-review.googlesource.com/1120854 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#571631}
-
Xiaocheng Hu authored
NG Hit test code currently uses variable names with unclear meanings, e.g. |accumulated_offset|, |adjusted_location|, ...., like legacy. This patch changes them into clear terms like |physical_offset|, and adds comments for clarification. Bug: 855279 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6c189b7e7001db8abb66241500b97d5df0c9c5b0 Reviewed-on: https://chromium-review.googlesource.com/1121052 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c91fe3ab1c5d..184d408b646b git log c91fe3ab1c5d..184d408b646b --date=short --no-merges --format='%ad %ae %s' 2018-06-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-29 ruiqimao@google.com skeletal animation support added to API and software backend 2018-06-29 mtklein@chromium.org update and skip accepts check in lexers 2018-06-29 brianosman@google.com Update ImGui to v1.62 (June 22, 2018) 2018-06-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-29 mtklein@google.com Revert "GrTessellator: handle three consecutive collinear edges." 2018-06-29 enne@chromium.org Fix chrome memory dump crashes using out of process strike caches 2018-06-29 senorblanco@chromium.org GrTessellator: handle three consecutive collinear edges. 2018-06-29 fmalita@chromium.org [skottie] Fix 'subtract' masks 2018-06-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@184d408b646b The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:851409.,chromium:851409. TBR=jcgregorio@chromium.org Change-Id: I6c4ed70c86826c5e2077314c243d352d238a02bb Reviewed-on: https://chromium-review.googlesource.com/1121049Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571629}
-
Scott Graham authored
https://chromium.googlesource.com/chromium/buildtools.git/+log/aec56e26079f..0dd5c6f980d2 $ git log aec56e260..0dd5c6f98 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 scottmg Revert "Remove libcpp_is_static" 2018-06-29 scottmg Re-add .gitignore for GN 2018-06-28 thomasanderson Remove libcpp_is_static Created with: roll-dep src/buildtools TBR: dpranke@chromium.org Bug: 858852, v8:7900 Change-Id: Ie887a2a54932703505369516ca42bf44c19242db Reviewed-on: https://chromium-review.googlesource.com/1121046Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#571628}
-
liberato@chromium.org authored
This is a reland of 7baa2dc1 Original change's description: > Convert various gpu video decoders to use AbstractTexture. > > Previously, VDAVideoDecoder, MCVD and D3D11VideoDecoder used > the validating GLES decoder's TextureRef (possibly indirectly, via > GLES2DecoderHelper and CommandBufferHelper) to retain textures. > > This CL moves them all over to use AbstractTexture, in preparation > for supporting the passthrough GLES decoder. > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I13985223443b8e0897c1508f052d0f35d77746fe > Reviewed-on: https://chromium-review.googlesource.com/1091649 > Commit-Queue: Frank Liberato <liberato@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571223} Change-Id: I69b842f2c08cbac9e9a1dfa12ea08133fff56c75 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1120470Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#571627}
-
Charlie Reis authored
We should track down the cause, but the intent of the restriction is to prevent web processes from committing extension URLs, so make an exception for now. BUG=840857 Change-Id: I5259f870140896400eb076b870981750a9ff73cd Reviewed-on: https://chromium-review.googlesource.com/1120840 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571626}
-
Alex Moshchuk authored
After r550769, cross-process postMessages are scheduled with PostTask, so that the actual postMessage IPC goes out on next iteration of the event loop. This is problematic when postMessage is executed from an unload handler that is triggered on a local-to-remote frame swap in RenderFrameImpl::OnSwapOut: the SwapOut ACK ends up being sent before any postMessage IPCs, and if this was the last active frame in the process, the browser process, upon receiving the SwapOut ACK, might destroy proxies that a postMessage was targeting. To prevent this, schedule the SwapOut ACK to ensure that it gets sent after any postMessage IPCs. Bug: 857274 Change-Id: I9e7339c0abc409fd201e7f73927e871c0f0d3b95 Reviewed-on: https://chromium-review.googlesource.com/1119391Reviewed-by:
-
