GitLab

Please reply to the V8 sheriff danno@chromium.org in case of problems.

TBR=danno@chromium.org

Review URL: https://codereview.chromium.org/288193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270987 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373385
R=jochen@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/289033006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270986 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds the read file operation, which is however not bound yet to
fileapi.

In the upcoming patch, support for FileStreamReader will be added. After that,
OpenFile, CloseFile and ReadFile will be bound to async file utils.

TEST=unit_tests: *FileSystemProvider*ReadFile*
BUG=248427

Review URL: https://codereview.chromium.org/287673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270985 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373594

Review URL: https://codereview.chromium.org/289963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270984 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270983 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174125:174137&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/287163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270982 0039d316-1c4b-4281-b951-d872f2087c98

Re-enable org.chromium.android_webview.test.ExternalVideoSurfaceContainerTest#testEnableVideoOverlayForEmbeddedVideo

The fix was landed: https://codereview.chromium.org/289653002

BUG=372748,372174

Review URL: https://codereview.chromium.org/292453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270979 0039d316-1c4b-4281-b951-d872f2087c98

The separated version of Gallery does not need the button.

BUG=358698
TEST=manually

Review URL: https://codereview.chromium.org/291483006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270978 0039d316-1c4b-4281-b951-d872f2087c98

PeerConnectionDependencyFactory should only deal with MediaStream tracks that are sent on a PeerConnection and thus is not a general MediaStream factory.
This cl also moves PeerconnectionDependencyFactory to media/webrtc since it depends on libjingle/webrtc files.

Note that PeerConnectionDependencyFactory still have some methods related to general audio input that should be further refactored.

BUG=323223

Review URL: https://codereview.chromium.org/272043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270977 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Stop ServiceWorker context when no controllee is associated (and when all refs are dropped) (https://codereview.chromium.org/272183005/)

Reason for revert:
Has memory leaks in
EmbeddedWorkerInstanceTest.InstanceDestroyedBeforeStartFinishes

Original issue's description:
> Stop ServiceWorker context when no controllee is associated (and when all refs are dropped)
> 
> Currently we stop the ServiceWorker thread/context when:
> 1. After all documents that are controlled by the SW are closed, with a delay (5 min)
> 2. All references to the version are dropped (i.e. in dtor)
> 
> In the current impl/codebase a worker is immediately stopped by 2
> in most cases.
> 
> The same stop timer (ScheduleStopWorker()) could be probably called
> each time handling event is finished to stop the worker more 
> aggressively, though this patch doesn't do so.
> 
> BUG=372673
> TEST=tested manually with chrome://serviceworker-internals/
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270971

TBR=michaeln@chromium.org,horo@chromium.org,kinuko@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=372673

Review URL: https://codereview.chromium.org/286203008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270976 0039d316-1c4b-4281-b951-d872f2087c98

In the Mac implementation of the password generation poup, the password
row is not unselected when the mouse is moved elsewhere in the popup
(e.g. over top of the help text).

The fix is that PasswordSelected() should always be called in
SetSelectionAtPoint, not just when the mouse is within the password
bounds. The Views implementation happens to work because it has a
subview (PasswordRow) which triggers OnMouseExited() when the mouse
moves outside of the password bounds.

Also added an optimization that PasswordSelectionUpdated() is only
called when the value is actually changed, not every time
PasswordSelected() is called.

BUG=114092
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/282093006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270975 0039d316-1c4b-4281-b951-d872f2087c98

This reverts changes user_manager_impl.cc that were lost in previous
revert (https://codereview.chromium.org/284333002) because file got moved.

BUG=331530
TBR=antrim

Review URL: https://codereview.chromium.org/288923010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270974 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Re-enable key silk case benchmarks on Android (https://codereview.chromium.org/279853002/)

Reason for revert:
Still failing on N5. e.g. 

http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf/builds/393/steps/smoothness.fast_path.key_silk_cases/logs/stdio

BUG=355952

Original issue's description:
> Re-enable key silk case benchmarks on Android
> 
> All the known issues with these telemetry benchmarks have been fixed.
> 
> BUG=355952
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270830

TBR=ernstm@chromium.org,skyostil@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=355952

Review URL: https://codereview.chromium.org/292453005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270973 0039d316-1c4b-4281-b951-d872f2087c98

Currently we stop the ServiceWorker thread/context when:
1. After all documents that are controlled by the SW are closed, with a delay (5 min)
2. All references to the version are dropped (i.e. in dtor)

In the current impl/codebase a worker is immediately stopped by 2
in most cases.

The same stop timer (ScheduleStopWorker()) could be probably called
each time handling event is finished to stop the worker more 
aggressively, though this patch doesn't do so.

BUG=372673
TEST=tested manually with chrome://serviceworker-internals/

Review URL: https://codereview.chromium.org/272183005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270971 0039d316-1c4b-4281-b951-d872f2087c98

The existing test code returns an empty ImageSkiaRep where
bytes are allocated but nothing is initialized. This was okay
because ImageSkiaTest doesn't touch the contents of the image.

Now ImageSkia can rescale the image data and such cases are
tested. So using a dummy ImageSkiaRep wouldn't be helthy.
Rather some data should be drawn.

BUG=373748
R=oshima@chromium.org
TEST=

Review URL: https://codereview.chromium.org/285393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270970 0039d316-1c4b-4281-b951-d872f2087c98

This test is flaky on my machine without this patch.

Separated from issue 270563002.

BUG=
TEST=LoginStateNotificationBlockerChromeOSBrowserTest
TBR=mukai@chromium.org

Review URL: https://codereview.chromium.org/284323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270969 0039d316-1c4b-4281-b951-d872f2087c98

This prevents RecvMsgWithPid from DCHECK failing under Debug builds
when reading EOF from a broken socket pair.  Noticed while testing
crrev.com/269543014.

Unfortunately, Linux allows sending zero length messages that the
recvmsg() API does not distinguish from reading EOF.  To be
conservative, if we didn't receive any message or control bytes, then
assume we received an EOF and tolerate not knowing the sender's PID.

BUG=357670

Review URL: https://codereview.chromium.org/276593008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270967 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Speculative revert because of failure in desktop_screen_x11_unittest.cc (DesktopScreenX11Test.GetWindowAtScreenPoint).

Original issue's description:
> Fix X11TopmostWindowFinder to take into account
> - Window manager provided window borders
> - Custom shapes specified via views::Widget::SetShape()
> 
> BUG=None
> TEST=None
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270877

TBR=sadrul@chromium.org,pkotwicz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/291583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270964 0039d316-1c4b-4281-b951-d872f2087c98

After maximizing/restoring the app widnow, the position of gear menu may not be
updated due to crbug.com/374093. This CL adds a workaround for the bug, which
forces to update the gear menu position.

BUG=372380
TEST=manually
R=fukino@chromium.org, yoshiki@chromium.org

Review URL: https://codereview.chromium.org/291583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270963 0039d316-1c4b-4281-b951-d872f2087c98

In tile manager we seem to reach the memory limit early (with the
pending tree). However, when we activate our memory gets released
and we start filling it up again with the now active tree tiles.

The windows bot seems to catch the system at the moment when we're not
using a lot of memory, thus failing the test.

BUG=373098
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/289003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270962 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jyasskin@chromium.org
NOTRY=true
BUG=374105

Review URL: https://codereview.chromium.org/291593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270961 0039d316-1c4b-4281-b951-d872f2087c98

The API is added crrev.com/270720.

BUG=358698
TEST=run the new Gallery.app.
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/282523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270960 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/284073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270959 0039d316-1c4b-4281-b951-d872f2087c98

The corresponding dbus level method is already added in
https://chromium-review.googlesource.com/#/c/195111/.
This CL is for adding the method to the wrapper client class.

BUG=356583

Review URL: https://codereview.chromium.org/281063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270958 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270957 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174118:174125&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/286203006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270956 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369875
TEST=On a Chromebook, try to save a web page and see the file type selector.

Review URL: https://codereview.chromium.org/287083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270955 0039d316-1c4b-4281-b951-d872f2087c98

Sending a RTCP sender report used to require a couple round trips of
IPCs. This is much simplified in this change. AudioSender or VideoSender
sends the latest known NTP time and corresponding RTP timestamp. Sends
it to CastTransportSender, which appends the current packet ccount and
octet count to form a sender report.

There is no need for AudioSender and VideoSender to know the current
packet count and octet count.

Review URL: https://codereview.chromium.org/281453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270954 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270953 0039d316-1c4b-4281-b951-d872f2087c98

BUG=275271
TEST=unit_tests

Review URL: https://codereview.chromium.org/285323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270952 0039d316-1c4b-4281-b951-d872f2087c98

> Move all callers of GetHomeDir() to PathService::Get(base::DIR_HOME).
> 
> * Fixes GetHomeDir() for multi-profiles case on Chrome OS.
> * Once user signs in on Chrome OS base::DIR_HOME is overridden with primary user homedir.
> * Added content switch --homedir to pass that information to ppapi plugins since they run in a separate process and previous base::DIR_HOME override does not apply there.
> 
> This fix doesn't require checking for --multi-profiles switch
> since user_id hash is known even without it.
> 
> BUG=331530
> TBR=vitalybuka@chromium.org
> 
> Review URL: https://codereview.chromium.org/200473002

This test has caused two tests to start failing on the chromeos valgrind bots:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%286%29/builds/25884
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%285%29/builds/26990

TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/284333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270951 0039d316-1c4b-4281-b951-d872f2087c98

> Use real PlatformSupport in content unit tests
> 
> Once all pages are force composited by default, this allows these tests
> to not explode when trying to create GraphicsLayers because of a lack of
> Platform::compositorSupport.
> 
> BUG=none
> 
> Review URL: https://codereview.chromium.org/287043002

This test has caused leak errors on the mac valgrind bot:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%282%29/builds/27964

TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/284193006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270950 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270949 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:371079
TEST=cros chrome-sdk --internal --board lumpy --version=5854.0.0 now works

Review URL: https://codereview.chromium.org/291483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270948 0039d316-1c4b-4281-b951-d872f2087c98

Previously the gallery's ribbon refers oldUrl property that was replaced with
oldEntry.
This causes a bug to fail update the ribbon's cache.

BUG=373167
TEST=manually
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/287063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270947 0039d316-1c4b-4281-b951-d872f2087c98

It's never set.

BUG=None

Review URL: https://codereview.chromium.org/286233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270946 0039d316-1c4b-4281-b951-d872f2087c98

Authored by davemoore@chromium.org, see https://codereview.chromium.org/275363002/

R=darin@chromium.org
TBR=davemoore@chromium.org

Review URL: https://codereview.chromium.org/287143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270945 0039d316-1c4b-4281-b951-d872f2087c98

This test fails flakily there.

TBR=perkj@chromium.org
NOTRY=true
BUG=373637

Review URL: https://codereview.chromium.org/292433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270944 0039d316-1c4b-4281-b951-d872f2087c98

This test has been failing frequently on bots and closing the tree.

NOTRY=true
TBR=mtomasz@chromium.org
BUG=374097

Review URL: https://codereview.chromium.org/290613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270943 0039d316-1c4b-4281-b951-d872f2087c98

This is a split of https://codereview.chromium.org/287673004/, to avoid
merging issues.

It is almost impossible to land a CL adding histograms via CQ, without
a merging conflict.

TBR=isherman@chromium.org
TEST=Just histograms, no actual changes.
BUG=248427

Review URL: https://codereview.chromium.org/289063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270942 0039d316-1c4b-4281-b951-d872f2087c98