- 18 Sep, 2020 40 commits
-
-
Guillaume Jenkins authored
Moves the DisableSafeBrowsingProceedAnyway from supported_on iOS 85 to future_on. This is the only policy that wasn't moved to future_on, other than EnableExperimentalPolicies. I believe it was an oversight. Without this change, the enterprise documentation page for the policy has a visual bug when displaying supported versions: https://screenshot.googleplex.com/7ZxKRy3mCmgCyut BYPASS_POLICY_COMPATIBILITY_CHECK="Moving the policy to future_on, since it hasn't truly been released" Bug: 1129888 Change-Id: I215afe151edc7379b60c85dcf2e1b31be00d625c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416852 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#808385}
-
Markus Handell authored
This reverts commit 6fc7c32c. Reason for revert: crbug.com/1128470 Original change's description: > [PTZ] Add macOS support > > This CL makes sure a USB Webcam device on macOS properly advertises its > PTZ support. When supported, the pan, tilt, and zoom controls (ranges > and values) are available to websites that user has granted access to. > > Bug: 934063 > Change-Id: I9d92d41fba0a6e9d518efb2501355d66cf77998f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368596 > Reviewed-by: François Beaufort <beaufort.francois@gmail.com> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: François Beaufort <beaufort.francois@gmail.com> > Cr-Commit-Position: refs/heads/master@{#807387} TBR=avi@chromium.org,beaufort.francois@gmail.com,reillyg@chromium.org,guidou@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 934063 Change-Id: I88b1a41d28f5ad34f149f489b22eae6753e051dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418577Reviewed-by:
Markus Handell <handellm@google.com> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#808384}
-
Elaine Chien authored
Bug: 1129024 Change-Id: I4d56a24510e09875463485ba105cbd354bd5f58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414925Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elaine Chien <elainec@chromium.org> Cr-Commit-Position: refs/heads/master@{#808383}
-
Yunke Zhou authored
Bug: 1127546 Change-Id: Ib4797dc6d8f2b28c15c3b55fb1a122d1027d999f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416502 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808382}
-
Oleg Davydov authored
This is minor simplification in WallClockTimer: Instead of SetNow(Now() + delay) idiom use special SimpleTestClock method. Bug: None Change-Id: I035bfe44792c0e12c23373ded65ad520792d1824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418317 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
-
Evan Stade authored
Bug: 1110811 Change-Id: Ic71790caad999db46b8a008f4194e4bf3ddab90f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415090 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#808380}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Ia566284652d587b7462a24638091c57af4350f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347034 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1102019 Change-Id: I5ec6f6a7467de2cb779984b9f1425f975c10f5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418377 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
Kevin Ellis authored
Fixes regression introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2416390 Bug: 1129816, 129780, 1129664 Change-Id: I793a61710fdc1f1b05b15d84a0aec4b4fc08bde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418971Reviewed-by:
Eugene Girard <girard@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#808377}
-
Ioana Pandele authored
A few test cases require access to list elements that can be off-screen. Those tests should first attempt to scroll to the required element, so that its corresponding view actually exists in the hierarchy. Bug: 1129884 Change-Id: Ifa5df8bdd26823c244339197d70806843763cd13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418672 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#808376}
-
Titouan Rigoudy authored
This change has the computation take into account the is_web_secure_context bit as set on the parent document, if any. It is not immediately clear what to do when the parent document has not committed a navigation yet. I suspect this ties in to crbug.com/1129326, in which we might want to look at the *current* frame's client security state instead, and inherit a value at frame creation time from the parent. Also stop computing the client security state for navigation requests served by the back-forward cache. Bug: chromium:1126856 Change-Id: I72a3ffddf53eaea04f579c87705eff68508474ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414249 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#808375}
-
Roman Sorokin authored
It's not being reported to histograms Bug: none Change-Id: I1e6999cf4618cdeb9a7969e78d35a06b0d461c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418573Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808374}
-
Robert Sesek authored
- Note that a component build will not work. - Note that library validation is incompatible with self-signed identities. - Add troubleshooting steps for detached signatures. Change-Id: Iffe04daffb49b2332966325abf02f4b11344e6a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416997 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#808373}
-
arthursonzogni authored
This reenable the two tests: CoopReportingOriginTrialBrowserTest.AccessReportingWithToken CoopReportingOriginTrialBrowserTest.CoopStateWithToken They aren't working on Android, because the OriginTrialPolicy is not set on this platform for BrowserTest in the browser process. See the comment in the code below. Bug: 1119555 Change-Id: I66cd03c9b8e1de26e9e21469149620eca43d67d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388120Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#808372}
-
Alice Wang authored
This CL adjusts the strings used in web sign-in bottom sheet to the final version that has legal approval. Screenshots: https://crbug.com/1129810/#c1 Bug: 1129810 Change-Id: Ic628263227b108376a7d72efa5b71ce4d03442d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418314 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#808371}
-
Yuanyao Zhong authored
Update chromecast's copy of accessibility private API. Add AcceleratorAction to accessibility_private.json. This is another candidate for duplicate code cleanup efforts. (See crbug.com/837773) However, leaving this in place for now. This change is needed for downstream accessibility to work. Test: build chromecast Bug: None Change-Id: I643642b821f247c928c6df27a338fb9b20d5b16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416853Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Yuanyao Zhong <yyzhong@google.com> Cr-Commit-Position: refs/heads/master@{#808370}
-
James Hawkins authored
This is a reland of 4b5732c0 Moved nearby_share test data JS files to is_chromeos section. Original change's description: > Nearby Share: Update build files to limit to CrOS only. > > For now Nearby Share is only planned to ship on CrOS and supporting > multi-platform builds is quite costly. > > Bug: none > Test: none > Change-Id: If879641d0d5b766f384f184078015eeabbf2215f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415135 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: James Hawkins <jhawkins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807903} Bug: none Change-Id: I5b4db837dc8d08f5ff2c5a8b2152be11ddf5c2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416726Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#808369}
-
Reilly Grant authored
A potential solution for issue 1119497 is to switch from enumerating devices implementing GUID_DEVINTERFACE_COMPORT to using the "bus enumerator" identified by GUID_DEVINTERFACE_SERENUM_BUS_ENUMERATOR. I'm putting this behind a flag so that developers can try it out in canary-channel. If it works I can enable it by default and keep the flag around for a couple releases in case it causes other problems. Bug: 1119497 Change-Id: Icad9008799ed331c3da15e5a70e0184144c47a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417460 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#808368}
-
Eric Orth authored
Fixed: 1081186 Change-Id: I4a6a68b2368abf9a959c1a856536170958d9a694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416883Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#808367}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a1539502. With Chromium commits locally applied on WPT: c2ab413e "CSS: Retire expansion-based implementation of :is and :where" aaab8ee4 "CSS: Rename new WPTs for uniqueness" e24e2d64 "Custom layout needs to force NG layout for the subtree." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Idaca15ca711c93e6a5104e27e781095b07f257ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418613Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808366}
-
James Cook authored
The API contract for ui::SelectFileDialog::SelectFile() allows a null owning_window, which should result in a modeless dialog not associated with a particular browser window. The lacros code used to assume owning_window was always non-null. This works for the common cases of open/save dialogs, but there's a code path for downloads that passes null. Add support for modeless dialogs by passing an empty owning shell window id for the SelectFile crosapi call. This is a non-breaking change. If a new lacros passes an empty window id to an older ash then the old code in ash will try to look up a shell surface window, fail, and bail out. Bug: 1129176 Change-Id: I6c71a573a411c1c5f4a6777dd7f102476201b102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417402Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#808365}
-
James Cook authored
Lacros is currently deploying trunk lacros-chrome to users running ash-chrome canary/dev/beta. This can make it hard to reason about which features are expected to work modulo the user's ash version. Add comments about the milestone each major new interface was added. We're hoping this helps a little with reasoning about compatbility, at least at a very high level. Bug: none Change-Id: I9bd79ffed130ebf85712145e31485d13080b22db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417510 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
-
Steven Valdez authored
Change-Id: I968cf53ce3bee336eb478404ab34175fa6755f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416809 Auto-Submit: Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#808363}
-
Justin Cohen authored
TBR = alfonsogarza@google.com Bug: 1108809 Change-Id: I94e5332ad2832f25671848ecfda233a6b45dc655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418913Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808362}
-
Dominique Fauteux-Chapleau authored
This should not change deep scanning behaviour with Connectors since OnSecurityEventEnterpriseConnector replaces this policy. Removing this policy completely is safe since it was marked as future and it has only been delivered as a cloud policy. Bug: 1103390 Change-Id: Ie886239acd53e28c5a9104812738b7627d082a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414550Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#808361}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1d480934..ad83951e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I29af5847d59ce06d42348c87d1b28a1ca29e0b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418614Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808360}
-
Victor Hugo Vianna Silva authored
After crrev.com/c/2415150, the class is no longer used from a background thread. This allows for a number of simplifications. - Removing all the synchronization code (synchronized blocks and lock). - updateSyncability() is now synchronous, so no need to expose the artificial callback parameter in ctor/updateAccount(). The associated code in the test file (CallbackHelper and updateAccountAndWait()) can also be removed. This also requires some adaptations: - Every call to the public API is guarded by assertOnUiThread(). - Tests that called the API from the test thread now use the methods in AndroidSyncSettingsTestUtil on runOnUIThreadBlocking(). Non-related to all this, the CL also takes care of the quick cleanup post crrev.com/c/2415150: AndroidSyncSettingsObserver implementations don't have to post a task anymore, since they are now notified directly in the UI thread. Fixed: 1028568 Change-Id: I8526cf67b26c97b3303510fbf0f4f0fc737617f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414194 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#808359}
-
Christian Dullweber authored
Create "fade-through" animation to switch between main page and subpage. Remove animation for page-info rows. Video: https://crbug.com/1077766#c42 Bug: 1077766 Change-Id: I330b57b79a0e6dbd421b1d10ac897f16246f2f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418373Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#808358}
-
Viktor Semeniuk authored
Test was flaky because objects in the test scope weren't deallocated properly. Changing to BlockCleanupTest is fixing it. Bug: 1126660 Change-Id: If301a7c27a6170b2a12831ea06c78e7f1e204a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414230 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#808357}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/68c424fe4240..97813ea40eea 2020-09-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 399f7fd741f7 to a148cdd49041 (1 revision) 2020-09-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 46fc663a1cb3 to d6935becabad (6 revisions) 2020-09-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 34ef0c3fdc8e to 50ae4c5f4427 (3 revisions) 2020-09-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from b045bf7d3b6a to 6ccc0d9ba0ff (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I5407ab46da1b7247acc87f959c5b363a5bca6b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418362Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808356}
-
Peter Boström authored
These arguments are essentially mandatory and call sites set both of them. Bug: 1106422 Change-Id: I85483306b70509e3b5cd0db5559179c88bc97b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417062 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Vasiliy Telezhnikov authored
Creation of eglImage can fail if context is lost. This CLs adds check that |source_texture_holder_| is not nullptr to avoid crash. Bug: 1129798 Change-Id: I91c351fa7932bda9074182090e6ede62cfc05ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418892Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#808354}
-
Joshua Pawlicki authored
- guidance is that owners should be committers, so removed mila for now. - linked Android and iOS Omaha clients to updater ownership. - salute to cpu@, but probably it is time to remove. Change-Id: I8beda0126d99a31b141c0f86bae6716e0c46446f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419031Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#808353}
-
Xi Han authored
In this CL, we make the following changes for MVP: 1) Hide the incognito switch on MVP start surface home page. 2) "Open a new incognito tab" will open a regular incognito tab without the home button. 3) Don't hide the incognito switch on Grid tab switcher. The Grid tab switcher can be reached from either "view all" button or the "tab switcher" button on a tab. Mock: https://docs.google.com/presentation/d/1ejI8l08SHOHF81rBXNWLMIJlNeMWHOTdnrU4VBq1UPE/edit?ts=5f4edb29#slide=id.g948759a467_0_0 Bug: 1108993 Change-Id: I01b4f6a569cfd663cc10f98e3b1be9a6e1dc1601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392736 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#808352}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1600192792-f4ca908cacd319b04516240c34a315b960a046b2.profdata to chrome-win64-master-1600408689-3295f79c407879ba1d63e0363bb7fc826852b30c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I7202874fb9f979d5aa261acf505712f5867eca61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418016Reviewed-by:
-
Peng Huang authored
We found some Mali GPU, Android surface control cannot present AHB correctly if the AHB Vulkan image's layout is not VK_IMAGE_LAYOUT_PRESENT_SRC_KHR. Fix the problem by setting the layoout after each accessing. Bug: 1127432 Change-Id: Id1efcde8824936dad5536b5f75a233d8ea968bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414677 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808350}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8d875587d515..70026f9d14f0 2020-09-18 kwiberg@webrtc.org Put UntypedFunction in untyped_function.h, not function.h 2020-09-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9cee95fc..86ce521c (808139:808263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0da03f6637642f5ca5637205bf60364f46f39922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418831Reviewed-by:
-
Friedrich Horschig authored
Instead of just telling users what a chip fills, highlight that a chip is an *autofill suggestion* provided by *Chrome*. IDS_IPH_KEYBOARD_ACCESSORY_FILL_WITH_CHROME screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/1b93b6afc656909bacdf8f62712a21b5990c7ac4 Bug: 1124711 Change-Id: Iefb80ccd3f59a865da661cf51d1308095c58fcb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418312Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#808348}
-
Michael Thiessen authored
Introduces JUnitTestGURLs, which returns GURLs generated from serialized GURLs for use in junit tests where the native library cannot be loaded. This allows junit tests to do simple operations with GURLs and allow unit testing of classes that use GURL without caring too much about more complex things like formatting or comparing origins, etc. The alternative to this is migrating the junit tests to instrumentation tests, but this isn't always feasible. For example, QualityEnforcerUnitTest is really difficult to re-write as an instrumentation test because of how it mocks out Activity behaviour and tests toasts. Bug: 783819 Change-Id: I37cf3a869958bd30e7ae86d2b212fd19961c1d7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417063Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#808347}
-
Jesse Schettler authored
When scanning is disabled, the scan SWA is disabled and chrome://scanning is forwarded to chrome://app-disabled. Bug: b:167569193 Change-Id: Ib9b3eb83f501470f6711a954abb68f12b479cead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406180 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#808346}
-
