Commits · e2ce6d1abcf4f17f3f31427a67fa88075d4232bc · eriksson monteiro / tangled

27 Jan, 2010 40 commits

[Qt] Update the .def files with exported symbols · e2ce6d1a

hausmann@webkit.org authored Jan 27, 2010

Reviewed by Laszlo Gombos.

* symbian/eabi/QtWebKitu.def: Add two mangled missing new symbols for arm eabi.

git-svn-id: svn://svn.chromium.org/blink/trunk@53936 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e2ce6d1a

.: [Qt] Don't build the tests in packages, only the launcher(s) · 031865a8

hausmann@webkit.org authored Jan 27, 2010

Reviewed by Kenneth Rohde Christiansen.

* WebKit.pro:

WebCore: [Qt] For package builds use the .def files on Symbian

Reviewed by Kenneth Rohde Christiansen.

* WebCore.pro:

git-svn-id: svn://svn.chromium.org/blink/trunk@53935 bbb929c8-8fbe-4397-9dbb-9b2b20218538

031865a8

2010-01-27 Jay Campan <jcampan@google.com> · 9edb01fe

eric@webkit.org authored Jan 27, 2010

        Reviewed by Darin Fisher.

        Adding EventListeners to the chromium API.

        https://bugs.webkit.org/show_bug.cgi?id=33882

        * WebKit.gyp:
        * public/WebEvent.h: Added.
        * public/WebEventListener.h: Added.
        * public/WebMutationEvent.h: Added.
        * public/WebNode.h:
        * public/WebString.h:
        (WebKit::operator==):
        (WebKit::operator!=):
        * src/EventListenerWrapper.cpp: Added.
        * src/EventListenerWrapper.h: Added.
        * src/WebEvent.cpp: Added.
        * src/WebEventListener.cpp: Added.
        * src/WebEventListenerPrivate.cpp: Added.
        * src/WebEventListenerPrivate.h: Added.
        * src/WebNode.cpp:
        (WebKit::WebNode::addEventListener):
        (WebKit::WebNode::removeEventListener):
        * src/WebString.cpp:
        (WebKit::WebString::equals):

git-svn-id: svn://svn.chromium.org/blink/trunk@53934 bbb929c8-8fbe-4397-9dbb-9b2b20218538

9edb01fe

2010-01-27 Alexander Pavlov <apavlov@chromium.org> · c024fcf3

eric@webkit.org authored Jan 27, 2010

        Reviewed by Timothy Hatcher.

        Avoid watch expressions duplication
        https://bugs.webkit.org/show_bug.cgi?id=33996

        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSidebarPane.prototype._settingsLoaded):

git-svn-id: svn://svn.chromium.org/blink/trunk@53933 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c024fcf3

2010-01-27 Alexander Pavlov <apavlov@chromium.org> · 6f2fac00

apavlov@chromium.org authored Jan 27, 2010

        Adding myself as committer. No review necessary.

        * Scripts/webkitpy/committers.py:


git-svn-id: svn://svn.chromium.org/blink/trunk@53932 bbb929c8-8fbe-4397-9dbb-9b2b20218538

6f2fac00

2010-01-27 Marcus Bulach <bulach@chromium.org> · 1cdf0eee

eric@webkit.org authored Jan 27, 2010

        Reviewed by Dimitri Glazkov.

        Adds EventSource bindings for V8
        https://bugs.webkit.org/show_bug.cgi?id=33695

        No new tests (existing layout tests for EventSource should pass).

        * Android.v8bindings.mk:
        * WebCore.gypi:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/DOMObjectsInclude.h:
        * bindings/v8/DerivedSourcesAllInOne.cpp:
        * bindings/v8/V8DOMWrapper.cpp:
        * bindings/v8/V8DOMWrapper.h:
        * bindings/v8/V8Index.cpp:
        * bindings/v8/V8Index.h:
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8EventSourceConstructor.cpp: Added.
        * bindings/v8/custom/V8EventSourceCustom.cpp: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@53931 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1cdf0eee

2010-01-27 Kent Hansen <kent.hansen@nokia.com> · 387d6bbb

eric@webkit.org authored Jan 27, 2010

        Reviewed by Simon Hausmann.

        [Qt] Meta-methods can't be introspected using ES5 API
        https://bugs.webkit.org/show_bug.cgi?id=34087

        Add getOwnPropertyDescriptor() and getOwnPropertyNames() reimplementations.

        Tests are in WebKit/qt/tests/qwebframe

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
        (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyNames):
        (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):
        (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyNames):
        * bridge/qt/qt_runtime.h:
2010-01-27  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Meta-methods can't be introspected using ES5 API
        https://bugs.webkit.org/show_bug.cgi?id=34087

        Test that Object.getOwnPropertyDescriptor and
        Object.getOwnPropertyNames work with meta-methods.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@53930 bbb929c8-8fbe-4397-9dbb-9b2b20218538

387d6bbb

Rubberstamped by Simon Hausmann · 502c1d4c

kenneth@webkit.org authored Jan 27, 2010

[Qt] QtLauncher refactoring, separating utility methods.

* QtLauncher/QtLauncher.pro:
* QtLauncher/main.cpp:
* QtLauncher/utils.cpp: Added.
(urlFromUserInput):
* QtLauncher/utils.h: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@53929 bbb929c8-8fbe-4397-9dbb-9b2b20218538

502c1d4c

2010-01-27 Kwang Yul Seo <skyul@company100.net> · a2f9a603

eric@webkit.org authored Jan 27, 2010

        Reviewed by Eric Seidel.

        [BREWMP] Port WTF's randomNumber
        https://bugs.webkit.org/show_bug.cgi?id=33566

        Use GETRAND to generate 4 byte random byte sequence to implement
        weakRandomNumber. Create a secure random number generator with
        AEECLSID_RANDOM to implement randomNumber.

        * wtf/RandomNumber.cpp:
        (WTF::weakRandomNumber):
        (WTF::randomNumber):

git-svn-id: svn://svn.chromium.org/blink/trunk@53928 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a2f9a603

2010-01-27 Tony Chang <tony@chromium.org> · 85b92e07

eric@webkit.org authored Jan 27, 2010

        Reviewed by Eric Seidel.

        Fix a crash when trying to indent a block element that was contained
        in a list.  This was happening because enclosingBlock() in
        htmlediting.cpp can return the current the same Node when a block
        element (like an <hr> or a <table>) is passed in.  This causes
        the indent command to think that it is not in a list item.

        Work around this by checking to see if enclosingBlock returned the
        same Node.

        https://bugs.webkit.org/show_bug.cgi?id=32390

        * editing/execCommand/indent-block-in-list-expected.txt: Added.
        * editing/execCommand/indent-block-in-list.html: Added.
2010-01-27  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        Fix a crash when trying to indent a block element that was contained
        in a list.  This was happening because enclosingBlock() in
        htmlediting.cpp can return the current the same Node when a block
        element (like an <hr> or a <table>) is passed in.  This causes
        the indent command to think that it is not in a list item.

        Work around this by checking to see if enclosingBlock returned the
        same Node.

        https://bugs.webkit.org/show_bug.cgi?id=32390

        Test: editing/execCommand/indent-block-in-list.html

        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::tryIndentingAsListItem):

git-svn-id: svn://svn.chromium.org/blink/trunk@53927 bbb929c8-8fbe-4397-9dbb-9b2b20218538

85b92e07

2010-01-27 Kwang Yul Seo <skyul@company100.net> · c9a2c253

eric@webkit.org authored Jan 27, 2010

        Reviewed by Eric Seidel.

        [BREWMP] Port getCPUTime
        https://bugs.webkit.org/show_bug.cgi?id=33572

        Use GETUPTIMEMS which returns a continuously and
        linearly increasing millisecond timer from the time the device
        was powered on. This function is enough to implement getCPUTime.

        * runtime/TimeoutChecker.cpp:
        (JSC::getCPUTime):

git-svn-id: svn://svn.chromium.org/blink/trunk@53926 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c9a2c253

2010-01-27 Eric Seidel <eric@webkit.org> · 0d5b3383

eric@webkit.org authored Jan 27, 2010

        Reviewed by Darin Adler.

        webkit-patch needs an open-bugs command
        https://bugs.webkit.org/show_bug.cgi?id=30793

        * Scripts/test-webkitpy: import OpenBugsTest
        * Scripts/webkit-patch: import OpenBugs
        * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
        * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
        * Scripts/webkitpy/commands/queries_unittest.py: ditto
        * Scripts/webkitpy/commands/queues_unittest.py: ditto
        * Scripts/webkitpy/commands/upload_unittest.py: ditto
        * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.

git-svn-id: svn://svn.chromium.org/blink/trunk@53925 bbb929c8-8fbe-4397-9dbb-9b2b20218538

0d5b3383

[Qt] Add the "d" suffix to QtWebKit's dll on Windows. · fcf62666

jocelyn.turcotte@nokia.com authored Jan 27, 2010

Reviewed by Tor Arne Vestbø.

* WebKit.pri:

WebCore:

* WebCore.pro:

git-svn-id: svn://svn.chromium.org/blink/trunk@53924 bbb929c8-8fbe-4397-9dbb-9b2b20218538

fcf62666

[Qt] Qt port doesn't need platform dependent expected file anymore · c171445c

ossy@webkit.org authored Jan 27, 2010

for editing/pasteboard/paste-noscript-xhtml.html from r53873.

* platform/qt/editing/pasteboard/paste-noscript-xhtml-expected.txt: Removed.



git-svn-id: svn://svn.chromium.org/blink/trunk@53923 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c171445c

2010-01-27 Kwang Yul Seo <skyul@company100.net> · 2dd6d91b

eric@webkit.org authored Jan 27, 2010

        Reviewed by Oliver Hunt.

        [BREWMP] Add MarkStack fastMalloc implementation for platforms without VirtualAlloc or mmap.
        https://bugs.webkit.org/show_bug.cgi?id=33582

        Use fastMalloc and fastFree to implement MarkStack::allocateStack and
        MarkStack::releaseStack for platforms without page level allocation.

        * runtime/MarkStack.h:
        (JSC::MarkStack::MarkStackArray::shrinkAllocation):
        * runtime/MarkStackNone.cpp: Added.
        (JSC::MarkStack::initializePagesize):
        (JSC::MarkStack::allocateStack):
        (JSC::MarkStack::releaseStack):

git-svn-id: svn://svn.chromium.org/blink/trunk@53922 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2dd6d91b

2010-01-27 Kwang Yul Seo <skyul@company100.net> · 4140d491

eric@webkit.org authored Jan 27, 2010

        Reviewed by Eric Seidel.

        [BREWMP] Don't use time function
        https://bugs.webkit.org/show_bug.cgi?id=33577

        Calling time(0) in BREW devices causes a crash because time
        is not properly ported in most devices. Cast currentTime() to
        time_t to get the same result as time(0).

        * wtf/DateMath.cpp:
        (WTF::calculateUTCOffset):

git-svn-id: svn://svn.chromium.org/blink/trunk@53921 bbb929c8-8fbe-4397-9dbb-9b2b20218538

4140d491

[Qt] fast/backgrounds/animated-svg-as-background.html make... · 367db919

ossy@webkit.org authored Jan 27, 2010

[Qt] fast/backgrounds/animated-svg-as-background.html make fast/backgrounds/svg-as-background-5.html crash.
https://bugs.webkit.org/show_bug.cgi?id=34202

* platform/qt/Skipped: fast/backgrounds/animated-svg-as-background.html enabled because bug rolled out by r53912.



git-svn-id: svn://svn.chromium.org/blink/trunk@53920 bbb929c8-8fbe-4397-9dbb-9b2b20218538

367db919

Rubberstamped by Simon Hausmann · 8d4e5e65

kenneth@webkit.org authored Jan 27, 2010

[Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.

* QtLauncher/main.cpp:
(MainWindow::MainWindow):
* QtLauncher/webpage.cpp:
(WebPage::WebPage):
(WebPage::applyProxy):
* QtLauncher/webpage.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@53919 bbb929c8-8fbe-4397-9dbb-9b2b20218538

8d4e5e65

[Qt] Build fix for windows when QTDIR contains release libraries. · c4b9b00d

jocelyn.turcotte@nokia.com authored Jan 27, 2010

Unreviewed build fix

* WebKit.pri: Use the <name>.lib syntax for linking instead of qmake's -l<name> emulation

git-svn-id: svn://svn.chromium.org/blink/trunk@53918 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c4b9b00d

2010-01-27 Matt Perry <mpcomplete@chromium.org> · 912d0a81

eric@webkit.org authored Jan 27, 2010

        Reviewed by Eric Seidel.

        Fix a bug where dispatchDocumentElementAvailable was fired for fragment parsing on XML documents.
        https://bugs.webkit.org/show_bug.cgi?id=33920

        * userscripts/resources: Added.
        * userscripts/resources/blank.xhtml: Added.
        * userscripts/script-not-run-for-fragments-expected.txt: Added.
        * userscripts/script-not-run-for-fragments.html: Added.
        * userscripts/script-run-at-start-expected.txt: Added.
        * userscripts/script-run-at-start.html: Added.
2010-01-27  Matt Perry  <mpcomplete@chromium.org>

        Reviewed by Eric Seidel.

        Fix a bug where dispatchDocumentElementAvailable was fired for fragment parsing on XML documents.
        https://bugs.webkit.org/show_bug.cgi?id=33920

        Tests: userscripts/script-not-run-for-fragments.html
               userscripts/script-run-at-start.html

        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::XMLTokenizer::startElementNs):

git-svn-id: svn://svn.chromium.org/blink/trunk@53917 bbb929c8-8fbe-4397-9dbb-9b2b20218538

912d0a81

2010-01-27 Pavel Feldman <pfeldman@chromium.org> · c0dd2ef7

pfeldman@chromium.org authored Jan 27, 2010

        Reviewed by Timothy Hatcher.

        Web Inspector: Improve SourceHTMLTokenizer so that it treats script tag well.

        https://bugs.webkit.org/show_bug.cgi?id=34177

        * inspector/front-end/SourceHTMLTokenizer.js:
        (WebInspector.SourceHTMLTokenizer):
        (WebInspector.SourceHTMLTokenizer.prototype._isAttribute):
        (WebInspector.SourceHTMLTokenizer.prototype._isAttributeValue):
        (WebInspector.SourceHTMLTokenizer.prototype._setAttributeValue):
        (WebInspector.SourceHTMLTokenizer.prototype._setAttribute):
        (WebInspector.SourceHTMLTokenizer.prototype._stringToken):
        (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
        * inspector/front-end/SourceHTMLTokenizer.re2js:


git-svn-id: svn://svn.chromium.org/blink/trunk@53916 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c0dd2ef7

2010-01-27 Pavel Feldman <pfeldman@chromium.org> · 1f7675d0

pfeldman@chromium.org authored Jan 27, 2010

        Reviewed by Timothy Hatcher.

        Web Inspector: nuke quarantine wrappers.

        https://bugs.webkit.org/show_bug.cgi?id=34203

        * Android.jscbindings.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSInspectedObjectWrapper.cpp: Removed.
        * bindings/js/JSInspectedObjectWrapper.h: Removed.
        * bindings/js/JSInspectorCallbackWrapper.cpp: Removed.
        * bindings/js/JSInspectorCallbackWrapper.h: Removed.
        * bindings/js/JSQuarantinedObjectWrapper.cpp: Removed.
        * bindings/js/JSQuarantinedObjectWrapper.h: Removed.


git-svn-id: svn://svn.chromium.org/blink/trunk@53915 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1f7675d0

[Qt] Corrects debug build of DumpRenderTree on Windows. · 7643b344

jocelyn.turcotte@nokia.com authored Jan 27, 2010

Reviewed by Tor Arne Vestbø.

* DumpRenderTree/qt/DumpRenderTree.pro:

git-svn-id: svn://svn.chromium.org/blink/trunk@53914 bbb929c8-8fbe-4397-9dbb-9b2b20218538

7643b344

Fix a typo in ChangeLogs. · 1c1a0b4a

ap@apple.com authored Jan 27, 2010


git-svn-id: svn://svn.chromium.org/blink/trunk@53913 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1c1a0b4a

Revert r53899 (HashMap<AtomicStringImpl*, Value> key checks) and subsequent bug fixes, · 5f737e16

ap@apple.com authored Jan 27, 2010

        because they make SVG tests crash in release builds.



git-svn-id: svn://svn.chromium.org/blink/trunk@53912 bbb929c8-8fbe-4397-9dbb-9b2b20218538

5f737e16

[Qt] fast/backgrounds/animated-svg-as-background.html make... · 859c0caa

ossy@webkit.org authored Jan 27, 2010

[Qt] fast/backgrounds/animated-svg-as-background.html make fast/backgrounds/svg-as-background-5.html crash.
https://bugs.webkit.org/show_bug.cgi?id=34202

* platform/qt/Skipped: fast/backgrounds/animated-svg-as-background.html skipped until fix.



git-svn-id: svn://svn.chromium.org/blink/trunk@53911 bbb929c8-8fbe-4397-9dbb-9b2b20218538

859c0caa

2010-01-25 Philippe Normand <pnormand@igalia.com> · 6b0b160c

philn@webkit.org authored Jan 27, 2010

        Reviewed by Eric Seidel.

        autobuffer value not forwarded media element to MediaPlayer
        https://bugs.webkit.org/show_bug.cgi?id=33889

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::loadResource): Forward autobuffer
        value to MediaPlayer instance.
        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::load): Forward autobuffer and
        preservesPitch values to newly created platform media player instance.

git-svn-id: svn://svn.chromium.org/blink/trunk@53910 bbb929c8-8fbe-4397-9dbb-9b2b20218538

6b0b160c

2010-01-25 Philippe Normand <pnormand@igalia.com> · 1cdc097a

philn@webkit.org authored Jan 27, 2010

        Reviewed by Eric Seidel.

        [Gtk] media/video-reverse-play-duration.html fails on and off on Gtk buildbots
        https://bugs.webkit.org/show_bug.cgi?id=34086

        Cache media duration and fix didEnd() in case of reverse
        playback. When EOS was reached but in case of reverse playback the
        position is not always 0. So to not confuse the HTMLMediaElement
        we synchronize position and duration values.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::duration):
        (WebCore::MediaPlayerPrivate::updateStates):
        (WebCore::MediaPlayerPrivate::didEnd):
        (WebCore::MediaPlayerPrivate::durationChanged):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

2010-01-25  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Seidel.

        [Gtk] media/video-reverse-play-duration.html fails on and off on Gtk buildbots
        https://bugs.webkit.org/show_bug.cgi?id=34086

        * platform/gtk/Skipped: Unskip fixed test.

git-svn-id: svn://svn.chromium.org/blink/trunk@53909 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1cdc097a

* WebCore.xcodeproj/project.pbxproj: Actually land the change to add... · 36a23b49

ap@apple.com authored Jan 27, 2010

        * WebCore.xcodeproj/project.pbxproj: Actually land the change to add ContainerNodeAlgorithms.h
        (it's "svn resolved", not "svn revert"!).



git-svn-id: svn://svn.chromium.org/blink/trunk@53908 bbb929c8-8fbe-4397-9dbb-9b2b20218538

36a23b49

2010-01-26 Daniel Bates <dbates@webkit.org> · 56e18d84

dbates@webkit.org authored Jan 27, 2010

        Unreviewed. Made a minor typo when I added the test case fast/css/button-height.html
        to the GTK Skipped file. In changeset 53900, I added test "fast/css/button-height.htm"
        to the GTK Skipped file instead of "fast/css/button-height.html". See bug #33936
        for more details.

        * platform/gtk/Skipped:


git-svn-id: svn://svn.chromium.org/blink/trunk@53907 bbb929c8-8fbe-4397-9dbb-9b2b20218538

56e18d84

[Qt] Failing tests after r53895 skipped. · db745be9

ossy@webkit.org authored Jan 27, 2010

https://bugs.webkit.org/show_bug.cgi?id=34167

* platform/qt/Skipped: 
 - http/tests/history/redirect-301.pl
 - http/tests/history/redirect-302.pl
 - http/tests/history/redirect-303.pl
 - http/tests/history/redirect-307.pl



git-svn-id: svn://svn.chromium.org/blink/trunk@53906 bbb929c8-8fbe-4397-9dbb-9b2b20218538

db745be9

Unreviewed trivial fix. · cef7984a

ossy@webkit.org authored Jan 27, 2010

* platform/qt/editing/pasteboard/paste-noscript-xhtml-expected.txt: updated after r53873.



git-svn-id: svn://svn.chromium.org/blink/trunk@53905 bbb929c8-8fbe-4397-9dbb-9b2b20218538

cef7984a

More Windows build fixing. · dd0e675f

ap@apple.com authored Jan 27, 2010

        * win/tools/vsprops/common.vsprops: Disable warning C4180 (qualifier applied to function
        type has no meaning; ignored). This is a known bug - MSVC tries to compile a wrong
        specialization sometimes - but it's not instantiated, so it's harmless.



git-svn-id: svn://svn.chromium.org/blink/trunk@53904 bbb929c8-8fbe-4397-9dbb-9b2b20218538

dd0e675f

More Windows build fixing. · 66d8ab52

ap@apple.com authored Jan 27, 2010

        * wtf/HashTraits.h: _msize takes void*, remove const qualifier from type.



git-svn-id: svn://svn.chromium.org/blink/trunk@53903 bbb929c8-8fbe-4397-9dbb-9b2b20218538

66d8ab52

Windows build fix. · a20d9d3b

ap@apple.com authored Jan 27, 2010

        * wtf/HashTraits.h: Include malloc.h for _msize().



git-svn-id: svn://svn.chromium.org/blink/trunk@53902 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a20d9d3b

Build fix. · 697ea931

ap@apple.com authored Jan 27, 2010

        * wtf/HashTable.h: (WTF::HashTable::checkTableConsistencyExceptSize): Remove const from a
        static (empty) version of this function.



git-svn-id: svn://svn.chromium.org/blink/trunk@53901 bbb929c8-8fbe-4397-9dbb-9b2b20218538

697ea931

2010-01-26 Daniel Bates <dbates@webkit.org> · 43fcba7f

dbates@webkit.org authored Jan 27, 2010

        Unreviewed. Updated expected failing results for table-percent-height.html
        to reflect one pixel difference between the results generated by the Qt bot
        and my machine. Added failing test fast/css/button-height.html to GTK Skipped
        file as we need to look into this. See bug #33936 for more details.

        * platform/gtk/Skipped: Added failing test fast/css/button-height.html.
        * platform/qt/fast/replaced/table-percent-height-expected.txt: Updated result.


git-svn-id: svn://svn.chromium.org/blink/trunk@53900 bbb929c8-8fbe-4397-9dbb-9b2b20218538

43fcba7f

Reviewed by Darin Adler. · 7f8c270a

ap@apple.com authored Jan 27, 2010

        https://bugs.webkit.org/show_bug.cgi?id=34150
        WebKit needs a mechanism to catch stale HashMap entries

        It is very difficult to catch stale pointers that are HashMap keys - since a pointer's hash
        is just its value, it is very unlikely that any observable problem is reproducible.

        This extends hash table consistency checks to check that pointers are referencing allocated
        memory blocks, and makes it possible to invoke the checks explicitly (it is not feasible
        to enable CHECK_HASHTABLE_CONSISTENCY by default, because that affects performance too much).

        * wtf/HashMap.h: (WTF::::checkConsistency): Call through to HashTable implementation. We can
        add similar calls to HashSet and HashCountedSet, but I haven't seen hard to debug problems
        with those yet.

        * wtf/HashSet.h: (WTF::::remove): The version of checkTableConsistency that's guarded by
        CHECK_HASHTABLE_CONSISTENCY is now called internalCheckTableConsistency().

        * wtf/HashTable.h:
        (WTF::HashTable::internalCheckTableConsistency):
        (WTF::HashTable::internalCheckTableConsistencyExceptSize):
        (WTF::HashTable::checkTableConsistencyExceptSize):
        Expose checkTableConsistency() even if CHECK_HASHTABLE_CONSISTENCY is off.
        (WTF::::add): Updated for checkTableConsistency renaming.
        (WTF::::addPassingHashCode): Ditto.
        (WTF::::removeAndInvalidate): Ditto.
        (WTF::::remove): Ditto.
        (WTF::::rehash): Ditto.
        (WTF::::checkTableConsistency): The assertion for !shouldExpand() was not correct - this
        function returns true for tables with m_table == 0.
        (WTF::::checkTableConsistencyExceptSize): Call checkValueConsistency for key. Potentially,
        we could do the same for values.

        * wtf/HashTraits.h:
        (WTF::GenericHashTraits::checkValueConsistency): An empty function that can be overridden
        to add checks. Currently, the only override is for pointer hashes.

        * wtf/RefPtrHashMap.h: (WTF::::remove): Updated for checkTableConsistency renaming.



git-svn-id: svn://svn.chromium.org/blink/trunk@53899 bbb929c8-8fbe-4397-9dbb-9b2b20218538

7f8c270a

2010-01-26 Yaar Schnitman <yaar@chromium.org> · ca0e3e27

eric@webkit.org authored Jan 27, 2010

        Reviewed by Darin Fisher.

        Add KeyboardTest to WebKit API tests
        https://bugs.webkit.org/show_bug.cgi?id=34178

        * WebKit.gyp:
        * tests/KeyboardTest.cpp: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@53898 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ca0e3e27

2010-01-26 Daniel Bates <dbates@webkit.org> · 988df85e

dbates@webkit.org authored Jan 27, 2010

        Reviewed by Tor Arne Vestbø.

        https://bugs.webkit.org/show_bug.cgi?id=29564

        [Qt] Fixes an issue where the height of <button>- and
        <input type="button">- elements are fixed to the height of the
        button label font plus padding. That is, the CSS height property
        is being ignored.

        Instead, we should honor the user-specified height, if appropriate
        for the platform and context. Notice, the Mac ports do not honor the
        height for <input type="button"> elements unless a border and/or
        background is also specified.

        Test: fast/css/button-height.html

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::adjustButtonStyle):
2010-01-26  Daniel Bates  <dbates@webkit.org>

        Reviewed by Tor Arne Vestbø.

        https://bugs.webkit.org/show_bug.cgi?id=29564

        Tests that the user-specified height for <button>- and <input type="button">-
        elements are honored, if appropriate for the platform and context.

        * fast/css/button-height-expected.txt: Added.
        * fast/css/button-height.html: Added.
        * fast/replaced/table-percent-height-expected.txt: Added notice about failing tests
        in Windows ports.
        * fast/replaced/table-percent-height.html: Ditto.
        * platform/qt/fast/replaced/table-percent-height-expected.txt: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@53897 bbb929c8-8fbe-4397-9dbb-9b2b20218538

988df85e