- 27 Nov, 2019 40 commits
-
-
Kamila authored
These strings are updated or added according to the latest iterations with UX, for the Notifications settings page. Bug: 986737 Change-Id: I2898a074a3c6973d9158133255cbc232f9988308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937168 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#719565}
-
Rob Buis authored
In r716655 new display attribute values math and inline-math were introduced but they should also have been added to PlatformEnumToCSSValueID to prevent running into a NOTREACHED. Bug: 6606 Change-Id: Ic0a7c43389731aaf72ab075719cb83d3e75a45d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939787Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#719564}
-
Stephen Nusko authored
Fix the INTERNAL_UID macro so it actually appends the value of __LINE__ rather then the string "__LINE__" Add a test to catch it. And also switch to the same implementation as the client library with the in parameter. Change-Id: I94b775e6692fe88a14efc7c6030c280057012935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939971 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#719563}
-
Koji Ishii authored
It looks like we tried to copy the logic in |LayoutObject:: NodeForHitTest| to |NGPaintFragment|. As part of deprecating |NGPaintFragment|, this patch moves it to |NGPhysicalFragment|, using the existing logic in |LayoutObject|. In future, this logic might be moved to |Node| or something that represents the box tree. Until then, using the logic in |LayoutObject| looks most reasonable. Bug: 982194 Change-Id: Ib6b967dc616714eb2cb1a16585493d106c44c504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937953Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#719562}
-
Oriol Brufau authored
The interaction of a ::marker pseudo-element with a 'content' property and the ::first-line of the list-item produced a DCHECK failure in debug builds (it was fine with debug disabled). This patch fixes it. Bug: 457718 TEST=external/wpt/css/css-pseudo/first-line-and-marker.html Change-Id: I443934f3a5cbfd95913287ac2bfb0966fa707e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937068Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#719561}
-
Mikhail Khokhlov authored
Build directories on bots follow more or less unified naming scheme, so it's possible to guess the path to the trace processor. Bug: 1028612 Change-Id: I6065fc2bac2ca23dcdf9363b4defb43b7cb8d22d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936314 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#719560}
-
Michael van Ouwerkerk authored
Bug: 1028949 Change-Id: I4a3d9296649c6bd52a8fc7d5d38b793945a6b35c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932551 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#719559}
-
Reilly Grant authored
This change updates usage of base::Callback to explicitly choose between base::OnceCallback and base::RepeatingCallback based on whether the callback will be executed repeatedly or not. Bug: 1007663 Change-Id: I058632afae3e14f14f1c51b9b4fe251b9011eb2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937353 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#719558}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c363982eeab3..e14cb994086d git log c363982eeab3..e14cb994086d --date=short --first-parent --format='%ad %ae %s' 2019-11-27 peah@webrtc.org Correct/update the activation of the multi-channel processing in APM Created with: gclient setdep -r src/third_party/webrtc@e14cb994086d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If7f5a6540348a3dfbbc6062a0ba6611b04e95d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939887Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719557}
-
Stepan Khapugin authored
Adds a code path for no default match case for the left image to be set to the default search image. Also adds a EG test for tapping on the omnibox with something in clipboard that verifies that the clipboard match (which isn't a default match) on NTP appears but doesn't populate text in the omnibox (not being default), and therefore tests that the app doesn't crash. Bug: 1024885, 1027561 Change-Id: I7242a537d919a6d3a6a4048ddf59a3249cb862f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939970 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#719556}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f1c7d33e..d21964d6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2562f6137b0c20ca5ffeaf0dbb6b3ab6d2428ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939519Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719555}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b35d2f479cd6..35e1a0ce9060 Created with: gclient setdep -r src-internal@35e1a0ce9060 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I23632af4c237f663ad0a9025d9eed4db7c4f020c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939669Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719554}
-
Tim Schumann authored
We are suspecting Chrome clients to leak FCM registrations. This patch identifies a few suspicious places and instruments them so that we can verify hypothesis and prioritize. Bug: 1028594 Change-Id: Ie457332073c8fd0763db20278e4f40d2254b10f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937031 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Auto-Submit: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#719553}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5462a762c28a..fec12b8a43a1 git log 5462a762c28a..fec12b8a43a1 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 dberris@chromium.org Fix builder names to conform to rules Created with: gclient setdep -r src/third_party/catapult@fec12b8a43a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:985223 Tbr: rmhasan@google.com Change-Id: I569792c63554ef663e81e0113ef3dcd089efdd5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939668Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS orderfile from 80-3943.1-1572866479-benchmark-80.0.3961.0-r1 to 80-3945.24-1574073604-benchmark-80.0.3964.0-r2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0feabe283f2164083e527616a5b1c144716fd5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939947Reviewed-by:
-
Artem Sumaneev authored
Make EnrollmentHandlerChromeOS ignore errors from DeviceSettingsService via DeviceCloudPolicyStoreChromeOS while enrollment is in progress and policies are not stored yet. Bug: 1001822 Change-Id: Id0670e4adf2baa763a2582fcdd1b679e0e2d315e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932789Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Artem Sumaneev <asumaneev@google.com> Cr-Commit-Position: refs/heads/master@{#719550}
-
Monica Basta authored
We get a crash in the |signin_email_confirmation_ui| due to a |DCHECK| |HasUnexpectedPlaceholder()|that checks that the replacement does not have an unsubstituted placeholder. The |DCHECK| runs before some of the placeholders get replaced by JavaScript. To avoid this crash, we remove the placeholders from |signin_email_confirmation.html| and rely on JavaScript to replace correctly the text. Change-Id: Ib56b8fbc4ae0d042ecffb53912a111a4964afb11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878769Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#719549}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: Ieda60fcfd3fc525d679d29b0f8665004abc8e730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929822 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#719548}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ccea71d219ed..5462a762c28a git log ccea71d219ed..5462a762c28a --date=short --first-parent --format='%ad %ae %s' 2019-11-27 crouleau@chromium.org [Telemetry] Fix misleading output log in story_filter. Created with: gclient setdep -r src/third_party/catapult@5462a762c28a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:965158 Tbr: rmhasan@google.com Change-Id: Ic02d9f85c54c5686c76a63070edb699fac4ba762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938311Reviewed-by:
-
Fabian Sommer authored
Bug: 1027987 Change-Id: I5b4c779717217a40807475a48b74529752cb0f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936292Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@google.com> Cr-Commit-Position: refs/heads/master@{#719546}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: I7f05d10a5cb92c8c0ef003e7d47c0fac71e3b322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930739Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#719545}
-
Fredrik Söderquist authored
Bug: 1021630 Change-Id: I50f835362b404f7c5e8828d70581078b7145f322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937067 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#719544}
-
Chih-Yu Huang authored
This CL removes all BindToCurrentLoop usage in ImageProcessor and its children classes. Also, we add client task runner and its sequence checker to make sure ImageProcessor's methods and callbacks are called on the correct sequence. Bug: 1004727 Test: pass video_decode_accelerator_tests and video_encode_accelerator_unittest on Kukui and Hana Test: Run image_processor_test on Eve and Kevin and confirm no sequence check failure Change-Id: I73f85a7fccf76a62e8546b98add429ed7e692048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937958 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#719543}
-
Luca Hunkeler authored
Change the way we handle accessibility strings to that there are three options: not set -> the default description is used empty string -> the view is ignored by accessibility non-empty string -> the string is used as description Bug: b/143757329 Change-Id: I39cd9bf4a634fa7482c485320d2a81d8513eb935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926590 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#719542}
-
Robbie Gibson authored
On iOS, if there is no text in the Omnibox text field, the "Go" button and the return key (on bluetooth keyboards) are disabled. This means that when using the keyboard to select matches, the return key doesn't work for the clipboard matches because no text is filled into the omnibox. This adds the following fill_into_edit: URL match -> URL text match -> Text image match -> Search Copied Image (the same as the match's description) Fixed: 1026595 Change-Id: I04686bc4b0cd38651d33b54113c97001a3a30eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937074 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
-
Jinho Bang authored
Spec change: https://github.com/gpuweb/gpuweb/pull/496 Bug: 852089 Change-Id: I0b786ebaf3cb4084ecf755c9175c2fe51d9eca22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936693 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#719540}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ddbe56c4721c..ccea71d219ed git log ddbe56c4721c..ccea71d219ed --date=short --first-parent --format='%ad %ae %s' 2019-11-27 fancl@chromium.org Migrate Pinpoint to a Single-Page-Application 2019-11-27 dberris@chromium.org Update build steps to allow subsetting tests Created with: gclient setdep -r src/third_party/catapult@ccea71d219ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1027975,chromium:985223 Tbr: skyostil@google.com Change-Id: I7696382f51786f37a0028a37f8cd769492d91b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938492Reviewed-by:
-
Peter Marshall authored
The devtools backend receives and will handle protocol messages in order, but there is no guarantee of ordering with other non-protocol things. This is true for content::ExecJs. This test sent a Runtime.Evaluate message over the devtools protocol and then called ExecJs. Due to the way scheduling is handled in the devtools backend, it's possible that the ExecJs code runs before the protocol message is handled by the backend. Callers can get around this by waiting for the first Runtime.Evaluate call to finish and then only continuing in the callback provided. In this case, the first JS evaluation sets up a promise that will only resolve once the second JS evaluation happens, so that won't work. The solution here is to use a second Runtime.Evaluate call, which does have an ordering guarantee with the first. Upcoming changes to the scheduling uncovered this as a flake on the trybots. Change-Id: I643539d094407a43b4ffff17dd052e5f49e3e44e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939409Reviewed-by:
-
Yutaka Hirano authored
Bug: 1028936 Change-Id: Ia607a4e4a46cbfa2f1b7f3003a70677d779115a5 Tbr: calamity@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939084Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#719537}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/882115da6b31..2a8799ff0874 git log 882115da6b31..2a8799ff0874 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 herb@google.com Revert "Naive CPU large emoji" 2019-11-27 herb@google.com Make SkEnumerate make flatten tuples 2019-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 92fe999a..c493edcc (509 commits) 2019-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f65b212492ec..c373dfd84194 (8 commits) 2019-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f2637d0dd7eb..663dcefa22ea (3 commits) 2019-11-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-26 ethannicholas@google.com SkSL now handles sk_Caps in include files 2019-11-26 herb@google.com Naive CPU large emoji 2019-11-26 reed@google.com hide deprecated next() on SkPath::Iter 2019-11-26 egdaniel@google.com Make sure we recycle the secondary command buffers when release primary command buffers. 2019-11-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-26 jlavrova@google.com Bug fixes 2019-11-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-26 benjaminwagner@google.com [infra] Upgrade NVIDIA driver 2019-11-26 egdaniel@google.com Return a size of 0 for external format GrSurfaces. 2019-11-26 egdaniel@google.com Cleanup GrVkCommandBuffer resource ownership and freeing. 2019-11-26 robertphillips@google.com Move the initial GrProgramDesc keyLength into the header 2019-11-26 benjaminwagner@google.com [infra] Upgrade Intel Skylake driver 2019-11-26 jvanverth@google.com Enable cross-context textures in Metal. 2019-11-26 fmalita@chromium.org [skottie] Handle null mask filter effects gracefully Created with: gclient setdep -r src/third_party/skia@2a8799ff0874 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None,chromium:None,chromium:None Tbr: bungeman@google.com Change-Id: Ia22c545462d90591cd73a6ea88c358ce10e54079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939228Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: If407e9bffa32b10a056e5a01f962d2eb41ea30b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938444Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719535}
-
Yuki Shiino authored
Implements the core part of overload resolution. Bug: 839389 Change-Id: If1281a7df2f4adf08968f6b361c5d43ef5999a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906453Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#719534}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b00449ac4016..34267f83deb7 git log b00449ac4016..34267f83deb7 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 tandrii@google.com Revert "Release new bb tool @ 1b9c7d3e8bacc3100d0f81c96825756e6f48a293." Created with: gclient setdep -r src/third_party/depot_tools@34267f83deb7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1028420 Tbr: agable@chromium.org Change-Id: I19c1ad3c2767da8911ea04b6c58fb5aaddc9aa0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939467Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/39e2ad23d608..b35d2f479cd6 Created with: gclient setdep -r src-internal@b35d2f479cd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I61e0676955d2ec37b984a5f17a821809d02bf402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939468Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/85f3e93d13f3..f31f26f73930 git log 85f3e93d13f3..f31f26f73930 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 headlessclayton@gmail.com utils/vscode: Add install.bat (#3071) 2019-11-26 52076061+digit-google@users.noreply.github.com build: cmake: Add support for Fuchsia. (#3062) 2019-11-26 dneto@google.com Add test with explicit example of stripping reflection info (#3064) 2019-11-26 9856269+sarahM0@users.noreply.github.com Permit the debug instructions in WebGPU SPIR-V (#3063) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@f31f26f73930 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I8ff921fe29c1c4a5e442da050a072ca0bdc5c430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938446Reviewed-by:
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL moves COEP and relevant functions from ServiceWorkerProviderHost to ServiceWorkerContainerHost. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I4a3c0fce12308bb95dbcb4b4b3babe5d49aebdca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939151 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#719530}
-
Luciano Pacheco authored
Change the way to hide Open button to use isModal state, instead of changing the semantics of the property |hasTask|, so keep |hasTask| meaning that the file has tasks. Add |isModal| property to <files-quick-view> to be able to hide the OPEN button when in a modal dialog. Change the OPEN button |hidden| condition to check for isModal attribute. Convert some variable definitions to const as forced by presubmit. Test: browser_tests --gtest_filter="*openQuickViewInFileDialog*" Bug: 948605 Fixed: 948605 Change-Id: I1c0c5f6c0178d258ec5d1a2f72b076cded0f8adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935276 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#719529}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f848256008f5..781bb85e9698 git log f848256008f5..781bb85e9698 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 85f3e93d13f3..f31f26f73930 (4 commits) Created with: gclient setdep -r src/third_party/angle@781bb85e9698 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: cwallez@google.com Change-Id: Ib6cdfc3536c4107122e7c9bea70d5176a67fcc14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938445Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=flackr@chromium.org Bug: 1023677 Change-Id: I0ca135cdf0f186623355b0cc3c7e2beefe342dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926907 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
-
Yutaka Hirano authored
It was marked as failing, but https://crrev.com/b71bef1cb23070af161d251d9188ea153bed67d8 removed the expectation. Since the flakiness persists, let's recover the expectation. Bug: 833100 Change-Id: If5f3d61e9cebb3fa9542ddbcf5f971a67340f8f6 No-Try: True Tbr: timvolodine@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939137Reviewed-by:
-
