GitLab

The web speech synthesis API was correctly passing through an utterance's
rate, pitch, and volume to native TTS, but not to extension-based speech.
This fixes the bug, and I filed another bug to clean up the redundancy that
led to this bug being there.

BUG=376280

Review URL: https://codereview.chromium.org/969913002

Cr-Commit-Position: refs/heads/master@{#320946}

Adding an example multi-machine test for Chromoting. This example starts a test controller machine which then starts a dedicated task machine to run the browser_tests_launcher on. The output is then streamed back to the test controller to be logged and the output (pass or fail) is mirrored on the test controller. This is a simple example of how to write and run multi-machine tests using the Legion framework.

BUG=467620

Review URL: https://codereview.chromium.org/1012883002

Cr-Commit-Position: refs/heads/master@{#320945}

BUG=437865

Review URL: https://codereview.chromium.org/1018613002

Cr-Commit-Position: refs/heads/master@{#320944}

The current focus rectangle logic is wrong -- it's always drawn
outside of local bounds, which is not drawn actually. The expected
behavior is to draw the focus rectangle around the actual text.

BUG=467510
R=sky@chromium.org
TEST=the new test case covers

Review URL: https://codereview.chromium.org/1018463004

Cr-Commit-Position: refs/heads/master@{#320943}

BUG=456004
TEST=gpu_unittests, about:gpu page
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/1018463002

Cr-Commit-Position: refs/heads/master@{#320942}

Current string: Signed in as [email]. Manage your synced data on Google Dashboard
New strings: Signed in as [email]. Manage your synced data and devices on Chrome Dashboard

BUG=402615

Manual test:
launch chrome by chrome --force-fieldtrials="ChromeDashboard/Enabled/"
log in chrome, and then go to settings, on the top of settings, there should be the new string, click the "Chrome Dashboard", it should bring you to URL("https://google.com/settings/chrome/sync").

Review URL: https://codereview.chromium.org/998413003

Cr-Commit-Position: refs/heads/master@{#320941}

Events exposed through inputMethodPrivate extension API.

BUG=455026

Review URL: https://codereview.chromium.org/973213003

Cr-Commit-Position: refs/heads/master@{#320940}

This CL is the first step toward support for third-party VPNs in ash UI.
t adds a delegate interface that ash UI will use to retrieve the list
of available VPN providers and request that a VPN provider show its "add
network" dialog.

The CL was tested together with follow-up CLs which wire up the actual
UI.

BUG=460428
TEST=Manual, together with follow-ups that wire up the UI

Review URL: https://codereview.chromium.org/984863005

Cr-Commit-Position: refs/heads/master@{#320939}

Revert of Enable Surfaces on Android (try #3)  (patchset #1 id:1 of https://codereview.chromium.org/1001203002/)

Reason for revert:
Speculative revert as it seems to be causing a big regression in input_latency/thread_time_cpu_per_frame

BUG=467978

Original issue's description:
> Enable Surfaces on Android (try #3)
>
> The browser compositor contents and renderer contents are each put into separate Surfaces which are aggregated together by a Display.
>
> BUG=449319
>
> Committed: https://crrev.com/8da5f9f03e955304716977004fd4ba1168869aca
> Cr-Commit-Position: refs/heads/master@{#320826}

TBR=sievers@chromium.org,jbauman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=449319

Review URL: https://codereview.chromium.org/1015813002

Cr-Commit-Position: refs/heads/master@{#320938}

If we don't do this, then we have a race condition between unloading
this extension, and trying to use it because we have manually
navigated to it.

BUG=460431

Committed: https://crrev.com/1805c4c5c4b5292cca51a54f379cde498db7238b
Cr-Commit-Position: refs/heads/master@{#318140}

Review URL: https://codereview.chromium.org/961443003

Cr-Commit-Position: refs/heads/master@{#320937}

Add a "clear-data-reduction-proxy-data-savings" flag, which when
enabled will clear out data savings statistics on startup.

BUG=461022

Review URL: https://codereview.chromium.org/1010083002

Cr-Commit-Position: refs/heads/master@{#320936}

Also
 - makes the callback to finishAuthentication optional
 - adds the "Important: This API works only on Chrome OS."
   banner to the documentation page.

BUG=432280

Review URL: https://codereview.chromium.org/1002243002

Cr-Commit-Position: refs/heads/master@{#320935}

Refactor history loading, eliminating the obsolete (and even obstructionist) ChromeSyncFileEntryProvider.
This CL updates the entire stack with support for multiple history files, but doesn't yet load all history files. That support will come in a subsequent change.
Remove extra "." qualifier in most instance of "Promise.<" and "Array.<" in affected files only.

TEST=*ImportHistory*

Review URL: https://codereview.chromium.org/1013893002

Cr-Commit-Position: refs/heads/master@{#320934}

1. VideoCaptureControllerID is a struct inside VCCEventHandler, just
to wrap an int. It also defines operator< and operator== to enable
using it in std::map. This is not needed, so I replaced it with a
typedef int VideoCaptureControllerID;

And s/const VideoCaptureControllerID&/VideoCaptureControllerID/

This enabled VideoCaptureControllerEventHandler to become a
pure interface. Removed video_capture_controller_event_handler.cc.

2. VideoCaptureHost lives 100% in IO Thread, except ctor in UI thread.
There's this idiom on IPC message sending where there's two
methods OnBla() -> PostTask to DoBla() on IO -> Send msg.
But all methods are living on IO and Send is asynchronous anyway,
so those DoBla() dealing with Send() are folded into OnBla()
methods -- trhose remain they mean basically a sophisticated
DeleteLater().

3. A few methods use base::TimeTicks as param, when they can
use const base::TimeTicks&, replaced them (one less copy in the
critical capture path).

BUG=440843

Review URL: https://codereview.chromium.org/1017503002

Cr-Commit-Position: refs/heads/master@{#320933}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a537ab2..2f002c7

TBR=rtoy@chromium.org,pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1008343005

Cr-Commit-Position: refs/heads/master@{#320932}

Cr-Commit-Position: refs/heads/master@{#320931}

Should fix the "D-Bus library appears to be incorrectly set up; failed to read
machine uuid" messages.

BUG=467901
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1008873004

Cr-Commit-Position: refs/heads/master@{#320930}

BUG=369661
TEST=none

Review URL: https://codereview.chromium.org/1013203002

Cr-Commit-Position: refs/heads/master@{#320929}

The origin now is included, and Blink has been updated to pass it in.

This is part of a three-sided patch:
  [1] https://codereview.chromium.org/982313002/
  [2] https://codereview.chromium.org/985063002/
  [3] This patch.

BUG=447628

Review URL: https://codereview.chromium.org/985693004

Cr-Commit-Position: refs/heads/master@{#320928}

It does enable Permissions.query() in Document and Worker context.

It is using the mojo pipe associated to the RenderFrameImpl or BlinkPlatformImpl
so the PermissionManager doesn't need to know in which context it lives.
However, it needs to do some thread jumping to be back in the main thread.

This is based on top of https://codereview.chromium.org/804553003

BUG=437770

Review URL: https://codereview.chromium.org/801613004

Cr-Commit-Position: refs/heads/master@{#320927}

BUG=

Review URL: https://codereview.chromium.org/912863002

Cr-Commit-Position: refs/heads/master@{#320926}

Make HttpStreamFactoryImpl::GetAlternateProtocolRequestFor() return
AlternativeService instead of AlternateProtocolInfo, and rename it to
GetAlternativeServiceRequestFor.  Also change the type and name of
HttpStreamFactoryImplJob.{,other_job_}alternate_protocol_.

BUG=392576

Review URL: https://codereview.chromium.org/1011013002

Cr-Commit-Position: refs/heads/master@{#320925}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/493c1ce..cdeca44

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1012043003

Cr-Commit-Position: refs/heads/master@{#320924}

The new callback (aptly named OnReceivedError2) is also called for
subresource load failures and provides more information about
the failed request.

Note that calling OnReceivedError2 is not yet implemented for requests
blocked due to security considerations by Blink. This will be
implemented separately.

BUG=456782

Review URL: https://codereview.chromium.org/1001003004

Cr-Commit-Position: refs/heads/master@{#320923}

GetSuccessorId and GetPredecessorId access all children of the
current node's parent in order to get to the next/previous node.
With implicit parent ID these functions can't get to the parent.
The reasons we didn't run into this problem before are
a) The server feature that will stop setting parent ID isn't
   enabled yet so there wasn't a chance to expose this yet.
b) There wasn't enough test coverage.

The fix is to use the ParentChildIndex to resolve the implicit
(unset) parent ID. Added a new method called GetSiblings at
the Directory level that does just that. Also added some
unit test coverage.

BUG=438313

Review URL: https://codereview.chromium.org/1008993004

Cr-Commit-Position: refs/heads/master@{#320922}

Fixes audio issue on Mac for USB headsets where kAudioUnitErr_TooManyFramesToProcess can be returned for a few frames at startup.

BUG=466954
TEST=Manual tests of WebRTC clients and different USB headsets.

Review URL: https://codereview.chromium.org/1017683002

Cr-Commit-Position: refs/heads/master@{#320921}

BUG=467059

Review URL: https://codereview.chromium.org/1013173002

Cr-Commit-Position: refs/heads/master@{#320920}

TBR=aboxhall@chromium.org
BUG=467921

Review URL: https://codereview.chromium.org/1014543006

Cr-Commit-Position: refs/heads/master@{#320919}

ScoredHistoryMatch::Builder was introduced to allow keeping ScoredHistoryMatch
in the history component without having a dependency on autocomplete code. As
ScoredHistoryMatch has been moved to chrome/browser/autocomplete this makes
the code more complex than necessary, so remove it.

BUG=462645

Review URL: https://codereview.chromium.org/976423002

Cr-Commit-Position: refs/heads/master@{#320918}

TBR=dbeam@chromium.org
BUG=467916

Review URL: https://codereview.chromium.org/1012073002

Cr-Commit-Position: refs/heads/master@{#320917}

BUG=467673

Review URL: https://codereview.chromium.org/1007383004

Cr-Commit-Position: refs/heads/master@{#320916}

The copy constructor was changed (in CL
https://codereview.chromium.org/853503002/) to allow a WeakNSObject to
be copied on a different thread.
This CL is making the assignment operator behave consistently with the
copy constructor: it is now allowed to assign a WeakNSObject on a
different thread.

In any case, dereferencing the WeakNSObject on another thread remains
disallowed.

BUG=394008

Review URL: https://codereview.chromium.org/1014813002

Cr-Commit-Position: refs/heads/master@{#320915}

This follows the very same pattern as the read and write methods, but does
so for deleting notifications instead. Note that the notification database
still isn't hooked up to production code, but is covered by a broad
series of unit tests.

Design document:
  http://goo.gl/TciXVp

BUG=447628

Review URL: https://codereview.chromium.org/1008003003

Cr-Commit-Position: refs/heads/master@{#320914}

BUG=440843

Review URL: https://codereview.chromium.org/1015473003

Cr-Commit-Position: refs/heads/master@{#320913}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c31ed491..2a8ff45e

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1014543005

Cr-Commit-Position: refs/heads/master@{#320912}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d0a840d..493c1ce

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1012043002

Cr-Commit-Position: refs/heads/master@{#320911}

Extracted part 3 of
https://codereview.chromium.org/190693002/

BUG=242405

Review URL: https://codereview.chromium.org/914183002

Cr-Commit-Position: refs/heads/master@{#320910}

needs https://codereview.chromium.org/1013803002/ to land and roll into chrome.

BUG=

Review URL: https://codereview.chromium.org/1011683006

Cr-Commit-Position: refs/heads/master@{#320909}

The RendererScheduler needs to be shutdown before the MessageLoop. Previously
this was the case as blink was shutdown before the message loop, however now
the message loop is shutdown first. This CL ensures that the renderer
scheduler is shutdown just before the message loop.

BUG=467369

Review URL: https://codereview.chromium.org/1014643002

Cr-Commit-Position: refs/heads/master@{#320908}

BUG=405038

Review URL: https://codereview.chromium.org/956363002

Cr-Commit-Position: refs/heads/master@{#320907}