GitLab

We take away the controller when we suspend, but never successfully
give it back to window_delegate on resume because it's expected to be
in enabled state. The result was mouse cursor not getting reset on
resume.

BUG=446184
NOTRY=true

Review URL: https://codereview.chromium.org/845303004

Cr-Commit-Position: refs/heads/master@{#311581}

With the changes to make the Data Reduction Proxy a best
effort proxy, AreDataReductionProxiesBypassed should
take the Data Reduction Proxy config rather than use the
request's proxy service config.

BUG=448477

Review URL: https://codereview.chromium.org/848103002

Cr-Commit-Position: refs/heads/master@{#311580}

BUG=448836
TEST=None

Review URL: https://codereview.chromium.org/829643003

Cr-Commit-Position: refs/heads/master@{#311579}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d8d613c..a705d7d

TBR=zmo@chromium.org,yutak@chromium.org

Review URL: https://codereview.chromium.org/840133004

Cr-Commit-Position: refs/heads/master@{#311578}

Lock pixels before using them

BUG=446347

Review URL: https://codereview.chromium.org/850043002

Cr-Commit-Position: refs/heads/master@{#311577}

The prior revert (ca6c8754) of the leveldb manifest reuse change (de701abe) was
insufficient because there appears to be a bug in leveldb where it fails to
consult the reuse_logs option. So if the Env has a working NewAppendableFile
method then leveldb will always try to reuse it's manifest. Deleting our
version of this function so that the base Env implementation will be called
(which fails forcing no-reuse).

BUG=402980, 395799

Review URL: https://codereview.chromium.org/852073002

Cr-Commit-Position: refs/heads/master@{#311576}

https://codereview.chromium.org/794923003/ had a few problems:
 - it broke uiautomator test output parsing
 - it had a typo in InstrumentationTestInstance
 - it had an error in how it handles instrumentation's test dict objects

BUG=428729

Review URL: https://codereview.chromium.org/854733002

Cr-Commit-Position: refs/heads/master@{#311575}

With the additional targets in Chromoting (Android, iOS and AppRemoting), the
check to verify that each string is being used produces lots of noise because
it is difficult to identify which strings should be used in each target.

It is non-trivial to handle all these cases cleanly with our current approach
so we'll need to disable these checks and re-visit how we want to handle
them.

BUG=448175

Review URL: https://codereview.chromium.org/848043002

Cr-Commit-Position: refs/heads/master@{#311574}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/7c348a8..89069a9

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/847243004

Cr-Commit-Position: refs/heads/master@{#311573}

Modeled after the Data Saver page. UI is preliminary. Full review from UX team and improvements to come.

BUG=446700

Review URL: https://codereview.chromium.org/847023002

Cr-Commit-Position: refs/heads/master@{#311572}

NOTRY=true

Review URL: https://codereview.chromium.org/827923007

Cr-Commit-Position: refs/heads/master@{#311571}

This restricts the availability of obfuscated GAIA ID
info (from chrome.identity.getProfileUserInfo) to apps
which specify the identity.email manifest permission.

BUG=415641

Review URL: https://codereview.chromium.org/784283006

Cr-Commit-Position: refs/heads/master@{#311570}

BUG=None
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/817983004

Cr-Commit-Position: refs/heads/master@{#311569}

As is described in http://crbug.com/440551#c28, the cache size
64 isn't big enough in ChromeOS, usually ChromeOS has fonts as much
as 100. Unsupported glyph can run out this cache with a single
character.

BUG=440551
R=derat@chromium.org, ckocagil@chromium.org
TBR=asvitkine@chromium.org
TEST=open data:text/html;charset=UTF8,<title>a%E2%9C%A8</title> and
  see the slowness around drawing has gone.

Review URL: https://codereview.chromium.org/796623005

Cr-Commit-Position: refs/heads/master@{#311568}

This allows a preferred signal strategy (currently always XMPP) to be used
speculatively, falling back on a back-up strategy (currently always WCS) if
that fails or times out. There is also a logging hook that will allow us to
log which strategy is in use, as well as corner cases such as the preferred
strategy succeeding after the time-out has expired (which would imply that
the time-out is too short). The actual logging will be a follow-up CL.

BUG=432171

Review URL: https://codereview.chromium.org/815943004

Cr-Commit-Position: refs/heads/master@{#311567}

Revert of GVDA, vdatest: Enable V4L2SliceVideoDecodeAccelerator. (patchset #1 id:1 of https://codereview.chromium.org/808973004/)

Reason for revert:
Dependent on https://codereview.chromium.org/852103002/ which was reverted due to arm breakage

Original issue's description:
> GVDA, vdatest: Enable V4L2SliceVideoDecodeAccelerator.
>
> Instantiate V4L2SVDA in GVDA and vdatest to be used if the hardware
> cannot support the current frame-based API and try to use slice-based API
> instead.
>
> BUG=chrome-os-partner:33728
> TEST=vdatest,veatest,apprtc,video playback
>
> Committed: https://crrev.com/daa138be4bc9374516fa0f779cc5e5fb8c38fbe4
> Cr-Commit-Position: refs/heads/master@{#311465}

TBR=wuchengli@chromium.org,henryhsu@chromium.org,kcwu@chromium.org,posciak@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chrome-os-partner:33728

Review URL: https://codereview.chromium.org/848233002

Cr-Commit-Position: refs/heads/master@{#311566}

BUG= none
R= jmedley@chromium.org, bradnelson@chromium.org, dmichael@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/831263005

Cr-Commit-Position: refs/heads/master@{#311565}

BUG=448204,441959

Review URL: https://codereview.chromium.org/811703007

Cr-Commit-Position: refs/heads/master@{#311564}

This changes the implementation to allow multiple SendTo calls to be in
flight at the same time. The plugin can now call SendTo multiple times
before getting PP_ERROR_INPROGRESS. The number of calls is an
implementation detail. Plugins that want maximum performance should
call SendTo continuously until they get an in progress result, then wait
for one or more previous calls to complete before calling Send again.

The resource is changed to queue SendTo callbacks. It checks that the
plugin stays within the limit, which is currently 8.

The browser message filter is changed to call SendTo until the socket is
busy, then queue the sends. It checks that the plugin can't grow the
queue past the limit. In theory, a plugin could go over the limit by
bypassing the resource checks but not saturating the socket. This is
not really a problem.

Adds a test to send multiple messages in the "optional callbacks" case.

BUG=154338

Review URL: https://codereview.chromium.org/632113003

Cr-Commit-Position: refs/heads/master@{#311563}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/33868e6..d8d613c

TBR=zmo@chromium.org,yutak@chromium.org

Review URL: https://codereview.chromium.org/841383003

Cr-Commit-Position: refs/heads/master@{#311562}

Revert of Add accelerated video decoder interface, VP8 and H.264 implementations and hook up to V4L2SVDA (patchset #1 id:20001 of https://codereview.chromium.org/813693006/)

Reason for revert:
This is breaking arm builds. See for example:

https://build.chromium.org/p/chromiumos.chromium/builders/Daisy%20%28chromium%29/builds/4129/steps/cbuildbot/logs/stdio

Original issue's description:
> Reland: Add accelerated video decoder interface, VP8 and H.264 implementations and hook up to V4L2SVDA.
>
> This is a reland as the previous CL has an issue with BUILD.gn and failed gn build.
>
> An AcceleratedVideoDecoder is a video decoder that requires support from an
> external accelerator (typically a hardware accelerator) to partially
> offload the decode process after parsing stream headers, and performing
> reference frame and state management.
>
> In this design, the hardware-independent decoder implementation interfaces
> with a HW-specific Accelerator to offload last stages of the decode process.
>
> Add the interface for AcceleratedVideoDecoder, decoders for VP8 and H264,
> V4L2-specific Accelerators for VP8 and H264 and a common accelerator/client
> class for V4L2.
>
> TEST=vdatest VP8/H264, mp4 local video playback, apprtc decode
> BUG=chrome-os-partner:33728
> TBR=wuchengli@chromium.org,kcwu@chromium.org,owenlin@chromium.org,xhwang@chromium.org,scherkus@chromium.org,dalecurtis@chromium.org
>
> Committed: https://crrev.com/3c09b9b26ee6fc8b43c7535070cfa08aba1285cf
> Cr-Commit-Position: refs/heads/master@{#311464}

TBR=wuchengli@chromium.org,kcwu@chromium.org,owenlin@chromium.org,xhwang@chromium.org,scherkus@chromium.org,dalecurtis@chromium.org,posciak@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chrome-os-partner:33728

Review URL: https://codereview.chromium.org/852103002

Cr-Commit-Position: refs/heads/master@{#311561}

BUG=none
R=
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/849073005

Cr-Commit-Position: refs/heads/master@{#311560}

On iOS the omnibox display a different icon for result coming from "history",
"search" and others sources, including different colors when in Incognito
mode.

Add iOS specific resources and introduce a variation in TypeToIcon() method
to allow distinguishing result coming from "history" from the rest.

BUG=446930

Review URL: https://codereview.chromium.org/847833002

Cr-Commit-Position: refs/heads/master@{#311559}

BUG=441409
NOTRY=true

Review URL: https://codereview.chromium.org/819363003

Cr-Commit-Position: refs/heads/master@{#311558}

BUG=448472

Review URL: https://codereview.chromium.org/846293002

Cr-Commit-Position: refs/heads/master@{#311557}

Also fix testMoveToElementAndClick on Android.

BUG=

Review URL: https://codereview.chromium.org/817913004

Cr-Commit-Position: refs/heads/master@{#311556}

Revert of Disable spdy tests for constant failures on Volantis bot (patchset #2 id:20001 of https://codereview.chromium.org/836033006/)

Reason for revert:
https://crrev.com/852053002 fixes the tests, they can be re-enabled.

Original issue's description:
> Disable spdy tests for constant failures on Volantis bot
>
> Per
> https://uberchromegw.corp.google.com/i/clank/builders/instrumentation-volantis-clankium-lmp,
> all spdy related tests have failed on volantis bot.
>
> BUG=447837
>
> Committed: https://crrev.com/f13f7dbe2ec8d008d7aefa4c625d297685e62435
> Cr-Commit-Position: refs/heads/master@{#311401}

BUG=447837

Review URL: https://codereview.chromium.org/800613008

Cr-Commit-Position: refs/heads/master@{#311555}

- Switching behavior of command line to send all field trials from the browser to the renderers.
- Added notification from renderer to browser whenever a trial is activated.

BUG=430924

Review URL: https://codereview.chromium.org/700953002

Cr-Commit-Position: refs/heads/master@{#311554}

Change the WebCrypto behavior when exporting EC private keys that were imported without a public key.

Before such keys were exported to PKCS8 format, the publicKey would be missing in the ECPrivateKey.

Now instead the publicKey is written to exported bytes even if it was not provided during import.

This is more consistent with how export works for JWK, where the public key is a required parameter.

It also speeds up the structured (de) cloning of such keys, which uses PKCS8 format under the hood (and for which if the publicKey was not provided, BoringSSL computes it).

BUG=445635

Review URL: https://codereview.chromium.org/835633002

Cr-Commit-Position: refs/heads/master@{#311553}

Revert of Update V8 to version 4.2.3 (based on b62f094884b95cf7b45484a27a9721a8477efc91). (patchset #1 id:1 of https://codereview.chromium.org/807183004/)

Reason for revert:
Breaks win8 gn

Original issue's description:
> Update V8 to version 4.2.3 (based on b62f094884b95cf7b45484a27a9721a8477efc91).
>
> TBR=machenbach@chromium.org
>
> Committed: https://crrev.com/1f4c50ac8b1359e524b5da7e444a667c6b41d19b
> Cr-Commit-Position: refs/heads/master@{#311548}

TBR=v8-autoroll@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/853763002

Cr-Commit-Position: refs/heads/master@{#311552}

Revert of [Telemetry] Fix WPR files not being downloaded when required. (patchset #4 id:60001 of https://codereview.chromium.org/834173006/)

Reason for revert:
Possible suspect for newly introduced telemetry unit test flake, e.g.:

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/1965/steps/telemetry_unittests/logs/stdio

Reverting to see what happens.

Original issue's description:
> [Telemetry] Fix WPR files not being downloaded when required.
>
> BUG=
>
> Committed: https://crrev.com/672e7140315568e9bfc442770a23fee66e045cb2
> Cr-Commit-Position: refs/heads/master@{#311496}

TBR=nednguyen@google.com,aiolos@chromium.org,lizeb@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/852863003

Cr-Commit-Position: refs/heads/master@{#311551}

Only license requests should not specify |legacy_destination_url|.

BUG=448242

Review URL: https://codereview.chromium.org/804713003

Cr-Commit-Position: refs/heads/master@{#311550}

Uses a RenderFrameHost instance to hold the reference to the respective
SiteInstance and its pre-spawned renderer process.

BUG=376094

Review URL: https://codereview.chromium.org/701953006

Cr-Commit-Position: refs/heads/master@{#311549}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/807183004

Cr-Commit-Position: refs/heads/master@{#311548}

Review URL: https://codereview.chromium.org/853643004

Cr-Commit-Position: refs/heads/master@{#311547}

This is a preparation for crbug.com/448190, where we're going
to allow Mojo MessagePipe being sent over Chrome IPC.

The plan is that we'll extend existing FileDescriptorSet to
carry both platform handles and Mojo's MessagePipes, then
let ChannelMojo take care of these handles.

As the first step, this change renames FileDescriptorSet to
MessageAttachmentSet and moves it out from the OS_POSIX guard.
Although this change doesn't do anything significant, we'll
generalize it to carry both platform files and mojo handles
eventually.

R=agl@chromium.org, viettrungluu@chromium.org
BUG=448190

Review URL: https://codereview.chromium.org/835873004

Cr-Commit-Position: refs/heads/master@{#311546}

Cause:
This is a regression of the HRD change, in which we pass in an unique
ID everytime when we create an app window.  This causes a new window
to be created whenever the user clicks on the app icon in the app
launcher.

Fix:
Only create a new app window when:
1. There are no existing windows or
2. The user clicks on the New Window context menu

BUG=448128

Review URL: https://codereview.chromium.org/844503007

Cr-Commit-Position: refs/heads/master@{#311545}

messages to enable componentizing printing. Basically, we have
modified two print messages
PrintHostMsg_AllocateTempFileForPrinting
PrintHostMsg_TempFileForPrintingWritten

to a routed message rather then a control message to simplify
implementation. However, this prevents moving the code to components.

BUG=446509

Review URL: https://codereview.chromium.org/854513002

Cr-Commit-Position: refs/heads/master@{#311544}

Extension background page is only allowed for the incognito profile
on sign-in screen, so in order to run the app on sign-in, the app
must be run in split incognito mode.

To avoid having two background pages per user (for original and otr
profile) in regular user session, set split incognito mode only for the
app running on signin screen (by using different manifest than for a
regular session)

TEST=
1. Make sure easy sign-in works
2. Lock screen with an incognito window open.
   Verify that the screen can be unlocked using Smart Lock
BUG=448634,445048

Review URL: https://codereview.chromium.org/834233005

Cr-Commit-Position: refs/heads/master@{#311543}

- Fix defaultControl to return ok button for error screen;
- Add aria-live and aria-atomic to content div so that it is read out
  when the screen state is changed and all contents are updated;

BUG=413766
TEST=Test enable-debugging flow with ChromeVox and verify that title and message gets read on each step.

Review URL: https://codereview.chromium.org/788953005

Cr-Commit-Position: refs/heads/master@{#311542}