GitLab

If the username field was read-only, password manager allowed to choose saved
password but failed to insert it into the password field.

BUG=634906
R=vabr@chromium.org

Review-Url: https://codereview.chromium.org/2317983002
Cr-Commit-Position: refs/heads/master@{#417264}

Disabled buttons use their usual background at 0.38a, so this change
adds a new color ID for their faded background and uses it in
MdTextButton::UpdateColors().

BUG=644543

Review-Url: https://codereview.chromium.org/2315233002
Cr-Commit-Position: refs/heads/master@{#417263}

We iterate over the rows of the SQL DB to find entries matching the origin
filter. Then, we issue a cached DELETE statement for each of the entries.

It would also be possible to issue one "DELETE .. IN (?,?,?)" statement for all
matched origins, however, this requires us to generate the statement runtime
to add the correct number of "?". This is more complex and probably doesn't
bring a performance gain in practice.

BUG=589586

Review-Url: https://codereview.chromium.org/2320763002
Cr-Commit-Position: refs/heads/master@{#417262}

Revert of Roll WebRTC 14068:14111 (40 commits) (patchset #1 id:1 of https://codereview.chromium.org/2316333002/ )

Reason for revert:
Broke all libFuzzer builds

Original issue's description:
> Roll WebRTC 14068:14111 (40 commits)
>
> Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/6d6af9a..71740ff
>
> $ git log 6d6af9a..71740ff --date=short --no-merges --format=%ad %ae %s
> 2016-09-07 deadbeef@webrtc.org Fixing stack buffer overflow (read) in SctpDataEngine.
> 2016-09-07 aleloi@webrtc.org Simplifications of the mixing algorithm.
> 2016-09-07 solenberg@webrtc.org Moving/renaming webrtc/common.h.
> 2016-09-07 ehmaldonado@webrtc.org GN: Move variables from //build_overrides/webrtc.gni to //webrtc/build/webrtc.gni
> 2016-09-07 perkj@webrtc.org Change OverUseFrameDetector to use a task queue instead of ProcessThread to periodically check for overuse. It is made to only operate on a single task queue.
> 2016-09-07 aleloi@webrtc.org Several lock acquisitions and one of the two lock members are removed. ENSURE_LOCKS_REQUIRED and CalledOnValidThread annotations are added.
> 2016-09-07 danilchap@webrtc.org Implement PlayoutDelay extension as a trait to be used with rtp::Packet class
> 2016-09-07 danilchap@webrtc.org Relax expectation in EndToEndTest.CallReportsRttForSender test to reduce flakiness by ignoring potentional rounding errors and minor ntp time adjustments.
> 2016-09-07 henrik.lundin@webrtc.org Setting up an RTP input fuzzer for NetEq
> 2016-09-07 danilchap@webrtc.org Merge min_ms and max_ms accessors in PlayoutDelayOracle to reduce CriticalSection enterencies and avoid potentional synchronisation issues.
> 2016-09-07 stefan@webrtc.org Only parse PPS up to PPS and SPS ids in the depacketizater.
> 2016-09-07 kjellander@webrtc.org Disable -Wsentinel warning for Linux 32-bit builds.
> 2016-09-07 stefan@webrtc.org Add time line for acked bitrate.
> 2016-09-06 skvlad@webrtc.org Fixed flaky StunRequestTests which depended on the wall clock
> 2016-09-06 skvlad@webrtc.org Increase timeout for flaky tests for ProcessThreadImpl
> 2016-09-06 glaznev@google.com Add dynamic bitrate tracker and adjustment for Exynos VP8 HW encoder.
> 2016-09-06 aluebs@webrtc.org Fix chromium-style errors in IntelligibilityEnhancer
> 2016-09-06 nisse@webrtc.org Reland of Delete cricket::VideoFrame::GetTimeStamp. (patchset #1 id:1 of https://codereview.webrtc.org/2315703002/ )
> 2016-09-06 aleloi@webrtc.org Improvements to UI to python event log analyzer tool.
> 2016-09-06 kwiberg@webrtc.org iSAC float: Handle errors in upper band decoding
> 2016-09-06 nisse@webrtc.org Revert of Delete cricket::VideoFrame::GetTimeStamp. (patchset #2 id:150001 of https://codereview.webrtc.org/2310043002/ )
> 2016-09-06 nisse@webrtc.org Reland of Delete cricket::VideoFrame::GetTimeStamp. (patchset #1 id:1 of https://codereview.webrtc.org/2306953002/ )
> 2016-09-06 danilchap@webrtc.org Remove dedicated unittest file for remb format RembStatus moved to RtcpSender unittest where it fits better Creating remb in Compound/ReducedSize modes already covered by RtcpSender unittests. Parsing remb already covered by RtcpReceiverTest.ReceivesRemb
> 2016-09-06 kjellander@webrtc.org MB: Cleanup no-longer-used GN configurations
> 2016-09-06 ehmaldonado@webrtc.org GN: Set WEBRTC_RESTRICT_LOGGING as is set in GYP.
> 2016-09-06 sakal@webrtc.org Remove stop method from VideoTrackSourceInterface.
> 2016-09-06 hbos@webrtc.org Significantly increased max_num_buffers_ of Vp9FrameBufferPool.
> 2016-09-06 henrik.lundin@webrtc.org neteq_rtpplay: Add an error message for unmatched SSRC
> 2016-09-06 kjellander@webrtc.org MB: Add Linux 32-bit Debug and Release trybots
> 2016-09-06 kthelgason@webrtc.org Revert of Remove all reference to carbon api (patchset #2 id:20001 of https://codereview.webrtc.org/2299633002/ )
> 2016-09-06 kthelgason@webrtc.org Remove all reference to carbon api
> 2016-09-05 zijiehe@chromium.org [WebRTC] Two DirectX capturers cannot work concurrently
> 2016-09-05 zijiehe@chromium.org An early analysis shows in DirectX based capturer, Windows API returns larger dirty region than the real screen change. A similar behavior may happen on other platforms with damage notification support. So it's better to have an individual layer to handle the Differ logic, and remove capturing independent logic out of each ScreenCapturer* implementation.
> 2016-09-05 ehmaldonado@webrtc.org GN: Apply optimize_max only on windows
> 2016-09-05 danilchap@webrtc.org RtcpReceiverTest rewritten using public available interface IncomingPacket(const uint8_t*, size_t) is used as entry point instead of IncomingRTCPPacket(PacketInformation* out, RtcpParser* in); Result is validated by checking which callbacks were called instead of checking intermediate structure PacketInformaion.
> 2016-09-05 kwiberg@webrtc.org rtc::Buffer: Let SetData and AppendData accept anything with .data() and .size()
> 2016-09-05 danilchap@webrtc.org Use RtpPacketToSend in RtpSenderAudio. this eliminates reparsing of rtp packet on send audio path
> 2016-09-05 asapersson@webrtc.org Revert of [WebRTC] A real ScreenCapturer test (patchset #8 id:240001 of https://codereview.webrtc.org/2268093002/ )
> 2016-09-05 ehmaldonado@webrtc.org MB: Add WebRTC FYI bots to mb_config.pyl.
> 2016-09-05 ehmaldonado@webrtc.org GN Templates: Move common_inherited_config to the template.
>
> TBR=
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
> BUG=
>
> Committed: https://crrev.com/f4d002d10343c75d14c68d505760137420d22f46
> Cr-Commit-Position: refs/heads/master@{#417088}

TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:645069

Review-Url: https://codereview.chromium.org/2322723003
Cr-Commit-Position: refs/heads/master@{#417261}

Update WebContents::FromJavaWebContents to use JavaRef instead of bare
jobject. Various function parameter types are converted from jobject to
JavaRef to enable calls to obj() higher up the call chain to be removed.

Also, fix a few similar cases that just happen to be in the same files
as files already being modified, to avoid touching them again in a later
CL.

BUG=506850

Review-Url: https://codereview.chromium.org/2315323002
Cr-Commit-Position: refs/heads/master@{#417260}

TBR=fmalita@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2325523002
Cr-Commit-Position: refs/heads/master@{#417259}

BUG=635847, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2316633002
Cr-Commit-Position: refs/heads/master@{#417258}

Previously MediaNotification large icons are passed to Android
NotificationManager without any scaling, which may hit OOMs when the
icons are too large. This CL scales the icons and probably solves the
OOM issue.

BUG=601912

Review-Url: https://codereview.chromium.org/2313753002
Cr-Commit-Position: refs/heads/master@{#417257}

This matches what our backend (ChromeReader) does.

BUG=643605

Review-Url: https://codereview.chromium.org/2317153003
Cr-Commit-Position: refs/heads/master@{#417256}

Since base::Optional<> has already been in use. It's helpful to wrap
MediaMetadata in base::Optional<>, so that the browser can know whether
the page has set the metadata or not.

BUG=643195

Review-Url: https://codereview.chromium.org/2300083002
Cr-Commit-Position: refs/heads/master@{#417255}

BUG=633682, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2309283002
Cr-Commit-Position: refs/heads/master@{#417254}

The bots seem to be correctly configured now.

BUG=625808

Review-Url: https://codereview.chromium.org/2313373002
Cr-Commit-Position: refs/heads/master@{#417253}

Checking WorkerThread::m_threadState is a proper way to confirm whether a worker
thread is initialized.

BUG=639153

Review-Url: https://codereview.chromium.org/2324763002
Cr-Commit-Position: refs/heads/master@{#417252}

It's already ignored by the bot_update implementation, so this is an
expectations-only change.

R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2318353002
Cr-Commit-Position: refs/heads/master@{#417251}

Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in InputMethodController::setSelectionOffsets

BUG=590369

Review-Url: https://codereview.chromium.org/2316053002
Cr-Commit-Position: refs/heads/master@{#417250}

BUG=590369

Review-Url: https://codereview.chromium.org/2327453002
Cr-Commit-Position: refs/heads/master@{#417249}

Callback::IsCancelled() checks if the Callback is cancelled by WeakPtr
invalidation.

Review-Url: https://codereview.chromium.org/2289703002
Cr-Commit-Position: refs/heads/master@{#417248}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/36997250..c4bff3ed

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2319583004
Cr-Commit-Position: refs/heads/master@{#417247}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/3b914a255a06e847855451036418c2c341bfe7ad WebRTC: Stop compiling at our GYP bots. (kjellander@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=webrtc:6323

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2320073002
Cr-Commit-Position: refs/heads/master@{#417246}

Design doc (Step 1):
https://docs.google.com/document/d/1Pj4vzxzCKC_11SugdJ_x7wq7ErE-pHtf4w4FLKdcF7g/edit?usp=sharing

This cl relands
- https://codereview.chromium.org/1915113005
- https://codereview.chromium.org/2066763002
except for code related to Field-Trial or SharedBuffer::unlock().

BUG=603462

Review-Url: https://codereview.chromium.org/2296913003
Cr-Commit-Position: refs/heads/master@{#417245}

Currently the GFX unittests assume a font called "Symbol" to be
available on all platforms. While the "Symbol" font may be available on
Ubuntu, it is a deprecated Type 1 package and stems from the
xfonts-mathml package on Debian, which is deprecated and no longer
maintained in favor of the newer STIX fonts [1].

In preparation for activating filtering for SNFT format font files, we
have to break with the assumption above and make at least some of the
used fonts in the gfx unittests configurable per OS.

This CL makes the symbol font name configurable and replace it with
"DejaVu Sans" on Linux.

In addition to reconfiguring the Symbol font this CL introduces a CJK
font as an example of a font that has a different descender/ascender
ratio to Arial as some unittests such as
StringSizeRespectsFontListMetrics require, since the newly chosen symbol
font on Linux does not that expose that property.

To make StringSizeRespectsFontListMetrics more robust, this CL adds
additional assertions based on GetFontSpansForTesting.

[1] https://tracker.debian.org/pkg/xfonts-mathml

BUG=632142

Review-Url: https://codereview.chromium.org/2302313002
Cr-Commit-Position: refs/heads/master@{#417244}

Password manager does not use clients, while it includes
chrome_password_manager_client.h.

It caused flaky build failures on some trybots.
e.g. https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/82274
https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/82281

BUG=None

Review-Url: https://codereview.chromium.org/2319763003
Cr-Commit-Position: refs/heads/master@{#417243}

Revert of Do a better job at faking simple challenge signatures. (patchset #7 id:120001 of https://codereview.chromium.org/2297193006/ )

Reason for revert:
crbug.com/645052

This is causing build_package failures on chromeos.

Original issue's description:
> Do a better job at faking simple challenge signatures.
>
> By returning a signed simple challenge that can actually be parsed as SignedData, we allow callers of the FakeCryptohomeClient to extract the original data back and process it, making for better fake behavior and simpler tests.
>
> Note that the signature is purposedly not verifiable in the FakeCryptohomeClient.
>
> BUG=643245
> TEST=chromeos_unittests; unit_tests and components_unittests also pass
>
> Committed: https://crrev.com/911199cb30f608636c79d47e50dca84735e3a08f
> Cr-Commit-Position: refs/heads/master@{#417118}

TBR=dkrahn@chromium.org,xiyuan@chromium.org,drcrash@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=643245

Review-Url: https://codereview.chromium.org/2326473002
Cr-Commit-Position: refs/heads/master@{#417242}

This CL changes the inline ScopedTempDir::path() to an out-of-line
GetPath() and enhances it with a DCHECK against the directory not
having been created yet.

FAQ

Q: Why GetPath?
A: Because of the added DCHECK in the path accessor, which needs
   #include "base/logging.h", there were two alternatives:
    (A) Keep the inline path() and #include "base/logging.h" in the header.
    (B) Change the inline path() to an out-of-line GetPath and implement it
        in the .cc file.

   (A) would affect compile-time, (B) affects run-time of the tests. I made no
   measuring, but obtaining the path is usually a one-off step in a test, so an
   unlikely hotspot. Therefore the trade-off seems much better for (B).

Q: Why deprecating path() instead of deleting it?
A: Due to the big amount of callsites (almost 600 files in the whole codebase),
   this change is rolled out in phases. This CL changes //base. After all of the
   codebase is converted, the deprecated path() will be deleted.

R=danakj@chromium.org
BUG=640599

Review-Url: https://codereview.chromium.org/2275553005
Cr-Commit-Position: refs/heads/master@{#417241}

This patch provides a basic skeleton implementation of the
CSS Properties and Values API. In particular, the pipeline from
registration to reading from computed styles is supported but with
many missing bits along the way.

Some of the missing bits:
- Only * and <length> syntax supported with trivial parsing logic.
- All properties assumed to be inherited.
- Computation logic is currently a no-op (needs to resolve ems, etc.)
- CSSOM on specified styles aren't yet affected by (un)registration

Spec: https://drafts.css-houdini.org/css-properties-values-api/
Design notes: https://docs.google.com/document/d/1IBT3qlZK-BznqcVANckj6kjMjpyFHc-KHdBLz1n4M4c

BUG=641877

Review-Url: https://codereview.chromium.org/2310823002
Cr-Commit-Position: refs/heads/master@{#417240}

This patch gets rid of unused parameter |caretRectChanged| from
|CaretBase::invalidateCaretRect()|, since it is always |false| as default
parameter, for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2320933002
Cr-Commit-Position: refs/heads/master@{#417239}

Review-Url: https://codereview.chromium.org/2321713002
Cr-Commit-Position: refs/heads/master@{#417238}

After a bit of discussion in [1], the latest strict 'Secure' draft [2]
relaxes the equivalency checks for strict 'Secure' enforcement to allow
a non-secure cookie whose path does not overlap an existing secure
cookie's path to be set.

That is, given a secure cookie at '/path', a non-secure cookie can be
set at '/not-path', but not at '/path/subpath'.

This carveout allows us to harden 'Secure' without breaking folks who
host both secure and non-secure applications on a single domain. That
turned out to be the root cause of the breakage Blizzard experienced
in https://crbug.com/580770.

[1]: https://github.com/httpwg/http-extensions/issues/223
[2]: https://tools.ietf.org/html/draft-ietf-httpbis-cookie-alone-01

BUG=580770
R=jww@chromium.org

Review-Url: https://codereview.chromium.org/2306393002
Cr-Commit-Position: refs/heads/master@{#417237}

This includes changing the GetBudgetDetails on BudgetDatabase to use the mojo
types and plumbing the result through the BudgetManager. It pulls out all of
the old implementation in BudetManager that used the prefs to store data
(although cleanup of that isn't quite complete). It also replaces the old
GetBudget/StoreBudget calls in the push messaging system with the new Consume
call.

Tests were added in BudgetManager for the new reserve functionality, and any
tests of GetBudget that were still applicable were moved from BudgetManager
to BudgetDatabase.

BUG=617971

Review-Url: https://codereview.chromium.org/2281673002
Cr-Commit-Position: refs/heads/master@{#417236}

Review-Url: https://codereview.chromium.org/2320723002
Cr-Commit-Position: refs/heads/master@{#417235}

BUG=625808

Review-Url: https://codereview.chromium.org/2319033004
Cr-Commit-Position: refs/heads/master@{#417234}

Nobody is looking at them, and they're not even in histograms.xml

The only thing GpuMemoryManager is doing now is populating the task
manager values.

BUG=643522
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2310623002
Cr-Commit-Position: refs/heads/master@{#417233}

See https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pwyjF_jAf6I/5MeKCBG8BQAJ
for context. Also https://codereview.chromium.org/2312323002 for checklicenses.

BUG=none

Review-Url: https://codereview.chromium.org/2319093002
Cr-Commit-Position: refs/heads/master@{#417232}

AppendMirrorRequestHeaderHelper added the X-Chrome-Connected header when it was required, but did not remove it when it was not required and already exited from previous redirection. The funcion is now renamed to FixMirrorRequestHeaderHelper and removes already existing header if it is not required.

BUG=588492

Review-Url: https://codereview.chromium.org/2258483002
Cr-Commit-Position: refs/heads/master@{#417231}

The XHR spec describes progress events on XHR are queued on the networking
task source, where Networking task runner is the corresponding task runner.
https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send

BUG=624696

Review-Url: https://codereview.chromium.org/2269513002
Cr-Commit-Position: refs/heads/master@{#417230}

https://chromium.googlesource.com/external/github.com/googlei18n/sfntly/+log/b18b09b..1ef790a

1ef790a Add missing header from commit c9025ecc.
6917286 Merge pull request #58 from leizleiz/leizleiz-lotsofchecks
4f1aa49 Add ReadableFontData::kInvalidUnsigned.
c9025ec Add more bounds checks in WritableFontData.
dd23046 Return error values in ReadableFontData::Read*().
813efeb Add a size limit for font tables.
08652be Add a nullptr check to GlyphTable::Glyph().

BUG=641330,641446,641460,642300
TBR=behdad@chromium.org

Review-Url: https://codereview.chromium.org/2316303003
Cr-Commit-Position: refs/heads/master@{#417229}

Use automatic functionality instead of manually calling
UseCounter::count.

BUG=636288

Review-Url: https://codereview.chromium.org/2250613002
Cr-Commit-Position: refs/heads/master@{#417228}

The revert patch was committed twice, and broke build again.
This CL is a revert of the second committed revert.

Original CL:
https://codereview.chromium.org/2318933002/
https://crrev.com/134a59bd48149d721ce06554570db1b2b5bdee55

Revert CL:
https://codereview.chromium.org/2325583002
https://chromium.googlesource.com/chromium/src/+/d7586a77bd18573597cc48bbd2e0e6fb0fbc0fb9
https://chromium.googlesource.com/chromium/src/+/0f82e43808017ab95d877be86eb63fe1e4057e97

TBR=bashi@chromium.org,yukishiino@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.chromium.org/2323673002
Cr-Commit-Position: refs/heads/master@{#417227}

Revert of [Bindings] Remove aggregation of generated binding code (patchset #3 id:60001 of https://codereview.chromium.org/2318933002/ )

Reason for revert:
Build break
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10652

Original issue's description:
> Remove aggregation of generated binding code.
>
> After this change, we maybe able to skip needless compiles
> based on redundant dependencies. (issue 388172)
> Plus, it is expected to compile those files in parallel.
>
> BUG=634231, 388172
>
> Committed: https://crrev.com/134a59bd48149d721ce06554570db1b2b5bdee55
> Cr-Commit-Position: refs/heads/master@{#417216}

TBR=bashi@chromium.org,yukishiino@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634231, 388172

Review-Url: https://codereview.chromium.org/2325583002
Cr-Commit-Position: refs/heads/master@{#417226}

Revert of [Bindings] Remove aggregation of generated binding code (patchset #3 id:60001 of https://codereview.chromium.org/2318933002/ )

Reason for revert:
Build break
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10652

Original issue's description:
> Remove aggregation of generated binding code.
>
> After this change, we maybe able to skip needless compiles
> based on redundant dependencies. (issue 388172)
> Plus, it is expected to compile those files in parallel.
>
> BUG=634231, 388172
>
> Committed: https://crrev.com/134a59bd48149d721ce06554570db1b2b5bdee55
> Cr-Commit-Position: refs/heads/master@{#417216}

TBR=bashi@chromium.org,yukishiino@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634231, 388172

Review-Url: https://codereview.chromium.org/2325583002
Cr-Commit-Position: refs/heads/master@{#417225}