- 27 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/aa79ac23ec8d..f729a8b7cc84 2020-08-27 landrey@webrtc.org Add logging of upload completion token events. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114055 Tbr: skyostil@google.com Change-Id: I71b1834b91f4ae7a1cf5b7d740002935240808be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378936Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802102}
-
Yoshisato Yanagisawa authored
With Goma builders, we have confirmed that chromium-ci-builder@chops-service-accounts.iam.gserviceaccount.com works as without using task service account for Goma. Let me migrate the builders. Bug: 1105814 Change-Id: Ic4dedf38c59f358909014d4f8b0c9379914bcb2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378780Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#802101}
-
Sadrul Habib Chowdhury authored
Not all dropped-frames affect smoothness. For example, the compositor thread may be driving a css animation, while the main-thread drops frames while doing busy js work (e.g. handling event, etc.). These dropped frames do not affectthe smoothness of the animation. So count the dropped frames that specifically affect smoothness separately. To do this, for each frame, track whether the compositor and/or the main thread are affecting smoothness. BUG=1115376 Change-Id: I6cd3e3d2a10ed63c53ab929386abae1d5e29e7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366039 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#802100}
-
Jinsuk Kim authored
The flaky test was already fixed. Re-enables the test on android-pie-x86-fyi-rel. Ignore-CQ-Freeze: enabling tests for emulator builder Bug: 1061216 Change-Id: I004a09829c410d40bea6d40d3b79bd5c748de739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363509Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#802099}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008200800_RC01.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/HZNHFa2CcUZB-FO9DToAmE5qKZsX_2h2bM8NbJPrGd0C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159384835 Tbr: help-app@grotations.appspotmail.com Change-Id: I7e756cb8946ae0170759fdcb0b9c3672f05b4799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378224Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802098}
-
Darren Shen authored
None of these are used in the internal VK code. Change-Id: I28d9658372fbef6208a9bc1efc7ec2b7c271e29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371149Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#802097}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/14a9bffb3e9e..ced41e1f394d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib3da838045fa77faf3ac6a3b333d2df07cf35a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378660Reviewed-by:
-
Chih-Yu Huang authored
Add the current ARC++ video team member to the OWNERS. BUG=None TEST=None Change-Id: I502e3445104efe5327d2a780e29d8ca934ea4696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377183Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#802095}
-
Andrew Xu authored
This CL implements the highlight background and the close button view for the Multipaste menu item. Note that the item deletion is not included in this CL. In addition, the rounded corners of the bitmap are removed in this CL. Because the previous implementation utilizes the paint layer, which brings us troubles when scrolling. The rounded corners will be added back in a separate CL. Bug: 1112888 Change-Id: Ib3f469124b01b5a6c0602cca0ebc29d177b678ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370656 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#802094}
-
Noel Gordon authored
Says as much but avoids an unfortunate auto-formatter line break. Also remove a comment that no longer matches the error code behavior. Bug: 1114622 Change-Id: If495124221d6bbeb416cb69a1a4b30fc6d95f1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377827 Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#802093}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/320c6c87b2ed..8575cb3ec773 2020-08-27 bajones@chromium.org Add setIndexBufferWithFormat method If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I6eb4a619817bb207509b18e99e3ed45baff5fb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378935Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I7521072eb9321e902a6325eda954db44c38bd0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378766Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802091}
-
nancylingwang authored
The function GetIconPurpose uses the parameter |size_hint_in_dip| to calculate the max supported pixel size, however, the input parameter |icon_size_in_px_| is incorrect, and |size_hint_in_dip_| should be used. BUG=1121480 Change-Id: I249f369e194eca9db96d8d2da68a9bdac03dedcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377667Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#802090}
-
Greg Thompson authored
The various SpellcheckCustomDictionaryTests post background tasks to update the dictionary file. Allow these tasks to complete at TearDown before destroying the TestingProfiles so that the directories on disk aren't being removed while background threads are trying to write to them. This CL unblocks making base::CreateAndOpenTemporaryFileInDir DCHECK if the target directory doesn't exist. BUG=1075917 R=groby@chromium.org Change-Id: I25b3317447f0928504e3315caa6b215410030c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193111 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#802089}
-
Songtao Xia authored
This is based on https://chromium-review.googlesource.com/c/chromium/src/+/1725223 by Dmitry Gozman. Part to support "stepping back from fetch" is in a different CL. Explainer: https://docs.google.com/document/d/1WJcNA9PymdWQXOZ4b0xSPmqQCDplWO6c01Ve47lQ2xo/edit?usp=sharing This patch introduces debug header "X-Debug-Stack-Trace-Id", which is added when Network.setDebugHeaderEnabled is called. This header plumbs stack trace id and can be used to stitch async stacks between page and service worker, or between page and node.js backend (future work). The header is added by InspectorNetworkAgent and parsed by ServiceWorkerGlobalScope. Frontend changes to enable 'step into service workers': https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2292897 Screenshot before: https://imgur.com/pIxDfHa After: https://imgur.com/MHXM5BI Change-Id: I4aeeca29802318fe063459562c31e147e7b0d9e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335644 Commit-Queue: Songtao Xia <soxia@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#802088}
-
Ian Kilpatrick authored
This patch removes counting various UseCounters, and assumes that HasLineClamp will always be true for a LayoutDeprecatedFlexibleBox object. Bug: 305376 Change-Id: I56ae40850698b6e04cebc320f78d7a0af4992c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954927 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#802087}
-
Josh Nohle authored
Set the expected uploaded contacts/certificates. Change-Id: Iaa927d9ee31e43ddf1d641cea7137d2507cab765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378597 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#802086}
-
Leonid Baraz authored
Bug: b:165851833 Change-Id: Id4d65e2426663783d510a72a8a1f298462e3d2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378655 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#802085}
-
chromium-internal-autoroll authored
Release_Notes:http://go/media_app-x20/relnotes/Nightly/media_app_202008260800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/NDPCcgJvuhM3F7KyVFnMa4mftVlWMdK9ysK3cuxhi2oC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/163669074,b/165878563 Tbr: media-app@grotations.appspotmail.com Change-Id: I9f32f007dc5d2f80af54e4d63a75c855e6c3dce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378933Reviewed-by:
-
Rachel Wong authored
The privacy container score was previously set to INT_MAX to ensure that it was the first container, because other container scores could fluctuate. The app list config now consolidates the scores for all search result containers, see https://chromium-review.googlesource.com/c/chromium/src/+/2345924. Bug: 1079169 Change-Id: I1caf9a3bd94f2c71aed68fe79f2ec88fa4f39645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377185Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#802083}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/14a9bffb3e9e..ced41e1f394d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1f53c2b234ac21a8c10748bbeebc32487102ca96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378887Reviewed-by:
-
Alan Screen authored
Advanced capabilities for ChromeOS are always strings, but those values can contain content that is to be interpreted as numbers or a boolean. These different types were previously distinguished by using the base::Value::ValueType enum, which is a superset of what ChromeOS requires for these capabilities. Use of this enum creates a hurdle in the effort to mojoify PrintBackend class for out-of-process print drivers. In particular, extending the mojo definition of base::Values has been deemed undesirable. [1] While the original reason for using base::Value::ValueType here is unknown, it seems that it should be replaced with something that reflects its more limited possible values. Rather than pull in CloudPrint-specific types into core printing code, introduce a type locally to reflect the expected capability types. [1] https://crrev.com/c/2368138 Bug: 809738 Change-Id: I42efff084a394cb6e0ac4e1f89ffd41aa58ae323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369496Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802081}
-
Kyle Horimoto authored
This class exposes the notifications which have been synced from the phone and provides APIs to dismiss notifications and send inline replies. The functionality to add notifications to this class and to implement dismissal/reply are not yet implemented. This CL also simplifies some logic in FakePhoneHubManager to avoid unnecessary unique_ptrs. Bug: 1106937 Change-Id: I9cc743bbb85aea64fe47f839ffa6b631f88e4e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378774 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802080}
-
Xinghui Lu authored
The SafeBrowsingExtendedReportingEnabled policy is supported on desktop platforms since M66. We should support this policy on Android as well. Screenshot: http://screen/AxEr3pc9q6s4KMi Bug: 1108604 Change-Id: I456de70a9a0435cbe3fa6e54e2648e7d834a42c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378542Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802079}
-
Danyao Wang authored
Allow origins enrolled in the Secure Payment Confirmation trial to use skip-the-sheet flow to trigger secure modal. Bug: 1122028 Change-Id: I8d9e41ad6ac3b8851e72fa5416562d85a8b14f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378446Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#802078}
-
Alexander Cooper authored
Oculus and OpenVR both have beta runtimes that will allow running their devices via OpenXR. In order to simplify the Chrome codebase, we will stop running Oculus and OpenVR against their own runtimes (which have not shipped), and run them via their OpenXR implementations. Note that with OpenVR being removed, the test macros needed to be modified to stop running against it, as well as a few OpenVR specific tests needing to be removed. Oculus runtime was never tested in an automatic fashion. Bug:1121624 Change-Id: Ibdf13532e922db1290062186fd5ec45885d5b46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373392Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#802077}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1752e62f5c2a..69ed1bc0165a 2020-08-26 brcui@microsoft.com Remove Settings from More tools menu 2020-08-26 michael.liao@microsoft.com [Accessibility - Console]: Adding SR alert for clearing the console If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1120065,chromium:1121312 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia9e73541b8212b21c4d1cbf678bf190ae7416db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378666Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e7f2169b3665..c08c71bedfbb 2020-08-26 apolito@google.com don't let 'anyone' be a reviewer 2020-08-26 vadimsh@chromium.org Update lucicfg to the latest version. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1120999 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I11dc021bd00bd7b17d45d2f5ed8370a769e639ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378663Reviewed-by:
-
Austin Tankiang authored
|stop_callback_| can no longer be used to indicate that Stop() has been called as running the callback will make it null, so add a |stopped_| field instead. Bug: 1007662 Change-Id: Ifea869fa1a80f1c6eeeced5abf8a56bf55808365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374911Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#802074}
-
Kurt Catti-Schmidt (SCHMIDT) authored
This change implements basic positioning and layout of grid children. It also allows for creation of NGGridLayoutAlgorithm from Blink outside of unit tests, so we now render actual grid content in Chromium for grids with fixed size rows and columns! There is still quite a bit of missing functionality, including for positioning in non-fixed sizes, grid-gap, etc, which will be covered in subsequent changes. This also includes some helper methods for dump tests, along with our first dump test for GridNG. A known limitation of this change is that there must be enough defined rows and columns for child elements. This will no longer be an issue once we handle the TODO comments regarding auto repeaters. For now, I've added additional row/column definitions to the existing tests to avoid this limitation. Bug: 1045599 Change-Id: I9efd14fd44eaf6cac7e93fa05be4c45810e64dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369673 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8178c8db6335..aa79ac23ec8d 2020-08-26 mheikal@chromium.org Remove is_emulator check from DeviceUtils#pixel_density If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I12c80ce89236ee416d3a0b2b8285a237c9e77013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378661Reviewed-by:
-
rbpotter authored
Add a preprocess_grit build rule and script. This will allow Web UI files to be preprocessed by grit without going through the pak/unpack process, and without requiring such files to be listed in a grd file. This simplifies the process of creating generated output folders with fully preprocessed files for bundling. Bug: 1071641 Change-Id: Ifd69f9d985083555987a7d968378a7f7aeff15c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369981Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#802071}
-
Austin Tankiang authored
This changes CryptAuthApiCallFlow and CryptAuthClient to use the newer callback classes, and updates users of CryptAuthClient's mock as needed. Bug: 1007662 Change-Id: I1a8acbcbd1ac6294165c2f6ece82571a324487f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377766Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#802070}
-
Kyle Horimoto authored
This class includes metadata associated with a notification which appears on the user's phone and has been synced to the Chrome OS device. Bug: 1106937 Change-Id: I2591ca19b8752346390c649d85f2c31978f1f37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378881Reviewed-by:
-
Oksana Zhuravlova authored
This reverts commit 279dbf78. Reason for revert: investigating a proper solution for https://crbug.com/1120959 might take a while Original change's description: > [mojo][bindings] Move Router exception to executor thread > > This change moves throwing the exception if Router was not closed to the > executor thread to make it crash instead of just logging. > > Bug: 1087098 > Change-Id: I65c510bdbadedc3a0589807843c57e925c0351c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321345 > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800765} TBR=boliu@chromium.org,oksamyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1087098 Change-Id: Iabeda9f10d9fcffd9d9894b72506a55b43907455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378897Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#802068}
-
Josh Nohle authored
The Device proto |display_name| field is a relic of the past. It could also be a privacy concern. Remove all use of it. The device name will continue being included in the certificate's encrypted metadata. Fixed: b/166114548 Change-Id: I74b9ee2924ca80a707c1e0e25f68be6a2a94dab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378757 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
-
David Maunder authored
Bug: 1119856 Change-Id: Id9f07fb02232d8a6ed7cfedf2c144e6e3c3a82c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372923Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#802066}
-
Sunny Sachanandani authored
If only video is being presented in an overlay swap chain, then root surface damage is empty. However, we still enqueue an event query for presentation feedback. This keeps the 3D engine active and consumes power. This CL moves the vsync and presentation feedback logic to the root surface (DirectCompositionChildSurfaceWin) and only enqueues the event query if the root surface damage is non-empty. Bug: 1117214 Change-Id: I7fa205e44010558bd08fe6a0681c783529cd8c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360323 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#802065}
-
Noah Rose Ledesma authored
When an audio device is selected via the GMC UI that setting should persist for all media on that origin in that sesion until another selection is made. Bug: 1122134 Change-Id: Icbdd58db3c0e2233804004065958dcd544d37c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378450Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/master@{#802064}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1f2195b4..2a00f38a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I70ddc2d6f35c8ad166a434367ac411099dcf3aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378694Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802063}
-
