- 11 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/549a44bb4574..54c26addfe46 2020-12-11 sigurds@chromium.org Report non-HTTP errors in Developer Resources View 2020-12-11 petermarshall@chromium.org Larger line-height for tabbed pane headers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1069378,chromium:1106182,chromium:1156789 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I226030657b26b6dd1067b094eb41d7a5c6311a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836138}
-
Peng Huang authored
With NVidia GPU, the Xserver crashing and vkCreateSwapchainKHR() returning errors happen at same time. Not sure if Xserver crashes cause the vkCreateSwapchainKHR() call fail, or Chrome crashes after vkCreateSwapchainKHR() returning errors cause Xserver crash. So with this change, Chrome GPU process will not crash when vkCreateSwapchainKHR() return errors. Instead chrome GPU process will handle the error, and consider it as context lost, and then try to tear down everything, and then restart the GPU process. Bug: 1149673 Change-Id: I9f5e5ca5aaf3f17107e1f9de31fa7837e6489d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587073 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#836137}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607666365-c1cc1d25065c901589c113e3c731cdd417d0631b.profdata to chrome-win64-master-1607677133-25f70964da7400c139fdb96077d2bf8b05dd84bf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic3d466709a9ae64f3fa7999e43011e991948c4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586663Reviewed-by:
-
Kent Tamura authored
Tbr: kojii@chromium.org No-Try: true Bug: 1157854 Change-Id: I07943e2c25c17784fd54c9fb13d0c359e60802d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586452Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#836135}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012110600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/oPbfH0SGPgdmwgZIaYCll3Gghrdsll3evPpO2h6YxXYC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138543581,b/138961540,b/142756263,b/156651695,b/168064736,b/173974643,b/173979024,b/174809292,b/175080523,b/175186196,b/175343303,b/175355842 Tbr: media-app@grotations.appspotmail.com Change-Id: Id73cb631c8bbd628e3c43129156a1a6f5aba45d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586945Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836134}
-
Scott Lee authored
https://crrev.com/c/2582808 enabled ResultDB for junit_tests on chromium.FYI at 30%. However, it turned out that - android-code-coverage is the only builder with junit_tests in chromium.fyi, and - the builder has been in a very unhealthy status for a long time already. : https://ci.chromium.org/p/chromium/builders/ci/android-code-coverage?limit=100 Therefore, chromium.FYI cannot be used to test ResultDB for junit tests. Instead, I replicated a builder from Android arm Builder (dbg) and set the experiment flag to test ResultDB on chromium.android junit_tests. : http://shortn/_pZLcaLnZ47 It WAI and results were streamed to ResultDB successfully. This CL sets the junit experiment flag to 30% for chromium.android. R=gbeaty@chromium.org,chanli@chromium.org Bug: 1084332 Change-Id: Ib8db8d46cc4d864b9a6de81f5fd4b0c280913f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586248Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Scott Lee <ddoman@chromium.org> Cr-Commit-Position: refs/heads/master@{#836133}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fd5c6c03c06f..e94526b4043b 2020-12-11 fmayer@google.com Fix build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9a9072cbfebcd548088f806731b42b212be1575d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586572Reviewed-by:
-
Roman Arora authored
Adds a webui optimized configuration for the 'Tab Search' feature. The resulting code reduces the number of network requests. Pinpoint benchmarks collected below suggest the webui optimized version of 'Tab Search' performs better in low end device scenarios. Pinpoint results spreadsheet: https://docs.google.com/spreadsheets/d/1sKon_KLA3dU0iASJ24BBFAq4qa_R0q5r3L9uPHmCwXU/edit#gid=1996236618 details and summary included in the crbug. Fixed: 1157194 Change-Id: I833a300f94a37296064b8c7db19c1d8e7a9ace1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529733Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#836131}
-
Benoit Lize authored
The scheduled purge task now retains the manager, but will not reschedule itself, ensuring that it will be destroyed. Bug: 1131857 Change-Id: Ifbb20e0c51902c8104630e35da6b025da1869639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586346Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#836130}
-
Sebastien Lalancette authored
Prevent showing the Link-to-text action when the current page is not HTML and also when, for some reason, the main frame cannot execute JavaScript. Bug: 1157053 Change-Id: I11702dd3d91d204b9b80f686c29ac4640c84ea88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585836 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#836129}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5a9d7eaa74ad..f2d81b7d4073 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib422c99a375e12e902b2fd2b341de06d6e828f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586571Reviewed-by:
-
Sanja Perisic authored
Improve the enumerator style to match constants, not macros (from ENUM_NAME to kEnumName) according to the Google C++ Style Guide. Bug: 1157058 Change-Id: I6dda26e324917fdfd27e26523f8c30a41746c251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584975Reviewed-by:
Anqing Zhao <anqing@chromium.org> Commit-Queue: Sanja Perisic <sanjaperisic@chromium.org> Cr-Commit-Position: refs/heads/master@{#836127}
-
Markus Handell authored
Change of plans. Enable forward rollout of this feature instead to permit impact assessment in a more standard way. Bug: 1157617 Change-Id: Icec78c1db644e7cfc4f4ec56cd96bba3d08e512c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586347 Auto-Submit: Markus Handell <handellm@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#836126}
-
Ella Ge authored
Tbr: tommi@chromium.org No-try: true Bug: 1157849 Change-Id: Ideaf0c3f6ee4dfe5bbd99857f93071e0376cb032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585690 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#836125}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ff44584b475b..203ae7e60e20 2020-12-11 reed@google.com Revert "Fix SkPathStroker::CheckConicLinear" 2020-12-11 kjlubick@google.com [infra] Add CIPD asset for mockery. 2020-12-11 kjlubick@google.com [canvaskit] Add API for deleting webgl ctx 2020-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from d94a77b304f4 to 0a64a9747555 (3 revisions) 2020-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 067a12f05951 to c75473c2cf88 (10 revisions) 2020-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 29fd62989338 to 6bcd4aceef10 (1 revision) 2020-12-11 csmartdalton@google.com Suppress ASAN warning for divide-by-zero in SkFindQuadMidTangent 2020-12-11 johnstiles@google.com Add parameter names to FunctionDeclaration descriptions. 2020-12-11 reed@google.com Remove dead code (from old flags) 2020-12-11 csmartdalton@google.com Fix SkPathStroker::CheckConicLinear 2020-12-10 bsalomon@google.com Restore GrRenderTargetContext as an alias for GrSurfaceDrawContext 2020-12-10 johnstiles@google.com Fix misspelling of faceforward() intrinsic in SPIR-V. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Test: Test: Test: Inspect the resulting markdown docTest: Test: angle_end2end_tests --gtest_filter=EGLSyncTest.*/ES2_VulkanTest: Test: run roll_aosp.sh --copy-to-vendor-partion, build the Android image Change-Id: If91a623b1b66357db9cc0b78ff583edd6ed7cbda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586905Reviewed-by:
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/3094902fcdc2db2cc832fa854b9a6a8be383926c..4ae71a4c7aea7287b7090dfa664bf9a1f30ea787 The following commits have update notes: a6b6b804a Align armv8.pl references to OPENSSL_armcap_P. Bug: none Change-Id: I5da6f76fc4e8db03f7c0a08cc5dcb08b2e6b4af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582410 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#836123}
-
Tim van der Lippe authored
Required for landing https://crrev.com/c/2578938 R=aerotwist@chromium.org Bug: 1024752 Change-Id: I9c681daee604e1616379f5cda2751601a736285d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584976 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#836122}
-
Dominique Fauteux-Chapleau authored
This prepares future changes to read the user DM token by moving the DM token reading code to ConnectorsService. This also moves and adds the incognito mode check to ConnectorsService instead of having it in random code locations. Bug: 1148789, 1149425 Change-Id: I70779d2af97735ed76271a2d0cadf7b9956411f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537933Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#836121}
-
Rouslan Solomakhin authored
Before this patch, the touch target of the dropdowns in the card and address editors were 24dp tall, which is shorter than the 48dp required for accessibility. This patch adds a 13dp padding on top and bottom of the dropdowns in the card and address editor. Because varying sizes of string values in the dropdown can wrap and cause the dropdown height to increase, alignment with text fields on the same row is difficult, so dropdowns are now prevented from sharing the same line with text fields. This affects the US address format in particular, where the "State" dropdown shared a line with the "ZIP Code" textfield. Other forms that shared two dropdowns in the row (e.g., expiration month and year in card form) or two textfields in the row are not affected. After this patch, the touch target of the dropdowns in the card and address editors is at least 48dp tall. Bug: 977272 Change-Id: I9b99f514a7427af7ddf7f0963c724f2cdda0cb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586147Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#836120}
-
Fergal Daly authored
From crashes (https://crbug.com/1146573#c38) we can see that render_frame_created_ is not staying false in RenderProcessExited. This introduces debugging to catch a second call to SetRenderFrameCreated(true) if it occurs during the section of code under suspicion. Bug: 1146573 Change-Id: I32b9a3202080690dc1f7227c8b62e3852f7e8cf4 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583584 Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836119}
-
Fergal Daly authored
The current code is full of conditionals. I think it's easier to read and see what's going on when it's 2 separate simpler flows. This could make it easier to forget to undo something in Destroy but Create/Destroy pairs are all over our code. Bug: 1146573 Change-Id: If93a8c72a2a20eaced929a3e9efe0dab938b1bbc Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581633 Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836118}
-
Alice Wang authored
This CL separates metrics logging method from SigninUtils to unblock the modularization of classes depending on this method. In the subsequenct CLs, we can also regroup other the signin metrics logging methods in the new SigninMetricsUtils class. Bug: 1157452 Change-Id: Ic9bc8dd2677afa026f37f98056a30c7599b63ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584304 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#836117}
-
Christian Dullweber authored
Replace usage of getContext() with getActivity() when it is used to fetch resources to make SiteSettings and PageInfo work on WebLayer. Bug: 1077766 Change-Id: I679d0e8ba991903d4fa055f01c88876c400fca46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577212 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#836116}
-
Danila Kuzmin authored
Bug: 1157315 Change-Id: I2c284c9ce47a9e679ed7cfd277da114874b0af66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584924 Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836115}
-
Sreeja Kamishetty authored
SelectToSpeakNavigationControlTest.ChangeSpeedWhilePlaying is consistently failing. More details: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-rel/b8861209763102157072/overview This test is failing on Chromeos-rel, Chromeos-dbg, linux-chromeos-chrome,Chromeos-ASan, MSan bots. Suspected CL: https://chromium-review.googlesource.com/c/chromium/src/+/2577882 TBR=joelriley@google.com,dmazzoni@chromium.org Bug: 1157817 Change-Id: Id2b66c92cce7199046707b85738fc143da48436e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586762Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#836114}
-
Anand K Mistry authored
Because ResourceBundleFileLoader waits for both a mojo::Remote and mojo::Receiver to disconnect before destroying itself, it's possible for the ResourceBundleFileLoader to still be alive but |client_| to be disconnected. Therefore when ResourceBundleFileLoader::OnMimeTypeRead() runs after |client_| is disconnected, attempts to call |client_| Mojo methods will either DCHECK or crash. Bug: 1156958 Change-Id: I4320c26a75dce2a73509d3b0653c443df0c77ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584725 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#836113}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5a9d7eaa74ad..f2d81b7d4073 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7483c0e020212534575ff5e7353dc2f3c2dbaa94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586101Reviewed-by:
-
Fredrik Söderqvist authored
Switch SVGPatternElement to use an observer scheme similar to that used by SVGGradientElement - i.e using an IdTargetObserver. Implement an override of FindCycleFromSelf() on LayoutSVGResourcePattern to handle the cycle-checking for the inheritance link. LayoutSVGResourcePattern is refactored a little in the process to allow reusing the attribute collection phase. This drops the only remaining user of SVGResources::LinkedResource(), so it and its associated code can be removed as well. Bug: 1028063 Change-Id: I228f80fb707921ccab695ee8a573d17c0498fcbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584307Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#836111}
-
Mihai Sardarescu authored
This CL also renames method SignOutAndRemoveAllAccounts() and SignOutAndKeepAllAccounts() to ClearPrimaryAccount() and RevokeSyncConsent() to better match the PrimaryAccountMutator APIs. Bug: 1155505 Change-Id: I395af84c98f32383f072eb3662d4ebde7e545534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580338 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#836110}
-
Eric Willigers authored
NavigateParamsForShareTarget() is moved to share_target_utils.h/cc We read the shared title from the Intent shared_title. We split the Intent's shared_text into text and url. See https://chromium-review.googlesource.com/c/chromium/src/+/2569329 Not yet implemented: Receiving title/text/url without files, for example using GET. Design doc in progress: https://docs.google.com/document/d/1E4CYASFDVNqmyCbaxa8u8sOn0-Sc1miLeZfA3t3ou5o/edit?usp=sharing Bug: 1125880 Change-Id: I2920e96517b9432ef10f11610b08fb60fb9207d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581636 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#836109}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I0bbaebfeb1c8d177549c1e453f60dd5cdf928d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586898Reviewed-by:
-
dpapad authored
This UI element is only used in c/b/r/chromeos/arc_support/ and does not justify residing within shared WebUI code. Moreover it was previously unnecessarily included in non-CrOS builds. Bug: None Change-Id: I0e2da5f89995b8d747bdeed11343e59ddaccedd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568609Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#836107}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/49ce67ac98da..d8969b3b6ba6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sreejakshetty@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sreejakshetty@google.com Change-Id: I2ea5752e1291dcbb1f06b7bfe24dffd1c4819b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586973Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/388379be2125..549a44bb4574 2020-12-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-12-11 alcastano@google.com [Backend] Show Issue next to corresponding line in Source Tab 2020-12-11 petermarshall@chromium.org [surveys] Fix minor issues with survey links 2020-12-11 wolfi@chromium.org Replace usage of 'blackbox' in UI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112738,chromium:1150883,chromium:1152082 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If800bd7ba9e11fcb089e77638b5efc62a5e881d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586902Reviewed-by:
-
Antonio Sartori authored
In the Blink Content Security Policy code, we switch from using the internal blink type blink::SourceListDirective to using the mojo type network::mojom::blink::CSPSourceList for handling lists of CSP source expressions. This is part of a project to harmonize the CSP code in Blink and in services/network, and will make it easier to synchronize Content Security Policies between the two. Bug: 1021462,1149272 Change-Id: Ibb860148689399c9b169bb9e604bfed5d5df429f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560100 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#836104}
-
Christoph Schwering authored
This CL moves ownership of AutofillExternalDelegate from ContentAutofillDriver and AutofillDriverIOS to AutofillManager. This change preservers equivalence. Bug: 1007974 Change-Id: Ib6319a45bced8f4b2dc440dc3ed3b9bbd0618df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584867Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#836103}
-
Hongbo Song authored
UKM privacy review: https://docs.google.com/document/d/1c10O4JSPxEaRCtnTSwV_2sJ1ffmXlmLPMg7ytG33III/edit?usp=sharing&resourcekey=0-IC06YsZ3Gk-sHNeUt_dMNw Change-Id: I386c3d80fc9397ce92c4e8a18b0e496820122960 Bug: 1152552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556583 Commit-Queue: Hongbo Song <hbsong@google.com> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#836102}
-
Tanmoy Mollik authored
If MOBILE_IDENTITY_CONSISTENCY is not enabled sync data type states are retained even if the user toggles 'Sync your Chrome data' off in SyncAndServicesSettings page. This leads to an UI error when the user is migrated while in this state that shows that all data types are enabled to sync even though sync is shown as turned off in ManageSyncSettings page. This state is impossible to reach if MOBILE_IDENTITY_CONSISTENCY is enabled. This cl creates a fix to migrate existing users who are in that state. Recording of the faulty behavior can be found on the bug. Bug: 1151853 Change-Id: I9716a5ac001da9048e7fa6e46f789fb3e5116709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581929 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
-
Dylan Cutler authored
constructor is private. This is part of a larger effort to make the generic constructor of CanonicalCookie private. CreateUnsafeCookieForTesting is a factory method that creates a test-only cookie which is not guaranteed to be canonical and should not be used in production. Bug: 1102874 Change-Id: I70bd75b14fa7ca5559a760905b459823b4f0d947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584644Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#836100}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f2d81b7d4073..fd5c6c03c06f 2020-12-11 simonmacm@google.com Merge "Export suspend-resume periods as a metric." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I410dd5ec21d2dc31bee81e80405bfb2af81e72f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586883Reviewed-by:
-
