GitLab

NOTRY=true

Review URL: https://codereview.chromium.org/591723002

Cr-Commit-Position: refs/heads/master@{#295910}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/70e09f7..fdff3fb

TBR=

Review URL: https://codereview.chromium.org/591953002

Cr-Commit-Position: refs/heads/master@{#295909}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/00a138c..29c857d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/588053002

Cr-Commit-Position: refs/heads/master@{#295908}

These tests are flaky on OSX 10.6.
Also revert attempted fix: https://codereview.chromium.org/568673004 .

BUG=405386

Review URL: https://codereview.chromium.org/582803005

Cr-Commit-Position: refs/heads/master@{#295907}

Provide a method to get the chromium version for use as the
data reduction proxy version.

BUG=410127

Review URL: https://codereview.chromium.org/533003002

Cr-Commit-Position: refs/heads/master@{#295906}

BUG=408964
TEST=Manual

Review URL: https://codereview.chromium.org/554393008

Cr-Commit-Position: refs/heads/master@{#295905}

BUG=339240
TBR=joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/591943002

Cr-Commit-Position: refs/heads/master@{#295904}

Broke check_licenses step http://build.chromium.org/p/chromium/builders/Linux/builds/53652/steps/check_licenses/logs/stdio

This reverts commit 7c33f442.

R=dzhioev@chromium.org
BUG=

Review URL: https://codereview.chromium.org/592603004

Cr-Commit-Position: refs/heads/master@{#295903}

BUG=348066
TEST=None
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/585283002

Cr-Commit-Position: refs/heads/master@{#295902}

Cr-Commit-Position: refs/heads/master@{#295901}

Cr-Commit-Position: refs/heads/master@{#295900}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/3c196de..00a138c

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/589923002

Cr-Commit-Position: refs/heads/master@{#295899}

Disable NaClBrowserTestNewlib.IrtException on Windows to see if that gets rid of the hung browser test binaries.

BUG=416272
TBR=uekawa@chromium.org

Review URL: https://codereview.chromium.org/591883002

Cr-Commit-Position: refs/heads/master@{#295898}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e266d9c..70e09f7

TBR=

Review URL: https://codereview.chromium.org/588933002

Cr-Commit-Position: refs/heads/master@{#295897}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bcf65c8..e266d9c

TBR=

Review URL: https://codereview.chromium.org/587653004

Cr-Commit-Position: refs/heads/master@{#295896}

Sometimes, the status icon was shown in unexpected timing. This might be because the animation is re-fired when the dom is restyled. This patch fixes it.

BUG=none
TEST=Open window->play video->pause->close window. Repeat it 20 times and observe no issue.

Review URL: https://codereview.chromium.org/573233002

Cr-Commit-Position: refs/heads/master@{#295895}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/665ffc7..bcf65c8

TBR=

Review URL: https://codereview.chromium.org/586293002

Cr-Commit-Position: refs/heads/master@{#295894}

Previously, thumbnails of offline-available non-image files were not shown. This was because we tried to show self-generated thumbnails when the file cache was present. But we can't generate thumbnails of non-image so the thumbnails of video files were not shown.

With this patch, if thumbnail can't be generated, the thumbnail from the external provider shows instead.

BUG=415048
TEST=manual tested

Review URL: https://codereview.chromium.org/574293002

Cr-Commit-Position: refs/heads/master@{#295893}

List of changes:
* Added all core-elements and paper-elements provided by Polymer.
* Added web-animations-js (a dependency of core-animation element).
* Components moved to 'components' subdirectory.
* Added a presubmit check verifying that the list of dependencies from
  bower.json and the list of components installed to 'components' are the same.
  (see README.chromium for details).
* Updated README.chromium
* Updated pathes to polymer.js and platform.js in projects that use them.

This CL doesn't change polymer and platform components.

Landed manually, because of the bug in the commit queue (http://crbug.com/416255).

BUG=415696
R=mtomasz@chromium.org, raymes@chromium.org, rsadam@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/582873003

Cr-Commit-Position: refs/heads/master@{#295892}

BUG=330264

Review URL: https://codereview.chromium.org/588033002

Cr-Commit-Position: refs/heads/master@{#295891}

Adding registration ID request and tests to GCM Account Mapper
* Adding code to get registration ID from GCM
* Making sure account tokens are only processed when reg ID is present
* Remembering only the last assigned set of account tokens
* Fixing tests that require registration ID
* Adding tests specific to registration ID setting

BUG=374969
R=zea@chromium.org

Review URL: https://codereview.chromium.org/580603002

Cr-Commit-Position: refs/heads/master@{#295890}

The implicit conversion has already been disabled for Linux and ChromeOS
builds. https://codereview.chromium.org/510323002 explains the rationale
for proceeding incrementally.

BUG=110610
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/589853002

Cr-Commit-Position: refs/heads/master@{#295889}

Previously, if exact_matches was True but there were no exact matches,
it would return fuzzy matches instead. This is not what the caller asked
for.

GPU test names are changed to match the buildbot config, since they were
previously relying on fuzzy matching.

SHERIFFS: May cause errors like:

  No test named "some_test_name".

  Available tests are:
    ...

If so, this CL can be safely reverted.

BUG=413334,413442

Committed: https://crrev.com/566ed9f6e71cea313c88e8f259eca76581b72d67
Cr-Commit-Position: refs/heads/master@{#294757}

Review URL: https://codereview.chromium.org/560153004

Cr-Commit-Position: refs/heads/master@{#295888}

Revert of Reland of "Remove void** from disk_cache interface." (patchset #2 id:40001 of https://codereview.chromium.org/583283002/)

Reason for revert:
Suspected for causing accessibility tests to flake.

Original issue's description:
> Reland of "Remove void** from disk_cache interface."
>
> Enumeration and iteration were passing around void**. With this CL, we
> instead use an Iterator object.
>
> TBR=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org
> BUG=413644
>
> Committed: https://crrev.com/edbfba945a76d97383122a01529abfe3ce63d34d
> Cr-Commit-Position: refs/heads/master@{#295870}

TBR=clamy@chromium.org,jkarlin@chromium.org,jsbell@chromium.org,rvargas@chromium.org,gavinp@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=413644

Review URL: https://codereview.chromium.org/592503002

Cr-Commit-Position: refs/heads/master@{#295887}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/582258c..665ffc7

TBR=

Review URL: https://codereview.chromium.org/590733002

Cr-Commit-Position: refs/heads/master@{#295886}

In base.gyp, USE_SYMBOLIZE is added for Desktop Linux and
Chrome OS builds for both base and base_unittests. In the GN
build, it's added for 'is_linux' builds (which does not include
Android), but only for base_unittests. This adds the define for
//base as well.

BUG=335824
TEST=build base and base_unittests, make a debug build and force a DCHECK() -- you should get a useful stack trace
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/583263003

Cr-Commit-Position: refs/heads/master@{#295885}

Fix up some issues along the way.

BUG=318404
TBR=nyquist@chromium.org,boliu@chromium.org

Review URL: https://codereview.chromium.org/587893002

Cr-Commit-Position: refs/heads/master@{#295884}

Change the PRESUBMIT to call the script from Blink (run-webkit-tests)
directly.

BUG=338338
TEST=None
R=dpranke@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/583093002

Cr-Commit-Position: refs/heads/master@{#295883}

A previous refactoring had left some duplicate code which fetched the
host list twice!

Review URL: https://codereview.chromium.org/582873004

Cr-Commit-Position: refs/heads/master@{#295882}

This is so it matches with GYP version. This was reported by
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/12122/steps/gyp_flag_compare/logs/stdio

BUG=None
TEST=gn gen out_gn/Debug && ninja -C out_gn/Debug events_base
events_unittests
R=brettw@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/587533002

Cr-Commit-Position: refs/heads/master@{#295881}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0721cb8..582258c

TBR=

Review URL: https://codereview.chromium.org/589873002

Cr-Commit-Position: refs/heads/master@{#295880}

The CL moves the final attribute on BrowserPlugin 'allowtransparency' out to the extensions module! No new content APIs had to be introduced! Transparency can be enabled from RenderWidgetHostView::SetBackgroundOpaque in the content embedder.

This means that BrowserPlugin no longer depends on NPAPI and so this patch removes a lot of unnecessary code.

TBR=asvitkine@chromium.org for histograms.xml, extension_function_histogram_value.h

TBR=asvitkine@chromium.org for histograms.xml, extension
BUG=330264

Review URL: https://codereview.chromium.org/584713002

Cr-Commit-Position: refs/heads/master@{#295879}

Remove the Stable whitelist.

BUG=324071,374440

Review URL: https://codereview.chromium.org/586533003

Cr-Commit-Position: refs/heads/master@{#295878}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d79096c..0721cb8

TBR=

Review URL: https://codereview.chromium.org/579893003

Cr-Commit-Position: refs/heads/master@{#295877}

ViewManager from mojo_shell.

Original cl was https://codereview.chromium.org/477923004/

Failure was
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%284%29/builds/28279
TBR=ben@chromium.org
BUG=

Review URL: https://codereview.chromium.org/584743003

Cr-Commit-Position: refs/heads/master@{#295876}

Since set_message_loop() takes ownership of the MessageLoop
parameter anyway, just pass it a const scoped_refptr<T>&, rather
than converting from scoped_refptr to T* back to scoped_refptr.

BUG=110610
TBR=rvargas@chromioum.org

Review URL: https://codereview.chromium.org/588003002

Cr-Commit-Position: refs/heads/master@{#295875}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/13645ea..3c196de

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/592493002

Cr-Commit-Position: refs/heads/master@{#295874}

- Add a .get() to a boolean test until boolean tests on scoped_refptr
  can be re-enabled.
- Change the test fixture store() accessor to just return a raw pointer,
  since no one depends on it returning a scoped_refptr anyway.

BUG=110610
TBR=stuartmorgan@chromium.org

Review URL: https://codereview.chromium.org/584373002

Cr-Commit-Position: refs/heads/master@{#295873}

This is a silly remnant of the extensions refactor. We go to chrome to go
back to extensions. This removes this API and calls IsWebViewRequest directly.

BUG=352293
TBR=sky@chromium.org for code deletion in chrome_extensions_browser_client

Review URL: https://codereview.chromium.org/590603002

Cr-Commit-Position: refs/heads/master@{#295872}

BUG=
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/590653002

Cr-Commit-Position: refs/heads/master@{#295871}