- 16 Nov, 2018 40 commits
-
-
Christopher Cameron authored
ScopedAccessibilityFocus should have changed the focus to return -[NSWindow accessibilityFocusedUIElement]. TBR=ellyjones Bug: 900846 Change-Id: I7813e4eb7099c69d1106630050b9581b4927d79b Reviewed-on: https://chromium-review.googlesource.com/c/1340911 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#608971}
-
Shawn Gallea authored
Move cursor_shapes interface out of server.cc This CL only moves code around. Bug: 896710 Test: Built on ChromeOS Change-Id: I43f93d25bf08f57d0f111ba99404a1fecb3723da Reviewed-on: https://chromium-review.googlesource.com/c/1324139 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#608970}
-
Michael Thiessen authored
Also refactors control container height resource to match how we handle the control container layout resource. Change-Id: I1ea13d9adf54a01e18cbf9cb5721883a2d0fdab4 Reviewed-on: https://chromium-review.googlesource.com/c/1338330 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#608969}
-
Michael Thiessen authored
This can happen when the Activity is recreated early during initialization, so we handle it be ignoring the saved instance state and loading as usual. Bug: 906172 Change-Id: I010803be39d698425bd1e38b2d34c95f2c658a34 Reviewed-on: https://chromium-review.googlesource.com/c/1340901Reviewed-by:
-
Matthew Denton authored
Deleted our custom sqlite fuzzers that crash on startup. Also added a patch for the upstream version of ossfuzz.c so that it will actually compile and run with our config (SQLITE_OMIT_PROGRESS_CALLBACK and SQLITE_OMIT_AUTOINIT both caused issues). Bug: 900482 Change-Id: Ib314a8589b6c7b6e53704a2ae15bf69c0a62fcdf Reviewed-on: https://chromium-review.googlesource.com/c/1330292 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#608967}
-
Krishna Govind authored
R=abdulsyed@chromium.org Change-Id: I472e2df34f72653c3b0a47b863f58dbbe9eef0b8 Reviewed-on: https://chromium-review.googlesource.com/c/1340336Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#608966}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8ada4d523eb4..5705acabe03a git log 8ada4d523eb4..5705acabe03a --date=short --no-merges --format='%ad %ae %s' 2018-11-16 borenet@google.com [gclient] Make getdep and setdep to provide builtin vars Created with: gclient setdep -r src/third_party/depot_tools@5705acabe03a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:906114 TBR=agable@chromium.org Change-Id: I7cd2e8320bed36ed8d30aa1cf7d8ae6abe1cf766 Reviewed-on: https://chromium-review.googlesource.com/c/1340575Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608965}
-
Alexander Shah authored
Splits |sink_map_| into two maps to differentiate between RootCompositorFrameSinkImpl and CompositorFrameSinkImpl. |sink_map_| is only used for lifetime management. The purpose of the change is to allow greater access to the CompositorFrameSinks than is given through mojom::CompositorFrameSink. R=sadrul@chromium.org Change-Id: I86da2c6094afa9a7d14ca1347c9e636e7c7f08fe Reviewed-on: https://chromium-review.googlesource.com/c/1340789Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Alexander Shah <zandershah@google.com> Cr-Commit-Position: refs/heads/master@{#608964}
-
Ella Ge authored
This reverts commit 390c941f. Reason for revert: causing layout test failure crbug.com/906174 Original change's description: > Stop ExpandRange/EndToSentenceBoundary from using VisiblePosition > > This patch stops the two functions from using VisiblePosition by switch > to the VP-free versions of Start/EndOfSentence(). Hence, this patch > reduces the usage of legacy VisiblePosition. > > Bug: 657237 > Change-Id: I933a020f9bd6643ba1b2cd5111b8be18b2f49086 > Reviewed-on: https://chromium-review.googlesource.com/c/1337816 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608849} TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org Bug: 657237, 906174 Change-Id: I915e9d68f16a11344b0160db4c5702113380273a Reviewed-on: https://chromium-review.googlesource.com/c/1340899 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#608963}
-
Mohamed Heikal authored
WebappActivity inflates its UI asynchronously thus the tab model may not be initialized during early startup. Calling ChromeActivity.getCurrentWebContents (happens on back button press), would crash chrome if the Tab Model is not initialized yet. This cl fixes the issue and makes ChromeActivity.getCurrentWebContents return null instead. Bug: 905583 Change-Id: I4add9cc2f41bb2544e279dd597b7b58a2f68b374 Reviewed-on: https://chromium-review.googlesource.com/c/1340917Reviewed-by:
-
Sam Maier authored
Bug: 872904 Change-Id: If03fdf11044f35fc1a475d9d1b40641fa1d67110 Reviewed-on: https://chromium-review.googlesource.com/c/1340785Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#608961}
-
Bo Liu authored
PreSandboxStartup is called in browser process as well where there is no kLang argument. For browser, the locale is set in PostEarlyInitialization. So check for browser process (empty kProcessType) and skip setting icu locale in PreSandboxStartup. Bug: 905910 Change-Id: Ie2dd1f84b81a61479ae87d96f02c36ea40780bb6 Reviewed-on: https://chromium-review.googlesource.com/c/1340562Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608960}
-
Peter Kasting authored
This updates the comments on the other tests to have TODO form. Bug: 163931, 823543, 824418 Change-Id: Ic82109fb4513a6b8053477ac28e5ee3969799f52 Reviewed-on: https://chromium-review.googlesource.com/c/1334842Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#608959}
-
Oystein Eftevaag authored
This event is extremely frequent and contributes heavily to trace size bloat, which is negatively affecting a lot of the testing infrastructure. Reducing the size of the event and removing the args which are not useful in this case. R=gab@chromium.org BUG=902064 Change-Id: Id7d0ecba3ed084f5ef30d7a29554b14c6a68b963 Reviewed-on: https://chromium-review.googlesource.com/c/1330067 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#608958}
-
Ella Ge authored
This reverts commit 775938b6. Reason for revert: need to revert this to revert r608849 Original change's description: > Change Range::expand() to VisiblePosition-free functions for word and sentence > > This patch changes Range::expand() to call VP-free version of word and > sentence start/end functions, by hoisting the creation of VP from > the functions into itself. In this way we reduce the usage of functions > relying on VP. > > Bug: 657237 > Change-Id: I56ea3cb88972144887eba7701cfdc3628bdbf67b > Reviewed-on: https://chromium-review.googlesource.com/c/1338719 > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608855} TBR=yosin@chromium.org,tkent@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org Bug: 657237, 906174 Change-Id: I46b8df3cfd8ed7f7636f9ef1dabfa350168cb820 Reviewed-on: https://chromium-review.googlesource.com/c/1340906Reviewed-by:
-
Bin Wu authored
Merge internal change: 221684051 R=rch@chromium.org Change-Id: I124ca8f5573966b7c8df35b28793003b834620a4 Reviewed-on: https://chromium-review.googlesource.com/c/1340399Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#608956}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d7cd1203a42b..28d8d7bc673a git log d7cd1203a42b..28d8d7bc673a --date=short --no-merges --format='%ad %ae %s' 2018-11-16 33432579+alan-baker@users.noreply.github.com Fix min base alignment (#2075) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@28d8d7bc673a The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1edd77b44e26cb3624ede1bb0f42ecea2c74c249 Reviewed-on: https://chromium-review.googlesource.com/c/1340573Reviewed-by:
-
Aiden Benner authored
See bugs for rationale Bug: 904912,906160 Change-Id: Ib3e45f2eee2189e90179a6857e5878342c9393ce Reviewed-on: https://chromium-review.googlesource.com/c/1340900Reviewed-by:
-
Ella Ge authored
This reverts commit 4c95576e. Reason for revert: live-edit-no-reveal.js failed on mac bots crbug/906189 Original change's description: > [LayoutTest] Rebaseline live-edit-no-reveal.js after V8 roll > > Bug: V8:8405 > Change-Id: I150f74bf5de8c0a2cd784e6d1399c1c702c2936e > Reviewed-on: https://chromium-review.googlesource.com/c/1339961 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Dan Elphick <delphick@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608839} TBR=rmcilroy@chromium.org,delphick@chromium.org Change-Id: I8d115789c789b22379fc95e418af388edeaea41b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: V8:8405, 906189 Reviewed-on: https://chromium-review.googlesource.com/c/1340943Reviewed-by:
-
Robert Kroeger authored
WebglConformance_conformance_textures_video_tex_2d_rgba_rgba_unsigned_short_5_5_5_1 is failing intermittently on Nexus9. Suppress. BUG=906158 TBR=kbr@chromium.org Change-Id: I1311556d5d2fc040c2b9e7c256a25b1bf0a7c18d Reviewed-on: https://chromium-review.googlesource.com/c/1340866Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#608952}
-
Bruce Dawson authored
ARM64 on Win32 adds a third Win32 target platform which requires updates to the script which configures the toolchain. This includes handling build\win_toolchain.json listing either two or three toolchains, and not copying UCRT DLLs in the ARM64 case, except for ucrtbased.dll. This also fixes some erroneous double quotes, probably left over from previous changes I made to this file. This is in preparation for landing and then using crrev.com/c/1330185 Bug: 893460 Change-Id: I1fa775b662e3c0483174c32ad3c73f30f2802ea9 Reviewed-on: https://chromium-review.googlesource.com/c/1339101Reviewed-by:
-
Lily Chen authored
This reverts commit dc8c60c3. Reason for revert: Bug causing crashes was fixed in https://crrev.com/c/1333135 Original change's description: > Revert "Add reprioritization to SSLConnectJobs" > > This reverts commit 8a9302e2. > > Reason for revert: Causing flaky crashes in external/wpt/webusb/idlharness.https.any.worker.html > > Original change's description: > > Add reprioritization to SSLConnectJobs > > > > This change allows the priority of an SSLConnectJob to be changed. If > > the reprioritization occurs while the job is establishing its underlying > > connection, the priority change is also passed down to the lower-level > > socket pool. > > > > Bug: 166689 > > Change-Id: I87d1e536846443901cc628423f4615c3ffa7542a > > Reviewed-on: https://chromium-review.googlesource.com/c/1327423 > > Commit-Queue: Lily Chen <chlily@chromium.org> > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#606876} > > TBR=mmenke@chromium.org,chlily@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 166689, 904345 > Change-Id: I6458798e11d210258f2a26330548f1ca33eb6c90 > Reviewed-on: https://chromium-review.googlesource.com/c/1331139 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Lily Chen <chlily@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607301} TBR=mmenke@chromium.org,chlily@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 166689, 904345 Change-Id: I54fe803331be6fe3df534c0f6042bf0fb0057cbb Reviewed-on: https://chromium-review.googlesource.com/c/1340824Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#608950}
-
Min Qin authored
Currently DownloadDB records some of the persistent for DownloadItem. And DownloadItem will constantly requesting these data from the DownloadDBCache during its life cycle. Which is unnecessary as these data are already passed to DownloadItem during the creation time. This CL allows DownloadItem to cache those persistent data after creation. So there is no longer any need to request them again, and we can remove them from the DownloadDBCache in future CLs to save memory. BUG=893651 Change-Id: Ic360bd81e283272105ef9d43d91e2b8dd00d9145 Reviewed-on: https://chromium-review.googlesource.com/c/1338328Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608949}
-
Evan Stade authored
It was added in 2012 for PrintPreviewTest but is no longer needed and is causing issues with single process mash tests, where OzonePlatform only expects to get initialized once. If this happens in a test's SetUp(), and parts of it get destroyed by the AtExitManager, they won't be re- initialized for later tests. Tests will still pass in isolation but not when run as a suite. This CL also simplifies PrintPreviewTest a bit, which is the test fixture for which the AtExitManager was originally added. Bug: 905430 Change-Id: I4617aed098962f4eea6a9d1bfe052e3902278557 Reviewed-on: https://chromium-review.googlesource.com/c/1340798Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#608948}
-
Justin Cohen authored
This happens when clearing browser data, and forces the NTP to be recreated (and not show previous NTP tiles). Bug: 905735 Change-Id: If818e02703c7324f0a660bf6b115603db3682b74 Reviewed-on: https://chromium-review.googlesource.com/c/1339340Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608947}
-
Ella Ge authored
TBR=kbr@chromium.org BUG=906092 Change-Id: I11105b926d35b5bcb16c2930c04f98db20e5f4b4 Reviewed-on: https://chromium-review.googlesource.com/c/1340788Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/09299cdfd973..4d0fac4a2c9e git log 09299cdfd973..4d0fac4a2c9e --date=short --no-merges --format='%ad %ae %s' 2018-11-16 tsepez@chromium.org Remove some unused strings from CFX_CSSData tables. Created with: gclient setdep -r src/third_party/pdfium@4d0fac4a2c9e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7108ae0af76028e59a5cc51eeedcf69a9094f9fc Reviewed-on: https://chromium-review.googlesource.com/c/1340572Reviewed-by:
-
Toni Barzic authored
The larger goal is to stop using sign-in profile after a user session starts (with hopes that it will eventually be possible to shut the profile down after sign-in completes). BUG=901768 Change-Id: Ic019113cad1284cffb50581d3e52b891cd509ff5 Reviewed-on: https://chromium-review.googlesource.com/c/1338866Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#608944}
-
Nico Weber authored
Bug: none Change-Id: I4cd719751f4962bd80c7f9b6531535e15a1d3d99 Reviewed-on: https://chromium-review.googlesource.com/c/1340520 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#608943}
-
Jesse McKenna authored
TaskScheduler: Make method ordering consistent between SchedulerWorkerPoolImpl:: and SchedulerSingleThreadTaskRunnerManager::JoinForTesting This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1338140 Bug: 889029 Change-Id: I1c179f6617bac417fb54c55e9328e2391d2d7b5b Reviewed-on: https://chromium-review.googlesource.com/c/1340360 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#608942}
-
Joe Downing authored
This change adds a DataChannelHandler for Action messages and ties it into ClientSession. When a new handler is created, it will receive an ActionExecutor (added in a previous CL) which is used to invoke the requested action. BUG: 892434 Change-Id: I56b60fdc56b89900297943eafe78f50982b7681f Reviewed-on: https://chromium-review.googlesource.com/c/1294715Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#608941}
-
Johannes Henkel authored
This directory is rolled manually and thus far does not contain anything that's synced in by gclient or similar. So it's confusing to have it in .gitignore because it makes it easy to forget updating things in it this way. an automatic deps mechanism, but for now this should be it. PS: We may later add this back, if we end up going with Change-Id: I74441dd50055efa860dd793789786b42c6c0fa2b Reviewed-on: https://chromium-review.googlesource.com/c/1338720 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608940}
-
Tarun Bansal authored
Enable DataReductionProxyMainMenu by default. This has been enabled for 99% of population for over a year. Also, remove the variation param "persistent_menu_item_enabled" since we decided not to launch with that setting. See the bug for more details. Change-Id: I551f90132e3a5daaedd544cd7847c0949400f09f Bug: 905911 Reviewed-on: https://chromium-review.googlesource.com/c/1338883Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#608939}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/417ac91cdb06..e4634a13a74d git log 417ac91cdb06..e4634a13a74d --date=short --no-merges --format='%ad %ae %s' 2018-11-16 jmadill@chromium.org Apply code formatting. 2018-11-16 ynovikov@chromium.org Vulkan: Handle VK_ERROR_DEVICE_LOST 2018-11-16 jmadill@chromium.org Use angle::Result in front-end (Part 9) Created with: gclient setdep -r src/third_party/angle@e4634a13a74d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I54172fc246c9772b6b184cdd9e131f366c31e228 Reviewed-on: https://chromium-review.googlesource.com/c/1340390Reviewed-by:
-
Bettina authored
We created another uninstall reason when uninstall functionality was made available in Chrome Web Store but didn't update the condition for showing the uninstall URL. I've re-enabled the browser test for EnsureExtensionUninstallURLIsActiveTabAfterUninstall since I've run the test 100 times in one run and 600 times in another run and it did not fail. Bug: 900554 Change-Id: I805840717709606a8e98d1c82cbea2b611efdfd6 Reviewed-on: https://chromium-review.googlesource.com/c/1336522 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608937}
-
Vlad Tsyrklevich authored
This change is preparing for an upcoming refactor. kFreePagesNumBits and kGpaMaxPages are equivalent. Get rid of the latter with a static_assert() that kGpaMaxPages is always equal to the size of the BitMap. Bug: 896019 Change-Id: I7e99766d2e6fffa0e3d3eb3a47a2e76038b522ab Reviewed-on: https://chromium-review.googlesource.com/c/1340526Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#608936}
-
Vlad Tsyrklevich authored
Get rid of the SlotMetadata constructor/destructor and replace the destructor with a Destroy() method. Also change alloc_ptr to be a uintptr_t. This refactor makes SlotMetadata safer to initialize with out-of-process memory in an upcoming crash handler change, because the SlotMetadata we read should not be automatically destructed (the members will be from another memory space). Since alloc_ptr is only used in the crash handler there's no reason to not make it a uintptr_t to make it appear less like a pointer in crash handler's memory space. Bug: 896019 Change-Id: I3f1f22eac6277722de9594a3331b8daef618d29d Reviewed-on: https://chromium-review.googlesource.com/c/1340868 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
-
Aaron Krajeski authored
Provide a pointer to SecurityOrigin within SVGFEImageElement so that it can test if its content actually taints the origin. Previously all filters with feImages tainted the canvas. When the filter is set (during CanvasRenderingContext2DState::SetFilter) the SecurityOrigin is stored. During CanvasRenderingContext2DState::GetFilter is it determined whether the compiled filter should taint the canvas. Next step is to make this work for other svg_fe elements. Change the test expectations for SVGFEDisplacment tests as FEImages no longer necessarily taint the origin. Reverting changes here: https://chromium-review.googlesource.com/c/chromium/src/+/782649/ Bug: 618871 Change-Id: I506c443f842068f08eab0e3d6b214f2b10878a86 Reviewed-on: https://chromium-review.googlesource.com/c/1258968 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#608934}
-
Shawn Gallea authored
Move wl_seat interface out of server.cc, removed usage of keyboard and pointer for cast shell. Bug: 896710 Test: Built on ChromeOS Change-Id: I3e91381883ff028e684b5c4bfbb1dd744cf31ed8 Reviewed-on: https://chromium-review.googlesource.com/c/1324099 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
-
Robert Flack authored
In BGPT, each KeyframeModel on a given Animation may need to animate a different ElementId, as the various effects of an element are split into multiple different nodes in some of the same node trees. This change sets the ElementId on the keyframe model and uses that when applying mutations. Since animations currently expect to look for the existence of a single element, this patch also modifies PaintPropertyBuilder to construct each node type that may be needed for an animation when any property is being animated on an element and then uses the kPrimaryEffect id to check whether this has happened. This also makes several changes to plumb the proper list of element ids: - Register all ancestor ElementIds in PaintArtifactCompositor::Update. - Synchronize registered ids during commit. - Synchronize registered ids during activation. Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Bug: 896549 Change-Id: I717822a1ca174658ef792005e76613a5033f4f6a Reviewed-on: https://chromium-review.googlesource.com/c/1297305Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608932}
-
