- 08 Jul, 2020 40 commits
-
-
Lily Chen authored
Based partially on earlier draft by morlovich: https://crrev.com/c/1038245 Bug: None Change-Id: I98ad46c6b3ed83d2af5ad9a565008829cf5cdba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284134 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Steven Bingler <bingler@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#786309}
-
Jason Chase authored
As a follow up to cl/21773473 [1], there are now 3 code locations that get the current script url from the V8 stack. Each location had their own helper function with very similar logic. This CL extracts the equivalent logic into a reusable function, and uses the new function in all 3 locations. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2173473/13/third_party/blink/renderer/core/loader/http_equiv.cc#53 Bug: 1073920 Change-Id: I237144bc1cfa75f5beecc9977f522549d8c1fbaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273599Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#786308}
-
Peter Kotwicz authored
This CL refactors ChromeStrictMode so that proguard removes the strict mode detection code in canary/beta/stable release builds. BUG=1038384 Change-Id: Ic03f6df3b479e023e7a63de5c8a386098968b793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280604Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#786307}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cdb7febb0552..c103a111af91 2020-07-08 primiano@google.com Docs: fix typos 2020-07-08 treehugger-gerrit@google.com Merge "tp: store argv from ProcessTree in process table and show in UI" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iae3d637e9655b0cd4747b828a250ea2edc715fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287774Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786306}
-
ckitagawa authored
As I understood it, a local frame needed to be loaded to reach the point where an embedding token was requested in LocalFrameView::CapturePaintPreview(). However, canary crash reports suggest it is possible a token may gone at this point (either the frame is unloaded or had yet to finish navigating). As such, we should check for the token and if it is not present capture should proceed as if the frame could not be captured separately (this appears to be a very rare case). Bug: 1103157 Change-Id: I8a2d244cdf5e453807ef9a229a55671895a2231e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287811Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#786305}
-
Matthew Mourgos authored
Before this, the MessageCenterObserver was used to allow the ShelfModel to keep track of existing notifications. This allowed the ShelfModel to correctly update the apps that had a notification. In this CL, the ShelfController no longer observes the MessageCenter and instead observes the AppRegistryCache to get notification updates. With this method, the ShelfModel no longer needs to keep a map of existing notifications. Instead, the AppRegistryCache calls OnAppUpdate() whenever an app's notification badge status has changed. Also, in order to get the initial notification badge status for new ShelfItems, the ShelfControlelr observes changes to the ShelfModel. When a new item is added to the model, the ShelfController uses the AppRegistryCache to update the model with the current notification badge status. Bug: 1080827 Change-Id: I1c37626170387a8e81cec0f6f3c06026ac62a976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219164Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#786304}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0c87b32429bf..f8597f282852 2020-07-08 khokhlov@google.com [Telemetry] Only use Perfetto sync when all agents produce proto traces If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1102378 Tbr: rmhasan@google.com Change-Id: Iab0c2a479bbc29580d7b333b336262813a14e9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287773Reviewed-by:
-
David Jean authored
Bug: 1079425 Change-Id: Ib39c9280714bd7f386d74979d9849f832957ad0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270063 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#786302}
-
Andy Lu authored
From the debugger, it was found that there were legitimate use cases where we would hit the DCHECKs (such as handling tab-opening intents from a cold start), causing a crash. Removing the DCHECKs fixes the issue. My feature that I am trying to implement: https://chromium-review.googlesource.com/c/chromium/src/+/2236243 Bug: 1102418 Change-Id: Ib0fe8ec238b271ec09d6ab3b6cfd8427555f5e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283575Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Andy Lu <andyhylu@google.com> Cr-Commit-Position: refs/heads/master@{#786301}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3444a49d77b0..e88c95e516b6 2020-07-08 hbos@webrtc.org [Stats] Add more rtc::Thread::ScopedDisallowBlockingCalls to getStats(). 2020-07-08 tommi@webrtc.org Remove unused GuardedAsyncInvoker class 2020-07-08 handellm@webrtc.org Revert "Migrate test/time_controller to webrtc::Mutex." 2020-07-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b5359525..a69b9c61 (785857:786202) 2020-07-08 hbos@webrtc.org [Stats] Optimization: Minimize number of thread-invokes in getStats(). 2020-07-08 mbonadei@webrtc.org Revert "Implement packets_(sent | received) for RTCTransportStats" 2020-07-08 handellm@webrtc.org Migrate modules/audio_device to webrtc::Mutex. 2020-07-08 handellm@webrtc.org VideoAnalyzer: remove lock recursions. 2020-07-08 handellm@webrtc.org Migrate test/pc/e2e to webrtc::Mutex. 2020-07-08 mbonadei@webrtc.org Add possibility to expand strings in the autoroller. 2020-07-08 handellm@webrtc.org Migrate test/time_controller to webrtc::Mutex. 2020-07-08 handellm@webrtc.org Migrate modules/congestion_controller to webrtc::Mutex. 2020-07-08 titovartem@webrtc.org Fix thread usage in PC level tests for getting to the IceConnected state 2020-07-08 handellm@webrtc.org Logging: reduce locking frequency by fixing TODO. 2020-07-07 handellm@webrtc.org Revert "Migrate video/ except video/end_to_end_tests and video/adaptation to webrtc::Mutex." 2020-07-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fa6a9612..b5359525 (785707:785857) 2020-07-07 handellm@webrtc.org Migrate pc/ to webrtc::Mutex. 2020-07-07 handellm@webrtc.org Migrate video/ except video/end_to_end_tests and video/adaptation to webrtc::Mutex. 2020-07-07 handellm@webrtc.org Migrate modules/remote_bitrate_estimator to webrtc::Mutex. 2020-07-07 handellm@webrtc.org Migrate video/adaptation and video/end_to_end_tests to webrtc::Mutex. 2020-07-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5f083e73..fa6a9612 (785559:785707) 2020-07-07 handellm@webrtc.org Migrate modules/audio_coding, audio_mixer/ and audio_processing/ to webrtc::Mutex. 2020-07-07 handellm@webrtc.org Migrate media/ to webrtc::Mutex. 2020-07-07 handellm@webrtc.org Migrate common_video/ and examples/ to webrtc::Mutex. 2020-07-07 ivoc@webrtc.org Update default max nr of packets to 200. 2020-07-07 handellm@webrtc.org Migrate modules/rtp_rtcp to webrtc::Mutex. 2020-07-07 handellm@webrtc.org Migrate modules/video_coding to webrtc::Mutex. 2020-07-07 titovartem@google.com Implement packets_(sent | received) for RTCTransportStats If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ida1605b68ce1bb4c568c7fddee238f84aeb98aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287775Reviewed-by:
-
Nate Fischer authored
This renames system_webview_pak_whitelist to system_webview_pak_allowlist. Fixed: 1101022 Test: build with `is_official_build = true` Change-Id: I56a11427132d8b3b143a830ba9dba098fe39d697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285504 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie5b8e90808748c59f7c03a2ccfa63eb1338b83e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287375Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/28159ee9c8e3..49a334846e76 2020-07-08 amaiorano@google.com Enable Kokoro LLVM 10 builds on Windows 2020-07-08 amaiorano@google.com Add llvm-10 configs for Windows 2020-07-08 amaiorano@google.com Copy and modify update.py for LLVM 10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I6ff199ab3f09e2ccb0423809cee47a4a61cf055e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287770Reviewed-by:
-
James Cook authored
Clean up a couple items related to the (deleted) mojo pref service. sync_preferences::PrefServiceSyncable doesn't make mojo calls anymore. prefs::PersistentPrefStoreClient doesn't exist. Bug: none Change-Id: I7640290a94aa3c2697c825dc6929b239b9574f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285920 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#786296}
-
Gavin Williams authored
Any local printer available to be printed to should always be present in CupsPrintersManager. So when requesting a printer status, if the requested printer is not available in CupsPrintersManager, return a Connecting to Device error. Bug: 1059607 Change-Id: I010545a57c896be4111e4e647ecb82bbb6804ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287376Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#786295}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9ad6107a3779a4f928cb4673acbabbf468c4f98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287374Reviewed-by:
-
Renato Silva authored
Add a feature flag for the PIN auto submit feature. Also add methods to store the user's PIN length in local state. Bug: 1075995 Change-Id: I2b307acefd5e39dd0deed747a0ef03c20be76899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287709 Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#786293}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/0f35b042e02e..96fb73efd5c6 2020-07-07 wl@gnu.org Fix clang warnings. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I7397766bf9b3c2d90235d8f94a169f261a7dec18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287769Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#786292}
-
Philip Rogers authored
CompositorAnimations::AttachCompositedLayers no longer needs to check for PaintLayers or the existence of a cc::Layer because these are now guaranteed with Animation::CheckCanStartAnimationOnCompositor, called from Animation::PreCommit, which checks if property tree nodes exist. This patch enables future supports for composited animations without PaintLayers (see: https://crrev.com/c/2250514). Bug: 1101002 Change-Id: I414b48d2586038cb818239a51c4b716204464ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283383Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#786291}
-
Kristian Kirs authored
GetRawDataResource assumes that underlying files are not compressed, whereas LoadDataResourceString automatically decompresses if necessary. Bug: 1068407 Change-Id: I03b5833fb245460d60a3206985cc905efdbf6cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270225Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#786290}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594202362-b0a6f43d52064bea3bb530e07058a845cbb3d6d1.profdata to chrome-win32-master-1594205767-6ce6d14294fc2a08f2b1164184f19ff8db079629.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib3935e0daad73d783cc9ff47c33e9355f45102e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287148Reviewed-by:
-
Saurabh Nijhara authored
As per the requirement of device policy, MinimumChromeVersionEnforced, it is required to show message on the management page in case update is required as per policy when device does not meet the minimum chrome version but device cannot be updated as it has reached its end of life. A message is also to be shown on the OS settings page which would be added in a subsequent CL. Bug: 1048607 Change-Id: Ia014ee3e930bd9856e78878e7b189c021b7b9879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264293 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#786288}
-
Anatoliy Potapchuk authored
Previously, if the browser process crashed during Web kiosk session, we would have just exited the session. This cl leverages the new kiosk launch logic, where we abstract out KioskAppLauncher. Bug: 1054382 Change-Id: Ia8bed81f839b7f7f81d703e8a03af58e768d0fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279121 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#786287}
-
Michael Crouse authored
This reverts commit 6ea86d08. Reason for revert: Tests are flaky on ChromeOS, so reverting until I can solve it. crbug/1103155 Original change's description: > [LiteVideo] Do not attempt LiteVideos on Reloads/Forward-Back. > > This change prevents LiteVideos from being attempted when the > navigation is a reload or forward-back page transition. It also > adds an entry for host of the navigation to the user blocklist to > allow users to soft opt-out of the optimization if they reload > frequently on a host. > > A future change will clear the blocklist when the browser history > is wiped. > > Bug: 1096796 > Change-Id: I687d4c9cd0844d7475f6a3baedacebcf73a48845 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276681 > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Auto-Submit: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786127} TBR=tbansal@chromium.org,sophiechang@chromium.org,rajendrant@chromium.org,mcrouse@chromium.org Change-Id: Id708961e3c7f961a8670ad4c3eb2ee30881e7305 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1096796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287378Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#786286}
-
Maciek Kumorek authored
The WinHttpAddRequestHeaders expects a fully formatted header: Key: Value\r\n Only the value of content-type header was passed. This change fixes the issue. Bug: 1102579 Change-Id: I1b432312bbba161f833de99dfda1ef9e4b39135d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283927Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Maciek Kumorek <makumo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#786285}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5a33f21a483b..cfbb56c6e180 2020-07-08 fmalita@chromium.org [skottie] Auto-orient fixes 2020-07-08 jvanverth@google.com Replace remainder of HRESULT checks with macro 2020-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 8b80e852bd6c to 3688cb363ccd (9 revisions) 2020-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 92554d75f354 to 7622be0544b0 (6 revisions) 2020-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f6f11215cd93 to 28159ee9c8e3 (1 revision) 2020-07-08 robertphillips@google.com Update DDL test harness to use GrDirectContexts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1091259 Tbr: mtklein@google.com Change-Id: I8e972d137003a43784862fe82e0c847e703f2f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287771Reviewed-by:
-
Anastasia Helfinstein authored
AX-Relnotes: n/a. Bug: 897365 Change-Id: I8a3691d56d5a12d15d382ae8f7f60ef629fc75e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285077 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#786283}
-
Chris Sharp authored
Change-Id: I2c3f9fbea344fd031e7249f2b9b6e18976472952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286952 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#786282}
-
Rushan Suleymanov authored
Prior to this patch any favicon change on iOS devices would cause bookmark reupload on each remote update (which contained favicon). Furthermore, any remote update with favicon could trigger favicon changed event. This CL checks if there is actual favicon in specifics before updating current entity on favicon changed event coming from the BookmarkModel. It is prevents entity from being reuploaded without favicon on incremental remote update. Bug: 1075709 Change-Id: Ie15dcc62160a0851b2ce8e40ce0ef20eff43f995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283214 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#786281}
-
David Van Cleve authored
Right now we LOG(FATAL) when a user provides bad Trust Tokens key commitments through the command line (for local debugging). This was intended to crash Chrome entirely when it's provided a syntactically invalid command line flag during local testing, with the thought that the user would want to know immediately that there was a problem with their testing setup. Sadly, LOG(FATAL)ling from the network service unfortunately just crashes the network service, not Chrome as a whole; this network service crash is not directly user-visible and can lead to confusing behavior like no pages loading. This change alters the log line to a LOG(ERROR) so that the failure remains consistently visible in the command line console without leading to hard-to-diagnose behavior like pages failing to load. Bug: None Change-Id: I70a40b1057140f17754f4c8b479f64256d1bc54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285466 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#786280}
-
David Roger authored
This CL adds a callback to the signin interception bubble. The callback will be called when the user interacts with the inner WebUI (in a follow-up CL) or when the bubble is closed. Bug: 1076880 Change-Id: Ie09df4915965ea1b62c88b5569c7530936f13b2f Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279197 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786279}
-
Javier Ernesto Flores Robles authored
Bug: N/A Change-Id: I379eb1b6865715abbb93677bca12849e2af56243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287436 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#786278}
-
Rainhard Findling authored
* This CL aligns the Chrome cleaner child element behavior with the latest mocks for all states except the "safe" states, which will be updated in a separate CL. Bug: 1087263 Change-Id: Ie2b05f879aa6b03ceff97d83f3376a701eedadb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276253 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#786277}
-
Victor Hugo Vianna Silva authored
This is a preparation to allow the user to choose which passwords to save in the 'save unsynced credentials' bubble. To do so, we will modify ManagePasswordsUIController::SaveUnsyncedCredentials() to take the vector of credentials as a parameter. BubbleObserver::AcceptSaveUnsyncedCredentialsPrompt() fakes the user accepting the bubble in this integration test. If it is kept in the new design, it would need to take the credentials as a parameter as well, which renders some expectations in this test completely artificial. So, after this CL, the test no longer verifies that accepting the bubble stores the credentials in the profile store. Instead it only verifies that the bubble is opened. The saving logic is still covered by unit tests in ManagePasswordsUIController. Bug: 1098672 Change-Id: I7a1d752b67934e31d968ac23475026fc0cdc4af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287315 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Andrew Grieve authored
This reverts commit fb07fcff. Reason for reland: Not changing target_sdk_version for angle tests Original change's description: > Revert "Android: Bump default target_sdk_version 24 -> SDK used to compile" > > This reverts commit b7fb15b1. > > Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1099849 > > Original change's description: > > Android: Bump default target_sdk_version 24 -> SDK used to compile > > > > Why do this? > > * It's best practice to target the latest sdk, so this makes for a > > better default. > > * Many targets were neglecting to ever update this value TBR=boliu@chromium.org,torne@chromium.org,agrieve@chromium.org,behdadb@chromium.org Bug: 1099849 Change-Id: I95f36a2b88d2e7ad1d90222f25192c9a915550ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280981Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#786275}
-
Oleh Lamzin authored
Add bluetooth info to the probe service. Bug: b:158658869 Change-Id: Ic17d533e877dd1be3804587ca6126125dec7b869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275880 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#786274}
-
Reilly Grant authored
This change converts callbacks related to Bluetooth Classic service creation from base::Callback to base::OnceCallback. There should be no functional change. Bug: 834319 Change-Id: I99917e7e03a65013f23f4ebd607e1d7eb6a5da64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286589 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#786273}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0b81007941c4..cdb7febb0552 2020-07-08 fmayer@google.com Merge "Keep track of whether client disconnected because of timeout." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1329f16d4364f9dcb021cd7f992b2778e15e89e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287146Reviewed-by:
-
Polina Bondarenko authored
IsRunningAsSystemCompositor must return false, because input should be disabled on ozone platform headless. BUG=b:160309778 TEST=manual Change-Id: I8a97b166b42a581a275c305355f0c4434e5adbbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276426Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5ba63704754faf862e2ef31a934c89463a147980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287372Reviewed-by:
-
