Commits · e322f3c3eae8adf9336efcf5c7923faac3528de5 · eriksson monteiro / tangled

01 Sep, 2014 5 commits

Make apps grid view scroll vertically in experimental app list. · e322f3c3

mgiuca authored Aug 31, 2014

Scrolling remains horizontal in the normal (and centered) app lists.

BUG=406222
TEST=Run with --enable-experimental-app-list --show-app-list. Apps grid
view should scroll vertically. Normal app list should still scroll
horizontally.

Review URL: https://codereview.chromium.org/491973004

Cr-Commit-Position: refs/heads/master@{#292826}

e322f3c3

disable WebRtcAecDumpBrowserTest.*CallWithAecDump* on Dr.Memory bots · fda1919d

zhaoqin authored Aug 31, 2014

TBR=phoglund@chromium.org
BUG=389132
NOTRY=true

Review URL: https://codereview.chromium.org/518173004

Cr-Commit-Position: refs/heads/master@{#292825}

fda1919d

exclude test AudioInputTest.Record · 96f06e77

zhaoqin authored Aug 31, 2014

TBR=henrika@chromium.org
NOTRY=true
BUG=409485

Review URL: https://codereview.chromium.org/528653002

Cr-Commit-Position: refs/heads/master@{#292824}

96f06e77

Replace NPObject usage in ppapi with gin · 9111ba5a

raymes authored Aug 31, 2014

This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.

There are 4 major parts to this CL:
1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.

BUG=351636

Committed: https://chromium.googlesource.com/chromium/src/+/21f446ae855d60cc896b40cb9a3249ed07f150b3

Committed: https://chromium.googlesource.com/chromium/src/+/ee49e63baf57e503bd71dfe61c8a80df63eac9aa

Review URL: https://codereview.chromium.org/459553003

Cr-Commit-Position: refs/heads/master@{#292823}

9111ba5a

Fix ProductTest.ProductInstallBasic and InstallerStateTest.InitializeTwice flakes. · 4b1d16a9

grt authored Aug 31, 2014

Use registry virtualization so that stale data on the test machines
don't interfere with the tests.

BUG=375739

Committed: https://chromium.googlesource.com/chromium/src/+/6d6ac988d6a7a311876f3b0d0257086ac58c8181

Review URL: https://codereview.chromium.org/521703002

Cr-Commit-Position: refs/heads/master@{#292822}

4b1d16a9

31 Aug, 2014 12 commits

remoting: Suppress a clang warning that fires in atl headers. · f49fcfbf

Nico Weber authored Aug 31, 2014

Suppresses

In file included from ..\..\remoting/host/verify_config_window_win.h:10:
..\..\third_party\wtl\include\atlapp.h(1683,17) :  warning(clang): using namespace directive in global context in header [-Wheader-hygiene]
using namespace WTL;
                ^

BUG=5027,82385
TBR=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/526863002

Cr-Commit-Position: refs/heads/master@{#292821}

f49fcfbf

[Local NTP] Implement style updates for Material Design · 00f25d4b

huangs authored Aug 31, 2014

Applying new styling, with some refactoring and bug fixes. Details:

- Sizing and positioning tweaks.
- Change of assets for "X" and for default favicon (if it's missing).
  - Using image as mask, and setting color by CSS (since design uses
    solid colors).
- The new PNG files have been minimized.
- Fixed bug: "Undo" and "Restore All" links continue to be selectable
  via tab after they fades out.
- Alternative Google logo (white): using image as mask and setting
  background color to #eee.  Will delete old image for M39.
- Theme title color in title.html <iframe>: now injecting it from local
  NTP in "c=RRGGBBAA" format. The old behavior of reading it from
  <iframe> and using it to override "c=RRGGBB" are kept, for
  compatibility with server-side NTP.

BUG=407943
NOTRY=1
R=mathp@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/512583002

Cr-Commit-Position: refs/heads/master@{#292820}

00f25d4b

Skia roll 21e6135:700a78d · 1678589c

skia-deps-roller authored Aug 31, 2014

https://skia.googlesource.com/skia/+log/21e613505562368e7719215f824fa8b3b4be652d..700a78d72fdf4f09b28446818028b39f31e26b38

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/525973002

Cr-Commit-Position: refs/heads/master@{#292819}

1678589c

Revert of Revert of clang/win: Fix a few warnings in targets not in... · beb9fd30

thakis authored Aug 31, 2014

Revert of Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #1 id:1 of https://codereview.chromium.org/519463003/)

Reason for revert:
Reland, wasn't the reason for the redness. (https://codereview.chromium.org/521703002/ was.)

Original issue's description:
> Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/)
>
> Reason for revert:
> Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481
>
> InstallerStateTest.InitializeTwice (run #1):
> [ RUN      ] InstallerStateTest.InitializeTwice
> c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
>   Actual: false
> Expected: true
> [  FAILED  ] InstallerStateTest.InitializeTwice (219 ms)
>
> InstallerStateTest.InitializeTwice (run #2):
> [ RUN      ] InstallerStateTest.InitializeTwice
> c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
>   Actual: false
> Expected: true
> [  FAILED  ] InstallerStateTest.InitializeTwice (109 ms)
>
>
> Original issue's description:
> > clang/win: Fix a few warnings in targets not in chromium_builder_tests.
> >
> > Also don't use "default" as a variable name, as it's a keyword.
> > Also fix a bug where a wstring was passed to %ls.
> >
> > No real behavior change.
> >
> > BUG=82385
> > R=hans@chromium.org
> > TBR=cpu, vitalybuka
> >
> > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09
>
> TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=82385
>
> Committed: https://chromium.googlesource.com/chromium/src/+/dae20dafcfd3ccc439ccc5b3d5e21ad611d13c23

TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=82385

Review URL: https://codereview.chromium.org/525013003

Cr-Commit-Position: refs/heads/master@{#292818}

beb9fd30

Updating trunk VERSION from 2142.0 to 2143.0 · 4c26e0a5
chrome-tpm authored Aug 31, 2014
```
Cr-Commit-Position: refs/heads/master@{#292817}
```
4c26e0a5

Revert of EasyUnlock: Work around the ghost overlay from CSS animation.... · 39e1410e

xiyuan authored Aug 31, 2014

Revert of EasyUnlock: Work around the ghost overlay from CSS animation. (patchset #3 id:40001 of https://codereview.chromium.org/487373002/)

Reason for revert:
No longer needed since underlying blink issue http://crbug.com/405250 is fixed.

Original issue's description:
> EasyUnlock: Work around the ghost overlay from CSS animation.
>
> BUG=404779
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290743

TBR=tbarzic@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404779

Review URL: https://codereview.chromium.org/521343002

Cr-Commit-Position: refs/heads/master@{#292816}

39e1410e

Automated Commit: Committing new LKGM version 6219.0.0 for chromeos. · 7dc2bfbf
chromeos-commit-bot authored Aug 31, 2014
```
Cr-Commit-Position: refs/heads/master@{#292815}
```
7dc2bfbf

Blink roll a00905c:332a56a · f3a091a1

blink-deps-roller authored Aug 30, 2014

https://chromium.googlesource.com/chromium/blink/+log/a00905c53f2a7e9c79d324b3ac36dc8b05fb0e7f..332a56a9d8e5d800e3a1fb8aa69c241d0ce59912
TBR=

Review URL: https://codereview.chromium.org/525163002

Cr-Commit-Position: refs/heads/master@{#292814}

f3a091a1

Skia roll 9e19ce1:21e6135 · 45a3e743

skia-deps-roller authored Aug 30, 2014

https://skia.googlesource.com/skia/+log/9e19ce1641422857b850cdedaee40927643b2f42..21e613505562368e7719215f824fa8b3b4be652d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/524263002

Cr-Commit-Position: refs/heads/master@{#292813}

45a3e743

Revert of Fix ProductTest.ProductInstallBasic and... · 43160106

ckocagil authored Aug 30, 2014

Revert of Fix ProductTest.ProductInstallBasic and InstallerStateTest.InitializeTwice flakes. (patchset #4 id:80001 of https://codereview.chromium.org/521703002/)

Reason for revert:
Breaks InstallerStateTest.InitializeTwice on XP:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481

Original issue's description:
> Fix ProductTest.ProductInstallBasic and InstallerStateTest.InitializeTwice flakes.
>
> Use registry virtualization so that stale data on the test machines
> don't interfere with the tests.
>
> BUG=375739
>
> Committed: https://chromium.googlesource.com/chromium/src/+/6d6ac988d6a7a311876f3b0d0257086ac58c8181

TBR=robertshield@chromium.org,grt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=375739

Review URL: https://codereview.chromium.org/520863005

Cr-Commit-Position: refs/heads/master@{#292812}

43160106

Blink roll 244a450:a00905c · 223e45cd

blink-deps-roller authored Aug 30, 2014

https://chromium.googlesource.com/chromium/blink/+log/244a450e5891380a808296994588063b762f2a63..a00905c53f2a7e9c79d324b3ac36dc8b05fb0e7f
TBR=

Review URL: https://codereview.chromium.org/520383005

Cr-Commit-Position: refs/heads/master@{#292811}

223e45cd

Fix build error with XCode6/OSX 10.9 SDK · cdb1b2d2

shouqun authored Aug 30, 2014

OpenGL/gl.h is required to be included to make the build pass.

BUG=
TEST=

Review URL: https://codereview.chromium.org/522533002

Cr-Commit-Position: refs/heads/master@{#292810}

cdb1b2d2

30 Aug, 2014 23 commits

Revert of clang/win: Fix a few warnings in targets not in... · 36c364b1

thakis authored Aug 30, 2014

Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/)

Reason for revert:
Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481

InstallerStateTest.InitializeTwice (run #1):
[ RUN      ] InstallerStateTest.InitializeTwice
c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
  Actual: false
Expected: true
[  FAILED  ] InstallerStateTest.InitializeTwice (219 ms)

InstallerStateTest.InitializeTwice (run #2):
[ RUN      ] InstallerStateTest.InitializeTwice
c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
  Actual: false
Expected: true
[  FAILED  ] InstallerStateTest.InitializeTwice (109 ms)

Original issue's description:
> clang/win: Fix a few warnings in targets not in chromium_builder_tests.
>
> Also don't use "default" as a variable name, as it's a keyword.
> Also fix a bug where a wstring was passed to %ls.
>
> No real behavior change.
>
> BUG=82385
> R=hans@chromium.org
> TBR=cpu, vitalybuka
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09

TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=82385

Review URL: https://codereview.chromium.org/519463003

Cr-Commit-Position: refs/heads/master@{#292809}

36c364b1

Skia roll 7843a24:9e19ce1 · 256383aa

skia-deps-roller authored Aug 30, 2014

https://skia.googlesource.com/skia/+log/7843a24ab2c2dc4fe77e82b9689cde953d6abd7c..9e19ce1641422857b850cdedaee40927643b2f42

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/521283002

Cr-Commit-Position: refs/heads/master@{#292808}

256383aa

Retry Set RequestContextObject for PNaCl pexe fetches, to fix On-Demand update. · efd4b3c8

jvoung authored Aug 30, 2014

There was a race condition in the added test check in the previous
attempt. That made the test Super Flaky. This is more noticeable in the
Release builds than the Debug build that I was working with.
(see https://codereview.chromium.org/471233003/)

With a Release build I was able to repro the flakiness (40% failure
over 200 runs). After the fix, I tested 500 runs and the success rate
is now 100%. I can't say it won't flake for other reasons, but
this fixes the main flake that was introduced. Historically,
the test does ocassionally need to be retried due to timeouts,
according to the bot log history. We may want to split the
CORS and the non-CORS test case to see if that will help w/ timeouts.

I didn't want to do that for this patch, since it would get
much more complicated and this is intended for merging to M38.

Retry with the race condition fixed. Also re-enable the test since
it got disabled by another CL for being flaky.

BUG=401755
BUG=315328

Review URL: https://codereview.chromium.org/524683002

Cr-Commit-Position: refs/heads/master@{#292807}

efd4b3c8

Do not show irrelevant registration promos to supervised and guest users · 00b31698

noamsml authored Aug 30, 2014

Hide registration promos for supervised and guest users. Also hide cloud print
connector section and irrelevant "cloud devices" section (since users cannot log
in).

BUG=288614,340893

Review URL: https://codereview.chromium.org/521953002

Cr-Commit-Position: refs/heads/master@{#292806}

00b31698

Blink roll dafd1d0:244a450 · fd8bc125

blink-deps-roller authored Aug 30, 2014

https://chromium.googlesource.com/chromium/blink/+log/dafd1d0b92247b98a38dfa8bc29ceb80e77582f1..244a450e5891380a808296994588063b762f2a63
TBR=

Review URL: https://codereview.chromium.org/528453002

Cr-Commit-Position: refs/heads/master@{#292805}

fd8bc125

Chromecast buildfix: forgot an include. · c23da633

gunsch authored Aug 30, 2014

Was necessary for https://codereview.chromium.org/517213005/.

R=lcwu@chromium.org,damienv@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/526693002

Cr-Commit-Position: refs/heads/master@{#292804}

c23da633

Switch to using WebSettings only for accessibilityEnabled and inlineTextBoxAccess · efb9ce72

aboxhall authored Aug 30, 2014

Depends on https://codereview.chromium.org/495763005/

BUG=406622

Review URL: https://codereview.chromium.org/497273002

Cr-Commit-Position: refs/heads/master@{#292803}

efb9ce72

Blink roll 3bbc0b2:dafd1d0 · 8e3c0419

blink-deps-roller authored Aug 30, 2014

https://chromium.googlesource.com/chromium/blink/+log/3bbc0b2b6d62c60bd38ce576e1af5a68e1e7cb6d..dafd1d0b92247b98a38dfa8bc29ceb80e77582f1
TBR=

Review URL: https://codereview.chromium.org/526703002

Cr-Commit-Position: refs/heads/master@{#292802}

8e3c0419

Roll libjingle/source/talk to r7007. · a6015791

tommi authored Aug 30, 2014

TBR=niklase
NOTRY=true

Review URL: https://codereview.chromium.org/525083002

Cr-Commit-Position: refs/heads/master@{#292801}

a6015791

Change VideoTrackAdapter to not drop frames if the source frame rate is known. · b18d81f6

perkj authored Aug 30, 2014

Also change remote video and pepper plugin MediaStreamVideoSource implementations to not set a guessed frame rate.

BUG= 394315

Review URL: https://codereview.chromium.org/517973002

Cr-Commit-Position: refs/heads/master@{#292800}

b18d81f6

Roll WebRTC 6955:7011 · 3b749672

tommi authored Aug 30, 2014

TBR=niklase@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/526683002

Cr-Commit-Position: refs/heads/master@{#292799}

3b749672

Blink roll b28553b:3bbc0b2 · 5ce28568

blink-deps-roller authored Aug 30, 2014

https://chromium.googlesource.com/chromium/blink/+log/b28553bee158127ed49ff22547f909f49ed9e00a..3bbc0b2b6d62c60bd38ce576e1af5a68e1e7cb6d
TBR=

Review URL: https://codereview.chromium.org/521163002

Cr-Commit-Position: refs/heads/master@{#292798}

5ce28568

Docserver: Rename CompiledFileSystem's GetFileVersion/GetFileListingVersion to · b147f5ec

kalman authored Aug 30, 2014

_GetFileVersionFromCache/_GetFileListingVersionFromCache, because they're
protected not public methods. More importantly, make them return Futures.
Plus a little more cleanup.

These are small changes in preparation to the more interesting patch which
addresses bug 402903.

BUG=402903
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/522183002

Cr-Commit-Position: refs/heads/master@{#292797}

b147f5ec

Skia roll 6d13420:7843a24 · 6102760f

skia-deps-roller authored Aug 30, 2014

https://skia.googlesource.com/skia/+log/6d134201a90692b0c7a1c0c4a97c894dae7b2158..7843a24ab2c2dc4fe77e82b9689cde953d6abd7c

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/521143003

Cr-Commit-Position: refs/heads/master@{#292796}

6102760f

athena: Add an accelerator to abort loading on escape. · a81e6127

Sadrul Habib Chowdhury authored Aug 30, 2014

BUG=none
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/527473002

Cr-Commit-Position: refs/heads/master@{#292795}

a81e6127

Blink roll abff685:b28553b · 7f3a2822

blink-deps-roller authored Aug 30, 2014

https://chromium.googlesource.com/chromium/blink/+log/abff6854093617bd6461c113d1b91f7498b399a0..b28553bee158127ed49ff22547f909f49ed9e00a
TBR=

Review URL: https://codereview.chromium.org/523403002

Cr-Commit-Position: refs/heads/master@{#292794}

7f3a2822

athena: Show a progress-bar when loading a web-page. · a596d7b3

Sadrul Habib Chowdhury authored Aug 30, 2014

BUG=none
R=mukai@chromium.org
TBR=vollick@chromium.org for DEPS addition on //ui/compositor

Review URL: https://codereview.chromium.org/521013004

Cr-Commit-Position: refs/heads/master@{#292793}

a596d7b3

Update libjingle's GN build config to match a recent fix. · d74e0b9e

tommi authored Aug 30, 2014

See here: https://codereview.chromium.org/516143002/

TBR=ajm

Review URL: https://codereview.chromium.org/523073003

Cr-Commit-Position: refs/heads/master@{#292792}

d74e0b9e

Chromecast: command-line switch to override the UMA metric upload URL. · db879ef8

gunsch authored Aug 30, 2014

R=byungchul@chromium.org,isherman@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/506083003

Cr-Commit-Position: refs/heads/master@{#292791}

db879ef8

Skia roll 5c49b70:6d13420 · c0422d5a

skia-deps-roller authored Aug 30, 2014

https://skia.googlesource.com/skia/+log/5c49b70ae3e19620bbecfe72eb68aa4513c4fd18..6d134201a90692b0c7a1c0c4a97c894dae7b2158

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/522163002

Cr-Commit-Position: refs/heads/master@{#292790}

c0422d5a

Revert of Disable UI flags for non-desktop OSes (patchset #4 id:60001 of... · 7371f2ce

mlerman authored Aug 30, 2014

Revert of Disable UI flags for non-desktop OSes (patchset #4 id:60001 of https://codereview.chromium.org/480453002/)

Reason for revert:
This will cause android to lose account consistency. I should not have removed the file!

Original issue's description:
> Disable UI flags for non-desktop OSes
>
> This is mostly to prevent the high res avatars from being downloaded when not necessary, and will also prevent any other non-UI side effects which are undesired on non-desktop OSes.
>
> BUG=404066
>
> Committed: https://chromium.googlesource.com/chromium/src/+/8003a95bb88e1d25ad59251b5d7e8609d76e5669

TBR=noms@chromium.org,rogerta@chromium.org,newt@chromium.org,dzhioev@chromium.org,aruslan@chromium.org,xiyuan@chromium.org,nkostylev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404066

Review URL: https://codereview.chromium.org/524023002

Cr-Commit-Position: refs/heads/master@{#292789}

7371f2ce

Added histogram names to the picture element use counter. · 3d213c35

yoav authored Aug 30, 2014

BUG=408797

Review URL: https://codereview.chromium.org/517343003

Cr-Commit-Position: refs/heads/master@{#292788}

3d213c35

Updating trunk VERSION from 2141.0 to 2142.0 · 55d036cc
chrome-tpm authored Aug 30, 2014
```
Cr-Commit-Position: refs/heads/master@{#292787}
```
55d036cc