GitLab

Bug: 905128
Change-Id: I590981ee93a645cef51586c880b5225ab03f2c29
Reviewed-on: https://chromium-review.googlesource.com/c/1335028Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608573}

https://chromium.googlesource.com/angle/angle.git/+log/666818eacf79..d9ee8bf96207


git log 666818eacf79..d9ee8bf96207 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 jmadill@chromium.org Minor inlining optimization to Context draw calls.
2018-11-15 geofflang@chromium.org Allow querying of all draw buffer states on the default framebuffer.
2018-11-15 geofflang@chromium.org GL: Put commas between vendor and renderer strings.
2018-11-15 brandon1.jones@intel.com Autogenerate Repeated Portions of Blit11


Created with:
  gclient setdep -r src/third_party/angle@d9ee8bf96207

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:882580
TBR=cwallez@chromium.org

Change-Id: Ic31314f096386f95c4e514df1db56065508acd2c
Reviewed-on: https://chromium-review.googlesource.com/c/1338155Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608572}

Also run clang-format on chrome_features.cc.

BUG=826982

Change-Id: I4916b2eeb226ca7e8ed1e73fe7d930b4634c08ee
Reviewed-on: https://chromium-review.googlesource.com/c/1336950Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608571}

This allows targets depending on //third_party/libwebp (as a group target)
to include headers (by marking the public headers of each subtarget as public
headers of the group), including those from the basic :libwebp_webp source set.

This resolves a couple of gn check issues in //third_party/blink/renderer/platform.

Change-Id: I66533ff7b1b1663dd6dce2842cef315e4ec866d8
Reviewed-on: https://chromium-review.googlesource.com/c/1329549Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608570}

TimeDelta::Max() should be used to express infinite timeouts. A large
timeout that is not TimeDelta::Max() causes MessageLoop to output a
warning.

Bug: 889652
Change-Id: Ied1dd02cdeaec18e6d00e7fd3023e5ec1ea77826
Reviewed-on: https://chromium-review.googlesource.com/c/1336030Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608569}

Speculative fix for https://crbug.com/901862

This bug seems very similar to https://crbug.com/791788, which had a
similar fix
https://chromium-review.googlesource.com/c/chromium/src/+/810049

This will affect Jelly Bean as per: https://cs.chromium.org/chromium/src/gpu/config/gpu_driver_bug_list.json?rcl=dba77bd3350d39eac12db8aba801a7ef0c3c190f&l=2017

Bug: 901862
Change-Id: Iccf4f54091ee0fcb5bd077ac5e06b38b83ff55c7
Reviewed-on: https://chromium-review.googlesource.com/c/1338338Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608568}

UpdateMetricsUsagePrefs() is a chain of calls:
- ChromeDataUseMeasurement::UpdateDataUseToMetricsService()
  -> UpdateMetricsUsagePrefs()
  -> MetricsService::UpdateMetricsUsagePrefs()
  -> ReportingService::UpdateMetricsUsagePrefs()
  -> DataUseTracker::UpdateMetricsUsagePrefs()

It can be reduced to:
- ChromeDataUseMeasurement::UpdateDataUseToMetricsService()
  -> UpdateMetricsUsagePrefs()
  -> DataUseTracker::UpdateMetricsUsagePrefs()

This removes the dependency from ChromeDataUseMeasurement to
MetricsService and ReportingService.

Bug: 902791
Change-Id: I38a6d22d1ff823134c79bc342ea32be0f89cda77
Reviewed-on: https://chromium-review.googlesource.com/c/1334267
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608567}

The Mac convention for ObjC objects is that if a callee needs to
have a reference, it should take the reference itself. The
current behavior of gfx::Image's NSImage constructor is surprising
and relying on explaining it in the comment is inadequate.

Note that gfx::Image's UIImage constructor had a similar change
made to it in 2a1f622d.

BUG=904645

Change-Id: I4dab00c3c7f3ff2f73e17520562d728b3a2e52aa
Reviewed-on: https://chromium-review.googlesource.com/c/1335957Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608566}

Bug: 905839
Change-Id: Ib643f63d88ce7a3b6935bda6c37626fee406f2ae
Reviewed-on: https://chromium-review.googlesource.com/c/1338467Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608565}

This reverts commit 50ab16b8.

Reason for revert: crbug.com/905853

Original change's description:
> Introduce bundle-specific native libraries
> 
> This will allow native code to be stripped out of the main library
> when it moves to a Dynamic Feature Module.  For now, the libraries will
> be identical.
> 
> BUG=874584
> 
> Change-Id: I8a54e6402a3686939dd14b509c614da99b0ff913
> Reviewed-on: https://chromium-review.googlesource.com/c/1332248
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Reviewed-by: David Turner <digit@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Commit-Queue: Christopher Grant <cjgrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608519}

TBR=digit@chromium.org,yfriedman@chromium.org,cjgrant@chromium.org,tiborg@chromium.org

Change-Id: I0780066bf999c3c25cc7c8c840abad97105a6762
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 874584
Reviewed-on: https://chromium-review.googlesource.com/c/1337484Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608564}

Shutting down the download manager will not remove in-progress file today.
However, in downloadItemImpl::InterruptWithPartialState(), if the download is
in a resuming state while download manager got shudown, then the file is
removed. This behavior is not consistent.
Since desktop already has the warning dialog when user tries to shut down
Chrome while there are in-progress download, we don't need to keep the
in-progress files. Clicking shut down pretty much means canceling the download.

BUG=901642

Change-Id: I7bcf30b21fca59bf2cc57a23f0a41d49f0639ce8
Reviewed-on: https://chromium-review.googlesource.com/c/1321574Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608563}

When the tab index for the parent element is never set to -1, if focus
leaves the list of items and then returns to it, the focus will
automatically target the most recently focused control. Instead, if
focus leaves the list, focus should return to the first control on the
most recently focused item.

Bug: 896624
Change-Id: I0e33e099f3b15b840d942d23fdccd620810b0806
Reviewed-on: https://chromium-review.googlesource.com/c/1336657
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608562}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ab76e332de7a..c37388f1addd


git log ab76e332de7a..c37388f1addd --date=short --no-merges --format='%ad %ae %s'
2018-11-15 greg@lunarg.com Add passes to propagate and eliminate redundant line instructions (#2027). (#2039)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@c37388f1addd

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ia635916ea8d1ba1c11f1d64f8c876b810909e481
Reviewed-on: https://chromium-review.googlesource.com/c/1337647Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608561}

With this support in overlay swap chain, screen capture on protected videos
will no longer work.

Hardware protected video has been supported in Chrome but it requires the
latest Intel GPU hardware for video decoding. Software protected video does
not require any specific hardware. It will be decoded by Chrome. However, the
first-time support of this feature will limit this feature to Intel hardware
overlay only. Underlays and non-Intel GPUs will be enabled later.

This CL replaces the existing flag |is_protected_video| with
|protected_video_type| which includes clear, softwareProtected and
hardwareProtected. The swap chain creation function will set the correct flags
accordingly.

This CL doesn't include the changes from YUV video draw quad and draw quad mojo.
Those changes will be checked in separately.


Bug:903552

Change-Id: I29a5eb021357b34ce15e7af4e85fccf151399583
Reviewed-on: https://chromium-review.googlesource.com/c/1333997Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608560}

internals.idl previously had Promise<bool>
but bool is not a Web IDL type.

Change-Id: If3541adc87e246a1933f5414e34d1025b32469b6
Reviewed-on: https://chromium-review.googlesource.com/c/1337133Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608559}

This reverts commit 1f5d78a9.

Reason for revert: This CL is, in some cases, preventing Assistant
cards from rendering. Not sure why, but will revert until I can
find the root cause.

Original change's description:
> Change height of Assistant caption bar.
>
> Per change in spec, the Assistant caption bar should be 48dip tall.
> See bug for detailed spec.
>
> Bug: b:119498360
> Change-Id: I40cd7cd44a37b9ca99710dad9311b929373b3797
> Reviewed-on: https://chromium-review.googlesource.com/c/1336525
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Commit-Queue: David Black <dmblack@google.com>
> Cr-Commit-Position: refs/heads/master@{#608232}

TBR=xiaohuic@chromium.org,dmblack@google.com

Change-Id: I7c46f52c84c5b5db6f7e5a8f482d67100f50a911
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:119498360
Reviewed-on: https://chromium-review.googlesource.com/c/1338403Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#608558}

Show a locale feature button in the unified system tray in demo
mode. The UI is implemented in //ash/system, but the data should come
from //chrome.

The mock is in go/CrosDemoLanguage. No additional spec is needed: the
UI is consistent with other buttons in the system tray. The change is
approved by UI review.

Bug: 877749
Change-Id: I23a88584845e432b7762aeac03ab86d659cca07c
Reviewed-on: https://chromium-review.googlesource.com/c/1321775
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608557}

Without this, "mb.py zip" can't include CIPD dependencies, which are
symlinks in the source tree.

Uses kjlubick's earlier work from
https://codereview.chromium.org/2844063005 .

Bug: 850107
Change-Id: Id96b85946ee15bcb2edfcf002016fcaad7b1a98b
Reviewed-on: https://chromium-review.googlesource.com/c/1338238Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608556}

https://android.googlesource.com/platform/external/perfetto.git/+log/3189731cbd9e..9ba32715116d


git log 3189731cbd9e..9ba32715116d --date=short --no-merges --format='%ad %ae %s'
2018-11-15 fmayer@google.com Merge "trace_to_text: add converter to profile proto."


Created with:
  gclient setdep -r src/third_party/perfetto@9ba32715116d

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I40efb7975b137c1cac41dd0abe2ee55b23ac4076
Reviewed-on: https://chromium-review.googlesource.com/c/1338153Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608555}

With OOP-D and SoftwareOutputDeviceX11 being moved to the GPU process
sometimes tooltips aren't showing up immediately. Instead an empty
tooltip window appears until something else happens that causes GPU
process to flush it's output buffer. Add call to XFlush() to prevent
this.

Bug: 892110
Change-Id: I2aba6b9e41286ff6de9a68864d412b45cdcc7345
Reviewed-on: https://chromium-review.googlesource.com/c/1335999Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608554}

New expectations for manual WPT will be appended to NeverFixTests
following https://crrev.com/c/1269759. This CL moves the existing
expectations from TestExpectations to NeverFixTests.

Steps:
1. Move all "external/wpt.*-manual.*[ Skip ]" lines without platform
   specifiers from TestExpectations to NeverFixTests.
2. Replace Skip with WontFix and strip the bug links.
3. Move all manual WPT lines in NeverFixTests to the end of the file
   and sort.

Bug: 738489, 626703
Change-Id: Ie5a22053630e01791e1b13dc371038251ed16489
Reviewed-on: https://chromium-review.googlesource.com/c/1334666Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608553}

UserTimingL3 uses returned value for feature detection. If measure and mark
API returns null, the APIs are L2 API; If the APIs return an entry, the APIs are
L3 API. However, in the current implementation, when L3 API is enabled, the
APIs do not always return the created entry.

This CL is to fix this bug, and add layout tests to verify it.

Change-Id: I9854f0abd0d64a3334701e09d6ce0fc245fcca3e
Reviewed-on: https://chromium-review.googlesource.com/c/1338225
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608552}

https://skia.googlesource.com/skia.git/+log/ce7a16b318c9..2791be403817


git log ce7a16b318c9..2791be403817 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 reed@google.com guard flag
2018-11-15 reed@google.com add flag to guard font apis
2018-11-15 halcanary@google.com SkPDF: pull out SkPDFSubsetFont code to another file.
2018-11-15 caryclark@skia.org fix pathops fuzz


Created with:
  gclient setdep -r src/third_party/skia@2791be403817

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@chromium.org

Change-Id: I00bec7bb8ba68a5485d25cc11d97961bb79c5e58
Reviewed-on: https://chromium-review.googlesource.com/c/1338400Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608551}

Refactor SlotMetadata to break out matching allocation/deallocation info
into a common struct.

Bug: 896019
Change-Id: I6955e43048a30977b502db21f254faf9796d643c
Reviewed-on: https://chromium-review.googlesource.com/c/1338236
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608550}

Stores the profiler in TLS and registers trace log observer for the
thread. If tracing is enabled then IO thread will be profiled.
We observe a lot of janks on IO thread and stack traces will be useful
to debug these traces.

Change-Id: I84f5c5f9c15d957ac2ee807289ddfab24731ef6d
Reviewed-on: https://chromium-review.googlesource.com/c/1330748
Commit-Queue: ssid <ssid@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608549}

Flakes appear to be due to destination store communicating with the
real native layer/print preview handler. Stub out native layer like in
other tests.

Bug: 901115, 905205
Change-Id: I938b6fbecfc5da26a5495e6f9ecbb8fa35b64d4e
Reviewed-on: https://chromium-review.googlesource.com/c/1335998
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608548}

Change-Id: I977413e186201573e71de941d530c5fdf336ca0e
Reviewed-on: https://chromium-review.googlesource.com/c/1337820Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
Cr-Commit-Position: refs/heads/master@{#608547}

Setting tabIndex=-1 no longer allows child elements to be focusable in
Shadow DOM v1 (see bug for additional context).

Remove logic that does this, and in order to prevent focusing of the
parent element when traversing backwards from the first item in the
focus row, listen for shift+tab on this element.

Bug: 896624
Change-Id: I35e871863418e7bca57f648713b8d172677a949c
Reviewed-on: https://chromium-review.googlesource.com/c/1325352
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608546}

Adds a test-only UiInputManager that gets swapped with the real one
anytime we're using the InputDelegateForTesting. Currently, the only
difference is that the testing version always reports that the
controller is not in the viewport.

This is so that pixel diff tests are not flaky based on the initial
orientation of the device - without this, the controller tooltips
would remain visible if the device started pointed slightly down
even though we lock the head pose forward.

Bug: 904012
Change-Id: Ia34944bd9d678c43480ef218b2d740928732f5ae
Reviewed-on: https://chromium-review.googlesource.com/c/1334941
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608545}

Currently, the pref delegate in network quality estimator (NQE) reads
network quality prefs right after startup. However, the underlying pref
service factory is initialized asynchronously by the network_context
(see the linked bug). This results in pref delegate read at startup
returning empty value, irrespective of the actual prefs.

This CL fixes the bug by changing pref delegate to read the pref only
after the pref service has been initialized. This ensures that
when the prefs are read, they actually return what's stored on the
disk, instead of empty values.

Change-Id: I9791c673c0300d6d896f2d8e556c97f01f7e1f52
Bug: 904465
Reviewed-on: https://chromium-review.googlesource.com/c/1333127
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608544}

For 32-bit ARM LLD builds (LTO and non-LTO), the linker map files can
have thousands of symbols with '.L_MergedGlobals' prefix. These symbols
obscure shadow symbols with more informative name.

This CL fixes the problem by making liner map parser  skip symbols with
these prefixes.

Bug: 905329
Change-Id: I2e72b566e17f025bdf147551bd5b569764e0ec16
Reviewed-on: https://chromium-review.googlesource.com/c/1338227Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608543}

These objects are created to satisfy the interface requirements but
have limited and/or reduced functionality. According to naming rules,
they should be called fake*.

Change-Id: I24fcc274b730305b89a8b1c9d269793dbd448a63
Reviewed-on: https://chromium-review.googlesource.com/c/1338202Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608542}

Switching windows or using the Element picker may focus the DevTools
area with relatedTarget=null. In these cases, re-applying node
highlight is not needed.

Bug: 905252
Change-Id: Ie3ae228c9cc404f16598ff428d9e593bb90e33e5
Reviewed-on: https://chromium-review.googlesource.com/c/1336910
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608541}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5ccf40a90be8..ec3b48cc9484


Created with:
  gclient setdep -r src-internal@ec3b48cc9484

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Id675d990cd19ff8a12927084b8f65a77a95cf6ac
Reviewed-on: https://chromium-review.googlesource.com/c/1338152Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608540}

We would like to share one ContextState for all raster decoders and
display compositor. To do that, we need make ContextState work without
a decoder client.

Bug: 902904
Change-Id: I0ebabbf084e864f18b5e5e1bc5d069a3d436718e
Reviewed-on: https://chromium-review.googlesource.com/c/1338383
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608539}

Consider the following circumstance:
- User installs extension Alpha normally (e.g., through the webstore).
  Alpha has Manifest::Location INTERNAL.
- Corp policy pushes out an update that lists Alpha as a required
  extension.

Currently, this behaves fantastically poorly. We validate that the user
is allowed to load an extension on each run of Chrome when loading
installed extensions, and UserMayLoad() will return false if the
extension is required by corporate policy (in order to prevent users
from installing "over" a policy-required extension). This means that
the policy-required extension gets disabled with reason
DISABLE_BLOCKED_BY_POLICY.

Make this slightly less bad by introducing a new policy provider method,
UserMayInstall(). This checks whether the user is allowed to install a
given extension, rather than whether the user is allowed to load it. For
default implementations, UserMayInstall() forwards to UserMayLoad()
(since they should be treated equivalently). However, we can now move
the check for if a Manifest::INTERNAL extension is required policy to
the UserMayInstall() check rather than UserMayLoad(). The effect of this
is to allow the user to load an already-installed extension that's
required by policy, but not policy-installed itself, while still
preventing the user from installing a new copy of that extension.

This is not a perfect solution, since the installed version of the
extension will still be the Manifest::INTERNAL one. This has a number of
implications, including that the extension won't show most policy-
installed indications and won't have access to policy-only APIs. In
extreme cases, the extensions can also be different versions. In the
future, we will need to think about how to handle this scenario more
gracefully.

Bug: 894184

Change-Id: I83c9c305b56f90ea211e4a9b0120b22d601b4fb4
Reviewed-on: https://chromium-review.googlesource.com/c/1327616
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608538}

These should reproduce (at least) these issues:
 - https://crbug.com/622128 - dark areas brought in from edges
 - https://crbug.com/632979 - dark areas brought in from edges
 - https://crbug.com/659501 - menus cause too much filtering
 - https://crbug.com/767997 - menus cause too much filtering
 - https://crbug.com/813796 - incorrect border used for filter
 - https://crbug.com/593307 - incorrect border used for filter

Bug: 497522,622128,632979,659501,767997,813796,593307
Change-Id: Iafea2fc8fffba950f74d27f21170df647dc62e29
Reviewed-on: https://chromium-review.googlesource.com/c/1330888
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608537}

Instead of exposing internal methods to layout test through
TestRunner, we can just emulate user navigating away from the page.

Bug: 855189
Change-Id: I4cd08357e7929108ad7c9fe79f7f5eeec13e7888
Reviewed-on: https://chromium-review.googlesource.com/c/1334192Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608536}

Tests possible scenarios of the default status response.

Bug: 881937
Change-Id: Ic19152b53a81571794fd82f0ce2bd6bed978cf0f
Reviewed-on: https://chromium-review.googlesource.com/c/1327525
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608535}

This reverts commit 49c4e756.

Reason for revert: 239 LayoutTests failure on Mac10.10 bot
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36316

Original change's description:
> Warn in the DevTools console for TLS 1.0 and 1.1.
>
> TLS 1.0 and 1.1 are deprecated. See:
> https://security.googleblog.com/2018/10/modernizing-transport-security.html
> https://groups.google.com/a/chromium.org/d/msg/blink-dev/EHSnAn2rucg/oiu0DoQ0CAAJ
>
> As part of that deprecation, show a console warning in DevTools and also
> add a Blink-level UseCounter. (We typically measure things at the
> connection or request level for network features, but since we're
> plumbing this in anyway, go ahead and add one.) I mirrored the plumbing
> and UseCounters for Symantec certificates.
>
> Bug: 896013
> Change-Id: I9b45e6264a2119b7b68a5a9f282dfd63a372210a
> Reviewed-on: https://chromium-review.googlesource.com/c/1324878
> Commit-Queue: David Benjamin <davidben@chromium.org>
> Reviewed-by: Carlos IL <carlosil@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608456}

TBR=kinuko@chromium.org,davidben@chromium.org,pfeldman@chromium.org,carlosil@chromium.org

Change-Id: I708f0234f09dd8747841b970463728b37a4bdbcd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 896013
Reviewed-on: https://chromium-review.googlesource.com/c/1338390Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608534}