- 11 Dec, 2020 40 commits
-
-
Xing Liu authored
Add a E2E test for reading list deletion. TBR=dtrainor@chromium.org Bug: NONE Change-Id: I4d3282b514c06a3cddfc04ff268f5aa0376beb3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586653Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835980}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f79c25ac..4d774788 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I58d89aa52d9019c47f35494871e06735e2abbc51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586268Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835979}
-
Clark DuVall authored
This is only an issue if ChromeApplication is used instead of SplitChromeApplication, since ChromeApplication uses ChromeApplicationImpl in all processes. This was broken by the refactor in http://crrev.com/c/2577546. Bug: 1150600 Change-Id: Ie006e613dc0ad6db57ad120655e89e927c9ddd02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586046Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#835978}
-
Dave Tapuska authored
Now that the WebLocalFrame solely owns (and closes) the WebFrameWidgetImpl we can clear the pointer after closure as opposed to doing it via a callback. BUG=1097816 Change-Id: I605016b100189b9ccf7623989fbecbe860a6896a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585827 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#835977}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cfb713273ffa..ae492241ec80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bartekg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1144858 Tbr: bartekg@google.com Change-Id: Ia6fd8a7bea6544bfd44bb57fec8e88266b8257c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585739Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835976}
-
Sebastien Marchand authored
Bug: 1144025 Change-Id: I880dde77edadb8fc7ccad8a7040f6c97d141db37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586107 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#835975}
-
Xianzhu Wang authored
crrev.com/835038 added check for whether an element animating transform is identity-or-translation. This added slight overhead during compositing update with large amount of animating elements. This CL reduces the overhead by calling CanPropagateSubpixelAccumulation() only if the subpixel accumulation is not zero. Bug: 1157047 Change-Id: Ic1c0c9732c0d82360c3778a5b5b129c2e3f01ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585504 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#835974}
-
Satoshi Niwa authored
Depends on crrev.com/c/2557965 (cryptohome service-side CL) BUG=b:171847983 TEST=Check if valid value is returned from cryptohome Change-Id: I3d0b1ede10f576e60ba9582df8c7ab48e573bba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545853 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#835973}
-
Trent Apted authored
Most ChromeOS System Web Apps are defined in a component layer at src/chromeos/components. Some delegate functionality out to the chrome layer via a delegate class implemented in a chrome layer, that is owned by the WebUiController. These tend to use the same pattern of construction, so make a new template function for them, rather than adding explicit specializations. Change-Id: I9b703dbaa8091b9b2d1c51f12e29bf3a7a88e1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581715Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#835972}
-
Daniele Castagna authored
BlitFramebufferCHROMIUM on gles2 is not guaranteed to support scaling and filtering. We currently use it with gles2 on ChromeOS where it does not seem to cause any problem for that specific use case. The only pixel test we have assumed scaling and filtering, and it breaks in some cases when gles2 is used. Given that the GLRenderer, that uses the blit, is going to be replaced soon by SkiaRenderer, this CL disable the test when we're not using gles 3. Bug: angleproject:5174, 1141108 Change-Id: I7d319eb7abb5cda002c272367ec1d721f81dc822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577485 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#835971}
-
Ryan Keane authored
This CL Updates CmaBackendProxy to make the following changes: - Calls to CmaBackendProxy now call into the CmaProxyHandler. - Calls to MultizoneAudioDecoderProxyImpl now also are duplicated to the underlying CmaBackend::AudioDecoder (when appropriate). Bug: b/167426091 Change-Id: Ib07dd53d0efc5a4a080a6b4762502a9447ec0002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561783 Commit-Queue: Ryan Keane <rwkeane@google.com> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835970}
-
kenkangxgwe authored
Wrap the Audio Bus if num_frames is less than buffer frames. Bug: b/175134526 Test: run cplay with config that filter group doesn't require resampler. Change-Id: I477221ad202aa4af11fdb535da0c27203aaf560d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585959Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Mingyu Kang <kenkangxgwe@google.com> Cr-Commit-Position: refs/heads/master@{#835969}
-
Xing Liu authored
Handles bottom sheet close correctly. TBR=dtrainor@chromium.org Bug: 1151001 Change-Id: Ibfd3c2b2a6de0552727a5cf80bb3a9170b99439b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585540 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835968}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I751cdf7fdf71f5456c2427cb12350d083938f359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586255Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835967}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f6df8692023c..9912971cf9b3 2020-12-10 cnorthrop@google.com Docs: Add limitation for Android usage on all apps 2020-12-10 courtneygo@google.com Vulkan: Eliminate fence wait from SyncVk If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Test: Test: Inspect the resulting markdown docTest: Test: angle_end2end_tests --gtest_filter=EGLSyncTest.*/ES2_Vulkan Change-Id: Ib44a478eca0be5accd1de46b379ccfa7c4a5442d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586065Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607622801-911c34fc75b181768a2abc88929167cca3e2a50d.profdata to chrome-mac-master-1607644656-0a2d12ddbaae1d8a16ffb54f7cbbe55ff04a272a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icdbda6e8587ef5a474bd888e7ea538b53dce95b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586262Reviewed-by:
-
Eric Willigers authored
To avoid the accumulation of shared files on Chromebooks that are restarted infrequently, we delete shared files 10 minutes after the share dialog completes. Design doc: https://docs.google.com/document/d/1EjpgseTbBhT9ogQv6HV6sLlBl4hpb2viOcmPtFJorMQ/ Bug: 1153215 Change-Id: Iff221b79b7e6d9e92e47081bdea4ebbf30f37776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581704 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#835964}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607622801-752d4072c7d48988cef666b2cc2834c70f6a2f6e.profdata to chrome-linux-master-1607644656-0b01fdecc754de80a3c2ac369c5f084aa20b4340.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ide5742a6f21b2eaa64031e5b41403fa92d894ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586261Reviewed-by:
-
Jeffrey Kardatzke authored
This resolves issues with the driver misinterpreting what frames are encrypted during the clear lead. The main effect is now we will only be using protected surfaces with an active protected session. NOTE: This breaks full sample encryption, we are sorting that out with Intel, but that's a tiny corner case compared to the benefit this has so we will enable this now. BUG=b:153111783, TEST=Protected playback works for VP9/H264 subsample Change-Id: Id189f856a911140c5a4a9b9c57d539eeeb24c901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583111 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#835962}
-
Alison Maher authored
In CL:2568852, the containing block chain for spanners was updated in NG to skip directly to the multi-column container. However, during paint, this resulted in calculating the incorrect containing layer, which in certain cases caused us to not paint the abspos element. This change fixes this by using the more expensive path for calculating the containing layer when an OOF positioned element is nested inside of a multi-column. Bug: 1079031 Change-Id: I5bce5333efbd59d1e58ee5f2ddf43bb539fa9bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580940 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#835961}
-
Lijin Shen authored
Queue should be resumed right after browsing mode is visible. Bug: 1156113 Change-Id: Idedadb8662249bcd1e655e939b1f23a93323dd4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586273Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#835960}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/3ac0b060c794..299d4780ec86 2020-12-11 rsesek@chromium.org mac: Depend on the //build/config/mac:sdk_inputs target for MIG actions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1157103 Tbr: mseaborn@chromium.org Change-Id: I74439a58ece3803be53ca159bd5bdb5e7bc91f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586274Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607568819-6e8c2579a56bcfb40b7d05eda1af5c54e41c853a.profdata to chrome-win32-master-1607622801-7eee2da7088824da6e68b5fe6587fe40e650ba9e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I39140e008fdf95b9f0ba0a416f7db223a7820423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585734Reviewed-by:
-
Nick Burris authored
* Removes the unused LegacyExternalAuthUtils after the downstream references have changed to the new components ExternalAuthUtils. This is patch 6/6 for refactoring ExternalAuthUtils into //components. Bug: 1144858 Change-Id: I56128f79233d74344dfe6b50c56c84047db96e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570199 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#835957}
-
Sven Zheng authored
CFI and ThinLTO were disabled on the simple chrome workflow because they increase build time quite a bit. But for official build, then should be enabled. Bug: 1157567 Change-Id: I33a9eac37221f31da9a6725b19992d5daded72dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586085Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#835956}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c566c247eb76..8e3a4ab1fe23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1030a8542a485b7dbcfa183f4cc24eaa73c580d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585675Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f83a0f03ccf4..5a9d7eaa74ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I08ba47764db1ba9718204fe4d7f0a7e5415c1929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585542Reviewed-by:
-
Christopher Cameron authored
A version of the canvas wide color gamut specification allowed for an ImageBitmap to specify a pixel format. This was never used. Remove it. ImageBitmap also had a CanvasColorParams structure added to its ParsedOptions structure. This was never initialized to something other than sRGB/uint8. Replace uses of this with kN32_SkColorType and SkColorSpace::MakeSRGB. Bug: 1121448 Change-Id: I5944a35464155c2901551e2a1b6bd65439a5ca2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569213 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#835953}
-
Xing Liu authored
No "Mark as read" menu option for read articles. On M89+, we will add "Mark as unread" option. TBR=dtrainor@chromium.org Bug: 1157643 Change-Id: I3e730854f7550551aee72d07f4ae248152b6ab59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585753Reviewed-by:
-
Jeroen Dhollander authored
UX has decided to pivot in another direction, and Bloom will not be released as a stand-alone feature. Bug: b/175052039 Test: Compiled Change-Id: I479dfea01fa75e10286a4b4a187d2490ae9b5af4 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577885 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#835951}
-
Julie Jeongeun Kim authored
This CL moves PrintHostMsg_RequestPrintPreview_Params to mojo and renames RequestPrintPreviewParams. Bug: 1008939 Change-Id: Ib7cab93b3c5664942d6fdca5335931d9d013dff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583593Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#835950}
-
Yue Zhang authored
LocationBarTest#testSetSearchQueryFocusesUrlBar_preNative is flaky on Lollipop Phone Tester. TBR: fgorski@chromium.org Bug: 1157659 Change-Id: Ibe4787604f23e82d978e6489382f5bd00ee92a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585758Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#835949}
-
David Black authored
When a file rename/move is observed by the `FileChangeService`, we will be notified of the event in the `HoldingSpaceFileSystemDelegate`. This delegate will update the holding space model appropriately and update any file watches as necessary. When a holding space item tracked in the model is moved, the `HoldingSpacePersistenceDelegate` will be notified of the event and update persistence so that the moved file will be successfully restore on next restart. Bug: 1136173 Change-Id: I758b7a828dd880a15a5fb5ab59de8f1bd0889c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583133Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#835948}
-
Clark DuVall authored
This reverts commit f63587ac. Reason for revert: Breaking tests on Lollipop: crbug.com/1157668 Original change's description: > [WebLayer] Fix relro sharing in GPU and load native lib in the background > > WebLayer relro sharing in the browser process has likely always been > broken in WebView compatibility mode because the ClassLoader created > does not have a class loader namespace, see here: https://cs.android.com/android/platform/superproject/+/master:frameworks/base/native/webview/loader/loader.cpp;l=129-132;drc=master > Unfortunately, this is difficult to fix since sharing relro in WebLayer > when it is loaded in the same process as WebView causes crashes. This > will be investigated more in a follow up. > > Relro sharing was never implemented for the WebLayer GPU process, and > this change adds support to do that. > > In addition, library loading is kicked off on a separate thread much > earlier in startup, which allows it to finish before it is needed on the > UI thread. > > Pinpoint runs: > startup.mobile: https://pinpoint-dot-chromeperf.appspot.com/job/169ab7ef520000 > -18.4% messageloop_start_time > -3.4% navigation_commit_time > -1.8% first_contentful_paint_time > > weblayer_startup: https://pinpoint-dot-chromeperf.appspot.com/job/17959d48d20000 > -6.4% weblayer_startup_wall_time > > system_health.memory_mobile: https://pinpoint-dot-chromeperf.appspot.com/job/16d61b37520000 > -10.0% (3.9MiB) all_processes private_dirty_size > -29.8% (3.7Mib) gpu_process private_dirty_size > > Bug: 1146438 > Change-Id: I52292f0472f18397b0a900307649e6f1b54bd5c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581007 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835580} TBR=torne@chromium.org,cduvall@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I0cb581cebbd8e6f0ba315d78035b292501da2aa2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146438, 1157668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586279Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#835947}
-
Collin Baker authored
Bug: 1090038, 1148631 Change-Id: I5fe93fcb6614c55ffb5a40f9dda3ae327b1dc481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583109 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#835946}
-
Luciano Pacheco authored
These affected tests don't need the Files app fully loaded, however a DCHECK in the networking layer crashes even though the test has passed. Avoid the crash by waiting for Files app to fully load. Bug: 1156958 Change-Id: Ia136989c492d0d16beec63b44ab73745f0980616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586285 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#835945}
-
Ben Reich authored
When browser tests are run on the bots they are sharded and any output is expected to be directed into ephemeral directories ensuring isolation between the shards. To accomplish this we take a path via the existing switch --devtools-code-coverage so the bots can pass their ephemeral output directories to write the coverage into. Additionally the ephemeral output directories write their output into a further isolated directory and the coverage files must be identified by a recursive directory walk. Update the coverage files to have an extension .cov.json so that we can find them easily. --devtools-code-coverage=/some/directory --devtools-code-coverage Bug: 1113941 Test: browser_test --gtest_filter=*FilesApp*:*DevToolsListener* Change-Id: I2b6aea654de0aef753a51fd91b26f38260a35369 Test: browser_test --gtest_filter=*FilesApp*:*DevToolsListener* Test: browser_test --gtest_filter=*FilesApp*:*DevToolsListener* Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584416Reviewed-by:Ben Wells <benwells@chromium.org> Commit-Queue: Ben Reich <benreich@chromium.org> Cr-Commit-Position: refs/heads/master@{#835944}
-
Austin Sullivan authored
The only consumer, GetDatabaseNames for devtools, has been removed. Bug: 992958 Change-Id: Iaf01673e800b3d317674cb639be547d6c08ad147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562797Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#835943}
-
Akira Baruah authored
Implements automatic FIDL reconnection with exponential backoff. If the client loses connection to the MetricsRecorder FIDL service, it will attempt to reconnect after 1 second. Consecutive disconnect/reconnect cycles without a successful Record() FIDL call will wait for twice as long, up to a maximum of 1 hour. Also continues to record user action events even during service disconnect, up to a maximum of 5000 events before dropping new events. Bug: b/170876057 Test: cr_fuchsia_base_unittests Change-Id: Ica2ed85f619834d6a50b546420e7acea86a9549c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547793 Commit-Queue: Akira Baruah <akirabaruah@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#835942}
-
Daniel Cheng authored
Non-bool arguments need to be explicitly converted. Bug: 1146573 Change-Id: I8cbe519470d7a4c5880c174c33e43abe913ee486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585985 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#835941}
-
