- 07 Feb, 2019 40 commits
-
-
Julie Jeongeun Kim authored
This CL makes ProfileDownloader use AccessTokenFetcher in kWaitUntilAvailable mode, which simplifies it as it doesn't need to observe OnRefreshTokenUpdatedForAccount(). This is a follow-up CL of https://crrev.com/c/1436780. Bug: 922757, 922758 Change-Id: If2b664a6e4e303db16cf028b947592e2f463c291 Reviewed-on: https://chromium-review.googlesource.com/c/1457575Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#629912}
-
Luciano Pacheco authored
Used lebab to convert to ES6 class with the following command: lebab --replace \ ui/file_manager/file_manager/foreground/js/file_selection.js \ --transform class Manual fixes: - Fix closure markup to go to constructor() instead of class definition. - Fix Mock class to be ES6 class too, since closure doesn't allow old style classes to extends from ES6 classes. - Rename MockFileSelectionHandler to FakeSelectionHandler. This fake lies to closure by saying that it extends FileSelectionHandler to allow it to be passed as FileSelectionHandler in closure compilation. - Add addEventListener() method to FakeFileSelectionHandler to fix tests that use this method. Bug: 778674 Change-Id: I39fb5ef7d7d8ef9c7fbc2b64244a26b9ebe23584 Reviewed-on: https://chromium-review.googlesource.com/c/1457700Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#629911}
-
Yoshifumi Inoue authored
This patches imports test cases for |SearchBufferTest| to |FindBufferTest| as preparation for getting rid of |SearchBuffer|. This patch also introduces |BufferMatchResult::operator==()| for testing. Change-Id: I5c8be1ca1e77e76b454341dad098f007a68ab376 Reviewed-on: https://chromium-review.googlesource.com/c/1457804Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#629910}
-
Yoshifumi Inoue authored
This patch introduces a performance test file "select-all-words.html" for measuring painting selection. See https://bit.ly/2SyNQS1 for profiling sample comparing legacy layout and LayoutNG. As of February 7, 2019, LayoutNG is two times slower than legacy layout. Change-Id: I8c5fe8418715b7d0078f6f1186c4191a1fb7d850 Reviewed-on: https://chromium-review.googlesource.com/c/1457701 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#629909}
-
David Roger authored
Following files are no longer built on ChromeOS: c/b/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc c/b/ui/bookmarks/bookmark_bubble_sign_in_delegate.h c/b/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc c/b/ui/views/sync/bubble_sync_promo_view_unittest.cc c/b/ui/views/sync/bubble_sync_promo_view.cc c/b/ui/views/sync/bubble_sync_promo_view.h Dead ChromeOS code is removed from c/b/signin/ Some duplicated code is refactored into: chrome/browser/ui/views/sync/bubble_sync_promo_view_util.h Change-Id: I30eee77bdf856282e50a5315944c606559e41047 Reviewed-on: https://chromium-review.googlesource.com/c/1445940Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#629908}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: Ie99662ee0fe609cf19218c818703b57e309013d4 Reviewed-on: https://chromium-review.googlesource.com/c/1457881 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Let the style recalc pass mark for re-attachment and re-attach in the RebuildLayoutTree pass instead. Only call DetachLayoutTree for nodes which were slotted but are not part of the flat tree anymore. This is similar to removing nodes from the DOM tree where we also call DetachLayoutTree synchronously. This is to fix performance regressions in 926268. Ran a pinpoint job[1] to confirm that at least some of the tests improved/recovered. This means we will also avoid subtree recalc on re-slotting since we are marking the slotted nodes with kLocalStyleChange (to recalc if the inheritance parent changed), not kSubtreeStyleChange like we used to with LazyReattachIfAttached(). The new code for HTMLSummaryElement is to trigger a recalc/reattach for the details marker when the main summary element changes. That was not necessary before because of the kSubtreeStyleChange which forced the recalc down the UA shadow for <details>. [1] https://pinpoint-dot-chromeperf.appspot.com/job/13e09791d40000 Bug: 926268, 734908 Change-Id: I49c483a6cc5ee945270753b0e4b261202facd10c Reviewed-on: https://chromium-review.googlesource.com/c/1452167Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#629906}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e09b459b..69a830d3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0111f3a4dd990bf0a52827b2918bb259cf0d0da5 Reviewed-on: https://chromium-review.googlesource.com/c/1457917Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629905}
-
Konstantin Ganenko authored
Service worker's version has nullptr GetMainScriptHttpResponseInfo when script loaded via ServiceWorkerInstalledScriptLoader. It is case when non-installed service worker requests script that is already installed. R=falken@chromium.org Bug: 929017 Change-Id: Ic4663fec8f2ad51982ac50a2fa2bd69fab67928b Reviewed-on: https://chromium-review.googlesource.com/c/1455138 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#629904}
-
Matt Falkenhagen authored
Bug: 929042 Change-Id: I82dd5a4251457a6693a8780846e93d7b83bddf5b Reviewed-on: https://chromium-review.googlesource.com/c/1457574Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#629903}
-
Eric Seckler authored
Addresses a bug where we end up tracing to the buffer of a previous tracing session. Bug: 929080 Change-Id: I4b4f21a994eddf66b6714b43185c3f78a2ea1532 Reviewed-on: https://chromium-review.googlesource.com/c/1456006 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#629902}
-
Yoshifumi Inoue authored
This patch changes |EnclosingElementWithTag()| to use |InclusiveAncestorsOf()| to simplify source code for improving readability. Change-Id: Ica7d58f0dd4d44573ecf937d21b9855d2b8210d1 Reviewed-on: https://chromium-review.googlesource.com/c/1454210Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#629901}
-
Gyuyoung Kim authored
PauseScheduledTasks() was added to allow embedders to suspend/resume the blink schedule tasks. But, SetPageFrozen() that was similar to PageScheduleTasks was added to the content API as well. It means that content APIs have supported two similar APIs. So, this CL removes PauseScheduledTasks except for the test case. Because the test case is still useful for the SetPageFrozen(). Instead, the test name is renamed to SetPageFrozen in WebContentImplBrowserTest. TEST: WebContentsImplBrowserTest.SetPageFrozen Bug: 822564 Change-Id: I4d08a85081fc5575ae2ea8f697deb9a3d9b3cc23 Reviewed-on: https://chromium-review.googlesource.com/c/1456236Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#629900}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I5a1335f374420fa37f778925a54c31df77e0f5a3 Reviewed-on: https://chromium-review.googlesource.com/c/1457880Reviewed-by:
-
Dominic Mazzoni authored
When a node is updated, on the browser side we need to go through a three-phase process to update the hypertext and other computed Windows attributes. In some cases we also need to update the parent node's attributes too - specifically when the original node is text that contributes to its parent's hypertext, or in an editable text region where things like spelling markers need to propagate. The previous algorithm was essentially that while updating a node, it'd force its parent to update too. This led to an inefficiency if you have a very flat document with thousands of nodes that are all children of a single parent. Every node that's updated triggers updating its parent, causing the parent to be updated thousands of times redundantly. The fix is to first precompute a set of all nodes that need to be updated, including following parents, and then update them all with no more recursion. This dramatically improves the load time of documents with thousands of lines of just flat text and line breaks. Bug: 921789 Change-Id: I5246ea321fda8a6ddce45221377010a4b5543801 Reviewed-on: https://chromium-review.googlesource.com/c/1455858 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#629898}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f4d325bdd8b0..8200b1f0ea55 Created with: gclient setdep -r src-internal@8200b1f0ea55 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I28b914ef245156dc31fc2de7cc392fafe4555d46 Reviewed-on: https://chromium-review.googlesource.com/c/1457525Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629897}
-
Findit authored
This reverts commit 3968c544. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 629872 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMzk2OGM1NDQ5ZWM1ZjQzMWZiMmQ0YTQwOTZiZjM4Y2QzYzk4NGUzZgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/31402 Sample Failed Step: webui_polymer2_browser_tests Sample Flaky Test: QuickView/FilesAppBrowserTest.Test/openQuickViewRemovablePartitions Original change's description: > Add quick view test for removable partitions. > > Bug: 918795 > Change-Id: I3ce85373b987f572e901889082d638035acf1235 > Reviewed-on: https://chromium-review.googlesource.com/c/1457557 > Commit-Queue: Alli Murray <alliemurray@google.com> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629872} Change-Id: I8f69d1ee7321782bc3f1379e6d81dc24435c897f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 918795 Reviewed-on: https://chromium-review.googlesource.com/c/1457922 Cr-Commit-Position: refs/heads/master@{#629896}
-
Hitoshi Yoshida authored
We filtered out "Exposed" members in checking origin trial members. It means we couldn't have members like [Exposed=Window, OriginTrialEnabled=FeatureName] attribute long a; in WebIDL. This CL drops the filtering and make generated code check the context to work well with them. Bug: 928917 Change-Id: I2e1c5225000a78eae2066e4a6db49bdde1e71896 Reviewed-on: https://chromium-review.googlesource.com/c/1457566 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
In some cases TextSearcherICU might find result with zero length. Example case from ClusterFuzz: <script> function go(){ setup() } window.onload=go; function setup(){ window.find('\u0080') } </script> <hr id='id9' contenteditable='true'</noscript> > Bug: 929217 Change-Id: Ic13b3a3595ae2feb83a7d54a2e8e532f7717e33b Reviewed-on: https://chromium-review.googlesource.com/c/1457798 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#629894}
-
Alli Murray authored
Bug: 918795 Change-Id: I3b4d530ad50264a1a9a40b2331b98886e3a81f18 Reviewed-on: https://chromium-review.googlesource.com/c/1457800 Commit-Queue: Alli Murray <alliemurray@google.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#629893}
-
rbpotter authored
Add type for all CustomEvent parameters and remove unnecessary type casts. Bug: 924733 Change-Id: I3b521ab2ca575aa3caf59921d06a2af75361c2fd Reviewed-on: https://chromium-review.googlesource.com/c/1456695 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#629892}
-
Matt Falkenhagen authored
It was calling EmbeddedWorkerInstance::Stop() but it's not needed since it owns EWI and when EWI gets destructed the Mojo connection breaks. EmbeddedWorkerInstanceClient handles the Mojo connection failure the same as receiving a Stop message in EmbeddedWorkerInstanceClient::OnError. Change-Id: I86f850245feee0dec492e88d3e6f5110e3479e6c Reviewed-on: https://chromium-review.googlesource.com/c/1457796Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#629891}
-
Michael Moss authored
All entries must be pinned (don't we have a presubmit check for that?), otherwise it breaks reproducibility and the branch/release workflow. R=nyerramilli@chromium.org, rohitrao@chromium.org Bug: 929544 Change-Id: I78c993f30a6fe3ea9fb1c6227f663ae83fdddb50 Reviewed-on: https://chromium-review.googlesource.com/c/1457435Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#629890}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/96e1911b0bad..01a3e9b6383f git log 96e1911b0bad..01a3e9b6383f --date=short --no-merges --format='%ad %ae %s' 2019-02-07 bryan.bernhart@intel.com Disable copy test failing on Intel Linux. Created with: gclient setdep -r src/third_party/dawn@01a3e9b6383f The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I4e8a8102079bc55e147e5c549a1e3f6783358e53 Reviewed-on: https://chromium-review.googlesource.com/c/1457821Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629889}
-
calamity authored
This reverts commit 350b8006. Reason for revert: Causing failures e.g https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/77921 Original change's description: > [Extensions] Separate activity log into multiple files > > activity_log.js will be split into activity_log_history.js and > activity_log.js to separate the file in preparation for the real-time > stream implementation. > > activity_log.js takes care of the UI lifecycle and common UI elements > logic (i.e. back/clear button, search bar, and loading the activity log > when the page is reached) > > activity_log_history.js takes care of fetching, handling and displaying > activity log data from the activityLogPrivate API. > > In a later CL, the activity log stream (implemented by listening to > activityLogPrivate.onExtensionActivity events) will be in a different > tab under activity_log.js and will have its own file. This CL aims to > prevent putting all activity logic into one large (and very bloated) > file. > > Bug: 832354 > Change-Id: I88be6309ba4c4d73e0078ce86e893dafb26594c2 > Reviewed-on: https://chromium-review.googlesource.com/c/1432939 > Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629848} TBR=dpapad@chromium.org,kelvinjiang@chromium.org Change-Id: I190cf8d01b9ef1fce355c98bce9e14623258e324 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832354 Reviewed-on: https://chromium-review.googlesource.com/c/1457879Reviewed-by:
-
Sreerenj Balachandran authored
The vp8_reference_frame_vector implementation has dependency to scoped_refptr.It is cleaner to include the scoped_refptr.h directly instead of using the ref_counted.h header file. Cleaning based on the review comments for: https://chromium-review.googlesource.com/c/chromium/src/+/1383540 Change-Id: I2e97cf4eb8a68690f32148bd6897dd83c56dd213 Reviewed-on: https://chromium-review.googlesource.com/c/1457727Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#629887}
-
Sreerenj Balachandran authored
Replace some of the const defintions with constexpr as a part of optimization based on review comments for https://chromium-review.googlesource.com/c/chromium/src/+/1383540 Change-Id: I82e8955950f526a2beb52f281efb6b9a463f1761 Reviewed-on: https://chromium-review.googlesource.com/c/1457423Reviewed-by:
-
Rakina Zata Amni authored
When traversing on a frame tree that has no matches and only one frame, we might get into an infinite loop because we keep traversing to the same node (due to wrapping). This CL checks if the last-traversed node is the same as the current node and stops if so, and also to stop when we're trying to traverse from an inactive frame. Bug: 889075 Change-Id: I099dcdc6353c21fa1694b4b81953cba68465ffc1 Reviewed-on: https://chromium-review.googlesource.com/c/1454161 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#629885}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/003f99ea..e09b459b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6b9e471451970554e1f696ee66627ba85a1f91b Reviewed-on: https://chromium-review.googlesource.com/c/1457731Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b32378da8f4..f4d325bdd8b0 Created with: gclient setdep -r src-internal@f4d325bdd8b0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib75f03308f0beb4b48df01e1a8ecb5a0be947dea Reviewed-on: https://chromium-review.googlesource.com/c/1457524Reviewed-by:
-
Matt Menke authored
This CL allows a SpdySession to be created by passing a StreamSocket to its constructor directly, in addition to keeping the previous constructor, which takes a ClientSocketHandle. The new constructor is intended for use where there's no socket pool below the session. In particular, for H2 proxies, the SpdySessions are created below the highest socket pool layer, at the ConnectJob layer. Once the socket pools are flight, this will become the only socket pool layer, so we'll only be dealing with a raw StreamSockets, rather than ClientSocketHandles. This is part of an effort to flatten the socket pools. https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit Change-Id: Ibe722bad9814879504757c03e8ad3c135d123971 Reviewed-on: https://chromium-review.googlesource.com/c/1453107 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#629882}
-
Vlad Tsyrklevich authored
Add the GWP-ASan UserStreamDataSource to the macOS crashpad handler. The GWP-ASan hook determines when an exception is related to GWP-ASan and reports additional debug information. Bug: 912286 Change-Id: I1cd0227ca8aade1bd17e25b83832cdb8f3e58d5e Reviewed-on: https://chromium-review.googlesource.com/c/1457461Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#629881}
-
Mitsuru Oshima authored
Delay re-adding shadow and mask as it can interfere with still animation. Bug: 923391 Test: ScrenRotationAnimatorTest updated, OverviewSessionTest.RoundedEdgeMaskVisibility Change-Id: Ie6455a40e2c796914f4fe04f4fa04cc13fc6fefc Reviewed-on: https://chromium-review.googlesource.com/c/1453541 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#629880}
-
Antoine Labour authored
Under lost device conditions, eglMakeCurrent can fail, even when releasing the context. As we otherwise assume that we have correct bindings when GLContext::IsCurrent returns true, we need to track the lost state to ensure that after ReleaseCurrent, IsCurrent will return false. Bug: 928693 Change-Id: I5bbf2616f872532c03da1e1beeade5c94d920b92 Reviewed-on: https://chromium-review.googlesource.com/c/1457675Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#629879}
-
Tommy C. Li authored
Currently, the IFRAME throttle doesn't always work on first-time use, when the Chrome process is first started. This is because the IFRAME throttle itself doesn't trigger the plugin list load. This CL updates the throttle to also trigger the plugin list load itself (only if it hasn't been loaded already), and should make the behavior less flaky. Bug: 924823 Change-Id: If51e85bf2d7005af1a5a825279388dd6d9324409 Reviewed-on: https://chromium-review.googlesource.com/c/1452771 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#629878}
-
Stefan Zager authored
These CHECKS were added by someone who left the project a year ago. Recent crash reports still show about 1-2 crashes per day, but the actual line that is crashing doesn't look like a valid CHECK condition, so I don't think there's anything left to do here. The parent_ variable was apparently added only for debugging. It is used in only one place apart from attach/detach; in that place I replaced it with a call to ParentFrameView (which goes through the frame tree, as it should). I also added a CHECK out of an abundance of caution. BUG=729196 R=dtapuska@chromium.org Change-Id: I3990c90f64901b6c797dad17376fa30821b02e2a Reviewed-on: https://chromium-review.googlesource.com/c/1457665Reviewed-by:
-
Nigel Tao authored
BUG=826982 Change-Id: If73d4090989a436c4f8ebd1857d1d8727a2dca50 Reviewed-on: https://chromium-review.googlesource.com/c/1457558Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#629876}
-
Alexei Filippov authored
BUG=681863 Change-Id: I5ad61c04e1af61e184e5a182234007812d75fd00 Reviewed-on: https://chromium-review.googlesource.com/c/1453542 Auto-Submit: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#629875}
-
Malay Keshav authored
This patch aims at fixing one of the causes for the transparent chrome window bug. One of the reasons that caused this bug was that some of the property changes on the original ui layer were not being propagated to the mirror layer. The visibility of the original layer needs to be propagated to the mirror layers. This patch adds this functionality. Bug: 927909 Change-Id: I3767bc513f199cb7c3dd7b3c0783894b99cd4293 Component: ui layer,stale content, solid color layer Reviewed-on: https://chromium-review.googlesource.com/c/1450611 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#629874}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I7be4d81c421379440ce5f601d6fa188ea5b5c98b Reviewed-on: https://chromium-review.googlesource.com/c/1457740Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#629873}
-
