GitLab

Add crypto::EnsureNSSInit to ClientCertStoreNSSTestDelegate, due to the
use_byte_certs changes NSS will not have been initialized already.

Bug: 716594,733922
Change-Id: I07f79cba8b482866ee9e2ea3e74355361393e5f8
Reviewed-on: https://chromium-review.googlesource.com/c/1474132Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632419}

This will allow us to connect a place which send the mojo message and
the place which received it.

R=rockot@google.com
CC=dmurph@chromium.org
BUG=932167

Change-Id: Iea1bb6f1645279d21ad329f983f4112469c138e0
Reviewed-on: https://chromium-review.googlesource.com/c/1473233Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632418}

It should be okay to support the flag without enabling the intervention feature
(i.e. when a website adapts by adding the "allow-downloads-" token, we should no
longer give deprecation warnings & should not give console errors "...invalid
sandbox flag". Both would happen if we don't support the token.).

Supporting the token will also change the result of
IsSandboxed(kSandboxDownloads): previously it was always True; now it will be
False if the "allow-downloads-" token is set. It will make the UseCounter
DownloadInSandbox keep decreasing as more and more websites are adapting to the
change. This also looks positive as it gives an idea of ongoing compatibility
risk rather than the maximum risk.

Bug: 539938
Change-Id: I002f1a556205344953dabf094849af7e1222dd9f
Reviewed-on: https://chromium-review.googlesource.com/c/1471002Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632417}

This reverts commit ad28299e.

Reason: This causes a crash deep in the Wayland code on startup, trying
to deserialize the message. Reproduced on a Reef (Nougat) device.

Bug: 932185, b:122704772

TBR=oshima@chromium.org, tetsui@chromium.org, yhanada@chromium.org

Test: Reef Chromebook boots ARC after revert
Change-Id: I68b7dce136496afedc285b7fcd5fc48b1dcb43bb
Reviewed-on: https://chromium-review.googlesource.com/c/1474684Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Auto-Submit: Lloyd Pique <lpique@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632416}

https://chromium.googlesource.com/angle/angle.git/+log/77874e2ca341..366df2b26dd1


git log 77874e2ca341..366df2b26dd1 --date=short --no-merges --format='%ad %ae %s'
2019-02-14 geofflang@chromium.org Vulkan: Support external texture binding points.


Created with:
  gclient setdep -r src/third_party/angle@366df2b26dd1

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: Ib5f05a6e28180ec782ed6135892d7d6a493f1040
Reviewed-on: https://chromium-review.googlesource.com/c/1474555Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632415}

Some blink unittests depend on common fonts which may not be available
on all platforms. This problem is solved in blink layout tests by using
custom font configuration with fonts from //third_party/test_fonts .
Previously the corresponding code was part of content_shell. Moved
it to //skia to make it possible to reuse it for blink_platform_unittests
and skia_unittests.

Bug: 928459
Change-Id: Ic7ea1e53c29ca9aea9014ed6c778ad0f8a2de6fb
Reviewed-on: https://chromium-review.googlesource.com/c/1469287Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632414}

This change adds a number of new operations to |FidoAuthenticator| to
support PIN operations.

Change-Id: I84b93879efb79a9bdb49482545d8e0ea68d277bf
Reviewed-on: https://chromium-review.googlesource.com/c/1460411Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632413}

This reverts commit a94eef13.

Reason for revert: Cast tests are failing on ChromiumOS MSAN:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/11290

Original change's description:
> Move tab mirroring performance tests into browser_tests.
> 
> This moves TabCapturePerformanceTest and CastV2PerformanceTest into
> browser_tests. By default, they have been changed to run in a quick-
> check mode. When run for performance testing on the perf bots, the
> additional --full-performance-run command line switch will be required.
> 
> The performance_browser_tests isolate config has been changed to run
> browser_tests with the --full-performance-run switch, gtest filters,
> and timeout overrides. Also, the old performance_browser_tests GN test
> target has been turned into a simple group target that groups the
> necessary data dependencies for running on the perf bots.
> 
> This change also includes some changes to allow the tests to complete
> in the absence of tracing data when in quick-check mode. While most
> bots do collect a reasonable amount of tracing data in a few short
> seconds, one or two don't always do so. Unfortunately, we can't justify
> making the CQ run longer to force data collection in all cases.
> 
> Bug: 804191
> Change-Id: I2de6c0b94453981fb0d9015f6b3f0e42f57cc2a6
> Reviewed-on: https://chromium-review.googlesource.com/c/1428399
> Commit-Queue: Yuri Wiitala <miu@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#632366}

TBR=miu@chromium.org,crouleau@chromium.org,jochen@chromium.org

Change-Id: I4c12b48c4ec82877c06ebb460a08a9944a6f5504
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 804191
Reviewed-on: https://chromium-review.googlesource.com/c/1474282Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632412}

During a window move loop events should not be sent to the client. There are
some cases that might trigger generating an event during the loop, that could
target the window. These should be ignored.

BUG=931878
TEST=none

Change-Id: I64fc6ac7212f3db4f8d64a8a9dc96d6f6355b26c
Reviewed-on: https://chromium-review.googlesource.com/c/1474797Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632411}

Bug: 926235
Change-Id: I3a65db96b88035f4953a169e79a718ac3252e339
Reviewed-on: https://chromium-review.googlesource.com/c/1463160
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632410}

Simply moves the win7 expectation to win since they both use the
same one. Formats the HTML and adds a title too.

--------------[ Original Description Below ]--------------

Apparently we don't have any vpx-alpha layout tests, hence macOS has
had broken support here for some time.

BUG=919015
TEST=fails without the macOS alpha fix.
TBR=dcastagna

Change-Id: I9defe5b3750faeedd63ef0b62aaddb067a7fbc3f
Reviewed-on: https://chromium-review.googlesource.com/c/1471355Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632409}

The test was timing out waiting for a message from the test app.
The problem was that in CrashRestore test, the app launch is expected to
happen early on, during chrome session set up - before the test main
part is run, and when the TestExtensionMessageListener is registered.

This CL moves extension message listener registration earlier in the
browser test setup (note that SetUpOnMainThread might be too late, while
SetUp is too early as message loop is not yet initialized).

BUG=930345
TEST=Ran the test with gtest_repeat=20, with no failures

Change-Id: I12c8d40fc52270492723a14b764a9cc7e3a619a6
Reviewed-on: https://chromium-review.googlesource.com/c/1474794Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632408}

This reverts commit 76044ee0.

Reason for revert: speculative: https://bugs.chromium.org/p/chromium/issues/detail?id=932301

BUG=932301

Original change's description:
> Reland "Cleanup run_performance_tests.py's output files handling"
> 
> Relanding https://chromium-review.googlesource.com/c/1449151 with fixes.
> 
> Patchset 1 is https://chromium-review.googlesource.com/c/1449151
> 
> Patchset 2 is https://chromium-review.googlesource.com/c/1464228
> 
> Patchset 3 is the new fix. When you run a telemetry benchmark as a
> reference, you are supposed to do
> `run_benchmark benchmark_name --browser=reference`
> but I thought that you were supposed to do
> `run_benchmark benchmark_name.reference --browser=reference`
> because I read the earlier code wrong.
> I also added a end to end test for this behavior, which also
> covers sharding code as well.
> 
> Patchset 5 is a unittest for
> https://chromium-review.googlesource.com/c/1464228
> 
> Bug: 930879, 928928, 927507, 923628, 920002, 744736
> Change-Id: If73d929b8e1b32c33d2bed7d2298b64d205658c1
> Reviewed-on: https://chromium-review.googlesource.com/c/1467907
> Reviewed-by: Emily Hanley <eyaich@chromium.org>
> Reviewed-by: John Chen <johnchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#632333}

TBR=crouleau@chromium.org,eyaich@chromium.org,johnchen@chromium.org

Change-Id: I84729563d3fa708edb9329f41c3bf2f0666f1818
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 930879, 928928, 927507, 923628, 920002, 744736
Reviewed-on: https://chromium-review.googlesource.com/c/1474971Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632407}

Now that https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/813849
landed, the methods left unused in Tab can be cleaned up.

Bug: 925242
Change-Id: I64e0d8a6868644ce1843fbc965b6a3fa920d8e11
Reviewed-on: https://chromium-review.googlesource.com/c/1470285Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632406}

Enable the feature to replace the WebUI Cast dialog with a Views dialog
by default.

Bug: 754101
Change-Id: I80fff11bf849c44a49de2f93a95ede08986f6a78
Reviewed-on: https://chromium-review.googlesource.com/c/1464925
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632405}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3ab00a7d068b..2b14855de938


git log 3ab00a7d068b..2b14855de938 --date=short --no-merges --format='%ad %ae %s'
2019-02-14 vadimsh@chromium.org [cipd] Update CIPD 2.2.15 -> 2.2.16.
2019-02-14 tikuta@chromium.org Support --enable-auto-submit in `git cl split`


Created with:
  gclient setdep -r src/third_party/depot_tools@2b14855de938

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:931755,chromium:927178
TBR=agable@chromium.org

Change-Id: I894fc0fd7072fa193745cce27e17ad0754e9c271
Reviewed-on: https://chromium-review.googlesource.com/c/1474294Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632404}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Patch is migrating SafeBrowsingResult to @IntDef with form common with other Chrome @IntDef:

1. with @IntDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with @Retention(RetentionPolicy.SOURCE)
4. without "static final" in the @interface

BUG=919666

Change-Id: I385d880a50373481ea84a5ec82ee73347f01ff49
Reviewed-on: https://chromium-review.googlesource.com/c/1450267Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#632403}

This CL was uploaded by git cl split.

R=posciak@chromium.org

Bug: 926235
Change-Id: I1dd8c021766144563372dc1b8cf495ba15862433
Reviewed-on: https://chromium-review.googlesource.com/c/1464343
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632402}

Bug: 931382
Change-Id: I0422682825f6cd930a95931c55972e78336100a4
Reviewed-on: https://chromium-review.googlesource.com/c/1457666Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Hao Zhang <hozhng@google.com>
Cr-Commit-Position: refs/heads/master@{#632401}

https://chromium.googlesource.com/catapult.git/+log/754352edf2d9..c79285cb0afd


git log 754352edf2d9..c79285cb0afd --date=short --no-merges --format='%ad %ae %s'
2019-02-14 tbarzic@chromium.org Disable RepeatableScrollActionNoRepeats on chromeos


Created with:
  gclient setdep -r src/third_party/catapult@c79285cb0afd

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:932104
TBR=sullivan@chromium.org

Change-Id: Ia9a0484c44c537b88504a5745efc7c5f18b53fc6
Reviewed-on: https://chromium-review.googlesource.com/c/1474550Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632400}

The BoxLayout doesn't seem to deal with label eliding properly (the
origin of the text moves around). This moves to the new FlexLayout,
which handles the resizing correctly.

Bug: 929944
Change-Id: Ie66f399cc85e500b5318d987d4759954e972c1b8
Reviewed-on: https://chromium-review.googlesource.com/c/1460197
Auto-Submit: Jay Harris <harrisjay@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632399}

The interface was only used for tests. Move the tests into blink
and remove the interface.

BUG=591921

Change-Id: I738449a5acd01adf1cf24ed48d84a2dbc447c5fa
Reviewed-on: https://chromium-review.googlesource.com/c/1472853
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632398}

NaCl development has been transitioning to WebAssembly for some time, and
NaCl is deprecated for some use cases.
This change removes these nacl-related flags:

  enable-nacl
  enable-nacl-debug
  force-pnacl-subzero
  nacl-debug-mask
  allow-nacl-socket-api

The corresponding nacl switches are still present; if you are developing using
one of these flags, migrate to using the command-line switch instead. The
force-pnacl-subzero and allow-nacl-socket-api switches are themselves slated to
be removed soon.

Bug: 918376
Change-Id: Ied029b6f8bd001fdacb5f0734bd1c5f4cf3d322a
Reviewed-on: https://chromium-review.googlesource.com/c/1473834
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632397}

- Make InputMethodMus not forwarding synthetic key events
  as InputMethodChromeOS does not expect to receive them;
- ChromeVirtualKeyboardDelegate to insert char to the
  correct ui::TextInputClient instance;

Bug: 931931
Change-Id: If783fcf53c833c360d6a733d22b5b30308528363
Reviewed-on: https://chromium-review.googlesource.com/c/1474635Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632396}

Currently the overflow menu will not work on second click if we never
go to the dialog. This is due to a early return cross check in the code.
If the overflow menu is exits by clicking somewhere else, it will close
without clear the actionMenuModel_. This is the same in the
history_list.

BUG=931969

Change-Id: Ia67886212ac6b09cdf0e7a0813ee98db8df34926
Reviewed-on: https://chromium-review.googlesource.com/c/1471972Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632395}

If WindowTreeHostMus::SetBounds() is called with no LocalSurfaceIdAllocation
(as happens when views calls SetBounds()) and the size hasn't changed, then
the current LocalSurfaceId should be used.

BUG=931878
TEST=covered by test

Change-Id: I135dca75ce04220796c41dd9d49042127d5dcfc5
Reviewed-on: https://chromium-review.googlesource.com/c/1474252
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632394}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/0444f9acb88d..43a449fd3566


git log 0444f9acb88d..43a449fd3566 --date=short --no-merges --format='%ad %ae %s'
2019-02-14 dgarrett@google.com chromeos_config: Add octopus factory branch.
2019-02-14 ihf@chromium.org Revert "default PreCQ: Remove betty-arcnext-pre-cq"
2019-02-14 kerrnel@chromium.org cros deploy: Fail if the package is not actually emerged.
2019-02-14 pprabhu@chromium.org config: Migrate auron_paine-paladin and bob-paladin to Skylab


Created with:
  gclient setdep -r src/third_party/chromite@43a449fd3566

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I3edd03431f59a32fea400a0139d4b47ab7a4d942
Reviewed-on: https://chromium-review.googlesource.com/c/1474552Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632393}

This CL updates the default behavior of FullscreenUIUpdater to use
|-updateForFullscreenProgress:| as a fallback for when the optional
FullscreenUIElement selectors are not implemented.


Bug: 932215
Change-Id: I4e2e5f0efd2b81e3c946161e45cb75f444510537
Reviewed-on: https://chromium-review.googlesource.com/c/1474092
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632392}

Tests buggy code paths in NG and Legacy.

Bug: 907911
Change-Id: I38f22f3673576a776fbe7e89f1cc8452b99d3ded
Reviewed-on: https://chromium-review.googlesource.com/c/1471384Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632391}

1. remove units in the RecordHistogram methods and TimesHistogramSample (they're always using milliseconds)

2. replace some methods with DateUtils constants / shared constants in TimeUtils

TBR=fgorski@chromium.org,caitkp@chromium.org

Change-Id: Ifd4e8f4e5af7051647c45cf310c1bc253b59eab2
Reviewed-on: https://chromium-review.googlesource.com/c/1444831
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632390}

Bug: 922649
Change-Id: I7148f5145e99d88bfed9066677841f96faccf04d
Reviewed-on: https://chromium-review.googlesource.com/c/1415298Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632389}

More logging in hope of shedding some light on issue 929413
(content_shell outliving run_web_tests).

Bug: 929413
Change-Id: I47117a85a083158d13527a535dab312774220001
Reviewed-on: https://chromium-review.googlesource.com/c/1474630Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632388}

This broke chrome cast mirroring from a minimized browser window.

This changed in https://chromium-review.googlesource.com/c/1326621

Bug: 930429
Change-Id: I0e212da02b66eed3f4b6d64c0d37fb61f1a6e840
Reviewed-on: https://chromium-review.googlesource.com/c/1468762Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632387}

Change-Id: I9c0585f678eb98d6d5b758036e11859675f659e4
Reviewed-on: https://chromium-review.googlesource.com/c/1474094
Commit-Queue: enne <enne@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632386}

This fixes the GCC build which was failing like this:

    ../../base/scoped_observer.h: In instantiation of ‘void ScopedObserver<Source, Observer>::RemoveAll() [with Source = TabStripModel; Observer = TabStripModelObserver]’:
    ../../base/scoped_observer.h:26:5:   required from ‘ScopedObserver<Source, Observer>::~ScopedObserver() [with Source = TabStripModel; Observer = TabStripModelObserver]’
    ../../chrome/browser/ui/views/extensions/extension_popup.h:115:70:   required from here
    ../../base/scoped_observer.h:45:20: error: invalid use of incomplete type ‘class TabStripModel’
           sources_[i]->RemoveObserver(observer_);
           ~~~~~~~~~~~~~^~~~~~~~~~~~~~

This is caused by https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89311 ("Brace
initialization needlessly invokes destructor"), i.e. having something like

    ScopedObserver<T, U> observer_{this};

in a header declaration requires T and U to be fully declared because
ScopedObserver's destructor references them. In a few cases, T was only
forward-declared.

Bug: 819294
Change-Id: Ie5b9dc2745e27d4532c5539e3845a8c9147a0595
Reviewed-on: https://chromium-review.googlesource.com/c/1472576
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632385}

This CL adds a common factory method named BuildChromeSigninClientWithURLLoader to
chrome/browser/signin/chrome_signin_client_test_util.cc|h to create a
ChromeSigninClient instance supplying the test's URLLoaderFactory to it.
This avoids GCMSFactory::GetInstance to be referenced from various places
for similar purposes.

In the end, there is no functionality change since GCMS fetches its
URLLoaderFactory instance from SigninClient when needed.

c/b/signin/gaia_cookie_manager_service_test_util.cc|h is removed.

This includes the following files:
- chrome/browser/ui/cocoa/test/cocoa_profile_test.mm
- chrome/browser/extensions/api/identity/identity_apitest.cc
- chrome/browser/ui/views/frame/test_with_browser_view.cc
- chrome/browser/metrics/ukm_browsertest.cc
- chrome/browser/sync/test/integration/secondary_account_helper.cc|h
- chrome/browser/sync/test/integration/single_client_secondary_account_sync_test.cc
- chrome/browser/sync/test/integration/single_cl

TBR=treib@chromium.org (Marc has reviewed //c/b/sync changes in CL_1466606
    that got reverted due to another problem).

BUG=930745

Change-Id: I4887f10f0a66b7c60d21bc7fd97f1b0d8f01a84b
Reviewed-on: https://chromium-review.googlesource.com/c/1471790Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#632384}

Adds the boolean "activatable" flag to DisplayLockOptions, which is
false by default. Signifies whether the lock can be activated by the
browser when needed, in cases like find-in-page, tab order navigation,
URL fragment anchor, etc.

This CL also renames the "IsSearchable" method in DisplayLockContext
to "IsActivatable", to be consistent with the option name.

The actual activation & "beforeactivate" event will be implemented in
another CL.

See doc: http://bit.ly/2RXULVi

Bug: 882663
Change-Id: I259ff7f2fed2e3e1f446fa33f202ed2d81a76ad7
Reviewed-on: https://chromium-review.googlesource.com/c/1466544Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632383}

This migrates chromeos::UserSessionManager from NetworkChangeNotifier to
NetworkConnectionTracker, which works with the network service enabled.

Bug: 887047
Change-Id: I814311aa08ab2dafa7bf9b4ac59b3dab0e0a984e
Reviewed-on: https://chromium-review.googlesource.com/c/1237553
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: proberge <proberge@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632382}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f806ca6b..3c4ae81e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2667b8c45fc4d51781a2f8b9e3b5ba2db0f7b30d
Reviewed-on: https://chromium-review.googlesource.com/c/1473839Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632381}

This is a code-health cleanup following discussions in
https://crrev.com/c/1462139/13/chrome/test/chromedriver/test/run_webdriver_tests.py#30

This is a mechanical substitution in blinkpy excluding third_party.

Change-Id: Ib546bb5fea743484186f62fd6fc1ea561700d610
Reviewed-on: https://chromium-review.googlesource.com/c/1473845Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632380}