GitLab

R=aandrey, eustas, yurys

Review URL: https://codereview.chromium.org/344443003

git-svn-id: svn://svn.chromium.org/blink/trunk@176404 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some modules, for example WebMIDI and WebCrypto, needs "Async Initializer".
The initializer should stay alive until the initialization succeeds (i.e. the
associated Promise is resolved), the initialization fails
(i.e. rejected), or the associated ExecutionContext is stopped.
This CL introduces the the constructor mode ScriptPromiseResolverWithContext.
If KeepAliveWhilePending is specified, the created resolver stays alive while
one of the above conditions meets.
Each initializer can stay alive by inheriting ScriptPromiseResolverWithContext.

This CL rewrites WebMIDI and WebCrypto async operations with it.

BUG=361041

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176381

Review URL: https://codereview.chromium.org/311733004

git-svn-id: svn://svn.chromium.org/blink/trunk@176403 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The crash was presumably caused by breakpointId handle being null because of exception in debugger. Generally debugger calls shouldn't throw but since some parts of it are implemented in JS there may be a stack overflow which would result in an exception and empty result handle.

BUG=381567

Review URL: https://codereview.chromium.org/341713008

git-svn-id: svn://svn.chromium.org/blink/trunk@176402 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As the WebSocket class handles suspend / resume, we can remove the suspend /
resume code from ThreadableWebSocketChannelClientWrapper.

BUG=384238
R=tyoshino

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176303

Review URL: https://codereview.chromium.org/333223002

git-svn-id: svn://svn.chromium.org/blink/trunk@176401 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=caseq@chromium.org

Review URL: https://codereview.chromium.org/337283004

git-svn-id: svn://svn.chromium.org/blink/trunk@176400 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a minor refactoring which moves the case of calculation
of cross-size of flex line for single line flex-container from
RenderFlexibleBox::repositionLogicalHeightDependentFlexItems
to RenderFlexibleBox::alignFlexLines which is more appropriate
and saves us from doing unnecessary work.  The old code was doing 
align-content for a single line, then reposition 
everything when aligning children.

Review URL: https://codereview.chromium.org/340513004

git-svn-id: svn://svn.chromium.org/blink/trunk@176399 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Static attributes are now supported by the base IDL parser, so these
overrides are no longer needed.

Followup to:
IDL parser: add StaticAttribute production
https://codereview.chromium.org/333853002/

...and prep for:
IDL parser: align with current Web IDL specification
https://codereview.chromium.org/329853005/

Review URL: https://codereview.chromium.org/336733002

git-svn-id: svn://svn.chromium.org/blink/trunk@176398 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- rename generatePopupContent.* to generateDetailsContent where appropriate;
- change generateDetailsContentForFrame to use TimelineDetailsContentHelper,
    thus removing redundant header;
- (drive-by) fix frame start time in case frames are built from trace events.

Review URL: https://codereview.chromium.org/341483005

git-svn-id: svn://svn.chromium.org/blink/trunk@176397 bbb929c8-8fbe-4397-9dbb-9b2b20218538

applyPropertyAll expands all shorthand property to longhand properties,
and apply each longhand property according to all's value (e.g. if
all's value is initial, initial).

Spec: http://dev.w3.org/csswg/css-cascade/#all-shorthand

BUG=172051
TEST=fast/css/all-shorthand.html

Review URL: https://codereview.chromium.org/339163002

git-svn-id: svn://svn.chromium.org/blink/trunk@176396 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The scrollbars does not paint as verticalScrollbarWidth() returns 0 in paint in case of overlay-scrollbars.
We should use actual scrollbar width while placing and painting the scrollbar.

BUG=385463

Review URL: https://codereview.chromium.org/337323002

git-svn-id: svn://svn.chromium.org/blink/trunk@176395 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Last user was removed with
http://src.chromium.org/viewvc/blink?view=revision&revision=171958

Review URL: https://codereview.chromium.org/341503002

git-svn-id: svn://svn.chromium.org/blink/trunk@176394 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Disallow new/delete operations for HitTestResult.
  HitTestResult was used
  -- with new/delete operators
  -- as part objects of ContextMenuController and MouseEventWithHitTestResult.
  -- as stack allocated objects

  We'd like to avoid to make such classes in Oilpan.
  So, this CL disallows new/delete, and WebHitTestResult owns another
  class to hold only required data copied from a HitTestResult.

- Move ContextMenuController to Oilpan heap, and trace HitTestResult member.

- Mark MouseEventWithHitTestResults STACK_ALLOCATED.

- We can't get HitTestResult from a WebHitTestResult. So we need to
  introduce new function to WebViewImpl for WebSubstringUtil.mm.


BUG=357163

Review URL: https://codereview.chromium.org/326393003

git-svn-id: svn://svn.chromium.org/blink/trunk@176393 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The CG for constructors and named constructors had its own simplified
mechanism for generating the actual call to the C++ constructor, rather
than using v8_methods.cpp_value(). Except for constructors with
optional arguments without default values, which used cpp_value() via
v8_methods.generate_argument() to generate the "short-cut" call used
when the function is called without the optional arguments.

With this patch, v8_methods.cpp_value() is used for all calls. This
will make it easier to adjust the handling of arguments later on in the
more complex cases.

Some IDL files that declare named constructors are modified by adding
ConstructorCallWith=Document, which was previously implied for named
constructors.

BUG=258153

Review URL: https://codereview.chromium.org/340443004

git-svn-id: svn://svn.chromium.org/blink/trunk@176390 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=jww
BUG=372920,245025

Review URL: https://codereview.chromium.org/344503003

git-svn-id: svn://svn.chromium.org/blink/trunk@176389 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a preparation to improve WebCore::XPath::EvaluationContext.
This CL should have no behavior changes.

BUG=

Review URL: https://codereview.chromium.org/344553002

git-svn-id: svn://svn.chromium.org/blink/trunk@176388 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL enables custom background color to be specified for IME composition.
Its Chrome counterpart is: https://codereview.chromium.org/313053007 .  Details:

- Adding backgroundColor to the following:
    WebCore::CompositionUnderline
    blink::WebCompositionUnderline
  for backward compabitility, we keep an old constructor, which will be deleted
  in another refactoring CL. Updated some tests to use the new constructor.
- Refactored (now) repetative code to loop over WebCompositionUnderline  that
  intersect with a range by adding class CompositionUnderlineVisitor.
- Perhaps WebCompositionUnderline should be renamed to WebCompositionSpan,
  but this refactoring task can be done in a separate CL.

We will need to split this CL when we commit.

BUG=135900

Review URL: https://codereview.chromium.org/313233002

git-svn-id: svn://svn.chromium.org/blink/trunk@176387 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/334393003

git-svn-id: svn://svn.chromium.org/blink/trunk@176386 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To confirm sanity.

BUG=

Review URL: https://codereview.chromium.org/338283003

git-svn-id: svn://svn.chromium.org/blink/trunk@176385 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2 real violations were masked by skipping check-webkit-style in this CL:
Manually commit changes that cause false-alarm on check-webkit-style.
https://codereview.chromium.org/330323005/

This fixes them.

BUG=381876
R=haraken

Review URL: https://codereview.chromium.org/347473002

git-svn-id: svn://svn.chromium.org/blink/trunk@176384 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext. (https://codereview.chromium.org/311733004/)

Reason for revert:
This CL breaks the build.

Original issue's description:
> Introduce KeepAliveWhilePending to ScriptPromiseResolverWithContext.
> 
> Some modules, for example WebMIDI and WebCrypto, needs "Async Initializer".
> The initializer should stay alive until the initialization succeeds (i.e. the
> associated Promise is resolved), the initialization fails
> (i.e. rejected), or the associated ExecutionContext is stopped.
> This CL introduces the the constructor mode ScriptPromiseResolverWithContext.
> If KeepAliveWhilePending is specified, the created resolver stays alive while
> one of the above conditions meets.
> Each initializer can stay alive by inheriting ScriptPromiseResolverWithContext.
> 
> This CL rewrites WebMIDI and WebCrypto async operations with it.
> 
> BUG=361041
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176381
TBR=yhirano, haraken, eroman, toyoshim@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/339443004

git-svn-id: svn://svn.chromium.org/blink/trunk@176383 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test is based on sorvell@'s test case reported
at http://jsbin.com/ganocegu/4/edit for crbug.com/355674.

As the result of moving style in shadow's scope from
its host to its root, this issue has been fixed since
r176304.  This is the test case to catch any regression
about shadow's sibling matching.

BUG=355674
TEST=this layout test passes.

Review URL: https://codereview.chromium.org/330193006

git-svn-id: svn://svn.chromium.org/blink/trunk@176382 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some modules, for example WebMIDI and WebCrypto, needs "Async Initializer".
The initializer should stay alive until the initialization succeeds (i.e. the
associated Promise is resolved), the initialization fails
(i.e. rejected), or the associated ExecutionContext is stopped.
This CL introduces the the constructor mode ScriptPromiseResolverWithContext.
If KeepAliveWhilePending is specified, the created resolver stays alive while
one of the above conditions meets.
Each initializer can stay alive by inheriting ScriptPromiseResolverWithContext.

This CL rewrites WebMIDI and WebCrypto async operations with it.

BUG=361041

Review URL: https://codereview.chromium.org/311733004

git-svn-id: svn://svn.chromium.org/blink/trunk@176381 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the first of a three-sided change to remove LegacyFrameProcessor
from Blink and Chromium now that the new FrameProcessor is stabilized.
Once Chromium no longer implements the FrameProcessorChoice version of
WMSI::addSourceBuffer(), a third change will remove the default Blink
implemenetations of addSourceBuffer() and the FrameProcessorChoice enum.

R=acolwell@chromium.org,abarth@chromium.org
BUG=249422
TEST=No MSE layout test regression locally on Linux

Review URL: https://codereview.chromium.org/310733002

git-svn-id: svn://svn.chromium.org/blink/trunk@176379 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No one uses this anymore.

Review URL: https://codereview.chromium.org/344523002

git-svn-id: svn://svn.chromium.org/blink/trunk@176378 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These are not set by the embedder yet, so the value is always null.

BUG=379012

Review URL: https://codereview.chromium.org/335293003

git-svn-id: svn://svn.chromium.org/blink/trunk@176377 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=245025, 379976

Review URL: https://codereview.chromium.org/336693003

git-svn-id: svn://svn.chromium.org/blink/trunk@176376 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove it to avoid misuse like the following:
  TRACE_EVENT1("a", "b", "c",
     condition ? TRACE_STR_COPY(short_live_string) : "literal");
In the above case, the argument value is actually const char*, not
TraceValueWithCopy because it is automatically converted back to
const char* with the const char* operator.

Found and fixed one error in WebKit.

Also changed some TRACE_STR_COPY(cstring.ascii().data()) to
cstring.ascii() because we always copy CStrings.

R=dsinclair,haraken
TBR=... changes of callers about TRACE_STR_NO_COPY
BUG=382789 (perhaps the reason)

Review URL: https://codereview.chromium.org/342513003

git-svn-id: svn://svn.chromium.org/blink/trunk@176375 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Prior to this CL, we updated both the style determined and the non-style
determined compositing reasons during the chicken/egg compositing update. Now
we only update the style-determined reasons, which means the non-style
determined reasons are only computed during the real compositing update.

R=vollick@chromium.org

Review URL: https://codereview.chromium.org/342593003

git-svn-id: svn://svn.chromium.org/blink/trunk@176374 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change fixes non-compliant MSE behavior when the duration is set
to a smaller value. The spec calls for remove() to get called in this
case which wasn't happening before. This causes SourceBuffer.updating
to become true which prevents other operations like endOfStream() from
being allowed until the remove completes. Tests that relied on this
broken behavior have been updated.

BUG=381302

Review URL: https://codereview.chromium.org/319213002

git-svn-id: svn://svn.chromium.org/blink/trunk@176373 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove SVG paint order runtime flag, since this has been stable for a while. This also removes one check in CSSPropertyParser.

Review URL: https://codereview.chromium.org/339963002

git-svn-id: svn://svn.chromium.org/blink/trunk@176372 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously it would return an array buffer of the JSON.

This corresponds with the recent spec update:
https://dvcs.w3.org/hg/webcrypto-api/rev/f61017a76a5d

BUG=373917,245025

Review URL: https://codereview.chromium.org/338993002

git-svn-id: svn://svn.chromium.org/blink/trunk@176371 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If my understanding is correct, we need "[TreatReturnedNullStringAs=Null] ByteString get(ByteString key);" for Headers class to return null.
http://fetch.spec.whatwg.org/#dom-headers-get


BUG=347426

Review URL: https://codereview.chromium.org/337373002

git-svn-id: svn://svn.chromium.org/blink/trunk@176370 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=381876
NOTRY=true

Review URL: https://codereview.chromium.org/330323005

git-svn-id: svn://svn.chromium.org/blink/trunk@176369 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In r176050, moving the full view repaint from StyleEngine to Document, the
check changed from !hasPendingSheets() to haveStylesheetsLoaded(). The
difference is that m_ignorePendingStylesheets affected the result of the
check which causes a FOUC in named BUG.

BUG=384969

Review URL: https://codereview.chromium.org/339573005

git-svn-id: svn://svn.chromium.org/blink/trunk@176367 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Change the ownership of AttrNodeList from a static HashMap to ElementRareData.

ElementRareData size increases by this change. A complex web page will
have slight increase of memory consumption even if the page doesn't
use Attr nodes.

BUG=357163,381629

Review URL: https://codereview.chromium.org/328243005

git-svn-id: svn://svn.chromium.org/blink/trunk@176366 bbb929c8-8fbe-4397-9dbb-9b2b20218538

FELightingNEON.h's inline FELighting::platformApplyNeon() method refers
to an extern neonDrawLighting symbol.  This function is implemented in
assembly in WebKit but does not exist in blink.  This must then be dead
code (otherwise there would have been complaints).

The only reference to platformApplyNeon that I can find is an ifdef'ed
call in FELighting::platformApply(), which is only enabled if the target
supports NEON but not Thumb (which I guess must be very uncommon).

BUG=381082
TEST=build with arm_neon=1 arm_thumb=0

Review URL: https://codereview.chromium.org/313303003

git-svn-id: svn://svn.chromium.org/blink/trunk@176365 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Disabling the tests as PopupListBox is not used for rendering <select> on android.

BUG=385588

Review URL: https://codereview.chromium.org/341543002

git-svn-id: svn://svn.chromium.org/blink/trunk@176364 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add some missing targets and do some minor fixes and additions.

Hook up modules and web targets to the build now that they work.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/343503003

git-svn-id: svn://svn.chromium.org/blink/trunk@176363 bbb929c8-8fbe-4397-9dbb-9b2b20218538

LayoutState does 2 fundamentally different things: it acts as a quick
repaint mapping between renderers and their repaint container (currently
only the RenderView crbug.com/363834), and keeps track of various layout
tree information (like the current pagination model).

Because the fast repaint mapping doesn't work for all types of renderers,
there's a concept of LayoutState being disabled, and sometimes not 'pushed'
at all. This CL renames the disabled state, which only applies to the
repaint optimization, to layoutStateCachedOffsetsEnabled, and makes
LayoutState stack-based instead of heap-based. It now will always "push,"
and tracks whether or not the repaint optimization is disabled as part of
itself.

This is one step in the process of teaching LayoutState to work on
renderers that aren't the RenderView.

BUG=363834

Review URL: https://codereview.chromium.org/335963002

git-svn-id: svn://svn.chromium.org/blink/trunk@176362 bbb929c8-8fbe-4397-9dbb-9b2b20218538

of the backing GraphicsLayer, not the squashing container
(they are not the same in the presence of layer squashing).

BUG=384963

Review URL: https://codereview.chromium.org/337173003

git-svn-id: svn://svn.chromium.org/blink/trunk@176361 bbb929c8-8fbe-4397-9dbb-9b2b20218538