GitLab

During destruction of WebView it's possible that not every observer has
unsubscribed from BeginFrameSource in RootFrameSink (the latest it will
happen in dtor RootFrameSink). This leads to situation when
RootFrameSinkProxy is still observing BrowserViewRenderer's
BeginFrameSource in dtor which leads to DCHECKs.

This CL adds explicit RemoveObserver in RootFrameSinkProxy dtor to
handle sutiation correctly.

Bug: 1054777
Change-Id: I00811c79ae430872964075c83a308cad17a8694a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067087Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743567}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95fa3e68d355..f67f959012ef


Created with:
  gclient setdep -r src-internal@f67f959012ef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I99b617de5f75940ee34db1083685d04d47661d62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068423Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743566}

User app activity data should only be uploaded to the server when
app activity collection toggle is enabled. If collection is disabled
Per-App Time Limits feature will still work 'locally', but without
uploading activity data. As a consequence parent nor child will not
be see activity data in Family Link app.

Bug: 1042477
Change-Id: I93382b654e490e2f8431dbd345f242ed2cc44f95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067662Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743565}

Bug: 1049185
Change-Id: Ide6316330f98c2b8a325a03403dd5b3184574bcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066923
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743564}

Ownership is changed to CrOS Family Experiences team.
Updated histograms:
* ManagedUsers.SafeSitesDelay
* Profile.NumberOfManagedProfiles
* Profile.PercentageOfManagedProfiles

Bug: 1053109, 1053004
Change-Id: Ie435635d6d66248fee63101b919957bc51ad6915
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067559Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743563}

Bug: 1054696
Change-Id: Icf2d04d066a8af07577f0e9c52963ae09a0c3221
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067860Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743562}

Trust Tokens key commitment records are served during the
issuance and redemption steps of the Trust Tokens (Privacy Pass)
protocol. These are JSON messages returned by a server endpoint
located at a .well-known path relative to the Trust Tokens issuer
origin.

This change adds a flow for fetching these from the server;
a concurrent CL (https://crrev.com/c/2029292) adds logic for parsing
the messages.

New code:
- KeyCommitmentController, which manages a commitment
request, creating an appropriately parameterized (viz., uncredentialed)
ResourceRequest and passing it to a SimpleURLLoader
- Unit tests verifying requests are constructed correctly and testing
end-to-end request flow by mocking out the response parser

Bug: 1042962
Change-Id: Iccf590a1b9a7b82f0ee85d7f6eb057f6194cced0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057009
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743561}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4b6120a066eb..84d733f34b73

git log 4b6120a066eb..84d733f34b73 --date=short --first-parent --format='%ad %ae %s'
2020-02-21 tvanderlippe@chromium.org Revert "Updates performance timeline for long tasks"
2020-02-21 tvanderlippe@chromium.org Revert "Build Karma test with Ninja"
2020-02-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-02-21 aerotwist@chromium.org Updates performance timeline for long tasks
2020-02-21 tvanderlippe@chromium.org Build Karma test with Ninja

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@84d733f34b73

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1011811,chromium:1054447
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I8b6f14ccba93d5015a2d284e5e2ab0fd69b98d8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068375Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743560}

This is a workaround for the blink unit tests that run non-nested
pending tasks manually with heap pointers on stack. We can't use
GCForbiddenScope there anymore because incremental marking was moved
to tasks which are executed from the task runner in tests.

Bug: 1022735
Change-Id: Id870d2da846d1b5cbedc6c053d2c06d1d9f2435c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906353
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743559}

This CL modernizes the OmniboxCoordinator
 - to use |browser| in the initializer,
 - to remove the public property for  dispatcher and browserstate,
 - to use self.browser to get browserstate and dispatcher values.

This includes migration to ChromeCoordinator as a superclass.

Bug: 1029346, 1048422
Change-Id: I894a367dec2c2c1c289b9709f1015401f661b328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066728Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Nazerke Kalidolda <nazerke@google.com>
Cr-Commit-Position: refs/heads/master@{#743558}

Before change:
The URL view on Expandable Payment Handler UI toolbar gets updated when
navigation starts. No URL update on navigation end.

After change:
No URL update on navigation starts; instead, it happens on navigation
end.

Change:
Move URL update from navigation start to navigation end

Bug: 1051634

Change-Id: Iab484aa710919b5cf2e23916ab85204aa9b5f0c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065496Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743557}

This reverts commit ed3b55f6.

Reason for revert: b/149959687
broke tast.video.DecodeAccelPerf.vp9_1080p_30fps on kevin|hana|scarlet 64 bit

Original change's description:
> media/gpu/test: Group ivf frames whose timestamps are same
>
> The served stream in webrtc can be dumped by the chrome
> option [1]. When the stream structures spatial-layers, one
> spatial layer is separately saved in one ivf in the dumped
> ivf file.
>
> On the other hand, to play the ivf file properly, it is needed
> to group the spatial layers, which have the same timestamp in
> ivf frame header. IvfFileReader [2] in webrtc does so in fact.
>
> This applies the group logic to our own ivf parser used in
> VDA test. This enables us to test SVC stream in VDA test.
>
> [1] --force-fieldtrials=WebRTC-DecoderDataDumpDirectory/;tmp;
> [2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/modules/video_coding/utility/ivf_file_reader.h
>
> Bug: 1044816
> Test: video.DecodeAccel.vp9_ksvc
> Change-Id: I9a0bcfa9083dc71333ad3c727d6cbb6d902202bc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032453
> Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
> Reviewed-by: David Staessens <dstaessens@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740575}

TBR=hiroh@chromium.org,dstaessens@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1044816, b:149959687
Change-Id: I4863f2d6a9079957a16a33eca339bd29ff81b2d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068122
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743556}

Use the same test exceptions for Fuchsia ARM64 as fuchsia-fyi-arm64-rel.

Bug: 1042512
Change-Id: I7b9333e49151975b4bfecb98dd6d36d954b514ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067673Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Stephen Roe <steveroe@google.com>
Cr-Commit-Position: refs/heads/master@{#743555}

After migrating away from ui::*Event constructors to XEvent translation
helper functions in Aura/X11, MouseEvent::changed_button_flags is
wrongly initialized for non-XI2 XEvents. This causes issues such as
crbug.com/1053931 and crbug.com/1047484. This CL fixes it as well as
adds unit tests to prevent future similar regressions.

Bug: 1054581, 1053931, 1047484
Test: events_unittests --gtest_filter=XEventTranslationTest.ChangedMouseButtonFlags
  interactive_ui_tests --gtest_filter=ToolbarActionViewInteractiveUITest.TestContextMenuOnOverflowedAction

R=sadrul@chromium.org

Change-Id: Iddc55cbaf36e5f40bb09655149e5b288b8402652
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063749Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#743554}

|request_completed_callback_| might destroy
PerUserTopicSubscriptionRequest object, so any use of this object after
running the callback must be avoided.

It wasn't the case for OnURLFetchCompleteInternal() which called
RecordRequestStatus() with arguments based on class members after
the running callback.

This CL reorders the calls to avoid heap-use-after-free and adds
documentation for |request_completed_callback_| behavior.

Bug: 1054590, 1054759
Change-Id: Iea0d10a7bbabc3b4cabdfea233e0ec0c79bd197c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066924
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743553}

The metric finds periods in a trace when scroll update events started
but didn't finish. The idea is arguable, but it corresponds well with
my subjective feeling of scroll jankiness when I look at the phone
screen.

My plan is to run this on an FYI bot on the waterfall for a while, to
see how stable the results are, and what can affect them.

Change-Id: If8833af1c07f56b1a21abce443e2915b39e736bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062334
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Reviewed-by: Deepanjan Roy <dproy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743552}

Currently, we can enable or disable set of features during our tests
using @Features annotations. This populates the |sTestFeatures|.
During our check of whether a feature is enabled or not in
ChromeFeatureList#isEnabled we check first if the feature is present
in the |sTestfeatures|. In case it's not we return an IllegalArgument
Exception. This however omits a check to see if that feature may be
present in native instead.

This CL adds a new variable |sTestCanUseDefaults| which will be set as
true for instrumentation tests that require access to default value
in native flags and is by default false, ideally for unit tests that
must explicitly enable or disable each Features, for which the their
unit test relies on.

Bug: 1053463
Change-Id: Iab681c610bb41141f74764e58efaecbabb85dc18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061155
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743551}

* Aligns the safety check parent element with the latest UI mocks.
* Adds a parent element update method that updates the element
  to the provided state.

Bug: 1015841
Change-Id: I22d291a0e83f16dd4eb1915fdd7023f6ec511c1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057306Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743550}

Dispatcher property is unused. It is replaced by Browser.

Change-Id: I005031492374c5992455f3f1e6cae50cc35b11a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066905
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743549}

https://swiftshader.googlesource.com/SwiftShader.git/+log/1ee36c9fa7e5..48d08d644c30

git log 1ee36c9fa7e5..48d08d644c30 --date=short --first-parent --format='%ad %ae %s'
2020-02-21 sugoi@google.com Revert "Subzero: add support for large stacks on Windows"
2020-02-20 amaiorano@google.com Subzero: add support for large stacks on Windows

Created with:
  gclient setdep -r src/third_party/swiftshader@48d08d644c30

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I110eef4c6405f2c8871f85ac47d8cb0254d63449
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068373Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743548}

This CL is a straight up mechanical change adding {await} to
various test helper methods that will become asynchronous. This prepares
web tests for asynchronous source mapping.

Bug: chromium:1032016
Change-Id: I9048cf6b165b4449c1e6aad1e3b88fafa50d6823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066903Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743547}

Bug: 873178
Change-Id: I55b70398864f4ceb1cf0978c2297f36ccef415bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066763
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743546}

Bug: 844530
Change-Id: I2ba07519a2be33b2333aae7c0fe1730809520dcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049972Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Thomas Tellier <tellier@google.com>
Cr-Commit-Position: refs/heads/master@{#743545}

With VizForWebview enabled webview now supports offscreen canvas.
This CL updates list of exposed interfaces accordingly.

Bug: 1054775
Change-Id: I1397e4629d9878712e3bce59237f4a424e7ab8b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067084Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743544}

https://webrtc.googlesource.com/src.git/+log/d881983a38b4..694b74b82673

git log d881983a38b4..694b74b82673 --date=short --first-parent --format='%ad %ae %s'
2020-02-21 titovartem@webrtc.org Fix export of plottable metrics on iOS
2020-02-21 phoglund@webrtc.org Whitespace change to kick bots.
2020-02-20 danilchap@webrtc.org Authenticate video header when dependency descriptor is sent
2020-02-20 phoglund@webrtc.org Make pc level smoke tests faster.
2020-02-20 nisse@webrtc.org Delete header file rtc_base/memory/aligned_array.h
2020-02-20 fabianbergmark@google.com Change the AudioDeiviceDataObserver to be passed as a unique_ptr.
2020-02-20 mbonadei@webrtc.org Revert "Delete legacy DataSize and DataRate factories"
2020-02-20 mbonadei@webrtc.org Revert "Remove old-style OnFailure callbacks"

Created with:
  gclient setdep -r src/third_party/webrtc@694b74b82673

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:589455
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I84d4baa64d777e416e00ad7584fedf9bc2e3d90c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068374Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743543}

This reverts commit 0f2af34b.

Reason for revert: pixel_skia_gold_tests failing https://crbug.com/1054796

Original change's description:
> Allow OffscreenCanvas to access the high-performance GPU.
>
> Instead of only checking whether the containing frame is same-origin
> with respect to the top-level document during
> transferControlToOffscreen, check in the OffscreenCanvas constructor,
> both for the main thread as well as dedicated workers. Dedicated workers
> are same-origin per specification, so always grant access to the
> discrete GPU in this scenario.
>
> Add new pixel tests that verify WebGL-rendered OffscreenCanvas into an
> ImageBitmapRenderingContext (i.e., where the OffscreenCanvas was not
> originally tied to a canvas element). On dual-GPU macOS devices, also
> verify the active state of the low-power and high-performance GPUs.
>
> Simplify some of the tests most recently written for low/high-power GPU
> switching.
>
> Bug: 1048892
> Change-Id: I85addc2b53a58997499e444b357d433d7082e262
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043076
> Commit-Queue: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Reviewed-by: Fernando Serboncini <fserb@chromium.org>
> Reviewed-by: James Darpinian <jdarpinian@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#743419}

TBR=kbr@chromium.org,jdarpinian@chromium.org,fserb@chromium.org,kainino@chromium.org

Change-Id: I198e4617df9c75691b84beb0e801b4e2a2b149eb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1048892, 1054796
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067085Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743542}

https://boringssl.googlesource.com/boringssl/+log/7e43e2e8eecc9114f829e6d75cc3c04d1af57504..6432bb46ab44731567ec923e6c8fc182f13d0070

The following commits have update notes:
  0c30649ba Clean up TLS 1.3 handback logic.
  f9cc26f9c Require handshake flights end at record boundaries.

Bug: none
Change-Id: Iffb9ae034fcd7c7e27659dccc7a7d0842bb3546e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067562
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743541}

https://chromium.googlesource.com/angle/angle.git/+log/61194f9321a7..d3aad0f4d106

git log 61194f9321a7..d3aad0f4d106 --date=short --first-parent --format='%ad %ae %s'
2020-02-21 jmadill@chromium.org Vulkan: Remove command graph size overlay widget.

Created with:
  gclient setdep -r src/third_party/angle@d3aad0f4d106

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I6f89893114bffc2909677ed04299e778830d7b8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068369Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743540}

Bug: 1015841
Change-Id: I789e97bb67a8537537ade0ca9755bbe7cbd7c3f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066547Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Andrey Zaytsev <andzaytsev@google.com>
Cr-Commit-Position: refs/heads/master@{#743539}

As part of unit-testing this class, I added a hook to it named
g_giving_up_callback. The destructor looks like this:

  ExtensionInstalledWaiter::~ExtensionInstalledWaiter() {
    if (done_callback_)
      g_giving_up_callback->Run();
  }

The hook allows unit tests to plug into the "browser destroyed while
ExtensionInstalledWaiter is live" behavior, which improves test
coverage. However, in production, g_giving_up_callback is null, so the
effect of this test hook was that if this case (ExtensionInstalledWaiter
being destroyed by browser exit) ever happened *in production*, the
browser would crash :(

Bug: 1049190
Change-Id: I434613d292ffd115dde9b6d8bc1658a14cd5dd0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067465Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743538}

saml_handler.js has dependency on saml_password_attributes.js, which is
located in resources/chromeos/login. Since this file is not used
anywhere else, move it and it's dependencies (saml_timestamps.js) to
gaia_auth_host/ folder.

Bug: 1054394
Change-Id: I7fb2cf5acc1a12ef94acafcc35999eae2288f6ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066789Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743537}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/114bd00a2bb1..95fa3e68d355


Created with:
  gclient setdep -r src-internal@95fa3e68d355

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ic6c84251ba8720e9f70fd987181378e38a19a073
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068370Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743536}

Replace "turn off cookie blocking" with "allow cookies" to remove double
negation.

Bug: 1054735
Change-Id: I212abea2cc3bb4f2a873c297bd373bed69b4de62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066788Reviewed-by: Huanzhong Huang <huanzhong@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743535}

The tests moved to html/semantics/embedded-content/the-img-element:
https://github.com/web-platform-tests/wpt/pull/21773
So the directory and remaining expected results can be removed.

Change-Id: Ib073dd3ca8cd6c6ec27e5c542cd38546fb87e4b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066764Reviewed-by: Frédéric Wang <fwang@igalia.com>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#743534}

Add one more DumpWithoutCrashing to test a theory.

Adds NOTREACHED following DumpWithoutCrashing so that we get internal
reports and maybe find a way to repro.

Bug: 1006814
Change-Id: I71d5f9bfb30bc33661db32a9e4fc567ce158c487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054653
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743533}

Get GN to build the XCode project with the autoninja command as build
command instead of regular ninja.

Bug: 1052038
Change-Id: Ib7440bf7c9d89ee4766f5f1114310c4a6df3c6aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055024
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743532}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6684a9fe..f33bae87

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2e32b0dfcfc98da64bbae78cfcf573cf5469764a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066581Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743531}

The capture experiment will enable a flag that captures and immediately
deletes paint previews with the intent of getting some metrics on
performance, artifact size, etc. This CL adds metrics to record
success, time and compressed disk size.

Bug: 1038390
Change-Id: Idb6bf18fc2f8dd2a1091f175db01b0443702999b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037342
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743530}

This change introduces the concept of "element condition", which are
arbitrary combination of element check that support and, or and not, and
is expressed in the proto as "all_of", or as "any_of and not as "none_of"

In proto, the concept is represented by ElementConditionProto. In C++,
the existing ElementPrecondition.

This change also switches all "element conditions" to use this concept,
that is to decide:
 - whether script preconditions match
 - whether wait for dom can continue
 - whether a prompt choice should be shown
 - whether a prompt choice should be auto-selected

The idea is to have only one piece of code that does element condition
that can be reused in multiple places that is powerful enough not to
require constant extensions.

This change is not backward-compatible with previous proto definition.
The idea is to have the server generate both the old proto and the new
conditions before submitting this change.

Bug: b/147865211
Change-Id: I74925e95a7c4898baaec3a64746c8c25e988ceb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020951
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743529}

TBR=bling-p10-rolls@google.com

Change-Id: Iff39002295b07f42d5f35eee1b57e5260860e9db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068120Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743528}