- 12 Nov, 2020 40 commits
-
-
Stefan Zager authored
Change-Id: I7aa610995e6ee647f2a30ca3df5649d67cd7031a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533328Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#826607}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e1012cfc791d..b638dfe160a1 2020-11-11 nicolascapens@google.com Fix backslash interpreted as part of URL 2020-11-11 srisser@google.com Implement VK_KHR_shader_float_controls 2020-11-11 amaiorano@google.com Subzero: clang-format crosstest, pnacl-llvm, runtime, and unittest 2020-11-11 amaiorano@google.com Subzero: clang-format src 2020-11-11 capn@google.com Fix LLVM host triple for ORCv2 JIT If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I98581d0e2f34f8bdd239fe965ebbd07988fe9c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533502Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826606}
-
David Dorwin authored
Since this is for development, it makes sense to enable logging. Bug: 1051533 Change-Id: Ib0f46de196e1edeb0068e84c556fc1952bee19d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533973 Commit-Queue: David Dorwin <ddorwin@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#826605}
-
zhiyuancai authored
Bug: 1144742, 1148020 Change-Id: I03cbed7c8c2b66f0ff4779eb1a200123040d29ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533037 Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#826604}
-
Yu Han authored
Update form-controls-dark-mode flag expiry-milestone Tbr: masonfreed@chromium.org Bug: 929098 Change-Id: I5934653aaf0514cf7c4172a4dccdc34bdaee383b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532581 Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826603}
-
Tal Pressman authored
All listeners should be registered on the AgentSchedulingGroup(Host), so there shouldn't be a need for this delegation. This follows-up on a comment from crrev.com/c/2513958. Bug: 1111231 Change-Id: I69e13cbc1cadd1c7d2dc7b5b425353adabd4c364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526667 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#826602}
-
Devlin Cronin authored
Add a minimal scripting.executeScript() function. This currently only allows taking in a function (to be serialized), targeting the main frame of the tab, and does not support currying arguments. Follow-ups will address these (and other) expansions. This adds the "scripting" namespace, permission, and enums, the executeScript core function, and an end-to-end API test for function serialization. Bug: 1144841, 1144839 Change-Id: Ibd0ecaaec84b5ade27b6af897467ae71284046cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531658 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#826601}
-
Moe Ahmadi authored
MostVisitedSites will be serving repeatable queries in the first two or the last two slots for the Most Visited URLs, if applicable, depending on the chosen variation. Fixed: 1145050 Change-Id: I899eb37d5461dc68e43c85bcaf0666830575e025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531067Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826600}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dfff133590c2..d3f0d0cc3810 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I568e1c52345c1e4a0d675c22547234e286f41514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533304Reviewed-by:
-
Shakti Sahu authored
This CL adds reading list read and unread section headers to the reading list page in bookmarks. Bug: 1139070 Change-Id: If2d3d02bb4b354f1e2d1b5269fa89875e46a6562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518426 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826598}
-
David Lei authored
Feeds in isDevChannel to window.features via loadTimeData. This allows us to determine if the SWA is running in a DEV channel. Bug: b/159267911 Change-Id: Id4dcbb8be14fc726cf995d9accba07658f55ef88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531336 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
David Lei <dlei@google.com> Reviewed-by:
Patti <patricialor@chromium.org> Auto-Submit: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#826597}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b776a105e531..59bafeeaa7de 2020-11-11 kjlubick@google.com [canvaskit] Deprecate measureText 2020-11-11 kjlubick@google.com [canvaskit] Use Raster instead of RasterDirect for Canvas2D surface 2020-11-11 bsalomon@google.com Split SkYUVAInfo::PlanarConfig into PlaneConfig and Subsampling enums 2020-11-11 scroggo@google.com Remove SkAnimatedImage::dimensions 2020-11-11 scroggo@google.com Remove unused SkAnimatedImage factory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: I2e0050ada11abef594df4325212f5152c5b7d747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533148Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea473b133142..c877d81ec34e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC estade@google.com,wjmaclean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1143402,chromium:1145379 Tbr: estade@google.com,wjmaclean@google.com Change-Id: I50d833e00f7d42b87bfc1d0c19a43a04b62548c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533434Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826595}
-
Nancy Wang authored
This CL adds the "settings.restore_apps_and_pages" preference item to prepare for the full restore feature. DD: go/chrome-os-full-restore-dd BUG=1146900 Change-Id: I259cc7fac01e77407337dbc2942ef645191c6057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533213 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#826594}
-
David Lei authored
Change-Id: I4daf247e0136bf5a5e95796e0463540099a7b039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533216Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#826593}
-
Juan Mojica authored
Also, use GSAState helper methods to fetch AGSA version names. Bug: 1098431 Change-Id: Ic369d1fbdb08df74dfffacc29592408f74fb9b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522883 Commit-Queue: Juan Mojica <juanmojica@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ben Goldberger <benwgold@google.com> Cr-Commit-Position: refs/heads/master@{#826592}
-
Yusuf Ozuysal authored
Change-Id: Ic6460a234659c04473e486b7cf315ad67b386106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530623 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#826591}
-
Kenneth Russell authored
The earlier of these CLs is suspected to have introduced a flaky failure to load certain images per http://crbug.com/1146687 and linked http://crbug.com/965387 . Speculatively reverting to see if the flakiness is resolved; will revert this if it isn't. Revert "Call OnComplete when pipe creation in OnStartLoadingResponseBody failed" This reverts commit 48341fab. https://chromium-review.googlesource.com/2531088 Revert "Make DeferredOnStartLoadingResponseBody drain the body pipe" This reverts commit b5decd74. https://chromium-review.googlesource.com/2513314 Bug: 1137682 Bug: 1146791 Bug: 1146687 Change-Id: I67dd3697080ceaa6440b63883ef5383ed9381653 Tbr: rakina@chromium.org Tbr: yhirano@chromium.org Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532869Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#826590}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8630bb119f96..26cd974abfad 2020-11-11 hferreiro@igalia.com Add a python2 shim under python2-bin/ 2020-11-11 mattkot@microsoft.com Retry CIPD client download on Linux / macOS 2020-11-11 vadimsh@chromium.org [cipd] Update cipd and vpython to latest versions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1109180,chromium:1124112,chromium:1145741 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I7be92c6400fac4d3c16662308f000e4b89cc256a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533147Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d3f0d0cc3810..53d3c085a784 2020-11-11 fmayer@google.com Merge changes I75cd4e72,I77bf8f64 2020-11-11 cferris@google.com Merge "Update for new unwindstack error codes." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icd67817ae8b5125c5f993c3b665ee94cc6b01ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533799Reviewed-by:
-
Aaron Leventhal authored
- Use clear order - Avoid double calculation of parent TBR=dmazzoni@chromium.org Bug: None Change-Id: Iddc27d27f33191d147c4ad1137e612ae05810a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533578 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#826587}
-
Nate Chapin authored
Bug: 1147612 Change-Id: I970c0dc32c56dd4b94273b5a29dd305925169a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530737 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#826586}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605084700-9619bbd46776ec532a7f848b4f703ffd6d373199.profdata to chrome-win64-master-1605095997-f02476ae2299d621bcc109d9e9e9e82082bcc8d2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibce88217618569e0a460a69709bc05db5a37fbab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533296Reviewed-by:
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=isherman@chromium.org Bug: 1145565 Change-Id: Ia3b05a0631731402d564aff85953d10be62a2096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532718 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826584}
-
Luciano Pacheco authored
Fixed: 1147301 Change-Id: I760e289145fb7cf58372b9b4792e0233a8979def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532019 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#826583}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I9a155c5146a14fdbb2918feb330d712d4c9e7047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532978Reviewed-by:
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=gab@chromium.org Bug: 1145565 Change-Id: I1acc0d0619824b5eb6491715614fbe326530097e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526921Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826581}
-
Josh Simmons authored
This was added in https://chromium-review.googlesource.com/c/chromium/src/+/2496031 but I'd missed updating actions.xml. Bug: 1140581 Change-Id: Ie5139104f4a56aef0741f6ce4919bea5fefac896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532767Reviewed-by:
-
David Black authored
Previously only `kPinnedFile` was being recorded. Bug: 1131266 Change-Id: I55e43c745319e97b2bc7e9fdd94c2dd2f0dd5695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533281Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#826579}
-
Ben Joyce authored
Don't need third party review as source is source from already added android_x libraries with same license. https://chromium.googlesource.com/chromium/src/+/master/third_party/android_deps/README.md "This is not necessary if you are only upgrading existing package s or adding packages from the same source and license (e.g. gms)" "Adding for AnimatorTestRule which would basically time increment like CompositorAnimator." Bug: 1147198 Change-Id: If9dcea302dcd49c823e55a784e0c0bb34365c8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528122Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Adrian Taylor <adetaylor@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#826578}
-
Nina Satragno authored
Remove some code that was unused. Replace the single use of one of these classes by a hardcoded vector instead. Fixed: 1148047 Change-Id: I33d5ada65570f5802b6a7c6edae7bfc23ac52912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533420Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#826577}
-
danakj authored
We assumed that giving an image to decode would result in an N32 pixel format reply, but it seems not. So convert to N32 on receipt of the reply from the renderer. R=rsesek@chromium.org Bug: 1148012, 1144462 Change-Id: I7ae2924f6450cb4d0261d6780861f85bf5ed15a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533519Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#826576}
-
spdonghao authored
Add a Start surface check for ChromeTabbedActivity#prepareToShowStartPagePreNative. Bug: 1139055, 1140406 Change-Id: I351359fde6af17af4f9fbac05ea50f8a8bdd774c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528623Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
-
Kent Tamura authored
* Add MainThreadScrollingReasonsTest::GetScrollableArea() and RootScrollerTest::GetScrollableArea() to reduce the number of casts to LayoutBoxModelObject. This CL has no behavior changes. Bug: 891908 Change-Id: I10d52bff1b228d54f67b7585b0e6c8ff3ba7a51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531800 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826574}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I7dc6f19b6fa2d8bce6b6fffd1d411d74ec0f08f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533797Reviewed-by:
-
Tom Anderson authored
This is a reland of 2ed82a41 Original change's description: > Set Xlib error handler after GTK X11 initialization > > The default GTK error handler exits the process, which we don't want. > We used to reset the error handler at some point after GTK > initialization, but this became lost after r815319. > > Also refactor the XlibLoader instance to be global so it doesn't have > to be created multiple times for each connection. > > R=sky > > Bug: 1145929 > Change-Id: I73a3f27551534c2262bd8994d33e30fc2a0a4e27 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527743 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825585} Bug: 1145929 Change-Id: Ib65f3add91181b3bf82dd71f7b9b87a9a681a53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533199 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#826572}
-
Jesse Schettler authored
Sort the resolutions in descending order and correctly select the default option. Bug: 1059779 Change-Id: If971e961b8174aec7d538cd21ca5ef0eada0f2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533395Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#826571}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=bdea@chromium.org Bug: 1145565 Change-Id: I852404bcc8df54aaa7273fd69ec47b80b0b44235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533155 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#826570}
-
David Black authored
The holding space model may already be attached when the holding space tray is creating, such as if the user connects an external monitor after login. When this occurs, we need to make sure to handle the already attached model. Bug: 1148044, 1147261 Change-Id: I842555a7cc27fd5e0bcd256179c202298baf8e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533291 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Akihiro Ota authored
This change immediately shows a lesson if it is the only one in its curriculum. For example, if I'm on the main menu of the tutorial and choose 'Resources' (which only has one lesson), then we should show the lesson instead of the 'All lessons' page. This change also adds a test to confirm behavior and visibility of relevant buttons. This change is motivated by UXR feedback. Fixed: 1142051 AX-Relnotes: N/A Change-Id: Ie074a9e8597d4143edc9bee08ee1b6c03a15360d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527346 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#826568}
-
