Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 13 Jan, 2008 1 commit
  3. 12 Jan, 2008 21 commits
    • mrowe@apple.com's avatar
      2008-01-12 Rodney Dawes <dobey@wayofthemonkey.com> · d9b37e2b
      mrowe@apple.com authored 
              Gtk debug build fix.  Reviewed by Mark Rowe.

        Add plugin logging channel, and use it rather than Win32-specific debugging methods _RPTF1 _RPTF2 and _CRT_WARN.

        * WebCore.pro: Add plugins directory to DEPENDPATH so dependencies are correctly tracked.
        * platform/Logging.cpp:
        * platform/Logging.h:
        * plugins/PluginDebug.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@29442 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d9b37e2b
    • mitz@apple.com's avatar
      Update expected results for fast/replaced/image-map-expected after · bd8a3071
      mitz@apple.com authored 
              r29432 disabled document replacement by the JavaScript result in this
        case.

        * fast/replaced/image-map-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@29441 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bd8a3071
    • darin@apple.com's avatar
      - try to fix Qt Windows build · 55f602f2
      darin@apple.com authored 
              * pcre/dftables: Remove reliance on the list form of Perl pipes.



git-svn-id: svn://svn.chromium.org/blink/trunk@29440 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      55f602f2
    • darin@apple.com's avatar
      - try to fix Qt build · 443cad2b
      darin@apple.com authored 
              * kjs/function.cpp: Added include of scope_chain_mark.h.
        * kjs/scope_chain_mark.h: Added multiple-include guards.



git-svn-id: svn://svn.chromium.org/blink/trunk@29439 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      443cad2b
    • mrowe@apple.com's avatar
      Roll out r29435 as it introduces many, many crashes. · 531c5bd0
      mrowe@apple.com authored 
      
git-svn-id: svn://svn.chromium.org/blink/trunk@29438 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      531c5bd0
    • mrowe@apple.com's avatar
      2008-01-12 Mark Rowe <mrowe@apple.com> · 38edc147
      mrowe@apple.com authored 
              Another Windows build fix.

        * kjs/Activation.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@29437 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      38edc147
    • mrowe@apple.com's avatar
      2008-01-12 Mark Rowe <mrowe@apple.com> · 4fa33492
      mrowe@apple.com authored 
              Attempted Windows build fix.  Use struct consistently when forward-declaring
        ActivationStackNode and StackActivation.

        * kjs/Activation.h:
        * kjs/JSGlobalObject.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@29436 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4fa33492
    • mrowe@apple.com's avatar
      2008-01-12 Cameron Zwarich <cwzwarich@uwaterloo.ca> · 721e5c9d
      mrowe@apple.com authored 
              Reviewed by Mark Rowe.

        Fixes leaking of ActivationStackNode objects.

        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::deleteActivationStack):
        (KJS::JSGlobalObject::~JSGlobalObject):
        (KJS::JSGlobalObject::init):
        (KJS::JSGlobalObject::reset):
        * kjs/JSGlobalObject.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@29435 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      721e5c9d
    • zecke@webkit.org's avatar
      * Make launching of the WebKit httpd work on GNU/Debian/Linux · be6d1f57
      zecke@webkit.org authored 
      The configuration of Apache2 and installation does not depend on
the kernel but on the distribution policy. Make launching of httpd
work for Debian derived distributions.


git-svn-id: svn://svn.chromium.org/blink/trunk@29434 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      be6d1f57
    • mrowe@apple.com's avatar
      Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc. · 64712a0e
      mrowe@apple.com authored 
      Reviewed by Maciej Stachowiak.

* DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
match the callers expectations that it can take ownership of the string.


git-svn-id: svn://svn.chromium.org/blink/trunk@29433 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      64712a0e
    • mjs@apple.com's avatar
      Reviewed by Maciej (and also tweaked a little bit). · e2a1f9e5
      mjs@apple.com authored 
              - more thorough fix for some crashing tests
          http://bugs.webkit.org/show_bug.cgi?id=16782

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::urlSelected):
        (WebCore::FrameLoader::submitForm):
        (WebCore::FrameLoader::executeIfJavaScriptURL):
        * loader/FrameLoader.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@29432 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e2a1f9e5
    • mjs@apple.com's avatar
      Reviewed by Maciej. · 3637438d
      mjs@apple.com authored 
              Fixes a problem with the ActivationImp tear-off patch (r29425) where
        some of the calls to JSGlobalObject::tearOffActivation() were using
        the wrong test to determine whether it should leave a relic behind.

        * kjs/function.cpp:
        (KJS::FunctionImp::argumentsGetter):
        (KJS::ActivationImp::getOwnPropertySlot):



git-svn-id: svn://svn.chromium.org/blink/trunk@29431 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3637438d
    • mjs@apple.com's avatar
      Reviewed by Sam. · 3ae02ccd
      mjs@apple.com authored 
              - fixed <rdar://problem/5556374> REGRESSION: cross-domain error when one URL uses an explicit port number and another doesn't
        
        * platform/SecurityOrigin.cpp:
        (WebCore::isDefaultPortForProtocol):
        (WebCore::SecurityOrigin::SecurityOrigin):



git-svn-id: svn://svn.chromium.org/blink/trunk@29430 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3ae02ccd
    • alp@webkit.org's avatar
      2008-01-11 Alp Toker <alp@atoker.com> · 700c3e88
      alp@webkit.org authored 
              Reviewed by Oliver Hunt.

        Enable FastMalloc by default in GTK+/autotools and add a configure
        switch.

        * GNUmakefile.am:
        * configure.ac:


git-svn-id: svn://svn.chromium.org/blink/trunk@29429 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      700c3e88
    • ggaren@apple.com's avatar
      JavaScriptCore: · 012bdd59
      ggaren@apple.com authored 
              Reviewed by Oliver Hunt.
        
        Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
        variable access (16644)
        
        This bug was caused by var declarations shadowing built-in properties of
        the global object.
        
        To match Firefox, we've decided that var declarations will never shadow
        built-in properties of the global object or its prototypes. We used to
        behave more like IE, which allows shadowing, but walking that line got
        us into trouble with websites that sent us down the Firefox codepath.

        * kjs/JSVariableObject.h:
        (KJS::JSVariableObject::symbolTableGet): New code to support calling
        hasProperty before the variable object is fully initialized (so you
        can call it during initialization).

        * kjs/nodes.cpp:.
        (KJS::ProgramNode::initializeSymbolTable): Always do a full hasProperty
        check when looking for duplicates, not getDirect, since it only checks
        the property map, and not hasOwnProperty, since it doesn't check
        prototypes.
        (KJS::EvalNode::processDeclarations): ditto

        * kjs/property_slot.h:
        (KJS::PropertySlot::ungettableGetter): Best function name evar.

WebCore:

        Reviewed by Oliver Hunt.
        
        Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
        variable access (16644)
        
        Removed the ReadOnly bit from some properties, to match Firefox. Also
        removed status-related setters, to allow using their names as variable
        names.
        
        * bindings/scripts/CodeGeneratorJS.pm: Added support for properties that
        are one-way across domain boundaries, to match Firefox.

        * bindings/js/kjs_window.cpp: Changed ReadOnly declarations to match FF.

        * bindings/scripts/CodeGeneratorJS.pm: Don't use JSObject:: because
        we don't know that JSObject is our base class.

        * page/DOMWindow.idl: Replaced lots of readonly declarations with
        [Replaceable] declarations.

        * page/DOMWindow.h: Removed interfaces for setting status text via the
        DOM. (They were getting in the way of, e.g., "var status"
        declarations.) By default, IE 7 and FF disable these interfaces in order
        to defend against phishing attacks that try to spoof domain names in the
        statusbar.
        * page/DOMWindow.cpp:

LayoutTests:

        Reviewed by Oliver Hunt.
        
        Fixed <rdar://problem/5665251> REGRESSION (r28880-r28886): Global
        variable access (16644)
        
        Added a test. Updated other tests to match new behavior.
        
        * fast/js/var-declarations-shadowing-expected.txt: Added.
        * fast/js/var-declarations-shadowing.html: Added.

        * fast/dom/HTMLScriptElement/script-load-events.html: Changed this test
        a bit because the original design made it hard to understand why it was failing.
        * fast/dom/HTMLScriptElement/script-load-events-expected.txt:
        
        * fast/dom/Window/get-set-properties.html: Changed this test to expect
        our new behavior, which matches Firefox.
        * fast/dom/Window/get-set-properties-expected.txt:

        * fast/dom/Window/window-property-shadowing.html: Removed some cases
        that differed from Firefox. 
        * fast/dom/Window/window-property-shadowing-expected.txt: 

        * http/tests/security/cross-frame-access-put-expected.txt: This test emits
        more "Unsafe JavaScript attempt" messages now because property sets that
        used to be prohibited (somewhat accidentally) by the ReadOnly attribute
        are now prohibited by security checks.



git-svn-id: svn://svn.chromium.org/blink/trunk@29428 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      012bdd59
    • mitz@apple.com's avatar
      WebCore: · 4c626e47
      mitz@apple.com authored 
      2008-01-11  Anyang Ren  <anyang.ren@gmail.com>

        Reviewed by Darin Adler.

        http://bugs.webkit.org/show_bug.cgi?id=15960
        The view source mode should skip an empty attribute value only if
        the attribute name is not followed by an equal sign (=).

        Test: fast/frames/viewsource-empty-attribute-value.html

        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):

LayoutTests:

2008-01-11  Anyang Ren  <anyang.ren@gmail.com>

        Reviewed by Darin Adler.

        Add a new regression test for
        http://bugs.webkit.org/show_bug.cgi?id=15960
        The view source mode should skip an empty attribute value only if
        the attribute name is not followed by an equal sign (=).

        * fast/frames/resources/viewsource-frame-1.html: Added.
        * fast/frames/viewsource-empty-attribute-value-expected.txt: Added.
        * fast/frames/viewsource-empty-attribute-value.html: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@29427 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4c626e47
    • alp@webkit.org's avatar
      2008-01-11 Sylvain Pasche <sylvain.pasche@gmail.com> · d7f8e596
      alp@webkit.org authored 
              Reviewed by Alp Toker.

        [Gtk] Uneven glyph spacing with subpixel antialiasing
        http://bugs.webkit.org/show_bug.cgi?id=16715

        Use cairo font options from the default GDK screen when creating a
        scaled font.

        * platform/graphics/gtk/FontPlatformDataGtk.cpp:
        (WebCore::FontPlatformData::FontPlatformData):


git-svn-id: svn://svn.chromium.org/blink/trunk@29426 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d7f8e596
    • mjs@apple.com's avatar
      JavaScriptCore: · 2568663e
      mjs@apple.com authored 
              Reviewed by Maciej.

        Optimized ActivationImp allocation, so that activation records are now
        first allocated on an explicitly managed stack and only heap allocated
        when necessary. Roughly a 5% improvement on SunSpider, and a larger
        improvement on benchmarks that use more function calls.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/Activation.h: Added.
        (KJS::ActivationImp::ActivationData::ActivationData):
        (KJS::ActivationImp::ActivationImp):
        (KJS::ActivationImp::classInfo):
        (KJS::ActivationImp::isActivationObject):
        (KJS::ActivationImp::isOnStack):
        (KJS::ActivationImp::d):
        (KJS::StackActivation::StackActivation):
        * kjs/ExecState.cpp:
        (KJS::ExecState::ExecState):
        (KJS::ExecState::~ExecState):
        * kjs/ExecState.h:
        (KJS::ExecState::replaceScopeChainTop):
        (KJS::ExecState::setActivationObject):
        (KJS::ExecState::setLocalStorage):
        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::reset):
        (KJS::JSGlobalObject::pushActivation):
        (KJS::JSGlobalObject::checkActivationCount):
        (KJS::JSGlobalObject::popActivationHelper):
        (KJS::JSGlobalObject::popActivation):
        (KJS::JSGlobalObject::tearOffActivation):
        * kjs/JSGlobalObject.h:
        * kjs/JSVariableObject.h:
        (KJS::JSVariableObject::JSVariableObjectData::JSVariableObjectData):
        (KJS::JSVariableObject::JSVariableObject):
        * kjs/function.cpp:
        (KJS::FunctionImp::argumentsGetter):
        (KJS::ActivationImp::ActivationImp):
        (KJS::ActivationImp::~ActivationImp):
        (KJS::ActivationImp::init):
        (KJS::ActivationImp::getOwnPropertySlot):
        (KJS::ActivationImp::markHelper):
        (KJS::ActivationImp::mark):
        (KJS::ActivationImp::ActivationData::ActivationData):
        (KJS::GlobalFuncImp::callAsFunction):
        * kjs/function.h:
        * kjs/nodes.cpp:
        (KJS::PostIncResolveNode::evaluate):
        (KJS::PostDecResolveNode::evaluate):
        (KJS::PreIncResolveNode::evaluate):
        (KJS::PreDecResolveNode::evaluate):
        (KJS::ReadModifyResolveNode::evaluate):
        (KJS::AssignResolveNode::evaluate):
        (KJS::WithNode::execute):
        (KJS::TryNode::execute):
        (KJS::FunctionBodyNode::processDeclarations):
        (KJS::FuncExprNode::evaluate):
        * kjs/object.h:
        * kjs/scope_chain.h:
        (KJS::ScopeChain::replace):
        * kjs/scope_chain_mark.h: Added.
        (KJS::ScopeChain::mark):

WebCore:

        Reviewed by Maciej.

        Added a new forwarding header, because Activation.h has been separated
        from function.h

        * ForwardingHeaders/kjs/Activation.h: Added.

LayoutTests:

        Reviewed by Maciej.

        Added a test case that came up when developing the ActivationImp tear-off.

        * fast/js/resources/vardecl-preserve-arguments.js:
        * fast/js/vardecl-preserve-arguments-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@29425 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2568663e
    • justin.garcia@apple.com's avatar
      <rdar://problem/5541054> editing/pasteboard/paste-RTFD.html failing on Tiger · 868dab9a
      justin.garcia@apple.com authored 
              * editing/pasteboard/paste-RTFD.html: Mention the Tiger bug that this demonstrates.
        * platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.checksum: Added.
        * platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.png: Added.
        * platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt: Updated expected results
        to reflect the new info included in the test.
        * platform/mac/editing/pasteboard/paste-RTFD-expected.checksum: Ditto.
        * platform/mac/editing/pasteboard/paste-RTFD-expected.png:
        * platform/mac/editing/pasteboard/paste-RTFD-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@29424 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      868dab9a
    • alp@webkit.org's avatar
      2008-01-11 Luca Bruno <lethalman88@gmail.com> · a4dbb8d1
      alp@webkit.org authored 
              Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=16729
        [cURL] Allow multiple files for upload

        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::readCallback): added
        (WebCore::ResourceHandleManager::setupPOST): setup for streaming the POST
        (WebCore::ResourceHandleManager::startJob):
        (WebCore::ResourceHandleManager::cancel): revert the previous patch for regression
        * platform/network/curl/ResourceHandleManager.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@29423 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a4dbb8d1
    • alp@webkit.org's avatar
      2008-01-11 Christian Dywan <christian@imendio.com> · af168a37
      alp@webkit.org authored 
              Reviewed by Alp Toker.

        [Gtk] Menu items need underscores
        http://bugs.webkit.org/show_bug.cgi?id=16817

        Add underscores to appropriate menu labels.
        Also adjust strings slightly.

        * platform/gtk/ContextMenuItemGtk.cpp:
        (WebCore::ContextMenuItem::createNativeMenuItem):
        * platform/gtk/LocalizedStringsGtk.cpp:
        (WebCore::searchableIndexIntroduction):
        (WebCore::fileButtonChooseFileLabel):
        (WebCore::fileButtonNoFileSelectedLabel):
        (WebCore::contextMenuItemTagOpenLinkInNewWindow):
        (WebCore::contextMenuItemTagDownloadLinkToDisk):
        (WebCore::contextMenuItemTagCopyLinkToClipboard):
        (WebCore::contextMenuItemTagOpenImageInNewWindow):
        (WebCore::contextMenuItemTagDownloadImageToDisk):
        (WebCore::contextMenuItemTagCopyImageToClipboard):
        (WebCore::contextMenuItemTagOpenFrameInNewWindow):
        (WebCore::contextMenuItemTagCopy):
        (WebCore::contextMenuItemTagGoBack):
        (WebCore::contextMenuItemTagGoForward):
        (WebCore::contextMenuItemTagStop):
        (WebCore::contextMenuItemTagReload):
        (WebCore::contextMenuItemTagCut):
        (WebCore::contextMenuItemTagPaste):
        (WebCore::contextMenuItemTagIgnoreSpelling):
        (WebCore::contextMenuItemTagLearnSpelling):
        (WebCore::contextMenuItemTagSearchWeb):
        (WebCore::contextMenuItemTagLookUpInDictionary):
        (WebCore::contextMenuItemTagOpenLink):
        (WebCore::contextMenuItemTagIgnoreGrammar):
        (WebCore::contextMenuItemTagSpellingMenu):
        (WebCore::contextMenuItemTagShowSpellingPanel):
        (WebCore::contextMenuItemTagCheckSpelling):
        (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
        (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
        (WebCore::contextMenuItemTagFontMenu):
        (WebCore::contextMenuItemTagBold):
        (WebCore::contextMenuItemTagItalic):
        (WebCore::contextMenuItemTagUnderline):
        (WebCore::contextMenuItemTagOutline):
        (WebCore::contextMenuItemTagWritingDirectionMenu):
        (WebCore::contextMenuItemTagDefaultDirection):
        (WebCore::contextMenuItemTagLeftToRight):
        (WebCore::contextMenuItemTagRightToLeft):
        (WebCore::contextMenuItemTagInspectElement):
        (WebCore::searchMenuClearRecentSearchesText):


git-svn-id: svn://svn.chromium.org/blink/trunk@29422 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      af168a37
  5. 11 Jan, 2008 18 commits