- 13 Sep, 2017 40 commits
-
-
Brett Wilson authored
Writes separate sections of allocator types for the OOP memory log. Sone refactoring in support of this. Adds tests for allocator splits and context information. Bug: 763173 Change-Id: I81aeae226075b221d5b0b944fe74980557ffce32 Reviewed-on: https://chromium-review.googlesource.com/664083 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501674}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/f2ca50ffa2d2..06c6855258bf $ git log f2ca50ffa..06c685525 --date=short --no-merges --format='%ad %ae %s' 2017-09-13 rharrison Rewrite IsHyphen using string operations Created with: roll-dep src/third_party/pdfium BUG=763256 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I95fd0446d3109077c44e88ad4326d5f0641ab9f6 Reviewed-on: https://chromium-review.googlesource.com/665257 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501673}
-
Gustav Sennton authored
AwVariationsConfigurationService uses JobScheduler.getPendingJob to check whether a specific job is pending. This method was introduced in Android version 24, but WebView supports version 21+, so replace the use of JobScheduler.getPendingJob with JobScheduler.getAllPendingJobs instead. Bug: 762607 Change-Id: Ia05815e73690ec0deff78d8d78b04d63376ec255 Reviewed-on: https://chromium-review.googlesource.com/664722 Commit-Queue: Gustav Sennton <gsennton@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#501672}
-
Andrey Kraynov authored
Without this |operator=(U&& value)| was never considered by the compiler, and assignment with rvalue leads to the following sequence: |Optional(T&& value)| -> |operator=(Optional&& other)| This patch eliminates unnecessary move ctor call for Optional and its value type. Add very simple test to demonstrate the problem. Bug: Change-Id: I6816c62c22b8016402a00d3c15afc4f07eaf2ef4 Reviewed-on: https://chromium-review.googlesource.com/663383Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#501671}
-
David Tseng authored
Given <div id="outer"> <span id="inner"></span> </div> and an event listener gets added on outer, all programmatic clicks, from the perspective of the page, have their event targets set to outer even if the client triggering the click action clicks the inner node. This is because we check AXNodeObject::IsClickable and Node::IsElementNode, both restrictions seem to break various assumptions by page authors. When those checks fail, we simply get the ancestor that is clickable (or an anchor), so click targets are always the ones with click event listeners. Unfortunately, this is not useful for page authors that want to add an event listener for a collection of nodes in a subtree. Bug: Change-Id: I43a28b265d5af6ea664c4d5fd5528763b78b499e Reviewed-on: https://chromium-review.googlesource.com/663214 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#501670}
-
Stepan Khapugin authored
Moves files from ios/shared/chrome/browser/ui/omnibox to ios/c/b/ui/omnibox. Renames ios/c/b/ui/omnibox:omnibox to ios/c/b/ui/omnibox:omnibox_utils. Bug: Change-Id: Ice67095eddfbe00f11af71bebe5f0d3c0255fe97 Reviewed-on: https://chromium-review.googlesource.com/654840Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501669}
-
Ehsan Chiniforooshan authored
memory_instrumentation::Coordinator is exposed by the browser service right now, which was a temporary solution before the resource_coordinator service was created. This CL moves it to the resource_coordinator service. Also, this CL exposes the tracing service, too. Later it will be used instead of the tracing controller that lives in the browser. Moving memory instrumentation and tracing to the resource_coordinator service will let the service manager to register all "service" processes to report memory usage and trace data. This is not possible if memory instrumentation and tracing live in content_browser since it will be a layering violation to have a dependency from //services/service_manager to content. BUG=687020,640235,733165 Change-Id: I7ea9e61430f4406fd115abd747b35a806a392469 Reviewed-on: https://chromium-review.googlesource.com/628658Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#501668}
-
Sylvain Defresne authored
This reverts commit 13de3702. Reason for revert: breaks '-[ExternalURLSigninTestCase testSignInReauthenticate]' EarlGrey test. Original change's description: > Fix restoration of session after a crash. > > Disable sending kTabModelNewTabWillOpenNotification notification > when the TabModel is restoring a session as this breaks the BVC > state that does not expect the notification to be sent when a tab > is added due to session restoration. > > Bug: 763964 > Change-Id: I404487b5a561e43fe4d23303c004e4d3e8701dfe > Reviewed-on: https://chromium-review.googlesource.com/664557 > Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501614} TBR=rohitrao@chromium.org,sdefresne@chromium.org Change-Id: I917e129b14d351bf66527a6620c4f67f97eaa8aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 763964 Reviewed-on: https://chromium-review.googlesource.com/664706Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#501667}
-
Philippe Hamel authored
Enable Ranker Enforcement by default for all platforms except Android and Ranker Query for all platforms. Bug: 646711 Change-Id: I87b114cd31829f2357b3e5fdce17a316c2f50312 Reviewed-on: https://chromium-review.googlesource.com/661388Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Philippe Hamel <hamelphi@chromium.org> Cr-Commit-Position: refs/heads/master@{#501666}
-
Eugene But authored
Metric and corresponding DCHECK was added to understand if WebStateImpl::GetCurrentURL() calls can safely be replaced with GetLastCommittedURL(). There are cases when these 2 URLs (current, last committed) get out of sync, however it's not an issue as long as both URLs have the same origin. This CL relaxes DCHECK and metric to flag the URL difference only if the origins of these 2 URLs (current, last committed) are different. Bug: 759943 Change-Id: I9f866e5d76253dece43fde55529e1b0633d4e09c Reviewed-on: https://chromium-review.googlesource.com/660693 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501665}
-
Xing Liu authored
This CL moves some download http response header handling logic from download_request_core.cc to the new class used by the new mojo url loader data pipe. Bug: 715630 Change-Id: I90d0618140009a047d7119d17bd2b0cf8d5329d7 Reviewed-on: https://chromium-review.googlesource.com/661145 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#501664}
-
Eugene But authored
The test were failing because the page did not finish layout after the load. Grabbing an HTML element forces layout and makes page prepared for the testing. Bug: 758735 Change-Id: I649d9b60eb5cfa41b361016402407afb2cf60d2f Reviewed-on: https://chromium-review.googlesource.com/664417Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#501663}
-
Greg Kraynov authored
Heap profiling may be requested to get enabled in stages when TraceLog is not created yet. Since TraceLog calls other MDM's lock-protected methods it can cause a deadlock. Bug: 764357 Change-Id: Ica08b4478aa09e03a3fa0761ec8ed787b1922cb6 Reviewed-on: https://chromium-review.googlesource.com/663722Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Grigoriy Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#501662}
-
Miguel Casas-Sanchez authored
This CL enables Mojo VEA by default for CrOs, which is the last platform supporting it that needed to be enabled; no downstream bots have regressed and the RTC UMA did not show changes, so let's follow up with this one. FTR the UMA [1] is one of those I'm monitoring, in particular the failure rate should not spike. [1] https://uma.googleplex.com/timeline_v2?sid=0d2de736ea34e1d0330a2d17cfe7e42f Bug: 736517 Change-Id: Icc84a2b603032158660ad677c6ce80045452fc10 Reviewed-on: https://chromium-review.googlesource.com/663997Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#501661}
-
Charlie Andrews authored
This is part of a larger migration described here: http://bit.ly/2jr4bIn Bug: 667892, 761498 Change-Id: I459de60aedc4ad6bd1cf08177690229644eb1037 Reviewed-on: https://chromium-review.googlesource.com/665164Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#501660}
-
Matt Menke authored
RenderFrameHostImplBrowserTest.AbortedRendererInitiatedNavigationDoNotCancelPendingXHR is now failing, possibly due to https://chromium-review.googlesource.com/663140 TBR: jam@chromium.org NOTRY: true Bug: 576261,762945 Change-Id: Ib9a8893e105444be13653438c6bd364511dcfad7 Reviewed-on: https://chromium-review.googlesource.com/665070Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#501659}
-
Helen Li authored
SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. This CL removes src/net/sdch. histograms will be deprecated in a separate CL. net/ TBR=rdsmith@chromium.org ios/chrome/browser TBR=sdefresne@chromium.org Bug: 762686 Change-Id: Iea2e894c99303912b5f09b5708f9f32dea6bd325 Reviewed-on: https://chromium-review.googlesource.com/664979Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#501658}
-
Brian Osman authored
Bug: 763605 Change-Id: I3e4c7fb40fe2e9dccdf0ba7549199466c785c605 Reviewed-on: https://chromium-review.googlesource.com/664983Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#501657}
-
Carlos IL authored
Websites with Security errors due to SHA1 signed certificates in the chain now show up with the broken (red triangle) indicator in the DevTools Security panel, instead of the neutral (red circle) indicator. R=estark@chromium.org Bug: 705671 Change-Id: I400936a3221ddeea65897a83f4ad04e6683e2d22 Reviewed-on: https://chromium-review.googlesource.com/664343Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Carlos Joan Rafael Ibarra Lopez <carlosil@google.com> Cr-Commit-Position: refs/heads/master@{#501656}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/596aa47eec50..c562de2ba25b $ git log 596aa47ee..c562de2ba --date=short --no-merges --format='%ad %ae %s' 2017-09-13 loloangela Fix errors related to invalid-name pt. 11 Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I135d77739b4f88756a56fb86447fc048f01fd7c9 Reviewed-on: https://chromium-review.googlesource.com/664820 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501655}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bbfd15c4..5bd1496e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Iada9cfd9e871e7747ed10aa56e8e6f26439f4694 Reviewed-on: https://chromium-review.googlesource.com/664842Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#501654}
-
Simon authored
For perf try jobs, you must specify --output-format=html in order to produce an HTML results file that can be displayed on the build page. This CL adds the flag if no --output-format is specified, or if none of the existing formats is html. Bug: chromium:762570 Change-Id: I5e39937faa64fa7d6bfb2a643e22eac426ff17b1 Reviewed-on: https://chromium-review.googlesource.com/661056Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#501653}
-
Matt Menke authored
These likely broke in https://chromium-review.googlesource.com/662957 TBR: nhiroki@chromium.org NOTRY: true Bug: 748415 Change-Id: Ied4e2131b72e8dc004a7ac695d35a86e2acf8a1b Reviewed-on: https://chromium-review.googlesource.com/664845Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#501652}
-
Helen Li authored
top_25_009.wprgo is of the legacy format. This causes WprGo server to error out when trying to unzip the archive. See attached bug for more detail. I converted to the new .wprgo format using tools/perf/convert_legacy_wpr_archive. Bug: 763466 Change-Id: I32b37852147b6cf70c0ded34906b08988d2fd455 Reviewed-on: https://chromium-review.googlesource.com/665061Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#501651}
-
Ria Jiang authored
After https://chromium-review.googlesource.com/c/chromium/src/+/617378, ClientWindowId is globally unique, so we can change FrameSinkId to have the value of the corresponding ClientWindowId. This also means that clients now know about their FrameSinkId. Changed ClientWindowId to be of type FrameSinkId to essentially merge these two ids in mus-ws. Updated uses of FrameSinkId in WindowManagerState and unittests. Fixed some more places in WindowTree that needed ClientWindowId conversions. Bug: 712302 Test: covered by tests Change-Id: I3a77487b7e10af5ba1850f2585b81f43768f2184 Reviewed-on: https://chromium-review.googlesource.com/639954 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#501650}
-
Matt Menke authored
They now seem to be timing out, issue likely caused by https://chromium-review.googlesource.com/657183 Bug: 763252 Change-Id: I6bee917df1995f4a4d176339485ad9e64577f977 TBR=rdsmith@chromium.org NOTRY=true Change-Id: I6bee917df1995f4a4d176339485ad9e64577f977 Reviewed-on: https://chromium-review.googlesource.com/665069Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#501649}
-
Tarun Bansal authored
This is a pure refactor CL and does not introduce any functionality change. Moving some of the code that retrieves memory information to t_p/Webkit/common makes it possible to access that code from chrome/browser. In the next CL, chrome/browser/chrome_content_browser_client.cc would call GetApproximatedDeviceMemory() to attach the required client hints to the navigation requests. Bug: 764513 Change-Id: I96e5d812b8f46e83601d02c6c48f1a37919f8041 Reviewed-on: https://chromium-review.googlesource.com/663768Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#501648}
-
Marti Wong authored
- Disable Select button of context bar when there is nothing to select. - Disable New Folder button of context bar when current root node is nil (removed remotely). - Added egtest to verify that when current root node is empty, the empty background appears and select button is disabled. Demo: https://drive.google.com/open?id=0B1O0Z7eoZMuGR2lZcGlvSUg4VjQ Bug: 695749 Change-Id: Iba6bf2e2d4e4260cc8d712d7e25e6417f8dc0455 Reviewed-on: https://chromium-review.googlesource.com/663501 Commit-Queue: Marti Wong <martiw@chromium.org> Reviewed-by:
Ramya Sharma <ramyasharma@chromium.org> Cr-Commit-Position: refs/heads/master@{#501647}
-
Charlie Andrews authored
Bug: 705042 Change-Id: Iec0fe8718b3a0510bb73d2e20efa4c732b539940 Reviewed-on: https://chromium-review.googlesource.com/665098Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#501646}
-
Andrew Grieve authored
Applicable only when building release. Disable via --no-deobfuscate Bug: 620323, 758670 Change-Id: Ib1289e6eae6bb326a1879c791e673cdeba331eab Reviewed-on: https://chromium-review.googlesource.com/656720Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#501645}
-
Brett Wilson authored
Failing to explicitly initialize stack dumping before adding a malloc hook that uses it can cause problems. In particular, on Linux calling backtrace() can load a library which calls malloc, meaning the hook will be recursive. Bug: 764522 Change-Id: If602902aa4238903541ca52f765927369dbf6e71 Reviewed-on: https://chromium-review.googlesource.com/664301Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501644}
-
Simeon Anfinrud authored
This can be used to make sure that tasks are being flushed through a given task runner at a desired rate, a signal that can be used to determine if tasks are blocking a thread. BUG=Internal b/23908801 BUG=Internal b/36699101 TEST=cast_base_unittests Change-Id: I22dc48134ac46b2bd00bccee8105a7580d1072c9 Reviewed-on: https://chromium-review.googlesource.com/664086 Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#501643}
-
Rob Buis authored
Support unset as a CSS wide keyword [1] and add some unit tests for it. [1] https://www.w3.org/TR/css3-values/#common-keywords Bug: 660273 Change-Id: Ic739055b83988017e11ff3968c1a0aad48073613 Reviewed-on: https://chromium-review.googlesource.com/663820 Commit-Queue: Rob Buis <rob.buis@samsung.com> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#501642}
-
sczs authored
This CL implements the Sad Tab functionality for the new architecture. -Adds a delegate setter to SadTab helper since the helper needs to outlive the Webstate. Since the delegate could previously only be set on init. This meant that the delegate had to persist until Webstate destruction, which is not ideal since we don't want the delegate to be a coordinator close to root. For this reason the helper is created as soon as a Webstate is Added and its delegate is added when the Tab is being displayed. Screenshot: https://drive.google.com/open?id=0Byo6-Nuda2jgeHZhbFBYQTl6Qnc Bug: Change-Id: I42c3c6710233b2148cc3bb696e0017db9c3c205f Reviewed-on: https://chromium-review.googlesource.com/656518Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#501641}
-
Ira Burak authored
Manually add MAJOR_BRANCH_DATE for M63. For the later versions, this file will be generated automatically. MAJOR_BRANCH_DATE file contains a date of the last major branch. This date will be used as a base date to compare expiry dates of histograms with. Bug: 753485 Change-Id: I2c336df168376c3ac909c877b5b938dad96a4347 Reviewed-on: https://chromium-review.googlesource.com/661068Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ira Burak <iburak@google.com> Cr-Commit-Position: refs/heads/master@{#501640}
-
Peter Kotwicz authored
BUG=None Change-Id: Ibae21432198d287ea3fac8656335232765f5dee8 Reviewed-on: https://chromium-review.googlesource.com/663243Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#501639}
-
Jean-François Geyelin authored
Bug: 764692 Change-Id: I3e2493f770e8218aa9a5eb0351dfc0db0612832d Reviewed-on: https://chromium-review.googlesource.com/664809 Commit-Queue: Jean-François Geyelin <jif@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#501638}
-
Koji Ishii authored
Following bot results are included. 1281 1282 1283 1284 1285 1286 1287 1291 1293 1294 1299 1300 1302 1303 1304 1305 85 lines were removed by consecutive passes since 1248. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: I479d8f2513097eea14cd12eb8e4188b14b1c8bde Reviewed-on: https://chromium-review.googlesource.com/665197 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#501637}
-
Ria Jiang authored
In the viz-hit-test case, when we cannot find the target window in EventTargeter, we were using NOTREACHED before this CL. But there are cases where the target window has simply been deleted by the time this event is processed, e.g. clicking the settings button inside system tray's network page, mouse move events after that but before the system tray goes away would fail. In these cases, it makes sense to just drop the event like we did in non-viz hit-test. Kept the TODO to investigate if it can be a security fault when no target window is found. Also fixes a memory exception in HTQ when using the transform directly. Bug: 752380 Change-Id: Ifa099c88a98d623b8be363fe3a77b7bc8eea4a54 Reviewed-on: https://chromium-review.googlesource.com/651564 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#501636}
-
Peter Beverloo authored
This fixes a crash that's observed on certain Android M devices. BUG=761060 Change-Id: Ibef9110eda33238cb2db2f0084320d3ea83fdab8 Reviewed-on: https://chromium-review.googlesource.com/663363Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#501635}
-