- 20 Jan, 2021 40 commits
-
-
James Cook authored
It should be "_mojom_traits" not ".mojom_traits". The latter does not match any files. Bug: None Change-Id: I039826848ad264a9437a22ec6bd314cc37aec67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639397 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#845156}
-
Vincent Boisselle authored
The NTP feed-related tests are in FeedV2NewTabPageTest, which has its own control functions. Bug: 1167893, 1091640 Change-Id: I9498d1ce753d0a95ed357ea9f5f707022df8ad29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635346Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#845155}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611122392-3fa54c599d014435b3d566bb93ac7e4c3fcf93dd.profdata to chrome-linux-master-1611142151-f3b642624b7e7391f296111a04b779942697c546.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I712a8b82dfa1ed0766f2ac68280d8f056845ef1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640275Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845154}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611122392-e8f247e0fcfff108ca1c2d87a3238278081efa89.profdata to chrome-win32-master-1611132884-698d50ded477bbf68b51ffca48f766bfc0d51fdd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib28c68c846530c61c04a843ce5a434c8c27c9c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639299Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845153}
-
Alice Wang authored
This CL cleans up the parameter SigninFirstRunFragment.FORCE_SIGNIN_ACCOUNT_TO used for FRE with child account, since this parameter is available in SigninFirstRunFragment, we don't need to save it in bundle and pass it down to the fragment. Bug: 1045473 Change-Id: I6b783f30630885d37d4aa8656307cd85d19554a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628297 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#845152}
-
Wez authored
Bug: 1162433 Change-Id: I7b40969219f46c39b3be550724f53b2e544f4d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640493 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#845151}
-
Sebastien Marchand authored
Bug: 1168512 Change-Id: I312ad1f704621be356202b83273317f41d386986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639807 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#845150}
-
Alice Wang authored
This CL moves the method openAccountPickerBottomSheet() from SigninUtils to SigninBridge to facilitate modularization. Bug: 1165772 Change-Id: Ifc47512cdb0c8b680e16a4fedd49c010a25a7359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631491 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845149}
-
Christian Dullweber authored
Also remove obsolete feature. Bug: 1146211 Change-Id: Ia99d008c78adc374c563b27d75147d62ff07554d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632960 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#845148}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a709974a868b..540f809f11e2 2021-01-20 aerotwist@chromium.org [boot perf] Fix value sorting 2021-01-20 tvanderlippe@chromium.org Empty several modules keys in module.json files 2021-01-20 bmeurer@chromium.org [cleanup] Remove unnecessary Promise.resolve()s in DebuggerModel.js 2021-01-20 sadym@chromium.org Respect DeviceScaleFactor in fullscreen screenshots If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1131500,chromium:1161501,chromium:1164757 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I08f677f466789a34cc4d0cf5062d30dbebf5f598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640274Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845147}
-
Andy Paicu authored
This reverts commit f3c62799. Reason for revert: Final PS did not make it in Original change's description: > Reland "Disconnect bluetooth device when the user revokes permission" > > This is a reland of 6ef36937 > > Original CL broke the build: > https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/b8861845414785298224 > > Original change's description: > > Disconnect bluetooth device when the user revokes permission > > > > Bug: 1128494 > > Change-Id: I394e97f61268869557df5c64017504745a8fcd71 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412331 > > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#833671} > > Bug: 1128494 > Change-Id: I4480bb33f2df1ad9e9302ec94b27da9195170373 > Fixed: 1155527 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573102 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845142} TBR=reillyg@chromium.org,alexmos@chromium.org,jochen@chromium.org,andypaicu@chromium.org,dougt@chromium.org,odejesush@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ib2147c7d4f76207ae1a6119496cc5e327db6478c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1128494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640613Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845146}
-
Anatoliy Potapchuk authored
Previously, we were never allowing guest users to configure global display settings, but since it became common to have cases where we have one single user always using managed guest session, we decided them to be able to configure device-wide display setting. Bug: 1166412, b/150002447 Change-Id: I09a372dd9878a01cb9d2f99f52e6e9e85d822b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628288 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#845145}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I4aaefe4249b157582bf59d0b6e051c3fd9a2059a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640163Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845144}
-
Owen Min authored
Add getter function of PolicyCache that reads from the SharedPreferences https://source.chromium.org/chromium/chromium/src/+/master:components/policy/core/common/policy_service_impl.cc;l=146?q=IDS_POLICY_MIGRATED_NEW_POLICY&ss=chromium%2Fchromium%2Fsrc Bug: 1127469 Change-Id: If6f8103e55625439a0607e358449ffddfe2949cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633927 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#845143}
-
Andy Paicu authored
This is a reland of 6ef36937 Original CL broke the build: https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/b8861845414785298224 Original change's description: > Disconnect bluetooth device when the user revokes permission > > Bug: 1128494 > Change-Id: I394e97f61268869557df5c64017504745a8fcd71 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412331 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833671} Bug: 1128494 Change-Id: I4480bb33f2df1ad9e9302ec94b27da9195170373 Fixed: 1155527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573102Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845142}
-
Aaron Leventhal authored
R=aboxhall@chromium.org Bug: 1167269 Change-Id: I5bb0f5fac139dcf16631482e4a21a85e41bd92c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636892 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#845141}
-
David Van Cleve authored
This change adds a space where one was missing. Bug: None Change-Id: I310ac3ec640a3d289db5a540db2959ede646bf2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638371 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#845140}
-
Sébastien Marchand authored
This reverts commit 7ec49ce5. Reason for revert: Causes deps failures, see crbug.com/1168512 Original change's description: > Delete //c/b/profiles/DEPS > > Per http://crrev.com/c/2542933/10/chrome/browser/profiles/DEPS#5 > This DEPS file had just one include rule, which explicitly allowed a > single include in a file with ~200 includes. Seems odd and not useful. > > Change-Id: Ic655d0c446671703f119223e47b6f8d54ae9a512 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636820 > Auto-Submit: Glen Robertson <glenrob@chromium.org> > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845114} TBR=droger@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,glenrob@chromium.org Change-Id: Iec68e19770867d63c707cb37800938833f819fa0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639806Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#845139}
-
chrome://policyIgor Ruvinov authored
To future-proof adding status messages to policies, the existing statuses (`AddError`, `AddWarning`) are combined into a single generic status method `AddMessage` which accepts the type of status message as an argument. This simplifies addition of new statuses, such as the status "Info" which will be used in a following CL. Bug: 1104043 Change-Id: I09196dc98ac78bc8c29131e303a68304069aa6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625895 Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#845138}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611089910-6a1c1563417281aed9ef8f312b971a0aa6f126b5.profdata to chrome-win32-master-1611122392-e8f247e0fcfff108ca1c2d87a3238278081efa89.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibac40abcf3f438326b866614a902eb4672d0bc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640158Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845137}
-
Mirko Bonadei authored
This reverts commit 22e354b4. Reason for revert: usrsctp has rolled again so this can be relanded. Original change's description: > Revert "Add fuzzer targets for usrsctp." > > This reverts commit 36efcfc8. > > Reason for revert: Need to revert this in order to revert the last > usrsctp update: https://chromium-review.googlesource.com/c/chromium/src/+/2586379 > > Original change's description: > > Add fuzzer targets for usrsctp. > > > > Bug: chromium:1025302 > > Change-Id: Iadbcb87f0f3f3a1845e925aed8f52685d78e740e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108066 > > Reviewed-by: Harald Alvestrand <hta@chromium.org> > > Reviewed-by: Florent Castelli <orphis@chromium.org> > > Commit-Queue: Taylor <deadbeef@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#816872} > > TBR=hta@chromium.org,deadbeef@chromium.org,orphis@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: chromium:1025302 > Change-Id: Ib984dc975c5802ad52d07b96d91e8fb1367bc4ae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586282 > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Commit-Queue: Taylor <deadbeef@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836877} TBR=hta@chromium.org,deadbeef@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1025302 Change-Id: I6c07d1b0bbbb3be404f1c0f3370e39fa854055bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611102Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#845136}
-
Aaron Leventhal authored
This fix ensures that detached objects are never considered as included in the tree. Explanation: Sometimes a node is detached in the middle of the tree. For example, this can occur when a combobox popup closes its popup. Currently, when a node is detached in the middle of the tree, the parent hierarchy may not be immediately repaired, to skip over the old detached object, which can cause anything using ParentObjectIncludedInTree() to reach a detached object, which is not actually included in the tree. Normally the parent hierarchy will be repaired the next time the detached object's parent's children are requested. An alternate fix would be to, immediately when a node is detached, ensure that the parent hierarchy is always repaired when nodes are detached in the middle of the hierarchy. However, care would need to be taken to avoid extra work when an entire document or subtree is being removed. Bug: 1167459 Change-Id: If374617f451992c1f68607dc9b3c56bc0f0908c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638395Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#845135}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4384.0-1610966529-benchmark-89.0.4389.6-r1 to 89-4384.0-1610966529-benchmark-89.0.4389.9-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iba49ec1e1e15de947e10b8c46bfd1f8c29016e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640153Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845134}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4384.0-1610969724-benchmark-89.0.4389.6-r1 to 89-4384.0-1610969724-benchmark-89.0.4389.9-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I6969d6363534279ac14ded7e7a39eadfed6dc7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640156Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845133}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bef6dfb3738f..6f24f9c44a65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC cfroussios@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: cfroussios@google.com Change-Id: If76560deb6294ac492d43e92abe370cb16168c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639921Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845132}
-
Mohamed Amir Yosef authored
This CL checks the kAutofillAddressProfileSavePrompt feature in AddressProfileSaveManager::SaveProfile() If the feature is disabled, it invokes the personal data manager directly. (No behavioral change) If the feature is enabled, it invokes the autofill client method that opens the save prompt. Bug: 1135178 Change-Id: I36fa5ec8d45d88a27d66d89c17f12f09f7bcc2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631500 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#845131}
-
Rainhard Findling authored
Bug: 1152336 Change-Id: I3ac333ff8fd31838c270dd5e0814c4c017850e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639758Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#845130}
-
Henrique Ferreiro authored
This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1164001 Change-Id: I8888525c62b18ebf6c3e3dc12cfa00dd340dc41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637496Reviewed-by:
James Cook <jamescook@chromium.org> Owners-Override: James Cook <jamescook@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#845129}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d2f4b461e4a3..a709974a868b 2021-01-20 sigurds@chromium.org Record schemes of developer resources via UMA 2021-01-20 janscheffler@chromium.org [JSDOC2TS]: Migrate media 2021-01-20 sigurds@chromium.org Update link for SAB usage 2021-01-20 kimanh@chromium.org [LMI] Rename 'Inspect memory' to 'Reveal in Memory Inspector panel' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1051466,chromium:1069378,chromium:1158760 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If4a102e437535dbe2c84b989e43ab06ca669a4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639297Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845128}
-
Noel Gordon authored
Bug: 1144419 Change-Id: Ie2872cea95965d15e38dc319897d315f02f9b4b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635383 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#845127}
-
Alice Wang authored
This CL refreshes SigninFragment UI only for target account update in ProfileDataCache. Prior to this CL, SigninFragment UI is refreshed for all account updates in ProfileDataCache. Bug: 1167672 Change-Id: I396eb4a9cccdadf2f5786f3ec5ee7184bf3ac528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635144Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#845126}
-
Monica Basta authored
This CL adds a tooltip for the local profile name as well as the gaia name on the profile card on picker main view. The CL for the local profile name is disabled if an inline profile name editing is in progress for this card. Fixed: 1168173 Change-Id: Id5e028e0decfbf6c0a368b6a0ab78ba82bec0af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637518Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#845125}
-
Mirko Bonadei authored
https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/4191ca1784d8..07f871bda239 $ git log 4191ca178..07f871bda --date=short --no-merges --format='%ad %ae %s' 2021-01-13 vitaly Unified version and soversion between all supported build systems. (#565) 2021-01-13 tuexen Whitespace changes. 2021-01-10 tuexen Restore file removed by accident 2021-01-10 tuexen Bump version. 2021-01-08 deadbeef Add __declspec(noreturn) to terminate_non_graceful() on Windows (#563) Created with: roll-dep src/third_party/usrsctp/usrsctplib Bug: None Change-Id: I977ede12bd294668b1846da3cf9fc81b1c2be76b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637516Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#845124}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5eb527cf7fb2..6dcbcead3da4 2021-01-20 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-20T04:04:26). 2021-01-19 tommi@webrtc.org Call MediaChannel::OnPacketReceived on the network thread. 2021-01-19 natim@webrtc.org ChannelStatistics RTT test case around remote SSRC change. 2021-01-19 asapersson@webrtc.org AlignmentAdjuster: take reduced layers into account for default downscaling. 2021-01-19 gustaf@webrtc.org Switch to enable the HMM transparent mode classifier 2021-01-19 lndmrk@webrtc.org Signal extmap-allow-mixed by default on session level 2021-01-19 tommi@webrtc.org Remove lock from UlpfecReceiverImpl and replace with a sequence checker. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1155071,chromium:1155477 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia91e5ee9682c66b260657f8a6e27529367428bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639568Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845123}
-
Harald Alvestrand authored
Ensure that even if the set of DTLS transports is modified during callbacks called from close, the process will be well-defined. Bug: chromium:1167357 Change-Id: I712280e7382a647027912178156127831b437f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639893Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#845122}
-
Olesia Marukhno authored
Change-Id: If80df7991f4499fd913787db66da5121f0900d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587019 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#845121}
-
Jan Wilken Dörrie authored
Following r841439 this change moves the logging of UTF16 strings from base/strings/string16.h to base/logging.h. Since base::string16 is now just a typedef for either std::u16string or std::wstring it is no longer associated with the base namespace, and thus its operator<< need to live in namespace std, so that it is found by ADL. TBR=dcheng Bug: 911896 Change-Id: I2f84da1ac084ec8440e671dd14d5aa9c30d98c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632693 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#845120}
-
Christos Froussios authored
This reverts commit 38aeef20. Reason for revert: The following tests have been failing consistently since this CL on Mac10.15 Tests All/SystemWebAppLaunchDuringShutdownBrowserTest.DontLaunchDuringShutdown/_WebAppInfoInstall All/SystemWebAppLaunchDuringShutdownBrowserTest.DontLaunchDuringShutdown/_Default e.g. https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/7628/overview Original change's description: > Reland "system-web-apps: implements a new LaunchSystemWebAppAsync API" > > This is a reland of 62cb2352 > > The original CL fails when AppBrowserControllerBrowserTest.Shutdown > passed a destroyed to LaunchSWAImpl. The reland removes this DCHECK > because the use of GetCreationStatusForProfile already makes sure the > DCHECK is always successful. > > Original change's description: > > system-web-apps: implements a new LaunchSystemWebAppAsync API > > > > This CL implements a new LaunchSystemWebAppAsync API, which is for other > > chrome components to launch a SWA safely. This new API should be used > > for SWA launches. > > > > The new API uses AppService to record metrics, handle disabled apps, > > etc. > > > > The old LaunchSWA is deprecated (its logic now becomes LaunchSWAImpl). > > > > LaunchSWAImpl is publicly declared because certain browser tests need to > > know the browser that hosts the SWA. It shouldn't be used to launch the > > App (other than LaunchSWA and Web app implementations). Subsequent CLs > > will attempt to migrate these browsertests to work with the new API. > > > > Bug: 1154540 > > Change-Id: I648a3b0404067ba460f0174e975fae44b3a0001a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592270 > > Reviewed-by: James Cook <jamescook@chromium.org> > > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Commit-Queue: Jiewei Qian <qjw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#843939} > > Bug: 1154540 > Change-Id: Ice207ac03834452223c5bb2ef880c6667e6cb25b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633485 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Auto-Submit: Jiewei Qian <qjw@chromium.org> > Commit-Queue: Jiewei Qian <qjw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845049} TBR=jamescook@chromium.org,sky@chromium.org,ortuno@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,nancylingwang@chromium.org,qjw@chromium.org,dominicschulz@google.com Change-Id: I5c77c3f9372fbfa03d361a190ce2b35028930ec8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1154540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640053Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#845119}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I35f61d283634a77e4b6fbb90dac1c696a3d94d41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639355Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845118}
-
Olivier Robin authored
It is possible that the committed URL is still the placeholder URL in case of a restoration of when loading an offline page. In that case, the domain check must extract the real URL from the placeholder. Bug: 1067733 Change-Id: Ieceaa41bc83ce519c2ef1920c3ff59d2e4f15ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632964 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#845117}
-