- 11 Mar, 2011 40 commits
-
-
enne@google.com authored
Reviewed by Kenneth Russell. Add missing unit tests to TilingData. https://bugs.webkit.org/show_bug.cgi?id=54143 * tests/TilingDataTest.cpp: (WebCore::TEST): git-svn-id: svn://svn.chromium.org/blink/trunk@80894 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
dglazkov@chromium.org authored
Reviewed by Eric Seidel. Introduce lookup-table based approach for applying CSS properties. The aim is to be a starting point for refactoring CSSStyleSelector::applyProperty() into more readable, maintainable code. https://bugs.webkit.org/show_bug.cgi?id=54707 No new behavior / covered by existing tests. * css/CSSStyleApplyProperty.cpp: Added. (WebCore::ApplyPropertyNull): Class that provides empty implementations of inherit, initial, value. (WebCore::ApplyPropertyDefault::ApplyPropertyDefault): Class that calls the appropriate RenderStyle setters directly. (WebCore::ApplyPropertyColorBase::ApplyPropertyColorBase): Class for handling CSSProperty*Color. (WebCore::ApplyPropertyColor::ApplyPropertyColor): Class for handling CSSPropertyColor. (WebCore::CSSStyleApplyProperty::sharedCSSStyleApplyProperty): Singleton initializer. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Constructor that bulds up the map from property id to apply-er objects. * css/CSSStyleApplyProperty.h: Added. (WebCore::CSSStyleApplyProperty::inherit): Handle the inherit case for a given property. (WebCore::CSSStyleApplyProperty::initial): Handle the initial case for a given property. (WebCore::CSSStyleApplyProperty::value): Apply a value to a given property. (WebCore::CSSStyleApplyProperty::implements): Returns true if the provided property id is implemented. (WebCore::CSSStyleApplyProperty::index): Private function to determine the index of a property the property map. (WebCore::CSSStyleApplyProperty::valid): Function to determine that a given property id is valid. (WebCore::CSSStyleApplyProperty::setPropertyValue): (WebCore::CSSStyleApplyProperty::propertyValue): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Get reference to the CSSStyleApplyProperty singleton. (WebCore::CSSStyleSelector::applyProperty): Now calls into CSSStyleApplyProperty for implemented property ids. Deleted color-related methods from the property id switch. * css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::style): Made public to allow access from CSSStyleApplyProperty. (WebCore::CSSStyleSelector::parentStyle): Made public to allow access from CSSStyleApplyProperty. * rendering/style/RenderStyle.h: Made CSSStyleApplyProperty a friend class. Necessary because it needs to access the private getters and setters on this clsass. git-svn-id: svn://svn.chromium.org/blink/trunk@80893 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
beidson@apple.com authored
Source/WebCore: Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11 Add WebKit1 API to view and delete local storage https://bugs.webkit.org/show_bug.cgi?id=51878 Created StorageTracker as a central point for tracking and deleting LocalStorage per origin. StorageTracker maintains its own database of origin identifiers and backing db paths, and this allows it to contain more relational data in the future, like variable quotas per origin. On initialization, StorageTracker syncs its database with LocalStorage files on disk. It adds an origin entry when StorageAreaSync performs a first sync for an origin. All StorageTracker file operations are performed on one background thread with a task queue. Tests: storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html * GNUmakefile.am: * WebCore.exp.in: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * page/PageGroup.cpp: (WebCore::PageGroup::clearLocalStorageForAllOrigins): (WebCore::PageGroup::clearLocalStorageForOrigin): (WebCore::PageGroup::syncLocalStorage): (WebCore::PageGroup::numberOfPageGroups): * page/PageGroup.h: * platform/chromium/FileSystemChromium.cpp: (WebCore::listDirectory): * platform/posix/FileSystemPOSIX.cpp: (WebCore::listDirectory): * storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::LocalStorageTask): (WebCore::LocalStorageTask::performTask): * storage/LocalStorageTask.h: (WebCore::LocalStorageTask::createOriginIdentifiersImport): (WebCore::LocalStorageTask::createSetOriginDetails): (WebCore::LocalStorageTask::createDeleteOrigin): (WebCore::LocalStorageTask::createDeleteAllOrigins): * storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::clearForOriginDeletion): (WebCore::StorageAreaImpl::sync): * storage/StorageAreaImpl.h: * storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::scheduleCloseDatabase): (WebCore::StorageAreaSync::openDatabase): (WebCore::StorageAreaSync::sync): (WebCore::StorageAreaSync::deleteEmptyDatabase): (WebCore::StorageAreaSync::scheduleSync): * storage/StorageAreaSync.h: * storage/StorageNamespace.h: * storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::clearOriginForDeletion): (WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion): (WebCore::StorageNamespaceImpl::sync): * storage/StorageNamespaceImpl.h: * storage/StorageTracker.cpp: Added. (WebCore::StorageTracker::initializeTracker): (WebCore::StorageTracker::tracker): (WebCore::StorageTracker::StorageTracker): (WebCore::StorageTracker::setStorageDirectoryPath): (WebCore::StorageTracker::trackerDatabasePath): (WebCore::StorageTracker::openTrackerDatabase): (WebCore::StorageTracker::importOriginIdentifiers): (WebCore::StorageTracker::syncImportOriginIdentifiers): (WebCore::StorageTracker::syncFileSystemAndTrackerDatabase): (WebCore::StorageTracker::setOriginDetails): (WebCore::StorageTracker::scheduleTask): (WebCore::StorageTracker::syncSetOriginDetails): (WebCore::StorageTracker::origins): (WebCore::StorageTracker::deleteAllOrigins): (WebCore::StorageTracker::syncDeleteAllOrigins): (WebCore::StorageTracker::deleteOrigin): (WebCore::StorageTracker::syncDeleteOrigin): (WebCore::StorageTracker::willDeleteAllOrigins): (WebCore::StorageTracker::willDeleteOrigin): (WebCore::StorageTracker::canDeleteOrigin): (WebCore::StorageTracker::cancelDeletingOrigin): (WebCore::StorageTracker::setClient): (WebCore::StorageTracker::syncLocalStorage): * storage/StorageTracker.h: Added. * storage/StorageTrackerClient.h: Added. (WebCore::StorageTrackerClient::~StorageTrackerClient): Source/WebKit: Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11 Add WebKit1 API to view and delete local storage https://bugs.webkit.org/show_bug.cgi?id=51878 * WebKit.xcodeproj/project.pbxproj: Source/WebKit/chromium: Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11 Add WebKit1 API to view and delete local storage https://bugs.webkit.org/show_bug.cgi?id=51878 * src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespaceProxy::clearOriginForDeletion): (WebCore::StorageNamespaceProxy::clearAllOriginsForDeletion): (WebCore::StorageNamespaceProxy::sync): * src/StorageNamespaceProxy.h: Source/WebKit/mac: Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11 https://bugs.webkit.org/show_bug.cgi?id=51878 Add WebKit1 API to view and delete local storage * Storage/WebStorageManager.mm: Added. (+[WebStorageManager sharedWebStorageManager]): (-[WebStorageManager origins]): (-[WebStorageManager deleteAllOrigins]): (-[WebStorageManager deleteOrigin:]): (-[WebStorageManager syncLocalStorage]): (-[WebStorageManager syncFileSystemAndTrackerDatabase]): (storageDirectoryPath): (WebKitInitializeStorageIfNecessary): * Storage/WebStorageManagerInternal.h: Added. * Storage/WebStorageManagerPrivate.h: Added. * Storage/WebStorageTrackerClient.h: Added. * Storage/WebStorageTrackerClient.mm: Added. (WebStorageTrackerClient::sharedWebStorageTrackerClient): (WebStorageTrackerClient::WebStorageTrackerClient): (WebStorageTrackerClient::~WebStorageTrackerClient): (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): (WebStorageTrackerClient::dispatchDidModifyOrigin): * WebCoreSupport/WebSecurityOrigin.mm: (-[WebSecurityOrigin protocol]): (-[WebSecurityOrigin host]): (-[WebSecurityOrigin databaseIdentifier]): (-[WebSecurityOrigin domain]): (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]): * WebCoreSupport/WebSecurityOriginPrivate.h: * WebKit.exp: * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Tools: Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11 https://bugs.webkit.org/show_bug.cgi?id=51878 Add WebKit1 API to view and delete local storage Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/LayoutTestController.cpp: (syncLocalStorageCallback): (observeStorageTrackerNotificationsCallback): (deleteAllLocalStorageCallback): (deleteLocalStorageForOriginCallback): (originsWithLocalStorageCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/StorageTrackerDelegate.h: Added. * DumpRenderTree/StorageTrackerDelegate.mm: Added. (-[StorageTrackerDelegate init]): (-[StorageTrackerDelegate logNotifications:controller:]): (-[StorageTrackerDelegate originModified:]): (-[StorageTrackerDelegate dealloc]): (-[StorageTrackerDelegate setControllerToNotifyDone:]): * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::deleteAllLocalStorage): (LayoutTestController::originsWithLocalStorage): (LayoutTestController::deleteLocalStorageForOrigin): (observeStorageTrackerNotifications): (syncLocalStorage): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::originsWithLocalStorage): (LayoutTestController::deleteAllLocalStorage): (LayoutTestController::deleteLocalStorageForOrigin): (LayoutTestController::observeStorageTrackerNotifications): (LayoutTestController::syncLocalStorage): * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): (allocateGlobalControllers): (releaseGlobalControllers): * DumpRenderTree/mac/DumpRenderTreeMac.h: * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::syncLocalStorage): (LayoutTestController::observeStorageTrackerNotifications): (LayoutTestController::deleteAllLocalStorage): (LayoutTestController::originsWithLocalStorage): (LayoutTestController::deleteLocalStorageForOrigin): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::originsWithLocalStorage): (LayoutTestController::deleteAllLocalStorage): (LayoutTestController::deleteLocalStorageForOrigin): (LayoutTestController::observeStorageTrackerNotifications): (LayoutTestController::syncLocalStorage): * DumpRenderTree/qt/LayoutTestControllerQt.h: * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::syncLocalStorage): (LayoutTestController::observeStorageTrackerNotifications): (LayoutTestController::clearAllDatabases): (LayoutTestController::deleteAllLocalStorage): (LayoutTestController::originsWithLocalStorage): (LayoutTestController::deleteLocalStorageForOrigin): * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::syncLocalStorage): (LayoutTestController::observeStorageTrackerNotifications): (LayoutTestController::clearAllDatabases): (LayoutTestController::deleteAllLocalStorage): (LayoutTestController::originsWithLocalStorage): (LayoutTestController::deleteLocalStorageForOrigin): LayoutTests: Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11 Add WebKit1 API to view and delete local storage https://bugs.webkit.org/show_bug.cgi?id=51878 * platform/chromium/test_expectations.txt: * storage/domstorage/localstorage/storagetracker: Added. * storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare-expected.txt: Added. * storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html: Added. * storage/domstorage/localstorage/storagetracker/storage-tracker-2-create-expected.txt: Added. * storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html: Added. * storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all-expected.txt: Added. * storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html: Added. * storage/domstorage/localstorage/storagetracker/storage-tracker-4-create-expected.txt: Added. * storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html: Added. * storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one-expected.txt: Added. * storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@80892 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jberlin@webkit.org authored
http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows https://bugs.webkit.org/show_bug.cgi?id=56185 url-parsing.html appears to be causing the crashes in later tests. Skipping the url-parsing.html test and unskipping the url-with-credential.html test. Unreviewed. * platform/win/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@80891 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Dimitri Glazkov. Add an accessibilityIsIgnored method to WebAccessibilityObject. https://bugs.webkit.org/show_bug.cgi?id=50969 * public/WebAccessibilityObject.h: * src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::accessibilityIsIgnored): git-svn-id: svn://svn.chromium.org/blink/trunk@80890 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
rniwa@webkit.org authored
Reviewed by Tony Chang. drag-text-delay.html should be a dump as text test https://bugs.webkit.org/show_bug.cgi?id=56223 Converted the test to a dump as text. Also reorganized the test code and added more descriptions. * editing/selection/drag-text-delay-expected.txt: * editing/selection/drag-text-delay.html: * platform/chromium-linux/editing/selection/drag-text-delay-expected.checksum: Removed. * platform/chromium-linux/editing/selection/drag-text-delay-expected.png: Removed. * platform/chromium-win/editing/selection/drag-text-delay-expected.checksum: Removed. * platform/chromium-win/editing/selection/drag-text-delay-expected.png: Removed. * platform/chromium-win/editing/selection/drag-text-delay-expected.txt: Removed. * platform/gtk/editing/selection/drag-text-delay-expected.checksum: Removed. * platform/gtk/editing/selection/drag-text-delay-expected.png: Removed. * platform/gtk/editing/selection/drag-text-delay-expected.txt: Removed. * platform/mac/editing/selection/drag-text-delay-expected.checksum: Removed. * platform/mac/editing/selection/drag-text-delay-expected.png: Removed. * platform/mac/editing/selection/drag-text-delay-expected.txt: * platform/win/editing/selection/drag-text-delay-expected.checksum: Removed. * platform/win/editing/selection/drag-text-delay-expected.png: Removed. * platform/win/editing/selection/drag-text-delay-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@80889 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
steveblock@google.com authored
Reviewed by Jeremy Orlow. JavaMethod does not correctly check for a null jstring for the method name https://bugs.webkit.org/show_bug.cgi?id=56187 No new tests, simple typo fix. * bridge/jni/JavaMethod.cpp: (JavaMethod::JavaMethod): git-svn-id: svn://svn.chromium.org/blink/trunk@80888 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
enne@google.com authored
Reviewed by James Robinson. [chromium] Compositor uses too much texture memory for scrollbars https://bugs.webkit.org/show_bug.cgi?id=56212 Compositor invalidations can be off the page (and very large), but scrollbars only need to care about the invalidation that's visible. The large invalidation was causing the tiler layer size to grow needlessly larger than the scrollbar. * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::invalidateRootLayerRect): git-svn-id: svn://svn.chromium.org/blink/trunk@80887 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
mihaip@chromium.org authored
Chromium Mac expectations update. Rebaseline some more tests after r80582. * fast/repaint/text-emphasis-h-expected.checksum: * fast/repaint/text-emphasis-h-expected.png: * platform/chromium-mac/fast/repaint/text-emphasis-h-expected.txt: Removed. * platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.checksum: * platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png: * platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.txt: Added. * platform/chromium/test_expectations.txt: * platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: * platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: git-svn-id: svn://svn.chromium.org/blink/trunk@80886 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
mihaip@chromium.org authored
Chromium Mac expectations update. Rebaseline some tests after r80582 (those that already had chromium-mac-leopard baselines). * platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: * platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png: * platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum: * platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.png: * platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: Removed. * platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: Removed. * platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum: * platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.png: * platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum: * platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.png: * platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum: * platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.png: * platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: * platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png: * platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: * platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png: * platform/chromium-mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.checksum: * platform/chromium-mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.png: * platform/chromium-mac-leopard/fast/blockflow/vertical-font-fallback-expected.checksum: * platform/chromium-mac-leopard/fast/blockflow/vertical-font-fallback-expected.png: * platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.checksum: * platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.png: * platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.checksum: * platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png: * platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: * platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.png: * platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.checksum: * platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.png: * platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.txt: * platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.checksum: Removed. * platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.png: Removed. * platform/chromium/test_expectations.txt: * platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: * platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: git-svn-id: svn://svn.chromium.org/blink/trunk@80885 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
jberlin@webkit.org authored
Process has finished launching. https://bugs.webkit.org/show_bug.cgi?id=56208 Reviewed by Adam Roben. Source/WebKit2: Only send the message if the Web Process is valid. * UIProcess/WebContext.cpp: (WebKit::WebContext::clearResourceCaches): Tools: * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added. (TestWebKitAPI::TEST): Test that calling WKContextClearResourceCaches works with both options when called before the Web Process is valid. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add the new test. * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@80884 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hyatt@apple.com authored
Reviewed by Simon Fraser. REGRESSION: Overflowing columns not repainted correctly Make sure to add in column overflow as visual overflow as well. It was only propagating layout overflow, which is obviously not sufficient, since blocks paint their own columns. Added fast/multicol/scrolling-overflow.html Source/WebCore: * rendering/RenderBlock.cpp: (WebCore::RenderBlock::addOverflowFromChildren): LayoutTests: * fast/multicol/scrolling-overflow.html: Added. * platform/mac/fast/multicol/scrolling-overflow-expected.checksum: Added. * platform/mac/fast/multicol/scrolling-overflow-expected.png: Added. * platform/mac/fast/multicol/scrolling-overflow-expected.txt: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@80883 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
dglazkov@chromium.org authored
Reviewed by Adam Barth. Start using derived sources correctly and link minidom with JavaScriptCore gyp project. https://bugs.webkit.org/show_bug.cgi?id=56217 * gyp/JavaScriptCore.gyp: Added derived source files and passing of shared directory to the scripts. * gyp/generate-derived-sources.sh: Changed to use passed directory. * gyp/generate-dtrace-header.sh: Ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@80882 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
mihaip@chromium.org authored
Mac and Chromium expectations update. Remove failing expectations for tests that no longer fail. Rebaseline fast/overflow/ overflow-rtl-vertical.html and fast/lists/008-vertical.html after r80755. * platform/chromium/test_expectations.txt: * platform/mac/fast/lists/008-vertical-expected.checksum: * platform/mac/fast/lists/008-vertical-expected.png: * platform/mac/fast/overflow/overflow-rtl-vertical-expected.checksum: * platform/mac/fast/overflow/overflow-rtl-vertical-expected.png: git-svn-id: svn://svn.chromium.org/blink/trunk@80881 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
mdelaney@apple.com authored
Reviewed by Simon Fraser. Set canvasUsesAcceleratedDrawing setting to be off(false) by default https://bugs.webkit.org/show_bug.cgi?id=56215 No new tests. Does not affect behavior. Just keeping the setting off by default. * page/Settings.cpp: (WebCore::Settings::Settings): git-svn-id: svn://svn.chromium.org/blink/trunk@80880 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
mihaip@chromium.org authored
Update Chromium expectations. Remove some commented out lines and promote some expectatiosn from chromium-mac to mac-leopard, so that those tests pass on chromium Snow Leopard (and mac Leopard). * platform/chromium/test_expectations.txt: * platform/mac-leopard/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum. * platform/mac-leopard/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.png. * platform/mac-leopard/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum. * platform/mac-leopard/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png. git-svn-id: svn://svn.chromium.org/blink/trunk@80879 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
aestes@apple.com authored
Reviewed by David Hyatt. Table cells with dynamically added percentage height descendants do not grow in size if the table has already been laid out. https://bugs.webkit.org/show_bug.cgi?id=56174 Table cells ignore their specified size and collapse to fit their children. When a descendent with percentage height is present before the table is first laid out, the descendent is sized based on the specified size of the table cell. However, when the child isn't present when the table is first laid out, the table cell ignores its specified size and collapses down to 0. Then, when the child div is added in a separate run loop iteration, it is sized to be 100% of the collapsed cell height instead of 100% of the cell's specified height. We should not get different layouts depending on the timing of tree construction. Fix this by clearing intrinsic padding before calculating the table cell's override height when we detect a child that should flex the table cell. Test: fast/table/dynamic-descendant-percentage-height.html * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::setOverrideSizeFromRowHeight): clear intrinsic padding before setting the override size. * rendering/RenderTableCell.h: * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): Call setOverrideSizeFromRowHeight() instead of setOverrideSize(). 2011-03-11 Andy Estes <aestes@apple.com> Reviewed by David Hyatt. Table cells with dynamically added percentage height descendants do not grow in size if the table has already been laid out. https://bugs.webkit.org/show_bug.cgi?id=56174 * fast/table/dynamic-descendant-percentage-height.html: Added. * platform/mac/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added. * platform/mac/fast/table/dynamic-descendant-percentage-height-expected.png: Added. * platform/mac/fast/table/dynamic-descendant-percentage-height-expected.txt: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@80878 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
hyatt@apple.com authored
git-svn-id: svn://svn.chromium.org/blink/trunk@80877 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
michaeln@google.com authored
Reviewed by David Levin. Add SQLCallbackWrapper Instead of directly holding RefPtrs to the Callback objects in SQLStatement and SQLTransaction, hold a wrapper objects which holds those references whose dtors will schedule the release of those references on the ScriptExecution thread. https://bugs.webkit.org/show_bug.cgi?id=55919 No new tests, existing tests apply. * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * storage/SQLCallbackWrapper.h: Added. (WebCore::SQLCallbackWrapper::SQLCallbackWrapper): (WebCore::SQLCallbackWrapper::clear): (WebCore::SQLCallbackWrapper::unwrap): (WebCore::SQLCallbackWrapper::hasCallback): (WebCore::SQLCallbackWrapper::safeRelease): * storage/SQLStatement.cpp: (WebCore::SQLStatement::create): (WebCore::SQLStatement::SQLStatement): (WebCore::SQLStatement::performCallback): * storage/SQLStatement.h: (WebCore::SQLStatement::hasStatementCallback): (WebCore::SQLStatement::hasStatementErrorCallback): * storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::executeSQL): (WebCore::SQLTransaction::checkAndHandleClosedOrInterruptedDatabase): (WebCore::SQLTransaction::deliverTransactionCallback): (WebCore::SQLTransaction::deliverStatementCallback): (WebCore::SQLTransaction::postflightAndCommit): (WebCore::SQLTransaction::deliverSuccessCallback): (WebCore::SQLTransaction::handleTransactionError): (WebCore::SQLTransaction::deliverTransactionErrorCallback): * storage/SQLTransaction.h: git-svn-id: svn://svn.chromium.org/blink/trunk@80876 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
andersca@apple.com authored
Reviewed by Dan Bernstein. Don't paint more than 60 times per second https://bugs.webkit.org/show_bug.cgi?id=56206 <rdar://problem/9085989> * WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_lastDisplayTime to 0. Change the display timer to call displayTimerFired. (WebKit::DrawingAreaImpl::didUpdate): Call displayTimerFired instead of display. (WebKit::DrawingAreaImpl::displayTimerFired): If we're asked to paint again less than 1/60th of a second after we've already painted, defer painting. (WebKit::DrawingAreaImpl::display): Update m_lastDisplayTime. git-svn-id: svn://svn.chromium.org/blink/trunk@80875 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
eric.carlson@apple.com authored
Reviewed by Sam Weinig. <rdar://problem/8955589> Adopt AVFoundation media back end on Lion. No new tests, existing media tests cover this. * WebCore.xcodeproj/project.pbxproj: * platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines): Register MediaPlayerPrivateAVFoundationObjC. (WebCore::bestMediaEngineForTypeAndCodecs): Kill some whitespace. (WebCore::MediaPlayer::loadWithNextMediaEngine): Ditto. (WebCore::MediaPlayer::inMediaDocument): Ditto. * platform/graphics/MediaPlayer.h: * platform/graphics/avfoundation: Added. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: Added. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Added. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Added. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Added. 2011-03-11 Eric Carlson <eric.carlson@apple.com> Reviewed by Sam Weinig. <rdar://problem/8955589> Adopt AVFoundation media back end on Lion. No new tests, existing media tests cover this. * JavaScriptCore.exp: Export cancelCallOnMainThread * wtf/Platform.h: Define WTF_USE_AVFOUNDATION. git-svn-id: svn://svn.chromium.org/blink/trunk@80874 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
dino@apple.com authored
Reviewed by Simon Fraser. https://bugs.webkit.org/show_bug.cgi?id=56205 m_restrictions needs to allow multiple values (a bitfield) HTMLMediaElement::m_restrictions needs to hold multiple values, so change BehaviorRestrictions to an unsigned typedef and rename the existing enum BehaviorRestrictionFlags. * html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::setBehaviorRestrictions): git-svn-id: svn://svn.chromium.org/blink/trunk@80873 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
dglazkov@chromium.org authored
[GTK] Update expectations after r80857. https://bugs.webkit.org/show_bug.cgi?id=55972 * platform/gtk/media/audio-controls-rendering-expected.txt: * platform/gtk/media/audio-repaint-expected.txt: * platform/gtk/media/controls-strict-expected.txt: * platform/gtk/media/controls-styling-expected.txt: * platform/gtk/media/controls-without-preload-expected.txt: * platform/gtk/media/media-document-audio-repaint-expected.txt: * platform/gtk/media/video-controls-rendering-expected.txt: * platform/gtk/media/video-empty-source-expected.txt: * platform/gtk/media/video-no-audio-expected.txt: * platform/gtk/media/video-volume-slider-expected.txt: * platform/gtk/media/video-zoom-controls-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@80872 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
hyatt@apple.com authored
Reviewed by Dan Bernstein. Table rows don't support ::before/::after. Add support to RenderTableRow::styleDidChange so that ::before/::after content gets properly constructed. Added fast/css-generated-content/table-row-before-after.html Source/WebCore: * rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::styleDidChange): * rendering/RenderTableRow.h: LayoutTests: * fast/css-generated-content/table-row-before-after.html: Added. * platform/mac/fast/css-generated-content/table-row-before-after-expected.checksum: Added. * platform/mac/fast/css-generated-content/table-row-before-after-expected.png: Added. * platform/mac/fast/css-generated-content/table-row-before-after-expected.txt: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@80871 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jamesr@google.com authored
Reviewed by Kenneth Russell. [chromium] Avoid updating a composited layer's contents if the layer has nonpositive dimensions https://bugs.webkit.org/show_bug.cgi?id=56209 This matches the behavior prior to r80482. No test since the only changes in behavior are avoiding work on invisible layers, which is unobservable, and fixing a crash due to bug 56153. * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateContentsRecursive): git-svn-id: svn://svn.chromium.org/blink/trunk@80869 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
hyatt@apple.com authored
Reviewed by Simon Fraser. CSS2.1 failures in background position parsing. Rewrite background position component parsing to match the spec. Our old parsing would allow "100% left" to be valid when it should not have. Rename parseFillPositionXY to parseFillPositionComponent and pass in enough information for it to understand what the first component was. For individual property parsing using background-position-x/y, I added new functions that just handle that without worrying about the other component. In order to pass the CSS2.1 test, I also had to fix multiple background parsing. The number of layers in multiple backgrounds is determined solely by the background-image property and not by any of the other properties. cullEmptyLayers has been changed to always consider a layer empty if it has no image set, even if other properties are set. A number of layout tests had to be patched as they were invalid. A couple of them relied on incorrect background-position parsing (e.g., "50 left") and another relied on incorrect multiple background parsing. It's not clear if the computed style should actually include the additional values when no image is set though, so that should perhaps be the subject of a follow-up bug. Added fast/backgrounds/background-position-parsing.html Source/WebCore: * css/CSSParser.cpp: (WebCore::CSSParser::parseFillPositionX): (WebCore::CSSParser::parseFillPositionY): (WebCore::CSSParser::parseFillPositionComponent): (WebCore::CSSParser::parseFillPosition): (WebCore::CSSParser::parseFillProperty): (WebCore::CSSParser::parseTransformOrigin): (WebCore::CSSParser::parsePerspectiveOrigin): * css/CSSParser.h: * rendering/style/FillLayer.cpp: (WebCore::FillLayer::fillUnsetProperties): (WebCore::FillLayer::cullEmptyLayers): LayoutTests: * fast/backgrounds/background-position-1.html: * fast/backgrounds/background-position-parsing.html: Added. * fast/backgrounds/multiple-backgrounds-computed-style-expected.txt: * fast/backgrounds/repeat/parsing-background-repeat-expected.txt: * fast/backgrounds/repeat/script-tests/parsing-background-repeat.js: * fast/backgrounds/resources/diamond.png: Added. * fast/backgrounds/resources/ring.png: Added. * fast/backgrounds/script-tests/multiple-backgrounds-computed-style.js: * platform/mac/fast/backgrounds/animated-svg-as-background-expected.checksum: * platform/mac/fast/backgrounds/animated-svg-as-background-expected.png: * platform/mac/fast/backgrounds/animated-svg-as-mask-expected.checksum: * platform/mac/fast/backgrounds/animated-svg-as-mask-expected.png: * platform/mac/fast/backgrounds/background-position-parsing-expected.checksum: Added. * platform/mac/fast/backgrounds/background-position-parsing-expected.png: Added. * platform/mac/fast/backgrounds/background-position-parsing-expected.txt: Added. * platform/mac/fast/backgrounds/bgCompositeCopy-expected.png: * platform/mac/fast/backgrounds/repeat/noRepeatCorrectClip-expected.png: * platform/mac/fast/backgrounds/size/backgroundSize01-expected.png: * platform/mac/fast/backgrounds/size/backgroundSize03-expected.png: * platform/mac/fast/backgrounds/size/backgroundSize05-expected.png: * platform/mac/fast/backgrounds/size/backgroundSize06-expected.png: * platform/mac/fast/backgrounds/size/backgroundSize07-expected.png: * platform/mac/fast/backgrounds/size/backgroundSize08-expected.png: * platform/mac/fast/backgrounds/size/backgroundSize09-expected.png: * platform/mac/fast/backgrounds/size/backgroundSize10-expected.png: * platform/mac/fast/backgrounds/size/backgroundSize11-expected.png: * platform/mac/fast/backgrounds/size/backgroundSize12-expected.png: * platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum: * platform/mac/fast/backgrounds/size/backgroundSize22-expected.png: * platform/mac/fast/backgrounds/size/contain-and-cover-expected.checksum: * platform/mac/fast/backgrounds/size/contain-and-cover-expected.png: * platform/mac/fast/backgrounds/svg-as-background-4-expected.png: git-svn-id: svn://svn.chromium.org/blink/trunk@80868 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
vangelis@chromium.org authored
Reviewed by James Robinson. [chromium] Adding a test for rotated large layers. https://bugs.webkit.org/show_bug.cgi?id=55984 * platform/chromium/compositing/huge-layer-rotated-expected.checksum: Added. * platform/chromium/compositing/huge-layer-rotated-expected.png: Added. * platform/chromium/compositing/huge-layer-rotated-expected.txt: Added. * platform/chromium/compositing/huge-layer-rotated.html: Added. 2011-03-11 Vangelis Kokkevis <vangelis@chromium.org> Reviewed by James Robinson. [chromium] Allow large layers with non-identity transforms to be drawn as long as their visible portion is smaller than the largest supported texture size. This code will soon be replaced by tiled layers. https://bugs.webkit.org/show_bug.cgi?id=55984 Test: platform/chromium/compositing/huge-layer-rotated.html * platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateContentsIfDirty): (WebCore::ContentLayerChromium::draw): * platform/graphics/chromium/ContentLayerChromium.h: git-svn-id: svn://svn.chromium.org/blink/trunk@80867 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
cmarrin@apple.com authored
Reviewed by Adam Roben. REGRESSION (5.0.3-ToT): Scrolling text doesn't scroll in Star Wars intro animation https://bugs.webkit.org/show_bug.cgi?id=52468 Added WIN32 to the ifdef controlling whether animations are applied in normal or reverse order. On Mac, animations used to be applied in reverse, but <rdar://problem/7095638> fixed this in the release after Snow Leopard. But that patch has not be applied to the Safari Windows SDK yet. For now I've made Windows use the reverse order logig. <rdar://problem/9112233> is tracking the inclusion of the patch on Windows. * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): git-svn-id: svn://svn.chromium.org/blink/trunk@80866 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
dglazkov@chromium.org authored
Reviewed by Adam Barth. Tweak dylib paths and add dtrace header generation action to JavaScriptCore gyp project. https://bugs.webkit.org/show_bug.cgi?id=56207 * JavaScriptCore.gypi: Added Tracing.d to the sources. * gyp/generate-dtrace-header.sh: Added. * gyp/JavaScriptCore.gyp: Updated dylib paths (now the project can see them), and added DTrace header generating step. git-svn-id: svn://svn.chromium.org/blink/trunk@80865 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
aroben@apple.com authored
You can now give Leaks Viewer the URL of a build results page (e.g., <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it will load all the leaks files from that build. Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks files from a particular build at once, rather than one at a time Reviewed by David Kilzer. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added. (LeaksLoader): Initialize our properties. (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and load it. Otherwise assume it's a build results page URL and start fetching the leaks files from that page. (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading so it can provide feedback. Then load each one and pass it to the client. (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse it into a DOM, pull out all the links to leaks files, and load each one. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added. (LeaksParser): Initialize our worker. (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added. This code mostly came from Worker.js. (LeaksParserWorker): Initialize our profile. (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our profile. (LeaksParserWorker.prototype._parseLeaks): (LeaksParserWorker.prototype._createNode): (LeaksParserWorker.prototype._incorporateLeaks): Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed version of createProfile which adds to this.profile instead of making a new profile each time. (onmessage): Parse the file and send back the new profile. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: (#loading-indicator): (#spinner): (#loading-indicator-label): Tweaked styles to accomodate a longer label. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: (LeaksViewer.loaded): Set up a loader and parser. (LeaksViewer.get filesLeftToParse): (LeaksViewer.set filesLeftToParse): Added these simple accessors. (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count. (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to the parser. (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed, tell the ProfilerAgent and mark that we're done loading. (Code came from the old _loadLeaksFromURL function). (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader. (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the loading indicator, including the number of files being loaded. (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too. (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label! (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to _loadingIndicatorText. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added. (getResource): Moved here from LeaksViewer.js. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by LeaksParserWorker.js. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS files, added a #loading-indicator-label element, and tweaked the prompt wording. git-svn-id: svn://svn.chromium.org/blink/trunk@80864 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aroben@apple.com authored
Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did Reviewed by Dan Bernstein. * Scripts/webkitpy/common/config/build.py: (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of directories that shouldn't trigger builds. Re-sorted the list. * Scripts/webkitpy/common/config/build_unittest.py: (ShouldBuildTest): Added a test to cover the above change. git-svn-id: svn://svn.chromium.org/blink/trunk@80863 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Tony Chang. Fix missing initialization of new member variables. https://bugs.webkit.org/show_bug.cgi?id=50969 * public/WebMenuItemInfo.h: (WebKit::WebMenuItemInfo::WebMenuItemInfo): git-svn-id: svn://svn.chromium.org/blink/trunk@80862 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
tonyg@chromium.org authored
Reviewed by Eric Seidel. Let the parser yield for layout before running scripts https://bugs.webkit.org/show_bug.cgi?id=54355 Prior to this patch, the parser would yield to perform a layout/paint before running a script only if the script or a stylesheet blocking the script is not loaded yet. Since we don't preload scan into the body while parsing the head, typically we'll block on a script early in the body that causes us to yield to do the first paint within a reasonable time. However, I'm planning to change the PreloadScanner to scan into the body from the head. That significantly improves overall load time, but would hurt first paint time because fewer scripts would be blocked during parsing and thus wouldn't yield. This change causes us to yield before running scripts if we haven't painted yet (regardless of whether or not the script is loaded). In addition to allowing the above mentioned PreloadScanner change to be implemented without regressing first paint time, this also improves first paint time by itself. I tested Alexa's top 45 websites using Web Page Replay to control the content and simulate bandwidth. This patch improved average first paint time by 1% over an unlimited connection, 6% over a 1Mbps connection and 11% over a 5Mbps connection. There was no statistically signifcant change in page load time. Within the pages tested, 33 had no statistically significant change in time to first paint, 12 improved, and none regressed. Of the improved, some of the standouts from the 1Mbps set are: 20% on youtube, 37% on wiki, 27% on ebay, 13% on cnn, 16% on espn, 74% on sohu. * html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::canTakeNextToken): This is the new yield point. (WebCore::HTMLDocumentParser::pumpTokenizer): Remove ASSERT that we are not paused. isPaused means that we are waiting for a script. Bug 54574 changed pumpTokenizer() so that it does the right thing whether we are just before a token or waiting for a script. Now that we may yield before a token or before a script, this may be called while paused. * html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::checkForYieldBeforeScript): Added. * page/FrameView.h: (WebCore::FrameView::hasEverPainted): Added. git-svn-id: svn://svn.chromium.org/blink/trunk@80861 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Ariya Hidayat. [Qt] Entering fullscreen and leaving it may hide the cursor of the application. https://bugs.webkit.org/show_bug.cgi?id=56181 We need to stop the auto hide cursor timer when closing the widget otherwise the timer might get fired and therefore hide the cursor even when the fullscreen widget is closed. * WebCoreSupport/FullScreenVideoWidget.cpp: (WebCore::FullScreenVideoWidget::closeEvent): git-svn-id: svn://svn.chromium.org/blink/trunk@80860 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
dglazkov@chromium.org authored
Fix crashes in dom/html/level2/html/HTMLInputElement*. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Added a null-check for e, because e can certainly be a null. git-svn-id: svn://svn.chromium.org/blink/trunk@80859 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
dglazkov@chromium.org authored
Reviewed by David Hyatt. Choke text-decoration when entering shadow DOM subtree. https://bugs.webkit.org/show_bug.cgi?id=56044 No new tests, because the functionality can't be tested yet. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Added a check for shadow DOM root. git-svn-id: svn://svn.chromium.org/blink/trunk@80858 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
dglazkov@chromium.org authored
Reviewed by Eric Carlson. Convert MediaControlTimeDisplayElement to use standard layout with a custom renderer. https://bugs.webkit.org/show_bug.cgi?id=55972 Update test results, because they are now laying out timeline consistently. * media/audio-repaint-expected.txt: Updated. * platform/mac/media/audio-controls-rendering-expected.checksum: Ditto. * platform/mac/media/audio-controls-rendering-expected.png: Ditto. * platform/mac/media/audio-controls-rendering-expected.txt: Ditto. * platform/mac/media/audio-repaint-expected.checksum: Ditto. * platform/mac/media/audio-repaint-expected.png: Ditto. 2011-03-08 Dimitri Glazkov <dglazkov@chromium.org> Reviewed by Eric Carlson. Convert MediaControlTimeDisplayElement to use standard layout with a custom renderer. https://bugs.webkit.org/show_bug.cgi?id=55972 Instead of poking at the time display elements all the way from RenderMedia, let the standard layout cycle take care of things. Move the logic of calculating when to collapse the time display elements into a custom renderer, since this is not something that can be accomplished with CSS. Also, the logic of keeping the timeline slider at least 100px needed refreshing, since it didn't actually keep it at 100px. * html/shadow/MediaControls.cpp: Moved the logic of determining visibility of time display elements to RenderMediaControlTimeDisplay, eliminating updateTimeDisplayVisibility method. * html/shadow/MediaControls.h: Removed decl. * rendering/MediaControlElements.cpp: (WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay): Added new renderer class. (WebCore::RenderMediaControlTimeDisplay::layout): Simplified (and corrected) size-sensing logic, still using hard-coded values. (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement): Removed m_isVisible member, which is no longer necessary. (WebCore::MediaControlTimeDisplayElement::createRenderer): Added to return the new renderer. * rendering/MediaControlElements.h: Adjusted decls. * rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout): Remove the now-unnecessary poking at media controls in layout. git-svn-id: svn://svn.chromium.org/blink/trunk@80857 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Gustavo Noronha Silva. Provide a knob to enable/disable DNS prefetching. DNS prefetching is enabled by default. https://bugs.webkit.org/show_bug.cgi?id=55973 * webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy): * webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify): git-svn-id: svn://svn.chromium.org/blink/trunk@80856 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
dglazkov@chromium.org authored
Reviewed by Eric Carlson. Start focusing updates to media controls, away from always updating everything. https://bugs.webkit.org/show_bug.cgi?id=56038 For now, the new methods just call generic MediaControls::update. Covered by existing tests. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Changed to use MediaControls::reset. (WebCore::HTMLMediaElement::setMuted): Changed to use MediaControls::changedMute. (WebCore::HTMLMediaElement::updateVolume): Changed to use MediaControls::changedVolume. (WebCore::HTMLMediaElement::defaultEventHandler): Changed to use the new mediaControls accessor. (WebCore::HTMLMediaElement::setClosedCaptionsVisible): Changed to use MediaControls::changedClosedCaptionsVisibility. (WebCore::HTMLMediaElement::mediaControls): Added. (WebCore::HTMLMediaElement::hasMediaControls): Added. * html/HTMLMediaElement.h: Added decls. * html/shadow/MediaControls.cpp: (WebCore::MediaControls::reset): Added. (WebCore::MediaControls::changedMute): Added. (WebCore::MediaControls::changedVolume): Added. (WebCore::MediaControls::changedClosedCaptionsVisibility): Added. * html/shadow/MediaControls.h: Added decls. git-svn-id: svn://svn.chromium.org/blink/trunk@80855 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Martin Robinson. [GStreamer] When seeking webKitWebSrcStop release the frame but should not. https://bugs.webkit.org/show_bug.cgi?id=55703 When calling webKitWebSrcStop in case of a seeking, the frame should not be reset (the source hasn't change). The frame may be used to get the network context. Some network stack (like Qt) are relaying on the network context to work. * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcStop): git-svn-id: svn://svn.chromium.org/blink/trunk@80854 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
