- 04 Dec, 2018 40 commits
-
-
Dale Curtis authored
The code path was only logging unsupported containers, so the results were skewed by unrecognizable garbage. BUG=877697 Change-Id: If3ec0019786cb388fafe599a7a773df15c3be08b Reviewed-on: https://chromium-review.googlesource.com/c/1357624Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#613382}
-
Katie Dillon authored
navigator.language should be supported in workers according to specifications. This CL adds a virtual function for retrieving the accept_language to navigator_language which is then overridden by navigator, who gets the languages from the frame, and woker_navigator, who gets the languages from renderer preferences. From there, navigator_language parses the string and returns either the top prefered language or a vector of all of the preferred languages. In addition, any changes to the language fires an event that notifies all of the worker threads to the change, as per specification. Based on this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1136794 Bug: 276159, 655458 Change-Id: I53bd454f10b5b9b9dc8fd3afa82415b6e93698ca Reviewed-on: https://chromium-review.googlesource.com/c/1255151 Commit-Queue: Ojan Vafai <ojan@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#613381}
-
Brandon Wylie authored
The bug was fixed, but I didn't add a unittest. This unittest will cover the case fixed in 1351534. Bug: 909735 Change-Id: Ie9337b301abcd7717c0719741d9e8d58adafade0 Reviewed-on: https://chromium-review.googlesource.com/c/1358922Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#613380}
-
Jon Kunkee authored
This change adds ARM64 Windows support to the configure/GNI-generation script for libvpx and adds the generated config files. Bug: 893460 Change-Id: I2b58bca3ac1e2650f68dd82495fa3bb5f44b88a7 Reviewed-on: https://chromium-review.googlesource.com/c/1332732Reviewed-by:
James Zern <jzern@chromium.org> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: James Zern <jzern@chromium.org> Cr-Commit-Position: refs/heads/master@{#613379}
-
Lei Zhang authored
Change-Id: I853a885dd09d523969353c698a7312272d5b0523 Reviewed-on: https://chromium-review.googlesource.com/c/1357761 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#613378}
-
Wez authored
Connection multiplexing results in unexpected hangs or resets when used by our runner scripts, so disable it until the root cause is found and resolved upstream. Bug: 900790 Change-Id: I5025a5d652cdcbfe0c206fc4bf42366efbee07be Reviewed-on: https://chromium-review.googlesource.com/c/1359489Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#613377}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f9910ea25812..0b201b07e499 git log f9910ea25812..0b201b07e499 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 halcanary@google.com SkQP: tools/skqp/get_gold_export_url.py 2018-12-03 michaelludwig@google.com Remove unnecessary gl_FragCoord workaround 2018-12-03 mtklein@google.com clean up SkBitmapProcState::platformProcs() Created with: gclient setdep -r src/third_party/skia@0b201b07e499 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I9b08077e0f5d63c88ac94fa4dc97ef11b38a576c Reviewed-on: https://chromium-review.googlesource.com/c/1358768Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613376}
-
Andrey Kosyakov authored
... to prevent deadlocking against stream consumer that may be blocked because of virtual time. Change-Id: Ic823f056677d707291c2cfd60bc8f8677d10c070 Reviewed-on: https://chromium-review.googlesource.com/c/1359414Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#613375}
-
Liquan(Max) Gu authored
The current implementation has switched to use until-GPU-swap timestamp, but the code base still keep the renderer timestamp. As the renderer timestamp is no longer used. We should remove it. The CL cleans up the renderer timestamp from paint-timing and first-meaningful-paint-detector. But this CL has leftover work, as we still have first_meaningful_paint2_quiet_ and first_meaningful_paint2_quiet_swap. Intuitively we would remove first_meaningful_paint2_quiet_ and keep first_meaningful_paint2_quiet_swap. But first_meaningful_paint2_quiet_ is still playing a role in the algorithm, which therefore makes the clean up a bit tricker. We will focus on this issue in a later patch. Bug: 747484 Change-Id: I8bdb5f4551fe823ad56fd26d735e37e626006c61 Reviewed-on: https://chromium-review.googlesource.com/c/1355258Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#613374}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/89808a631e39..8c294315e5a9 git log 89808a631e39..8c294315e5a9 --date=short --no-merges --format='%ad %ae %s' 2018-12-03 wonderfly@google.com chromeos_config: Add a schedule for master-lakitu-release on R72 Created with: gclient setdep -r src/third_party/chromite@8c294315e5a9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ied13abee7935ca8dafbc176772159db29279c863 Reviewed-on: https://chromium-review.googlesource.com/c/1359572Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613373}
-
Brandon Wylie authored
Scaling/cropping images we get for Feed, yields a roughly 5x decrease in memory usage. Image size before: 1064160 bytes Image size after: 188356 bytes Bug: 910192 Change-Id: I7b4347c9e34f6f8680886bb2c0dd14f5b4346ebe Reviewed-on: https://chromium-review.googlesource.com/c/1357608 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#613372}
-
John Lee authored
Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=911008#c1 Bug: 911008 Change-Id: I26748c195fa18cb30dc98a7bb14a1e231337261f Reviewed-on: https://chromium-review.googlesource.com/c/1358702Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#613371}
-
Lei Zhang authored
Use the locale's RTL direction in Print Preview's header/footer template. Bug: 906521 Change-Id: I97d2f8d30be8bfe26f4260df05fe26138655c487 Reviewed-on: https://chromium-review.googlesource.com/c/1354568 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#613370}
-
Eugene But authored
This will prevent showing Back And Forward items in the app UI. Bug: 877671 Change-Id: I93f7868847a58e82d70fc01ebfb11a3a7d30399a Reviewed-on: https://chromium-review.googlesource.com/c/1356982Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#613369}
-
Megan Jablonski authored
Change-Id: I777e068f0391dfd0e45c26fde83c423d3374cb20 Bug: 909915 Reviewed-on: https://chromium-review.googlesource.com/c/1354346Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#613368}
-
Peter Boström authored
Makes use of SetFocusTraversableParent to declare where focus should go after the view has been fully traversed. Fixes infinite recursion where LoginUserMenu would redirect focus to its anchor and then forward focus (which takes it inside LoginUserMenu as the dialog is anchored). Bug: chromium:901456 Change-Id: I138be71866760de84980f5e4ca0c1b42d6d1793f Reviewed-on: https://chromium-review.googlesource.com/c/1338222 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#613367}
-
Yuichiro Hanada authored
Bug: 901439, 908762 Test: content_browsertests Change-Id: Id8730f01db6781d7983ebbc1402176203e0b146a Reviewed-on: https://chromium-review.googlesource.com/c/1347634Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#613366}
-
Cathy Li authored
[Explore sites]: Fix scrolling issue, where clicking on NTP tiles would sometimes not scroll to the right category on the ESP. Bug: 910399 Change-Id: Icd9e7cc3a4974d18960458bf633c10df659f968c Reviewed-on: https://chromium-review.googlesource.com/c/1359512 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#613365}
-
Collin Baker authored
When an inactive tab is hovered over, GetTabForegroundColor uses either the active or inactive tab background color rather than the blended background color. This has GetTabForegroundColor take the true background color as an argument to fix this. Bug: 905066 Change-Id: I5e91341ea0012e8c811c60d118a0ae4347716ed6 Reviewed-on: https://chromium-review.googlesource.com/c/1354230Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#613364}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/41975c6b..d8a2cdca Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaaaf33ccb56b27c74d046b98b0e7509c13e82bdf Reviewed-on: https://chromium-review.googlesource.com/c/1359313Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613363}
-
James Darpinian authored
The GLSL 3.00.6 spec forbids aliasing of attributes even if they are inactive. Earlier versions of GLSL still allow it. This mirrors an ANGLE change: http://crrev.com/c/1005077 Fixes WebGL conformance test conformance2/attribs/gl-bindAttribLocation-aliasing-inactive.html Bug: 829541 Change-Id: I8163c3fac3ca7b5b0c6efd9f9a88b9f92c2d19f6 Reviewed-on: https://chromium-review.googlesource.com/c/1359413Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#613362}
-
Max Moroz authored
Bug: 911030 Change-Id: Ib17595734fc034faba8fa99ab064385be15fcfdb Reviewed-on: https://chromium-review.googlesource.com/c/1359491Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#613361}
-
Wez authored
Add pass-through for --test-launcher-bot-mode and set it via mb.py for all non-script steps that we run on Fuchsia. The main difference this makes is to enable the TestLauncher's default bot-mode retry-limit. Bug: 911160 Change-Id: I036c0d466c37dfdcd64c7faebdfc7d25ee6a00a5 Reviewed-on: https://chromium-review.googlesource.com/c/1358636 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#613360}
-
Ovidio Henriquez authored
This reverts commit 56848201. Reason for revert: WizardControllerDeviceStateTest.ControlFlowDeviceDisabled timing out on linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9330 Original change's description: > Reland "cros: Remove WizardInProcessBrowserTest" > > Reason for revert: the failing test was flaky without this change and has since been disabled (crbug.com/911154) > > Original change's description: > > Revert "cros: Remove WizardInProcessBrowserTest" > > > > This reverts commit 92925c66. > > > > Reason for revert: WizardControllerDeviceState*Test timing out on linux-chromeos-dbg > > > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9248 > > > > rowserTestBase received signal: Terminated. Backtrace: > > #0 0x7feb2e8b3fed base::debug::StackTrace::StackTrace() > > #1 0x7feb2e5addfa base::debug::StackTrace::StackTrace() > > #2 0x563fac6dc0f2 content::(anonymous namespace)::DumpStackTraceSignalHandler() > > #3 0x7feafb349cb0 <unknown> > > #4 0x7feafb4116d3 epoll_wait > > #5 0x7feb2e96353f epoll_dispatch > > #6 0x7feb2e956cc5 event_base_loop > > #7 0x7feb2e9073c9 base::MessagePumpLibevent::Run() > > #8 0x7feb2e63fbe6 base::MessageLoopImpl::Run() > > #9 0x7feb2e6eb322 base::RunLoop::Run() > > #10 0x563fa6018304 chromeos::WizardControllerDeviceStateTest::WaitForAutoEnrollmentState() > > #11 0x563fa5ffeb8f chromeos::WizardControllerDeviceStateExplicitRequirementTest_ControlFlowForcedReEnrollment_Test::RunTestOnMainThread() > > > > Original change's description: > > > cros: Remove WizardInProcessBrowserTest > > > > > > The base class convoluted the inheritance structure and it is simpler to > > > directly derive from InProcessBrowserTest. > > > > > > Bug: 899777 > > > Change-Id: I04b8e4d48d0a28a8d4481891d5379456df32d0d6 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1345244 > > > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > > > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#612394} > > > > TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org > > > > Change-Id: I06cfea778c8246795a8bb8fdc9878812a1ab5d52 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 899777 > > Reviewed-on: https://chromium-review.googlesource.com/c/1356168 > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#612523} > > TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org,ortuno@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 899777 > Change-Id: Id6a54d588736969830db39963f5cc4560d1068b9 > Reviewed-on: https://chromium-review.googlesource.com/c/1359135 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613244} TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org,ortuno@chromium.org Change-Id: Ifeec16d8f954fd9a9aede38a2fa0bffcc107dab4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899777 Reviewed-on: https://chromium-review.googlesource.com/c/1359815Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#613359}
-
Kyle Horimoto authored
Previously, we would attempt a BLE scan any time that we got a DeviceChanged() or DeviceAdded() callback. However, the DeviceChanged() callback was invoked when a device was in the process of disconnecting, meaning that we would see a disconnecting device, then try to start a connection immediately. This resulted in spurious connection requests which could sometime cause a deadlock in underlying Bluetooth code. Additionally, we would rely on the DeviceChanged() and DeviceRemoved() callbacks to listen for Bluetooth disconnections, which also resulted in error-prone disconnections. This CL updates both call sites to use the updated DeviceAdvertisementReceived() and DeviceConnectedStateChanged() callbacks instead. Bug: 898334 Change-Id: I743e51e6e47194649ab6852966b9d892c3ef334d Reviewed-on: https://chromium-review.googlesource.com/c/1359478 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#613358}
-
Mounir Lamouri authored
Bug: None Change-Id: I99172fb7a36e002fe535c2176189368cee3283e1 Reviewed-on: https://chromium-review.googlesource.com/c/1357384Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#613357}
-
Yury Khmel authored
This reverts commit 36458f22. Reason for revert: This CL leads to data loss. Original change's description: > [Locked Fullscreen] Disable ARC while in locked fullscreen > > Locked fullscreen is supposed to be a secure mode where the user cannot do > anything outside of the current browser window, but ARC apps can currently draw > on top of it. To fix this, we disable ARC when entering the mode, and we > re-enable it upon exiting the mode. > > Bug: 888611 > Change-Id: I84cda87a260a42108f1ef6c4767c174bc8b1fb61 > Reviewed-on: https://chromium-review.googlesource.com/c/1356813 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Commit-Queue: Ivan Šandrk <isandrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613254} TBR=isandrk@chromium.org,karandeepb@chromium.org Change-Id: I9e5ca84ba4e186cb43e3a186da9b659b03368145 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 888611 Reviewed-on: https://chromium-review.googlesource.com/c/1359813Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#613356}
-
Robbie McElrath authored
Bug: 911173 Change-Id: I8ecef4636e421c0e698af3d5f1796fca78cb269a Reviewed-on: https://chromium-review.googlesource.com/c/1359330Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#613355}
-
Kouhei Ueno authored
Bug: 909576 Change-Id: Ic202cda4e44410d75bd774edae721a8a2cb6ae10 Reviewed-on: https://chromium-review.googlesource.com/c/1350420Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#613354}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d835d664bd3b..b1ff8ba5b90f git log d835d664bd3b..b1ff8ba5b90f --date=short --no-merges --format='%ad %ae %s' 2018-12-03 33432579+alan-baker@users.noreply.github.com Check device scope for Vulkan memory model (#2149) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b1ff8ba5b90f The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Icc484759c9089e59e6a8ae22aa4d631ac2526d4d Reviewed-on: https://chromium-review.googlesource.com/c/1358769Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#613353}
-
Zakhar Voit authored
Show warning icon on public session login screen when managed sessions are enabled. Bug: 910218 Change-Id: I119dd321c6d9a7bf8dd3b3da533b8774e9620bc7 Reviewed-on: https://chromium-review.googlesource.com/c/1337492 Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#613352}
-
Charlie Harrison authored
This CL: 1. Adds method to ContentBrowserClient which allows logging blink UseCounters scoped to a given RenderFrameHost. 2. Uses this new API to log UseCounters for opener navigations resulting in downloads. Bug: 632514 Change-Id: I4459281c5a104fac776a13f9f003b1d75349354f Reviewed-on: https://chromium-review.googlesource.com/c/1324244 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#613351}
-
Jamie Madill authored
Bug: 822310 Change-Id: I08253e03f7a7e954b129d7650ca30efcca5fc9cb Reviewed-on: https://chromium-review.googlesource.com/c/1355603Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#613350}
-
Sky Malice authored
Bug: 910712 Change-Id: I70b768c1215ef0f540fbccbe98d0907881388782 Reviewed-on: https://chromium-review.googlesource.com/c/1357537 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#613349}
-
Kent Tamura authored
- content::LayoutTestBluetoothFakeAdapterSetterImpl - content::LayoutTestBrowserMainParts - content::MojoLayoutTestHelper Their file names were already renamed in crrev.com/613027. This CL has no behavior changes. Bug: 84341 Change-Id: I97c32f04a8b2d3ba06947176e912a222885b9cdd Reviewed-on: https://chromium-review.googlesource.com/c/1358313Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#613348}
-
James Cook authored
This breaks a dependency from AutomationManagerAura to the extensions system. It should make AutomationManagerAura easier to test in unit tests. Bug: 910280 Test: browser_tests Change-Id: I3e7036671d6e6140b6e19b72e7d6482e2fb6f376 Reviewed-on: https://chromium-review.googlesource.com/c/1357548Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#613347}
-
Dale Curtis authored
There's currently no way to resume these sinks from html/js so there's no point in restoring the sink state after disconnection. Specifically you can't call MediaElementAudioSourceNode.disconnect() and expect the underlying media element to be able to ever work again. See this demo: http://storage.googleapis.com/dalecurtis/webaudio-test.html Once AudioContext.createMediaElementSource(element) has been called on an element, that element can never be used standalone again. It must always be connected to the AudioContext to be used. In fact it's actually causing unnecessary work when the elements are destructed since removing the client respins the sink and mixer, etc. BUG=910951 TEST=passes cq. R=hongchan Change-Id: I5ff7fc532545075d62859a30f96d17c83bff9d21 Reviewed-on: https://chromium-review.googlesource.com/c/1359092 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#613346}
-
bsheedy authored
This is a reland of 06b8660d No changes made from original CL - original was reverted due to a failing DCHECK, but it turns out that DCHECK was invalid and got reverted. Original change's description: > Use mocked VR controller for scrolling > > Switches all VR instrumentation tests for scrolling using the Daydream > controller to use the Chrome-side controller mock instead of the > VrCore-side emulation via intents. The latter has always been somewhat > flaky, so this should help reduce VR test flakiness. > > Bug: 902938 > Change-Id: I560cda2129357c49bdfa3d095836e6ebd1b23da8 > Reviewed-on: https://chromium-review.googlesource.com/c/1341061 > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Commit-Queue: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613107} TBR=vollick@chromium.org, cjgrant@chromium.org Bug: 902938 Change-Id: Ifd06d60a292f0f55e34f3c177c346d79504fde5c Reviewed-on: https://chromium-review.googlesource.com/c/1358648Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#613345}
-
bsheedy authored
Regular roll to the most recent release version. TBR=bajones@chromium.org Change-Id: Icff9d97925cd15670da6f3c38e53416855c31fc9 Reviewed-on: https://chromium-review.googlesource.com/c/1359482Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#613344}
-
François Beaufort authored
This PR makes sure the last video frame stays visible in the PiP window when video ends. This is what <video> elements currently do inline. Bug: 910433 Change-Id: Id6a2065146ca4c76828f3257cd3ee2af7c2eed1b Reviewed-on: https://chromium-review.googlesource.com/c/1356707Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#613343}
-