GitLab

* Update extract_actions.py to scan for metrics specified in the WebUI code.  A common pattern is <input pref="blah" metric="Options_Blah" type="checkbox">.

* Clean up almost all of the existing warnings thrown by extract_actions.py.  There is one remaining use of RecordComputedAction that is a bit too subtle for me to lump into this patch.

* Add a new warning to extract_actions.py that scans for uses of UserMetricsAction with a non-literal string.  Any such uses are going to be missed by the script, and hence should use RecordComputedAction instead.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7314020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95925 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87457
TEST=none

Review URL: http://codereview.chromium.org/7600007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95923 0039d316-1c4b-4281-b951-d872f2087c98

BUG=54942,50481
TEST=none

Review URL: http://codereview.chromium.org/7599002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95919 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87457
TEST=none

Review URL: http://codereview.chromium.org/7598010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95918 0039d316-1c4b-4281-b951-d872f2087c98

Revert overly-wide change in dependency chain.  Now the new build step will only be enabled when the optimizations are turned on.

Review URL: http://codereview.chromium.org/7598008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95916 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95915 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581

Review URL: http://codereview.chromium.org/7598020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95914 0039d316-1c4b-4281-b951-d872f2087c98

Whitespace change: http://codereview.chromium.org/7600002

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/7600001

TBR=jianli@chromium.org

The following tests started to fail (crash) on WK canary with this roll: 2d.path.arc.zero.1.html 2d.path.bezierCurveTo.basic.html 2d.path.bezierCurveTo.shape.html 2d.path.fill.closed.unaffected.html 2d.path.fill.winding.subtract.3.html 2d.path.moveTo.basic.html 2d.path.rect.end.1.html 2d.path.rect.selfintersect.html 2d.path.rect.zero.4.html 2d.path.stroke.prune.arc.html 2d.path.stroke.prune.rect.html 2d.path.stroke.union.html 2d.shadow.canvas.basic.html 2d.shadow.enable.x.html 2d.state.saverestore.globalCompositeOperation.html context.unrecognised.nullsuffix.html canvas-copyPixels.html canvas-drawImage-incomplete.html canvas-fillPath-pattern-shadow.html canvas-font-ex-units-crash.html
Review URL: http://codereview.chromium.org/7600012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95913 0039d316-1c4b-4281-b951-d872f2087c98

This should help reduce confusion on when/whether a sandbox is running.

Review URL: http://codereview.chromium.org/7528013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95912 0039d316-1c4b-4281-b951-d872f2087c98

Change PrintWebViewHelper::PrintPreviewContext to have a PreviewMetafile, removing the need to cast it.

BUG=NONE
TEST=NONE


Review URL: http://codereview.chromium.org/7582014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95911 0039d316-1c4b-4281-b951-d872f2087c98

  * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ .  Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome.
  * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*.  This also allows doing string operations on them.
  * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety.
  * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation).
  * Avoid #define and "using".
  * Use standard algorithms for similar reasons as using string ops.
  * Use file_util functions to significantly abbreviate file reading/writing code.
  * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue).
  * Avoid casting where possible.  Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate.
  * Convert non-error uses of stderr to the chrome-standard VLOG(1).
  * Correctly handle hostnames with trailing dots in the input file.
  * In general, shorten code where possible.

Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly.  It would be nice if we could avoid this but I guess gyp would have to be smarter or something.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7550002

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/7529035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95910 0039d316-1c4b-4281-b951-d872f2087c98

Reverting to make merging next patch into M14 easier.

Added formatting API for browser extension as well as event routing. 
Created a complete UI for formatting.

This code depends on the following changes to libcros:
http://gerrit.chromium.org/gerrit/#change,4446

BUG=chromium-os:4541, chromium-os:17071
TEST=Try to format removable media.


Review URL: http://codereview.chromium.org/7471024

TBR=sidor@chromium.org
Review URL: http://codereview.chromium.org/7599015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95909 0039d316-1c4b-4281-b951-d872f2087c98

R=jhawkins@chromium.org
BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7550053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95908 0039d316-1c4b-4281-b951-d872f2087c98

  * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ .  Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome.
  * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*.  This also allows doing string operations on them.
  * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety.
  * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation).
  * Avoid #define and "using".
  * Use standard algorithms for similar reasons as using string ops.
  * Use file_util functions to significantly abbreviate file reading/writing code.
  * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue).
  * Avoid casting where possible.  Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate.
  * Convert non-error uses of stderr to the chrome-standard VLOG(1).
  * Correctly handle hostnames with trailing dots in the input file.
  * In general, shorten code where possible.

Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly.  It would be nice if we could avoid this but I guess gyp would have to be smarter or something.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7550002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95907 0039d316-1c4b-4281-b951-d872f2087c98

1) Unit tests were incorrectly using TextureInfo
2) GLES2Implementation::TexSubImageImpl was reading 1-7 bytes
   too many.

TEST=ran with Dr.Memory
BUG=91786


Review URL: http://codereview.chromium.org/7541074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95906 0039d316-1c4b-4281-b951-d872f2087c98

This headerfile is required on newer systems.

BUG=none
TEST=print preview works after including the header file.


Review URL: http://codereview.chromium.org/7558008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95905 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/7598012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95902 0039d316-1c4b-4281-b951-d872f2087c98

One of the issues is that a nested event loop in |-mouseDown:| was causing the
thread to block after the menu closes, because the opening of the menu pumps the
mouseUp event.

BUG=91850
TEST=Open a bookmark from the folder and the spinner spins.

Review URL: http://codereview.chromium.org/7528007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95901 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7598006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95900 0039d316-1c4b-4281-b951-d872f2087c98

Now with support for linux views!

Original review URL: http://codereview.chromium.org/7452008

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7553020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95899 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for https://bugs.webkit.org/show_bug.cgi?id=65658 .

BUG=55927
TEST=


Review URL: http://codereview.chromium.org/7566046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95898 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=PanelBrowserTest.FindBar

Review URL: http://codereview.chromium.org/7538010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95897 0039d316-1c4b-4281-b951-d872f2087c98

Found from Coverity CID=16390

R=jam@chromium.org
BUG=
TEST=none


Review URL: http://codereview.chromium.org/7222023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95896 0039d316-1c4b-4281-b951-d872f2087c98

locally), and you can't double-strip with -c. I'll investigate further.
Removing the strip for now.

BUG=91978
TEST=Mac release build


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95895 0039d316-1c4b-4281-b951-d872f2087c98

different path.

BUG=NONE

Review URL: http://codereview.chromium.org/7558006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95894 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7601008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95893 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91978
TEST=none
Review URL: http://codereview.chromium.org/7582032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95892 0039d316-1c4b-4281-b951-d872f2087c98

to try to warm up necessary window creation.

BUG=91452
TEST=none
Review URL: http://codereview.chromium.org/7566024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95891 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91166
TEST=manual

Review URL: http://codereview.chromium.org/7541051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95890 0039d316-1c4b-4281-b951-d872f2087c98

Remove frontend code that allows for dynamic profile setting, and read the profile off the browser where possible.  This matches common practice and various invariants that expect profiles to be constant for the life of the browser.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7574021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95889 0039d316-1c4b-4281-b951-d872f2087c98

OLD:
It looks like you've moved.  Would you like to use http://www.google.de/?  [Yes] [No]

NEW:
Would you like to search with google.de instead of google.fr? [Switch to google.de] [Keep using google.fr] _Learn more_

BUG=85671
TEST=none
Review URL: http://codereview.chromium.org/7578015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91896
TEST=trybots

Review URL: http://codereview.chromium.org/7584033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95884 0039d316-1c4b-4281-b951-d872f2087c98

Landing this change for rogerm@chromium.org, original review at http://codereview.chromium.org/7541080/.

BUG=None
TEST=Incremental linking works again.
Review URL: http://codereview.chromium.org/7106002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95878 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95876 0039d316-1c4b-4281-b951-d872f2087c98

We were not waiting for the file manager extension to initialize its
Web Worker process before starting the test, which lead to occasional
crashes if the test completed before the init was done.

BUG=chromium:89733
TEST=browser_tests --gtest_filter=FileManagerDialogTest.* --gtest_repeat=10 --gtest_shuffle

Review URL: http://codereview.chromium.org/7528003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95875 0039d316-1c4b-4281-b951-d872f2087c98

Whitespace change: http://codereview.chromium.org/7600002

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/7600001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95874 0039d316-1c4b-4281-b951-d872f2087c98

This brings us closer to the most-recent UX request that
I've seen:

- muting displays the previous volume level in a disabled
  state rather than displaying 0%
- volume down while muted drops the level to 0%
- volume up while muted unmutes and raises the level to 25%
  if it was 0% or restores the previous level otherwise

The requested behavior is actually to swell to the louder
volume over three seconds in the volume-up-while-muted case
instead of doing it instantly, but the mixer code doesn't
support that at present, so I'm punting on it for now.

BUG=chromium-os:8473,chromium-os:13618
TEST=manual

Review URL: http://codereview.chromium.org/7566018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95873 0039d316-1c4b-4281-b951-d872f2087c98

This avoids having a nested class Observer in PersonalDataManager.

BUG=None
TEST=None

R=jhawkins@chromium.org

Review URL: http://codereview.chromium.org/7541065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95871 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95870 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
Review URL: http://codereview.chromium.org/7558005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95869 0039d316-1c4b-4281-b951-d872f2087c98