- 18 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fa3d64bf72d6..57f137d71cdf 2020-06-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 763957e6b4fc to 7a1d99d0be42 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I6cfffdc86d76f8b38bc9409763f88c1aeaac1e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251725Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779776}
-
Rohit Rao authored
BUG=None Change-Id: I9d075a81676196ee885e0d7fa9be55b2c4e59bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248728Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#779775}
-
Ewann authored
This CL presents views related to page info using FormSheet. Bug: 1095644 Change-Id: I58f2f2d343a16912f9effb78ff4ad26a42b569a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249778Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#779774}
-
Ewann authored
This CL rephrases the cookies status "Block Third-Party in Incognito" in "Block in Incognito". Bug: 1063824 Change-Id: I550a63a1608c981bd2af30121f4ff5508f653c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251619Reviewed-by:
-
Colin Blundell authored
This CL sets up the infrastructure for private instrumentation tests of WebLayer's infobars and adds an initial test: that addition of an infobar impacts the visual state of the infobar container as expected. BUG=1093846 Change-Id: Id5cdc73f02a4eadb46b3733451541fbd1f796441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247836 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#779772}
-
Friedrich Horschig authored
With larger (or smaller font) the absolute pixel sizes for the spinner change the relative center of the animation which leads to an uneven rotation. To prevent this, the spinner now has a size relative to the font size which is identical for the current size on normal scaling but scales with larger/smaller sizes to keep the animation intact. Since a large/small spinner looks wrong for a static status icon, the icons also scale with the font size to match the spinner (which is not a problem for the vector graphics). Bug: 1096397 Change-Id: Ice9300cafdd2ef4877f28dd08c0a5b432588ddfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250203Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#779771}
-
Saurabh Nijhara authored
As per product requirements of minimum chrome version policy, it is required to show notifications (for update required in case of network limitations and to return the device in case of end-of-life) on login if it is the last day to reach the deadline. Like other notifications of this policy, this notification on sign in is also only applicable to managed users to maintain consistency. This behaviour helps to curb the problem of notification being missed if policy is received when un-managed user is signed in and later a managed user signs in. Only the last day notification is shown on managed user sign in to avoid too much spamming. Bug: 1048607 Change-Id: I01a8d52bbc4a003d5e1323140885881887211176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248567Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#779770}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c6d6e06a5c45..2c9d76a4eb0f 2020-06-18 eshr@google.com Use DataRates in QualityRampUpExperimentHelper If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I508024aa1d86877043bc2e6aa2714a0b582faab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251726Reviewed-by:
-
Austin Tankiang authored
PreferenceWatcher is private to DriveIntegrationService, so there's no point having it be passed in. Bug: 1096355 Change-Id: I753c1c452d6873768f89d25f6737732624cc8b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251268Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#779768}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592459911-c43358934a37f46ea56775cef711f664e7b25ffd.profdata to chrome-win32-master-1592467151-bf53acbeb3a2f5db843a60a3b97cc31d9344243a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I70e7206f3b2e61f72f3e27b116d48bc91b30dd26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251723Reviewed-by:
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I2b34d25846b971723bacb00e495ed219faa02e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249761 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#779766}
-
Anatoliy Potapchuk authored
Bug: 1015383 Change-Id: I271647c5c47b568805ee1623c24823f92574737d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246562 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
-
Ewann authored
This CL adds a footer to cookies settings, explaining to the user how to apply the new cookies setting. Bug: 1063824 Change-Id: Ib683b385115f30f6b46eceb7a30741ca0a0a99d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248563 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
After recent fixes to the underlying blocking bug crbug.com/968222, it's worth giving those test another shot. Bug: 1044038,1054629 Change-Id: Idd2317c028c1cc7bb2ebee0e312c19456be57482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249981Reviewed-by:
-
Benoit Lize authored
PartitionAllocator can be used as the malloc() implementation. In this context, a (D)CHECK() which fires causes allocations, which creates reentrency issues when used inside PartitionAlloc. To avoid that, use PA_(D)CHECK() in base/allocator/partition_allocator/, which is identical to the unprefixed version if PartitionAlloc is not the malloc() implementation. Otherwise it uses simplified versions. This doesn't necessarily cover all the code reached from PartitionAlloc. This is not a correctness issue, as Chrome would still crash when a (D)CHECK() fires, but a debugability one. As a consequence, limiting the changes to the directory (rather than all code called from it) is sufficient. Bug: 998048 Change-Id: I171be3e6bac35cf09a29400c4254adc6f995739b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249739 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#779762}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4ccff505fbf79918af792ac5e9e1f699cfe7f9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251724Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a7112d544b2e..99651228b238 2020-06-17 vasniktel@gmail.com Add RemoveParameter method (#3437) 2020-06-17 vasniktel@gmail.com Fix return type (#3435) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: Ibb9c19488b31b545fec8cc3a1a87441a48fbaef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251469Reviewed-by:
-
Maksim Ivanov authored
Replace the custom handwritten compareBuffers() tool with the commonly used and more bulletproof chrome.test.assertEq(). Bug: 1078761 Change-Id: Ic30bb450f6922a2fa69297cc60010f4661a4c0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246683Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#779759}
-
Victor Hugo Vianna Silva authored
Blacklists that are unsynced at the time a b4p user signs out should not be offered for fallback saving in the profile store. Bug: 1060132 Change-Id: Iac615a525e92f7c60055bfbd00957bb819b6c7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250108Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#779758}
-
Victor Hugo Vianna Silva authored
This CL starts displaying the dialog from crrev.com/c/2248180. Moreover, RemovePasswordBehavior is deprecated. The more elaborate logic of removing different copies of a password can live directly in the dialog, while PasswordsListHandler can use simple logic for the case when a single copy must be removed. In particular, it felt strange that PasswordListItem has this Polymer behavior but never used any of its functionalities (it was PasswordsListHandler that used it instead). We also use the occasion to fix an aspect of crrev.com/c/2235850. If the entry is moved, there's no element to reset the focus to, so the focusWithoutInk() call is removed. The same is done for removal dialog. Bug: 1049141 Change-Id: I06fe35b8bd14ee27873b6a56849e755c02cbc1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246157 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#779757}
-
Koji Ishii authored
|NGLineTruncator| was originally designed to compute and trunate |NGPhysicalTextFragment|. This patch changes it to work on |NGLogicalLineItem| instead. This is yet another effort to reduce the usage of |NGPhysicalTextFragment|, following r778837 and r779021. This saves creating intermediate |NGPhysicalTextFragment| when FragmentItem is enabled, and reduces dependency on |NGPhysicalTextFragment| for the removal when the switch to FragmentItem was completed. Bug: 982194 Change-Id: I3742fa1ea33648e2151f7d3cbf83e977928c6715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230583 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779756}
-
Kent Tamura authored
web_tests depends on third_party/test_fonts since this CL. This CL has no behavior changes in production. Bug: 1082087 Change-Id: Ibe1dde711426c7b0f0ed2dad4b2435e820648dd1 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249272Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Kent Tamura authored
The LayoutNG behavior looks correct with the current ruby architecture. The light-blue box is a child of <rt>, and it should not overlap with the ruby base text. Bug: 1069817 Change-Id: Id6eef5444a5c77a4e55c3451c52cb12d2b0d842d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249214Reviewed-by:
-
Anatoliy Potapchuk authored
This will make us able to create a generic controller to control all kiosks. There is still an issue with arc kiosk though, which will require additional refactoring. Bug: 1015383 Change-Id: I5766a58ca68f623c639115a298d9a0e0338cbe87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245140Reviewed-by:
-
Alex Ilin authored
The information about which call site triggered reauth is needed for tailoring UI strings for specific call sites as well as for metrics recording. This CL only does plumbing from all call sites which already touches many files. Actual usage will be added in following CLs. Bug: 1045515 Change-Id: I85de7fefda83f5bcf2896c5aae153311d812a937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249800 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#779752}
-
Anders Hartvoll Ruud authored
This CL adds: - Parser support for the @scroll-timeline rule itself. - Parser support for the associated descriptors. - A partial CSSOM API for the @scroll-timeline rule. It's currently not possible to add parser support for @scroll-timeline without also adding the CSSOM wrapper, hence this is done in the same CL. Parsing a @scroll-timeline rule emits a StyleRuleScrollTimeline object, whereas the CSSOM API is implemented via CSSScrollTimelineRule, which wraps the StyleRuleScrollTimeline object. Since this CL is big enough already, the following has been postponed to later CLs: - StyleEngine integration. (Adding StyleRuleScrollTimeline to RuleSet, cascading @scroll-timeline rules, etc). - CSSScrollTimelineRule::cssText() (full-rule serialization). Bug: 1074052 Change-Id: Id5a51b3c7c269b852cb2e6de5414db44c710a87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240852 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#779751}
-
Tom Anderson authored
BUG=1066670 R=sky Change-Id: Icb955af0161e3e4b2dbdcd0c283a2aa631c4f799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249389 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
-
Nidhi Jaju authored
Upon investigation of a recent bug reporting the Chrome browser hanging during startup, it was found that ServiceWorkerStorage::GetAll Registrations() is called which may take a considerable amount of time. Hence, by removing this call and just getting Registered Origins instead of all registrations, this issue should be resolved. The call to the ServiceWorkerContextWatcher class was also removed from ServiceWorkerContextWrapper, along with GetAllRegistrations() being replaced with GetRegisteredOrigins(). Bug: 807440 Change-Id: I99ef9895ca28dd5ba8977fe422a3d92099527765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239590 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#779749}
-
Mikel Astiz authored
This logically reverts the old https://codereview.chromium.org/551843003 because meanwhile the Sync Directory has been deprecated in favor of a new codepath, Unified Sync and Storage (USS). Change-Id: I80e66c304b76a8d9edffe1a4657ba0c2513f2ff4 Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250042Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ae1892d4e4ce..c6d6e06a5c45 2020-06-18 nisse@webrtc.org Delete OpaqueTransportParameters and SDP attribute x-otp 2020-06-18 deadbeef@webrtc.org Disable SCTP asconf and auth extensions. 2020-06-17 mbonadei@webrtc.org Remove //tools_webrtc/sancov. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I428362d3fba349b961f4ee515c06c3f7d5beef04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251175Reviewed-by:
-
Michael Ershov authored
Compare public key inside the certificate and public key from key pair to make sure that they are the same and certificate was issued for the expected key pair. Bug: 1045895 Test: CertProvisioning* Change-Id: I37a72a8b1c39e424782826f6ba278365af4c4b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246687Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#779746}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/22e7befe144d..22b0828640fb 2020-06-18 cbruni@chromium.org Revert "Avoid UpdateTrafficSettings when possible" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: Ic55014c0911d3be0c47ec37e3267860f2d7d9810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251718Reviewed-by:
-
Karandeep Bhatia authored
Currently a *compromised* web renderer can request any extension resource from an extension that has web accessible resources (WAR). This was necessary earlier since: - extension iframes didn't always live in the extension process when embedded in a website. - We needed to allow extension subresource requests from such iframes. These subresources didn't need to be web accessible. - This meant that the browser needed to allow cross renderer requests to such resources. - Hence as a compromise, at the browser level we allowlisted any cross renderer subresource request to an extension with WAR. However, now extension iframes should always have their own process. Hence the browser side check can be made more strict to disallow cross renderer requests to non web accessible resources. Note that we already block access to non web accessible extension resources at the renderer level. BUG=1093570, 179127, 173688. Change-Id: I20523db2d1629f3714d3c84a27e0904ed4f1b27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244433 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#779744}
-
Victor Hugo Vianna Silva authored
For a b4p user, in case some password has copies attached both to the device and the Google Account, attempting to delete it should show a dialog that allows selecting which copies to remove. This CL implements this dialog but does not yet wire it in. Some details in the UI are left for future CLs, such as the user avatar and displaying the website associated with the password to be deleted. Note RemovePasswordBehavior is not used here, for reasons that are better explained in crrev.com/c/2246157. Screenshot of implementation: https://screenshot.googleplex.com/hZnTiuy80tL Screenshot of mock: https://screenshot.googleplex.com/pGV0iMTQBxw Bug: 1049141 Change-Id: I50ca0e5bfc99dbc76c12c345c00f82788bbc377c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248180 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit b1d0fc82. Reason for revert: failures of AssistiveWindowControllerTest https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests?limit=200 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/19523?blamelist=1#blamelist-tab Original change's description: > Use SuggestionDetails struct for showing suggestion > > In preparation for adding show_setting_link param for personal info > suggestion. > > Bug: 1094267 > Change-Id: Id9e4a5d5de335613df93bf80142a3df8bb564fd0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243073 > Commit-Queue: My Nguyen <myy@chromium.org> > Reviewed-by: Keith Lee <keithlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779566} TBR=keithlee@chromium.org,curtismcmullan@chromium.org,myy@chromium.org Change-Id: I66864faf4aac2f9c8ad10ecc22eba71b32005750 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1094267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250107Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#779742}
-
Maxim Kolosovskiy authored
This reverts commit bd23dace. Reason for revert: in order to resolve merge conflict for https://chromium-review.googlesource.com/c/chromium/src/+/2250107 Original change's description: > Add preference for personal info suggester showing setting link > > Should stop showing setting link after showing 10 times or when user > have accepted it. > > See: http://go/personal-info-setting-link > > Bug: 1094267 > Change-Id: I9d9c5f09aa77f56445722c5fd626a8caaa04da7d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245583 > Commit-Queue: My Nguyen <myy@chromium.org> > Reviewed-by: Jing Wang <jiwan@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779602} TBR=shend@chromium.org,myy@chromium.org,jiwan@chromium.org Change-Id: If873508473e418a2c9fd93d2b31fd47d05aa902b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1094267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250253Reviewed-by:
-
David Roger authored
The parameter has changed on the Gaia server from mlreuse to reuseCookies. Fixed: 1072463 Change-Id: I5d1d889b14c3229f55d1638dbb4f2f07bc7622df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249958Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#779740}
-
Benoit Lize authored
ParkableStrings can be written out to disk, but this is not always the case, as writing is disabled in several cases: - When the renderer's associated profile is an incognito one - When the browser failed to open the file - When writing failed at some point Capture the frequency of these events in a histogram. This requires making the feature accessible to blink, so it moves from content to blink. Bug: 1029320 Change-Id: I671db1e92fcabc24c383551621ef93febd197cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249858Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#779739}
-
Maxim Kolosovskiy authored
This reverts commit 676d0cb1. Reason for revert: reverting this CL to resolve merge conflicts to land https://chromium-review.googlesource.com/c/chromium/src/+/2250202 TBR=avi@chromium.org,fdoray@chromium.org Change-Id: I2ab86f1980fa5fb905c03349252c5a440abe3f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249930 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 7eab011b. Reason for revert: AmbientControllerTest failures https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg?limit=200 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19204?blamelist=1#blamelist-tab Original change's description: > ambient: container logic refactoring [part 1]. > > This CL is splitted from the original CL: > https://chromium-review.googlesource.com/c/chromium/src/+/2199870 > with all files changed on ambient/. side. > > Bug: b/156531168 > Test: unittests. > Change-Id: I4f84277c74c95419ac96e6cfaaa48081c407b243 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248878 > Commit-Queue: Meilin Wang <meilinw@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779664} TBR=xiyuan@chromium.org,xiaohuic@chromium.org,wutao@chromium.org,meilinw@chromium.org Change-Id: Ia9eaa3e0d856c7dabf2526c3566fa35cf415e17c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/156531168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250602Reviewed-by:
-
