- 19 May, 2020 40 commits
-
-
Joe Downing authored
I originally fixed these as part of a different CL but that change turned out to be unnecessary due to my change last week to cleanly close the PeerConnection. So here is a super-minor clean-up CL that fixes some comments. Change-Id: I588239e74f341d87a2468d7d47eccb00161fb5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208091 Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#769970}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/ca609c305ed1..763905cc6884 git log ca609c305ed1..763905cc6884 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 rwkeane@google.com Code Coverage: Add missing buildbot config Created with: gclient setdep -r src/third_party/openscreen/src@763905cc6884 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I36ed0d1538c473889fb42ac54e3a943ddebe50a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208452Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769969}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c4fb1974191f..e67e41aa8994 git log c4fb1974191f..e67e41aa8994 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@e67e41aa8994 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I9aa0d705414ff873b0d6946a87e8bb54d1f50ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208451Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d136b6ae..36aad447 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieee40203f8fbcb98722738b2d52c0c5834808817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206919Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769967}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3aab09d9c915..1c8cab8f9441 Created with: gclient setdep -r src-internal@1c8cab8f9441 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shend@google.com Change-Id: I46196649f4348308b213f9315fc60d3c160dea69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208200Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769966}
-
Eric Willigers authored
This CL is in preparation for enabling the Bookmark Apps without Extensions (BMO) flag "DesktopPWAsWithoutExtensions", to maximize time on Canary. Each unit test that does not yet pass with the DesktopPWAsWithoutExtensions flag enabled is parameterized and a TODO is added. We will work over the next few weeks to update these unit tests, or their test intrastructure, so they pass with the flag enabled. Bug: 877898 Change-Id: I1835b78c12429d2372377b609ae9b7d187aec695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206298 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#769965}
-
Dominic Mazzoni authored
The goal is that when we enable kEnableAccessibilityExposeHTMLElement, relatively few tests will be affected. In this tests, there was an assumption about nodes being an immediate child of the root element. Bug: 1063155 Change-Id: I5c906ac6a518755b48cefd12a6e3bef7b2c59aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206225Reviewed-by:
Chris Hall <chrishall@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#769964}
-
Hiroki Sato authored
Bug: None Test: git cl lint Change-Id: I52cc6c0c8191417f394e03e971a31c594cd424e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206140Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#769963}
-
Chong Gu authored
Allow skipping specific tests that aren't supported on Fuchsia. Remove the logic for supports_swiftshader in gpu_process tests, since we only run those tests on platforms that support swiftshader. Bug: 1058255 Change-Id: I423a376ef9c25bd36ed39349399a9d327e425683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207939Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#769962}
-
Hui Yingst authored
Bug: 1039520 Change-Id: I34c324b776b0248a907f45d1a74b5d72d3cb59cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203151 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#769961}
-
David Munro authored
Bug: chromium:1084374 Test: Manual, deploy and look for yellow colour. Change-Id: I870d458dd7ca179cea0a6b5317fd1c04613fbcb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208330 Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#769960}
-
danielng authored
Always forwarding ports on wlan0 isn't ideal, this commit makes it so that ports are forwarded on the interface of the highest priority network. It makes use of network handler, to ensure it is only looking at physical networks/devices and trusts the prioritization used there. Bug: 848127 Tests: Manual testing with eth, wlan, tether and VPN networks. Change-Id: Iabd15c717b3cc7792fa39909c2f34809d4aeac89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200303 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#769959}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dbcf680f8fd3..98bc22c68981 git log dbcf680f8fd3..98bc22c68981 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 reed@google.com add fontmetrics to custom typeface Created with: gclient setdep -r src/third_party/skia@98bc22c68981 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I5d8adc4c1f628fe3700e7506dec01b1cf3e4df5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208203Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/24dcbd1b1f68..0ab78114a9e1 git log 24dcbd1b1f68..0ab78114a9e1 --date=short --first-parent --format='%ad %ae %s' 2020-05-18 laddoc@outlook.com Add check for DOUBLE in low versions (#2223) 2020-05-18 greg@lunarg.com Flatten all interface variables (#2217) 2020-05-18 cepheus@frii.com Bump version. Created with: gclient setdep -r src/third_party/glslang/src@0ab78114a9e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I34180d1f6ec67df3ded3e3a00c196404498cc2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206894Reviewed-by:
-
Aaron Colwell authored
There are several tests that were implicitly making assumptions about lock URLs and didn't really need to have those details. This change has a variety of lock URL related changes that make tests less dependent on the actual implementation of process locks and fixes a few cases where site URLs were being used as lock URLs. Bug: 1015882 Change-Id: Iad9304cd7464a3cddbff61d72c33a707cde5081b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196858 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#769956}
-
Avi Drissman authored
The fallback task provider triggers and provides a task for a render process if the render process has a service worker in it but no tabs. Add the ability for the fallback task provider to fall back for a collection of providers, not just one. Use that to fall back for both the tabs and the workers. Bug: 1083664 Change-Id: Ia7d9d0248fb40df3c25c43ec2bcd915f78c159ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204363 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#769955}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2af35ab984e3..ef93a2618066 git log 2af35ab984e3..ef93a2618066 --date=short --first-parent --format='%ad %ae %s' 2020-05-18 handellm@webrtc.org RtpVideoStreamReceiver::RtcpFeedbackBuffer: remove lock recursions. Created with: gclient setdep -r src/third_party/webrtc@ef93a2618066 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9578ca2de72d65de9f81faa1eaa864e5c6d744b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208199Reviewed-by:
-
Hirokazu Honda authored
This retrofits DecoderBufferValidator to video_encode_accelerator_tests. It inherits DecoderBufferProcessor and validates a bitstream by parsing it and check some compressed info (e.g. visible rectangle and profile) are expected. Bug: 1045825 Test: vea_tests on eve Change-Id: I33d324ae647e5199144a9910e5f699af831222a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109577Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#769953}
-
Miyoung Shin authored
WebViewPlugin didn't have the implementation of blink::mojo::WidgetHost, it was able to access the null pointer access when the mouse pointer is moved to on the plugin view, so this CL implements blink::mojo::WidgetHost in WebViewPlugin and adds WebWidget::GetTooltipText for the web test. Fuzzer report: https://clusterfuzz.com/testcase?key=5128177771413504 Bug: 1081999, 1082648 Change-Id: Ia24d71b687850d796bff02bcca496dc04217c17d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198517Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#769952}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I072bf5ae65b0b69db8f725c86ac9e6ca179183d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208270 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#769951}
-
Ye Kuang authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/160b445a44e0..7e8636295f47 $ git log 160b445a4..7e8636295 --date=short --no-merges --format='%ad %ae %s' 2020-05-18 tikuta Revert "Reland "client: enable go isolated on every platform"" 2020-05-15 yekuang client: update isolated client 2020-05-14 tikuta Reland "client: enable go isolated on every platform" 2020-05-14 tikuta client: update isolated client 2020-05-14 tikuta Revert "client: enable go isolated on every platform" 2020-05-13 tikuta client: enable go isolated on every platform 2020-05-13 tikuta client: update isolated client 2020-05-13 yekuang Make swarming client python3 compatible enough so that it can be ported to google3 2020-05-13 yekuang client: update isolated client 2020-05-12 tikuta client: enable report on exception in run_isolated on bot 2020-05-11 tikuta client: remove _ENABLED_DOMAINS 2020-05-11 tikuta client: remove report_on_exception_exit from client 2020-05-08 yekuang client: update isolated client 2020-05-08 tikuta client: report exception in archive_files_to_storage 2020-05-07 yekuang client: update isolated client 2020-04-30 tikuta client: update urllib3 to 1.25.8 2020-04-30 tikuta client/third_party: update requests to 2.23 2020-04-30 tikuta client/third_party: update readme for requests 2020-04-30 tikuta client/third_party: add license header in urllib3/update.sh 2020-04-30 tikuta client/third_party: update readme for urllib3 2020-04-28 tikuta client: log when TimeoutExpired is thrown 2020-04-28 tikuta client: implement retry for archive_files_to_storage 2020-04-27 tikuta subprocess42: replace gid with pgid 2020-04-24 tikuta client: include full stack formatted stack trace 2020-04-24 tikuta client: fix format string in ValueError 2020-04-23 jwata [client] git cl format --pytnon 2020-04-23 tikuta client: fix AttributeError 2020-04-23 tikuta client: log items when failed to verify uploaded files 2020-04-22 tikuta client: update isolated client 2020-04-22 yekuang [swarming] Add UserAgent to run_isolated.py 2020-04-21 tikuta Revert "client: send exception from run_isolated to error reporting" 2020-04-21 tikuta client: send exception from run_isolated to error reporting 2020-04-21 tikuta client: reset push_state when failed to verify 2020-04-21 tikuta client: remove unnecessary conditonal base64 decode 2020-04-21 tikuta client: add test for uploaded file verification 2020-04-21 tikuta client: make fake server more compatible to real server 2020-04-20 tikuta client: use logging.exception to show exception 2020-04-20 tikuta client: store content only when valid in fake server 2020-04-17 tikuta client: report exception for error from map_and_run 2020-04-16 nodir [resultdb] Update LUCI_CONTEXT.md 2020-04-15 tikuta client: update isolated client Created with: roll-dep src/tools/swarming_client Bug: 1074756 Change-Id: I7b2148e6572d6b73ac7260ce618aab8923232232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206857 Commit-Queue: Ye Kuang <yekuang@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Ye Kuang <yekuang@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#769950}
-
David Lechner authored
After deprecating the previous implementation, we need to create a new implementation that allows selecting write with or without response. The new implementation is simply a copy of the deprecated implementation with the following changes: - An enum WriteType parameter is added to select with or without response. - All GATT characteristic property checks are removed and the new enum parameter is used to select the write type instead. - Additional write flags parameters are added to the platform-specific backends as needed. - For most platforms, these are just bit flags/enums. - For BlueZ, this is a string. - On the "win" backend, the part that depends on the characteristic property was moved to the DeprecatedWriteRemoteCharacteristic method since it would otherwise interfere with the new implementation. - On the "cast" backend, we are able to use the existing WriteAuth method without additional modification. Likewise, the new unit tests are just a copy of the same unit tests that call the DeprecatedWriteRemoteCharacteristic method. The new tests have been modified to try to avoid using base::RunLoop::RunUntilIdle. Bug: 672648 Change-Id: I7958d9e6d3fd285695091fe3220b3d2fce45c641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191232 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:Vincent Scheib <scheib@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#769949}
-
David Benjamin authored
This uses a BoringSSL abstraction for reading things like /proc/cpuinfo or opening /dev/urandom ahead of time. Rather than using RAND_set_urandom_fd to pass the //base copy of /dev/urandom to BoringSSL, we ask BoringSSL to open it internally (which it may not need at all if the system supports getrandom). This also means we may later be able to have base::RandBytes call into BoringSSL and pick up getrandom, etc., support. See https://boringssl.googlesource.com/boringssl/+/HEAD/SANDBOXING.md Change-Id: I7c9160fb76a5f20a360974408605f2f8438ae177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203227Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#769948}
-
Li Lin authored
Instead of always showing the Quick Answers view when user bring up context menu, we would like to only show the UI if the predicted user intent (based on text annotation result) is supported. Bug: 1082984 Test: manual tests Change-Id: Icf47b70bae4bf7ca5a46fe798f11aaaacb205017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203541Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#769947}
-
Vadim Bendebury authored
We sure want to keep collection this metric. BUG=chromium:1084047 TEST=none Change-Id: Id32327dfce4d2a76bf62b2d14797bc8ec3b4bf5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207955 Auto-Submit: Vadim Bendebury <vbendeb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#769946}
-
Kenichi Ishibashi authored
We still check these UMAs. Bug: 1084052 Change-Id: I5bf7433c4193dc022427785c5459cdd49589a259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208013Reviewed-by:
-
Toni Barzic authored
UpdateClientImpl DCHECKs that it's destructed only if list of pending tasks is empty. Tasks have a callback bound to a update client reference, and the UpdateClient keeps a references to pending update tasks, so this should generally be true, but TaskUpdate invokes the callback by posting it to a task runner, which moves the callback (and a UpdateClientImpl reference) ownership to the task runner itself. If Chrome shutsdown while the callback task is scheduled on the task runner, the UpdateClientImpl will be deleted with the callback during task runner tear-down, before the callback is run. Also, fixes a task instance was referencing a callback bound to unretained UpdateClientImpl, thus not keeping UpdateClient alive. BUG=1079241 Change-Id: I6f6c81c9011ede03806362fd5cf52a3f36b36cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205326Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#769944}
-
Yichen Zhou authored
Add histograms for tab dragging in clamshell mode. Bug: 1032766 Change-Id: I33b9a39598ff06aa2c343a86e5e2effa79523d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199501 Commit-Queue: Yichen Zhou <yichenz@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#769943}
-
David Tseng authored
Bug: 1084359 Change-Id: I4d81939f0425e41cc4bf7747b04fac4dcbd8d349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208076 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#769942}
-
Hirokazu Honda authored
There is no way to specify codec profile that VideoEncodeAccelerator must produce in video_encode_accelerator_tests. This adds the command line option to specify it. Bug: 1045825 Test: video_encode_accelerator_tests on eve Change-Id: Iaaea9443abac4d6e1d6dd0ad8950538ea90185f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203556Reviewed-by:
-
Kelvin Jiang authored
This CL adds priority checking between matching modifyHeaders and allow/ allowAllRequests rules in an extension. Currently, if there is a matching allow/allowAllRequests rule, it will override any removeHeaders rules since removeHeaders rules don't have priority. Since modifyHeaders rules have priority, within an extension, the matching allow/allowAllRequests rule with the highest priority should override modifyHeaders rules with equal or lesser priority. Bug: 947591 Change-Id: Ifc8e4e18ea1d33811d4458574e474603cea44461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172640 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#769940}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3a999dcd95fd..4e79dd6ea5f3 git log 3a999dcd95fd..4e79dd6ea5f3 --date=short --first-parent --format='%ad %ae %s' 2020-05-18 michael.liao@microsoft.com [Network Project]: Failing failure when attributionInfo is undefined Created with: gclient setdep -r src/third_party/devtools-frontend/src@4e79dd6ea5f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1082944 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If9a5e138f65e777b33af46fcce726a5a45f44746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208192Reviewed-by:
-
Sinan Sahin authored
AutofillAssistantCollectUserDataIntegrationTest#testEnterPayment AutofillAssistantPersonalDataManagerTest#testCreateAndEditProfileMultipleTimes TBR=marianfe,sandromaggi Bug: 1084324, 1084191 Change-Id: I3ca3cfc4479e59d5653c4387f9ed04c3e348682f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208253Reviewed-by:
Sinan Sahin <sinansahin@google.com> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#769938}
-
Maggie Chen authored
TBR=kbr@chromium.org Bug: angleproject:4641 Change-Id: Ibc556e198ed1f12874a30bb4d4f8293ae5835ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208350Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#769937}
-
Natalie Chouinard authored
Remove workaround no longer needed due to K deprecation. Update documentation based on linked bug's current status. Bug: 1009058 Change-Id: I7cd585108d543d13158101a74b4cc5e78cbc34d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207626 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#769936}
-
Alexander Cooper authored
Updates the expiration date for a still-useful and in-use webxr metric by 1 year (per guidance for metrics that seem like they'll be useful indefinitely). Additionally, marks one metric that has already been removed from code as obsolete. Finally, replaces cassew@ with alcooper@ as owner for VR metrics, since cassew@ no longer works on VR. FIXED: 1084129,1084126 Change-Id: Ied4b89d9cef8a8bb95f83b579b5855d2efcc8e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208083 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I18f0d149fdc083547b950f2cf7d998174df99dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208193Reviewed-by:
-
Charlene Yan authored
This makes collapse looks slightly more useful. Without this the underline make the tab group still look not collapsed. This will need more work to spec, but thought it was a nice update. Bug: 1018230 Change-Id: I22343f34aea7d9f42e2a1cfd8205643973e50686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207504 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#769933}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/275a95c1dc64..e25ee25e7743 git log 275a95c1dc64..e25ee25e7743 --date=short --first-parent --format='%ad %ae %s' 2020-05-18 bryan.bernhart@intel.com D3D12: De-duplicate sampler heap allocations. Created with: gclient setdep -r src/third_party/dawn@e25ee25e7743 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ibcb65bf3d1c8dd129112218e9ad08a336e9c5127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208190Reviewed-by:
-
Jon Mann authored
Change-Id: Ic8739fb31e786fb31f3e87ebc90a4b04d93691d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207622Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#769931}
-
