- 29 May, 2020 40 commits
-
-
Saurabh Nijhara authored
Bug: 1064271 Change-Id: I731e7b85cafaefb9b71a1cffba177fce99a30a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181388 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773139}
-
Matthias Körber authored
A recent change caused a regression in the filling of credit card numbers when a second wrongly detected credit card number field was detected in a form before the actual credit card number field. Change-Id: Ic3b95e5177ce3a8adbd82f51cd9e4a6c444e89b4 Bug: 1086991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219947Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#773138}
-
Rohit Rao authored
These APIs were deprecated starting in iOS 13, but the replacements are not available on iOS 12. This CL uses compile guards to call the new APIs when compiling with a min_deployment_target of 13.0+, or the old APIs otherwise. BUG=1086653 Change-Id: I0d784f8e41b56088669a0429685eb5f0cbef001e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220278Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773137}
-
Denis Kuznetsov authored
Bug: 1073095 Change-Id: I0f54e981ad14d6d446f39e0cf2fd01a703027b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218120Reviewed-by:
-
Avi Drissman authored
When putting passwords onto the clipboard, tag them as confidential. Bug: 1067542, 1084244, 1071828 Change-Id: I9de97ba615fc6496366af9af65a0c6f186a03945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216329Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
-
Colin Blundell authored
This CL changes WebLayer's intent launching logic to match that of CCT in the specific case of an http(s) URL with a non-default external handler. In this case CCT overrides ExternalNavigationHandler's default behavior of showing the intent picker to instead keep the navigation in the app. It is desired that WebLayer precisely match CCT here. The implementation is adapted from that in //chrome's CustomTabDelegateFactory. A couple notes: - Unlike //chrome, in //weblayer the check for whether the app has a default handler does not bother to exclude the embedder of WebLayer. The reason is that WebLayer is not embedded in apps that handle incoming intents. - The special-casing of the intent being for the client of CCT at [1] has no analogue in WebLayer (again, because WebLayer is not embedded in apps that handle incoming intents). Thus, there is no such corresponding check in WebLayer. To test: - Install the booking.com app on your device - Search for "hotel booking paris" in Google on WebLayer Shell - Click on the ad for booking.com that should result at the top - Observe that the booking.com app is launched - Via Android Settings, configure the booking.com's handling of support URLs to be "ask every time" - Repeat the above search in WebLayer Shell and observe that the navigation to booking.com stays in WebLayer Shell [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java;l=119?q=CustomTabDelegateFactory&ss=chromium&originalUrl=https:%2F%2Fcs.chromium.org%2F Bug: 1085405 Change-Id: I2bec60967c5c2ef1638a927a33f7e21ba93ae58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219494 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#773134}
-
Olga Sharonova authored
This reverts commit 002510a0. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1087807 Bug: 1087807, 623268 Original change's description: > Fix the http/tests/devtools/inspect-iframe-from-different-domain.js test > > This test wants to verify devtools inspect works with an iframe in > another domain. It was putting the iframe in another site, which causes > it to become detached from the local root in site isolation. Instead, > put both the main frame and iframe into the example.test domain, with > the iframe in a subdomain. > > This test was originally added for webkit bug 31587 which is found at > https://bugs.webkit.org/show_bug.cgi?id=31587. > > It said: > > If you try to inspect elements located inside an IFRAME that was > > loaded from a different domain, not satisfying the same origin > > policy, Web Inpector in recent WebKit nightly builds cannot show > > style information. Works in Safari 4.0.4. > > R=yangguo@chromium.org > > Bug: 623268 > Change-Id: I842bf835e49ee79e60e423fd36a5d3cedb8a8cfa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218765 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772743} TBR=danakj@chromium.org,caseq@chromium.org,yangguo@chromium.org Change-Id: I0555399e579bf5a1976e53b0fa419d9aa04a6c2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 623268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218025Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#773133}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/980e0c16b911..f026592a6611 2020-05-29 landrey@webrtc.org Add HEVC codec name. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icf16ab3136bd34b04becfe69fafc155292cc02a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220824Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773132}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7b165971aa48..364d64319c41 2020-05-29 janscheffler@chromium.org Clear cookie preview when deleting cookies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3b500ce7ece34f14ee69bb85226864779a276425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220822Reviewed-by:
-
Etienne Bergeron authored
This CL is adding a unittest that ensures GetTextDirection(...) and GetDisplayTextDirection(...) are invalidated when changing the directionality mode. R=msw@chromium.org Bug: 1025561 Change-Id: Ieb6f6c0bca2803614a89a48a3e0b3d906a790e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220071 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#773130}
-
Mirko Bonadei authored
WebRTC doesn't use gclient_args.gni, this CL adds the possibility to override the value of "checkout_google_benchmark" with another override method (//build_overrides/build.gni). Bug: None Change-Id: If6e6cd9b9cbeb82d96e7c5b578347884e0c84607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218024Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#773129}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id8d4b78c27e58f127a2bbc4484992c0e7c0a4125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222118Reviewed-by:
-
Ehimare Okoyomon authored
Refactored the page info v2 sections for these components into their own controllers. More functionality for subpages will be added later. Bug: 1077766 Change-Id: I91e74844f8743a3774d6b7f0fb37308b9bf50f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213580 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#773127}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/48a6bcf4f11e..15a98af79295 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC olka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: olka@google.com Change-Id: I305b3bc08b517ff5b7c1f3e4fe0f0ee5ae26717a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220821Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773126}
-
James Cook authored
The sync consent screen is skipped for non-branded (e.g. developer) builds. We need to do this check after the check for non-GAIA and public accounts, otherwise we try to enable sync for account types that don't have an IdentityManager primary account. This fixes DCHECK failures on account_id in Active Directory and device local account tests. This CL also adds an explicit sync consent screen test for Active Directory accounts, because it took me a while to figure out why unrelated AD tests were failing in sync consent code. Bug: 1060289 Change-Id: Ief0b78ae6869349993b4427226af625591d827f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211181 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iecbfab03f5bf9594c65b6fbf55194d8660f8abf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222117Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a869b729..259d8f40 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I016bcf5e56fbc3d4be728995ae4729fd81d4c8d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218395Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773123}
-
Etienne Bergeron authored
This CL replace the fixed size vector used to store the text style by a std::array which is by default fixed size. The goal is to statically ensures the size of the vector. R=pkasting@chromium.org Bug: 1025561 Change-Id: I773897545adb34680cf62ece1594f03617d2e262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220074 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#773122}
-
Mark Brand authored
Adds mojo/tools/fuzzers/mojom.gni which has a template rule that wraps most of the build-file mechanics necessary to build fuzzer targets using MojoLPM, and adds pipe date size limits to the MojoLPM data pipe implementations to prevent fuzzers from OOMing so easily. In order to make the mojolpm_fuzzer_target work, it needs to fix handling for testonly in a couple of places: - adding testonly propagation to protoc_convert. - adding testonly to seed_corpus copy rule. Bug: 1076336 Change-Id: Ib6b2efbe533151e28c3ef26593ac0dc322725770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172079 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#773121}
-
sandromaggi authored
The Autofill Assistant now handles back button clicks by removing its UI and stopping. Bug: b/152954282 Change-Id: I9c86d45c58b036147c5d729801faae2484068fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207177 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#773120}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590724612-5db2101d2a61d33e1335d92c89441aeea9c7ea20.profdata to chrome-win64-master-1590739125-6c79d7b2f103e2693202dab38de41a1a724cbc3e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I37d54dbd5d59650d17ead1c5fb3737674a0db8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222310Reviewed-by:
-
Patrick To authored
When initializing the GPUInfo of each GPU on the computer, also include the LUID. A LUID is needed to uniquely identify a GPU adapter. The vendor ID and device ID is not sufficient because device IDs are unique only relative to the vendor ID, not to each other. If a computer has two of the same exact GPU, they will have the same vendor ID and device ID, but different LUIDs. This change is one part of a series of changes to add multi-GPU support for VR. This code was originally reviewed as part of a larger CL here: https://chromium-review.googlesource.com/c/chromium/src/+/2096778 However, that change is being split into smaller pieces to facilitate code review and landing. The other parts of the split will be put up within a few days. Bug: 792657 Change-Id: I4821e2d1317caf335add61b16a9adc7e0d08a41b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216166Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#773118}
-
Mikel Astiz authored
Most sync integration tests don't need to wait until history loads. It slows down the tests, and in fact runs into timeouts on some platforms. Instead, let's rely on tests themselves being robust enough to handle history initialization, and if that's not the case they should explicitly wait until history loads. Change-Id: Iaf06c3055c21eed0b4502559450bdbf5726bb88e Bug: 1086829,1049597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218022 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#773117}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/45b9192ad981..980e0c16b911 2020-05-29 handellm@webrtc.org VideoSendStreamTest: remove lock recursions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9aba055ed50745135c933537607f829aa3652940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222314Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/33004b09f180..b41baa411329 2020-05-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from afe55126be2d to 3c5bad0911e3 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I48c0993d557827ade40b5ea0310372169d86ad00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222306Reviewed-by:
-
Joel Hockey authored
This reverts commit 6fce9dc3. Reason for revert: Relanding with fix Original change's description: > Revert "Refactor crostini use CrostiniId rather than vm_name, container_name" > > This reverts commit 3984e14d. > > Reason for revert: CrostiniManagerRestartTest.RestartMultipleThenUninstall crashing on https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg > > first failure https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/18909 > > crash log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878996586056266096/+/steps/unit_tests/0/logs/Deterministic_failure:_CrostiniManagerRestartTest.RestartMultipleThenUninstall__status_CRASH_/0 > > Original change's description: > > Refactor crostini use CrostiniId rather than vm_name, container_name > > > > Refactor only change. > > > > Change places where vm_name and container_name are being used in a > > function to use ContainerId, and particularly ContainerId::GetDefault. > > > > TBR=haraken@chromium.org > > > > Bug: 846190 > > Change-Id: Iaa545c750aa979cceff74c87e89ef4bd21867f4f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220106 > > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > > Commit-Queue: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Julian Watson <juwa@google.com> > > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#773035} > > TBR=haraken@chromium.org,joelhockey@chromium.org,juwa@google.com > > Change-Id: I8bc3d9e68df869fc19c04381d4d013fe6ef4f7b3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 846190 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218313 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773085} TBR=haraken@chromium.org,olka@chromium.org,joelhockey@chromium.org,juwa@google.com Bug: 846190 Change-Id: I4597e0d01cd8c9f9b2d5bb94591b1c1c2f404741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222084Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#773114}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 169c3365. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I903f871cbf5eb9bdb03897830e98c93678db523a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218813Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773113}
-
Maksim Ivanov authored
Fix the policy_fuzzer to use the new accessor interface of the PolicyMap::Entry class. Bug: 1083984 Change-Id: I0dae1ac3ecc39ca4cab89ffc937dd4081e077580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218316 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#773112}
-
Victor Hugo Vianna Silva authored
This CL uses the previously introduced frontendId field to deduplicate entries across stores in chrome://settings/passwords. Bug: 1049141 Change-Id: I295a92a0525db80cae6e57551a0cf0bab34fdbbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219503Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#773111}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fcef4e406f7d..7b165971aa48 2020-05-29 janscheffler@chromium.org Reenable test for layers panel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1053901,chromium:1076763 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0552f988b9ddd76ba3750211f23ea3346d623e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222312Reviewed-by:
-
Olga Sharonova authored
This reverts commit 4b053da1. Reason for revert: breaks the build https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878975239685380208/+/steps/compile/0/stdout Original change's description: > [Fuchsia] Add WebGL MSAA to the allowed list for WebEngine > > Now webgl-antialiasing-mode and webgl-msaa-sample-count can be > specified in WebEngine config. This will allow to control MSAA support > when using WebGL. > > Bug: 766360 > Change-Id: If325bedefb31c1c960868563bcf223ba0bc88999 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220865 > Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773101} TBR=reveman@chromium.org,wez@chromium.org,sergeyu@chromium.org Change-Id: Ifb1e0fa7717e14424dce62a93b81602adca09435 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 766360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218317Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a075151a2121..5666031c614c 2020-05-29 hjd@google.com Merge "trace_processor: Fix layout track" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I224be11f1c1b8150341fcdf77f8c4dfb9a3567fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222311Reviewed-by:
-
Tomasz Moniuszko authored
With the feature disabled, MediaHistoryKeyedServiceFactory instance is not created in ChromeBrowserMainExtraPartsProfiles:: EnsureBrowserContextKeyedServiceFactoriesBuilt() and thus dependency graph is incomplete. Creating MediaHistoryKeyedService on clearing browsing data can lead to crashes on keyed services shutdown for profile. Bug: 1064755 Change-Id: I883b98db96fcd7ce6f0445b296342d529cb038af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218121 Auto-Submit: Tomasz Moniuszko <tmoniuszko@opera.com> Reviewed-by: -
Andrew Walbran authored
Often not all the buttons and axes between 0 and buttons_length / axes_length are actually used. This change adds some fields to keep track of which ones are used. This is necessary in some cases to determine which mapping is appropriate. Also fixes a bug where special buttons might not be counted towards the buttons_length on Windows. BUG=1073130 Change-Id: I9f69b7bc9f68e124b5682588af22a135ed8964a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216510Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Andrew Walbran <qwandor@google.com> Cr-Commit-Position: refs/heads/master@{#773106}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590724612-c1421d9824c914ff15feb610fd2b028bed82b9e1.profdata to chrome-mac-master-1590739125-30ac6fa847343d316264eb803765e7acf0a7e6c1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3b54b3601d93e69ee50e5b370c75654abdc54640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222309Reviewed-by:
-
Kenichi Ishibashi authored
This CL adds the following mojo wrappers ServiceWorkerStorage operations: * StoreUncommittedResourceId() * DoomUncommittedResources() Bug: 1055677 Change-Id: I09e8086aa4ebed3930ed41137d578126af266c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220129 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773104}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d95366028fd0..48a6bcf4f11e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC olka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:996088 Tbr: olka@google.com Change-Id: I80a37bd094435985ce9871079d84af023c8e9c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222302Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/14aed087..a869b729 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9ac1a40260e7cccdd9b39fb04277f35997d2a602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218394Reviewed-by:
-
Sergey Ulanov authored
Now webgl-antialiasing-mode and webgl-msaa-sample-count can be specified in WebEngine config. This will allow to control MSAA support when using WebGL. Bug: 766360 Change-Id: If325bedefb31c1c960868563bcf223ba0bc88999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220865 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#773101}
-
Matthias Körber authored
Change-Id: I3147cce49be27f644aec762e48f1c1793d73f4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220008Reviewed-by:
-
