- 10 May, 2018 40 commits
-
-
Xiaohan Wang authored
Bug: 840586 Change-Id: I0d91bde150d6e3755df3a3577862149298eaa61f Reviewed-on: https://chromium-review.googlesource.com/1050934Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#557469}
-
Fumitoshi Ukai authored
release clobber debug clobber debug Bug: 835731 Change-Id: I253025e12c36fe2ee6bad941721bc79658de8062 Reviewed-on: https://chromium-review.googlesource.com/1029569Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#557468}
-
Hiroki Nakagawa authored
According to a recent spec change, this CL changes the default credentials mode on WorkletOptions from 'omit' to 'same-origin'. Spec issue: https://github.com/w3c/css-houdini-drafts/issues/756 Feature dashboard: https://www.chromestatus.com/feature/6383899018002432 Bug: 838540 Change-Id: I341f9c61e11387fe7192d75e616b4003fa36128f Reviewed-on: https://chromium-review.googlesource.com/1051307Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#557467}
-
Adam Rice authored
The http/tests/websocket/workers/no-onmessage-in-sync-op.html layout test had a 2 second busy loop. Reduce it to 0.2 seconds. It would be possible to avoid the busy loop by using sync XHR instead, but this might change the semantics of the test. It is particularly important not to change any semantics as this is a regression test for https://bugs.webkit.org/show_bug.cgi?id=76521. The length of the delay has been removed from the test output so that the expectations won't need to be changed if the delay is changed again. No other changes have been made to the test. In particular, it hasn't been updated to a modern style. BUG=386044 Change-Id: I38c317d89b96e7e3729225603c742d99359959e9 Reviewed-on: https://chromium-review.googlesource.com/1046686 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#557466}
-
Matt Falkenhagen authored
This CL makes it so ServiceWorkerSubresourceLoaderFactory uses a factory created from a ChildURLLoaderFactoryBundle rather than the direct network factory for "network fallback" after service worker does not provide a response to a FetchEvent. The direct network factory didn't work in the case of chrome-extension:// URLs, since network service does not understand such URLs. To create the fallback factory, we use the default ChildURLLoaderFactoryBundle of the RenderFrameImpl, except remove the "default factory" from that bundle. The default factory can be something like the AppCache loader factory, which we don't want to hit when performing network fallback. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If6ae1d6fc161cae8ec4574417a0d8954215f878e Bug: 836129 Reviewed-on: https://chromium-review.googlesource.com/1032354 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#557465}
-
Hitoshi Yoshida authored
- Drops two unnecessary TraceWrappers(). They just call TW() of parent classes. - Add a trace in Trace(). Bug: 581412 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I726fcea1872488ab98541b8a7cce233793815da8 Reviewed-on: https://chromium-review.googlesource.com/1053336Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#557464}
-
Maksim Sisov authored
This is a tiny patch, which adds a check if platform_window has already been destroyed by the time ::Close was called. Change-Id: I3413fae38f9574cea4f806755e6738289efda1f5 Reviewed-on: https://chromium-review.googlesource.com/1051827Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#557463}
-
John Abd-El-Malek authored
The FrameTreeNode's initial RenderFrameHost might change during navigations if a cross-origin redirect happens. So caching the initial RPH/RFH IDs would be incorrect. For the navigation case, the only thing that is needed is the BrowserContext so pass that in directly. The security check (AllowExtensionResourceLoad) isn't needed for navigations, as that's done in ExtensionNavigationThrottle per the comment in the file. This makes ExtensionURLLoaderFactory pass in -1 for the procss ID when the network service is running, to match what ExtensionProtocolHandler does for the non-network-service case. Bug: 840600 Change-Id: Ie23ed9e78f69fd4a8bb7a1a4aa964303db2102cf Reviewed-on: https://chromium-review.googlesource.com/1050812 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#557462}
-
Ryo Hashimoto authored
BUG=837161 TEST=build Change-Id: I99299e9f4066dd445458325c264743211e1c6645 Reviewed-on: https://chromium-review.googlesource.com/1051546Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#557461}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/563f26415461..baf831d074e7 $ git log 563f26415..baf831d07 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 angle-skia-autoroll Roll third_party/externals/angle2/ 7348fc5b9..a932b6b51 (4 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I61735a6ac2b8b81878f2bc070734577f1344e5ff Reviewed-on: https://chromium-review.googlesource.com/1053561Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557460}
-
Antonio Gomes authored
Apart from the actual migration, CL also adapts the existing unittests (namely GoogleURLTrackerTest, from components_unittests target) to work with the SimpleURLLoader machinery. Some remarks on the unittests' migration: - GetFetcher calls in the unittests were replaced by handled_request. - MockSearchDomainCheckResponse: rather than calling the URLFetcherDelegate method, it queue a server response to be served upon request. - We call MockSearchDomainCheckResponse before instantiating any request. - RequestServerCheck and FinishSleep both can trigger SimpleURLLoader download. Hence both methods add a loop in order to make sure a request is handled by the server (or failed). Additionally, CL removes the dependency of URLRequestContextGetter from GoogleURLTrackerClient. Derived classes are also updated accordingly. Last, some unittests, namely browser_tests' ErrorPageAutoReloadTest, stared to track additional "google url tracker" loads from its Interceptor. Tests are updated to skip counting such loads. BUG=773295 TBR=treib@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I416c6254876ce6a54ee239ff63cd35fc300d5053 Reviewed-on: https://chromium-review.googlesource.com/1042825 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#557459}
-
Stuart Langley authored
Some cleanup work for components/drive/chromeos/ briging it in line with recomended practices/c++ modernization. - Use ThreadChecker macros. - s/DCHECK(!callback.is_null())/DCHECK(callback)/ - clang tidy: -- modernize-use-default -- modernize-make-unique This CL introduces NO logic changes. Bug: 841659 Change-Id: Ic6f8829a983b14e955c858ed864dcadbc41f9506 Reviewed-on: https://chromium-review.googlesource.com/1053335 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#557458}
-
Matt Falkenhagen authored
Revert "service worker: Make provider hosts for reserved clients first-class members of SWContextCore." This reverts commit 0ce272e0. Reason for revert: Causes crashes on layout tests on MSAN. Original change's description: > service worker: Make provider hosts for reserved clients first-class members of SWContextCore. > > Before this CL, provider hosts for documents that were still undergoing > navigation (i.e., hosts for "reserved clients"), were not owned by > SWContextCore. Instead they were owned by > ServiceWorkerNavigationHandle* and added to SWContextCore after > navigation commit and the renderer ACKs back an OnProviderCreated IPC. > > This CL makes SWContextCore own such provider hosts. This means that > users of SWContextCore will start needing to be aware of reserved vs > ready clients. There are some motivations: > - Sometimes we need to do operations on reserved clients. For example, > the linked bug happens because a new registration can't find reserved > clients. > - SWContextCore already implicitly knows about reserved clients, since > GetProviderByClientUUID can return them. This is a bit of a confusing > inconsistency. > - The spec has evolved to make "reserved clients" a concept, so > it's generally useful to have them clearly defined to more clearly > match the spec algorithms. > > This CL isn't expected to have a behavior change but clears the way > to fixing the linked bug. > > Bug: 841070 > Change-Id: I31ba40029e1b7247f41d69abcf4fa6ef97300a0d > Reviewed-on: https://chromium-review.googlesource.com/1051145 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557423} TBR=falken@chromium.org,kinuko@chromium.org,clamy@chromium.org,shimazu@chromium.org Change-Id: I72b3f4360b764d3d5882582d8ef0f7e07ad96e46 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 841070 Reviewed-on: https://chromium-review.googlesource.com/1053469Reviewed-by:
-
James Cook authored
It just provides backing for ScreenMus; it doesn't really manage displays (and we already have display::DisplayManager). Rename ui::ws2:DisplayManagerMus to ScreenProvider. Leave ui::ws::UserDisplayManager as-is, since it may go away or get refactored soon. TBR=tsepez@chromium.org for renaming an existing mojom BUG=839592 TEST=services_unittests and views_mus_unittests Change-Id: I392f8f8c306e1a0b4497cd3ef455464359acbae5 Reviewed-on: https://chromium-review.googlesource.com/1053170 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
This reverts commit 239d8abb. Reason for revert: Speculative revert for test failures on MSAN bots. https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/7078 Original change's description: > cros: Add fingerprint UI to views lock screen > > This CL adds some basic fingerprint UI to views lock screen to support > fingerprint fishfood. > The detailed specs are not ready and may be subject to change. So it > may need to be polished in the future for adding animation, adjusting > styles etc. > > Current mocks: > https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdwfnbqy2eSi/files/MCHm5Lyh8lQ6SZ3vjzwd3Uo8wMSJbxAVNpw > > Bug: 835357 > Change-Id: Ifab074ca53bb0a8a5128d9b3da6139d68bb03b09 > Reviewed-on: https://chromium-review.googlesource.com/1047958 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557254} TBR=xiyuan@chromium.org,tsepez@chromium.org,xiaoyinh@chromium.org Change-Id: Ibc27fa0b9eb9807428023af99a3cd98ae8741f0d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835357 Reviewed-on: https://chromium-review.googlesource.com/1053468Reviewed-by:
-
Christopher Lam authored
See go/closure-compile-gn for details. This CL converts the Closure Compilation of print preview from GYP to GN. It also fixes a number of incorrect annotations surfaced by the migration. A local closure compile can be run by setting closure_compile = true in args.gn, and then running ninja -C out/Default webui_closure_compile. A more localized compile may look like: ninja -C out/Default chrome/browser/resources/print_preview:closure_compile Bug: 632206 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifecaf4ac8f9f082060e28acb3eac613a1d98a931 Reviewed-on: https://chromium-review.googlesource.com/1041605Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#557454}
-
Fady Samuel authored
This is no longer used. Bug: 672962 Change-Id: Ib97ca682e2c5eb1252972af9068da5afbff9fb81 TBR: piman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1053588Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#557453}
-
Kurt Horimoto authored
FullscreenUIElements only need data accessible from FullscreenAnimator's public interface. Subclasses only differed in deciding the final progress value, which is always either 0.0 or 1.0. This CL consolidates the existing animators into a more flexible animator superclass. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I83b5c47037f77af41cea538bbc663e355f54e253 Reviewed-on: https://chromium-review.googlesource.com/1052809 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557452}
-
Eugene But authored
WaitForCondition is a wrapper around deprecated base::test::ios::WaitUntilCondition, which uses DCHECK. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7a85ff395e2cb8edae9b56d4db7998d9c64ae475 Reviewed-on: https://chromium-review.googlesource.com/1053184 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#557451}
-
Raymes Khoury authored
This fixes 2 nullptr dereferences. The first arises because we don't sanity check the permission type received in the PermissionService. We don't expect to receive protected media requests on non-android platforms so a check is added for that. The second is because the default implementation of ResetPermission in PermissionContextBase won't work for content settings types which don't have a registered ContentSettingsType. We add a check for that case before resetting the permission. Bug: 839194, 839221 Change-Id: I0dbb9930a7cc5e459b99e8f937791846fd0db83b Reviewed-on: https://chromium-review.googlesource.com/1045962Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#557450}
-
Yoichi Osato authored
This patch changes NGTextFragmentPainter to use NGPhysicalTextFragment::LocalRect instead of computing it itself for consistency. Bug: 837521 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I52395834bd0c141873aa792f9f1805ee1a1fdad1 Reviewed-on: https://chromium-review.googlesource.com/1051427Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#557449}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5623aeebe84f..7c3ff1311a45 $ git log 5623aeebe..7c3ff1311 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 tikuta Introduce GIT_TRACE_PERFORMANCE Created with: roll-dep src/third_party/depot_tools BUG=chromium:840592 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I1f3b5cde09b19cb3a7137f4245f9074482fd50af Reviewed-on: https://chromium-review.googlesource.com/1053157Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557448}
-
Takumi Fujimoto authored
- Add CastDialogModel struct that contains dialog header and sink info. - Add CastDialogView class that implements the dialog UI. - Add CastDialogController interface, through which the dialog will communicate with Media Router. The interface will be implemented by MediaRouterViewsUI. The code paths to open and send data to the dialog will be added in a later CL (WIP): crrev.com/c/1010410/6..8 Screenshots (colors/dimensions TBD): https://drive.google.com/open?id=1M1R9jO-VHEO18aA3pTpoQBI4FHMU5MEf https://drive.google.com/open?id=1dRGkINNrk8etvx8_SSZko13uu3MQRfER Bug: 826089 Change-Id: I7f965383d427d347bf8063ed1cb16296a0044aa2 Reviewed-on: https://chromium-review.googlesource.com/1020231 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#557447}
-
Abhishek Arya authored
R=mmoroz@chromium.org,liaoyuke@chromium.org Bug: 784464, 841513 Change-Id: Ia592f2c0145d9117e6c59d14c6b1685d104429c0 Reviewed-on: https://chromium-review.googlesource.com/1053161Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#557446}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1fcac0556947..563f26415461 $ git log 1fcac0556..563f26415 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Ifb767af53ec83f0ecd8c2ec2b3f4e88661438a9b Reviewed-on: https://chromium-review.googlesource.com/1053547 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Cathy Li authored
Change-Id: I987af5542f66c58a89013b2ceffdf7a31d8fd33c Reviewed-on: https://chromium-review.googlesource.com/1053348Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#557444}
-
https://webrtc.googlesource.com/src.git/+log/e1f222e5c5a4..e53ac0463daa $ git log e1f222e5c..e53ac0463 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia28749f2a57e087706cd0e59d69c07e41c8566f6 Reviewed-on: https://chromium-review.googlesource.com/1053550 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557443}
-
Tetsui Ohkubo authored
This CL adds ChromeOS.SystemTray.ToggleExpanded metrics to UnifiedSystemTray. The value records if the system tray bubble is expanded or collapsed by the button, or by touch gesture. TEST=manual(chrome://histograms) BUG=none Change-Id: I55eb917297a00eecd4d07d74e5d346bc5db111fc Reviewed-on: https://chromium-review.googlesource.com/1049465Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#557442}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I633c319df06580406337b56d8c86da04dd5f01bd Reviewed-on: https://chromium-review.googlesource.com/1053567Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#557441}
-
Yuri Wiitala authored
The LoopbackStream is an audio::InputStream that provides the result of looping-back and mixing-together all current and future audio output streams belonging to the same "group." An example of this would be for tab capture, where all output streams from one tab are recorded and then re-mixed into a single capture stream. Bug: 824019 Change-Id: I3374182798452bbf9d8688e318dc0546d3630f5e Reviewed-on: https://chromium-review.googlesource.com/1041661 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557440}
-
codeimpl authored
std::make_unique<Type>(...) and base::WrapUnique<new Type(...)) are equivalent but std::make_unique should be preferred, because it is harder to use unsafely than base::WrapUnique in background_sync. Ref: https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Prefer-MakeUnique-to-WrapUnique Bug: None Change-Id: Ibc1f9455206ffb469f63a7e2529a71e678b54757 Reviewed-on: https://chromium-review.googlesource.com/1034050Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#557439}
-
Ben Wells authored
This metric will allow us to know how many people are running the setup flow and what the results of the flow are. Bug: 703927 Change-Id: I1d4fef03f0c88714b4e2f648cc43540ff0e510a6 Reviewed-on: https://chromium-review.googlesource.com/1051133 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Chong Zhang authored
Perf Dashboard has some issues handling large test results (see bug). This patch tentatively changed the benchmark to only upload _diff charts (which is consider most useful) to get the graph running, and we should revert the benchmark back after the issue has been fixed. Bug: 840524 Change-Id: I4e87da8405bf102f16c76ccad28107b3c9b87be7 Reviewed-on: https://chromium-review.googlesource.com/1052674Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557437}
-
Jinsuk Kim authored
The call order of |super.onConfigurationChanged| doesn't seem to matter. This CL deletes the interface method from ContentViewCore.InternalAccessDelegate and let the embedders call it directly. Bug: 598880 Change-Id: If0ef9eeb583036846130accbbdd0e71b19ac48b6 Reviewed-on: https://chromium-review.googlesource.com/1053327Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#557436}
-
Tetsui Ohkubo authored
As described in the design doc, old SystemTray class is going to be replaced by UnifiedSystemTray class. Model variables of SystemTrayItems will be decoupled into SystemTrayModel, and tray icons will be implemented in UnifiedSystemTray by obseving the models. This CL adds power icon to UnifiedSystemTray button. In order to do this, this CL changes * PowerTrayView to observe PowerStatus directly. * Move PowerTrayView declaration to tray_power.h. * TrayItemView to support null owner(). * Embed PowerTrayView in UnifiedSystemTray. Screenshot: http://screen/Wi1PioeB47D Design doc: go/cros-qs-restyling TEST=manual BUG=836134 Change-Id: I5719cf004b258b2498743afd9c775085aae0e068 Reviewed-on: https://chromium-review.googlesource.com/1049472Reviewed-by:
-
Noel Gordon authored
Break test changeTracks into three separate tests, rather than do it all in one test. And hopefully, improve test speed and robustness by eliminating the interrupted play() -> pause() problem, which was due due to not waiting for the play button aria-label state change. changeTracks Clicks on the "next" button and tests that the "next" track plays. Move what was formerly in this test, to the new tests. changeTracksPlayList Expands the track list by clicking on the the play-list button and clicks track 0. Test that the expected audio track (0) plays. changeTracksPlayListIcon Expands the track list by clicking on the the play-list button and clicks the track 1 'Play' icon. Test that the expected audio track (1) plays. Add more comments to the togglePlayState and changeVolumeLevel tests and comments describing the new tests. Test: browser_tests --gtest_filter=AudioPlayerBrowserTest.ChangeTr* Bug: 835626 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibfb771ab7b276fbb64e2f40c5d17221a95244d15 Reviewed-on: https://chromium-review.googlesource.com/1051306Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#557434}
-
Ran Ji authored
This cl made two changes: 1. If a url is opened from WebAPK through window.open(), and that url is within the current WebAPK scope. Open it in CCT instead of using WebAPK 2. If a CCT is opened by a WebAPK, and the CCT redirects to a url within the WebAPK scope, stay in the CCT instead of using WebAPK to open the url. Bug: 831806, 771418 Change-Id: Ibf522b3b49599ec8bbb76f515f3b96b07707b56d Reviewed-on: https://chromium-review.googlesource.com/1008735 Commit-Queue: Ran Ji <ranj@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557433}
-
Aleks Totic authored
Unfortunatelly, handling scrollbars in NG is delayed to next milestone. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I50ba6eb28ed040da2cbb8857c1b3eb84c3a609a3 Reviewed-on: https://chromium-review.googlesource.com/1053298Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#557432}
-
Tsuyoshi Horo authored
We are trying to show SignedExchange related information in DevTools. https://bit.ly/2HXVbCU After this CL, the certificate request of signed exchange is displayed. This CL depends on https://crrev.com/c/1029750 Bug: 830505 Change-Id: Ia431b5bb889fa5f89754f11eb2e54dbf91d0e4fe Reviewed-on: https://chromium-review.googlesource.com/1029755 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#557431}
-
Joel Hockey authored
Implement fileManagerPrivate.mountCrostiniContainer to call Crostini Restart. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7a6326e0faa92c48cd1014ce426b1a19f0b35d0d Reviewed-on: https://chromium-review.googlesource.com/1049988 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
-
