GitLab

Merge these redundant classes and their unit tests.
Do not try_mirroring_arrow with dummy anchor rects.
Deprecate unused allow_bubble_offscreen bubble flag.
Replace GetArrowLocation virtual with simple setter/getter pair.
Return anchor view bounds in BubbleDelegateView::GetAnchorRect.
Other refactoring and simplification.

BUG=106050
TEST=Bubbles are anchored correctly with their arrows in the right location.

Review URL: http://codereview.chromium.org/8870003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114598 0039d316-1c4b-4281-b951-d872f2087c98

This removes a lot of boilerplate with checking host_ (which was never
[locally] thread-safe, anyway).

Make as many things in SyncBackendHost private as possible.

BUG=103410,107279
TEST=


Review URL: http://codereview.chromium.org/8938013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:17585
TEST=browser_tests --gtest_filter=SystemPrivateChromeOsApiTest.GetUpdateStatus

Review URL: http://codereview.chromium.org/8747003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114596 0039d316-1c4b-4281-b951-d872f2087c98

Move D&D client stuff into client namespace.
Provide some convenient getters/setters.

BUG=none
TEST=existing automation
TBR=sky
Review URL: http://codereview.chromium.org/8949010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114595 0039d316-1c4b-4281-b951-d872f2087c98

When VarTracker remove PP_Var from VarMap, it release its Var object
if needed, but never reset var_id stored in Var object. Then, if Var's
reference count is not 1, Var continue to exist with invalid var_id until
the last reference is released.

BUG=87310
TEST=ui_tests, browser_tests, nacl_integration

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114384

Review URL: http://codereview.chromium.org/8872065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79722
TEST=none


Review URL: http://codereview.chromium.org/8952002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114591 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=new tests


Review URL: http://codereview.chromium.org/8872044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114590 0039d316-1c4b-4281-b951-d872f2087c98

Add loop to _VerifySearchInPDFURL to try FindInPage 10 times and re-raise
the exception on the final loop. This is required because
_GetResultFromJSONRequest appears to timeout if called before the PDF has
loaded.

Add timeout parameter to pyauto.FindInPage to be passed to
_GetResultFromJSONRequest to speed up the loop in _VerifySearchInPDFURL
from the default of 45 seconds to 1 second.

Re-enable test on Mac.

BUG=107448, 70927, 93956

Review URL: http://codereview.chromium.org/8913012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114589 0039d316-1c4b-4281-b951-d872f2087c98

This change has been made at the parent class level, where the rendering
of the BookmarkButtonCell is implemented. It aligns the favicon with
NSImageLeft if there is no title.

A test has also been added to check for the differences in image positioning between these two classes.

BUG=105276


Review URL: http://codereview.chromium.org/8792001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114588 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107063
TEST=none

Review URL: http://codereview.chromium.org/8926001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114586 0039d316-1c4b-4281-b951-d872f2087c98

Some NaClLog invocations were left with detail level 0, which gets
printed by default.  This CL just increases some of these, so that
NACLVERBOSITY environment variable would have to be set to see events
such as NaCl module crash log messages that occur while generating the
'crashed' event.

BUG= None
TEST= None


Review URL: http://codereview.chromium.org/8929022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114585 0039d316-1c4b-4281-b951-d872f2087c98

Add a component installer for Portable NaCl. Registration of installer is hidden behind a commandline flag '--enable-pnacl'.

Still some of TODOs: finalize the metadata associated with the CRX, figure out what to do when a NaCl plugin needs Pnacl, but it's not there yet.


BUG= http://code.google.com/p/nativeclient/issues/detail?id=2365
TEST= none yet, only manually test:

(1) put a pnacl omaha config in the omaha sandbox, pointing at a crx.

(2) run out/Debug/chrome --user-data-dir=/tmp/temp_profile/ --enable-pnacl --component-updater-debug=fast-update --apps-gallery-update-url=http://omaha.sandbox.google.com/service/update2/crx

check /tmp/temp_profile/PNaCl/0.1.0.X is installed after a few seconds.

restart chrome, check that PathService registers /tmp/temp_profile/PNaCl/0.1.0.X soonish.


Review URL: http://codereview.chromium.org/8348026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8907052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114583 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8490001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles


Review URL: http://codereview.chromium.org/8680040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114581 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114580 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107047
TEST=trybots

Review URL: http://codereview.chromium.org/8954001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114579 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:24259
TEST=None
Review URL: http://codereview.chromium.org/8957002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114576 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:24265
TEST=None
Review URL: http://codereview.chromium.org/8951003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114575 0039d316-1c4b-4281-b951-d872f2087c98

RendererAccessibility::PostAccessibilityNotification function while processing the WebAccessibilityNotificationLayoutComplete 
notification from webkit. This function recursively calls itself with the WebAccessibilityNotificationLayoutComplete
notification leading to infinite recursion.

Fix is to check whether the incoming notification is WebAccessibilityNotificationLayoutComplete before the recursive
call.

BUG=none
TEST=chrome frame tests should pass on the IE6 builder.
Review URL: http://codereview.chromium.org/8952005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114573 0039d316-1c4b-4281-b951-d872f2087c98

This is primarily used by the sync typed URL performance tests.  This
method helps stabilize the perf numbers since there's only a single
notification that is emitted (instead of one per URL).

BUG=107040
TEST=


Review URL: http://codereview.chromium.org/8910024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114572 0039d316-1c4b-4281-b951-d872f2087c98

This time, we allow the StackingClient to be optional. If not specified, unparented windows will just be added to the RootWindow.

BUG=none
TEST=existing automation

Review URL: http://codereview.chromium.org/8916020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8898036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114562 0039d316-1c4b-4281-b951-d872f2087c98

Set aura window focus in NativeWidgetAura::ClearNativeFocus only if the focus is owned by child window.

 This was causing a focus to be stolen when non active window calls ClearNativeFocus.

BUG=114477
TEST=OmniboxViewTest.PopupAccelerators passes with this change


Review URL: http://codereview.chromium.org/8931022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114561 0039d316-1c4b-4281-b951-d872f2087c98

1. Get rid of the dummy AtlModule registration in the chrome frame net test suite. This is no longer needed
   as there is an Atlmodule instance instantiated by the content code.

2. The TestSuite and NetTestSuite classes now provide special protected constructors which allow
   test instances to control whether an AtExitManager instance is created for the duration of the
   test. The ChromeFrame net test suite reuses the AtExitManager instance created in BrowserMain.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435

BUG=105435
TEST=ChromeFrame net tests should now run on the builders.
Review URL: http://codereview.chromium.org/8907054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114559 0039d316-1c4b-4281-b951-d872f2087c98

Resubmitting reverted CL with fix
BUG=chromium-os:23757
TEST=manual
Review URL: http://codereview.chromium.org/8883046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114558 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8909012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114557 0039d316-1c4b-4281-b951-d872f2087c98

Requiring developers to update their extensions to manifest_version 2 when
loading them as unpacked extensions was more disruptive than we anticipated.
We want to make sure our documentation is in better shape and that folks have a
chance to move to manifest_version 2 on their own schedule before flipping this
switch.

Review URL: http://codereview.chromium.org/8907056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114556 0039d316-1c4b-4281-b951-d872f2087c98

Copy the url onto the stack.

BUG=99242
TEST=none


Review URL: http://codereview.chromium.org/8907055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114555 0039d316-1c4b-4281-b951-d872f2087c98

linux_redux does not have safe_browsing enabled in the GYP variables,
which causes all of chrome/browser/safe_browsing to be excluded from
the chrome_browser target - including safe_browsing_tab_observer.[cc,h]

This enables a stub SafeBrowsingTabObserver to be compiled when
safe_browsing==0, fixing the linker errors from TabContentsWrapper having
a SafeBrowsingTabObserver member.

BUG=none

Review URL: http://codereview.chromium.org/8909017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114553 0039d316-1c4b-4281-b951-d872f2087c98

This will fix vista boxes with legacy XP drivers and make ANGLE work if D3D9Ex is disabled.
Review URL: http://codereview.chromium.org/8913015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107222
TEST=see bug

Review URL: http://codereview.chromium.org/8918022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114550 0039d316-1c4b-4281-b951-d872f2087c98

Eventually it would be great to have something more user friendly like 
chrome:net-internals, but this is at least a start.

BUG=30812
TEST=Run chrome with --vmodule=extension_updater=2, then try doing an 
extension update check (eg from chrome://extensions page, turn on development
mode and then hit the update now button). You should see some debugging output
on the console.


Review URL: http://codereview.chromium.org/8929019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114549 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8915016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114548 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8949003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114547 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114546 0039d316-1c4b-4281-b951-d872f2087c98

This is a checkpoint commit. It does the following:

- if Write() blocks, calls onEvent() when the underlying socket finishes its work.
- Demonstrates a working framework for sending events back to JS.

It does NOT do any of the following:

- Prove that the above statements are true.

In order to cause a UDP socket to block, we pretty much have to mock it, and I determined that I'd have to refactor my Socket class to let me put in a ClientSocketFactory for testing, which will then let me work DelayedSocketData in net/socket/socket_test_util.h into the mix and simulate Write blockage. After discussion with Antony, we agreed to break up this work into this CL and then a refactor/mock CL, which I'm working on now.

BUG=106802
TEST=none (see above).

Review URL: http://codereview.chromium.org/8896013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114544 0039d316-1c4b-4281-b951-d872f2087c98

- Add IPv6 support to talk_base::SocketAddress 
- Refactored PeerConnectionFactory interface 
- Bug fixes

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/8914025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114543 0039d316-1c4b-4281-b951-d872f2087c98

The nacl_helper program uses content::MakeSharedMemorySegmentViaIPC but
none of the other proxy functions in the same source file.  Some of those
functions refer to symbols that bring in a great deal of other code, e.g.
most of v8.  We don't want all that code linked into nacl_helper--it bloats
the binary by a factor of ten or so.

Moving the function out to its own file prevents the other dependencies
coming in unnecessarily.

BUG= http://code.google.com/p/chromium/issues/detail?id=106986
TEST= still builds and nacl_helper binary is much smaller

R=jam@chromium.org,bradchen@google.com

Review URL: http://codereview.chromium.org/8893009

TBR=mcgrathr@chromium.org
Review URL: http://codereview.chromium.org/8914026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114542 0039d316-1c4b-4281-b951-d872f2087c98

Avoid creating a temporary |gfx::Font| just to get its
name and size to pass it to Skia.

Note: There's room for further optimizations here, such
as caching, which I plan to look at in a future CL.

BUG=107394
TEST=Run aura and check that omnibox still looks fine. Run about:tracing and check that time used by this code is significantly decreased.

Review URL: http://codereview.chromium.org/8910004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114541 0039d316-1c4b-4281-b951-d872f2087c98